RE: ✗ Fi.CI.BAT: failure for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Illipilli, TejasreeX
Hi, https://patchwork.freedesktop.org/series/128186/ - Re-reported . Thanks, Tejasree -Original Message- From: Intel-gfx On Behalf Of Imre Deak Sent: Thursday, January 4, 2024 9:31 PM To: intel-gfx@lists.freedesktop.org; i915-ci-in...@lists.freedesktop.org Subject: Re: ✗ Fi.CI.BAT: fail

✓ Fi.CI.BAT: success for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) URL : https://patchwork.freedesktop.org/series/128186/ State : success == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128186v2 Sum

✗ Fi.CI.IGT: failure for drm/edid: prefer forward declarations over includes in drm_edid.h (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/edid: prefer forward declarations over includes in drm_edid.h (rev2) URL : https://patchwork.freedesktop.org/series/127695/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14080_full -> Patchwork_127695v2_full

RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-04 Thread Almahallawy, Khaled
Thank you for the patch Tested-by: Khaled Almahallawy -Original Message- From: Intel-gfx On Behalf Of Arun R Murthy Sent: Wednesday, January 3, 2024 1:07 AM To: intel-gfx@lists.freedesktop.org; Nikula, Jani ; Deak, Imre Subject: [PATCH] drm/i915/display/dp: 128/132b DP-capable with S

[PATCH i-g-t] tests/perf_pmu: Restore sysfs freq in exit handler

2024-01-04 Thread Vinay Belgaumkar
Seeing random issues where this test starts with invalid values. Ensure that we restore the frequencies in case test exits early due to some system issues. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9432 Signed-off-by: Vinay Belgaumkar --- tests/intel/perf_pmu.c | 53 +++

✗ Fi.CI.BAT: failure for Update bxt_sanitize_cdclk() for Xe2_LPD (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: Update bxt_sanitize_cdclk() for Xe2_LPD (rev2) URL : https://patchwork.freedesktop.org/series/128175/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128175v2 Summary ---

Re: [PATCH] drm/i915: clear the QGV mask set by GOP while booting

2024-01-04 Thread Sworo, George D
On Thu, 2024-01-04 at 11:04 -0800, george.d.sw...@intel.com wrote: > From: George D Sworo > > GOP driver in the firmware is masking the QGV points except the one > which can > provide high Bandwidth required for panel. > > On boot to the OS the mask is already set, and is not cleared > anywhere

✗ Fi.CI.IGT: failure for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3)

2024-01-04 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3) URL : https://patchwork.freedesktop.org/series/123813/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14080_full -> Patchwork_123813v3_full

✓ Fi.CI.BAT: success for drm/edid: prefer forward declarations over includes in drm_edid.h (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/edid: prefer forward declarations over includes in drm_edid.h (rev2) URL : https://patchwork.freedesktop.org/series/127695/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_127695v2 ==

Re: [PATCH 4/4] drm/i915/cdclk: Re-use bxt_cdclk_ctl() when sanitizing

2024-01-04 Thread Matt Roper
On Thu, Jan 04, 2024 at 03:48:34PM -0800, Matt Roper wrote: > On Thu, Jan 04, 2024 at 12:21:50AM -0300, Gustavo Sousa wrote: > > That's the function responsible for deriving that register's value; use > > it. > > > > Signed-off-by: Gustavo Sousa > > Reviewed-by: Matt Roper Forgot to mention...

Re: [PATCH 4/4] drm/i915/cdclk: Re-use bxt_cdclk_ctl() when sanitizing

2024-01-04 Thread Matt Roper
On Thu, Jan 04, 2024 at 12:21:50AM -0300, Gustavo Sousa wrote: > That's the function responsible for deriving that register's value; use > it. > > Signed-off-by: Gustavo Sousa Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 26 +++--- > 1 file chan

✗ Fi.CI.IGT: failure for series starting with [1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER URL : https://patchwork.freedesktop.org/series/128219/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14080_full -> Patchwork_128219v1_full ===

✓ Fi.CI.BAT: success for series starting with [1/3] drm/nouveau: include drm/drm_edid.h only where needed

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/nouveau: include drm/drm_edid.h only where needed URL : https://patchwork.freedesktop.org/series/128224/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128224v1 =

Re: [PATCH 3/4] drm/i915/cdclk: Reorder bxt_sanitize_cdclk()

2024-01-04 Thread Matt Roper
On Thu, Jan 04, 2024 at 12:21:49AM -0300, Gustavo Sousa wrote: > Make the sequence of steps more logical by grouping things related to > the check on the value of CDCLK_CTL into a single "block". Also, this > will make an upcoming change replacing that block with a single function > call easier to

Re: [PATCH 2/4] drm/i915/cdclk: Extract bxt_cdclk_ctl()

2024-01-04 Thread Matt Roper
On Thu, Jan 04, 2024 at 12:21:48AM -0300, Gustavo Sousa wrote: > This makes the code better readable and will be used later in > bxt_sanitize_cdclk(). > > Signed-off-by: Gustavo Sousa Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 57 +- > 1 f

Re: [PATCH 1/4] drm/i915/xe2lpd: Update bxt_sanitize_cdclk()

2024-01-04 Thread Matt Roper
On Thu, Jan 04, 2024 at 12:21:47AM -0300, Gustavo Sousa wrote: > With Xe2_LPD, there were changes to the way CDCLK_CTL must be > programmed. Those were reflected on _bxt_set_cdclk() with commit > 3d3696c0fed1 ("drm/i915/lnl: Start using CDCLK through PLL"), but > bxt_sanitize_cdclk() was left out.

✗ Fi.CI.BAT: failure for drm/i915: clear the QGV mask set by GOP while booting

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: clear the QGV mask set by GOP while booting URL : https://patchwork.freedesktop.org/series/128223/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128223v1 Summary ---

✗ Fi.CI.IGT: failure for drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: don't make assumptions about intel_wakeref_t type URL : https://patchwork.freedesktop.org/series/128218/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14080_full -> Patchwork_128218v1_full =

Re: [PATCH 1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Matt Roper
On Thu, Jan 04, 2024 at 07:43:46PM +0200, Jani Nikula wrote: > Display code should not care about graphics version. > > Signed-off-by: Jani Nikula For the series: Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

✓ Fi.CI.BAT: success for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3)

2024-01-04 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3) URL : https://patchwork.freedesktop.org/series/123813/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_123813v3 Summary -

✗ Fi.CI.SPARSE: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3)

2024-01-04 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3)

2024-01-04 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim checkpatch failed a0a6446af902 drm/i915: Enable Wa_16019325821 1410cfb541d6 drm/i915/guc: Add support for w/a KLV

✓ Fi.CI.IGT: success for series starting with [v4,1/3] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128214/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080_full -> Patchwork_128214v1_full ===

✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER URL : https://patchwork.freedesktop.org/series/128219/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128219v1 =

✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER URL : https://patchwork.freedesktop.org/series/128219/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separ

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Andi Shyti
Hi Tvrtko, [1] > > + /* > > +* Loop over all available slices and assign each a user engine. > > +* > > +* With 1 engine (ccs0): > > +* slice 0, 1, 2, 3: ccs0 > > +* > > +* With 2 engines (ccs0, ccs1): > > +* slice 0, 2: ccs0 > > +* slice 1, 3: ccs1 > > +

✓ Fi.CI.BAT: success for drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: don't make assumptions about intel_wakeref_t type URL : https://patchwork.freedesktop.org/series/128218/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128218v1 Summa

[RESEND] drm/edid: prefer forward declarations over includes in drm_edid.h

2024-01-04 Thread Jani Nikula
There's no need to include either linux/hdmi.h or drm/drm_mode.h. They can be removed by using forward declarations. While at it, group the forward declarations together, and remove the unnecessary ones. Signed-off-by: Jani Nikula --- include/drm/drm_edid.h | 12 +--- 1 file changed, 5

✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128214/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128214v1 Sum

Re: [PATCH] drm/i915/huc: Allow for very slow HuC loading

2024-01-04 Thread Daniele Ceraolo Spurio
On 1/2/2024 2:22 PM, john.c.harri...@intel.com wrote: From: John Harrison A failure to load the HuC is occasionally observed where the cause is believed to be a low GT frequency leading to very long load times. So a) increase the timeout so that the user still gets a working system even in

✗ Fi.CI.SPARSE: warning for series starting with [v4,1/3] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128214/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86

✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/3] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128214/ State : warning == Summary == Error: dim checkpatch failed 967606fce39b drm/i915: Disable DSB in Xe KMD -:38: WARNING:IS_ENABLED_CONFIG: IS_ENABLED(

[PATCH 3/3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2024-01-04 Thread Jani Nikula
hdmi-codec.h does not appear to directly need drm/drm_edid.h for anything. Remove it. There are some files that get drm/drm_edid.h by proxy; include it where needed. v2-v4: Fix build (kernel test robot ) Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: Marijn Suijten C

[PATCH 2/3] drm/hisilicon: include drm/drm_edid.h only where needed

2024-01-04 Thread Jani Nikula
Reduce the need for rebuilds when drm_edid.h is modified by including it only where needed. Cc: Xinliang Liu Cc: Tian Tao Cc: Xinwei Kong Cc: Sumit Semwal Cc: Yongqin Liu Cc: John Stultz Signed-off-by: Jani Nikula --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 - drivers/gpu/drm

[PATCH 1/3] drm/nouveau: include drm/drm_edid.h only where needed

2024-01-04 Thread Jani Nikula
Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 files when drm_edid.h is modified, while there are only a few files that actually need to include drm_edid.h. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula

✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128212/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128212v1 Sum

Re: [PATCH 2/4] drm/ttm: replace busy placement with flags v4

2024-01-04 Thread Zack Rusin
On Thu, Jan 4, 2024 at 10:05 AM Christian König wrote: > > From: Somalapuram Amaranath > > Instead of a list of separate busy placement add flags which indicate > that a placement should only be used when there is room or if we need to > evict. > > v2: add missing TTM_PL_FLAG_IDLE for i915 > v3:

✗ Fi.CI.SPARSE: warning for series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128212/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86

✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128212/ State : warning == Summary == Error: dim checkpatch failed 37112d90d4cb drm/i915: Disable DSB in Xe KMD -:38: WARNING:IS_ENABLED_CONFIG: IS_ENABLED(

[PATCH] drm/i915: clear the QGV mask set by GOP while booting

2024-01-04 Thread george . d . sworo
From: George D Sworo GOP driver in the firmware is masking the QGV points except the one which can provide high Bandwidth required for panel. On boot to the OS the mask is already set, and is not cleared anywhere in the i915 driver even though sagv is enabled. This means Pcode is unable to switc

Re: [PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-04 Thread Andrzej Hajda
On 04.01.2024 17:46, Jani Nikula wrote: intel_wakeref_t is supposed to be a mostly opaque cookie to its users. It should only be checked for being non-zero and set to zero. Debug logging its actual value is meaningless. Switch to just debug logging whether the async_put_wakeref is non-zero. T

[PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160

2024-01-04 Thread John . C . Harrison
From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/

[PATCH v3 2/3] drm/i915/guc: Add support for w/a KLVs

2024-01-04 Thread John . C . Harrison
From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc.h

[PATCH v3 0/3] Enable Wa_14019159160 and Wa_16019325821 for MTL

2024-01-04 Thread John . C . Harrison
From: John Harrison Enable Wa_14019159160 and Wa_16019325821 for MTL RCS/CCS workarounds for MTL. v2: Fix bug in WA KLV implementation (offset not being reset to start of list). Add better comment to prep patch about how KLVs can be added. Add a module parameter override and disable the w/a by

[PATCH v3 1/3] drm/i915: Enable Wa_16019325821

2024-01-04 Thread John . C . Harrison
From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 19 +++---

[PATCH 2/5] drm/i915/dmc: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index b70502586ab9

[PATCH 3/5] drm/i915/hdcp: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. While at it, abstract the version check to a separate macro. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_hdcp_regs.h| 28 ++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 4/5] drm/i915/display: use IS_DISPLAY_VER instead of IS_GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_di

[PATCH 1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_

[PATCH 5/5] drm/i915/tv: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. It's only comments here, but update anyway. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_tv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i

Re: ✗ Fi.CI.IGT: failure for Resolve suspend-resume racing with GuC destroy-context-worker (rev13)

2024-01-04 Thread Teres Alexis, Alan Previn
On Thu, 2024-01-04 at 10:57 +, Patchwork wrote: > Patch Details > Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev13) > URL:https://patchwork.freedesktop.org/series/121916/ > State: failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12

Re: [PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-04 Thread Imre Deak
On Thu, Jan 04, 2024 at 06:46:00PM +0200, Jani Nikula wrote: > intel_wakeref_t is supposed to be a mostly opaque cookie to its > users. It should only be checked for being non-zero and set to > zero. Debug logging its actual value is meaningless. Switch to just > debug logging whether the async_put

Re: [PATCH v4 3/3] drm/xe: Use intel_wakeref_t in intel_runtime_pm functions

2024-01-04 Thread Jani Nikula
On Thu, 04 Jan 2024, José Roberto de Souza wrote: > Now intel_wakeref_t is a unsigned long and Xe KMD version of those > functions should use the same type, so changing from bool to > intel_wakeref_t. > > Cc: Maarten Lankhorst > Signed-off-by: José Roberto de Souza I don't think it was ever a b

Re: [PATCH v4 2/3] drm/xe: Fix definition of intel_wakeref_t

2024-01-04 Thread Jani Nikula
On Thu, 04 Jan 2024, José Roberto de Souza wrote: > i915 defines it as unsigned long so Xe should do the same to avoid > compilation warnings: > > CC [M] drivers/gpu/drm/i915/i915_gem.o > CC [M] drivers/gpu/drm/xe/i915-display/intel_display_power_well.o > In file included from ./include/drm/

Re: [PATCH v3 1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Jani Nikula
On Thu, 04 Jan 2024, José Roberto de Souza wrote: > Often getting DBS overflows when starting Xorg or Wayland compositors > when running Xe KMD. > Issue was reported but nothing was done, so disabling DSB as whole > until properly fixed in Xe KMD. > > v2: > - move check to HAS_DSB(Jani) > > v3: >

[PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-04 Thread Jani Nikula
intel_wakeref_t is supposed to be a mostly opaque cookie to its users. It should only be checked for being non-zero and set to zero. Debug logging its actual value is meaningless. Switch to just debug logging whether the async_put_wakeref is non-zero. The issue dates back to much earlier than comm

[PATCH v4 3/3] drm/xe: Use intel_wakeref_t in intel_runtime_pm functions

2024-01-04 Thread José Roberto de Souza
Now intel_wakeref_t is a unsigned long and Xe KMD version of those functions should use the same type, so changing from bool to intel_wakeref_t. Cc: Maarten Lankhorst Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 10 +- 1 file changed, 5 in

[PATCH v4 2/3] drm/xe: Fix definition of intel_wakeref_t

2024-01-04 Thread José Roberto de Souza
i915 defines it as unsigned long so Xe should do the same to avoid compilation warnings: CC [M] drivers/gpu/drm/i915/i915_gem.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_power_well.o In file included from ./include/drm/drm_mm.h:51, from drivers/gpu/drm/xe/xe_bo_ty

[PATCH v4 1/3] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread José Roberto de Souza
Often getting DSB overflows when starting Xorg or Wayland compositors when running Xe KMD. Issue was reported but nothing was done, so disabling DSB as whole until properly fixed in Xe KMD. v2: - move check to HAS_DSB(Jani) v3: - use IS_ENABLED(I915) check in intel_dsb_prepare() Link: https://gi

Re: [PATCH v3 1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Francois Dugast
On Thu, Jan 04, 2024 at 08:05:56AM -0800, José Roberto de Souza wrote: > Often getting DBS overflows when starting Xorg or Wayland compositors > when running Xe KMD. s/DBS overflows/DSB overflows/ > Issue was reported but nothing was done, so disabling DSB as whole > until properly fixed in Xe KM

[PATCH v3 2/2] drm/xe: Fix definition of intel_wakeref_t

2024-01-04 Thread José Roberto de Souza
i915 defines it as unsigned long so Xe should do the same. It did not break anything because the bool was being promoted to int by compiler. This was caught because it causing compilation warnings: CC [M] drivers/gpu/drm/i915/i915_gem.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_po

[PATCH v3 1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread José Roberto de Souza
Often getting DBS overflows when starting Xorg or Wayland compositors when running Xe KMD. Issue was reported but nothing was done, so disabling DSB as whole until properly fixed in Xe KMD. v2: - move check to HAS_DSB(Jani) v3: - use IS_ENABLED(I915) check in intel_dsb_prepare() Link: https://gi

Re: ✗ Fi.CI.BAT: failure for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Imre Deak
On Thu, Jan 04, 2024 at 02:08:32PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) > URL : https://patchwork.freedesktop.org/series/128186/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14078 ->

Re: [PATCH] drm/i915: clear the QGV mask set by GOP while booting

2024-01-04 Thread Sworo, George D
On Thu, 2024-01-04 at 10:13 +0200, Lisovskiy, Stanislav wrote: > On Wed, Jan 03, 2024 at 06:57:45PM -0800, George D Sworo wrote: > > From: George D Sworo > > > > GOP driver in the firmware is masking the QGV points except the one > > which can > > provide high Bandwidth required for panel. > > >

✓ Fi.CI.BAT: success for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/128207/ State : success == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128207v1 ===

✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/128207/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/128207/ State : warning == Summary == Error: dim checkpatch failed dcccad5f8257 drm/ttm: return ENOSPC from ttm_bo_mem_space -:35: WARNING:FROM_SI

✗ Fi.CI.BAT: failure for Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Patchwork
== Series Details == Series: Disable dynamic load balancing and support fixed balancing URL : https://patchwork.freedesktop.org/series/128202/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128202v1 Summar

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Tvrtko Ursulin
On 04/01/2024 14:35, Andi Shyti wrote: The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one

[PATCH 2/4] drm/ttm: replace busy placement with flags v4

2024-01-04 Thread Christian König
From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ERROR on drm-tip/drm-tip v4: fix some typos pointed

[PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2024-01-04 Thread Christian König
Try to fill up VRAM as well by setting the busy flag on GTT allocations. This fixes the issue that when VRAM was evacuated for suspend it's never filled up again unless the application is restarted. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++ 1 file

[PATCH 3/4] drm/ttm: improve idle/busy handling v2

2024-01-04 Thread Christian König
Previously we would never try to move a BO into the preferred placements when it ever landed in a busy placement since those were considered compatible. Rework the whole handling and finally unify the idle and busy handling. ttm_bo_validate() is now responsible to try idle placement first and then

[PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Christian König
Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index edf10618fe2b..8c1eaa74fa21 100644 --- a/drivers/

Rework TTMs busy handling

2024-01-04 Thread Christian König
Hi guys, I'm trying to make this functionality a bit more useful for years now since we multiple reports that behavior of drivers can be suboptimal when multiple placements be given. So basically instead of hacking around the TTM behavior in the driver once more I've gone ahead and changed the id

✗ Fi.CI.SPARSE: warning for Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Patchwork
== Series Details == Series: Disable dynamic load balancing and support fixed balancing URL : https://patchwork.freedesktop.org/series/128202/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Patchwork
== Series Details == Series: Disable dynamic load balancing and support fixed balancing URL : https://patchwork.freedesktop.org/series/128202/ State : warning == Summary == Error: dim checkpatch failed 478beb8ee33d drm/i915/gt: Support fixed CCS mode Traceback (most recent call last): File "

[PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Christian König
Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index edf10618fe2b..8c1eaa74fa21 100644 --- a/drivers/

[PULL] drm-misc-next-fixes

2024-01-04 Thread Maxime Ripard
Hi! Here's this week drm-misc-next-fixes PR Maxime drm-misc-next-fixes-2024-01-04: One fix for drm/plane to avoid a use-after-free and some additional warnings to prevent more of these occurences, a lock inversion dependency fix and an indentation fix for drm/rockchip, and some doc warning fixes

[PATCH v2 3/3] drm/i915/gt: Disable HW load balancing for CCS

2024-01-04 Thread Andi Shyti
The hardware is not able to dynamically balance the load between CCS engines. Wa_16016805146 suggests disabling it for all platforms. Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Niranjana Vishwanathapura Cc: Tejas Upadhyay --- drivers/gpu/drm/i915/gt/intel_gt_regs.h

[PATCH v2 2/3] drm/i915/gt: Allow user to set up the CSS mode

2024-01-04 Thread Andi Shyti
Now that the CCS mode is configurable, an interface has been exposed in the GT's sysfs set of files, allowing users to set the mode. Additionally, another interface has been added to display the number of available slices, named 'num_slices.' Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joona

[PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Andi Shyti
The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one CCS to all the slices. Based on a patch by

[PATCH v2 0/3] Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Andi Shyti
Hi, This series aims to disable the CCS hardware load balancing, as recommended by hardware directives in Wa_16016805146. In the meantime, we need to define and support a fixed CCS mode of balancing that can be configured by the user. Thanks, Andi Changelog: == v1 -> v2: - update comme

✗ Fi.CI.BAT: failure for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) URL : https://patchwork.freedesktop.org/series/128186/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128186v2 Sum

✗ Fi.CI.SPARSE: warning for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) URL : https://patchwork.freedesktop.org/series/128186/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) URL : https://patchwork.freedesktop.org/series/128186/ State : warning == Summary == Error: dim checkpatch failed a61040ad6018 drm/i915: Init DRM connector polled field early eecdb602c0e0 drm/i915: Keep

✓ Fi.CI.BAT: success for Panel replay selective update support

2024-01-04 Thread Patchwork
== Series Details == Series: Panel replay selective update support URL : https://patchwork.freedesktop.org/series/128193/ State : success == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128193v1 Summary --- **SUCCES

[PATCH v2 07/12] drm/i915: Prevent modesets during driver init/shutdown

2024-01-04 Thread Imre Deak
An unexpected modeset or connector detection by a user (user space or FB console) during the initialization/shutdown sequence is possible either via a hotplug IRQ handling work or via the connector sysfs (status/detect) interface. These modesets/detections should be prevented by disabling/flushing

✗ Fi.CI.SPARSE: warning for Panel replay selective update support

2024-01-04 Thread Patchwork
== Series Details == Series: Panel replay selective update support URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support

2024-01-04 Thread Patchwork
== Series Details == Series: Panel replay selective update support URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim checkpatch failed e2d183d50b55 drm/i915/psr: Disable panel replay for now 7fed1cae811a drm/i915/psr: Do not check alpm on DP or cap

✗ Fi.CI.BAT: failure for drm/i915: Fix HPD handling during driver init/shutdown

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown URL : https://patchwork.freedesktop.org/series/128186/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128186v1 Summary --

✗ Fi.CI.SPARSE: warning for drm/i915: Fix HPD handling during driver init/shutdown

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown URL : https://patchwork.freedesktop.org/series/128186/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix HPD handling during driver init/shutdown

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown URL : https://patchwork.freedesktop.org/series/128186/ State : warning == Summary == Error: dim checkpatch failed 5e045c45aae9 drm/i915: Init DRM connector polled field early 2f88f00692d8 drm/i915: Keep the con

Re: [PATCH v2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Jani Nikula
On Wed, 03 Jan 2024, José Roberto de Souza wrote: > Often getting DBS overflows when starting Xorg or Wayland compositors > when running Xe KMD. > Issue was reported but nothing was done, so disabling DSB as whole > until properly fixed in Xe KMD. > > v2: > - move check to HAS_DSB(Jani) I was thi

✗ Fi.CI.BAT: failure for drm/i915/guc: Avoid circular locking issue on busyness flush (rev6)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915/guc: Avoid circular locking issue on busyness flush (rev6) URL : https://patchwork.freedesktop.org/series/127985/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14077 -> Patchwork_127985v6 ===

Re: [V2] drm/i915: Add workaround 14019877138

2024-01-04 Thread Andi Shyti
Hi Tejas, On Wed, Jan 03, 2024 at 11:01:11AM +0530, Tejas Upadhyay wrote: > WA 14019877138 needed for Graphics 12.70/71 both > > V2(Jani): > - Use drm/i915 > > Signed-off-by: Tejas Upadhyay looks OK to me, if no other comments, I will go ahead and merge it. Reviewed-by: Andi Shyti Andi

Re: [PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-01-04 Thread Dmitry Baryshkov
On Thu, 4 Jan 2024 at 12:49, Jouni Högander wrote: > > Add definitions for panel replay selective update > > Cc: dri-de...@lists.freedesktop.org > 1) This CC should not be necessary. It is already a part of maintainers entry for this file 2) It probably doesn't work as expected. It is separated

✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Avoid circular locking issue on busyness flush (rev6)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915/guc: Avoid circular locking issue on busyness flush (rev6) URL : https://patchwork.freedesktop.org/series/127985/ State : warning == Summary == Error: dim checkpatch failed d0cacf327d6c drm/i915/guc: Avoid circular locking issue on busyness flush -:13: WAR

[PATCH 12/12] drm/i915/psr: Add panel replay sel update support to debugfs interface

2024-01-04 Thread Jouni Högander
Add panel replay selective update support to debugfs status interface. In case of sink supporting panel replay we will print out: Sink support: PSR = no, Panel Replay = yes, Panel Replay Selective Update = yes and PSR mode will look like this if printing out enabled panel replay selective update:

[PATCH 11/12] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay

2024-01-04 Thread Jouni Högander
Currently intel_dp_get_su_granularity doesn't support panel replay. This fix modifies it to support panel replay as well. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 59 +--- 1 file changed, 53 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-01-04 Thread Jouni Högander
Add definitions for panel replay selective update Cc: dri-de...@lists.freedesktop.org Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 3731828825bd..6a59d30b

  1   2   >