✗ Fi.CI.BUILD: failure for drm/i915/guc: Change wa and EU_PERF_CNTL registers to MCR type (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915/guc: Change wa and EU_PERF_CNTL registers to MCR type (rev2) URL : https://patchwork.freedesktop.org/series/128095/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/128095/revisions/2/mbox/ not applied Applying:

✓ Fi.CI.BAT: success for drm/xe/display: Disable aux ccs framebuffers (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/xe/display: Disable aux ccs framebuffers (rev2) URL : https://patchwork.freedesktop.org/series/128122/ State : success == Summary == CI Bug Log - changes from CI_DRM_14076 -> Patchwork_128122v2 Summary -

Re: [PATCH] drm/i915: clear the QGV mask set by GOP while booting

2024-01-04 Thread Lisovskiy, Stanislav
On Wed, Jan 03, 2024 at 06:57:45PM -0800, George D Sworo wrote: > From: George D Sworo > > GOP driver in the firmware is masking the QGV points except the one > which can > provide high Bandwidth required for panel. > > On boot to the OS the mask is already set, and is not cleared anywhere > in

Re: [PATCH] drm/i915: clear the QGV mask set by GOP while booting

2024-01-04 Thread Lisovskiy, Stanislav
On Wed, Jan 03, 2024 at 06:57:45PM -0800, George D Sworo wrote: > From: George D Sworo > > GOP driver in the firmware is masking the QGV points except the one > which can > provide high Bandwidth required for panel. > > On boot to the OS the mask is already set, and is not cleared anywhere > in

[PATCH 00/12] drm/i915: Fix HPD handling during driver init/shutdown

2024-01-04 Thread Imre Deak
Fix the handling of display connector hotplug handling during the driver init/shutdown sequences. A hotplug event can result in a connector detection/modeset running in parallel with the HW programming of the init/shutdown sequence, or when the display IRQs are disabled already. Also fix incorrect

[PATCH 01/12] drm/i915: Init DRM connector polled field early

2024-01-04 Thread Imre Deak
After an HPD IRQ storm on a connector intel_hpd_irq_storm_detect() will set the connector's HPD pin state to HPD_MARK_DISABLED and the IRQ gets disabled. Subsequently intel_hpd_irq_storm_switch_to_polling() will enable polling for these connectors, setting the pin state to HPD_DISABLED, but only if

[PATCH 02/12] drm/i915: Keep the connector polled state disabled after storm

2024-01-04 Thread Imre Deak
If an HPD IRQ storm is detected on a connector during driver loading or system suspend/resume - disabling the IRQ and switching to polling - the polling may get disabled too early - before the intended 2 minute HPD_STORM_REENABLE_DELAY - with the HPD IRQ staying disabled for this duration. One such

[PATCH 03/12] drm/i915: Move audio deinit after disabling polling

2024-01-04 Thread Imre Deak
Deinitialize audio during driver unload after disabling polling. This is in preparation to do all the display HW init/deinit steps at a point where no HPD IRQ or polling initiated connector detection or modeset can change the HW state. This may still happen here via an HPD IRQ -> hotplug detection

[PATCH 04/12] drm/i915: Disable intel HPD poll after DRM poll init/enable

2024-01-04 Thread Imre Deak
The only purpose of intel_hpd_poll_disable() during driver loading and system resume - at which point polling should be disabled anyway, except for connectors in an IRQ storm, for which the polling will stay enabled - is to force-detect all the connectors. However this detection in i915_hpd_poll_in

[PATCH 05/12] drm/i915: Suspend the framebuffer console during driver shutdown

2024-01-04 Thread Imre Deak
Suspend the FB console during driver shutdown the same way this is done during system resume. This should prevent any HPD event to trigger a new FB probe/modeset cycle happening in parallel with the display HW disable/uninitialize steps. A preceding FB HPD event handling may be still pending, resu

[PATCH 06/12] drm/i915: Suspend the framebuffer console earlier during system suspend

2024-01-04 Thread Imre Deak
Suspend the FB console early during system suspend to prevent new FB probe/modeset cycles interfering with the HW uninitialization steps in a similar way as during driver shutdown as described in the previous patch. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_driver.c | 3 +-- 1 file

[PATCH 07/12] drm/i915: Prevent modesets during driver init/shutdown

2024-01-04 Thread Imre Deak
An unexpected modeset or connector detection by a user (user space or FB console) during the initialization/shutdown sequence is possible either via a hotplug IRQ handling work or via the connector sysfs (status/detect) interface. These modesets/detections should be prevented by disabling/flushing

[PATCH 08/12] drm/i915: Disable hotplug detection works during driver init/shutdown

2024-01-04 Thread Imre Deak
As described in the previous patch, an unexpected connector detection/modeset started from the intel_hotplug::hotplug_work can happen during the driver init/shutdown sequence. Prevent these by disabling the queuing of and flushing all the intel_hotplug work that can start them at the beginning of t

[PATCH 09/12] drm/i915: Disable hotplug detection handlers during driver init/shutdown

2024-01-04 Thread Imre Deak
As described in the previous two patches an unexpected connector detection can happen during the init/shutdown sequences. Prevent these by returning the connector's current status from the detection handlers. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_crt.c| 4 driv

[PATCH 10/12] drm/i915: Add intel_digital_port lock/unlock hooks

2024-01-04 Thread Imre Deak
Add hooks to intel_digital_port to lock and unlock the port and add a helper to check the connector's detect status while the port is locked already. This simplifies checking the connector detect status in intel_dp_aux_xfer() and intel_digital_port_connected() in the next two patches aborting AUX t

[PATCH 11/12] drm/i915: Filter out glitches on HPD lines during hotplug detection

2024-01-04 Thread Imre Deak
Glitches deasserting the connector HPD line can lead to incorrectly detecting a disconnect event (a glitch asserting the line will only cause a redundant connect->disconnect transition). The source of such a glitch can be noise on the line or a 0.5ms-1ms MST IRQ_HPD pulse. TypeC ports in the DP-alt

[PATCH 12/12] drm/i915/dp: Abort AUX on disconnected native DP ports

2024-01-04 Thread Imre Deak
An AUX transfer on any disconnected DP port results in long timeout/retry delays the same way as this is described for TypeC port in commit a972cd3f0eb5 ("drm/i915/tc: Abort DP AUX transfer on a disconnected TC port") Prevent the delay on non-TypeC ports as well by aborting the transfer if the p

✗ Fi.CI.SPARSE: warning for Resolve suspend-resume racing with GuC destroy-context-worker (rev13)

2024-01-04 Thread Patchwork
== Series Details == Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev13) URL : https://patchwork.freedesktop.org/series/121916/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for Resolve suspend-resume racing with GuC destroy-context-worker (rev13)

2024-01-04 Thread Patchwork
== Series Details == Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev13) URL : https://patchwork.freedesktop.org/series/121916/ State : success == Summary == CI Bug Log - changes from CI_DRM_14076 -> Patchwork_121916v13

RE: [PATCH v2 3/3] drm/i915/display: Cleanup mplla/mpllb selection

2024-01-04 Thread Kahola, Mika
> -Original Message- > From: Deak, Imre > Sent: Wednesday, January 3, 2024 6:16 PM > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH v2 3/3] drm/i915/display: Cleanup mplla/mpllb selection > > On Tue, Jan 02, 2024 at 01:57:41PM +0200, Mika Kahola wrote: > > T

✗ Fi.CI.CHECKPATCH: warning for TC phy check cleanup (rev4)

2024-01-04 Thread Patchwork
== Series Details == Series: TC phy check cleanup (rev4) URL : https://patchwork.freedesktop.org/series/127989/ State : warning == Summary == Error: dim checkpatch failed 3f1e1d3cda90 drm/i915: Rename intel_bios_encoder_data_lookup as a port variant f375d2f368b9 drm/i915: Introduce intel_encod

✗ Fi.CI.SPARSE: warning for TC phy check cleanup (rev4)

2024-01-04 Thread Patchwork
== Series Details == Series: TC phy check cleanup (rev4) URL : https://patchwork.freedesktop.org/series/127989/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for TC phy check cleanup (rev4)

2024-01-04 Thread Patchwork
== Series Details == Series: TC phy check cleanup (rev4) URL : https://patchwork.freedesktop.org/series/127989/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14077 -> Patchwork_127989v4 Summary --- **FAILURE** Ser

✗ Fi.CI.BUILD: failure for series starting with [v2,1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings (rev3)

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings (rev3) URL : https://patchwork.freedesktop.org/series/128026/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/128026/revisio

[PATCH 00/12] Panel replay selective update support

2024-01-04 Thread Jouni Högander
This patch set is implementing panel replay selective update support for Intel hardware. It is also fixing couple of exisiting issues in current panel replay implementation: ALPM status is checked even on DP (non eDP) PSR capability change is checked even when using panel replay Panel replay is

[PATCH 01/12] drm/i915/psr: Disable panel replay for now

2024-01-04 Thread Jouni Högander
Panel replay is not completely validated yet. Let's disable it for now. Signed-off-by: Jouni Högander --- .../gpu/drm/i915/display/intel_display_types.h| 15 --- drivers/gpu/drm/i915/display/intel_psr.c | 10 +- 2 files changed, 17 insertions(+), 8 deletions(-)

[PATCH 02/12] drm/i915/psr: Do not check alpm on DP or capability change for panel replay

2024-01-04 Thread Jouni Högander
Alpm is eDP specific. Do not check if not eDP. Also panel replay doesn't know about capability changes -> no need to check that. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i

[PATCH 03/12] drm/i915/psr: Unify panel replay enable sink

2024-01-04 Thread Jouni Högander
Panel replay enable for a sink is currently done in intel_ddi.c:intel_ddi_pre_enable_dp. Move it to intel_psr_enable_sink to unify psr/panel replay paths. Also enable some additional hpd interrupts for panel replay. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_ddi.c | 7

[PATCH 04/12] drm/i915/psr: Rename has_psr2 as has_sel_update

2024-01-04 Thread Jouni Högander
We are going to reuse has_psr2 for panel_replay as well. Rename it as has_sel_update to avoid confusion. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 5 +++-- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/int

[PATCH 05/12] drm/i915/psr: Rename psr2_enabled as sel_update_enabled

2024-01-04 Thread Jouni Högander
We are about to reuse psr2_enabled for panel replay as well. Rename it as sel_update_enabled to avoid confusion. Signed-off-by: Jouni Högander --- .../drm/i915/display/intel_display_types.h| 2 +- drivers/gpu/drm/i915/display/intel_psr.c | 52 +-- 2 files changed, 27 in

[PATCH 06/12] drm/i915/psr: Add some documentation of variables used in psr code

2024-01-04 Thread Jouni Högander
We are adding more boolean variable into intel_psr and intel_crtc_state structs. Add some documentation about these for sake of clarity. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/dr

[PATCH 07/12] drm/i915/psr: Add sink_panel_replay_su_support to intel_psr

2024-01-04 Thread Jouni Högander
Add new boolean to store panel replay selective update support of sink. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/inte

[PATCH 08/12] drm/i915/psr: Detect panel replay selective update support

2024-01-04 Thread Jouni Högander
Detect panel replay selective update support and store it into intel_psr->sink_panel_replay_su_support. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr

[PATCH 09/12] drm/i915/psr: Split intel_psr2_config_valid for panel replay

2024-01-04 Thread Jouni Högander
Part of intel_psr2_config_valid is valid for panel replay. rename it as intel_sel_update_config_valid. Split psr2 specific part and name it as intel_psr2_config_valid. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 60 +++- 1 file changed, 38 ins

[PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-01-04 Thread Jouni Högander
Add definitions for panel replay selective update Cc: dri-de...@lists.freedesktop.org Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 3731828825bd..6a59d30b

[PATCH 11/12] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay

2024-01-04 Thread Jouni Högander
Currently intel_dp_get_su_granularity doesn't support panel replay. This fix modifies it to support panel replay as well. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 59 +--- 1 file changed, 53 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH 12/12] drm/i915/psr: Add panel replay sel update support to debugfs interface

2024-01-04 Thread Jouni Högander
Add panel replay selective update support to debugfs status interface. In case of sink supporting panel replay we will print out: Sink support: PSR = no, Panel Replay = yes, Panel Replay Selective Update = yes and PSR mode will look like this if printing out enabled panel replay selective update:

✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Avoid circular locking issue on busyness flush (rev6)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915/guc: Avoid circular locking issue on busyness flush (rev6) URL : https://patchwork.freedesktop.org/series/127985/ State : warning == Summary == Error: dim checkpatch failed d0cacf327d6c drm/i915/guc: Avoid circular locking issue on busyness flush -:13: WAR

Re: [PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-01-04 Thread Dmitry Baryshkov
On Thu, 4 Jan 2024 at 12:49, Jouni Högander wrote: > > Add definitions for panel replay selective update > > Cc: dri-de...@lists.freedesktop.org > 1) This CC should not be necessary. It is already a part of maintainers entry for this file 2) It probably doesn't work as expected. It is separated

Re: [V2] drm/i915: Add workaround 14019877138

2024-01-04 Thread Andi Shyti
Hi Tejas, On Wed, Jan 03, 2024 at 11:01:11AM +0530, Tejas Upadhyay wrote: > WA 14019877138 needed for Graphics 12.70/71 both > > V2(Jani): > - Use drm/i915 > > Signed-off-by: Tejas Upadhyay looks OK to me, if no other comments, I will go ahead and merge it. Reviewed-by: Andi Shyti Andi

✗ Fi.CI.BAT: failure for drm/i915/guc: Avoid circular locking issue on busyness flush (rev6)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915/guc: Avoid circular locking issue on busyness flush (rev6) URL : https://patchwork.freedesktop.org/series/127985/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14077 -> Patchwork_127985v6 ===

Re: [PATCH v2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Jani Nikula
On Wed, 03 Jan 2024, José Roberto de Souza wrote: > Often getting DBS overflows when starting Xorg or Wayland compositors > when running Xe KMD. > Issue was reported but nothing was done, so disabling DSB as whole > until properly fixed in Xe KMD. > > v2: > - move check to HAS_DSB(Jani) I was thi

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix HPD handling during driver init/shutdown

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown URL : https://patchwork.freedesktop.org/series/128186/ State : warning == Summary == Error: dim checkpatch failed 5e045c45aae9 drm/i915: Init DRM connector polled field early 2f88f00692d8 drm/i915: Keep the con

✗ Fi.CI.SPARSE: warning for drm/i915: Fix HPD handling during driver init/shutdown

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown URL : https://patchwork.freedesktop.org/series/128186/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915: Fix HPD handling during driver init/shutdown

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown URL : https://patchwork.freedesktop.org/series/128186/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128186v1 Summary --

✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support

2024-01-04 Thread Patchwork
== Series Details == Series: Panel replay selective update support URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim checkpatch failed e2d183d50b55 drm/i915/psr: Disable panel replay for now 7fed1cae811a drm/i915/psr: Do not check alpm on DP or cap

✗ Fi.CI.SPARSE: warning for Panel replay selective update support

2024-01-04 Thread Patchwork
== Series Details == Series: Panel replay selective update support URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v2 07/12] drm/i915: Prevent modesets during driver init/shutdown

2024-01-04 Thread Imre Deak
An unexpected modeset or connector detection by a user (user space or FB console) during the initialization/shutdown sequence is possible either via a hotplug IRQ handling work or via the connector sysfs (status/detect) interface. These modesets/detections should be prevented by disabling/flushing

✓ Fi.CI.BAT: success for Panel replay selective update support

2024-01-04 Thread Patchwork
== Series Details == Series: Panel replay selective update support URL : https://patchwork.freedesktop.org/series/128193/ State : success == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128193v1 Summary --- **SUCCES

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) URL : https://patchwork.freedesktop.org/series/128186/ State : warning == Summary == Error: dim checkpatch failed a61040ad6018 drm/i915: Init DRM connector polled field early eecdb602c0e0 drm/i915: Keep

✗ Fi.CI.SPARSE: warning for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) URL : https://patchwork.freedesktop.org/series/128186/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) URL : https://patchwork.freedesktop.org/series/128186/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128186v2 Sum

[PATCH v2 0/3] Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Andi Shyti
Hi, This series aims to disable the CCS hardware load balancing, as recommended by hardware directives in Wa_16016805146. In the meantime, we need to define and support a fixed CCS mode of balancing that can be configured by the user. Thanks, Andi Changelog: == v1 -> v2: - update comme

[PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Andi Shyti
The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one CCS to all the slices. Based on a patch by

[PATCH v2 2/3] drm/i915/gt: Allow user to set up the CSS mode

2024-01-04 Thread Andi Shyti
Now that the CCS mode is configurable, an interface has been exposed in the GT's sysfs set of files, allowing users to set the mode. Additionally, another interface has been added to display the number of available slices, named 'num_slices.' Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joona

[PATCH v2 3/3] drm/i915/gt: Disable HW load balancing for CCS

2024-01-04 Thread Andi Shyti
The hardware is not able to dynamically balance the load between CCS engines. Wa_16016805146 suggests disabling it for all platforms. Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Niranjana Vishwanathapura Cc: Tejas Upadhyay --- drivers/gpu/drm/i915/gt/intel_gt_regs.h

[PULL] drm-misc-next-fixes

2024-01-04 Thread Maxime Ripard
Hi! Here's this week drm-misc-next-fixes PR Maxime drm-misc-next-fixes-2024-01-04: One fix for drm/plane to avoid a use-after-free and some additional warnings to prevent more of these occurences, a lock inversion dependency fix and an indentation fix for drm/rockchip, and some doc warning fixes

[PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Christian König
Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index edf10618fe2b..8c1eaa74fa21 100644 --- a/drivers/

✗ Fi.CI.CHECKPATCH: warning for Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Patchwork
== Series Details == Series: Disable dynamic load balancing and support fixed balancing URL : https://patchwork.freedesktop.org/series/128202/ State : warning == Summary == Error: dim checkpatch failed 478beb8ee33d drm/i915/gt: Support fixed CCS mode Traceback (most recent call last): File "

✗ Fi.CI.SPARSE: warning for Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Patchwork
== Series Details == Series: Disable dynamic load balancing and support fixed balancing URL : https://patchwork.freedesktop.org/series/128202/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Rework TTMs busy handling

2024-01-04 Thread Christian König
Hi guys, I'm trying to make this functionality a bit more useful for years now since we multiple reports that behavior of drivers can be suboptimal when multiple placements be given. So basically instead of hacking around the TTM behavior in the driver once more I've gone ahead and changed the id

[PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Christian König
Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index edf10618fe2b..8c1eaa74fa21 100644 --- a/drivers/

[PATCH 3/4] drm/ttm: improve idle/busy handling v2

2024-01-04 Thread Christian König
Previously we would never try to move a BO into the preferred placements when it ever landed in a busy placement since those were considered compatible. Rework the whole handling and finally unify the idle and busy handling. ttm_bo_validate() is now responsible to try idle placement first and then

[PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2024-01-04 Thread Christian König
Try to fill up VRAM as well by setting the busy flag on GTT allocations. This fixes the issue that when VRAM was evacuated for suspend it's never filled up again unless the application is restarted. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++ 1 file

[PATCH 2/4] drm/ttm: replace busy placement with flags v4

2024-01-04 Thread Christian König
From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ERROR on drm-tip/drm-tip v4: fix some typos pointed

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Tvrtko Ursulin
On 04/01/2024 14:35, Andi Shyti wrote: The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one

✗ Fi.CI.BAT: failure for Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Patchwork
== Series Details == Series: Disable dynamic load balancing and support fixed balancing URL : https://patchwork.freedesktop.org/series/128202/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128202v1 Summar

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/128207/ State : warning == Summary == Error: dim checkpatch failed dcccad5f8257 drm/ttm: return ENOSPC from ttm_bo_mem_space -:35: WARNING:FROM_SI

✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/128207/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/128207/ State : success == Summary == CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128207v1 ===

Re: [PATCH] drm/i915: clear the QGV mask set by GOP while booting

2024-01-04 Thread Sworo, George D
On Thu, 2024-01-04 at 10:13 +0200, Lisovskiy, Stanislav wrote: > On Wed, Jan 03, 2024 at 06:57:45PM -0800, George D Sworo wrote: > > From: George D Sworo > > > > GOP driver in the firmware is masking the QGV points except the one > > which can > > provide high Bandwidth required for panel. > > >

Re: ✗ Fi.CI.BAT: failure for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-04 Thread Imre Deak
On Thu, Jan 04, 2024 at 02:08:32PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) > URL : https://patchwork.freedesktop.org/series/128186/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14078 ->

[PATCH v3 1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread José Roberto de Souza
Often getting DBS overflows when starting Xorg or Wayland compositors when running Xe KMD. Issue was reported but nothing was done, so disabling DSB as whole until properly fixed in Xe KMD. v2: - move check to HAS_DSB(Jani) v3: - use IS_ENABLED(I915) check in intel_dsb_prepare() Link: https://gi

[PATCH v3 2/2] drm/xe: Fix definition of intel_wakeref_t

2024-01-04 Thread José Roberto de Souza
i915 defines it as unsigned long so Xe should do the same. It did not break anything because the bool was being promoted to int by compiler. This was caught because it causing compilation warnings: CC [M] drivers/gpu/drm/i915/i915_gem.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_po

Re: [PATCH v3 1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Francois Dugast
On Thu, Jan 04, 2024 at 08:05:56AM -0800, José Roberto de Souza wrote: > Often getting DBS overflows when starting Xorg or Wayland compositors > when running Xe KMD. s/DBS overflows/DSB overflows/ > Issue was reported but nothing was done, so disabling DSB as whole > until properly fixed in Xe KM

[PATCH v4 1/3] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread José Roberto de Souza
Often getting DSB overflows when starting Xorg or Wayland compositors when running Xe KMD. Issue was reported but nothing was done, so disabling DSB as whole until properly fixed in Xe KMD. v2: - move check to HAS_DSB(Jani) v3: - use IS_ENABLED(I915) check in intel_dsb_prepare() Link: https://gi

[PATCH v4 2/3] drm/xe: Fix definition of intel_wakeref_t

2024-01-04 Thread José Roberto de Souza
i915 defines it as unsigned long so Xe should do the same to avoid compilation warnings: CC [M] drivers/gpu/drm/i915/i915_gem.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_power_well.o In file included from ./include/drm/drm_mm.h:51, from drivers/gpu/drm/xe/xe_bo_ty

[PATCH v4 3/3] drm/xe: Use intel_wakeref_t in intel_runtime_pm functions

2024-01-04 Thread José Roberto de Souza
Now intel_wakeref_t is a unsigned long and Xe KMD version of those functions should use the same type, so changing from bool to intel_wakeref_t. Cc: Maarten Lankhorst Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 10 +- 1 file changed, 5 in

[PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-04 Thread Jani Nikula
intel_wakeref_t is supposed to be a mostly opaque cookie to its users. It should only be checked for being non-zero and set to zero. Debug logging its actual value is meaningless. Switch to just debug logging whether the async_put_wakeref is non-zero. The issue dates back to much earlier than comm

Re: [PATCH v3 1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Jani Nikula
On Thu, 04 Jan 2024, José Roberto de Souza wrote: > Often getting DBS overflows when starting Xorg or Wayland compositors > when running Xe KMD. > Issue was reported but nothing was done, so disabling DSB as whole > until properly fixed in Xe KMD. > > v2: > - move check to HAS_DSB(Jani) > > v3: >

Re: [PATCH v4 2/3] drm/xe: Fix definition of intel_wakeref_t

2024-01-04 Thread Jani Nikula
On Thu, 04 Jan 2024, José Roberto de Souza wrote: > i915 defines it as unsigned long so Xe should do the same to avoid > compilation warnings: > > CC [M] drivers/gpu/drm/i915/i915_gem.o > CC [M] drivers/gpu/drm/xe/i915-display/intel_display_power_well.o > In file included from ./include/drm/

Re: [PATCH v4 3/3] drm/xe: Use intel_wakeref_t in intel_runtime_pm functions

2024-01-04 Thread Jani Nikula
On Thu, 04 Jan 2024, José Roberto de Souza wrote: > Now intel_wakeref_t is a unsigned long and Xe KMD version of those > functions should use the same type, so changing from bool to > intel_wakeref_t. > > Cc: Maarten Lankhorst > Signed-off-by: José Roberto de Souza I don't think it was ever a b

Re: [PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-04 Thread Imre Deak
On Thu, Jan 04, 2024 at 06:46:00PM +0200, Jani Nikula wrote: > intel_wakeref_t is supposed to be a mostly opaque cookie to its > users. It should only be checked for being non-zero and set to > zero. Debug logging its actual value is meaningless. Switch to just > debug logging whether the async_put

Re: ✗ Fi.CI.IGT: failure for Resolve suspend-resume racing with GuC destroy-context-worker (rev13)

2024-01-04 Thread Teres Alexis, Alan Previn
On Thu, 2024-01-04 at 10:57 +, Patchwork wrote: > Patch Details > Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev13) > URL:https://patchwork.freedesktop.org/series/121916/ > State: failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12

[PATCH 5/5] drm/i915/tv: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. It's only comments here, but update anyway. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_tv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i

[PATCH 1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_

[PATCH 4/5] drm/i915/display: use IS_DISPLAY_VER instead of IS_GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_di

[PATCH 3/5] drm/i915/hdcp: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. While at it, abstract the version check to a separate macro. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_hdcp_regs.h| 28 ++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 2/5] drm/i915/dmc: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-04 Thread Jani Nikula
Display code should not care about graphics version. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index b70502586ab9

[PATCH v3 1/3] drm/i915: Enable Wa_16019325821

2024-01-04 Thread John . C . Harrison
From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 19 +++---

[PATCH v3 0/3] Enable Wa_14019159160 and Wa_16019325821 for MTL

2024-01-04 Thread John . C . Harrison
From: John Harrison Enable Wa_14019159160 and Wa_16019325821 for MTL RCS/CCS workarounds for MTL. v2: Fix bug in WA KLV implementation (offset not being reset to start of list). Add better comment to prep patch about how KLVs can be added. Add a module parameter override and disable the w/a by

[PATCH v3 2/3] drm/i915/guc: Add support for w/a KLVs

2024-01-04 Thread John . C . Harrison
From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc.h

[PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160

2024-01-04 Thread John . C . Harrison
From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/

Re: [PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-04 Thread Andrzej Hajda
On 04.01.2024 17:46, Jani Nikula wrote: intel_wakeref_t is supposed to be a mostly opaque cookie to its users. It should only be checked for being non-zero and set to zero. Debug logging its actual value is meaningless. Switch to just debug logging whether the async_put_wakeref is non-zero. T

[PATCH] drm/i915: clear the QGV mask set by GOP while booting

2024-01-04 Thread george . d . sworo
From: George D Sworo GOP driver in the firmware is masking the QGV points except the one which can provide high Bandwidth required for panel. On boot to the OS the mask is already set, and is not cleared anywhere in the i915 driver even though sagv is enabled. This means Pcode is unable to switc

✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128212/ State : warning == Summary == Error: dim checkpatch failed 37112d90d4cb drm/i915: Disable DSB in Xe KMD -:38: WARNING:IS_ENABLED_CONFIG: IS_ENABLED(

✗ Fi.CI.SPARSE: warning for series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128212/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86

Re: [PATCH 2/4] drm/ttm: replace busy placement with flags v4

2024-01-04 Thread Zack Rusin
On Thu, Jan 4, 2024 at 10:05 AM Christian König wrote: > > From: Somalapuram Amaranath > > Instead of a list of separate busy placement add flags which indicate > that a placement should only be used when there is room or if we need to > evict. > > v2: add missing TTM_PL_FLAG_IDLE for i915 > v3:

✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD

2024-01-04 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915: Disable DSB in Xe KMD URL : https://patchwork.freedesktop.org/series/128212/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128212v1 Sum

[PATCH 1/3] drm/nouveau: include drm/drm_edid.h only where needed

2024-01-04 Thread Jani Nikula
Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 files when drm_edid.h is modified, while there are only a few files that actually need to include drm_edid.h. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula

  1   2   >