✗ Fi.CI.IGT: failure for drm/i915/display: Use helper to select C20 MPLLA/B

2024-01-05 Thread Patchwork
== Series Details == Series: drm/i915/display: Use helper to select C20 MPLLA/B URL : https://patchwork.freedesktop.org/series/128254/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14080_full -> Patchwork_128254v1_full Summ

Re: ✗ Fi.CI.IGT: failure for drm/i915: Add workaround 14019877138

2024-01-05 Thread Matt Roper
On Wed, Jan 03, 2024 at 02:52:37PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add workaround 14019877138 > URL : https://patchwork.freedesktop.org/series/128143/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14072_full -> Patchwork_128143v1_

Re: [PATCH] drm/i915/huc: Allow for very slow HuC loading

2024-01-05 Thread John Harrison
On 1/4/2024 12:34, Daniele Ceraolo Spurio wrote: On 1/2/2024 2:22 PM, john.c.harri...@intel.com wrote: From: John Harrison A failure to load the HuC is occasionally observed where the cause is believed to be a low GT frequency leading to very long load times. So a) increase the timeout so tha

✓ Fi.CI.BAT: success for ALPM AUX Wake Configuration (rev2)

2024-01-05 Thread Patchwork
== Series Details == Series: ALPM AUX Wake Configuration (rev2) URL : https://patchwork.freedesktop.org/series/127954/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_127954v2 Summary --- **SUCCESS**

✗ Fi.CI.SPARSE: warning for ALPM AUX Wake Configuration (rev2)

2024-01-05 Thread Patchwork
== Series Details == Series: ALPM AUX Wake Configuration (rev2) URL : https://patchwork.freedesktop.org/series/127954/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

✗ Fi.CI.CHECKPATCH: warning for ALPM AUX Wake Configuration (rev2)

2024-01-05 Thread Patchwork
== Series Details == Series: ALPM AUX Wake Configuration (rev2) URL : https://patchwork.freedesktop.org/series/127954/ State : warning == Summary == Error: dim checkpatch failed b9c0b09fc5df drm/i915/alpm: Add ALPM register definitions -:38: WARNING:LONG_LINE: line length of 113 exceeds 100 co

Re: [PATCH 4/4] drm/i915/cdclk: Re-use bxt_cdclk_ctl() when sanitizing

2024-01-05 Thread Matt Roper
On Fri, Jan 05, 2024 at 11:09:37AM -0300, Gustavo Sousa wrote: > Quoting Matt Roper (2024-01-04 20:52:32-03:00) > >On Thu, Jan 04, 2024 at 03:48:34PM -0800, Matt Roper wrote: > >> On Thu, Jan 04, 2024 at 12:21:50AM -0300, Gustavo Sousa wrote: > >> > That's the function responsible for deriving that

Re: [PATCH 3/3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2024-01-05 Thread Alex Deucher
On Thu, Jan 4, 2024 at 3:17 PM Jani Nikula wrote: > > hdmi-codec.h does not appear to directly need drm/drm_edid.h for > anything. Remove it. > > There are some files that get drm/drm_edid.h by proxy; include it where > needed. > > v2-v4: Fix build (kernel test robot ) > > Cc: Rob Clark > Cc: Abh

✓ Fi.CI.BAT: success for Update bxt_sanitize_cdclk() for Xe2_LPD (rev3)

2024-01-05 Thread Patchwork
== Series Details == Series: Update bxt_sanitize_cdclk() for Xe2_LPD (rev3) URL : https://patchwork.freedesktop.org/series/128175/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128175v3 Summary ---

Re: [PATCH 02/12] drm/i915: Keep the connector polled state disabled after storm

2024-01-05 Thread Imre Deak
On Fri, Jan 05, 2024 at 04:08:31PM +0200, Hogander, Jouni wrote: > On Fri, 2024-01-05 at 15:38 +0200, Imre Deak wrote: > > On Fri, Jan 05, 2024 at 03:23:49PM +0200, Hogander, Jouni wrote: > > > On Thu, 2024-01-04 at 10:29 +0200, Imre Deak wrote: > > > > If an HPD IRQ storm is detected on a connecto

RE: [PATCH 3/7] drm/i915/psr: Carry su area in crtc_state

2024-01-05 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Monday, December 18, 2023 7:50 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 3/7] drm/i915/psr: Carry su area in crtc_state > > Su_area is needed when configuring CUR_POS_ERLY_TPT and PIPE_SRC_SZ_ER

[PATCH v2 3/4] drm/i915/alpm: Calculate ALPM Entry check

2024-01-05 Thread Jouni Högander
ALPM Entry Check represents the number of lines needed to put the main link to sleep and keep it in the sleep state before it can be taken out of the SLEEP state (eDP requires the main link to be in the SLEEP state for a minimum of 5us). Bspec: 71477 Signed-off-by: Jouni Högander --- .../drm/i9

[PATCH v2 4/4] drm/i915/alpm: Alpm aux wake configuration for lnl

2024-01-05 Thread Jouni Högander
Lunarlake has some configurations in ALPM_CTL register for legacy ALPM as well. Write these. Bspec: 71477 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/d

[PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct

2024-01-05 Thread Jouni Högander
Add new alpm_parameters struct into intel_psr for all calculated alpm parameters. Signed-off-by: Jouni Högander --- .../drm/i915/display/intel_display_types.h| 8 -- drivers/gpu/drm/i915/display/intel_psr.c | 28 ++- 2 files changed, 21 insertions(+), 15 deletions(-

[PATCH v2 1/4] drm/i915/alpm: Add ALPM register definitions

2024-01-05 Thread Jouni Högander
Add ALPM register definitions for Lunar Lake. v2: - Use REG_BIT instead of BIT - Add commit message Cc: Jani Nikula Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr_regs.h | 103 ++ 1 file changed, 103 insertions(+) diff --git a/drivers/gpu/drm/i91

[PATCH v2 0/4] ALPM AUX Wake Configuration

2024-01-05 Thread Jouni Högander
This patch set is adding some missing AUX wake related configuration for Lunar Lake. Also ALPM parameters are moved to separate struct because amount of parameters is about to increase in upcoming patches. Additionally all ALPM related register definitions are added for Lunar Lake. v2: - Use R

Re: [PATCH 4/4] drm/i915/cdclk: Re-use bxt_cdclk_ctl() when sanitizing

2024-01-05 Thread Gustavo Sousa
Quoting Matt Roper (2024-01-04 20:52:32-03:00) >On Thu, Jan 04, 2024 at 03:48:34PM -0800, Matt Roper wrote: >> On Thu, Jan 04, 2024 at 12:21:50AM -0300, Gustavo Sousa wrote: >> > That's the function responsible for deriving that register's value; use >> > it. >> > >> > Signed-off-by: Gustavo Sousa

Re: [PATCH 02/12] drm/i915: Keep the connector polled state disabled after storm

2024-01-05 Thread Hogander, Jouni
On Fri, 2024-01-05 at 15:38 +0200, Imre Deak wrote: > On Fri, Jan 05, 2024 at 03:23:49PM +0200, Hogander, Jouni wrote: > > On Thu, 2024-01-04 at 10:29 +0200, Imre Deak wrote: > > > If an HPD IRQ storm is detected on a connector during driver > > > loading or > > > system suspend/resume - disabling

RE: [PATCH 2/7] drm/i915/psr: Extend SU area to cover cursor fully if needed

2024-01-05 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Monday, December 18, 2023 7:50 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 2/7] drm/i915/psr: Extend SU area to cover cursor fully if > needed > > In case early transport is enabled SU area needs

[PATCH v2 3/4] drm/i915/cdclk: Reorder bxt_sanitize_cdclk()

2024-01-05 Thread Gustavo Sousa
Make the sequence of steps in bxt_sanitize_cdclk() more logical by grouping things related to the check on the value of CDCLK_CTL into a single "block". Also, this will make an upcoming change replacing that block with a single function call easier to follow. v2: - Improve body of commit message

[PATCH v2 4/4] drm/i915/cdclk: Re-use bxt_cdclk_ctl() when sanitizing

2024-01-05 Thread Gustavo Sousa
The function bxt_cdclk_ctl() is responsible for deriving the value for CDCLK_CTL; use it instead of repeating the same logic. v2: - Use a better commit message body by making it more self-contained and not referring to stuff from the subject line. (Matt) Reviewed-by: Matt Roper Signed-off-

[PATCH v2 2/4] drm/i915/cdclk: Extract bxt_cdclk_ctl()

2024-01-05 Thread Gustavo Sousa
Extract logic for deriving the value for CDCLK_CTL into bxt_cdclk_ctl(). This makes the code better readable and will be used later in bxt_sanitize_cdclk(). v2: - Improve body of commit message to be more self-contained. Reviewed-by: Matt Roper Signed-off-by: Gustavo Sousa --- drivers/gpu/dr

[PATCH v2 1/4] drm/i915/xe2lpd: Update bxt_sanitize_cdclk()

2024-01-05 Thread Gustavo Sousa
With Xe2_LPD, there were changes to the way CDCLK_CTL must be programmed. Those were reflected on _bxt_set_cdclk() with commit 3d3696c0fed1 ("drm/i915/lnl: Start using CDCLK through PLL"), but bxt_sanitize_cdclk() was left out. This was causing some issues when loading the driver with a pre-existi

[PATCH v2 0/4] Update bxt_sanitize_cdclk() for Xe2_LPD

2024-01-05 Thread Gustavo Sousa
This series fixes an issue observed during module load due to missing bits in bxt_sanitize_cdclk() specific to Xe2_LPD. The first patch contains the fix itself. The subsequent patches refactor the code so that bxt_sanitize_cdclk() and _bxt_set_cdclk() use the same function for deriving the value f

Re: [PATCH 1/5] drm/i915/irq: use DISPLAY_VER instead of GRAPHICS_VER

2024-01-05 Thread Jani Nikula
On Thu, 04 Jan 2024, Matt Roper wrote: > On Thu, Jan 04, 2024 at 07:43:46PM +0200, Jani Nikula wrote: >> Display code should not care about graphics version. >> >> Signed-off-by: Jani Nikula > > For the series: > > Reviewed-by: Matt Roper Thanks, pushed to drm-intel-next, with the tabs in comm

Re: [PATCH 03/12] drm/i915: Move audio deinit after disabling polling

2024-01-05 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:29 +0200, Imre Deak wrote: > Deinitialize audio during driver unload after disabling polling. This > is > in preparation to do all the display HW init/deinit steps at a point > where no HPD IRQ or polling initiated connector detection or modeset > can > change the HW state.

Re: [PATCH 02/12] drm/i915: Keep the connector polled state disabled after storm

2024-01-05 Thread Imre Deak
On Fri, Jan 05, 2024 at 03:23:49PM +0200, Hogander, Jouni wrote: > On Thu, 2024-01-04 at 10:29 +0200, Imre Deak wrote: > > If an HPD IRQ storm is detected on a connector during driver loading or > > system suspend/resume - disabling the IRQ and switching to polling - the > > polling may get disable

Re: [PATCH 02/12] drm/i915: Keep the connector polled state disabled after storm

2024-01-05 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:29 +0200, Imre Deak wrote: > If an HPD IRQ storm is detected on a connector during driver loading > or > system suspend/resume - disabling the IRQ and switching to polling - > the > polling may get disabled too early - before the intended 2 minute > HPD_STORM_REENABLE_DELAY

Re: [PATCH 01/12] drm/i915: Init DRM connector polled field early

2024-01-05 Thread Imre Deak
On Fri, Jan 05, 2024 at 02:54:06PM +0200, Hogander, Jouni wrote: > On Thu, 2024-01-04 at 10:29 +0200, Imre Deak wrote: > > After an HPD IRQ storm on a connector intel_hpd_irq_storm_detect() > > will > > set the connector's HPD pin state to HPD_MARK_DISABLED and the IRQ > > gets > > disabled. Subseq

Re: [PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-05 Thread Jani Nikula
On Thu, 04 Jan 2024, Imre Deak wrote: > On Thu, Jan 04, 2024 at 06:46:00PM +0200, Jani Nikula wrote: >> intel_wakeref_t is supposed to be a mostly opaque cookie to its >> users. It should only be checked for being non-zero and set to >> zero. Debug logging its actual value is meaningless. Switch t

Re: [PATCH 01/12] drm/i915: Init DRM connector polled field early

2024-01-05 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:29 +0200, Imre Deak wrote: > After an HPD IRQ storm on a connector intel_hpd_irq_storm_detect() > will > set the connector's HPD pin state to HPD_MARK_DISABLED and the IRQ > gets > disabled. Subsequently intel_hpd_irq_storm_switch_to_polling() will > enable polling for thes

Re: [PATCH 2/4] drm/ttm: replace busy placement with flags v4

2024-01-05 Thread Christian König
Am 04.01.24 um 21:02 schrieb Zack Rusin: On Thu, Jan 4, 2024 at 10:05 AM Christian König wrote: From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TT

✓ Fi.CI.BAT: success for drm/i915/display: Use helper to select C20 MPLLA/B

2024-01-05 Thread Patchwork
== Series Details == Series: drm/i915/display: Use helper to select C20 MPLLA/B URL : https://patchwork.freedesktop.org/series/128254/ State : success == Summary == CI Bug Log - changes from CI_DRM_14080 -> Patchwork_128254v1 Summary --

Re: [Intel-gfx] â Fi.CI.IGT: success for drm/i915: use ref_tracker library in i915 (rev4)

2024-01-05 Thread Jani Nikula
On Mon, 20 Nov 2023, Andrzej Hajda wrote: > Patchset merged to intel-gt-next. For future reference, anything that has an impact outside of the gt/gem land should be merged via drm-intel-next, not drm-intel-gt-next. We can cross-merge drm-intel-next -> drm-intel-gt-next, but any changes from drm-

Re: [PATCH] drm/i915/display: Use helper to select C20 MPLLA/B

2024-01-05 Thread Imre Deak
On Fri, Jan 05, 2024 at 01:22:43PM +0200, Mika Kahola wrote: > We used to select between MPLLA/B with the following > > state->tx[0] & C20_PHY_USE_MPLLB > > Since this is used a few places within C20 PLL setting, > let's introduce a helper function to clean up the code > a bit. > > Signed-off-by

Re: [RESEND] drm/edid: prefer forward declarations over includes in drm_edid.h

2024-01-05 Thread Jani Nikula
On Fri, 05 Jan 2024, Thomas Zimmermann wrote: > Am 04.01.24 um 22:10 schrieb Jani Nikula: >> There's no need to include either linux/hdmi.h or drm/drm_mode.h. They >> can be removed by using forward declarations. >> >> While at it, group the forward declarations together, and remove the >> unnece

Re: [PATCH i-g-t] tests/perf_pmu: Restore sysfs freq in exit handler

2024-01-05 Thread Kamil Konieczny
Hi Vinay, On 2024-01-04 at 17:10:00 -0800, Vinay Belgaumkar wrote: looks good, there are some nits, first about subject: [PATCH i-g-t] tests/perf_pmu: Restore sysfs freq in exit handler s!tests/perf_pmu:!tests/intel/perf_pmu:! Also you can drop "sysfs", so it will look: [PATCH i-g-t] tests/inte

[PATCH] drm/i915/display: Use helper to select C20 MPLLA/B

2024-01-05 Thread Mika Kahola
We used to select between MPLLA/B with the following state->tx[0] & C20_PHY_USE_MPLLB Since this is used a few places within C20 PLL setting, let's introduce a helper function to clean up the code a bit. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 17 +

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-05 Thread Tvrtko Ursulin
On 04/01/2024 21:23, Andi Shyti wrote: Hi Tvrtko, [1] + /* +* Loop over all available slices and assign each a user engine. +* +* With 1 engine (ccs0): +* slice 0, 1, 2, 3: ccs0 +* +* With 2 engines (ccs0, ccs1): +* slice 0, 2

Re: [PATCH 3/3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2024-01-05 Thread Andi Shyti
Hi Jani, On Thu, Jan 04, 2024 at 10:16:32PM +0200, Jani Nikula wrote: > hdmi-codec.h does not appear to directly need drm/drm_edid.h for > anything. Remove it. > > There are some files that get drm/drm_edid.h by proxy; include it where > needed. > > v2-v4: Fix build (kernel test robot ) > > Cc:

Re: [PATCH 2/3] drm/hisilicon: include drm/drm_edid.h only where needed

2024-01-05 Thread Andi Shyti
Hi Jani, On Thu, Jan 04, 2024 at 10:16:31PM +0200, Jani Nikula wrote: > Reduce the need for rebuilds when drm_edid.h is modified by including it > only where needed. > > Cc: Xinliang Liu > Cc: Tian Tao > Cc: Xinwei Kong > Cc: Sumit Semwal > Cc: Yongqin Liu > Cc: John Stultz > Signed-off-by

Re: [PATCH 1/3] drm/nouveau: include drm/drm_edid.h only where needed

2024-01-05 Thread Andi Shyti
Hi Jani, On Thu, Jan 04, 2024 at 10:16:30PM +0200, Jani Nikula wrote: > Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 > files when drm_edid.h is modified, while there are only a few files that > actually need to include drm_edid.h. > > Cc: Karol Herbst > Cc: Lyude Paul

Re: [PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

2024-01-05 Thread Andi Shyti
Hi Jani, On Thu, Jan 04, 2024 at 06:46:00PM +0200, Jani Nikula wrote: > intel_wakeref_t is supposed to be a mostly opaque cookie to its > users. It should only be checked for being non-zero and set to > zero. Debug logging its actual value is meaningless. Switch to just > debug logging whether the

Re: [RESEND] drm/edid: prefer forward declarations over includes in drm_edid.h

2024-01-05 Thread Thomas Zimmermann
Am 04.01.24 um 22:10 schrieb Jani Nikula: There's no need to include either linux/hdmi.h or drm/drm_mode.h. They can be removed by using forward declarations. While at it, group the forward declarations together, and remove the unnecessary ones. Signed-off-by: Jani Nikula Reviewed-by: Thom