Re: [PATCH 1/7] drm: Add eDP 1.5 early transport definition

2024-01-10 Thread Hogander, Jouni
Hello All, I accidentally pushed this patch into drm-intel/drm-intel-next. Hopefully this doesn't cause problems. I'm very sorry for inconvenience. Best Regards, Jouni Högander On Wed, 2024-01-03 at 10:46 +, Kahola, Mika wrote: > > -Original Message- > > From: Intel-gfx On Behalf >

Re: Rework TTMs busy handling

2024-01-10 Thread Michel Dänzer
On 2024-01-09 09:34, Christian König wrote: > Am 09.01.24 um 09:14 schrieb Thomas Hellström: >> On Tue, 2024-01-09 at 08:47 +0100, Christian König wrote: >>> >>> I'm trying to make this functionality a bit more useful for years now >>> since we multiple reports that behavior of drivers can be subop

Re: [PATCH v2 13/15] drm/i915/fbdev: Fix smem_start for LMEMBAR stolen objects

2024-01-10 Thread Andrzej Hajda
On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä The "io" address of an object is its dma address minus the region.start. Subtract the latter to make smem_start correct. The current code happens to work for genuine LMEM objects as LMEM region.start==0, but for LMEMBAR stolen object

Re: [PATCH v2 04/15] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

2024-01-10 Thread Andrzej Hajda
On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä On MTL accessing stolen memory via the BARs is somehow borked, and it can hang the machine. As a workaround let's bypass the BARs and just go straight to DSMBASE/GSMBASE instead. Note that on every other platform this itself would h

Re: [PATCH 1/3] drm/nouveau: include drm/drm_edid.h only where needed

2024-01-10 Thread Jani Nikula
On Tue, 09 Jan 2024, Danilo Krummrich wrote: > On 1/9/24 10:59, Jani Nikula wrote: >> On Mon, 08 Jan 2024, Danilo Krummrich wrote: >>> On 1/4/24 21:16, Jani Nikula wrote: Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 files when drm_edid.h is modified, while ther

disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Christoph Hellwig
Hi all, Darrick reported that the fairly new XFS xfile code blows up when force enabling large folio for shmem. This series fixes this quickly by disabling large folios for this particular shmem file for now until it can be fixed properly, which will be a lot more invasive. I've added most of yo

[PATCH 1/2] mm: add a mapping_clear_large_folios helper

2024-01-10 Thread Christoph Hellwig
Users of shmem_kernel_file_setup might not be able to deal with large folios (yet). Give them a way to disable large folio support on their mapping. Signed-off-by: Christoph Hellwig --- include/linux/pagemap.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/linux/pag

[PATCH 2/2] xfs: disable large folio support in xfile_create

2024-01-10 Thread Christoph Hellwig
The xfarray code will crash if large folios are force enabled using: echo force > /sys/kernel/mm/transparent_hugepage/shmem_enabled Fixing this will require a bit of an API change, and prefeably sorting out the hwpoison story for pages vs folio and where it is placed in the shmem API. For now

Re: [PATCH 3/3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2024-01-10 Thread Jani Nikula
On Thu, 04 Jan 2024, Jani Nikula wrote: > hdmi-codec.h does not appear to directly need drm/drm_edid.h for > anything. Remove it. Jaroslav, Takashi, ack for merging this via the drm trees, please? BR, Jani. > > There are some files that get drm/drm_edid.h by proxy; include it where > needed. >

Re: [Intel-gfx] [PATCH] drm/i915: Fix bigjoiner case for DP2.0

2024-01-10 Thread Lisovskiy, Stanislav
On Fri, Oct 13, 2023 at 01:43:46PM +0300, Ville Syrjälä wrote: > On Fri, Oct 13, 2023 at 01:00:00AM +0530, vsrini4 wrote: > > Patch calculates bigjoiner pipes in mst compute. > > Patch also passes bigjoiner bool to validate plane > > max size. > > I doubt this is sufficient. The modeset sequence i

Re: [PATCH 5/7] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2024-01-10 Thread Maxime Ripard
Hi, On Tue, Jan 09, 2024 at 06:11:02PM +, Andri Yngvason wrote: > From: Werner Sembach > > Add a new general drm property "preferred color format" which can be used > by userspace to tell the graphic drivers to which color format to use. > > Possible options are: > - auto (default/curre

Re: [PATCH v2 14/15] drm/i915: Tweak BIOS fb reuse check

2024-01-10 Thread Andrzej Hajda
On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä Currently we assume that we bind the BIOS fb exactly into the same ggtt address where the BIOS left it. That is about to change, and in order to keep intel_reuse_initial_plane_obj() working as intended we need to compare the original

Re: [PATCH v2 15/15] drm/i915: Try to relocate the BIOS fb to the start of ggtt

2024-01-10 Thread Andrzej Hajda
On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä On MTL the GOP (for whatever reason) likes to bind its framebuffer high up in the ggtt address space. This can conflict with whatever ggtt_reserve_guc_top() is trying to do, and the result is that ggtt_reserve_guc_top() fails and the

Re: [PATCH v2 05/15] drm/i915: Disable the "binder"

2024-01-10 Thread Andrzej Hajda
On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä Now that the GGTT PTE updates go straight to GSMBASE (bypassing GTTMMADR) there should be no more risk of system hangs? So the "binder" (ie. update the PTEs via MI_UPDATE_GTT) is no longer necessary, disable it. TODO: MI_UPDATE_GTT

RE: ✗ Fi.CI.IGT: failure for Update bxt_sanitize_cdclk() for Xe2_LPD (rev3)

2024-01-10 Thread Illipilli, TejasreeX
Hi, https://patchwork.freedesktop.org/series/128175/ - Re-reported Thanks, Tejasree -Original Message- From: I915-ci-infra On Behalf Of Gustavo Sousa Sent: Monday, January 8, 2024 11:07 PM To: i915-ci-in...@lists.freedesktop.org; Patchwork ; intel-gfx@lists.freedesktop.org Cc: intel-g

RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-10 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, January 9, 2024 2:58 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org; > Deak, Imre > Subject: RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST > > On Tue, 09 Jan 2024, "Murthy, Arun R" wrote: > >> -O

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-10 Thread Daniel Vetter
On Tue, Jan 09, 2024 at 11:12:11PM +, Andri Yngvason wrote: > Hi Daniel, > > þri., 9. jan. 2024 kl. 22:32 skrifaði Daniel Stone : > > > On Tue, 9 Jan 2024 at 18:12, Andri Yngvason wrote: > > > + * active color format: > > > + * This read-only property tells userspace the color format > >

Re: [PATCH v2 04/15] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

2024-01-10 Thread Nirmoy Das
Hi Ville, Apologies, but I lost track of this series after I returned from sick leave. On 12/15/2023 11:59 AM, Ville Syrjala wrote: From: Ville Syrjälä On MTL accessing stolen memory via the BARs is somehow borked, and it can hang the machine. As a workaround let's bypass the BARs and just g

RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-10 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, January 9, 2024 2:59 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org; > Deak, Imre > Subject: RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST > > On Tue, 09 Jan 2024, Jani Nikula wrote: > > On Tue, 09

Re: drm/i915: Add bigjoiner force enable option to debugfs

2024-01-10 Thread Joshi, Kunal1
Hello Stan, On 11/16/2023 4:07 PM, Stanislav Lisovskiy wrote: For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs. v2: - Apparently intel_dp_need_bigjoiner can't be used, when

RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-10 Thread Jani Nikula
On Wed, 10 Jan 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Tuesday, January 9, 2024 2:59 PM >> To: Murthy, Arun R ; >> intel-gfx@lists.freedesktop.org; >> Deak, Imre >> Subject: RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST >> >> On

[PATCH v1 0/2] drm/xe: ensure fbc cfb size to be page size aligned

2024-01-10 Thread Vinod Govindapillai
DRM gem object handling expet the object size to be page size aligned. Neither the driver or xe stolen memory handlers do that causing BUG_ON being triggered in some cases. Vinod Govindapillai (2): drm/i915/display: use PAGE_SIZE macro for FBC cfb alloc drm/xe: Modify the cfb size to be page s

[PATCH v1 1/2] drm/i915/display: use PAGE_SIZE macro for FBC cfb alloc

2024-01-10 Thread Vinod Govindapillai
FBC compressed frame buffer size need to be PAGE_SIZE aligned and the corresponding the drm_gem functions check the object size alignment using PAGE_SIZE macro. Use the PAGE_SIZE macro in the cfb alloc as well instead of the magic number. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i9

[PATCH v1 2/2] drm/xe: Modify the cfb size to be page size aligned for FBC

2024-01-10 Thread Vinod Govindapillai
drm_gem_private_object_init expect the object size be page size aligned. The xe_bo create functions do not update the size for any alignment requirements. So align cfb size to be page size aligned in xe stolen memory handling. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/xe/compat-i915

RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-10 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, January 10, 2024 4:24 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org; > Deak, Imre > Subject: RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST > > On Wed, 10 Jan 2024, "Murthy, Arun R" wrote: > >> -

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

2024-01-10 Thread Daniel Vetter
On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: > From: Werner Sembach > > This commit implements the "active color format" drm property for the AMD > GPU driver. > > Signed-off-by: Werner Sembach > Signed-off-by: Andri Yngvason > Tested-by: Andri Yngvason > --- > .../gpu/drm

Re: [PATCH v2 04/15] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

2024-01-10 Thread Nirmoy Das
On 1/10/2024 11:49 AM, Nirmoy Das wrote: Hi Ville, Apologies, but I lost track of this series after I returned from sick leave. Please ignore the uncontextual "but" in the previous response. I need to disable auto correct options. Regards, Nirmoy On 12/15/2023 11:59 AM, Ville Syrj

Re: [RFC 00/15] VBT read Cleanup

2024-01-10 Thread Jani Nikula
On Mon, 08 Jan 2024, Radhakrishna Sripada wrote: > This series does the VBT read cleanup. The series introduces new > intel_vbt structure to cache and collate vbt related info. Vbt > read from different sources viz. firmware/opregion/spi/oprom > needs to be cached for debug purposes and handled a

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Matthew Wilcox
On Wed, Jan 10, 2024 at 10:21:07AM +0100, Christoph Hellwig wrote: > Hi all, > > Darrick reported that the fairly new XFS xfile code blows up when force > enabling large folio for shmem. This series fixes this quickly by disabling > large folios for this particular shmem file for now until it can

Re: [PATCH 1/2] drm/i915/display: No need for full modeset due to psr

2024-01-10 Thread Lisovskiy, Stanislav
On Tue, Jan 09, 2024 at 12:05:16PM +0200, Jouni Högander wrote: > There is no specific reason to force full modeset if psr is enabled. > > Signed-off-by: Jouni Högander > Tested-by: Paz Zcharya Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_display.c | 7 ---

Re: [PATCH 2/2] drm/i915/psr: CAN_PSR and CAN_PANEL_REPLAY can be now local defines

2024-01-10 Thread Lisovskiy, Stanislav
On Tue, Jan 09, 2024 at 12:05:17PM +0200, Jouni Högander wrote: > CAN_PSR and CAN_PANEL_REPLAY are not used outside intel_psr.c anymore. Make > them as intel_psr.c local defines. > > Signed-off-by: Jouni Högander Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_psr.

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

2024-01-10 Thread Daniel Vetter
On Wed, 10 Jan 2024 at 13:53, Andri Yngvason wrote: > > mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter : > > > > On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: > > > + /* Extract information from crtc to communicate it to userspace as > > > connector properties */ > > >

[PATCH v2 00/13] Panel replay selective update support

2024-01-10 Thread Jouni Högander
This patch set is implementing panel replay selective update support for Intel hardware. It is also fixing couple of exisiting issues in current panel replay implementation: ALPM status is checked even on DP (non eDP) PSR capability change is checked even when using panel replay Make psr pause/re

[PATCH v2 01/13] drm/i915/psr: Disable panel replay for now

2024-01-10 Thread Jouni Högander
Panel replay is not completely validated yet. Let's disable it for now. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_psr.c | 10 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/

[PATCH v2 04/13] drm/i915/psr: Unify panel replay enable sink

2024-01-10 Thread Jouni Högander
Panel replay enable for a sink is currently done in intel_ddi.c:intel_ddi_pre_enable_dp. Move it to intel_psr_enable_sink to unify psr/panel replay paths. Also enable some additional hpd interrupts for panel replay. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_ddi.c | 7

[PATCH v2 03/13] drm/i915/psr: Do not check alpm on DP or capability change for panel replay

2024-01-10 Thread Jouni Högander
Alpm is eDP specific. Do not check if not eDP. Also panel replay doesn't know about capability changes -> no need to check that. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i

[PATCH v2 02/13] drm/i915/psr: Intel_psr_pause/resume needs to support panel replay

2024-01-10 Thread Jouni Högander
Currently intel_psr_pause and intel_psr_resume do nothing in case of panel replay. Change them to perform pause and return also in case of panel replay. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH v2 05/13] drm/i915/psr: Rename has_psr2 as has_sel_update

2024-01-10 Thread Jouni Högander
We are going to reuse has_psr2 for panel_replay as well. Rename it as has_sel_update to avoid confusion. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 5 +++-- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/int

[PATCH v2 06/13] drm/i915/psr: Rename psr2_enabled as sel_update_enabled

2024-01-10 Thread Jouni Högander
We are about to reuse psr2_enabled for panel replay as well. Rename it as sel_update_enabled to avoid confusion. Signed-off-by: Jouni Högander --- .../drm/i915/display/intel_display_types.h| 2 +- drivers/gpu/drm/i915/display/intel_psr.c | 52 +-- 2 files changed, 27 in

[PATCH v2 07/13] drm/i915/psr: Add some documentation of variables used in psr code

2024-01-10 Thread Jouni Högander
We are adding more boolean variable into intel_psr and intel_crtc_state structs. Add some documentation about these for sake of clarity. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/dr

[PATCH v2 08/13] drm/i915/psr: Add sink_panel_replay_su_support to intel_psr

2024-01-10 Thread Jouni Högander
Add new boolean to store panel replay selective update support of sink. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/inte

[PATCH v2 10/13] drm/i915/psr: Split intel_psr2_config_valid for panel replay

2024-01-10 Thread Jouni Högander
Part of intel_psr2_config_valid is valid for panel replay. rename it as intel_sel_update_config_valid. Split psr2 specific part and name it as intel_psr2_config_valid. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 60 +++- 1 file changed, 38 ins

[PATCH v2 09/13] drm/i915/psr: Detect panel replay selective update support

2024-01-10 Thread Jouni Högander
Detect panel replay selective update support and store it into intel_psr->sink_panel_replay_su_support. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr

[PATCH v2 11/13] drm/panelreplay: dpcd register definition for panelreplay SU

2024-01-10 Thread Jouni Högander
Add definitions for panel replay selective update v2: Remove unnecessary Cc from commit message Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 281afff6ee4e

[PATCH v2 12/13] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay

2024-01-10 Thread Jouni Högander
Currently intel_dp_get_su_granularity doesn't support panel replay. This fix modifies it to support panel replay as well. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 59 +--- 1 file changed, 53 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH v2 13/13] drm/i915/psr: Add panel replay sel update support to debugfs interface

2024-01-10 Thread Jouni Högander
Add panel replay selective update support to debugfs status interface. In case of sink supporting panel replay we will print out: Sink support: PSR = no, Panel Replay = yes, Panel Replay Selective Update = yes and PSR mode will look like this if printing out enabled panel replay selective update:

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

2024-01-10 Thread Werner Sembach
Hi, Am 10.01.24 um 14:09 schrieb Daniel Vetter: On Wed, 10 Jan 2024 at 13:53, Andri Yngvason wrote: mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter : On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: + /* Extract information from crtc to communicate it to userspace as

Re: [PATCH 5/7] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2024-01-10 Thread Werner Sembach
Hi, Am 10.01.24 um 11:11 schrieb Andri Yngvason: Hi, mið., 10. jan. 2024 kl. 09:27 skrifaði Maxime Ripard : On Tue, Jan 09, 2024 at 06:11:02PM +, Andri Yngvason wrote: From: Werner Sembach Add a new general drm property "preferred color format" which can be used by userspace to tell the

Re: [PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-01-10 Thread Hogander, Jouni
On Thu, 2024-01-04 at 12:59 +0200, Dmitry Baryshkov wrote: > On Thu, 4 Jan 2024 at 12:49, Jouni Högander > wrote: > > > > Add definitions for panel replay selective update > > > > Cc: dri-de...@lists.freedesktop.org > > > > 1) This CC should not be necessary. It is already a part of > maintain

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-10 Thread Daniel Stone
Hi, On Wed, 10 Jan 2024 at 10:44, Daniel Vetter wrote: > On Tue, Jan 09, 2024 at 11:12:11PM +, Andri Yngvason wrote: > > ţri., 9. jan. 2024 kl. 22:32 skrifađi Daniel Stone : > > > How does userspace determine what's happened without polling? Will it > > > only change after an `ALLOW_MODESET`

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-10 Thread Werner Sembach
Hi, Am 09.01.24 um 19:10 schrieb Andri Yngvason: From: Werner Sembach Add a new general drm property "active color format" which can be used by graphic drivers to report the used color format back to userspace. There was no way to check which color format got actually used on a given monitor.

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] mm: add a mapping_clear_large_folios helper

2024-01-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] mm: add a mapping_clear_large_folios helper URL : https://patchwork.freedesktop.org/series/128420/ State : warning == Summary == Error: dim checkpatch failed e1a8add4aba0 mm: add a mapping_clear_large_folios helper 0faf35dc1522 xfs: disab

✗ Fi.CI.SPARSE: warning for series starting with [1/2] mm: add a mapping_clear_large_folios helper

2024-01-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] mm: add a mapping_clear_large_folios helper URL : https://patchwork.freedesktop.org/series/128420/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 5/7] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2024-01-10 Thread Werner Sembach
Hi, Am 10.01.24 um 14:42 schrieb Andri Yngvason: mið., 10. jan. 2024 kl. 13:09 skrifaði Werner Sembach: Hi, Am 10.01.24 um 11:11 schrieb Andri Yngvason: Hi, mið., 10. jan. 2024 kl. 09:27 skrifaði Maxime Ripard: On Tue, Jan 09, 2024 at 06:11:02PM +, Andri Yngvason wrote: From: Werner Se

✗ Fi.CI.BAT: failure for series starting with [1/2] mm: add a mapping_clear_large_folios helper

2024-01-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] mm: add a mapping_clear_large_folios helper URL : https://patchwork.freedesktop.org/series/128420/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14108 -> Patchwork_128420v1

✗ Fi.CI.SPARSE: warning for drm/xe: ensure fbc cfb size to be page size aligned

2024-01-10 Thread Patchwork
== Series Details == Series: drm/xe: ensure fbc cfb size to be page size aligned URL : https://patchwork.freedesktop.org/series/128425/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/a

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Joonas Lahtinen
Quoting Matthew Wilcox (2024-01-10 14:37:18) > On Wed, Jan 10, 2024 at 10:21:07AM +0100, Christoph Hellwig wrote: > > Hi all, > > > > Darrick reported that the fairly new XFS xfile code blows up when force > > enabling large folio for shmem. This series fixes this quickly by disabling > > large f

✓ Fi.CI.BAT: success for drm/xe: ensure fbc cfb size to be page size aligned

2024-01-10 Thread Patchwork
== Series Details == Series: drm/xe: ensure fbc cfb size to be page size aligned URL : https://patchwork.freedesktop.org/series/128425/ State : success == Summary == CI Bug Log - changes from CI_DRM_14108 -> Patchwork_128425v1 Summary -

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2024-01-10 17:20:24) > Quoting Matthew Wilcox (2024-01-10 14:37:18) > > On Wed, Jan 10, 2024 at 10:21:07AM +0100, Christoph Hellwig wrote: > > > Hi all, > > > > > > Darrick reported that the fairly new XFS xfile code blows up when force > > > enabling large folio for shmem

Re: [PATCH 1/3] drm/i915/hdcp: Do intel_hdcp_component_init() much later during init

2024-01-10 Thread Andrzej Hajda
On 15.12.2023 12:09, Ville Syrjala wrote: From: Ville Syrjälä intel_hdcp_component_init()->...->intel_hdcp_gsc_initialize_message() will allocate ggtt address space for some hdcp gsc message thing. That is currently being done way too early as we haven't even taken over the BIOS fb yet. So this

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Matthew Wilcox
On Wed, Jan 10, 2024 at 05:28:22PM +0200, Joonas Lahtinen wrote: > Quoting Joonas Lahtinen (2024-01-10 17:20:24) > > However we specifically pass "huge=within_size" to vfs_kern_mount when > > creating a private mount of tmpfs for the purpose of i915 created > > allocations. > > > > Older hardware

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Andrew Morton
On Wed, 10 Jan 2024 10:21:07 +0100 Christoph Hellwig wrote: > Hi all, > > Darrick reported that the fairly new XFS xfile code blows up when force > enabling large folio for shmem. This series fixes this quickly by disabling > large folios for this particular shmem file for now until it can be f

Re: [PATCH 2/3] drm/i915/hdcp: Pin the hdcp gsc message high in ggtt

2024-01-10 Thread Andrzej Hajda
On 15.12.2023 12:09, Ville Syrjala wrote: From: Ville Syrjälä AFAICS there is no hardware restriction on where in ggtt the hdcp gsc message object needs to be bound. And as it's a regular shmem object we don't need it be in the mappabe range either. So pin it high to make avoid needlessly wasti

Re: [PATCH 3/3] drm/i915: Pin error_capture to high end of mappable

2024-01-10 Thread Andrzej Hajda
On 15.12.2023 12:09, Ville Syrjala wrote: From: Ville Syrjälä If we fail to pin error_capture to the start of ggtt (which is likely given the BIOS fb is usually there), we currently fall back to pinning it at the next available low address. This seems somewhat sub-optimal to me in case we later

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Christoph Hellwig
On Wed, Jan 10, 2024 at 07:38:43AM -0800, Andrew Morton wrote: > I assume that kernels which contain 137db333b29186 ("xfs: teach xfile > to pass back direct-map pages to caller") want this, so a Fixes: that > and a cc:stable are appropriate? I think it needs to back all the way back to 3934e8ebb7c

Re: disable large folios for shmem file used by xfs xfile

2024-01-10 Thread Christoph Hellwig
On Wed, Jan 10, 2024 at 12:37:18PM +, Matthew Wilcox wrote: > On Wed, Jan 10, 2024 at 10:21:07AM +0100, Christoph Hellwig wrote: > > Hi all, > > > > Darrick reported that the fairly new XFS xfile code blows up when force > > enabling large folio for shmem. This series fixes this quickly by di

[PATCH 0/6] drm: enable W=1 warnings by default across the subsystem

2024-01-10 Thread Jani Nikula
This is v2 of [1] to enable most W=1 warnings across the drm subsystem. Some fixes first, and a CONFIG_DRM_WERROR on top. I build tested this for x86 (both gcc and clang), arm and arm64. BR, Jani. [1] https://lore.kernel.org/r/20231129181219.1237887-1-jani.nik...@intel.com Jani Nikula (6):

[PATCH 2/6] drm/nouveau/svm: remove unused but set variables

2024-01-10 Thread Jani Nikula
Fix the W=1 warning -Wunused-but-set-variable. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/nouveau_svm.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu

[PATCH 3/6] drm/amdgpu: prefer snprintf over sprintf

2024-01-10 Thread Jani Nikula
This will trade the W=1 warning -Wformat-overflow to -Wformat-truncation. This lets us enable -Wformat-overflow subsystem wide. Cc: Alex Deucher Cc: Christian König Cc: Pan, Xinhui Cc: amd-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++-

[PATCH 1/6] drm/nouveau/acr/ga102: remove unused but set variable

2024-01-10 Thread Jani Nikula
Fix the W=1 warning -Wunused-but-set-variable. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu

[PATCH 4/6] drm/imx: prefer snprintf over sprintf

2024-01-10 Thread Jani Nikula
This will trade the W=1 warning -Wformat-overflow to -Wformat-truncation. This lets us enable -Wformat-overflow subsystem wide. Cc: Philipp Zabel Signed-off-by: Jani Nikula --- drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[PATCH 5/6] drm: enable (most) W=1 warnings by default across the subsystem

2024-01-10 Thread Jani Nikula
At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend most of the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to compare

[PATCH 6/6] drm: Add CONFIG_DRM_WERROR

2024-01-10 Thread Jani Nikula
Add kconfig to enable -Werror subsystem wide. This is useful for development and CI to keep the subsystem warning free, while avoiding issues outside of the subsystem that kernel wide CONFIG_WERROR=y might hit. Signed-off-by: Jani Nikula --- drivers/gpu/drm/Kconfig | 18 ++ driv

✗ Fi.CI.SPARSE: warning for Panel replay selective update support (rev2)

2024-01-10 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev2) URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev2)

2024-01-10 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev2) URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim checkpatch failed af6e1b067218 drm/i915/psr: Disable panel replay for now 1ad3b9a2a48a drm/i915/psr: Intel_psr_pause/resume

✓ Fi.CI.BAT: success for Panel replay selective update support (rev2)

2024-01-10 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev2) URL : https://patchwork.freedesktop.org/series/128193/ State : success == Summary == CI Bug Log - changes from CI_DRM_14108 -> Patchwork_128193v2 Summary --- *

✗ Fi.CI.SPARSE: warning for drm/i915: Rework global state serialization (rev2)

2024-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Rework global state serialization (rev2) URL : https://patchwork.freedesktop.org/series/127968/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915: Rework global state serialization (rev2)

2024-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Rework global state serialization (rev2) URL : https://patchwork.freedesktop.org/series/127968/ State : success == Summary == CI Bug Log - changes from CI_DRM_14108 -> Patchwork_127968v2 Summary --

[bug report] drm/i915/gt: Use i915_vm_put on ppgtt_create error paths

2024-01-10 Thread Dan Carpenter
Hello Chris Wilson, This is a semi-automatic email about new static checker warnings. The patch c286558f5853: "drm/i915/gt: Use i915_vm_put on ppgtt_create error paths" from Sep 26, 2022, leads to the following Smatch complaint: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:274 gen6_ppgtt_cleanup()

✗ Fi.CI.CHECKPATCH: warning for drm: enable W=1 warnings by default across the subsystem (rev2)

2024-01-10 Thread Patchwork
== Series Details == Series: drm: enable W=1 warnings by default across the subsystem (rev2) URL : https://patchwork.freedesktop.org/series/127072/ State : warning == Summary == Error: dim checkpatch failed e933bc518dbe drm/nouveau/acr/ga102: remove unused but set variable 3d19a8353d23 drm/nou

✗ Fi.CI.SPARSE: warning for drm: enable W=1 warnings by default across the subsystem (rev2)

2024-01-10 Thread Patchwork
== Series Details == Series: drm: enable W=1 warnings by default across the subsystem (rev2) URL : https://patchwork.freedesktop.org/series/127072/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm: enable W=1 warnings by default across the subsystem (rev2)

2024-01-10 Thread Patchwork
== Series Details == Series: drm: enable W=1 warnings by default across the subsystem (rev2) URL : https://patchwork.freedesktop.org/series/127072/ State : success == Summary == CI Bug Log - changes from CI_DRM_14108 -> Patchwork_127072v2 S

Re: [PATCH] drm/xe/display: Disable aux ccs framebuffers

2024-01-10 Thread Rodrigo Vivi
On Tue, Jan 09, 2024 at 08:40:24PM +, Souza, Jose wrote: > On Mon, 2024-01-08 at 17:18 -0500, Rodrigo Vivi wrote: > > On Tue, Jan 02, 2024 at 09:44:48PM +0200, Jani Nikula wrote: > > > On Tue, 02 Jan 2024, Juha-Pekka Heikkila > > > wrote: > > > > Aux ccs framebuffers don't work on Xe driver h

Re: [PATCH] drm/i915/gt: Use rc6.supported flag from intel_gt for rc6_enable sysfs

2024-01-10 Thread Rodrigo Vivi
On Tue, Jan 09, 2024 at 05:03:00PM -0800, Juan Escamilla wrote: > Currently if rc6 is supported, it gets enabled and the sysfs files for > rc6_enable_show and rc6_enable_dev_show uses masks to check information > from drm_i915_private. > > However rc6_support functions take more variables and co

Re: [PATCH 5/6] drm: enable (most) W=1 warnings by default across the subsystem

2024-01-10 Thread Hamza Mahfooz
On 1/10/24 12:39, Jani Nikula wrote: At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend most of the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with s/KBUILD_CFLAGS/subdir-

Re: [PATCH 6/6] drm: Add CONFIG_DRM_WERROR

2024-01-10 Thread Hamza Mahfooz
On 1/10/24 12:39, Jani Nikula wrote: Add kconfig to enable -Werror subsystem wide. This is useful for development and CI to keep the subsystem warning free, while avoiding issues outside of the subsystem that kernel wide CONFIG_WERROR=y might hit. Signed-off-by: Jani Nikula Reviewed-by: Hamza

[PATCH] drm/i915/gt: Restart the heartbeat timer when forcing a pulse

2024-01-10 Thread John . C . Harrison
From: John Harrison The context persistence code does things like send super high priority heartbeat pulses to ensure any leaked context can still be pre-empted and thus isn't a total denial of service but only a minor denial of service. Unfortunately, it wasn't bothering to restart the heatbeat

✓ Fi.CI.BAT: success for drm/i915/gt: Restart the heartbeat timer when forcing a pulse

2024-01-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Restart the heartbeat timer when forcing a pulse URL : https://patchwork.freedesktop.org/series/128458/ State : success == Summary == CI Bug Log - changes from CI_DRM_14109 -> Patchwork_128458v1 Sum

RE: [PATCH v2 01/13] drm/i915/psr: Disable panel replay for now

2024-01-10 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Wednesday, January 10, 2024 6:43 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v2 01/13] drm/i915/psr: Disable panel replay for now > > Panel replay is not completely validated yet. Let's disable i

RE: [PATCH v2 02/13] drm/i915/psr: Intel_psr_pause/resume needs to support panel replay

2024-01-10 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Wednesday, January 10, 2024 6:43 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v2 02/13] drm/i915/psr: Intel_psr_pause/resume needs to > support panel replay > > Currently intel_psr_pause and intel

RE: [PATCH v2 03/13] drm/i915/psr: Do not check alpm on DP or capability change for panel replay

2024-01-10 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Wednesday, January 10, 2024 6:43 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v2 03/13] drm/i915/psr: Do not check alpm on DP or > capability change for panel replay > > Alpm is eDP specific. Do n

Re: [PATCH v2 03/13] drm/i915/psr: Do not check alpm on DP or capability change for panel replay

2024-01-10 Thread Hogander, Jouni
On Thu, 2024-01-11 at 06:14 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Wednesday, January 10, 2024 6:43 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 03/13] drm/i915/psr: Do not check alpm

Re: [PATCH] nightly.conf: Add the xe repo to drm-tip

2024-01-10 Thread Thomas Hellström
On Mon, 2024-01-08 at 16:22 -0600, Lucas De Marchi wrote: > On Mon, Jan 08, 2024 at 05:13:51PM -0500, Rodrigo Vivi wrote: > > On Wed, Jan 03, 2024 at 11:59:16PM -0600, Lucas De Marchi wrote: > > > On Wed, Jan 03, 2024 at 02:50:57PM +0100, Thomas Hellström wrote: > > > > On Tue, 2023-12-26 at 13:30