Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-25 Thread Daniel Vetter
On Tue, Jan 23, 2024 at 06:09:05AM +, Jason-JH Lin (林睿祥) wrote: > Hi Maxime, Daniel, > > We encountered similar issue with mediatek SoCs. > > We have found that in drm_atomic_helper_commit_rpm(), when disabling > the cursor plane, the old_state->legacy_cursor_update in > drm_atomic_wait_for_v

Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-01-25 Thread Souza, Jose
On Thu, 2024-01-25 at 17:56 +0200, Juha-Pekka Heikkila wrote: > On 25.1.2024 17.28, Souza, Jose wrote: > > On Thu, 2024-01-25 at 17:25 +0200, Juha-Pekka Heikkila wrote: > > > AuxCCS framebuffers don't work on Xe driver hence disable them > > > from plane capabilities until they are fixed. FlatCCS f

✓ Fi.CI.BAT: success for drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-01-25 Thread Patchwork
== Series Details == Series: drm/i915/display: Disable AuxCCS framebuffers if built for Xe URL : https://patchwork.freedesktop.org/series/129166/ State : success == Summary == CI Bug Log - changes from CI_DRM_14179 -> Patchwork_129166v1 Sum

Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-01-25 Thread Juha-Pekka Heikkila
On 25.1.2024 17.28, Souza, Jose wrote: On Thu, 2024-01-25 at 17:25 +0200, Juha-Pekka Heikkila wrote: AuxCCS framebuffers don't work on Xe driver hence disable them from plane capabilities until they are fixed. FlatCCS framebuffers work and they are left enabled. CCS is left untouched for i915 de

Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-01-25 Thread Souza, Jose
On Thu, 2024-01-25 at 17:25 +0200, Juha-Pekka Heikkila wrote: > AuxCCS framebuffers don't work on Xe driver hence disable them > from plane capabilities until they are fixed. FlatCCS framebuffers > work and they are left enabled. CCS is left untouched for i915 > deriver. > > Closes: https://gitlab

[PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-01-25 Thread Juha-Pekka Heikkila
AuxCCS framebuffers don't work on Xe driver hence disable them from plane capabilities until they are fixed. FlatCCS framebuffers work and they are left enabled. CCS is left untouched for i915 deriver. Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/933 Signed-off-by: Juha-Pekka Heik

Re: Re: [PATCH v3 05/16] drm/i915: Disable the "binder"

2024-01-25 Thread Michał Winiarski
On Thu, Jan 25, 2024 at 11:08:04AM +0200, Ville Syrjälä wrote: > On Fri, Jan 19, 2024 at 01:12:11AM +0200, Ville Syrjälä wrote: > > On Wed, Jan 17, 2024 at 06:46:24PM +0100, Nirmoy Das wrote: > > > > > > On 1/17/2024 3:13 PM, Michał Winiarski wrote: > > > > On Tue, Jan 16, 2024 at 09:56:25AM +0200

Re: [PATCH] mm: Remove double faults once write a device pfn

2024-01-25 Thread Christian König
Am 24.01.24 um 12:04 schrieb Alistair Popple: "Zhou, Xianrong" writes: [AMD Official Use Only - General] The vmf_insert_pfn_prot could cause unnecessary double faults on a device pfn. Because currently the vmf_insert_pfn_prot does not make the pfn writable so the pte entry is normally read-o

✓ Fi.CI.BAT: success for drm/i915/fbc: Allow FBC with CCS modifiers on SKL+ (rev4)

2024-01-25 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Allow FBC with CCS modifiers on SKL+ (rev4) URL : https://patchwork.freedesktop.org/series/129075/ State : success == Summary == CI Bug Log - changes from CI_DRM_14178 -> Patchwork_129075v4 Summary

✓ Fi.CI.BAT: success for drm/i915: (stolen) memory region related fixes (rev10)

2024-01-25 Thread Patchwork
== Series Details == Series: drm/i915: (stolen) memory region related fixes (rev10) URL : https://patchwork.freedesktop.org/series/127721/ State : success == Summary == CI Bug Log - changes from CI_DRM_14178 -> Patchwork_127721v10 Summary -

✗ Fi.CI.SPARSE: warning for drm/i915: (stolen) memory region related fixes (rev10)

2024-01-25 Thread Patchwork
== Series Details == Series: drm/i915: (stolen) memory region related fixes (rev10) URL : https://patchwork.freedesktop.org/series/127721/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: (stolen) memory region related fixes (rev10)

2024-01-25 Thread Patchwork
== Series Details == Series: drm/i915: (stolen) memory region related fixes (rev10) URL : https://patchwork.freedesktop.org/series/127721/ State : warning == Summary == Error: dim checkpatch failed 72dda2db9044 drm/i915: Use struct resource for memory region IO as well -:388: WARNING:LONG_LINE

[PATCH v4 06/16] drm/i915: Rename the DSM/GSM registers

2024-01-25 Thread Ville Syrjala
From: Ville Syrjälä 0x108100 and 0x1080c0 have been around since snb. Rename the defines appropriately. v2: Rebase Cc: Paz Zcharya Reviewed-by: Andrzej Hajda Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_ggtt.c|

[PATCH v4 05/16] drm/i915: Disable the "binder"

2024-01-25 Thread Ville Syrjala
From: Ville Syrjälä Now that the GGTT PTE updates go straight to GSMBASE (bypassing GTTMMADR) there should be no more risk of system hangs? So the "binder" (ie. update the PTEs via MI_UPDATE_GTT) is no longer necessary, disable it. My main worry with the MI_UPDATE_GTT are: - only used on this on

[PATCH v4 04/16] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

2024-01-25 Thread Ville Syrjala
From: Ville Syrjälä On MTL accessing stolen memory via the BARs is somehow borked, and it can hang the machine. As a workaround let's bypass the BARs and just go straight to DSMBASE/GSMBASE instead. Note that on every other platform this itself would hang the machine, but on MTL the system firmw

Re: Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-25 Thread Jani Nikula
On Wed, 24 Jan 2024, Gustavo Sousa wrote: > Quoting Yury Norov (2024-01-24 12:27:58-03:00) >>On Wed, Jan 24, 2024 at 08:03:53AM -0600, Lucas De Marchi wrote: >>> On Wed, Jan 24, 2024 at 09:58:26AM +0200, Jani Nikula wrote: >>> > On Tue, 23 Jan 2024, Lucas De Marchi wrote: >>> > > From: Yury Norov

Re: [PATCH v3 05/16] drm/i915: Disable the "binder"

2024-01-25 Thread Ville Syrjälä
On Fri, Jan 19, 2024 at 01:12:11AM +0200, Ville Syrjälä wrote: > On Wed, Jan 17, 2024 at 06:46:24PM +0100, Nirmoy Das wrote: > > > > On 1/17/2024 3:13 PM, Michał Winiarski wrote: > > > On Tue, Jan 16, 2024 at 09:56:25AM +0200, Ville Syrjala wrote: > > >> From: Ville Syrjälä > > >> > > >> Now that

[PULL] drm-xe-fixes

2024-01-25 Thread Thomas Hellstrom
Hi, Dave, Sima The Xe fixes PR for 6.8-rc2. Thanks, Thomas. The following changes since commit 6613476e225e090cc9aad49be7fa504e290dd33d: Linux 6.8-rc1 (2024-01-21 14:11:32 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-fixes-202