Re: [PATCH 1/2] drm/display/dp: Check for MSTM_CAP before MSTM_CTRL write

2024-01-29 Thread Lin, Charlton
On 1/27/2024 12:06 PM, Arun R Murthy wrote: > With DP2.1, multistream packetization and the underneth MST protocol > will be required for SST. So check for MSTM_CAP to see if MST is really > required and skip the MSTM_CTRL write so that we ensure that only the > underneth protocol and the multistre

✗ Fi.CI.BAT: failure for series starting with [v2,1/1] iommu/vt-d: Remove INTEL_IOMMU_BROKEN_GFX_WA

2024-01-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] iommu/vt-d: Remove INTEL_IOMMU_BROKEN_GFX_WA URL : https://patchwork.freedesktop.org/series/129292/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14193 -> Patchwork_129292v1 ===

Re: [PATCH v2 1/1] iommu/vt-d: Remove INTEL_IOMMU_BROKEN_GFX_WA

2024-01-29 Thread Baolu Lu
On 2024/1/30 14:24, Tian, Kevin wrote: From: Lu Baolu Sent: Tuesday, January 30, 2024 2:08 PM Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA option for broken graphics drivers") was introduced 24 years ago as a temporary workaround for graphics drivers that used physical address

RE: [PATCH v2 1/1] iommu/vt-d: Remove INTEL_IOMMU_BROKEN_GFX_WA

2024-01-29 Thread Tian, Kevin
> From: Lu Baolu > Sent: Tuesday, January 30, 2024 2:08 PM > > Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA > option for > broken graphics drivers") was introduced 24 years ago as a temporary > workaround for graphics drivers that used physical addresses for DMA and > avoided DM

[PATCH v2 1/1] iommu/vt-d: Remove INTEL_IOMMU_BROKEN_GFX_WA

2024-01-29 Thread Lu Baolu
Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA option for broken graphics drivers") was introduced 24 years ago as a temporary workaround for graphics drivers that used physical addresses for DMA and avoided DMA APIs. This workaround was disabled by default. As 24 years have passed

Re: Re: Re: [PATCH v2] drm/hwmon: Fix abi doc warnings

2024-01-29 Thread Lucas De Marchi
On Mon, Jan 29, 2024 at 06:36:13PM +0200, Jani Nikula wrote: On Mon, 29 Jan 2024, Rodrigo Vivi wrote: On Mon, Jan 29, 2024 at 09:18:59AM -0600, Lucas De Marchi wrote: no. the issue is not that it doesn't exist, but that the same path is documented in 2 different places. If the interface is exa

Re: linux-next: Tree for Jan 29 (drm/xe/ and FB_IOMEM_HELPERS)

2024-01-29 Thread Randy Dunlap
On 1/28/24 19:30, Stephen Rothwell wrote: > Hi all, > > Changes since 20240125: > > New trees: i2c-host-fixes, i2c-host > on riscv 64-bit or powerpc 64-bit: WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]:

Re: [PATCH 1/2] drm/i915/xe2lpd: Move D2D enable/disable

2024-01-29 Thread Matt Roper
On Fri, Jan 26, 2024 at 02:46:36PM -0800, Lucas De Marchi wrote: > Bits to enable/disable and check state for D2D moved from > XELPDP_PORT_BUF_CTL1 to DDI_BUF_CTL (now named DDI_CTL_DE in the spec). > Make the functions mtl_ddi_disable_d2d() and mtl_ddi_enable_d2d generic > to work with multiple re

✓ Fi.CI.BAT: success for drm/i915/dp: Add jitter WAs for MST/FEC/DSC links

2024-01-29 Thread Patchwork
== Series Details == Series: drm/i915/dp: Add jitter WAs for MST/FEC/DSC links URL : https://patchwork.freedesktop.org/series/129277/ State : success == Summary == CI Bug Log - changes from CI_DRM_14192 -> Patchwork_129277v1 Summary ---

[PATCH 5/6] drm/i915/mtl+: Disable DP/DSC SF insertion at EOL WA

2024-01-29 Thread Imre Deak
Disable the workaround inserting an SF symbol between the last DSC EOC symbol and the subsequent BS symbol. The WA is enabled by default - based on the register's reset value - and Bspec requires disabling it explicitly. Bspec doesn't provide an actual WA ID for this. Bspec: 50054, 65448, 68849 S

[PATCH 3/6] drm/i915/adlp: Add DP MST DPT/DPTP alignment WA (Wa_14014143976)

2024-01-29 Thread Imre Deak
Add a workaround to fix BS-BS jitter issues on MST links, aligning DPT/DPTP MTPs. Bspec: 50050, 55424 Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/d

[PATCH 6/6] drm/i915/mtl: Add DP FEC BS jitter WA

2024-01-29 Thread Imre Deak
Add a workaround to fix BS (blank start) to BS jitter fixes on non-UHBR MST/FEC and UHBR links. Bspec doesn't provide an actual WA ID for this. Bspec: 65448, 50054 Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_reg.h | 1

[PATCH 4/6] drm/i915/adlp+: Add DSC early pixel count scaling WA (Wa_1409098942)

2024-01-29 Thread Imre Deak
Add a workaround to fix timing issues on links with DSC enabled - presumedly related to the audio functionality. Bspec requires enabling this workaround if audio is enabled on ADLP, however Windows enables it whenever DSC is enabled ADLP onwards; follow Windows. Bspec: 50490, 55424 Signed-off-by

[PATCH 2/6] drm/i915/adlp: Add MST short HBlank WA (Wa_14014143976)

2024-01-29 Thread Imre Deak
Add a workaround to fix BS jitter issues on MST links if the HBLANK period is less than 1 MTP. The WA applies only to UHBR rates while on non-UHBR the specification requires disabling it explicitly - presumedly because the register's reset value has the WA enabled. Bspec: 50050, 55424 Signed-off-

[PATCH 1/6] drm/i915/adlp: Add MST FEC BS jitter WA (Wa_14013163432)

2024-01-29 Thread Imre Deak
Add a workaround to fix BS (blank start) to BS jitter issues on MST links when FEC is enabled. Neither Bspec requires this nor Windows clears the WA when disabling the output - presumedly because CHICKEN_MISC_3 gets reset after disabling the pipe/transcoder - so follow suit. Bspec: 50050, 55424 S

[PATCH 0/6] drm/i915/dp: Add jitter WAs for MST/FEC/DSC links

2024-01-29 Thread Imre Deak
Add workarounds to fix jitter issues on non-UHBR/UHBR MST/FEC/DSC links. This fixes at least the output on MTLP + a DELL docking station MST/DSC link with different monitors connected. Imre Deak (6): drm/i915/adlp: Add MST FEC BS jitter WA (Wa_14013163432) drm/i915/adlp: Add MST short HBlank W

Re: Re: [PATCH v2] drm/hwmon: Fix abi doc warnings

2024-01-29 Thread Jani Nikula
On Mon, 29 Jan 2024, Rodrigo Vivi wrote: > On Mon, Jan 29, 2024 at 09:18:59AM -0600, Lucas De Marchi wrote: >> no. the issue is not that it doesn't exist, but that the same path is >> documented in 2 different places. If the interface is exactly the same, >> there could be just 1 place to document

Re: [PATCH v2] drm/hwmon: Fix abi doc warnings

2024-01-29 Thread Dixit, Ashutosh
On Mon, 29 Jan 2024 07:18:59 -0800, Lucas De Marchi wrote: > > On Sat, Jan 27, 2024 at 12:10:08PM -0800, Ashutosh Dixit wrote: > > On Sat, 27 Jan 2024 08:50:40 -0800, Badal Nilawar wrote: > >> > > > > Hi Badal, > > > >> This fixes warnings in xe, i915 hwmon docs > >> > >> Warning: /sys/devices/.../

Re: Re: [PATCH v2] drm/hwmon: Fix abi doc warnings

2024-01-29 Thread Rodrigo Vivi
On Mon, Jan 29, 2024 at 09:18:59AM -0600, Lucas De Marchi wrote: > On Sat, Jan 27, 2024 at 12:10:08PM -0800, Ashutosh Dixit wrote: > > On Sat, 27 Jan 2024 08:50:40 -0800, Badal Nilawar wrote: > > > > > > > Hi Badal, > > > > > This fixes warnings in xe, i915 hwmon docs > > > > > > Warning: /sys/

Re: Re: [PATCH v2] drm/hwmon: Fix abi doc warnings

2024-01-29 Thread Lucas De Marchi
On Sat, Jan 27, 2024 at 12:10:08PM -0800, Ashutosh Dixit wrote: On Sat, 27 Jan 2024 08:50:40 -0800, Badal Nilawar wrote: Hi Badal, This fixes warnings in xe, i915 hwmon docs Warning: /sys/devices/.../hwmon/hwmon/curr1_crit is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-

Re: Re: Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-29 Thread Lucas De Marchi
On Wed, Jan 24, 2024 at 07:27:58AM -0800, Yury Norov wrote: On Wed, Jan 24, 2024 at 08:03:53AM -0600, Lucas De Marchi wrote: On Wed, Jan 24, 2024 at 09:58:26AM +0200, Jani Nikula wrote: > On Tue, 23 Jan 2024, Lucas De Marchi wrote: > > From: Yury Norov > > > > Generalize __GENMASK() to support

✓ Fi.CI.BAT: success for drm/i915: use READ_ONCE() to read vma->iomap in concurrent environment

2024-01-29 Thread Patchwork
== Series Details == Series: drm/i915: use READ_ONCE() to read vma->iomap in concurrent environment URL : https://patchwork.freedesktop.org/series/129271/ State : success == Summary == CI Bug Log - changes from CI_DRM_14191 -> Patchwork_129271v1

✗ Fi.CI.CHECKPATCH: warning for drm/i915: use READ_ONCE() to read vma->iomap in concurrent environment

2024-01-29 Thread Patchwork
== Series Details == Series: drm/i915: use READ_ONCE() to read vma->iomap in concurrent environment URL : https://patchwork.freedesktop.org/series/129271/ State : warning == Summary == Error: dim checkpatch failed ba938f823490 drm/i915: use READ_ONCE() to read vma->iomap in concurrent environ

RE: [PATCH] mm: Remove double faults once write a device pfn

2024-01-29 Thread Zhou, Xianrong
[AMD Official Use Only - General] > The vmf_insert_pfn_prot could cause unnecessary double faults > on a device pfn. Because currently the vmf_insert_pfn_prot does > not make the pfn writable so the pte entry is normally > read-only or dirty catching. > >>>

[PATCH] drm/i915: use READ_ONCE() to read vma->iomap in concurrent environment

2024-01-29 Thread linke li
In function i915_vma_pin_iomap(), vma->iomap is read using READ_ONCE() in line 562 562ptr = READ_ONCE(vma->iomap); while read directly in line 597 592if (unlikely(cmpxchg(&vma->iomap, NULL, ptr))) { 593if (page_unmask_bits(ptr)) 594__i915_gem_object_release_map(vma->o

Re: Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-29 Thread Yury Norov
On Wed, Jan 24, 2024 at 08:03:53AM -0600, Lucas De Marchi wrote: > On Wed, Jan 24, 2024 at 09:58:26AM +0200, Jani Nikula wrote: > > On Tue, 23 Jan 2024, Lucas De Marchi wrote: > > > From: Yury Norov > > > > > > Generalize __GENMASK() to support different types, and implement > > > fixed-types ve

RE: [PATCH] mm: Remove double faults once write a device pfn

2024-01-29 Thread Zhou, Xianrong
[AMD Official Use Only - General] > > The vmf_insert_pfn_prot could cause unnecessary double faults on a > > device pfn. Because currently the vmf_insert_pfn_prot does not > > make the pfn writable so the pte entry is normally read-only or > > dirty catching. > What? How do yo

RE: [PATCH] mm: Remove double faults once write a device pfn

2024-01-29 Thread Zhou, Xianrong
[AMD Official Use Only - General] > > The vmf_insert_pfn_prot could cause unnecessary double faults on a > > device pfn. Because currently the vmf_insert_pfn_prot does not make > > the pfn writable so the pte entry is normally read-only or dirty > > catching. > > What? How do you got to this concl

RE: [PATCH] mm: Remove double faults once write a device pfn

2024-01-29 Thread Zhou, Xianrong
[AMD Official Use Only - General] > >>> The vmf_insert_pfn_prot could cause unnecessary double faults on a > >>> device pfn. Because currently the vmf_insert_pfn_prot does not make > >>> the pfn writable so the pte entry is normally read-only or dirty > >>> catching. > >> What? How do you got to t

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-29 Thread 林睿祥

Re: [PATCH 3/3] Start separating pipe vs transcoder set logic for bigjoiner during modeset

2024-01-29 Thread Lisovskiy, Stanislav
On Fri, Jan 12, 2024 at 06:47:10PM +0200, Ville Syrjälä wrote: > On Mon, Jan 08, 2024 at 02:07:25PM +0200, Stanislav Lisovskiy wrote: > > Handle only bigjoiner masters in skl_commit_modeset_enables/disables, > > slave crtcs should be handled by master hooks. Same for encoders. > > That way we can a

✗ Fi.CI.SPARSE: warning for Bigjoiner refactoring (rev4)

2024-01-29 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev4) URL : https://patchwork.freedesktop.org/series/128311/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warnin

✗ Fi.CI.CHECKPATCH: warning for Bigjoiner refactoring (rev4)

2024-01-29 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev4) URL : https://patchwork.freedesktop.org/series/128311/ State : warning == Summary == Error: dim checkpatch failed 3390094a8423 drm/i915: Add bigjoiner force enable option to debugfs -:38: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 7

✓ Fi.CI.BAT: success for Bigjoiner refactoring (rev4)

2024-01-29 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev4) URL : https://patchwork.freedesktop.org/series/128311/ State : success == Summary == CI Bug Log - changes from CI_DRM_14190 -> Patchwork_128311v4 Summary --- **SUCCESS** No

Re: [PATCH 4/5] drm/xe/xe2: Limit ccs framebuffers to tile4 only

2024-01-29 Thread Matthew Auld
On 26/01/2024 21:08, Juha-Pekka Heikkila wrote: Display engine support ccs only with tile4, prevent other modifiers from using compressed memory. Store pin time pat index to xe_bo. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/xe/display/xe_fb_pin.c | 19 +++ 1 file

RE: [PATCH] drm/i915/fbc: Allow FBC with CCS modifiers on SKL+

2024-01-29 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, January 24, 2024 9:13 AM > To: Vivi, Rodrigo > Cc: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/fbc: Allow FBC with CCS modifiers on SKL+ > > On Tue, Jan 23, 2024 at 05:44:06PM -0500, Rodrig

Re: [PATCH 3/5] drm/xe: store bind time pat index to xe_bo

2024-01-29 Thread Matthew Auld
On 26/01/2024 21:08, Juha-Pekka Heikkila wrote: Store pat index from xe_vma to xe_bo and check if bo was pinned as framebuffer and verify pat index is not changing for pinned framebuffers. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/xe/xe_pt.c | 23 +++ 1 file

Re: [PATCH v5 0/3] drm/i915: Fix VMA UAF on destroy against deactivate race

2024-01-29 Thread Janusz Krzysztofik
Hi Nirmoy, On Monday, 29 January 2024 10:24:07 CET Nirmoy Das wrote: > Hi Janusz, > > There seems to be a regression in CI related to this: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129026v2/bat-dg1-7/ igt@gem_lmem_swapping@random-engi...@lmem0.html#dmesg-warnings1053 > > Please ha

Re: Re: Re: [PATCH 3/5] drm/ttm: replace busy placement with flags v6

2024-01-29 Thread Thomas Hellström
On Fri, 2024-01-26 at 16:22 -0600, Lucas De Marchi wrote: > On Fri, Jan 26, 2024 at 04:16:58PM -0600, Lucas De Marchi wrote: > > On Thu, Jan 18, 2024 at 05:38:16PM +0100, Thomas Hellström wrote: > > > > > > On 1/17/24 13:27, Thomas Hellström wrote: > > > > > > > > On 1/17/24 11:47, Thomas Hellstr

Re: [PATCH 03/19] drm/i915/dp: Add support to notify MST connectors to retry modesets

2024-01-29 Thread Imre Deak
On Mon, Jan 29, 2024 at 12:36:12PM +0200, Hogander, Jouni wrote: > On Tue, 2024-01-23 at 12:28 +0200, Imre Deak wrote: > > [...] > > +void > > +intel_dp_queue_modeset_retry_for_link(struct intel_atomic_state *state, > > + struct intel_encoder *encoder, > > +

Re: [PATCH 03/19] drm/i915/dp: Add support to notify MST connectors to retry modesets

2024-01-29 Thread Hogander, Jouni
On Tue, 2024-01-23 at 12:28 +0200, Imre Deak wrote: > On shared (Thunderbolt) links with DP tunnels, the modeset may need > to > be retried on all connectors on the link due to a link BW limitation > arising only after the atomic check phase. To support this add a > helper > function queuing a work

Re: [PATCH v5 0/3] drm/i915: Fix VMA UAF on destroy against deactivate race

2024-01-29 Thread Nirmoy Das
Hi Janusz, There seems to be a regression in CI related to this: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129026v2/bat-dg1-7/igt@gem_lmem_swapping@random-engi...@lmem0.html#dmesg-warnings1053 Please have a look. Regards, Nirmoy On 1/24/2024 6:13 PM, Janusz Krzysztofik wrote: Obje

[PATCH 1/3] drm/i915: Add bigjoiner force enable option to debugfs

2024-01-29 Thread Stanislav Lisovskiy
For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs. v2: - Apparently intel_dp_need_bigjoiner can't be used, when debugfs entry is created so lets just check manually