[PATCH 10/11] drm/i915/hdcp: Allocate stream id after HDCP AKE stage

2024-02-03 Thread Suraj Kandpal
Allocate stream id after HDCP AKE stage and not before so that it can also be done during link integrity check. Right now for MST scenarios LIC fails after hdcp enablement for this reason. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 115 ++ 1

[PATCH 11/11] drm/i915/hdcp: Read Rxcaps for robustibility

2024-02-03 Thread Suraj Kandpal
We see some monitors and docks report incorrect hdcp version and capability in first few reads so we read rx_caps three times before we conclude the monitor's or docks HDCP capability --v2 -Add comment to justify the 3 time read loop for hdcp capability[Ankit] Signed-off-by: Suraj Kandpal Review

[PATCH 09/11] drm/i915/hdcp: Save acquire_ctx in intel_hdcp

2024-02-03 Thread Suraj Kandpal
Save acquire_ctx in intel_hdcp so that it can be used later for locking to get vcpi id without need to propate intel_atomic_state. Furthermore it can be called from work_struct where deriving intel_atomic_state is not possible. Signed-off-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_disp

[PATCH 08/11] drm/i915/hdcp: Extract hdcp structure from correct connector

2024-02-03 Thread Suraj Kandpal
Currently intel_hdcp is not being extracted from primary connector this patch fixes that. Fixes: 524240b231ea ("drm/i915/hdcp: Propagate aux info in DP HDCP functions") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 7 +-- 1 file

[PATCH 06/11] drm/i915/hdcp: HDCP Capability for the downstream device

2024-02-03 Thread Suraj Kandpal
Currently we are only checking capability of remote device and not immediate downstream device but during capability check we need are concerned with only the HDCP capability of downstream device. During i915_display_info reporting we need HDCP Capability for both the monitors and downstream branch

[PATCH 07/11] drm/i915/hdcp: Remove additional timing for reading mst hdcp message

2024-02-03 Thread Suraj Kandpal
Now that we have moved back to direct reads the additional timing is not required hence this can be removed. --v2 -Add Fixes tag [Ankit] Fixes: 3974f9c17bb9 ("drm/i915/hdcp: Adjust timeout for read in DPMST Scenario") Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm

[PATCH 05/11] drm/i915/hdcp: Add new remote capability check shim function

2024-02-03 Thread Suraj Kandpal
Create a remote HDCP capability shim function which can read the remote monitor HDCP capability when in MST configuration. --v2 -Add an assertion to make sure only mst encoder call this remote_cap function [Ankit] Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_types.h|

[PATCH 01/11] drm/i915/hdcp: Move to direct reads for HDCP

2024-02-03 Thread Suraj Kandpal
Even for MST scenarios we need to do direct reads only on the immediate downstream device the rest of the authentication is taken care by that device. Remote reads will only be used to check capability of the monitors in MST topology. --v2 -Add fixes tag [Ankit] -Derive aux where needed rather tha

[PATCH 04/11] drm/i915/hdcp: Pass drm_dp_aux to read_bcaps function

2024-02-03 Thread Suraj Kandpal
Pass drm_dp_aux to intel_dp_hdcp_read_bcaps function so as to aid in reading the bcaps for the remote monitor later on. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) d

[PATCH 00/11] HDCP Type1 MST fixes

2024-02-03 Thread Suraj Kandpal
We were seeing a blank screen whenever Type1 content was played. This was due to extra timing which was taken as we had moved to remote read and writes previously for MST scenario, which in turn was done as we were not able to do direct read and writes to the immediate downstream device. The correc

[PATCH 03/11] drm/i915/hdcp: Refactor intel_dp_hdcp2_capable

2024-02-03 Thread Suraj Kandpal
Break intel_dp_hdcp2_capable so that the common the code can be reused for the remote capability check. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 02/11] drm/i915/hdcp: Move source hdcp2 checks into its own function

2024-02-03 Thread Suraj Kandpal
Move checks on the source side for HDCP2.2 into its own function so that they can be used in the HDCP remote capability check function. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 20 +--- 1 file changed, 17 insertions

Re: [PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_params_changed

2024-02-03 Thread Gustavo Sousa
Quoting Ville Syrjälä (2024-02-02 16:58:37-03:00) >On Fri, Feb 02, 2024 at 10:12:08AM -0300, Gustavo Sousa wrote: >> Looks like the name and description of intel_cdclk_needs_modeset() >> became inacurate as of commit 59f9e9cab3a1 ("drm/i915: Skip modeset for >> cdclk changes if possible"), when it

Re: [PATCH] drm/i915/cdclk: Rename intel_cdclk_needs_modeset to intel_cdclk_params_changed

2024-02-03 Thread Gustavo Sousa
Quoting Ville Syrjälä (2024-02-02 17:06:02-03:00) >On Fri, Feb 02, 2024 at 09:58:37PM +0200, Ville Syrjälä wrote: >> On Fri, Feb 02, 2024 at 10:12:08AM -0300, Gustavo Sousa wrote: >> > Looks like the name and description of intel_cdclk_needs_modeset() >> > became inacurate as of commit 59f9e9cab3a1

Re: [Intel-gfx] [PATCH] drm/i915: Replace dead 01.org link

2024-02-03 Thread Zhi Wang
On Fri, 4 Aug 2023 12:05:44 +0800 Zhenyu Wang wrote: > 01.org is dead so replace old gvt link with current wiki page. > > Signed-off-by: Zhenyu Wang > Acked-by: Jani Nikula > --- > MAINTAINERS | 2 +- > drivers/gpu/drm/i915/Kconfig | 2 +- > drivers/gpu/drm/i915/inte