RE: [PATCH] drm/i915/panelreplay: Move out psr_init_dpcd() from init_connector()

2024-02-26 Thread Manna, Animesh
> -Original Message- > From: Jani Nikula > Sent: Monday, February 26, 2024 11:17 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; Hogander, Jouni > ; Murthy, Arun R ; > Manna, Animesh > Subject: Re: [PATCH] drm/i915/panelreplay: Move ou

✓ Fi.CI.BAT: success for XE HDCP Enablement (rev7)

2024-02-26 Thread Patchwork
== Series Details == Series: XE HDCP Enablement (rev7) URL : https://patchwork.freedesktop.org/series/129456/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_129456v7 Summary --- **SUCCESS** No re

✗ Fi.CI.SPARSE: warning for XE HDCP Enablement (rev7)

2024-02-26 Thread Patchwork
== Series Details == Series: XE HDCP Enablement (rev7) URL : https://patchwork.freedesktop.org/series/129456/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/asm/bitops.h:116:1: warning

[PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-02-26 Thread Suraj Kandpal
Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.c so that intel_hdcp_gsc_message can be redefined for xe as needed. --v2 -Correct commit message to reflect what patch is actually doing [Arun] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 6 ++ d

Re: [PATCH] drm/i915/display/debugfs: New entry "DRRS capable" to i915_drrs_status

2024-02-26 Thread Modem, Bhanuprakash
On 26-02-2024 07:50 pm, Jani Nikula wrote: On Mon, 26 Feb 2024, "Nautiyal, Ankit K" wrote: On 2/22/2024 11:27 AM, Golani, Mitulkumar Ajitkumar wrote: -Original Message- From: Intel-gfx On Behalf Of Bhanuprakash Modem Sent: Wednesday, February 21, 2024 4:42 PM To: intel-gfx@lists.

[PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-02-26 Thread Suraj Kandpal
Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.h so that intel_hdcp_gsc_message can be redefined for xe as needed. --v2 -Correct commit message to reflect what patch is actually doing [Arun] Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 6 ++ d

[PATCH 4/4] drm/xe/hdcp: Enable HDCP for XE

2024-02-26 Thread Suraj Kandpal
Enable HDCP for Xe by defining functions which take care of interaction of HDCP as a client with the GSC CS interface. Add intel_hdcp_gsc_message to Makefile and add corresponding changes to xe_hdcp_gsc.c to make it build. --v2 -add kfree at appropriate place [Daniele] -remove useless define [Dani

[PATCH 2/4] drm/xe/hdcp: Use xe_device struct

2024-02-26 Thread Suraj Kandpal
Use xe_device struct instead of drm_i915_private so as to not cause confusion and comply with Xe standards as drm_i915_private is xe_device under the hood. --v2 -Fix commit message [Daniele] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_hdcp_gsc.c |

[PATCH 3/4] drm/xe: Use gsc_proxy_init_done to check proxy status

2024-02-26 Thread Suraj Kandpal
Expose gsc_proxy_init_done so that we can check if gsc proxy has been initialized or not. --v2 -Check if GSC FW is enabled before taking forcewake ref [Daniele] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/xe/display/xe_hdcp_g

[PATCH 0/4] XE HDCP Enablement

2024-02-26 Thread Suraj Kandpal
This patch series enables HDCP on XE. Mainly includes rewriting functions that were responsible for sending hdcp messages via gsc cs. Signed-off-by: Suraj Kandpal Suraj Kandpal (4): drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file drm/xe/hdcp: Use xe_device struct drm/x

Re: [PATCH] drm/i915/display/debugfs: New entry "DRRS capable" to i915_drrs_status

2024-02-26 Thread Nautiyal, Ankit K
On 2/26/2024 7:50 PM, Jani Nikula wrote: On Mon, 26 Feb 2024, "Nautiyal, Ankit K" wrote: On 2/22/2024 11:27 AM, Golani, Mitulkumar Ajitkumar wrote: -Original Message- From: Intel-gfx On Behalf Of Bhanuprakash Modem Sent: Wednesday, February 21, 2024 4:42 PM To: intel-gfx@lists.freed

RE: [PATCH 2/3] Start separating pipe vs transcoder set logic for bigjoiner during modeset

2024-02-26 Thread Srinivas, Vidya
> -Original Message- > From: Intel-gfx On Behalf Of > Srinivas, Vidya > Sent: Tuesday, February 27, 2024 10:10 AM > To: Lisovskiy, Stanislav ; intel- > g...@lists.freedesktop.org > Cc: Saarinen, Jani ; ville.syrj...@linux.intel.com > Subject: RE: [PATCH 2/3] Start separating pipe vs tran

RE: [PATCH 2/3] Start separating pipe vs transcoder set logic for bigjoiner during modeset

2024-02-26 Thread Srinivas, Vidya
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Thursday, February 22, 2024 12:50 AM > To: intel-gfx@lists.freedesktop.org > Cc: Lisovskiy, Stanislav ; Saarinen, Jani > ; ville.syrj...@linux.intel.com; Srinivas, Vidya > > Subject: [PATCH 2/3] Start separating pipe vs transcode

✗ Fi.CI.BAT: failure for drm/i915: Allow for Vsync_start and Vsync_end to change in LRR

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915: Allow for Vsync_start and Vsync_end to change in LRR URL : https://patchwork.freedesktop.org/series/130415/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_130415v1 Su

✓ Fi.CI.BAT: success for drm/i915: Reuse rplu cdclk fns for mtl/lnl

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915: Reuse rplu cdclk fns for mtl/lnl URL : https://patchwork.freedesktop.org/series/130410/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_130410v1 Summary --- **S

✓ Fi.CI.BAT: success for drm/i915/display: Disable AuxCCS framebuffers if built for Xe (rev2)

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915/display: Disable AuxCCS framebuffers if built for Xe (rev2) URL : https://patchwork.freedesktop.org/series/129166/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_129166v2 ==

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP

2024-02-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP URL : https://patchwork.freedesktop.org/series/130398/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_130398v1 ==

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP

2024-02-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP URL : https://patchwork.freedesktop.org/series/130398/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't b

✗ Fi.CI.BAT: failure for drm/i915: Add Display Port tunnel BW allocation support (rev6)

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915: Add Display Port tunnel BW allocation support (rev6) URL : https://patchwork.freedesktop.org/series/129082/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_129082v6 Su

Re: linux-next: Tree for Feb 26 (drivers/gpu/drm/xe)

2024-02-26 Thread Randy Dunlap
On 2/25/24 22:55, Stephen Rothwell wrote: > Hi all, > > Changes since 20240223: > on powerpc32 or i386: ../drivers/gpu/drm/xe/xe_ggtt.c: In function 'xe_ggtt_set_pte': ../drivers/gpu/drm/xe/xe_ggtt.c:78:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=imp

✗ Fi.CI.SPARSE: warning for drm/i915: Add Display Port tunnel BW allocation support (rev6)

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915: Add Display Port tunnel BW allocation support (rev6) URL : https://patchwork.freedesktop.org/series/129082/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add Display Port tunnel BW allocation support (rev6)

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915: Add Display Port tunnel BW allocation support (rev6) URL : https://patchwork.freedesktop.org/series/129082/ State : warning == Summary == Error: dim checkpatch failed 855f2818d384 drm/dp: Add drm_dp_max_dprx_data_rate() c1dbb46b64c9 drm/dp: Add support fo

Re: [PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160

2024-02-26 Thread John Harrison
On 2/26/2024 05:25, Nilawar, Badal wrote: Hi John, On 04-01-2024 23:35, john.c.harri...@intel.com wrote: From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14

✓ Fi.CI.BAT: success for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2)

2024-02-26 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2) URL : https://patchwork.freedesktop.org/series/130335/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_130335v2 Summary -

[PATCH] drm/i915: Allow for Vsync_start and Vsync_end to change in LRR

2024-02-26 Thread Manasi Navare
Since LRR mode requires panel to support VRR, any of the LRR mode is achieved by stretching vertical front porch which also pushes out Vsync_start and Vsync_end timings of the mode. This allows for VSS and VSE timings to be different in case of LRR to ensure semaless modeset/fastset to LRR mode. I

✗ Fi.CI.SPARSE: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2)

2024-02-26 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2) URL : https://patchwork.freedesktop.org/series/130335/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2)

2024-02-26 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2) URL : https://patchwork.freedesktop.org/series/130335/ State : warning == Summary == Error: dim checkpatch failed f8cc51578cea drm/i915: Enable Wa_16019325821 e399c9355ad3 drm/i915/guc: Add support for w/a KLV

✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915/bios: bump expected child device size

2024-02-26 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915/bios: bump expected child device size URL : https://patchwork.freedesktop.org/series/130396/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_130396v1 =

✗ Fi.CI.SPARSE: warning for series starting with [v2,1/3] drm/i915/bios: bump expected child device size

2024-02-26 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915/bios: bump expected child device size URL : https://patchwork.freedesktop.org/series/130396/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separatel

✓ Fi.CI.BAT: success for drm/i915/guc: Simplify/extend platform check for Wa_14018913170 (rev3)

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915/guc: Simplify/extend platform check for Wa_14018913170 (rev3) URL : https://patchwork.freedesktop.org/series/130022/ State : success == Summary == CI Bug Log - changes from CI_DRM_14345 -> Patchwork_130022v3

[PATCH] drm/i915: Reuse rplu cdclk fns for mtl/lnl

2024-02-26 Thread Radhakrishna Sripada
MTL/LNL use the same cdclk functions as rplu albeit with different tables. Having separate tables not explicit special handling for the platforms reuse rplu cdclk functions. Cc: Gustavo Sousa Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_cdclk.c | 11 ++- 1

✗ Fi.CI.BAT: failure for drm/i915: fix applying placement flag

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915: fix applying placement flag URL : https://patchwork.freedesktop.org/series/130389/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14344 -> Patchwork_130389v1 Summary --- **FAILUR

✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix applying placement flag

2024-02-26 Thread Patchwork
== Series Details == Series: drm/i915: fix applying placement flag URL : https://patchwork.freedesktop.org/series/130389/ State : warning == Summary == Error: dim checkpatch failed f9d6634478e6 drm/i915: fix applying placement flag -:16: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be imm

[PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-02-26 Thread Juha-Pekka Heikkila
AuxCCS framebuffers don't work on Xe driver hence disable them from plane capabilities until they are fixed. FlatCCS framebuffers work and they are left enabled. CCS is left untouched for i915 driver. Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/933 Signed-off-by: Juha-Pekka Heikk

Re: [PATCH 1/2] drm/ttm: improve idle/busy handling v4

2024-02-26 Thread Thomas Hellström
Hi, Christian On Fri, 2024-02-23 at 15:30 +0100, Christian König wrote: > Am 06.02.24 um 13:56 schrieb Christian König: > > Am 06.02.24 um 13:53 schrieb Thomas Hellström: > > > Hi, Christian, > > > > > > On Fri, 2024-01-26 at 15:09 +0100, Christian König wrote: > > > > Previously we would never t

✓ Fi.CI.BAT: success for ALSA/ASoC: Conditionally skip i915 init and cleanups (rev3)

2024-02-26 Thread Patchwork
== Series Details == Series: ALSA/ASoC: Conditionally skip i915 init and cleanups (rev3) URL : https://patchwork.freedesktop.org/series/130271/ State : success == Summary == CI Bug Log - changes from CI_DRM_14344 -> Patchwork_130271v3 Summa

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-26 Thread Jani Nikula
On Wed, 21 Feb 2024, Stanislav Lisovskiy wrote: > Patch calculates bigjoiner pipes in mst compute. > Patch also passes bigjoiner bool to validate plane > max size. Please use the imperative mood in commit messages, e.g. "calculate" intead of "calculates". Please do not refer to "patch". We know

Re: [PATCH 2/2] drm/i915/dsi: Don't use SET_CONTEXT_LATENCY with DSI transcoders

2024-02-26 Thread Jani Nikula
On Mon, 26 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > ADL DSI transcoders do not have the new SET_CONTEXT_LATENCY > register. Instead they supposedly use the older TGL VBLANK_START > based method of defining the vblank delay. > > Completely untested due to lack of suitable hardware.

Re: [PATCH 1/2] drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP

2024-02-26 Thread Jani Nikula
On Mon, 26 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Looks like I misplaced a few hunks when I moved the audio > enable/disable out from the encoder enable/disable hooks. > So we are now doing a double audio enable/disable on SDVO > and g4x+ DP. Probably harmless as doing it twice

Re: [PATCH v2 4/6] intel_device: fix warning on possible buffer overlflow on sprintf() calls

2024-02-26 Thread Ville Syrjälä
On Wed, Feb 21, 2024 at 07:55:48PM +0100, Enrico Weigelt, metux IT consult wrote: > Signed-off-by: Enrico Weigelt, metux IT consult > --- > src/intel_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel_device.c b/src/intel_device.c > index f28d3be1..06108

[PATCH 2/2] drm/i915/dsi: Don't use SET_CONTEXT_LATENCY with DSI transcoders

2024-02-26 Thread Ville Syrjala
From: Ville Syrjälä ADL DSI transcoders do not have the new SET_CONTEXT_LATENCY register. Instead they supposedly use the older TGL VBLANK_START based method of defining the vblank delay. Completely untested due to lack of suitable hardware. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i9

[PATCH 1/2] drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP

2024-02-26 Thread Ville Syrjala
From: Ville Syrjälä Looks like I misplaced a few hunks when I moved the audio enable/disable out from the encoder enable/disable hooks. So we are now doing a double audio enable/disable on SDVO and g4x+ DP. Probably harmless as doing it twice shouldn't really change anything, but let's do it just

Re: [PATCH v2 6/6] uxa: stop calling deprecated xf86_reload_cursors()

2024-02-26 Thread Ville Syrjälä
On Wed, Feb 21, 2024 at 07:55:50PM +0100, Enrico Weigelt, metux IT consult wrote: > the function has become a no-op, it's former duties are done automatically. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > src/uxa/intel_display.c | 3 --- > 1 file changed, 3 deletions(-) > > d

Re: [PATCH v2 5/6] stop using obsolete xf86BlockSIGIO() and xf86UnblockSIGIO()

2024-02-26 Thread Ville Syrjälä
On Wed, Feb 21, 2024 at 07:55:49PM +0100, Enrico Weigelt, metux IT consult wrote: > These Please spell out what "these" are. > are just wrappers for calling input_lock()/input_unlock() and marked > deprecated for quite a while now. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > s

Re: [PATCH v2 4/6] intel_device: fix warning on possible buffer overlflow on sprintf() calls

2024-02-26 Thread Ville Syrjälä
On Wed, Feb 21, 2024 at 07:55:48PM +0100, Enrico Weigelt, metux IT consult wrote: Please write an actual commit message. > Signed-off-by: Enrico Weigelt, metux IT consult > --- > src/intel_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel_device.c b/s

Re: [PATCH v2 1/6] sna: stop using obsolete type aliases

2024-02-26 Thread Ville Syrjälä
On Wed, Feb 21, 2024 at 07:55:45PM +0100, Enrico Weigelt, metux IT consult wrote: > The Xserver has been moved to using pixman for all matrix operations, back in > 2008, but left some #define's so drivers still compile. Reference to the actual commit would help. > Since 1.5 decades have > passed

[PATCH v3 12/21] drm/i915/dp: Add support for DP tunnel BW allocation

2024-02-26 Thread Imre Deak
Add support to enable the DP tunnel BW allocation mode. Follow-up patches will call the required helpers added here to prepare for a modeset on a link with DP tunnels, the last change in the patchset actually enabling BWA. With BWA enabled, the driver will expose the full mode list a display suppo

[PATCH v3 02/21] drm/dp: Add support for DP tunneling

2024-02-26 Thread Imre Deak
Add support for Display Port tunneling. For now this includes the support for Bandwidth Allocation Mode (BWA), leaving adding Panel Replay support for later. BWA allows using displays that share the same (Thunderbolt) link with their maximum resolution. Atm, this may not be possible due to the coa

[PATCH v3 11/21] drm/i915/dp: Sync instead of try-sync commits when getting active pipes

2024-02-26 Thread Imre Deak
Sync instead of only try-sync non-blocking commits when getting the active pipes through a given DP port. Atm intel_dp_get_active_pipes() will only try to sync a given pipe and if that would block ignore the pipe. This was supposed to avoid link retraining in case a pending modeset would do that an

[PATCH v3 01/21] drm/dp: Add drm_dp_max_dprx_data_rate()

2024-02-26 Thread Imre Deak
Copy intel_dp_max_data_rate() to DRM core. It will be needed by a follow-up DP tunnel patch, checking the maximum rate the DPRX (sink) supports. Accordingly use the drm_dp_max_dprx_data_rate() name for clarity. This patchset will also switch calling the new DRM function in i915 instead of intel_dp_

[PATCH v2 3/3] drm/i915/bios: abstract child device expected size

2024-02-26 Thread Jani Nikula
Add a function to return the expected child device size. Flip the if ladder around and use the same versions as in documentation to make it easier to verify. Return an error for unknown versions. No functional changes. v2: Move BUILD_BUG_ON() next to the expected sizes Signed-off-by: Jani Nikula

[PATCH v2 1/3] drm/i915/bios: bump expected child device size

2024-02-26 Thread Jani Nikula
VBT versions since 256 have an extra byte for EFP index. v2: Update BUILD_BUG_ON() (Matt) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 6 -- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/

[PATCH v2 2/3] drm/i915/bios: abstract child device size check

2024-02-26 Thread Jani Nikula
Separate the child device size check to a separate function for clarity. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 79 +-- 1 file changed, 44 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/i915/display/inte

Re: [PATCH v2 1/5] drm/i915/display: Make intel_dp_aux_fw_sync_len available for PSR code

2024-02-26 Thread Jani Nikula
On Thu, 22 Feb 2024, Jouni Högander wrote: > ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO > wake and fast wake lines. Convert intel_dp_aux_fw_sync_len as non-static > to make it available for PSR code. u8 is enough for fw sync pulse length. "u8 is enough" is not a goo

Re: [PATCH] drm/i915/panelreplay: Move out psr_init_dpcd() from init_connector()

2024-02-26 Thread Jani Nikula
On Thu, 22 Feb 2024, Animesh Manna wrote: > Move psr_init_dpcd() from init-connector to connector-detect > function. Why? The commit message *must* *always* answer the question why, unless the reason is completely and utterly obvious (e.g. don't need to say why typos need to be fixed). BR, Jani

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Ville Syrjälä
On Mon, Feb 26, 2024 at 05:35:51PM +0200, Jani Nikula wrote: > On Mon, 26 Feb 2024, Andy Shevchenko > wrote: > > On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: > >> On Fri, 23 Feb 2024, Ville Syrjälä wrote: > >> > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: > > >

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2024 at 05:35:51PM +0200, Jani Nikula wrote: > On Mon, 26 Feb 2024, Andy Shevchenko > wrote: > > On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: > >> On Fri, 23 Feb 2024, Ville Syrjälä wrote: > >> > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: ...

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Jani Nikula
On Mon, 26 Feb 2024, Andy Shevchenko wrote: > On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: >> On Fri, 23 Feb 2024, Ville Syrjälä wrote: >> > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: > > ... > >> > I think the proper solution would be to have actually >> > sens

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: > On Fri, 23 Feb 2024, Ville Syrjälä wrote: > > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: ... > > I think the proper solution would be to have actually > > sensible conversion specifiers in the format string. > > So

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Jani Nikula
On Fri, 23 Feb 2024, Ville Syrjälä wrote: > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: >> On Thu, Feb 15, 2024 at 06:40:44PM +0200, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > intel_crtc_check_fastset() is done per-pipe, so it would be nice >> > to know which pipe

RE: [PATCH 2/2] drm/i915: Support replaying GPU hangs with captured context image

2024-02-26 Thread Santa, Carlos
> -Original Message- > From: Tvrtko Ursulin > Sent: Monday, February 26, 2024 1:56 AM > To: Vivi, Rodrigo > Cc: Intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Ursulin, > Tvrtko ; Landwerlin, Lionel G > ; Santa, Carlos > Subject: Re: [PATCH 2/2] drm/i915: Support repla

[PATCH] drm/i915: fix applying placement flag

2024-02-26 Thread Christian König
Switching from a separate list to flags introduced a bug here. We were accidentially ORing the flag before initailizing the placement and not after. So this code didn't do nothing except producing a warning. Signed-off-by: Christian König Reported-by: Stephen Rothwell Fixes: a78a8da51b36 ("drm/

Re: [PATCH] drm/i915/display/debugfs: New entry "DRRS capable" to i915_drrs_status

2024-02-26 Thread Jani Nikula
On Mon, 26 Feb 2024, "Nautiyal, Ankit K" wrote: > On 2/22/2024 11:27 AM, Golani, Mitulkumar Ajitkumar wrote: >> >>> -Original Message- >>> From: Intel-gfx On Behalf Of >>> Bhanuprakash Modem >>> Sent: Wednesday, February 21, 2024 4:42 PM >>> To: intel-gfx@lists.freedesktop.org >>> Cc: Mod

Re: [PULL] drm-xe-next

2024-02-26 Thread Lucas De Marchi
On Mon, Feb 26, 2024 at 10:46:43AM +, Daniel Stone wrote: Hi, On Mon, 26 Feb 2024 at 03:21, Lucas De Marchi wrote: All of this should be fixed by now: dim is used for applying and pushing patches, which has additional checks so that doesn't happen again. Still pending confirmation from Dan

Re: [PATCH v2 00/21] drm/i915: Add Display Port tunnel BW allocation support

2024-02-26 Thread Maxime Ripard
On Mon, Feb 26, 2024 at 03:54:19PM +0200, Jani Nikula wrote: > On Tue, 20 Feb 2024, Imre Deak wrote: > > This is v2 of [1], with the following changes: > > > > - Several functional/typo/formatting fixes, detailed in the patches. > > - Move the BW allocation from encoder hooks to > > intel_atomic

Re: [PATCH v2 00/21] drm/i915: Add Display Port tunnel BW allocation support

2024-02-26 Thread Jani Nikula
On Tue, 20 Feb 2024, Imre Deak wrote: > This is v2 of [1], with the following changes: > > - Several functional/typo/formatting fixes, detailed in the patches. > - Move the BW allocation from encoder hooks to > intel_atomic_commit_tail() fixing the allocation for MST streams > enabled/disabled

i915 build error on drm-misc-next

2024-02-26 Thread Jeffrey Hugo
With the x86_64_defconfig I see the following when building drm-misc-next: CC drivers/gpu/drm/i915/display/intel_crt.o CC drivers/gpu/drm/i915/display/intel_cx0_phy.o CC drivers/gpu/drm/i915/display/intel_ddi.o CC drivers/gpu/drm/i915/display/intel_ddi_buf_trans.o CC

Re: Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-26 Thread Yury Norov
On Thu, Feb 22, 2024 at 05:04:10PM +0200, Andy Shevchenko wrote: > On Thu, Feb 22, 2024 at 06:49:59AM -0800, Yury Norov wrote: > > On Wed, Feb 21, 2024 at 03:59:06PM -0600, Lucas De Marchi wrote: > > ... > > > +#define __GENMASK(t, h, l) \ > > + ((~0 - (1 << (l)) + 1) & (~0 >> (BITS_PER_LONG -

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-26 Thread Kent Overstreet
On Fri, Feb 23, 2024 at 01:46:53PM -0500, Steven Rostedt wrote: > On Fri, 23 Feb 2024 10:30:45 -0800 > Jeff Johnson wrote: > > > On 2/23/2024 9:56 AM, Steven Rostedt wrote: > > > From: "Steven Rostedt (Google)" > > > > > > [ > > >This is a treewide change. I will likely re-create this patch

Re: Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-26 Thread Yury Norov
On Wed, Feb 21, 2024 at 03:59:06PM -0600, Lucas De Marchi wrote: > On Wed, Feb 21, 2024 at 11:04:22PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 21, 2024 at 10:30:02PM +0200, Dmitry Baryshkov wrote: > > > On Thu, 8 Feb 2024 at 09:45, Lucas De Marchi > > > wrote: > > > > ... > > > > > > +#def

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-26 Thread Jeff Johnson
On 2/23/2024 9:56 AM, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.9 and submit it then. Hoping >to keep the conflicts that it will cause to a minimum. >

Re: [PATCH v1 0/6] LNL display

2024-02-26 Thread Gustavo Sousa
Hi, guys. Quoting Govindapillai, Vinod (2024-02-22 11:39:32-03:00) >Hi, > >Well.. sorry.. I didn't know Gustavo is already working on this! >@Gustavo, pls ignore this series if you are arealdy working on this. Please >let me know Yeah. I have a couple of local fixes to apply to those commits, bu

Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-26 Thread Yury Norov
On Mon, Feb 19, 2024 at 11:13:57PM -0600, Lucas De Marchi wrote: > On Fri, Feb 09, 2024 at 08:53:25AM -0800, Yury Norov wrote: > > On Wed, Feb 07, 2024 at 11:45:20PM -0800, Lucas De Marchi wrote: > > > Implement fixed-type BIT() to help drivers add stricter checks, like was > > > done for GENMASK.

Re: [PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160

2024-02-26 Thread Nilawar, Badal
Hi John, On 04-01-2024 23:35, john.c.harri...@intel.com wrote: From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harr

Re: linux-next: build failure after merge of the drm-misc tree

2024-02-26 Thread Christian König
Am 25.02.24 um 22:47 schrieb Stephen Rothwell: Hi all, On Mon, 26 Feb 2024 08:41:16 +1100 Stephen Rothwell wrote: On Tue, 20 Feb 2024 08:48:21 +1100 Stephen Rothwell wrote: On Mon, 12 Feb 2024 15:15:54 +0200 Jani Nikula wrote: On Tue, 06 Feb 2024, Stephen Rothwell wrote: After merging

[PATCH v3 5/5] ALSA: hda: Reuse for_each_pcm_streams()

2024-02-26 Thread Cezary Rojewski
Use the macro to improve readability. Signed-off-by: Cezary Rojewski --- sound/pci/hda/hda_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 12f02cdc9659..2cac337f5263 100644 --- a/sound/pci/hda/hda_codec.c +++

[PATCH v3 4/5] ASoC: codecs: hda: Cleanup error messages

2024-02-26 Thread Cezary Rojewski
Be cohesive and use same pattern in each error message. Signed-off-by: Cezary Rojewski --- sound/soc/codecs/hda.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/hda.c b/sound/soc/codecs/hda.c index 7c6bedeceaa2..5a58723dc0e9 100644 --- a/sound/soc

[PATCH v3 3/5] ASoC: Intel: avs: Ignore codecs with no suppoting driver

2024-02-26 Thread Cezary Rojewski
HDMI codecs which are present and functional from audio perspective lack i915 support on drm side what results in -ENODEV during the probing sequence. There is no reason to perform recovery procedure e.g.: reset the HDAudio controller if this is the case. Signed-off-by: Cezary Rojewski --- sound

[PATCH v3 2/5] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-26 Thread Cezary Rojewski
If i915 does not support given platform but the hardware i.e.: HDAudio codec is still there, the codec-probing procedure will succeed for such device but the follow up initialization will always end up with -ENODEV. While bus could filter out address '2' which Intel's HDMI/DP codecs always enumera

[PATCH v3 1/5] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-26 Thread Cezary Rojewski
Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends removed support for i915 for all CNL-based platforms. HDAudio library, however, still treats such platforms as valid candidates for i915 binding. Update query mechanism to reflect changes made in drm tree. At the same time, i9

[PATCH v3 0/5] ALSA/ASoC: Conditionally skip i915 init and cleanups

2024-02-26 Thread Cezary Rojewski
A small set of changes to improve initialization of the audio stack on HDAudio devices and pair of cleanups. As the first change is the most important one here, following is the technical background for it: Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends removed support fo

Re: [PATCH v2 2/4] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-26 Thread Cezary Rojewski
On 2024-02-26 12:09 PM, Takashi Iwai wrote: On Fri, 23 Feb 2024 18:09:59 +0100, Cezary Rojewski wrote: On 2024-02-23 3:44 PM, Takashi Iwai wrote: On Fri, 23 Feb 2024 12:46:24 +0100, Cezary Rojewski wrote: If i915 does not support given platform but the hardware i.e.: HDAudio codec is still t

Re: [PATCH v2 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-26 Thread Cezary Rojewski
On 2024-02-26 11:40 AM, Jani Nikula wrote: On Fri, 23 Feb 2024, Cezary Rojewski wrote: Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends removed support for i915 for all CNL-based platforms. HDAudio library, however, still treats such platforms as valid candidates for i915

Re: [PATCH v2 12/21] drm/i915/dp: Add support for DP tunnel BW allocation

2024-02-26 Thread Imre Deak
On Fri, Feb 23, 2024 at 11:37:41PM +0200, Ville Syrjälä wrote: > On Tue, Feb 20, 2024 at 11:18:32PM +0200, Imre Deak wrote: > > +static void queue_retry_work(struct intel_atomic_state *state, > > +struct drm_dp_tunnel *tunnel, > > +const struct intel_

Re: [PATCH v2 02/21] drm/dp: Add support for DP tunneling

2024-02-26 Thread Imre Deak
On Fri, Feb 23, 2024 at 11:32:21PM +0200, Ville Syrjälä wrote: > On Tue, Feb 20, 2024 at 11:18:22PM +0200, Imre Deak wrote: > > +static inline void drm_dp_tunnel_ref_put(struct drm_dp_tunnel_ref > > *tunnel_ref) > > +{ > > + drm_dp_tunnel_put(tunnel_ref->tunnel, &tunnel_ref->tracker); > > Shoul

Re: [PATCH v2 2/4] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-26 Thread Takashi Iwai
On Fri, 23 Feb 2024 18:09:59 +0100, Cezary Rojewski wrote: > > On 2024-02-23 3:44 PM, Takashi Iwai wrote: > > On Fri, 23 Feb 2024 12:46:24 +0100, > > Cezary Rojewski wrote: > >> > >> If i915 does not support given platform but the hardware i.e.: HDAudio > >> codec is still there, the codec-probin

✓ Fi.CI.BAT: success for HDCP MST Type1 fixes (rev8)

2024-02-26 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes (rev8) URL : https://patchwork.freedesktop.org/series/129925/ State : success == Summary == CI Bug Log - changes from CI_DRM_14335 -> Patchwork_129925v8 Summary --- **SUCCESS** No

RE: [PATCH v2 2/6] drm/i915/psr: Calculate aux less wake time

2024-02-26 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Tuesday, February 20, 2024 5:41 PM > To: intel-gfx@lists.freedesktop.org > Cc: Hogander, Jouni > Subject: [PATCH v2 2/6] drm/i915/psr: Calculate aux less wake time > > Calculate aux less wake time and store it

RE: [PATCH 4/5] drm/xe/hdcp: Enable HDCP for XE

2024-02-26 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Suraj > Kandpal > Sent: Thursday, February 15, 2024 11:43 AM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Ceraolo Spurio, Daniele ; Kandpal, Suraj > > Subject: [PATCH 4/5] drm/xe/hdcp: Enable HDCP for XE

✗ Fi.CI.SPARSE: warning for HDCP MST Type1 fixes (rev8)

2024-02-26 Thread Patchwork
== Series Details == Series: HDCP MST Type1 fixes (rev8) URL : https://patchwork.freedesktop.org/series/129925/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning

RE: [PATCH v2 12/21] drm/i915/dp: Add support for DP tunnel BW allocation

2024-02-26 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Wednesday, February 21, 2024 2:49 AM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Ville Syrjälä > Subject: [PATCH v2 12/21] drm/i915/dp: Add support for DP tunnel BW allocation > > A

Re: [PULL] drm-xe-next

2024-02-26 Thread Daniel Stone
Hi, On Mon, 26 Feb 2024 at 03:21, Lucas De Marchi wrote: > All of this should be fixed by now: dim is used for applying and pushing > patches, which has additional checks so that doesn't happen again. Still > pending confirmation from Daniel Stone if the git server hooks are ready > in gitlab so

Re: [PATCH v2 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-26 Thread Jani Nikula
On Fri, 23 Feb 2024, Cezary Rojewski wrote: > Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends > removed support for i915 for all CNL-based platforms. HDAudio library, > however, still treats such platforms as valid candidates for i915 > binding. Update query mechanism to re

RE: [PATCH 3/5] drm/xe: Use gsc_proxy_init_done to check proxy status

2024-02-26 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Daniele > Ceraolo Spurio > Sent: Wednesday, February 14, 2024 4:52 AM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org; > intel...@lists.freedesktop.org > Subject: Re: [PATCH 3/5] drm/xe: Use gsc_proxy_init_done to check proxy > st

Re: [PATCH 2/3] drm/i915/psr: Improve fast and IO wake lines calculation

2024-02-26 Thread Dan Carpenter
Hi Jouni, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jouni-H-gander/drm-i915-display-Add-aux-function-pointer-for-fast-wake-sync-pulse-count/20240221-160220 base

Re: [PATCH 5/6] drm/i915/display: Compute vrr_vsync params

2024-02-26 Thread Nautiyal, Ankit K
On 2/22/2024 5:42 PM, Mitul Golani wrote: Compute vrr_vsync_start/end which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit) - Update bit fields of VRR_VSYNC_START/END.

Re: [PULL] drm-xe-next

2024-02-26 Thread Daniel Vetter
On Sun, Feb 25, 2024 at 09:21:00PM -0600, Lucas De Marchi wrote: > Hi Dave and Sima, > > Here's the PR for drm-xe-next for Linux v6.9. It's a big list of > changes, but it contains several fixes for things noticed throughout the > v6.8 cycle after being merged upstream, added to the linux-next, et

Re: [PATCH 2/2] drm/i915: Support replaying GPU hangs with captured context image

2024-02-26 Thread Tvrtko Ursulin
On 22/02/2024 21:07, Rodrigo Vivi wrote: On Wed, Feb 21, 2024 at 02:22:45PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which

Re: [PATCH 4/6] drm/i915/display: Compute AS SDP parameters.

2024-02-26 Thread Nautiyal, Ankit K
On 2/22/2024 5:42 PM, Mitul Golani wrote: Add necessary functions definitions to enable and compute AS SDP data. The new `intel_dp_compute_as_sdp` function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Add DP_SDP_ADA

Re: [PATCH 3/6] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-26 Thread Nautiyal, Ankit K
On 2/22/2024 5:42 PM, Mitul Golani wrote: Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - R

  1   2   >