[PATCH v4 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-05-08 Thread Animesh Manna
For validation purpose add debugfs for LOBF. v1: Initial version. v2: Add aux-wake/less info along with lobf status. [Jouni] Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_alpm.c | 49 +++ drivers/gpu/drm/i915/display/intel_alpm.h | 2 +

[PATCH v4 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-05-08 Thread Animesh Manna
Set the Link Off Between Frames Enable bit in ALPM_CTL register. Note: Lobf need to be enabled adaptive sync fixed refresh mode where vmin = vmax = flipline, which will arise after cmmr feature enablement. Will add enabling sequence in a separate patch. v1: Initial version. v2: Condition check

[PATCH v4 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-08 Thread Animesh Manna
Link Off Between Active Frames, is a new feature for eDP that allows the panel to go to lower power state after transmission of data. This is a feature on top of ALPM, AS SDP. Add compute config during atomic-check phase. v1: RFC version. v2: Add separate flag for auxless-alpm. [Jani] v3: -

[PATCH v4 3/6] drm/display: Add missing aux less alpm wake related bits

2024-05-08 Thread Animesh Manna
From: Jouni Högander eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v4 2/6] drm/i915/alpm: Move alpm related code to a new file

2024-05-08 Thread Animesh Manna
Move ALPM feature related code as it will be used for non-psr panel also thorugh LOBF feature. v1: Initial version. v2: Correct ordering in makefile. [Jani] Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_alpm.c | 292

[PATCH v4 1/6] drm/i915/alpm: Move alpm parameters from intel_psr

2024-05-08 Thread Animesh Manna
ALPM can be enabled for non psr panel and currenly aplm-params are encapsulated under intel_psr struct, so moving out to intel_dp struct. Signed-off-by: Animesh Manna --- .../drm/i915/display/intel_display_types.h| 21 + drivers/gpu/drm/i915/display/intel_psr.c | 43

[PATCH v4 0/6] Link off between frames for edp

2024-05-08 Thread Animesh Manna
Link Off Between Active Frames (LOBF) allows an eDP link to be turned Off and On durning long VBLANK durations without enabling any of the PSR/PSR2/PR modes of operation. Bspec: 71477 Note: Lobf need to be enabled adaptive sync fixed refresh mode where vmin = vmax = flipline, which will arise

[v4] drm/i915: Implement Audio WA_14020863754

2024-05-08 Thread Uma Shankar
WA_14020863754: Corner case with Min Hblank Fix can cause audio hang Issue: Previously a fix was made to avoid issues with extremely small hblanks, called the "Min Hblank Fix". However, this can potentially cause an audio hang. Workaround : During "Audio Programming Sequence" Audio Enabling -

✓ Fi.CI.BAT: success for drm/i915/pps: Disable DPLS_GATING around pps sequence (rev3)

2024-05-08 Thread Patchwork
== Series Details == Series: drm/i915/pps: Disable DPLS_GATING around pps sequence (rev3) URL : https://patchwork.freedesktop.org/series/132495/ State : success == Summary == CI Bug Log - changes from CI_DRM_14736 -> Patchwork_132495v3

✓ Fi.CI.BAT: success for series starting with [PATCHv2,1/2] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Patchwork
== Series Details == Series: series starting with [PATCHv2,1/2] drm/i915/display/dp: Remove UHBR13.5 for icl URL : https://patchwork.freedesktop.org/series/133359/ State : success == Summary == CI Bug Log - changes from CI_DRM_14735 -> Patchwork_133359v1

✗ Fi.CI.BUILD: warning for series starting with [PATCHv2,1/2] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Patchwork
== Series Details == Series: series starting with [PATCHv2,1/2] drm/i915/display/dp: Remove UHBR13.5 for icl URL : https://patchwork.freedesktop.org/series/133359/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/133359/revisions/1/mbox/ not found

[PATCH] drm/i915/pps: Disable DPLS_GATING around pps sequence

2024-05-08 Thread Suraj Kandpal
Disable bit 29 of SCLKGATE_DIS register around pps sequence when we turn panel power on. --v2 -Squash two commit together [Jani] -Use IS_DISPLAY_VER [Jani] -Fix multiline comment [Jani] --v3 -Define register in a more appropriate place [Mitul] Bspec: 49304 Signed-off-by: Suraj Kandpal ---

[PATCH 2/2] drm/i915/display: Remove uhbr13.5 pll state values

2024-05-08 Thread Arun R Murthy
uhbr13.5 is not supported on dg2/mtl. This patch removes the pll state table for synps and c20 PHY. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 26 -- drivers/gpu/drm/i915/display/intel_dp.c | 2 --

[PATCHv2 1/2] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Arun R Murthy
Per Bspec display 14+ has uhbr13.5 Due to the retimer constraint none of the Intel platforms support uhbr13.5. This has been removed for mtl by the commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") This patch will remove the support for DG2. v2: Reframed the commit msg (Jani)

✗ Fi.CI.BUILD: failure for Make I2C terminology more inclusive for I2C Algobit and consumers (rev4)

2024-05-08 Thread Patchwork
== Series Details == Series: Make I2C terminology more inclusive for I2C Algobit and consumers (rev4) URL : https://patchwork.freedesktop.org/series/131867/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/131867/revisions/4/mbox/ not applied

[PATCH v3 6/6] fbdev/viafb: Make I2C terminology more inclusive

2024-05-08 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile

[PATCH v3 5/6] fbdev/smscufx: Make I2C terminology more inclusive

2024-05-08 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile

[PATCH v3 4/6] sfc: falcon: Make I2C terminology more inclusive

2024-05-08 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile

[PATCH v3 3/6] drm/i915: Make I2C terminology more inclusive

2024-05-08 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile

[PATCH v3 2/6] drm/gma500: Make I2C terminology more inclusive

2024-05-08 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile

[PATCH v3 1/6] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile

[PATCH v3 0/6] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-05-08 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of the I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Wed, May 8, 2024 at 4:12 PM Easwar Hariharan wrote: > > On 5/8/2024 7:53 AM, Alex Deucher wrote: > > On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan > > wrote: > >> > >> On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > >>> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced > >>>

Re: [PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-08 Thread Lucas De Marchi
On Wed, May 08, 2024 at 10:52:54PM GMT, Ville Syrjälä wrote: On Tue, May 07, 2024 at 11:53:40AM +0300, Jani Nikula wrote: On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > For some reason xe and i915 each have an identical (fortunately) > copy of intel_fbdev_fb.h. The xe

✓ Fi.CI.BAT: success for drm/i915/huc: pick the DG2 HuC up from the CI folder (rev2)

2024-05-08 Thread Patchwork
== Series Details == Series: drm/i915/huc: pick the DG2 HuC up from the CI folder (rev2) URL : https://patchwork.freedesktop.org/series/131526/ State : success == Summary == CI Bug Log - changes from CI_DRM_14733 -> Patchwork_131526v2

✗ Fi.CI.CHECKPATCH: warning for drm/i915/huc: pick the DG2 HuC up from the CI folder (rev2)

2024-05-08 Thread Patchwork
== Series Details == Series: drm/i915/huc: pick the DG2 HuC up from the CI folder (rev2) URL : https://patchwork.freedesktop.org/series/131526/ State : warning == Summary == Error: dim checkpatch failed 5667d317b5ad drm/i915/huc: pick the DG2 HuC up from the CI folder -:20: CHECK:SPACING:

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Easwar Hariharan
On 5/8/2024 7:53 AM, Alex Deucher wrote: > On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan > wrote: >> >> On 5/3/2024 11:13 AM, Easwar Hariharan wrote: >>> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" >>> with more appropriate terms. Inspired by and following on to

Re: [PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-08 Thread Ville Syrjälä
On Tue, May 07, 2024 at 11:53:40AM +0300, Jani Nikula wrote: > On Mon, 06 May 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > For some reason xe and i915 each have an identical (fortunately) > > copy of intel_fbdev_fb.h. The xe copy actually only gets included > > by xe's

[PULL] drm-intel-fixes

2024-05-08 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our last fixes for v6.9. drm-intel-fixes-2024-05-08: - Automate CCS Mode setting during engine resets (Andi) - Fix audio time stamp programming for DP (Chaitanya) - Fix parsing backlight BDB data (Karthikeyan) The following changes since commit

Re: [PATCH 3/5] drm/i915: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Ville Syrjälä
On Wed, May 08, 2024 at 12:12:32PM +0300, Jani Nikula wrote: > On Mon, 08 Apr 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Replace the open coded drm_crtc_vblank_crtc() with the real > > thing. > > > > Cc: intel-gfx@lists.freedesktop.org > > Signed-off-by: Ville Syrjälä > >

Re: [PATCH 2/5] drm/amdgpu: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Ville Syrjälä
On Wed, May 08, 2024 at 09:47:50AM -0400, Alex Deucher wrote: > On Mon, Apr 8, 2024 at 3:06 PM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > Replace the open coded drm_crtc_vblank_crtc() with the real > > thing. > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: "Pan,

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: remove implicit dev_priv from VRR

2024-05-08 Thread Patchwork
== Series Details == Series: drm/i915/display: remove implicit dev_priv from VRR URL : https://patchwork.freedesktop.org/series/10/ State : warning == Summary == Error: dim checkpatch failed b51cea67ab0e drm/i915: pass dev_priv explicitly to TRANS_VRR_CTL -:70: WARNING:LONG_LINE: line

✓ Fi.CI.BAT: success for drm/i915/display: remove implicit dev_priv from VRR

2024-05-08 Thread Patchwork
== Series Details == Series: drm/i915/display: remove implicit dev_priv from VRR URL : https://patchwork.freedesktop.org/series/10/ State : success == Summary == CI Bug Log - changes from CI_DRM_14731 -> Patchwork_10v1 Summary

[PATCH 10/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VSYNC

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_VSYNC register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vrr.c | 9 ++--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 7 insertions(+), 4

[PATCH 09/10] drm/i915: pass dev_priv explicitly to TRANS_PUSH

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_PUSH register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vrr.c | 9 + drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-)

[PATCH 08/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_STATUS2

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_STATUS2 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[PATCH 07/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_FLIPLINE

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_FLIPLINE register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vrr.c | 6 -- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 5 insertions(+), 3

[PATCH 06/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VTOTAL_PREV

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_VTOTAL_PREV register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[PATCH 05/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_STATUS

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_STATUS register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vrr.c | 3 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)

[PATCH 04/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VMAXSHIFT

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_VMAXSHIFT register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[PATCH 03/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VMIN

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_VMIN register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vrr.c | 6 -- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 5 insertions(+), 3

[PATCH 02/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VMAX

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_VMAX register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vrr.c | 6 -- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 5 insertions(+), 3

[PATCH 01/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_CTL

2024-05-08 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_VRR_CTL register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vrr.c | 13 - drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 9 insertions(+), 6

[PATCH 00/10] drm/i915/display: remove implicit dev_priv from VRR

2024-05-08 Thread Jani Nikula
Continue removing implicit dev_priv local variable use. This is all scripted, based on [1]. [1] https://lore.kernel.org/r/cover.1714136165.git.jani.nik...@intel.com Jani Nikula (10): drm/i915: pass dev_priv explicitly to TRANS_VRR_CTL drm/i915: pass dev_priv explicitly to TRANS_VRR_VMAX

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan wrote: > > On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > > with more appropriate terms. Inspired by and following on to Wolfram's > > series to fix drivers/i2c/[1],

RE: [PATCH] drm/i915/mtl: Update workaround 14018778641

2024-05-08 Thread Upadhyay, Tejas
> -Original Message- > From: Intel-gfx On Behalf Of Chen, > Angus > Sent: Tuesday, April 30, 2024 4:50 PM > To: Andi Shyti > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/mtl: Update workaround 14018778641 > > The original workaround was from >

Re: [PATCH 4/5] drm/i915: simplify ULT/ULX subplatform detection

2024-05-08 Thread Rodrigo Vivi
On Wed, May 08, 2024 at 04:01:56PM +0300, Jani Nikula wrote: > On Wed, 08 May 2024, Rodrigo Vivi wrote: > > On Tue, May 07, 2024 at 03:56:51PM +0300, Jani Nikula wrote: > >> For HSW/BDW ULX machines are also considered ULT. For the sake of > >> simplicity and clarity, handle this at the

Re: [PATCH 2/5] drm/amdgpu: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Alex Deucher
On Mon, Apr 8, 2024 at 3:06 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Replace the open coded drm_crtc_vblank_crtc() with the real > thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: amd-...@lists.freedesktop.org > Signed-off-by: Ville Syrjälä

Re: [RFC PATCH 0/3] Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2

2024-05-08 Thread Juha-Pekka Heikkila
On 8.5.2024 1.56, Matt Roper wrote: On Mon, May 06, 2024 at 09:52:35PM +0300, Juha-Pekka Heikkila wrote: These patches introduce I915_FORMAT_MOD_4_TILED_XE2_CCS modifier, which, from the kernel's perspective, behaves similarly to `I915_FORMAT_MOD_4_TILED`. This new modifier is primarily

Re: [PATCH 4/5] drm/i915: simplify ULT/ULX subplatform detection

2024-05-08 Thread Jani Nikula
On Wed, 08 May 2024, Rodrigo Vivi wrote: > On Tue, May 07, 2024 at 03:56:51PM +0300, Jani Nikula wrote: >> For HSW/BDW ULX machines are also considered ULT. For the sake of >> simplicity and clarity, handle this at the IS_XXX_ULT() macro level >> instead of two simultaneous subplatforms. >> >>

Re: [PATCH 4/5] drm/i915: simplify ULT/ULX subplatform detection

2024-05-08 Thread Rodrigo Vivi
On Tue, May 07, 2024 at 03:56:51PM +0300, Jani Nikula wrote: > For HSW/BDW ULX machines are also considered ULT. For the sake of > simplicity and clarity, handle this at the IS_XXX_ULT() macro level > instead of two simultaneous subplatforms. > > Signed-off-by: Jani Nikula > --- >

Re: [PATCH 3/5] drm/i915: separate RPL-U from RPL-P

2024-05-08 Thread Rodrigo Vivi
On Tue, May 07, 2024 at 03:56:50PM +0300, Jani Nikula wrote: > RPL-S is a subplatform of ADL-S and RPL-P is a subplatform of > ADL-P. It's a bit much that RPL-P also matches RPL-U. Separate RPL-U > from RPL-P, and make RPL-U a standalone subplatform of ADL-P. Now I confess I got lost. And I

Re: [PATCH 2/5] drm/i915: don't include RPL-U PCI IDs in RPL-P

2024-05-08 Thread Rodrigo Vivi
On Tue, May 07, 2024 at 03:56:49PM +0300, Jani Nikula wrote: > It's confusing for INTEL_RPLP_IDS() to include INTEL_RPLU_IDS(). Even if > we treat them the same elsewhere, the lists of PCI IDs should not. This shouldn't be required for the end goal, right? Since Xe is doing this as well. Anyway,

Re: [PATCH 1/5] drm/i915: don't include CML PCI IDs in CFL

2024-05-08 Thread Rodrigo Vivi
On Wed, May 08, 2024 at 11:33:43AM +0300, Jani Nikula wrote: > On Tue, 07 May 2024, Rodrigo Vivi wrote: > > On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote: > >> @@ -535,11 +541,7 @@ > >>INTEL_WHL_U_GT1_IDS(info), \ > >>INTEL_WHL_U_GT2_IDS(info), \ > >>

Re: PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Jani Nikula
On Wed, 08 May 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Wednesday, May 8, 2024 5:18 PM >> To: Murthy, Arun R ; Ville Syrjälä >> >> Cc: intel-gfx@lists.freedesktop.org >> Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl >> >> On

PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, May 8, 2024 5:18 PM > To: Murthy, Arun R ; Ville Syrjälä > > Cc: intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > On Wed, 08 May 2024, "Murthy, Arun R" wrote: > >>

Re: [PATCH 1/5] drm/i915: don't include CML PCI IDs in CFL

2024-05-08 Thread Ville Syrjälä
On Wed, May 08, 2024 at 02:45:10PM +0300, Jani Nikula wrote: > On Wed, 08 May 2024, Ville Syrjälä wrote: > > On Tue, May 07, 2024 at 09:47:16AM -0400, Rodrigo Vivi wrote: > >> On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote: > >> > It's confusing for INTEL_CFL_IDS() to include all CML

RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Jani Nikula
On Wed, 08 May 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Wednesday, May 8, 2024 3:29 PM >> To: Murthy, Arun R ; Ville Syrjälä >> >> Cc: intel-gfx@lists.freedesktop.org >> Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl >> >> On

Re: [PATCH 1/5] drm/i915: don't include CML PCI IDs in CFL

2024-05-08 Thread Jani Nikula
On Wed, 08 May 2024, Ville Syrjälä wrote: > On Tue, May 07, 2024 at 09:47:16AM -0400, Rodrigo Vivi wrote: >> On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote: >> > It's confusing for INTEL_CFL_IDS() to include all CML PCI IDs. Even if >> > we treat them the same in a lot of places, CML

RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, May 8, 2024 3:29 PM > To: Murthy, Arun R ; Ville Syrjälä > > Cc: intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > On Wed, 08 May 2024, "Murthy, Arun R" wrote: > > This

✓ Fi.CI.BAT: success for Cursor Fault Fix (rev2)

2024-05-08 Thread Patchwork
== Series Details == Series: Cursor Fault Fix (rev2) URL : https://patchwork.freedesktop.org/series/133311/ State : success == Summary == CI Bug Log - changes from CI_DRM_14727 -> Patchwork_133311v2 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for Cursor Fault Fix (rev2)

2024-05-08 Thread Patchwork
== Series Details == Series: Cursor Fault Fix (rev2) URL : https://patchwork.freedesktop.org/series/133311/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning:

✗ Fi.CI.CHECKPATCH: warning for Cursor Fault Fix (rev2)

2024-05-08 Thread Patchwork
== Series Details == Series: Cursor Fault Fix (rev2) URL : https://patchwork.freedesktop.org/series/133311/ State : warning == Summary == Error: dim checkpatch failed 11df68700d82 drm: Add drm_vblank_work_flush_all(). -:33: WARNING:WAITQUEUE_ACTIVE: waitqueue_active without comment #33: FILE:

Re: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Ville Syrjälä
On Wed, May 08, 2024 at 12:58:46PM +0300, Jani Nikula wrote: > On Wed, 08 May 2024, "Murthy, Arun R" wrote: > > This is the limitation from the retimer hardware. > > The commit message needs to reflect this. > > Do all units have a retimer with the limitation? Or could you have a DG2 > without

Re: [PATCH 1/5] drm/i915: don't include CML PCI IDs in CFL

2024-05-08 Thread Ville Syrjälä
On Tue, May 07, 2024 at 09:47:16AM -0400, Rodrigo Vivi wrote: > On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote: > > It's confusing for INTEL_CFL_IDS() to include all CML PCI IDs. Even if > > we treat them the same in a lot of places, CML is a platform of its own, > > and the lists of

[PULL] drm-misc-next-fixes

2024-05-08 Thread Maarten Lankhorst
Hi Dave, Sima, drm-misc-next-fixes for v6.10-rc1. There was some discussion on certain cherry picks I did, specifically the one for hiding fbdev address. There is some potential to cause regressions on ARM by hiding the physical address, but I think it should be fine to move ahead. This is why

RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl

2024-05-08 Thread Jani Nikula
On Wed, 08 May 2024, "Murthy, Arun R" wrote: > This is the limitation from the retimer hardware. The commit message needs to reflect this. Do all units have a retimer with the limitation? Or could you have a DG2 without the limitation? Do we need to check for that instead of blanket removal of

Regression on linux-next (next-20240506)

2024-05-08 Thread Borah, Chaitanya Kumar
Hello Thomas,   Hope you are doing well.   This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository.   Since the version next-20240506 [2], we are seeing the following regression   `

✗ Fi.CI.BAT: failure for Cursor Fault Fix

2024-05-08 Thread Patchwork
== Series Details == Series: Cursor Fault Fix URL : https://patchwork.freedesktop.org/series/133311/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14726 -> Patchwork_133311v1 Summary --- **FAILURE** Serious

Re: [PATCH 3/3] drm/i915: pass dev_priv explicitly to PORT_DFT2_G4X

2024-05-08 Thread Jani Nikula
On Mon, 06 May 2024, Ville Syrjälä wrote: > On Mon, May 06, 2024 at 01:09:04PM +0300, Jani Nikula wrote: >> Avoid the implicit dev_priv local variable use, and pass dev_priv >> explicitly to the PORT_DFT2_G4X register macro. > > Looks like we only use this on VLV/CHV, so could define a fixed >

✗ Fi.CI.SPARSE: warning for Cursor Fault Fix

2024-05-08 Thread Patchwork
== Series Details == Series: Cursor Fault Fix URL : https://patchwork.freedesktop.org/series/133311/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning:

✗ Fi.CI.CHECKPATCH: warning for Cursor Fault Fix

2024-05-08 Thread Patchwork
== Series Details == Series: Cursor Fault Fix URL : https://patchwork.freedesktop.org/series/133311/ State : warning == Summary == Error: dim checkpatch failed 48823212b63c drm: Add drm_vblank_work_flush_all(). -:33: WARNING:WAITQUEUE_ACTIVE: waitqueue_active without comment #33: FILE:

Re: [PATCH 2/5] drm/amdgpu: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the open coded drm_crtc_vblank_crtc() with the real > thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: amd-...@lists.freedesktop.org > Signed-off-by: Ville Syrjälä FWIW, Reviewed-by:

Re: [PATCH 3/5] drm/i915: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the open coded drm_crtc_vblank_crtc() with the real > thing. > > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_crtc.c | 3

Re: [PATCH 1/5] drm/i915: don't include CML PCI IDs in CFL

2024-05-08 Thread Jani Nikula
On Tue, 07 May 2024, Rodrigo Vivi wrote: > On Tue, May 07, 2024 at 03:56:48PM +0300, Jani Nikula wrote: >> @@ -535,11 +541,7 @@ >> INTEL_WHL_U_GT1_IDS(info), \ >> INTEL_WHL_U_GT2_IDS(info), \ >> INTEL_WHL_U_GT3_IDS(info), \ >> -INTEL_AML_CFL_GT2_IDS(info), \ >> -

[PATCH 4/4] drm/i915: Use the same vblank worker for atomic unpin

2024-05-08 Thread Chaitanya Kumar Borah
From: Maarten Lankhorst In case of legacy cursor update, the cursor VMA needs to be unpinned only after vblank. This exceeds the lifetime of the whole atomic commit. Any trick I attempted to keep the atomic commit alive didn't work, as drm_atomic_helper_setup_commit() force throttles on any old

[PATCH 3/4] drm/i915: Use vblank worker to unpin old legacy cursor fb safely

2024-05-08 Thread Chaitanya Kumar Borah
From: Ville Syrjälä The cursor hardware only does sync updates, and thus the hardware will be scanning out from the old fb until the next start of vblank. So in order to make the legacy cursor fastpath actually safe we should not unpin the old fb until we're sure the hardware has ceased

[PATCH 2/4] drm: Add helper to check if there are pending vblank work

2024-05-08 Thread Chaitanya Kumar Borah
Add helper to check if there are pending vblank work for a crtc which are yet to be scheduled. Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/drm/drm_vblank_work.c | 24 include/drm/drm_vblank_work.h | 1 + 2 files changed, 25 insertions(+) diff --git

[PATCH 1/4] drm: Add drm_vblank_work_flush_all().

2024-05-08 Thread Chaitanya Kumar Borah
From: Maarten Lankhorst In some cases we want to flush all vblank work, right before vblank_off for example. Add a simple function to make this possible. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_vblank_work.c | 22 ++ include/drm/drm_vblank_work.h | 2

[PATCH 0/4] Cursor Fault Fix

2024-05-08 Thread Chaitanya Kumar Borah
This series is based on the following series by Maarten https://patchwork.freedesktop.org/series/132900/ It is an attempt at solving CI issues seen in the original series

Re: [PATCH 11/11] drm/tegra: Use fbdev client helpers

2024-05-08 Thread Thomas Zimmermann
Hi Am 07.05.24 um 23:03 schrieb Felix Kuehling: On 2024-05-07 07:58, Thomas Zimmermann wrote: Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann