✗ Fi.CI.IGT: failure for drm/i915: skl+ plane register stuff (rev6)

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915: skl+ plane register stuff (rev6) URL : https://patchwork.freedesktop.org/series/133458/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14756_full -> Patchwork_133458v6_full Summary

✓ Fi.CI.BAT: success for drm/edid: remove drm_do_get_edid()

2024-05-13 Thread Patchwork
== Series Details == Series: drm/edid: remove drm_do_get_edid() URL : https://patchwork.freedesktop.org/series/133569/ State : success == Summary == CI Bug Log - changes from CI_DRM_14757 -> Patchwork_133569v1 Summary ---

Re: [PATCH 16/16] drm/i915: Handle SKL+ WM/DDB registers next to all other plane registers

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Having the plane WM/DDB regitster write functions in skl_watermarks.c > is rather annoying when trying to implement DSB based plane updates. > Move them into the respective files that handle all other plane > register writes.

Re: [PATCH 15/16] drm/i915: Nuke skl_write_wm_level() and skl_ddb_entry_write()

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Get rid of skl_ddb_entry_write() and skl_write_wm_level() and > just call intel_de_write_fw() directly. > > This is prep work towards DSB based plane updates where these > wrappers are more of a hinderance. > > Done with cocci

Re: [PATCH v2 13/16] drm/i915: Refactor skl+ plane register offset calculations

2024-05-13 Thread Jani Nikula
On Mon, 13 May 2024, Jani Nikula wrote: > On Mon, 13 May 2024, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Currentluy every skl+ plane register defines some intermediate *Currently >> macros to calculate the final register offset. Pull all of that >> into common macros, simplifying the

Re: [PATCH 14/16] drm/i915: Extract skl_plane_{wm,ddb}_reg_val()

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Extract helpers to calculate the final wm/ddb register > values for skl+. Will allow me to more cleanly remove the > register write wrappers for these registers. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula >

Re: [PATCH v2 13/16] drm/i915: Refactor skl+ plane register offset calculations

2024-05-13 Thread Jani Nikula
On Mon, 13 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Currentluy every skl+ plane register defines some intermediate > macros to calculate the final register offset. Pull all of that > into common macros, simplifying the final register offset stuff > into just five defines: > - raw

Re: [PATCH v2 10/16] drm/i915: Shuffle the skl+ plane register definitions

2024-05-13 Thread Jani Nikula
On Mon, 13 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Rearrange the plane skl+ universal plane register definitions: > - keep everything related to the same register in one place > - sort based on register offset > - unify the whitespace/etc a bit > > v2: Define register contents

[PATCH] drm/edid: remove drm_do_get_edid()

2024-05-13 Thread Jani Nikula
All users of drm_do_get_edid() have been converted to drm_edid_read_custom(). Remove the unused function to prevent new users from creeping in. Signed-off-by: Jani Nikula --- Cc: Robert Foss Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- drivers/gpu/drm/drm_edid.c | 28

Re: [PATCH 1/2] drm/xe/display: remove unused xe->enabled_irq_mask

2024-05-13 Thread Jani Nikula
On Mon, 13 May 2024, Lucas De Marchi wrote: > On Mon, May 13, 2024 at 03:10:29PM GMT, Jani Nikula wrote: >>On Fri, 10 May 2024, Jani Nikula wrote: >>> The xe->enabled_irq_mask member has never been used for anything. >>> >>> Signed-off-by: Jani Nikula >> >>Lucas, ack for merging these two via

Re: [PATCH 2/9] drm: Export drm_plane_has_format()

2024-05-13 Thread Jani Nikula
On Mon, 13 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Export drm_plane_has_format() so that drivers can use it. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_crtc_internal.h | 2 -- > drivers/gpu/drm/drm_plane.c | 1 + >

Re: [PATCH 1/9] drm: Rename drm_plane_check_pixel_format() to drm_plane_has_format()

2024-05-13 Thread Jani Nikula
On Mon, 13 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename drm_plane_check_pixel_format() to drm_plane_has_format() > and change the return type accordingly. Allows one to write > more natural code. > > Also matches drm_any_plane_has_format() better. > > Signed-off-by: Ville

✗ Fi.CI.BAT: failure for drm/i915: Polish plane surface alignment handling

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915: Polish plane surface alignment handling URL : https://patchwork.freedesktop.org/series/133564/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14756 -> Patchwork_133564v1 Summary

✗ Fi.CI.SPARSE: warning for drm/i915: Polish plane surface alignment handling

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915: Polish plane surface alignment handling URL : https://patchwork.freedesktop.org/series/133564/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915: skl+ plane register stuff (rev6)

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915: skl+ plane register stuff (rev6) URL : https://patchwork.freedesktop.org/series/133458/ State : success == Summary == CI Bug Log - changes from CI_DRM_14756 -> Patchwork_133458v6 Summary ---

✗ Fi.CI.CHECKPATCH: warning for drm/i915: skl+ plane register stuff (rev6)

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915: skl+ plane register stuff (rev6) URL : https://patchwork.freedesktop.org/series/133458/ State : warning == Summary == Error: dim checkpatch failed 6783d48ac30b drm/i915: Nuke _MMIO_PLANE_GAMC() 6d5c913cfe2c drm/i915: Extract skl_universal_plane_regs.h

✗ Fi.CI.SPARSE: warning for drm/i915: skl+ plane register stuff (rev6)

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915: skl+ plane register stuff (rev6) URL : https://patchwork.freedesktop.org/series/133458/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH 9/9] drm/i915: Nuke the TGL+ chroma plane tile row alignment stuff

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä I don't think the display hardware really has such chroma plane tile row alignment requirements as outlined in commit d156135e6a54 ("drm/i915/tgl: Make sure a semiplanar UV plane is tile row size aligned") Bspec had the same exact thing to say about earlier hardware as well,

[PATCH 8/9] drm/i915: Update plane alignment requirements for TGL+

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Currently we still use the SKL+ PLANE_SURF alignment even for TGL+ even though the hardware no longer needs it. Introduce a separate tgl_plane_min_alignment() and update it to more accurately reflect the hardware requirements. Signed-off-by: Ville Syrjälä ---

[PATCH 7/9] drm/i915: Move intel_surf_alignment() into skl_univerals_plane.c

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Now that all pre-skl platforms have their own .min_alignment() functions the remainder of intel_surf_alignment() can be hoisted into skl_univerals_plane.c (and renamed appropriately). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fb.c | 77

[PATCH 6/9] drm/i915: Split pre-skl platforms out from intel_surf_alignment()

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Extract the necessary chunks from intel_surf_alignment() into per-platform variants for all pre-skl primary/sprite planes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i9xx_plane.c | 69 - drivers/gpu/drm/i915/display/intel_fb.c |

[PATCH 5/9] drm/i915: Split cursor alignment to per-platform vfuncs

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Split intel_cursor_alignment() into per-platform variants. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cursor.c | 40 +++-- drivers/gpu/drm/i915/display/intel_fb.c | 16 - drivers/gpu/drm/i915/display/intel_fb.h | 3

[PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Different planes could have different alignment requirements even for the same format/modifier. Collect the alignment requirements across all planes capable of scanning out the fb such that the alignment used when pinning the normal ggtt view is satisfactory to all those

[PATCH 3/9] drm/i915: Introduce plane->min_alignment() vfunc

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Different hardware generations have different scanout alignment requirements. Introduce a new vfunc that will allow us to make that distinction without horrible if-ladders. For now we directly plug in the existing intel_surf_alignment() and intel_cursor_alignment()

[PATCH 1/9] drm: Rename drm_plane_check_pixel_format() to drm_plane_has_format()

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Rename drm_plane_check_pixel_format() to drm_plane_has_format() and change the return type accordingly. Allows one to write more natural code. Also matches drm_any_plane_has_format() better. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c| 7 ++-

[PATCH 2/9] drm: Export drm_plane_has_format()

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Export drm_plane_has_format() so that drivers can use it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc_internal.h | 2 -- drivers/gpu/drm/drm_plane.c | 1 + include/drm/drm_plane.h | 2 ++ 3 files changed, 3 insertions(+), 2 deletions(-)

[PATCH 0/9] drm/i915: Polish plane surface alignment handling

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä intel_surf_alignment() in particular has devolved into a complete mess. Redesign the code so that we can handle alignment restrictions in a nicer. Also adjust alignment for TGL+ to actually match the hardware requirements. Ville Syrjälä (9): drm: Rename

Re: [RESEND 4/6] drm/amdgpu: remove amdgpu_connector_edid() and stop using edid_blob_ptr

2024-05-13 Thread Robert Foss
On Fri, May 10, 2024 at 5:09 PM Jani Nikula wrote: > > amdgpu_connector_edid() copies the EDID from edid_blob_ptr as a side > effect if amdgpu_connector->edid isn't initialized. However, everywhere > that the returned EDID is used, the EDID should have been set > beforehands. > > Only the drm

[PATCH v2 13/16] drm/i915: Refactor skl+ plane register offset calculations

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Currentluy every skl+ plane register defines some intermediate macros to calculate the final register offset. Pull all of that into common macros, simplifying the final register offset stuff into just five defines: - raw register offsets for the planes 1 and 2 on pipes A and

[PATCH v2 12/16] drm/i915: Drop a few unwanted tabs from skl+ plane reg defines

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä A few extra tabs have snuck into the skl+ plane register bit definitions. Remove them. v2: Rebase Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_universal_plane_regs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v2 11/16] drm/i915: Use REG_BIT for PLANE_WM bits

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä A couple of PLANE_WM bits were still using the hand rolled (1< Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_universal_plane_regs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RESEND 3/6] drm/radeon: remove radeon_connector_edid() and stop using edid_blob_ptr

2024-05-13 Thread Robert Foss
On Fri, May 10, 2024 at 5:08 PM Jani Nikula wrote: > > radeon_connector_edid() copies the EDID from edid_blob_ptr as a side > effect if radeon_connector->edid isn't initialized. However, everywhere > that the returned EDID is used, the EDID should have been set > beforehands. > > Only the drm

[PATCH v2 10/16] drm/i915: Shuffle the skl+ plane register definitions

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä Rearrange the plane skl+ universal plane register definitions: - keep everything related to the same register in one place - sort based on register offset - unify the whitespace/etc a bit v2: Define register contents after all offsets (Jani) Cc: Jani Nikula Signed-off-by:

[PATCH v2 09/16] drm/i915: Drop useless PLANE_FOO_3 register defines

2024-05-13 Thread Ville Syrjala
From: Ville Syrjälä We only need register defines for the first two planes on the first two pipes. Nuke everything else. v2: Drop a few more that snuck through Reviewed-by: Jani Nikula #v1 Signed-off-by: Ville Syrjälä --- .../i915/display/skl_universal_plane_regs.h | 19

Re: [RESEND 2/6] drm/radeon: convert to using is_hdmi and has_audio from display info

2024-05-13 Thread Robert Foss
On Fri, May 10, 2024 at 5:08 PM Jani Nikula wrote: > > Prefer the parsed results for is_hdmi and has_audio in display info over > calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), > respectively. > > Cc: Alex Deucher > Cc: Christian König > Cc: Pan, Xinhui > Cc:

Re: [PATCH 10/16] drm/i915: Shuffle the skl+ plane register definitions

2024-05-13 Thread Ville Syrjälä
On Mon, May 13, 2024 at 02:28:11PM +0300, Jani Nikula wrote: > On Fri, 10 May 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Rearrange the plane skl+ universal plane register definitions: > > - keep everything related to the same register in one place > > - sort based on register

Re: [PATCH] drm/i915/gem/i915_gem_ttm_move: Fix typo

2024-05-13 Thread Rodrigo Vivi
On Mon, May 13, 2024 at 02:14:51AM -0400, Deming Wang wrote: > The mapings should be replaced by mappings. > > Signed-off-by: Deming Wang Reviewed-by: Rodrigo Vivi and pushed to drm-intel-gt-next thanks for the patch > --- > drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 2 +- > 1 file

RE: [v4] drm/i915: Implement Audio WA_14020863754

2024-05-13 Thread Shankar, Uma
> -Original Message- > From: Shankar, Uma > Sent: Thursday, May 9, 2024 11:05 AM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; > jani.nik...@linux.intel.com; Roper, Matthew D ; > Shankar, Uma > Subject: [v4] drm/i915: Implement

Re: [PATCH 1/2] drm/xe/display: remove unused xe->enabled_irq_mask

2024-05-13 Thread Lucas De Marchi
On Mon, May 13, 2024 at 03:10:29PM GMT, Jani Nikula wrote: On Fri, 10 May 2024, Jani Nikula wrote: The xe->enabled_irq_mask member has never been used for anything. Signed-off-by: Jani Nikula Lucas, ack for merging these two via drm-intel-next? Even though these touch struct xe_device, I

✓ Fi.CI.BAT: success for drm/i915/gem/i915_gem_ttm_move: Fix typo

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915/gem/i915_gem_ttm_move: Fix typo URL : https://patchwork.freedesktop.org/series/133540/ State : success == Summary == CI Bug Log - changes from CI_DRM_14754 -> Patchwork_133540v1 Summary ---

[PATCH v2] drm/i915/mtl: Update workaround 14018778641

2024-05-13 Thread Chen, Angus
The WA should be extended to cover VDBOX engine. We found that 28-channels 1080p VP9 encoding may hit this issue. Signed-off-by: Chen, Angus --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c

✗ Fi.CI.BUILD: failure for drm/i915: Correct error handler (rev4)

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915: Correct error handler (rev4) URL : https://patchwork.freedesktop.org/series/133538/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/133538/revisions/4/mbox/ not applied Applying: drm/i915: Correct error

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-13 Thread Alex Deucher
On Mon, May 13, 2024 at 8:20 AM Jani Nikula wrote: > > On Fri, 10 May 2024, Alex Deucher wrote: > > On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote: > >> > >> I've sent this some moths ago, let's try again... > >> > >> BR, > >> Jani. > >> > >> Jani Nikula (6): > >> drm/nouveau: convert to

Re: [PATCH] drm/i915: Correct error handler

2024-05-13 Thread Jiasheng Jiang
Maybe the format is incorrect. I would like to use "jiashengjiangc...@outlook.com" to resend my patch. -Jiasheng From: Jiasheng Jiang Sent: Saturday, May 11, 2024 3:40 To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com;

[PATCH] drm/i915: Correct error handler

2024-05-13 Thread Jiasheng Jiang
Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak. Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/i915/i915_scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] drm/i915: Correct error handler

2024-05-13 Thread Jiasheng Jiang
From: Jiasheng Jiang Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak. Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/i915/i915_scheduler.c | 2 +- 1 file changed, 1

[PATCH] drm/i915/gem/i915_gem_ttm_move: Fix typo

2024-05-13 Thread Deming Wang
The mapings should be replaced by mappings. Signed-off-by: Deming Wang --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c index

[PATCH] drm/i915: Correct error handler

2024-05-13 Thread Jiasheng Jiang
Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak. Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/i915/i915_scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] drm/i915: Correct error handler

2024-05-13 Thread Jiasheng Jiang
Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak. Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/i915/i915_scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2] drm/i915/mtl: Update workaround 14018778641

2024-05-13 Thread Chen, Angus
From: Angus Chen Applying it to VDBOX after recent performance data on MTL Signed-off-by: Angus Chen --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Alex Deucher wrote: > On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote: >> >> I've sent this some moths ago, let's try again... >> >> BR, >> Jani. >> >> Jani Nikula (6): >> drm/nouveau: convert to using is_hdmi and has_audio from display info >> drm/radeon: convert to

Re: [RESEND 1/6] drm/nouveau: convert to using is_hdmi and has_audio from display info

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Lyude Paul wrote: > Reviewed-by: Lyude Paul Thanks, how do you want to handle merging this? BR, Jani. > > On Fri, 2024-05-10 at 18:08 +0300, Jani Nikula wrote: >> Prefer the parsed results for is_hdmi and has_audio in display info >> over >> calling

Re: [PATCH 1/2] drm/xe/display: remove unused xe->enabled_irq_mask

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Jani Nikula wrote: > The xe->enabled_irq_mask member has never been used for anything. > > Signed-off-by: Jani Nikula Lucas, ack for merging these two via drm-intel-next? Even though these touch struct xe_device, I presume any further cleanups touching the surrounding

✓ Fi.CI.BAT: success for drm/i915/fbc: Add sizes to info message about reducing fb size

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Add sizes to info message about reducing fb size URL : https://patchwork.freedesktop.org/series/133534/ State : success == Summary == CI Bug Log - changes from CI_DRM_14752 -> Patchwork_133534v1

✗ Fi.CI.CHECKPATCH: warning for drm/i915/fbc: Add sizes to info message about reducing fb size

2024-05-13 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Add sizes to info message about reducing fb size URL : https://patchwork.freedesktop.org/series/133534/ State : warning == Summary == Error: dim checkpatch failed f707833392ee drm/i915/fbc: Add sizes to info message about reducing fb size -:10:

RE: [PATCH v8 1/7] drm/i915: Define and compute Transcoder CMRR registers

2024-05-13 Thread Jani Nikula
On Mon, 13 May 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Mitul >> Golani >> Sent: Thursday, May 9, 2024 1:28 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Shankar, Uma ; Nikula, Jani >> >> Subject: [PATCH v8 1/7] drm/i915: Define and compute

Re: [PATCH v8 1/7] drm/i915: Define and compute Transcoder CMRR registers

2024-05-13 Thread Jani Nikula
On Thu, 09 May 2024, Mitul Golani wrote: > Add register definitions for Transcoder Fixed Average > Vtotal mode/CMRR function, with the necessary bitfields. > Compute these registers when CMRR is enabled, extending > Adaptive refresh rate capabilities. > > --v2: > - Use intel_de_read64_2x32 in

Re: [PATCH 10/16] drm/i915: Shuffle the skl+ plane register definitions

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Rearrange the plane skl+ universal plane register definitions: > - keep everything related to the same register in one place > - sort based on register offset > - unify the whitespace/etc a bit > > Signed-off-by: Ville Syrjälä

RE: [PATCH v4 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-13 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Monday, May 13, 2024 1:02 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Murthy, Arun R > ; Nikula, Jani > Subject: Re: [PATCH v4 4/6] drm/i915/alpm: Add compute config for lobf >

RE: [PATCH] drm/i915/bmg: Load DMC

2024-05-13 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Intel-xe On Behalf Of > Gustavo Sousa > Sent: Friday, May 10, 2024 7:36 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Subject: [PATCH] drm/i915/bmg: Load DMC > > Load Battlemage's DMC. We re-use XELPDP_DMC_MAX_FW_SIZE since

RE: [PATCH v8 2/7] drm/i915: Add Enable/Disable for CMRR based on VRR state

2024-05-13 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Mitul > Golani > Sent: Thursday, May 9, 2024 1:28 PM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nikula, Jani > > Subject: [PATCH v8 2/7] drm/i915: Add Enable/Disable for CMRR based on VRR > state > > Add CMRR/Fixed

[PATCH] drm/i915/fbc: Add sizes to info message about reducing fb size

2024-05-13 Thread Paul Menzel
The info message currently does not contain any information, how much the stolen memory size should be increased. [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS. To be more

Re: [PATCH 12/16] drm/i915: Drop a few unwanted tabs from skl+ plane reg defines

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > A few extra tabs have snuck into the skl+ plane register bit > definitions. Remove them. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/skl_universal_plane_regs.h | 6 +++--- >

Re: [PATCH 11/16] drm/i915: Use REG_BIT for PLANE_WM bits

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > A couple of PLANE_WM bits were still using the hand > rolled (1< > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/skl_universal_plane_regs.h | 4 ++-- > 1 file changed, 2

Re: [PATCH 09/16] drm/i915: Drop useless PLANE_FOO_3 register defines

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > We only need register defines for the first two planes > on the first two pipes. Nuke everything else. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > .../gpu/drm/i915/display/skl_universal_plane_regs.h |

Re: [PATCH 08/16] drm/i915/gvt: Use PLANE_CTL and PLANE_SURF defines

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop hand rolling PLANE_CTL and PLANE_SURF for the third plane > and just use the real thing. > > Cc: Zhenyu Wang > CC: Zhi Wang > Signed-off-by: Ville Syrjälä The original is a baffling mix. Reviewed-by: Jani Nikula >

RE: [PATCH 0/7] Enable Aux Based EDP HDR

2024-05-13 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Tuesday, May 7, 2024 9:34 AM > To: intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Kandpal, Suraj > > Subject: [PATCH 0/7] Enable Aux Based EDP HDR > > This

Re: [PATCH 07/16] drm/i915/gvt: Use the full PLANE_KEY*() defines

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop hand rolling PLANE_KEY*() register defines and just > use the real thing. > > Cc: Zhenyu Wang > CC: Zhi Wang > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_gvt_mmio_table.c

Re: [PATCH 06/16] drm/i915/gvt: Use the proper PLANE_AUX_OFFSET() define

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop hand rolling PLANE_AUX_OFFSET() and just use the real thing. > > Cc: Zhenyu Wang > CC: Zhi Wang > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/gvt/handlers.c | 24

Re: [PATCH 05/16] drm/i915/gvt: Use the proper PLANE_AUX_DIST() define

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop hand rolling PLANE_AUX_DIST() and just use the real thing. > > Cc: Zhenyu Wang > CC: Zhi Wang > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/gvt/handlers.c | 24

Re: [PATCH 04/16] drm/i915: Move skl+ wm/ddb registers to proper headers

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > On SKL+ the watermark/DDB registers are proper per-plane > registers. Move the definitons to their respective files. > > Cc: Zhenyu Wang > CC: Zhi Wang > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [PATCH 03/16] drm/i915: Extract intel_cursor_regs.h

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Move most cursor register definitions into their own file. > Declutters i915_reg.h a bit more. > > Cc: Zhenyu Wang > CC: Zhi Wang > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [PATCH 02/16] drm/i915: Extract skl_universal_plane_regs.h

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Move most of the SKL+ universal plane register definitions > into their own file. Declutters i915_reg.h a bit more. > > Cc: Zhenyu Wang > CC: Zhi Wang > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [PATCH 01/16] drm/i915: Nuke _MMIO_PLANE_GAMC()

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > _MMIO_PLANE_GAMC() is some leftover macro that is never used. > Get rid of it. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 2 -- > 1 file changed, 2 deletions(-) > >

Re: ✗ Fi.CI.IGT: failure for drm/i915/gt: Disarm breadcrumbs if engines are already idle (rev4)

2024-05-13 Thread Janusz Krzysztofik
On Friday, 10 May 2024 08:12:02 GMT+2 Patchwork wrote: > == Series Details == > > Series: drm/i915/gt: Disarm breadcrumbs if engines are already idle (rev4) > URL : https://patchwork.freedesktop.org/series/132786/ > State : failure > > == Summary == > > CI Bug Log - changes from

Re: ✗ Fi.CI.IGT: failure for Documentation/i915: remove kernel-doc for DMC wakelocks

2024-05-13 Thread Luca Coelho
Hi, There is no way that the tests that are failing in the shards have anything to do with the small documentation change that is in my patch.  Can you please re-report? Thanks! -- Cheers, Luca. On Sat, 2024-05-11 at 01:02 +, Patchwork wrote: > Patch Details > Series:Documentation/i915:

Re: [PATCH v4 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-13 Thread Hogander, Jouni
On Thu, 2024-05-09 at 11:01 +0530, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC

Re: [PATCH] drm/i915: Correct error handler

2024-05-13 Thread Nirmoy Das
On 5/11/2024 5:48 PM, Jiasheng Jiang wrote: Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak. Nice catch. I would make the subject more like: drm/i915: Fix memory leak by correcting cache object name in error handler Fixes: 32eb6bcfdda9

RE: [PATCH v8 1/7] drm/i915: Define and compute Transcoder CMRR registers

2024-05-13 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Mitul > Golani > Sent: Thursday, May 9, 2024 1:28 PM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nikula, Jani > > Subject: [PATCH v8 1/7] drm/i915: Define and compute Transcoder CMRR > registers > > Add register