✓ Fi.CI.BAT: success for drm/i915/display: Update calculation to avoid overflow (rev2)

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915/display: Update calculation to avoid overflow (rev2) URL : https://patchwork.freedesktop.org/series/134860/ State : success == Summary == CI Bug Log - changes from CI_DRM_14938 -> Patchwork_134860v2 Sum

✓ Fi.CI.BAT: success for CMRR patch fixes

2024-06-13 Thread Patchwork
== Series Details == Series: CMRR patch fixes URL : https://patchwork.freedesktop.org/series/134865/ State : success == Summary == CI Bug Log - changes from CI_DRM_14938 -> Patchwork_134865v1 Summary --- **SUCCESS** No regressions

✓ Fi.CI.BAT: success for drm/i915/display: Update calculation to avoid overflow

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915/display: Update calculation to avoid overflow URL : https://patchwork.freedesktop.org/series/134860/ State : success == Summary == CI Bug Log - changes from CI_DRM_14938 -> Patchwork_134860v1 Summary --

[PATCH v2] drm/i915/display: Update calculation to avoid overflow

2024-06-13 Thread Mitul Golani
Update calculation to avoid overflow. -v2: Remove extra line between cc and signed-off. Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Suraj Kandpal Cc: Jani Nikula Cc: Stephen Rothwell Signed-off-by: Mitul Golani Reviewed-by: Ank

[PATCH v2 0/2] CMRR patch fixes

2024-06-13 Thread Mitul Golani
Address following issues regarding CMRR 1. Describe target_rr_divider in struct drm_dp_as_sdp. 2. Use required macro to avoid overflow. -v2: - Remove extra line from commit message. Mitul Golani (2): drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp drm/i915/display: Update calculat

[PATCH v2 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-13 Thread Mitul Golani
Describe newly added parameter target_rr_divider in struct drm_dp_as_sdp. -v2: Remove extra line from commit message.(Lucas) Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing AS SDP") Cc: Mitul Golani Cc: Arun R Murthy Cc: Suraj Kandpal Cc: Ankit Nautiyal Cc: Jani

[PATCH v2 2/2] drm/i915/display: Update calculation to avoid overflow

2024-06-13 Thread Mitul Golani
Update calculation to avoid overflow. -v2: Remove extra line from commit message.(Lucas) Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Suraj Kandpal Cc: Jani Nikula Cc: Stephen Rothwell Signed-off-by: Mitul Golani Reviewed-by: An

[PATCH] drm/i915/display: Update calculation to avoid overflow

2024-06-13 Thread Mitul Golani
Update calculation to avoid overflow. Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Suraj Kandpal Cc: Jani Nikula Cc: Stephen Rothwell Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/int

✓ Fi.CI.BAT: success for drm/i915/gt/uc: Fix typo in comment

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915/gt/uc: Fix typo in comment URL : https://patchwork.freedesktop.org/series/134851/ State : success == Summary == CI Bug Log - changes from CI_DRM_14937 -> Patchwork_134851v1 Summary --- **SUCCESS*

✗ Fi.CI.SPARSE: warning for drm/i915/gt/uc: Fix typo in comment

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915/gt/uc: Fix typo in comment URL : https://patchwork.freedesktop.org/series/134851/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915/gt/uc: Evaluate GuC priority within locks (rev4)

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915/gt/uc: Evaluate GuC priority within locks (rev4) URL : https://patchwork.freedesktop.org/series/134525/ State : success == Summary == CI Bug Log - changes from CI_DRM_14937 -> Patchwork_134525v4 Summary

[PATCH] drm/i915/gt/uc: Fix typo in comment

2024-06-13 Thread Andi Shyti
Replace "dynmically" with "dynamically". Signed-off-by: Andi Shyti Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h ind

[PATCH] drm/i915/gt/uc: Evaluate GuC priority within locks

2024-06-13 Thread Andi Shyti
The ce->guc_state.lock was made to protect guc_prio, which indicates the GuC priority level. But at the begnning of the function we perform some sanity check of guc_prio outside its protected section. Move them within the locked region. Use this occasion to expand the if statement to make it clea

[PATCH] drm/i915/gt/uc: Evaluate GuC priority within locks

2024-06-13 Thread Andi Shyti
The ce->guc_state.lock was made to protect guc_prio, which indicates the GuC priority level. But at the begnning of the function we perform some sanity check of guc_prio outside its protected section. Move them within the locked region. Use this occasion to expand the if statement to make it clea

Re: [PATCH 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-13 Thread Lucas De Marchi
On Thu, Jun 13, 2024 at 10:43:16AM GMT, Mitul Golani wrote: Describe newly added parameter target_rr_divider in struct drm_dp_as_sdp. Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing AS SDP") Cc: Mitul Golani Cc: Arun R Murthy Cc: Suraj Kandpal Cc: Ankit Nautiyal

Re: ✗ Fi.CI.IGT: failure for drm/i915/dp_mst: Enable link training fallback (rev5)

2024-06-13 Thread Imre Deak
On Tue, Jun 11, 2024 at 07:15:54AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp_mst: Enable link training fallback (rev5) > URL : https://patchwork.freedesktop.org/series/133624/ > State : failure Thanks for the reviews, patchset is pushed to -din. The failures are unr

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsc: don't mess up splitter state in joiner or dsc config

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915/dsc: don't mess up splitter state in joiner or dsc config URL : https://patchwork.freedesktop.org/series/134825/ State : warning == Summary == Error: dim checkpatch failed 426978d76908 drm/i915/dsc: don't mess up splitter state in joiner or dsc config -:79

[PATCH] drm/i915/dsc: don't mess up splitter state in joiner or dsc config

2024-06-13 Thread Jani Nikula
The driver handles splitter (for MSO) and joiner/dsc configuration in different places. Avoid messing up the splitter state when enabling/disabling joiner or dsc. Note: We should probably handle splitter for MSO as well as dual-link DSI in intel_vdsc.c. Also, we have intel_uncompressed_joiner_enab

✓ Fi.CI.BAT: success for drm/i915/dsc: don't mess up splitter state in joiner or dsc config

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915/dsc: don't mess up splitter state in joiner or dsc config URL : https://patchwork.freedesktop.org/series/134825/ State : success == Summary == CI Bug Log - changes from CI_DRM_14935 -> Patchwork_134825v1

Re: ✓ Fi.CI.IGT: success for drm/i915/dp_mst: Fix DSC input BPP computation

2024-06-13 Thread Imre Deak
On Wed, Jun 12, 2024 at 06:40:34AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp_mst: Fix DSC input BPP computation > URL : https://patchwork.freedesktop.org/series/134726/ > State : success Thanks for the review, pushed this now to drm-intel-next. > == Summary == > >

✓ Fi.CI.BAT: success for drm: add missing MODULE_DESCRIPTION() macros (rev2)

2024-06-13 Thread Patchwork
== Series Details == Series: drm: add missing MODULE_DESCRIPTION() macros (rev2) URL : https://patchwork.freedesktop.org/series/134680/ State : success == Summary == CI Bug Log - changes from CI_DRM_14933 -> Patchwork_134680v2 Summary -

✗ Fi.CI.SPARSE: warning for drm: add missing MODULE_DESCRIPTION() macros (rev2)

2024-06-13 Thread Patchwork
== Series Details == Series: drm: add missing MODULE_DESCRIPTION() macros (rev2) URL : https://patchwork.freedesktop.org/series/134680/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [PATCH v2] drm: add missing MODULE_DESCRIPTION() macros

2024-06-13 Thread Jeff Johnson
On 6/11/2024 6:56 AM, Jeff Johnson wrote: > On x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/gud/gud.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/drm_panel_orientation_quirks.o > WARNING: modpost: miss

Re: [f2fs-dev] [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-06-13 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Steven Rostedt (Google) : On Thu, 16 May 2024 13:34:54 -0400 you wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.1

[PATCH v2] drm: add missing MODULE_DESCRIPTION() macros

2024-06-13 Thread Jeff Johnson
On x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/gud/gud.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_panel_orientation_quirks.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/i915/kvm

[PATCH v2 0/8] drm/i915: PREEMPT_RT related fixups.

2024-06-13 Thread Sebastian Andrzej Siewior
Hi, The following patches are from the PREEMPT_RT queue. It is mostly about disabling interrupts/preemption which leads to problems. Unfortunately DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks from within trace points. Making the lock a raw_spinlock_t led to higher l

[PATCH v2 7/8] drm/i915/guc: Consider also RCU depth in busy loop.

2024-06-13 Thread Sebastian Andrzej Siewior
intel_guc_send_busy_loop() looks at in_atomic() and irqs_disabled() to decide if it should busy-spin while waiting or if it may sleep. Both checks will report false on PREEMPT_RT if sleeping spinlocks are acquired leading to RCU splats while the function sleeps. Check also if RCU has been disabled

[PATCH v2 4/8] drm/i915: Disable tracing points on PREEMPT_RT

2024-06-13 Thread Sebastian Andrzej Siewior
Luca Abeni reported this: | BUG: scheduling while atomic: kworker/u8:2/15203/0x0003 | CPU: 1 PID: 15203 Comm: kworker/u8:2 Not tainted 4.19.1-rt3 #10 | Call Trace: | rt_spin_lock+0x3f/0x50 | gen6_read32+0x45/0x1d0 [i915] | g4x_get_vblank_counter+0x36/0x40 [i915] | trace_event_raw_event_i915

[PATCH v2 6/8] drm/i915: Drop the irqs_disabled() check

2024-06-13 Thread Sebastian Andrzej Siewior
The !irqs_disabled() check triggers on PREEMPT_RT even with i915_sched_engine::lock acquired. The reason is the lock is transformed into a sleeping lock on PREEMPT_RT and does not disable interrupts. There is no need to check for disabled interrupts. The lockdep annotation below already check if t

[PATCH v8 06/20] drm/i915/psr: Disable PSR2 SU Region Early Transport if psr_enable is set

2024-06-13 Thread Jouni Högander
Currently PSR2 SU Region Early Transport is enabled by default on Lunarlake if panel supports it despite psr_enable value. Prevent SU Region Early Transport if psr_enable is set to than -1 which is the default. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 13 +

[PATCH v8 11/20] drm/i915/psr: Inform Panel Replay source support on eDP as well

2024-06-13 Thread Jouni Högander
Display version >= 20 support eDP 1.5. Inform Panel Replay source support on eDP for display version >= 20. Bspec: 68920 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/disp

✓ Fi.CI.BAT: success for drm/i915: PREEMPT_RT related fixups. (rev8)

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev8) URL : https://patchwork.freedesktop.org/series/95463/ State : success == Summary == CI Bug Log - changes from CI_DRM_14932 -> Patchwork_95463v8 Summary --- **SU

[PATCH v8 14/20] drm/i915/psr: 128b/132b Panel Replay is not supported on eDP

2024-06-13 Thread Jouni Högander
Take into account that 128b/132b Panel Replay is not supported on eDP. Bspec: 68920 v2: - make crtc_state as const - add debug message to print out why Panel Replay is not possible Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 21 +++-- 1 file

[PATCH v8 17/20] drm/i915/psr: Perform psr2 checks related to ALPM for Panel Replay

2024-06-13 Thread Jouni Högander
eDP1.5 support ALPM with Panel Replay as well. We need to check ALPM related things for Panel Replay as well. Bspec: 68920 v5: - instead of using crtc_state->has_panel_replay provide aux_less flag v4: - do not move _compute_psr2_sdp_prior_scanline_indication - move ALPM related checks to se

[PATCH v8 20/20] drm/i915/psr: Modify dg2_activate_panel_replay to support eDP

2024-06-13 Thread Jouni Högander
There are couple of bits in PSR2_CTL which needs to be written in case of eDP Panel Replay Bspec: 68920 v2: use boolean instead of assuming eDP Panel Replay mean Early Transport Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 13 + 1 file changed, 13 in

[PATCH v8 08/20] drm/i915/psr: Add new debug bit to disable Panel Replay

2024-06-13 Thread Jouni Högander
Add new debug bit to be used with i915_edp_psr_debug debugfs interface. This can be used to disable Panel Replay. v2: ensure that fastset is performed when the bit changes Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/i

✓ Fi.CI.BAT: success for Panel Replay eDP support (rev9)

2024-06-13 Thread Patchwork
== Series Details == Series: Panel Replay eDP support (rev9) URL : https://patchwork.freedesktop.org/series/133684/ State : success == Summary == CI Bug Log - changes from CI_DRM_14932 -> Patchwork_133684v9 Summary --- **SUCCESS**

✓ Fi.CI.BAT: success for drm/i915: gvt register macro cleanups, unused macro removals (rev3)

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915: gvt register macro cleanups, unused macro removals (rev3) URL : https://patchwork.freedesktop.org/series/134600/ State : success == Summary == CI Bug Log - changes from CI_DRM_14932 -> Patchwork_134600v3 ===

✓ Fi.CI.BAT: success for CMRR patch fixes

2024-06-13 Thread Patchwork
== Series Details == Series: CMRR patch fixes URL : https://patchwork.freedesktop.org/series/134801/ State : success == Summary == CI Bug Log - changes from CI_DRM_14932 -> Patchwork_134801v1 Summary --- **SUCCESS** No regressions

[PULL] drm-xe-fixes

2024-06-13 Thread Thomas Hellstrom
Hi Dave & Sima, This week's drm-xe-fixes PR. Except from the maintainer update, nothing major, really. The "drm/xe: move disable_c6 call" required some conflict resolution (both visible and silent) which was also reflected in a conflict with drm-next when building drm-tip. drm-xe-fixes-2024-06-1

✗ Fi.CI.SPARSE: warning for drm/i915: PREEMPT_RT related fixups. (rev8)

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev8) URL : https://patchwork.freedesktop.org/series/95463/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: PREEMPT_RT related fixups. (rev8)

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev8) URL : https://patchwork.freedesktop.org/series/95463/ State : warning == Summary == Error: dim checkpatch failed 11fc90acc6d0 drm/i915: Use preempt_disable/enable_rt() where recommended -:7: WARNING:COMMIT_LOG_LONG_LINE:

Re: [PATCH v2 4/9] drm/i915: Introduce fb->min_alignment

2024-06-13 Thread Imre Deak
On Wed, Jun 12, 2024 at 11:47:07PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Different planes could have different alignment requirements > even for the same format/modifier. Collect the alignment > requirements across all planes capable of scanning out the > fb such that the alignmen

[PATCH v2 8/8] Revert "drm/i915: Depend on !PREEMPT_RT."

2024-06-13 Thread Sebastian Andrzej Siewior
Once the known issues are addressed, it should be safe to enable the driver. Signed-off-by: Sebastian Andrzej Siewior --- drivers/gpu/drm/i915/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 5932024f8f954..a02162d6b710e

[PATCH v2 2/8] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates

2024-06-13 Thread Sebastian Andrzej Siewior
From: Mike Galbraith Commit 8d7849db3eab7 ("drm/i915: Make sprite updates atomic") started disabling interrupts across atomic updates. This breaks on PREEMPT_RT because within this section the code attempt to acquire spinlock_t locks which are sleeping locks on PREEMPT_RT. According to the c

[PATCH v2 5/8] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()

2024-06-13 Thread Sebastian Andrzej Siewior
execlists_dequeue() is invoked from a function which uses local_irq_disable() to disable interrupts so the spin_lock() behaves like spin_lock_irq(). This breaks PREEMPT_RT because local_irq_disable() + spin_lock() is not the same as spin_lock_irq(). execlists_dequeue_irq() and execlists_dequeue()

[PATCH v2 1/8] drm/i915: Use preempt_disable/enable_rt() where recommended

2024-06-13 Thread Sebastian Andrzej Siewior
From: Mike Galbraith Mario Kleiner suggest in commit ad3543ede630f ("drm/intel: Push get_scanout_position() timestamping into kms driver.") a spots where preemption should be disabled on PREEMPT_RT. The difference is that on PREEMPT_RT the intel_uncore::lock disables neither preemption nor in

[PATCH v2 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT

2024-06-13 Thread Sebastian Andrzej Siewior
The !in_atomic() check in _wait_for_atomic() triggers on PREEMPT_RT because the uncore::lock is a spinlock_t and does not disable preemption or interrupts. Changing the uncore:lock to a raw_spinlock_t doubles the worst case latency on an otherwise idle testbox during testing. Therefore I'm current

✗ Fi.CI.SPARSE: warning for Panel Replay eDP support (rev9)

2024-06-13 Thread Patchwork
== Series Details == Series: Panel Replay eDP support (rev9) URL : https://patchwork.freedesktop.org/series/133684/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: war

Re: [PATCH] drm/i915/dp_mst: Fix DSC input BPP computation

2024-06-13 Thread Imre Deak
On Thu, Jun 13, 2024 at 01:25:59AM +0300, Luca Coelho wrote: > On Wed, 2024-06-12 at 18:22 +0300, Imre Deak wrote: > > On Wed, Jun 12, 2024 at 04:35:36PM +0300, Luca Coelho wrote: > > > Hi Imre, > > > > > > On Tue, 2024-06-11 at 18:33 +0300, Imre Deak wrote: > > > > The branch or sink device decom

[PATCH v8 19/20] drm/i915/psr: Check Early Transport for Panel Replay as well

2024-06-13 Thread Jouni Högander
Move Early Transport validity check to be performed for Panel Replay as well and use Early Transport for eDP Panel Replay always. v2:set crtc_state->enable_psr2_su_region_et directly (not in if block) Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 6 +++--- 1 file

[PATCH v8 13/20] drm/i915/psr: Check panel Early Transport capability for eDP PR

2024-06-13 Thread Jouni Högander
Our HW doesn't support panel replay without Early Transport on eDP. Bspec: 68920 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/

[PATCH v8 10/20] drm/i915/psr: Check panel ALPM capability for eDP Panel Replay

2024-06-13 Thread Jouni Högander
Our HW doesn't support Panel Replay without AUX_LESS ALPM on eDP. Check panel support for this and prevent eDP panel replay if it doesn't exits. Bspec: 68920 v2: use intel_alpm_aux_less_wake_supported Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 7 +++ 1 fil

[PATCH v8 04/20] drm/i915/psr: Add Panel Replay compute_config helper

2024-06-13 Thread Jouni Högander
We are about to add more checks for Panel Replay. Due to that it makes sense to add now Panel Replay compute config helper. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i

[PATCH v8 03/20] drm/i915/alpm: Fix port clock usage in AUX Less wake time calculation

2024-06-13 Thread Jouni Högander
Port clock is link rate in 10 kbit/s units. Take this into account when calculating AUX Less wake time. Fixes: da6a9836ac09 ("drm/i915/psr: Calculate aux less wake time") Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_alpm.c | 3 ++- 1 file changed, 2 insertions(+), 1 delet

[PATCH v8 02/20] drm/i915/display: Wa 16021440873 is writing wrong register

2024-06-13 Thread Jouni Högander
Wa 16021440873 is writing wrong register. Instead of PIPE_SRCSZ_ERLY_TPT write CURPOS_ERLY_TPT. v2: use right offset as well Fixes: 29cdef8539c3 ("drm/i915/display: Implement Wa_16021440873") Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_cursor.c | 4 ++-- drivers/gpu/dr

[PATCH v8 18/20] drm/i915/psr: Perform scanline indication check for Panel Replay as well

2024-06-13 Thread Jouni Högander
Scanline indication needs to be checked and configure for both PSR2 and Panel Replay Selective Update. Move this check to intel_sel_update_config_valid. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v8 09/20] Revert "drm/i915/psr: Disable early transport by default"

2024-06-13 Thread Jouni Högander
This reverts commit f3c2031db7dfdf470a2d9bf3bd1efa6edfa72d8d. We want to notice possible issues faced with PSR2 Region Early Transport as early as possible -> let's revert patch disabling Region Early Transport by default. Also eDP 1.5 Panel Replay requires Early Transport. Signed-off-by: Jouni H

[PATCH v8 07/20] drm/i915/psr: Disable PSR/Panel Replay on sink side for PSR only

2024-06-13 Thread Jouni Högander
Enabling/disabling Panel Replay on sink side has to be done before link training. We can't disable it in sink side on PSR disable. Fixes: 88ae6c65ecdb ("drm/i915/psr: Unify panel replay enable/disable sink") Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 12 ++--

[PATCH v8 01/20] drm/i915/psr: Set SU area width as pipe src width

2024-06-13 Thread Jouni Högander
Currently SU area width is set as MAX_INT. This is causing problems. Instead set it as pipe src width. Fixes: 86b26b6aeac7 ("drm/i915/psr: Carry su area in crtc_state") Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH v8 00/20] Panel Replay eDP support

2024-06-13 Thread Jouni Högander
This patch set is implementing eDP1.5 Panel Replay for Intel hw. Patch to disable Region Early Transport by default is reverted as it is needed by eDP Panel Replay. v8: - series reordered to ease merging subset - wa 16021440873 modified - Fix port clock usage in AUX Less wake time calculatio

[PATCH v8 15/20] drm/i915/psr: HW will not allow PR on eDP when HDCP enabled

2024-06-13 Thread Jouni Högander
Take into account in Panel Replay compute config that HW will not allow PR on eDP when HDCP enabled. v2: add debug message to print out why Panel Replay is not possible Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 14 ++ 1 file changed, 14 insertions

[PATCH v8 16/20] drm/i915/alpm: Make crtc_state as const in intel_alpm_compute_params

2024-06-13 Thread Jouni Högander
Intel_alpm_compute_params doesn't change crtc_state. Let's convert it as const. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_alpm.c | 9 + drivers/gpu/drm/i915/display/intel_alpm.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/

[PATCH v8 12/20] drm/i915/psr: enable sink for eDP1.5 Panel Replay

2024-06-13 Thread Jouni Högander
eDP1.5 allows Panel Replay on eDP as well. Take this into account when enabling sink PSR/Panel Replay. Write also PANEL_REPLAY_CONFIG2 register accordingly. v3: - set DP_PANEL_REPLAY_CRC_VERIFICATION in PANEL_REPLAY_CONFIG2 - PANEL_REPLAY_CONFIG2 is available in DP2.1 as well v2: do not config

[PATCH v8 05/20] drm/i915/psr: Disable Panel Replay if PSR mode is set via module parameter

2024-06-13 Thread Jouni Högander
If enable_psr module parameter is set as disabled, PSR1 or PSR2: Panel Replay is disabled. Signed-off-by: Jouni Högander --- .../gpu/drm/i915/display/intel_display_params.c | 3 +-- drivers/gpu/drm/i915/display/intel_psr.c | 16 2 files changed, 17 insertions(+), 2 del

✗ Fi.CI.SPARSE: warning for CMRR patch fixes

2024-06-13 Thread Patchwork
== Series Details == Series: CMRR patch fixes URL : https://patchwork.freedesktop.org/series/134801/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915: Polish plane surface alignment handling (rev2)

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915: Polish plane surface alignment handling (rev2) URL : https://patchwork.freedesktop.org/series/133564/ State : success == Summary == CI Bug Log - changes from CI_DRM_14932 -> Patchwork_133564v2 Summary

Re: [PATCH 00/10] drm/i915: PREEMPT_RT related fixups.

2024-06-13 Thread Sebastian Andrzej Siewior
On 2024-06-11 18:25:07 [-0400], Rodrigo Vivi wrote: > > 2/10 is needed for the XE driver since it shares code with i915. > > I believe you meant patch 1 right? > We are trying to eliminate the > #if I915 > for the shared display code with Xe... we probably need to think > more deeply about that.

✗ Fi.CI.SPARSE: warning for drm/i915: Polish plane surface alignment handling (rev2)

2024-06-13 Thread Patchwork
== Series Details == Series: drm/i915: Polish plane surface alignment handling (rev2) URL : https://patchwork.freedesktop.org/series/133564/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PULL] drm-misc-next

2024-06-13 Thread Maxime Ripard
Hi, Here's this week drm-misc-next PR Maxime drm-misc-next-2024-06-13: drm-misc-next for 6.11: UAPI Changes: Cross-subsystem Changes: Core Changes: - Sprinkle MODULE_DESCRIPTIONS everywhere they are missing - bridge: Remove drm_bridge_chain_mode_fixup - ci: Require a more recent version of

[drm-intel:for-linux-next-gt 3/3] drivers/gpu/drm/i915/gem/i915_gem_stolen.c:941:33: warning: format '%lli' expects argument of type 'long long int', but argument 5 has type 'resource_size_t' {aka 'un

2024-06-13 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-gt head: 05da7d9f717bcb03c457379fa8a61c1689dab86c commit: 05da7d9f717bcb03c457379fa8a61c1689dab86c [3/3] drm/i915/gem: Downgrade stolen lmem setup warning config: i386-randconfig-002-20240613 (https://download.01.org/0day-ci

[drm-intel:for-linux-next-gt 3/3] drivers/gpu/drm/i915/gem/i915_gem_stolen.c:942:5: warning: format specifies type 'long long' but the argument has type 'resource_size_t' (aka 'unsigned int')

2024-06-13 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-gt head: 05da7d9f717bcb03c457379fa8a61c1689dab86c commit: 05da7d9f717bcb03c457379fa8a61c1689dab86c [3/3] drm/i915/gem: Downgrade stolen lmem setup warning config: i386-buildonly-randconfig-002-20240613 (https://download.01.org/0day