PORT_ALPM_* registers are using MMIO_TRANS2 macro. This is not correct as
they are port register. Use _PORT_MMIO instead.
Fixes: 4ee30a448255 ("drm/i915/alpm: Add ALPM register definitions")
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_alpm.c | 5 +++--
Enabling/disabling Panel Replay on sink side has to be done before link
training. We can't disable it in sink side on PSR disable.
Fixes: 88ae6c65ecdb ("drm/i915/psr: Unify panel replay enable/disable sink")
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
Port clock is link rate in 10 kbit/s units. Take this into account when
calculating AUX Less wake time.
Fixes: da6a9836ac09 ("drm/i915/psr: Calculate aux less wake time")
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_alpm.c | 3 ++-
1 file
This reverts commit f3c2031db7dfdf470a2d9bf3bd1efa6edfa72d8d.
We want to notice possible issues faced with PSR2 Region Early Transport as
early as possible -> let's revert patch disabling Region Early Transport by
default. Also eDP 1.5 Panel Replay requires Early Transport.
Signed-off-by: Jouni
Wa 16021440873 is writing wrong register. Instead of PIPE_SRCSZ_ERLY_TPT
write CURPOS_ERLY_TPT.
v2: use right offset as well
Fixes: 29cdef8539c3 ("drm/i915/display: Implement Wa_16021440873")
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_cursor.c | 4 ++--
If user is specifically limiting PSR mode to PSR1 or PSR2: disable Panel
Replay. With default value -1 all modes are allowed including Panel
Replay. Disabling PSR using value 0 disables Panel Replay as well.
Also own compute config helper is added for Panel Replay. This makes sense
because number
Currently PSR2 SU Region Early Transport is enabled by default on Lunarlake
if panel supports it despite enable_psr module parameter value. This patch
makes it possible for user to limit used PSR mode and prevent SU Region
Early Transport by setting enable_psr as 2. With default (-1) PSR2 SU
Add new debug bit to be used with i915_edp_psr_debug debugfs
interface. This can be used to disable Panel Replay.
v2: ensure that fastset is performed when the bit changes
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
This is a subset of "Panel Replay eDP" patch set. It contains various
preparations and fixes for enabling Panel Replay eDP. These are seen
as safe to merge next and they are not yet enabling Panel Replay eDP.
This patch set is also changing how enable_psr module parameter is
used on LunarLake
Currently SU area width is set as MAX_INT. This is causing
problems. Instead set it as pipe src width.
Fixes: 86b26b6aeac7 ("drm/i915/psr: Carry su area in crtc_state")
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
1 file changed, 1 insertion(+), 1
Hi Animesh,
> -Original Message-
> From: Manna, Animesh
> Sent: Monday, June 10, 2024 2:05 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com; Hogander, Jouni
> ; Murthy, Arun R ;
> Golani, Mitulkumar Ajitkumar ;
> Manna, Animesh
> Subject: [PATCH v6]
== Series Details ==
Series: drm: Support per-plane async flip configuration (rev2)
URL : https://patchwork.freedesktop.org/series/134900/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14959 -> Patchwork_134900v2
Summary
== Series Details ==
Series: drm: Support per-plane async flip configuration (rev2)
URL : https://patchwork.freedesktop.org/series/134900/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
amdgpu can handle async flips on overlay planes, so mark it as true
during the plane initialization.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Replace the generic "is this plane primary" for a plane::async_flip
check, so DRM follows the plane restrictions set by the driver.
Signed-off-by: André Almeida
---
drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This driver can perfom async flips on primary planes, so enable it.
Signed-off-by: André Almeida
---
drivers/gpu/drm/vc4/vc4_plane.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
index
This driver can perfom async flips on primary planes, so enable it.
Signed-off-by: André Almeida
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4
drivers/gpu/drm/nouveau/dispnv50/wndw.c | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
This driver can perfom async flips on primary planes, so enable it.
Signed-off-by: André Almeida
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++
drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 +
2 files changed, 4 insertions(+)
diff --git
This driver can perfom async flips on primary planes, so enable it.
Signed-off-by: André Almeida
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
This driver can perfom async flips on primary planes, so enable it.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
Drivers have different capabilities on what plane types they can or
cannot perform async flips. Create a plane::async_flip field so each
driver can choose which planes they allow doing async flips.
Signed-off-by: André Almeida
---
include/drm/drm_plane.h | 5 +
1 file changed, 5
Allow userspace to use explicit synchronization with atomic async flips.
That means that the flip will wait for some hardware fence, and then
will flip as soon as possible (async) in regard of the vblank.
Signed-off-by: André Almeida
---
drivers/gpu/drm/drm_atomic_uapi.c | 4 +++-
1 file
AMD hardware can do async flips with overlay planes, but currently there's no
easy way to enable that in DRM. To solve that, this patchset creates a new
drm_plane field, bool async_flip, that allows drivers to choose which plane can
or cannot do async flips. This is latter used on
On Mon, Jun 17, 2024 at 08:38:20PM GMT, Andi Shyti wrote:
On Mon, Jun 17, 2024 at 10:46:07AM -0500, Lucas De Marchi wrote:
On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote:
> On Mon, Jun 17, 2024 at 07:55:10AM -0500, Lucas De Marchi wrote:
> > On Sun, Jun 16, 2024 at 09:03:48AM GMT,
== Series Details ==
Series: drm/i915/gem: Return SIGBUS for wrong mapping parameters (rev2)
URL : https://patchwork.freedesktop.org/series/134953/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14958 -> Patchwork_134953v2
== Series Details ==
Series: Sparse errors on the i915_gem_stolen (rev2)
URL : https://patchwork.freedesktop.org/series/134930/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14957 -> Patchwork_134930v2
Summary
---
On Wed, Jun 12, 2024 at 02:12:39PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm-intel tree, today's linux-next build (i386
> defconfig) failed like this:
>
> x86_64-linux-gnu-ld: drivers/gpu/drm/i915/display/intel_vrr.o: in function
> `intel_vrr_compute_config':
>
== Series Details ==
Series: drm/i915/gt: Fix potential UAF by revoke of fence registers (rev5)
URL : https://patchwork.freedesktop.org/series/134411/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14957 -> Patchwork_134411v5
== Series Details ==
Series: drm/i915/gt: Fix potential UAF by revoke of fence registers (rev5)
URL : https://patchwork.freedesktop.org/series/134411/
State : warning
== Summary ==
Error: dim checkpatch failed
9da43f43b292 drm/i915/gt: Fix potential UAF by revoke of fence registers
-:9:
Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup
warning") adds a debug message where the "lmem_size" and
"dsm_base" variables are printed using the %lli identifier.
However, these variables are defined as resource_size_t, which
are unsigned long for 32-bit machines and unsigned
Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup
warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's
supposed to return a pointer to the intel_memory_region
structure.
Sparse complains with the following message:
>> drivers/gpu/drm/i915/gem/i915_gem_stolen.c:943:32:
Hi Jonathan,
Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup
warning") produces two sparse warnings. The first one being a bit
more sever as it might cause a segmentation fault.
The difference between v1 and v2 is that the patch should return
a NULL, which won't cause any issues.
On Mon, Jun 17, 2024 at 10:46:07AM -0500, Lucas De Marchi wrote:
> On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote:
> > On Mon, Jun 17, 2024 at 07:55:10AM -0500, Lucas De Marchi wrote:
> > > On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote:
> > > > Commit 05da7d9f717b
== Series Details ==
Series: series starting with [1/3] drm/i915: Move encoder suspend/shutdown
helpers to intel_encoder.c
URL : https://patchwork.freedesktop.org/series/134966/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14957 -> Patchwork_134966v1
On Mon, Jun 17, 2024 at 08:54:13PM +0300, Imre Deak wrote:
> On Mon, Jun 17, 2024 at 01:44:06PM -0400, Rodrigo Vivi wrote:
> > On Mon, Jun 17, 2024 at 08:03:56PM +0300, Imre Deak wrote:
> > > Use the suspend encoders helper which is also used by the i915 driver.
> > > This fixes an issue in the xe
== Series Details ==
Series: series starting with [1/3] drm/i915: Move encoder suspend/shutdown
helpers to intel_encoder.c
URL : https://patchwork.freedesktop.org/series/134966/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be
== Series Details ==
Series: series starting with [1/3] drm/i915: Move encoder suspend/shutdown
helpers to intel_encoder.c
URL : https://patchwork.freedesktop.org/series/134966/
State : warning
== Summary ==
Error: dim checkpatch failed
f56120af9380 drm/i915: Move encoder suspend/shutdown
On Mon, Jun 17, 2024 at 01:44:06PM -0400, Rodrigo Vivi wrote:
> On Mon, Jun 17, 2024 at 08:03:56PM +0300, Imre Deak wrote:
> > Use the suspend encoders helper which is also used by the i915 driver.
> > This fixes an issue in the xe driver where the encoder
> > suspend_complete() hook is not called
On Mon, Jun 17, 2024 at 08:03:56PM +0300, Imre Deak wrote:
> Use the suspend encoders helper which is also used by the i915 driver.
> This fixes an issue in the xe driver where the encoder
> suspend_complete() hook is not called and was an overlook when this hook
> was added in
I believe it is
On Mon, Jun 17, 2024 at 08:03:55PM +0300, Imre Deak wrote:
> Pass intel_display to the encoder suspend/shutdown helpers instead of
> drm_i915_private for better isolation. This assumes that HAS_DISPLAY()
> will also take an intel_display parameter in the future (or that the
> HAS_DISPLAY() check
On Mon, Jun 17, 2024 at 08:03:54PM +0300, Imre Deak wrote:
> Move the encoder suspend/shutdown helpers to intel_encoder.c, this being
> the logical place for encoder functions.
>
> This also allows sharing the above helpers with the xe driver, done in a
> follow-up patch.
>
> While at it rename
Use the suspend encoders helper which is also used by the i915 driver.
This fixes an issue in the xe driver where the encoder
suspend_complete() hook is not called and was an overlook when this hook
was added in
Commit b61fad5f7e5d ("drm/i915/tc: Call TypeC port flush_work/cleanup without
Move the encoder suspend/shutdown helpers to intel_encoder.c, this being
the logical place for encoder functions.
This also allows sharing the above helpers with the xe driver, done in a
follow-up patch.
While at it rename the functions using the usual intel_encoder prefix
and in the functions
Pass intel_display to the encoder suspend/shutdown helpers instead of
drm_i915_private for better isolation. This assumes that HAS_DISPLAY()
will also take an intel_display parameter in the future (or that the
HAS_DISPLAY() check will be moved to a caller of these functions).
Signed-off-by: Imre
On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote:
On Mon, Jun 17, 2024 at 07:55:10AM -0500, Lucas De Marchi wrote:
On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote:
> Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup
> warning") returns '0' from
== Series Details ==
Series: drm/i915/gt: Fix potential UAF by revoke of fence registers (rev4)
URL : https://patchwork.freedesktop.org/series/134411/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14955 -> Patchwork_134411v4
== Series Details ==
Series: drm/i915/gt: Fix potential UAF by revoke of fence registers (rev4)
URL : https://patchwork.freedesktop.org/series/134411/
State : warning
== Summary ==
Error: dim checkpatch failed
7cd708052a40 drm/i915/gt: Fix potential UAF by revoke of fence registers
-:9:
On Mon, 17 Jun 2024, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: make struct intel_frontbuffer opaque
> URL : https://patchwork.freedesktop.org/series/134957/
> State : failure
>
> == Summary ==
>
> Error: make failed
> CALLscripts/checksyscalls.sh
> DESCEND objtool
>
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev10)
URL : https://patchwork.freedesktop.org/series/95463/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14955 -> Patchwork_95463v10
Summary
---
== Series Details ==
Series: drm/i915: make struct intel_frontbuffer opaque
URL : https://patchwork.freedesktop.org/series/134957/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC [M]
On Wed, Jun 12, 2024 at 11:47:05PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Export drm_plane_has_format() so that drivers can use it.
>
> Reviewed-by: Jani Nikula
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/drm_crtc_internal.h | 2 --
> drivers/gpu/drm/drm_plane.c
On Mon, Jun 17, 2024 at 07:55:10AM -0500, Lucas De Marchi wrote:
> On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote:
> > Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup
> > warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's
> > supposed to return a pointer to
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev10)
URL : https://patchwork.freedesktop.org/series/95463/
State : warning
== Summary ==
Error: dim checkpatch failed
1d7b86cf3890 drm/i915: Use preempt_disable/enable_rt() where recommended
-:7:
Hide struct intel_frontbuffer implementation details within
intel_frontbuffer.c.
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_frontbuffer.c | 10 ++
.../gpu/drm/i915/display/intel_frontbuffer.h | 18 --
2 files changed, 14 insertions(+), 14
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev10)
URL : https://patchwork.freedesktop.org/series/95463/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Add accessor to frontbuffer ->write to avoid direct access from outside
of intel_frontbuffer.c in preparation for making struct
intel_frontbuffer opaque.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_frontbuffer.c | 5 +
drivers/gpu/drm/i915/display/intel_frontbuffer.h |
Add _raw accessors for front->ref to avoid direct access from outside of
intel_frontbuffer.c, in preparation for making struct intel_frontbuffer
opaque.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_frontbuffer.c | 10 ++
Add helpers for ->bits in preparation for making struct
intel_frontbuffer opaque.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_fb.c| 2 +-
drivers/gpu/drm/i915/display/intel_frontbuffer.c | 10 ++
drivers/gpu/drm/i915/display/intel_frontbuffer.h |
Move frontbuffer bits read and check from intel_frontbuffer.h inline
functions to intel_frontbuffer.c, in preparation for making struct
intel_frontbuffer opaque.
Rename __intel_fb_* to __intel_frontbuffer_* while at it, because fb
sounds like framebuffer more than frontbuffer.
Signed-off-by:
Hide the struct intel_frontbuffer implementation to add more clarity in
the interface boundaries.
Jani Nikula (5):
drm/i915/frontbuffer: un-inline frontbuffer bits checks
drm/i915/frontbuffer: hide ->bits more
drm/i915/frontbuffer: add low-level kref accessors
drm/i915/frontbuffer: hide
== Series Details ==
Series: drm/i915/gem: Return SIGBUS for wrong mapping parameters
URL : https://patchwork.freedesktop.org/series/134953/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14955 -> Patchwork_134953v1
Summary
Hi
Am 14.06.24 um 16:33 schrieb Christian König:
Am 14.06.24 um 15:21 schrieb Thomas Zimmermann:
Add offset and size parameters to ttm_bo_vmap() to allow for partial
mappings of a buffer object. This brings the functionality on par with
ttm_bo_kmap().
Well the long term plan was to remove
Hi,
Am 17.06.24 um 14:32 schrieb Thomas Zimmermann:
Hi
Am 14.06.24 um 16:31 schrieb Christian König:
Am 14.06.24 um 15:21 schrieb Thomas Zimmermann:
For each instances of struct iosys_map set up by ttm_bo_vmap(), store
the type of allocation in the instance. Use this information to unmap
the
On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote:
Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup
warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's
supposed to return a pointer to the intel_memory_region
structure.
Sparse complains with the following
We normally issue a warning when incorrect memory parameters are
provided. Typically, providing erroneous addresses to mmap,
results in a segmentation fault, and the default behavior
is to return VM_FAULT_SIGBUS.
This can happen for example when remap_io_mapping() or
remap_io_sg() return -EINVAL.
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev9)
URL : https://patchwork.freedesktop.org/series/95463/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14955 -> Patchwork_95463v9
Summary
---
Hi
Am 14.06.24 um 16:31 schrieb Christian König:
Am 14.06.24 um 15:21 schrieb Thomas Zimmermann:
For each instances of struct iosys_map set up by ttm_bo_vmap(), store
the type of allocation in the instance. Use this information to unmap
the memory in ttm_bo_vunmap(). This change simplifies the
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev9)
URL : https://patchwork.freedesktop.org/series/95463/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev9)
URL : https://patchwork.freedesktop.org/series/95463/
State : warning
== Summary ==
Error: dim checkpatch failed
06fbc03ec8cc drm/i915: Use preempt_disable/enable_rt() where recommended
-:7: WARNING:COMMIT_LOG_LONG_LINE:
Hi!
> > Let's bring in the actual gpu people.. Dave/Jani/others - does any of
> > this sound familiar? Pavel says things have gotten much slower in
> > 6.10: "something was very wrong with the performance, likely to do
> > with graphics"
>
> Actually, maybe it's not graphics at all. Rafael just
On Fri, 14 Jun 2024, Ville Syrjälä wrote:
> On Fri, Jun 14, 2024 at 05:23:11PM +0300, Jani Nikula wrote:
>> It's not possible to use the joiner at the same time with eDP MSO. When
>> a panel needs MSO, it's not optional, so MSO trumps joiner.
>>
>> v3: Only change intel_dp_has_joiner(), leave
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-gt
head: ae45f07cade1a5853ff6fd745bbd86a64cc82643
commit: 05da7d9f717bcb03c457379fa8a61c1689dab86c [3/5] drm/i915/gem: Downgrade
stolen lmem setup warning
config: i386-randconfig-053-20240617
(https://download.01.org/0day-ci
72 matches
Mail list logo