== Series Details ==
Series: Panel Replay eDP support (rev10)
URL : https://patchwork.freedesktop.org/series/133684/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:116:1: wa
There are couple of bits in PSR2_CTL which needs to be written in case of
eDP Panel Replay
Bspec: 68920
v2: use boolean instead of assuming eDP Panel Replay mean Early Transport
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 13 +
1 file changed, 13 in
eDP1.5 support ALPM with Panel Replay as well. We need to check ALPM
related things for Panel Replay as well.
Bspec: 68920
v5:
- instead of using crtc_state->has_panel_replay provide aux_less flag
v4:
- do not move _compute_psr2_sdp_prior_scanline_indication
- move ALPM related checks to se
Scanline indication needs to be checked and configure for both PSR2 and
Panel Replay Selective Update. Move this check to
intel_sel_update_config_valid.
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Take into account in Panel Replay compute config that HW will not allow PR
on eDP when HDCP enabled.
v2: add debug message to print out why Panel Replay is not possible
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 14 ++
1 file changed, 14 insertions
Move Early Transport validity check to be performed for Panel Replay as
well and use Early Transport for eDP Panel Replay always.
v2:set crtc_state->enable_psr2_su_region_et directly (not in if block)
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 6 +++---
1 file
Take into account that 128b/132b Panel Replay is not supported on eDP.
Bspec: 68920
v2:
- make crtc_state as const
- add debug message to print out why Panel Replay is not possible
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 21 +++--
1 file
Intel_alpm_compute_params doesn't change crtc_state. Let's convert it as
const.
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_alpm.c | 9 +
drivers/gpu/drm/i915/display/intel_alpm.h | 2 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/
Our HW doesn't support panel replay without Early Transport on eDP.
Bspec: 68920
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
b/drivers/
eDP1.5 allows Panel Replay on eDP as well. Take this into account when
enabling sink PSR/Panel Replay. Write also PANEL_REPLAY_CONFIG2 register
accordingly.
v3:
- set DP_PANEL_REPLAY_CRC_VERIFICATION in PANEL_REPLAY_CONFIG2
- PANEL_REPLAY_CONFIG2 is available in DP2.1 as well
v2: do not config
Display version >= 20 support eDP 1.5. Inform Panel Replay source support
on eDP for display version >= 20.
Bspec: 68920
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/disp
This patch set is implementing eDP1.5 Panel Replay for Intel hw and
enabling it on LunarLake HW when eDP1.5 panel is available. Patches
are tested using two differenet eDP1.5 panel models. IGT modifications
for testing are under review and available here:
https://patchwork.freedesktop.org/series/1
Our HW doesn't support Panel Replay without AUX_LESS ALPM on eDP. Check
panel support for this and prevent eDP panel replay if it doesn't exits.
Bspec: 68920
v2: use intel_alpm_aux_less_wake_supported
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 7 +++
1 fil
== Series Details ==
Series: Implement WA to fix increased power usage (rev2)
URL : https://patchwork.freedesktop.org/series/134541/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14966 -> Patchwork_134541v2
Summary
---
On Tue, 2024-06-18 at 08:30 +0300, Jouni Högander wrote:
> This is a subset of "Panel Replay eDP" patch set. It contains various
> preparations and fixes for enabling Panel Replay eDP. These are seen
> as safe to merge next and they are not yet enabling Panel Replay eDP.
>
> This patch set is also
To reach PC10 when PKG_C_LATENCY is configure we must do the following
things
1) Enter PSR1 only when delayed_vblank < 6 lines and DC5 can be entered
2) Allow PSR2 deep sleep when DC5 can be entered
3) DC5 can be entered when all transocoder have either PSR1, PSR2 or
eDP 1.5 PR ALPM enabled and VBI
Convert hsw_activate_psr1 from void to bool as going forward
there is a chance psr1 is not enabled.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_psr.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
b/d
When DPKGC is enabled we see an increase in power consumption for
PSR1: When gap between vblank and delayed vblank is >= 6
PSR2: When deep sleep is enabled.
WA adds condition to avoid the above conditions
WA: 16023497226
Signed-off-by: Suraj Kandpal
Suraj Kandpal (2):
drm/i915/psr: Add return
Hi Jani,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-intel/for-linux-next-fixes drm-tip/drm-tip
drm-xe/drm-xe-next linus/master v6.10-rc4 next-20240618]
[If your patch is applied to the wrong git tree
Em 18/06/2024 14:43, Dmitry Baryshkov escreveu:
On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote:
Em 18/06/2024 07:07, Dmitry Baryshkov escreveu:
On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote:
On Tue, 18 Jun 2024, André Almeida wrote:
Drivers have different capabilities on wha
On Fri, Jun 14, 2024 at 03:53:04PM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 14, 2024 at 09:55:57AM +0530, Mitul Golani wrote:
> > Describe newly added parameter target_rr_divider in struct
> > drm_dp_as_sdp.
> >
> > -v2:
> > Remove extra line from commit message.(Lucas)
> >
> > Fixes: a20c6d954d7
-Original Message-
From: Andi Shyti
Sent: Monday, June 17, 2024 11:43 AM
To: intel-gfx ; dri-devel
Cc: Andi Shyti ; Cavitt, Jonathan
; De Marchi, Lucas
Subject: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen
>
> Hi Jonathan,
>
> Commit 05da7d9f717b ("drm/i915/gem: Downgrade sto
On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote:
> Em 18/06/2024 07:07, Dmitry Baryshkov escreveu:
> > On Tue, 18 Jun 2024 at 12:38, Jani Nikula
> > wrote:
> > >
> > > On Tue, 18 Jun 2024, André Almeida wrote:
> > > > Drivers have different capabilities on what plane types they can
> -Original Message-
> From: Nautiyal, Ankit K
> Sent: Monday, June 3, 2024 6:33 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani,
> Mitulkumar Ajitkumar
> Subject: [PATCH 1/5] drm/i915/dp: fix the Adaptive sync Operation
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev11)
URL : https://patchwork.freedesktop.org/series/95463/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14962 -> Patchwork_95463v11
Summary
---
**
Em 18/06/2024 07:07, Dmitry Baryshkov escreveu:
On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote:
On Tue, 18 Jun 2024, André Almeida wrote:
Drivers have different capabilities on what plane types they can or
cannot perform async flips. Create a plane::async_flip field so each
driver can choos
== Series Details ==
Series: drm/i915/display: platform identification with display->is.
URL : https://patchwork.freedesktop.org/series/135016/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14963 -> Patchwork_135016v1
Summa
== Series Details ==
Series: drm/i915/display: platform identification with display->is.
URL : https://patchwork.freedesktop.org/series/135016/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/display: platform identification with display->is.
URL : https://patchwork.freedesktop.org/series/135016/
State : warning
== Summary ==
Error: dim checkpatch failed
818c210ecfa9 drm/i915/display: use a macro to initialize subplatforms
a05b0a6226d3 drm/i915
The display platform enums are not really needed for anything. Remove.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_device.c | 12 +++-
drivers/gpu/drm/i915/display/intel_display_device.h | 11 ---
2 files changed, 3 insertions(+), 20 deletions(-)
di
Facilitate using display->is.HASWELL etc. for identifying platforms and
subplatforms. Merge platform and subplatform members together.
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_display_core.h | 3 +++
.../drm/i915/display/intel_display_device.c | 19 +++
2
Add a structure with a bitfield member for each platform and
subplatform, and initialize them in platform and subplatform descs.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_device.c | 8 ++--
drivers/gpu/drm/i915/display/intel_display_device.h | 8
2 fi
We'll want to use the subplatforms similar to platforms.
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_device.c | 2 +-
.../drm/i915/display/intel_display_device.h | 51 +--
2 files changed, 25 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/
We'll be needing a macro based list of platforms for more things in the
future. Start by defining the platform enumerations with it.
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_device.h | 115 ++
1 file changed, 61 insertions(+), 54 deletions(-)
diff --gi
Make it easier to change the underlying structures by using a macro
similar to PLATFORM() for initialization.
The subplatform names in debug logs change slightly as they now reflect
the enum rather than manually entered names. For example, RAPTORLAKE_S
rather than RPL-S.
Signed-off-by: Jani Nikul
Long story short, we'll need to identify platforms in display code using
some other way than i915 core IS_() macros if we ever want to
make a strict separation between the display and non-display parts.
I tossed some ideas around (see the bottom of this mail), Lucas liked
something similar to what
Hi CI team,
could you check the failure below, it looks unrelated:
On Tue, Jun 18, 2024 at 01:30:14PM +, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [v2,1/3] drm/i915: Move encoder suspend/shutdown
> helpers to intel_encoder.c
> URL : https://patchwork.freedes
On Tue, 18 Jun 2024, Imre Deak wrote:
> Use the suspend encoders helper which is also used by the i915 driver.
> This fixes an issue in the xe driver where the encoder
> suspend_complete() hook is not called and was an overlook when this hook
> was added in commit b61fad5f7e5d ("drm/i915/tc: Call
On Tue, 18 Jun 2024, Imre Deak wrote:
> Pass intel_display to the encoder suspend/shutdown helpers instead of
> drm_i915_private for better isolation.
>
> v2: Pass intel_display to HAS_DISPLAY() as well, update commit log
> accordingly. (Jani)
>
> Cc: Jani Nikula
> Reviewed-by: Rodrigo Vivi
== Series Details ==
Series: series starting with [v2,1/3] drm/i915: Move encoder suspend/shutdown
helpers to intel_encoder.c
URL : https://patchwork.freedesktop.org/series/135014/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14963 -> Patchwork_135014v1
=
> -Original Message-
> From: Hogander, Jouni
> Sent: Tuesday, June 18, 2024 8:30 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Kahola, Mika
> ; Hogander, Jouni
> Subject: [PATCH 2/9] drm/i915/display: Wa 16021440873 is writing wrong
> register
>
> Wa 16021440873 is wri
== Series Details ==
Series: series starting with [v2,1/3] drm/i915: Move encoder suspend/shutdown
helpers to intel_encoder.c
URL : https://patchwork.freedesktop.org/series/135014/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't
On 2024-06-18 10:00:09 [+0100], Tvrtko Ursulin wrote:
> I did a re-test but am not 100% certain yet. CI looks frustratingly noisy at
> the moment.
>
> igt@debugfs_test@read_all_entries appears to be a fluke which is not new.
>
> But igt@gem_exec_parallel@engines@basic from the latest run seem new
Pass intel_display to the encoder suspend/shutdown helpers instead of
drm_i915_private for better isolation.
v2: Pass intel_display to HAS_DISPLAY() as well, update commit log
accordingly. (Jani)
Cc: Jani Nikula
Reviewed-by: Rodrigo Vivi # v1
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i
Use the suspend encoders helper which is also used by the i915 driver.
This fixes an issue in the xe driver where the encoder
suspend_complete() hook is not called and was an overlook when this hook
was added in commit b61fad5f7e5d ("drm/i915/tc: Call TypeC port
flush_work/cleanup without modeset l
Move the encoder suspend/shutdown helpers to intel_encoder.c, this being
the logical place for encoder functions.
This also allows sharing the above helpers with the xe driver, done in a
follow-up patch.
While at it rename the functions using the usual intel_encoder prefix
and in the functions re
== Series Details ==
Series: drm/i915/panelreplay: Panel replay workaround with VRR (rev7)
URL : https://patchwork.freedesktop.org/series/129632/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14963 -> Patchwork_129632v7
Sum
> -Original Message-
> From: Hogander, Jouni
> Sent: Tuesday, June 18, 2024 11:00 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Kahola, Mika
> ; Hogander, Jouni
> Subject: [PATCH 5/9] drm/i915/psr: Disable PSR2 SU Region ET if enable_psr
> module parameter is set
>
>
> -Original Message-
> From: Hogander, Jouni
> Sent: Tuesday, June 18, 2024 11:00 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Kahola, Mika
> ; Hogander, Jouni
> Subject: [PATCH 4/9] drm/i915/psr: Disable Panel Replay if PSR mode is set
> via module parameter
>
> If
> -Original Message-
> From: Hogander, Jouni
> Sent: Tuesday, June 18, 2024 11:00 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Kahola, Mika
> ; Hogander, Jouni
> Subject: [PATCH 9/9] intel_alpm: Fix wrong offset for PORT_ALPM_* registers
>
> PORT_ALPM_* registers are
Panel Replay VSC SDP not getting sent when VRR is enabled
and W1 and W2 are 0. So Program Set Context Latency in
TRANS_SET_CONTEXT_LATENCY register to at least a value of 1.
HSD: 14015406119
v1: Initial version.
v2: Update timings stored in adjusted_mode struct. [Ville]
v3: Add WA in compute_conf
On Tue, Jun 18, 2024 at 12:05:16PM +0300, Jani Nikula wrote:
> On Mon, 17 Jun 2024, Imre Deak wrote:
> > Pass intel_display to the encoder suspend/shutdown helpers instead of
> > drm_i915_private for better isolation. This assumes that HAS_DISPLAY()
> > will also take an intel_display parameter in
On Tue, Jun 18, 2024 at 11:01:18AM +0300, Jani Nikula wrote:
> On Mon, 17 Jun 2024, Imre Deak wrote:
> > Move the encoder suspend/shutdown helpers to intel_encoder.c, this being
> > the logical place for encoder functions.
> >
> > This also allows sharing the above helpers with the xe driver, done
On Tue, 11 Jun 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> More prep work extracted from my upcoming DSB based plane
> programming series.
One nitpick, otherwise
Reviewed-by: Jani Nikula
on the series
>
> Ville Syrjälä (11):
> drm/i915: Extract intel_crtc_arm_vblank_event()
> d
On Tue, 11 Jun 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The future direction will be to mainly use intel_display
> rather than i915 in the display code. Start on that path
> for the DSB code.
Yay! \o/
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_dsb
On Tue, 11 Jun 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> As we extend the use of DSB for critical pipe/plane register
> programming, it'll be nice to have an escape valve at hand,
> in case things go very poorly. To that end, add a i915.enable_dsb
> modparam by which we can force the d
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev11)
URL : https://patchwork.freedesktop.org/series/95463/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev11)
URL : https://patchwork.freedesktop.org/series/95463/
State : warning
== Summary ==
Error: dim checkpatch failed
5177644eee61 drm/i915: Use preempt_disable/enable_rt() where recommended
-:7: WARNING:COMMIT_LOG_LONG_LINE:
> -Original Message-
> From: Hogander, Jouni
> Sent: Tuesday, June 18, 2024 8:30 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Kahola, Mika
> ; Hogander, Jouni
> Subject: [PATCH 1/9] drm/i915/psr: Set SU area width as pipe src width
>
> Currently SU area width is set as
On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote:
>
> On Tue, 18 Jun 2024, André Almeida wrote:
> > Drivers have different capabilities on what plane types they can or
> > cannot perform async flips. Create a plane::async_flip field so each
> > driver can choose which planes they allow doing async
On Tue, 18 Jun 2024, André Almeida wrote:
> Drivers have different capabilities on what plane types they can or
> cannot perform async flips. Create a plane::async_flip field so each
> driver can choose which planes they allow doing async flips.
>
> Signed-off-by: André Almeida
> ---
> include/d
== Series Details ==
Series: drm/i915/gem: Return SIGBUS for wrong mapping parameters (rev2)
URL : https://patchwork.freedesktop.org/series/134953/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14958_full -> Patchwork_134953v2_full
=
On Mon, 10 Jun 2024, Animesh Manna wrote:
> Panel Replay VSC SDP not getting sent when VRR is enabled
> and W1 and W2 are 0. So Program Set Context Latency in
> TRANS_SET_CONTEXT_LATENCY register to at least a value of 1.
>
> HSD: 14015406119
>
> v1: Initial version.
> v2: Update timings stored in
On Mon, 17 Jun 2024, Imre Deak wrote:
> Pass intel_display to the encoder suspend/shutdown helpers instead of
> drm_i915_private for better isolation. This assumes that HAS_DISPLAY()
> will also take an intel_display parameter in the future (or that the
> HAS_DISPLAY() check will be moved to a cal
On 17/06/2024 11:07, Sebastian Andrzej Siewior wrote:
On 2024-06-14 13:19:25 [+0100], Tvrtko Ursulin wrote:
So the question is why do you need to know if the context is atomic?
The only impact is avoiding disabling preemption. Is it that important
to avoid it?
If so would cant_migrate() work?
== Series Details ==
Series: Sparse errors on the i915_gem_stolen (rev2)
URL : https://patchwork.freedesktop.org/series/134930/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14957_full -> Patchwork_134930v2_full
Summary
---
== Series Details ==
Series: drm/i915/gt: Fix potential UAF by revoke of fence registers (rev5)
URL : https://patchwork.freedesktop.org/series/134411/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14957_full -> Patchwork_134411v5_full
==
On Mon, 17 Jun 2024, Imre Deak wrote:
> Move the encoder suspend/shutdown helpers to intel_encoder.c, this being
> the logical place for encoder functions.
>
> This also allows sharing the above helpers with the xe driver, done in a
> follow-up patch.
>
> While at it rename the functions using the
Hi Lucas,
On Mon, Jun 17, 2024 at 05:29:24PM -0500, Lucas De Marchi wrote:
> On Mon, Jun 17, 2024 at 08:38:20PM GMT, Andi Shyti wrote:
> > On Mon, Jun 17, 2024 at 10:46:07AM -0500, Lucas De Marchi wrote:
> > > On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote:
> > > > On Mon, Jun 17, 2024 a
69 matches
Mail list logo
