Re: drm-ci: flaky tests for i915 driver testing

2024-07-11 Thread Vignesh Raman
Hi Maintainers, On 28/05/24 12:07, Vignesh Raman wrote: Hi Maintainers, There are some flaky tests reported for i915 driver testing in drm-ci for the below boards. *) # Board Name: asus-C523NA-A20057-coral # IGT Version: 1.28-g0df7b9b97 # Linux Version: 6.9.0-rc7 # Failure Rate: 50 kms_fb_co

RE: Regression on linux-next (next-20240709)

2024-07-11 Thread Borah, Chaitanya Kumar
[+intel-gfx] Hello Jiangshan, Hope you are doing well. I am Chaitanya from the linux graphics team in Intel. This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository. Since the version next-20240709 [2], we are seeing the following regression during boot up

✓ Fi.CI.IGT: success for drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev4)

2024-07-11 Thread Patchwork
== Series Details == Series: drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev4) URL : https://patchwork.freedesktop.org/series/135901/ State : success == Summary == CI Bug Log - changes from CI_DRM_15064_full -> Patchwork_135901v4_full ===

[PULL] drm-xe-fixes

2024-07-11 Thread Lucas De Marchi
Hi Dave and Sima, First patch has an important impact to userspace, changing the cahcing mode to write-back for system memory on DGFX. In this case we introduce a limitation in the cache selection uapi that is transparent to UMDs. I mean, no change on their side is needed. Coherence is maintaine

Re: [PULL] drm-xe-next-fixes v2

2024-07-11 Thread Rodrigo Vivi
On Thu, Jul 11, 2024 at 02:29:04PM -0700, Jordan Justen wrote: > On 2024-07-11 08:18:18, Rodrigo Vivi wrote: > > Hi Dave and Sima, > > > > This is a v2 of https://lore.kernel.org/intel-xe/zo2so4t32dxqy...@intel.com/ > > > > v2 - Removed Thomas' write-back caching mode patch since Lucas will > >

Re: [PULL] drm-xe-next-fixes v2

2024-07-11 Thread Jordan Justen
On 2024-07-11 08:18:18, Rodrigo Vivi wrote: > Hi Dave and Sima, > > This is a v2 of https://lore.kernel.org/intel-xe/zo2so4t32dxqy...@intel.com/ > > v2 - Removed Thomas' write-back caching mode patch since Lucas will propagete > that through drm-xe-fixes towards 6.10. So we remove the amount of p

Re: ✓ Fi.CI.IGT: success for drm/i915/dp: Fix LTTPR detection (rev2)

2024-07-11 Thread Imre Deak
On Tue, Jul 09, 2024 at 11:12:26AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Fix LTTPR detection (rev2) > URL : https://patchwork.freedesktop.org/series/135711/ > State : success Thanks for the reviews, pushed patches 1-4 to drm-intel-next, patch 5 to drm-misc-next

Re: [PATCH v3] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-11 Thread Rodrigo Vivi
On Thu, Jul 11, 2024 at 04:28:53PM +, Cavitt, Jonathan wrote: > -Original Message- > From: Intel-gfx On Behalf Of Nitin > Gote > Sent: Thursday, July 11, 2024 9:32 AM > To: Wilson, Chris P ; tursu...@ursulin.net; > intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org

Re: [PATCH] drm/xe/fbdev: Limit the usage of stolen for LNL+

2024-07-11 Thread Ville Syrjälä
On Thu, Jul 11, 2024 at 11:31:54AM -0500, Lucas De Marchi wrote: > On Thu, Jul 11, 2024 at 10:43:39AM GMT, Uma Shankar wrote: > >As per recommendation in the workarounds: > >WA_14021987551, Wa_16023588340: > > > >There is an issue with accessing Stolen memory pages due a > >hardware limitation. Lim

✓ Fi.CI.BAT: success for drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev4)

2024-07-11 Thread Patchwork
== Series Details == Series: drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev4) URL : https://patchwork.freedesktop.org/series/135901/ State : success == Summary == CI Bug Log - changes from CI_DRM_15064 -> Patchwork_135901v4 =

Re: [PATCH] drm/xe/fbdev: Limit the usage of stolen for LNL+

2024-07-11 Thread Lucas De Marchi
On Thu, Jul 11, 2024 at 09:37:41AM GMT, Matt Roper wrote: On Thu, Jul 11, 2024 at 10:43:39AM +0530, Uma Shankar wrote: As per recommendation in the workarounds: WA_14021987551, Wa_16023588340: The first one here isn't a valid workaround lineage number, just a per-platform ticket number. I thi

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev4)

2024-07-11 Thread Patchwork
== Series Details == Series: drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev4) URL : https://patchwork.freedesktop.org/series/135901/ State : warning == Summary == Error: dim checkpatch failed ecd6858702b8 drm/i915/gt: Do not consider preemption during execlists

Re: [PATCH] drm/xe/fbdev: Limit the usage of stolen for LNL+

2024-07-11 Thread Matt Roper
On Thu, Jul 11, 2024 at 10:43:39AM +0530, Uma Shankar wrote: > As per recommendation in the workarounds: > WA_14021987551, Wa_16023588340: The first one here isn't a valid workaround lineage number, just a per-platform ticket number. I think you meant Wa_22019338487, which is the lineage number t

Re: [PATCH] drm/xe/fbdev: Limit the usage of stolen for LNL+

2024-07-11 Thread Lucas De Marchi
On Thu, Jul 11, 2024 at 10:43:39AM GMT, Uma Shankar wrote: As per recommendation in the workarounds: WA_14021987551, Wa_16023588340: There is an issue with accessing Stolen memory pages due a hardware limitation. Limit the usage of stolen memory for fbdev for LNL+. Don't use BIOS FB from stolen

RE: [PATCH v3] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-11 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Nitin Gote Sent: Thursday, July 11, 2024 9:32 AM To: Wilson, Chris P ; tursu...@ursulin.net; intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Shyti, Andi ; Das, Nirmoy ; janusz.krzyszto...@linux.intel.com; Gote, Nitin

[PATCH v3] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-11 Thread Nitin Gote
We're seeing a GPU HANG issue on a CHV platform, which was caused by bac24f59f454 ("drm/i915/execlists: Enable coarse preemption boundaries for gen8"). Gen8 platform has only timeslice and doesn't support a preemption mechanism as engines do not have a preemption timer and doesn't send an irq if

[PULL] drm-xe-next-fixes v2

2024-07-11 Thread Rodrigo Vivi
Hi Dave and Sima, This is a v2 of https://lore.kernel.org/intel-xe/zo2so4t32dxqy...@intel.com/ v2 - Removed Thomas' write-back caching mode patch since Lucas will propagete that through drm-xe-fixes towards 6.10. So we remove the amount of patch duplication. Again, it is important to highlight t

XDC 2024: Registration & Call for Proposals now open!

2024-07-11 Thread Mark Filion
Hello! Registration & Call for Proposals are now open for XDC 2024, which will take place at the Concordia University Conference Centre in Montréal, Canada on October 9 to 11. New this year: XDC 2024 will feature two full days dedicated to talks followed by a day dedicated to workshops, meetings

Re: [PATCH v1] drm/ci: uprev IGT

2024-07-11 Thread Helen Koike
On 04/07/2024 06:22, Vignesh Raman wrote: Uprev IGT to the latest version, which includes a fix for the writeback tests issue on MSM devices. Enable debugging for igt-runner to log output such as 'Begin test' and 'End test'. This will help identify which test causes system freeze or hangs. Upd

[PULL] drm-misc-next-fixes

2024-07-11 Thread Maxime Ripard
Hi, Here's this week drm-misc-next-fixes PR Thanks! Maxime drm-misc-next-fixes-2024-07-11: A fix for fbdev on big endian systems, a condition fix for a sharp panel at removal, and a fix for qxl to prevent unpinned buffer access under certain conditions. The following changes since commit 896868e

Re: [PATCH v4 3/6] drm/i915: Make I2C terminology more inclusive

2024-07-11 Thread Andi Shyti
Hi Easwar, On Thu, Jul 11, 2024 at 05:27:31AM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, > fix the terminology for users of I2C_ALGOBIT bitbanging int

Re: [PATCH v2 6/6] drm/i915/dp: Dump the LTTPR PHY descriptors

2024-07-11 Thread Imre Deak
On Thu, Jul 11, 2024 at 03:20:19PM +0530, Nautiyal, Ankit K wrote: > > On 7/9/2024 12:30 AM, Imre Deak wrote: > > Dump the descriptor of the detected LTTPRs in non-transparent mode to > > help the debugging related to LTTPRs easier. > > > > v2: Use drm_dp_dump_lttpr_desc() instead of the driver s

Re: [PATCH v4 6/6] fbdev/viafb: Make I2C terminology more inclusive

2024-07-11 Thread Helge Deller
On 7/11/24 07:27, Easwar Hariharan wrote: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage e

Re: [PATCH v4 5/6] fbdev/smscufx: Make I2C terminology more inclusive

2024-07-11 Thread Helge Deller
On 7/11/24 07:27, Easwar Hariharan wrote: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage e

Re: [PATCH] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-11 Thread Tvrtko Ursulin
On 11/07/2024 06:12, Nitin Gote wrote: We're seeing a GPU HANG issue on a CHV platform, which was caused by bac24f59f454 ("drm/i915/execlists: Enable coarse preemption boundaries for gen8"). Gen8 platform has only timeslice and doesn't support a preemption mechanism as engines do not have a p

[PULL] drm-misc-fixes

2024-07-11 Thread Maarten Lankhorst
Hi Dave, Sima, Few fixes for v6.10. :) Cheers, ~Maarten drm-misc-fixes-2024-07-11: drm-misc-fixes for v6.10: - EDID irq fix for bridge/adv7511. - gma500 null mode fixes. - Cleanup meson binding. The following changes since commit 256abd8e550ce977b728be79a74e1729438b4948: Linux 6.10-rc7 (2024-

Re: [PATCH v2 6/6] drm/i915/dp: Dump the LTTPR PHY descriptors

2024-07-11 Thread Nautiyal, Ankit K
On 7/9/2024 12:30 AM, Imre Deak wrote: Dump the descriptor of the detected LTTPRs in non-transparent mode to help the debugging related to LTTPRs easier. v2: Use drm_dp_dump_lttpr_desc() instead of the driver specific equivalent. Reviewed-by: Ville Syrjälä # v1 Signed-off-by: Imre Deak

Re: [PATCH v2 5/6] drm/dp: Add helper to dump an LTTPR PHY descriptor

2024-07-11 Thread Nautiyal, Ankit K
LGTM Reviewed-by: Ankit Nautiyal On 7/9/2024 12:30 AM, Imre Deak wrote: Add a helper to dump the DPCD descriptor for an LTTPR PHY. This is based on [1] and [2] moving the helper to DRM core as suggested by Ville. [1] https://lore.kernel.org/all/20240703155937.1674856-5-imre.d...@intel.com [2]

Re: [PATCH v2 4/6] drm/i915/dp: Keep cached LTTPR mode up-to-date

2024-07-11 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal On 7/9/2024 12:30 AM, Imre Deak wrote: Nothing depends on the cached LTTPR mode, however for consistency keep it up-to-date with the value programmed to the DPCD register. Reviewed-by: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/displa

Re: [PATCH v2 3/6] drm/i915/dp: Reset cached LTTPR count if number of LTTPRs is unsupported

2024-07-11 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal On 7/9/2024 12:30 AM, Imre Deak wrote: After detection the cached LTTPR count can be checked to determine if LTTPRs in non-transparent mode were detected. Reset the cached LTTPR count if the reported number of LTTPRs is invalid to ensure the above checks work

Re: [PATCH v2 2/6] drm/i915/dp: Don't switch the LTTPR mode on an active link

2024-07-11 Thread Nautiyal, Ankit K
LGTM Reviewed-by: Ankit Nautiyal On 7/9/2024 12:30 AM, Imre Deak wrote: Switching to transparent mode leads to a loss of link synchronization, so prevent doing this on an active link. This happened at least on an Intel N100 system / DELL UD22 dock, the LTTPR residing either on the host or the

Re: [PATCH v2 1/6] drm/i915/dp: Reset intel_dp->link_trained before retraining the link

2024-07-11 Thread Nautiyal, Ankit K
On 7/9/2024 12:30 AM, Imre Deak wrote: Regularly retraining a link during an atomic commit happens with the given pipe/link already disabled and hence intel_dp->link_trained being false. Ensure this also for retraining a DP SST link via direct calls to the link training functions (vs. an actual

✓ Fi.CI.BAT: success for Ultrajoiner basic functionality series (rev5)

2024-07-11 Thread Patchwork
== Series Details == Series: Ultrajoiner basic functionality series (rev5) URL : https://patchwork.freedesktop.org/series/133800/ State : success == Summary == CI Bug Log - changes from CI_DRM_15060 -> Patchwork_133800v5 Summary ---

✗ Fi.CI.CHECKPATCH: warning for Ultrajoiner basic functionality series (rev5)

2024-07-11 Thread Patchwork
== Series Details == Series: Ultrajoiner basic functionality series (rev5) URL : https://patchwork.freedesktop.org/series/133800/ State : warning == Summary == Error: dim checkpatch failed 2d669c201834 drm/i915: Add some essential functionality for joiners -:61: ERROR:OPEN_BRACE: that open bra

✓ Fi.CI.BAT: success for drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev3)

2024-07-11 Thread Patchwork
== Series Details == Series: drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev3) URL : https://patchwork.freedesktop.org/series/135901/ State : success == Summary == CI Bug Log - changes from CI_DRM_15060 -> Patchwork_135901v3 =

✓ Fi.CI.IGT: success for drm/i915: Fix readout degamma_lut mismatch on ilk/snb

2024-07-11 Thread Patchwork
== Series Details == Series: drm/i915: Fix readout degamma_lut mismatch on ilk/snb URL : https://patchwork.freedesktop.org/series/135939/ State : success == Summary == CI Bug Log - changes from CI_DRM_15057_full -> Patchwork_135939v1_full S

[PATCH 5/6] drm/i915: Compute config and mode valid changes for ultrajoiner

2024-07-11 Thread Stanislav Lisovskiy
Implement required changes for mode validation and compute config, to support Ultrajoiner. This also includes required DSC changes and checks. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 5 +- drivers/gpu/drm/i915/display/intel_display.h | 3 +- driv

[PATCH 6/6] drm/i915: Add new abstraction layer to handle pipe order for different joiners

2024-07-11 Thread Stanislav Lisovskiy
Ultrajoiner case requires special treatment where both reverse and staight order iteration doesn't work(for instance disabling case requires order to be: primary master, slaves, secondary master). Lets unify our approach by using not only pipe masks for iterating required pipes based on joiner typ

[PATCH 4/6] drm/i915: Implement hw state readout and checks for ultrajoiner

2024-07-11 Thread Stanislav Lisovskiy
Ultrajoiner mode has some new bits and states to be read out from the hw. Lets make changes accordingly. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 125 ++ .../gpu/drm/i915/display/intel_vdsc_regs.h| 3 + 2 files changed, 100 inse

[PATCH 3/6] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks

2024-07-11 Thread Stanislav Lisovskiy
Adding sanity checks for primary and secondary bigjoiner/uncompressed bitmasks, should make it easier to spot possible issues. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 25 +++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --gi

[PATCH 2/6] drm/i915: Split current joiner hw state readout

2024-07-11 Thread Stanislav Lisovskiy
We need to add a new sanity checks and also do some preparations for adding ultrajoiner hw state readout. Lets first split reading of the uncompressed joiner and bigjoiner bit masks into separate functions. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 65

[PATCH 0/6] Ultrajoiner basic functionality series

2024-07-11 Thread Stanislav Lisovskiy
This patch series attempts to implement basic support for Ultrajoiner functionality. Stanislav Lisovskiy (6): drm/i915: Add some essential functionality for joiners drm/i915: Split current joiner hw state readout drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks

[PATCH 1/6] drm/i915: Add some essential functionality for joiners

2024-07-11 Thread Stanislav Lisovskiy
In most of the cases we now try to avoid mentioning things like "bigjoiner" or "ultrajoiner" trying to unify the API and refer mostly to all this functionality as "joiner". In majority cases that should be way to go. However in some cases we still need to distinguish between bigjoiner primaries and

Re: [PATCH 3/4] drm/i915: Compute config and mode valid changes for ultrajoiner

2024-07-11 Thread Lisovskiy, Stanislav
On Wed, Jul 10, 2024 at 06:58:14PM +0530, Nautiyal, Ankit K wrote: > > On 7/10/2024 2:07 PM, Lisovskiy, Stanislav wrote: > > On Wed, Jul 03, 2024 at 02:21:48PM +0530, Nautiyal, Ankit K wrote: > > > On 6/26/2024 1:48 PM, Stanislav Lisovskiy wrote: > > > > Implement required changes for mode validat

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev3)

2024-07-11 Thread Patchwork
== Series Details == Series: drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8 (rev3) URL : https://patchwork.freedesktop.org/series/135901/ State : warning == Summary == Error: dim checkpatch failed 268d2d1f11e5 drm/i915/gt: Do not consider preemption during execlists

✓ Fi.CI.BAT: success for Make I2C terminology more inclusive for I2C Algobit and consumers (rev5)

2024-07-11 Thread Patchwork
== Series Details == Series: Make I2C terminology more inclusive for I2C Algobit and consumers (rev5) URL : https://patchwork.freedesktop.org/series/131867/ State : success == Summary == CI Bug Log - changes from CI_DRM_15060 -> Patchwork_131867v5 ==

✗ Fi.CI.SPARSE: warning for Make I2C terminology more inclusive for I2C Algobit and consumers (rev5)

2024-07-11 Thread Patchwork
== Series Details == Series: Make I2C terminology more inclusive for I2C Algobit and consumers (rev5) URL : https://patchwork.freedesktop.org/series/131867/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Make I2C terminology more inclusive for I2C Algobit and consumers (rev5)

2024-07-11 Thread Patchwork
== Series Details == Series: Make I2C terminology more inclusive for I2C Algobit and consumers (rev5) URL : https://patchwork.freedesktop.org/series/131867/ State : warning == Summary == Error: dim checkpatch failed 4d3e28cb7aec drm/amdgpu, drm/radeon: Make I2C terminology more inclusive -:6: