Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-18 Thread Raag Jadav
On Wed, Aug 14, 2024 at 02:07:44PM +0530, Nilawar, Badal wrote: > > Hi Andi, > > On 09-08-2024 15:46, Andi Shyti wrote: > > Hi Badal, > > > > > > +static int > > > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > > > +{ > > > > + struct i915_hwmon *hwmon = ddat->hwmon; >

Re: [PATCH 48/86] drm/xlnx: Run DRM default client setup

2024-08-18 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:23:14PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-

Re: [PATCH 36/86] drm/renesas/shmobile: Run DRM default client setup

2024-08-18 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:23:02PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-

Re: [PATCH 34/86] drm/renesas/rcar-du: Run DRM default client setup

2024-08-18 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:23:00PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The rcar-du

Re: [PATCH 04/86] drm: Add client-agnostic setup helper

2024-08-18 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:22:30PM +0200, Thomas Zimmermann wrote: > DRM may support multiple in-kernel clients that run as soon as a DRM > driver has been registered. To select the client(s) in a single place, > introduce drm_client_setup(). > > Drivers that

Re: [PATCH 01/86] drm/fbdev-helper: Move color-mode lookup into 4CC format helper

2024-08-18 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:22:27PM +0200, Thomas Zimmermann wrote: > The color mode specified on the kernel command line gives the user's > preferred color depth and number of bits per pixel. Move the > color-mode-to-format conversion form fbdev helpers into a

Re: [PATCH 25/86] drm/mcde: Run DRM default client setup

2024-08-18 Thread Linus Walleij
On Fri, Aug 16, 2024 at 2:54 PM Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The mcde driver specifies a preferred color mode of 32. As

Re: [PATCH 46/86] drm/tve200: Run DRM default client setup

2024-08-18 Thread Linus Walleij
On Fri, Aug 16, 2024 at 2:54 PM Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Linus Walleij Th