✗ Fi.CI.IGT: failure for drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-19 Thread Patchwork
== Series Details == Series: drm/i915/gt: Continue creating engine sysfs files even after a failure URL : https://patchwork.freedesktop.org/series/137451/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15255_full -> Patchwork_137451v1_full ==

✓ Fi.CI.BAT: success for drm/i915/hwmon: expose fan speed (rev6)

2024-08-19 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: expose fan speed (rev6) URL : https://patchwork.freedesktop.org/series/136036/ State : success == Summary == CI Bug Log - changes from CI_DRM_15263 -> Patchwork_136036v6 Summary --- **SUCC

[PATCH v6] drm/i915/hwmon: expose fan speed

2024-08-19 Thread Raag Jadav
Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1: N/A (max = 43.00 W) energy1: 32.02 k

✓ Fi.CI.BAT: success for drm/i915/display: platform identification with display->is. (rev3)

2024-08-19 Thread Patchwork
== Series Details == Series: drm/i915/display: platform identification with display->is. (rev3) URL : https://patchwork.freedesktop.org/series/135016/ State : success == Summary == CI Bug Log - changes from CI_DRM_15261 -> Patchwork_135016v3 ===

✗ Fi.CI.SPARSE: warning for drm/i915/display: platform identification with display->is. (rev3)

2024-08-19 Thread Patchwork
== Series Details == Series: drm/i915/display: platform identification with display->is. (rev3) URL : https://patchwork.freedesktop.org/series/135016/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: platform identification with display->is. (rev3)

2024-08-19 Thread Patchwork
== Series Details == Series: drm/i915/display: platform identification with display->is. (rev3) URL : https://patchwork.freedesktop.org/series/135016/ State : warning == Summary == Error: dim checkpatch failed 49590e10bdf0 drm/i915/display: use a macro to initialize subplatforms 8be6dec8c79a

[PATCH v3] drm/i915/display: add platforms "is" member to struct intel_display

2024-08-19 Thread Jani Nikula
Facilitate using display->is.HASWELL and display->is.HASWELL_ULT etc. for identifying platforms and subplatforms. Merge platform and subplatform members together. v3: - Fix sanity check on display->is after merging subplatform members v2: - Use bitmap ops - Add some sanity checks with warnings S

[PATCH v2 9/9] drm/i915/bios: use display->is.PLATFORM instead of IS_PLATFORM()

2024-08-19 Thread Jani Nikula
Switch to using the new display->is.PLATFORM members. There are still cases like IS_G4X() which is trivial with macros, but not so with platform members. Ditto for IS_IRONLAKE_M() and IS_IVB_GT1() etc. although not used in this file. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i

[PATCH v2 8/9] drm/i915/display: keep subplatforms next to their platforms

2024-08-19 Thread Jani Nikula
There's no reason to keep subplatforms separated in the members. Update the comment while at it. Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_device.h | 51 ++- 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/display/int

[PATCH v2 7/9] drm/i915/display: consider HSW/BDW ULX to also be ULT

2024-08-19 Thread Jani Nikula
Follow i915 core and IS_HASWELL_ULT()/IS_BROADWELL_ULT() conventions, i.e. "is ULT" also matches ULX platforms. Using multiple SUBPLATFORM() macros, we initialize both ULT and ULX subplatforms, and take the subplatform name from the last (so be careful to keep ULX last). This is *not* an example

[PATCH v2 6/9] drm/i915/display: remove the display platform enum as unnecessary

2024-08-19 Thread Jani Nikula
The display platform enums are not really needed for anything. Remove. Without the enum, PLATFORM_UNINITIALIZED is also no longer needed for keeping the first enum 0. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_device.c | 12 +++- drivers/gpu/drm/i915/displ

[PATCH v2 5/9] drm/i915/display: add platforms "is" member to struct intel_display

2024-08-19 Thread Jani Nikula
Facilitate using display->is.HASWELL and display->is.HASWELL_ULT etc. for identifying platforms and subplatforms. Merge platform and subplatform members together. v2: - Use bitmap ops - Add some sanity checks with warnings Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_display_co

[PATCH v2 4/9] drm/i915/display: add display platforms structure with platform members

2024-08-19 Thread Jani Nikula
Add a structure with a bitfield member for each platform and subplatform, and initialize them in platform and subplatform descs. The structure also contains a bitmap in a union for easier manipulation of the bits. Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_device.c | 8

[PATCH v2 3/9] drm/i915/display: join the platform and subplatform enums

2024-08-19 Thread Jani Nikula
We'll want to use the subplatforms similar to platforms. Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_device.c | 2 +- .../drm/i915/display/intel_display_device.h | 51 +-- 2 files changed, 25 insertions(+), 28 deletions(-) di

[PATCH v2 2/9] drm/i915/display: use a macro to define platform enumerations

2024-08-19 Thread Jani Nikula
We'll be needing a macro based list of platforms for more things in the future. Start by defining the platform enumerations with it. Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_device.h | 115 ++ 1 file changed, 61 insertions(+),

[PATCH v2 1/9] drm/i915/display: use a macro to initialize subplatforms

2024-08-19 Thread Jani Nikula
Make it easier to change the underlying structures by using a macro similar to PLATFORM() for initialization. The subplatform names in debug logs change slightly as they now reflect the enum rather than manually entered names. For example, RAPTORLAKE_S rather than RPL-S. Reviewed-by: Rodrigo Vivi

[PATCH v2 0/9] drm/i915/display: platform identification with display->is.

2024-08-19 Thread Jani Nikula
v2 of [1]. Please read the cover letter there. This addresses review comments and adds a few more commits on top, in particular the last one showcasing the approach. The main question remains, is this what we want? BR, Jani. [1] https://lore.kernel.org/r/cover.1718719962.git.jani.nik...@intel.c

✗ Fi.CI.BAT: failure for video/aperture: match the pci device when calling sysfb_disable() (rev2)

2024-08-19 Thread Patchwork
== Series Details == Series: video/aperture: match the pci device when calling sysfb_disable() (rev2) URL : https://patchwork.freedesktop.org/series/137088/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15261 -> Patchwork_137088v2 ==

Re: [PATCH V2] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Javier Martinez Canillas
Alex Deucher writes: Hello Alex, > In aperture_remove_conflicting_pci_devices(), we currently only > call sysfb_disable() on vga class devices. This leads to the > following problem when the pimary device is not VGA compatible: > > 1. A PCI device with a non-VGA class is the boot display > 2. T

Re: [PATCH V2] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Alex Deucher
I forgot to update the patch title but it should probably be something like: video/aperture: optionally match the device in sysfb_disable() Alex On Mon, Aug 19, 2024 at 1:00 PM Alex Deucher wrote: > > In aperture_remove_conflicting_pci_devices(), we currently only > call sysfb_disable() on vga

Re: [PATCH v2 0/2] Allow partial memory mapping for cpu memory

2024-08-19 Thread Matthew Brost
On Mon, Aug 19, 2024 at 05:16:09PM +0200, Andi Shyti wrote: > Hi Matt, > > On Wed, Aug 14, 2024 at 04:07:02PM +, Matthew Brost wrote: > > On Wed, Aug 14, 2024 at 03:48:32PM +0200, Andi Shyti wrote: > > > I am resending this patch series, not to disregard the previous > > > discussions, but to

[PATCH V2] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Alex Deucher
In aperture_remove_conflicting_pci_devices(), we currently only call sysfb_disable() on vga class devices. This leads to the following problem when the pimary device is not VGA compatible: 1. A PCI device with a non-VGA class is the boot display 2. That device is probed first and it is not a VGA

Re: [PATCH 59/86] drm/solomon: Run DRM default client setup

2024-08-19 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The solomon driver specifies a preferred color mode of 32. As this > is the default if no

Re: [PATCH 58/86] drm/simpledrm: Run DRM default client setup

2024-08-19 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas

Re: [PATCH 57/86] drm/ofdrm: Use DRM default client setup

2024-08-19 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Thomas Zimmermann > Cc: Javier Ma

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-19 Thread Neil Armstrong
On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang ---

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-19 Thread Neil Armstrong
On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang ---

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-19 Thread Andi Shyti
Hi Sima, On Mon, Aug 19, 2024 at 04:17:01PM +0200, Daniel Vetter wrote: > On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote: > > On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote: > > > On Tue, Aug 13, 2024 at 04:09:55PM +0200, Daniel Vetter wrote: > > > > On Tue, Aug 13, 2

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-19 Thread Andi Shyti
Hi Raag, I'm sorry, I missed this mail. On Mon, Aug 19, 2024 at 09:50:13AM +0300, Raag Jadav wrote: > On Wed, Aug 14, 2024 at 02:07:44PM +0530, Nilawar, Badal wrote: > > On 09-08-2024 15:46, Andi Shyti wrote: > > > > > +static int > > > > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *

Re: [PATCH v2 0/2] Allow partial memory mapping for cpu memory

2024-08-19 Thread Andi Shyti
Hi Matt, On Wed, Aug 14, 2024 at 04:07:02PM +, Matthew Brost wrote: > On Wed, Aug 14, 2024 at 03:48:32PM +0200, Andi Shyti wrote: > > I am resending this patch series, not to disregard the previous > > discussions, but to ensure it gets tested with the IGTs that > > Krzysztof has provided. > >

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Thomas Zimmermann
Am 19.08.24 um 10:04 schrieb Thomas Zimmermann: Hi Am 16.08.24 um 22:57 schrieb Alex Deucher: On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann wrote: Hi Am 10.08.24 um 13:44 schrieb kernel test robot: Hi Alex, kernel test robot noticed the following build errors: [auto build test ERRO

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-19 Thread Daniel Vetter
On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote: > On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote: > > On Tue, Aug 13, 2024 at 04:09:55PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote: > > > > On Mon, Aug 12, 2024 at 04:

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Alex and Thomas, > Hi > > Am 16.08.24 um 22:57 schrieb Alex Deucher: >> On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann >> wrote: >>> Hi >>> >>> Am 10.08.24 um 13:44 schrieb kernel test robot: Hi Alex, kernel test robot noticed the following bui

RE: [PATCH] drm/i915/psr: Prevent Panel Replay if CRC calculation is enabled

2024-08-19 Thread Kahola, Mika
> -Original Message- > From: Hogander, Jouni > Sent: Monday, August 19, 2024 12:26 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh ; Kahola, Mika > ; Hogander, Jouni > Subject: [PATCH] drm/i915/psr: Prevent Panel Replay if CRC calculation is > enabled > > Similarly as for

✓ Fi.CI.BAT: success for drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-19 Thread Patchwork
== Series Details == Series: drm/i915/gt: Continue creating engine sysfs files even after a failure URL : https://patchwork.freedesktop.org/series/137451/ State : success == Summary == CI Bug Log - changes from CI_DRM_15255 -> Patchwork_137451v1

[PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-19 Thread Andi Shyti
The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/. The process is straightforward: we loop over the UABI engines and for each one, we: - Create the object. - Create basic files. - If the engine supports timeslicing, create timeslice duration fi

RE: [PATCH v10] drm/i915: WA context support for L3flush

2024-08-19 Thread Gote, Nitin R
Hi Andi, > -Original Message- > From: Andi Shyti > Sent: Wednesday, August 14, 2024 5:05 PM > To: Gote, Nitin R > Cc: intel-gfx@lists.freedesktop.org; Nayana, Venkata Ramana > ; Harrison, John C > ; Wilson, Chris P ; > Upadhyay, Tejas > Subject: Re: [PATCH v10] drm/i915: WA context supp

✓ Fi.CI.BAT: success for drm/i915/psr: Prevent Panel Replay if CRC calculation is enabled

2024-08-19 Thread Patchwork
== Series Details == Series: drm/i915/psr: Prevent Panel Replay if CRC calculation is enabled URL : https://patchwork.freedesktop.org/series/137445/ State : success == Summary == CI Bug Log - changes from CI_DRM_15255 -> Patchwork_137445v1

[PATCH] drm/i915/psr: Prevent Panel Replay if CRC calculation is enabled

2024-08-19 Thread Jouni Högander
Similarly as for PSR2 CRC calculation seems to timeout when Panel Replay is enabled. Fix this by falling back to PSR if CRC calculation is enabled. Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2266 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 6 ++

Re: [68/86] drm/loongson: Run DRM default client setup

2024-08-19 Thread Sui Jingfeng
Hi, On 2024/8/16 20:23, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The loongson driver specifies a preferred color mode of 32. As this is th

Re: [82/86] drm/i915: Move custom hotplug code into separate callback

2024-08-19 Thread Sui Jingfeng
Hi, Thomas I love your patch, yet ... On 2024/8/16 20:23, Thomas Zimmermann wrote: i915's fbdev contains additional code for hotplugging a display that cannot be ported to the common fbdev client. Introduce the callback struct drm_fb_helper.fb_hotplug and implement it for i915. The fbdev help

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Thomas Zimmermann
Hi Am 16.08.24 um 22:57 schrieb Alex Deucher: On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann wrote: Hi Am 10.08.24 um 13:44 schrieb kernel test robot: Hi Alex, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR