[PATCH] drm/i915/gt: Remove const from struct i915_wa list allocation

2025-04-25 Thread Kees Cook
In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.) The assign

✓ i915.CI.Full: success for drm/i915/gsc: mei interrupt top half should be in irq disabled context (rev4)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/gsc: mei interrupt top half should be in irq disabled context (rev4) URL : https://patchwork.freedesktop.org/series/148172/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464_full -> Patchwork_148172v4_full ==

Re: [PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot()

2025-04-25 Thread Peter Xu
On Fri, Apr 25, 2025 at 09:48:50PM +0200, David Hildenbrand wrote: > On 25.04.25 21:31, Peter Xu wrote: > > On Fri, Apr 25, 2025 at 10:17:06AM +0200, David Hildenbrand wrote: > > > ... by factoring it out from track_pfn_remap(). > > > > > > For PMDs/PUDs, actually check the full range, and trigger

✓ i915.CI.BAT: success for drm/i915/slpc: Balance the inc/dec for num_waiters

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Balance the inc/dec for num_waiters URL : https://patchwork.freedesktop.org/series/148299/ State : success == Summary == CI Bug Log - changes from CI_DRM_16465 -> Patchwork_148299v1 Summary --

[PATCH] drm/i915/slpc: Balance the inc/dec for num_waiters

2025-04-25 Thread Vinay Belgaumkar
As seen in some recent failures, SLPC num_waiters value is < 0. This happens because the inc/dec are not balanced. We should skip decrement for the same conditions as the increment. Currently, we do that for power saving profile mode. This patch also ensures that num_waiters is incremented in the c

✓ i915.CI.BAT: success for drm/i915/pch: fix warning for coffeelake on SunrisePoint PCH (rev2)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/pch: fix warning for coffeelake on SunrisePoint PCH (rev2) URL : https://patchwork.freedesktop.org/series/148028/ State : success == Summary == CI Bug Log - changes from CI_DRM_16465 -> Patchwork_148028v2 ===

Re: [PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

2025-04-25 Thread David Hildenbrand
On 25.04.25 22:23, Peter Xu wrote: On Fri, Apr 25, 2025 at 10:17:09AM +0200, David Hildenbrand wrote: Let's use our new interface. In remap_pfn_range(), we'll now decide whether we have to track (full VMA covered) or only sanitize the pgprot (partial VMA covered). Remember what we have to untra

✓ i915.CI.BAT: success for drm/i915/display: Add check for alloc_ordered_workqueue() and alloc_workqueue() (rev3)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/display: Add check for alloc_ordered_workqueue() and alloc_workqueue() (rev3) URL : https://patchwork.freedesktop.org/series/145245/ State : success == Summary == CI Bug Log - changes from CI_DRM_16465 -> Patchwork_145245v3 ===

[PATCH v2 RESEND] drm/i915/display: Add check for alloc_ordered_workqueue() and alloc_workqueue()

2025-04-25 Thread Haoxiang Li
Add check for the return value of alloc_ordered_workqueue() and alloc_workqueue(). Furthermore, if some allocations fail, cleanup works are added to avoid potential memory leak problem. Fixes: 40053823baad ("drm/i915/display: move modeset probe/remove functions to intel_display_driver.c") Cc: sta

✗ LGCI.VerificationFailed: failure for drm/xe: Allow building as kernel built-in (rev2)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/xe: Allow building as kernel built-in (rev2) URL : https://patchwork.freedesktop.org/series/148280/ State : failure == Summary == Address 'hpaus...@protonmail.com' is not on the allowlist! Exception occurred during validation, bailing out!

Re: [PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

2025-04-25 Thread Peter Xu
On Fri, Apr 25, 2025 at 10:17:09AM +0200, David Hildenbrand wrote: > Let's use our new interface. In remap_pfn_range(), we'll now decide > whether we have to track (full VMA covered) or only sanitize the pgprot > (partial VMA covered). > > Remember what we have to untrack by linking it from the VM

Re: [PATCH v1 04/11] mm/memremap: convert to pfnmap_track() + pfnmap_untrack()

2025-04-25 Thread David Hildenbrand
On 25.04.25 22:00, Peter Xu wrote: On Fri, Apr 25, 2025 at 10:17:08AM +0200, David Hildenbrand wrote: Let's use the new, cleaner interface. Signed-off-by: David Hildenbrand --- mm/memremap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/memremap.c b/mm/memre

RE: [PATCH] drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Cavitt, Jonathan
-Original Message- From: Intel-xe On Behalf Of Animesh Manna Sent: Friday, April 25, 2025 6:21 AM To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: Hogander, Jouni ; Manna, Animesh Subject: [PATCH] drm/i915/alpm: Check for alpm support before accessing alpm regist

Re: [PATCH v1 04/11] mm/memremap: convert to pfnmap_track() + pfnmap_untrack()

2025-04-25 Thread Peter Xu
On Fri, Apr 25, 2025 at 10:17:08AM +0200, David Hildenbrand wrote: > Let's use the new, cleaner interface. > > Signed-off-by: David Hildenbrand > --- > mm/memremap.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 2aebc1b192

Re: [PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot()

2025-04-25 Thread David Hildenbrand
- track_pfn_insert(vma, &pgprot, pfn); + if (pfnmap_sanitize_pgprot(pfn_t_to_pfn(pfn), PAGE_SIZE, &pgprot)) + return VM_FAULT_FALLBACK; Would "pgtable" leak if it fails? If it's PAGE_SIZE, IIUC it won't ever trigger, though. Missed that comment. I can document that pgpr

Re: [PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot()

2025-04-25 Thread David Hildenbrand
On 25.04.25 21:31, Peter Xu wrote: On Fri, Apr 25, 2025 at 10:17:06AM +0200, David Hildenbrand wrote: ... by factoring it out from track_pfn_remap(). For PMDs/PUDs, actually check the full range, and trigger a fallback if we run into this "different memory types / cachemodes" scenario. The cu

[PATCH RESEND] drm/i915/pch: fix warning for coffeelake on SunrisePoint PCH

2025-04-25 Thread Jiajia Liu
i915/pch reports a warning on a mini PC which has a CoffeeLake-S GT2 [UHD Graphics 630] [8086:3e92] and an ISA bridge - H110 LPC Controller [8086:a143]. [5.608723] i915 :00:02.0: [drm] Found coffeelake (device ID 3e92) integrated display version 9.00 stepping N/A [5.608969] [ cut

✓ i915.CI.BAT: success for drm/i915/pm: Clean up the hibernate vs. PCI D3 quirk (rev3)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/pm: Clean up the hibernate vs. PCI D3 quirk (rev3) URL : https://patchwork.freedesktop.org/series/139097/ State : success == Summary == CI Bug Log - changes from CI_DRM_16465 -> Patchwork_139097v3 Summa

✓ i915.CI.BAT: success for drm/i915/gsc: mei interrupt top half should be in irq disabled context (rev4)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/gsc: mei interrupt top half should be in irq disabled context (rev4) URL : https://patchwork.freedesktop.org/series/148172/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148172v4

✗ i915.CI.BAT: failure for drm/i915: refactor VLV IOSF SB for display usage

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915: refactor VLV IOSF SB for display usage URL : https://patchwork.freedesktop.org/series/148266/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148266v1 Summary ---

✓ i915.CI.BAT: success for drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/alpm: Check for alpm support before accessing alpm register URL : https://patchwork.freedesktop.org/series/148268/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148268v1 ==

✓ i915.CI.BAT: success for drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/alpm: Check for alpm support before accessing alpm register URL : https://patchwork.freedesktop.org/series/148268/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148268v1 ==

✓ i915.CI.BAT: success for drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/alpm: Check for alpm support before accessing alpm register URL : https://patchwork.freedesktop.org/series/148268/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148268v1 ==

✓ i915.CI.BAT: success for drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/alpm: Check for alpm support before accessing alpm register URL : https://patchwork.freedesktop.org/series/148268/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148268v1 ==

✓ i915.CI.BAT: success for drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/alpm: Check for alpm support before accessing alpm register URL : https://patchwork.freedesktop.org/series/148268/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148268v1 ==

✓ i915.CI.BAT: success for Rework/Correction on minimum hblank calculation (rev7)

2025-04-25 Thread Patchwork
== Series Details == Series: Rework/Correction on minimum hblank calculation (rev7) URL : https://patchwork.freedesktop.org/series/147361/ State : success == Summary == CI Bug Log - changes from CI_DRM_16460 -> Patchwork_147361v7 Summary --

✓ i915.CI.BAT: success for drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/alpm: Check for alpm support before accessing alpm register URL : https://patchwork.freedesktop.org/series/148268/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148268v1 ==

Re: [PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot()

2025-04-25 Thread Peter Xu
On Fri, Apr 25, 2025 at 10:17:06AM +0200, David Hildenbrand wrote: > ... by factoring it out from track_pfn_remap(). > > For PMDs/PUDs, actually check the full range, and trigger a fallback > if we run into this "different memory types / cachemodes" scenario. The current patch looks like to still

Re: [PATCH v2] drm/xe: Allow building as kernel built-in

2025-04-25 Thread Harry Austen
On Fri Apr 25, 2025 at 8:59 AM BST, Jani Nikula wrote: > On Fri, 25 Apr 2025, Harry Austen wrote: >> Fix Kconfig symbol dependency on KUNIT, which isn't actually required >> for XE to be built-in. However, if KUNIT is enabled, it must be built-in >> too. >> >> Also, allow DRM_XE_DISPLAY to be buil

Re: [PATCH v3 0/2] Don't create Python bytecode when building the kernel

2025-04-25 Thread Akira Yokosawa
On Wed, 23 Apr 2025 19:31:36 +0300, Andy Shevchenko wrote: > On Wed, Apr 23, 2025 at 06:30:48PM +0900, Akira Yokosawa wrote: >> On Tue, 22 Apr 2025 10:57:33 +0300, Andy Shevchenko wrote: >>> On Mon, Apr 21, 2025 at 10:35:29AM -0600, Jonathan Corbet wrote: Dmitry Baryshkov writes: > > [...] >

✓ i915.CI.BAT: success for drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/alpm: Check for alpm support before accessing alpm register URL : https://patchwork.freedesktop.org/series/148268/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148268v1 ==

✓ i915.CI.BAT: success for drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/alpm: Check for alpm support before accessing alpm register URL : https://patchwork.freedesktop.org/series/148268/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148268v1 ==

Re: [PATCH v3 0/2] Don't create Python bytecode when building the kernel

2025-04-25 Thread Akira Yokosawa
Hi Andy, On Tue, 22 Apr 2025 10:57:33 +0300, Andy Shevchenko wrote: > On Mon, Apr 21, 2025 at 10:35:29AM -0600, Jonathan Corbet wrote: >> Dmitry Baryshkov writes: [...] >> > Would it be possible to properly support O= and create pyc / pycache >> > inside the object/output dir? >> >> I have to c

[PATCH v2] drm/xe: Allow building as kernel built-in

2025-04-25 Thread Harry Austen
Fix Kconfig symbol dependency on KUNIT, which isn't actually required for XE to be built-in. However, if KUNIT is enabled, it must be built-in too. Also, allow DRM_XE_DISPLAY to be built-in. But only as long as DRM_I915 isn't, since that results in duplicate symbol errors. Fixes: 08987a8b6820 ("d

[PATCH v3] drm/xe: Allow building as kernel built-in

2025-04-25 Thread Harry Austen
Fix Kconfig symbol dependency on KUNIT, which isn't actually required for XE to be built-in. However, if KUNIT is enabled, it must be built-in too. Also, allow DRM_XE_DISPLAY to be built-in. But only as long as DRM_I915 isn't, since that results in duplicate symbol errors. Fixes: 08987a8b6820 ("d

✓ i915.CI.BAT: success for drm/i915/gsc: mei interrupt top half should be in irq disabled context (rev3)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/gsc: mei interrupt top half should be in irq disabled context (rev3) URL : https://patchwork.freedesktop.org/series/148172/ State : success == Summary == CI Bug Log - changes from CI_DRM_16464 -> Patchwork_148172v3

✓ i915.CI.BAT: success for Rework/Correction on minimum hblank calculation (rev7)

2025-04-25 Thread Patchwork
== Series Details == Series: Rework/Correction on minimum hblank calculation (rev7) URL : https://patchwork.freedesktop.org/series/147361/ State : success == Summary == CI Bug Log - changes from CI_DRM_16460 -> Patchwork_147361v7 Summary --

✗ Fi.CI.BUILD: warning for drm/i915/pm: Clean up the hibernate vs. PCI D3 quirk (rev3)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/pm: Clean up the hibernate vs. PCI D3 quirk (rev3) URL : https://patchwork.freedesktop.org/series/139097/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/139097/revisions/3/mbox/ not found

Re: [PATCH v3 04/20] drm/i915: Avoid open-coded use of ratelimit_state structure's ->missed field

2025-04-25 Thread Paul E. McKenney
On Fri, Apr 25, 2025 at 11:48:31AM +0300, Jani Nikula wrote: > On Thu, 24 Apr 2025, "Paul E. McKenney" wrote: > > The i915_oa_stream_destroy() function directly accesses the > > ratelimit_state structure's ->missed field, which work, but which also > > makes it more difficult to change this field.

[PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Junxiao Chang
MEI GSC interrupt comes from i915. It has top half and bottom half. Top half is called from i915 interrupt handler. It should be in irq disabled context. With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC top half might be in threaded IRQ context. generic_handle_irq_safe API c

✗ Fi.CI.SPARSE: warning for drm/i915: refactor VLV IOSF SB for display usage

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915: refactor VLV IOSF SB for display usage URL : https://patchwork.freedesktop.org/series/148266/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bi

✗ Fi.CI.CHECKPATCH: warning for drm/i915: refactor VLV IOSF SB for display usage

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915: refactor VLV IOSF SB for display usage URL : https://patchwork.freedesktop.org/series/148266/ State : warning == Summary == Error: dim checkpatch failed 8d12bc3f7133 drm/i915: rename vlv_sideband*.[ch] to vlv_iosf_sb*.[ch] -:236: WARNING:FILE_PATH_CHANGES

[PATCH] drm/i915/alpm: Check for alpm support before accessing alpm register

2025-04-25 Thread Animesh Manna
Currently as EDP only support alpm and check for alpm support will prevent DP connector to access alpm register. Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_alpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_alpm.

[PATCH 5/6] drm/i915: move VLV IOSF SB unit specific helpers under display

2025-04-25 Thread Jani Nikula
Now that all the VLV IOSF SB unit specific helper users are under display, relocate the helpers themselves under display as well. Resurrect the vlv_sideband.[ch] name for this. Make everything except DPIO helpers static inlines, as their implementations are trivial. All of this considerably simpli

[PATCH 6/6] drm/i915: convert VLV IOSF SB interface to struct drm_device

2025-04-25 Thread Jani Nikula
With users both in i915 core and display, struct drm_device is the common denominator for the VLV IOSF SB users. Also use drm_device for the helpers on the display side to keep the static inlines as simple as possible. We can drop a number of dependencies on i915_drv.h with this. Signed-off-by: J

[PATCH 4/6] drm/i915: switch i915 core to generic VLV IOSF SB functions

2025-04-25 Thread Jani Nikula
We'll want to relocate the unit specific functions to display, making them inaccessible to i915 core. As there aren't that many users in i915 core, we can just convert them to the generic VLV IOSF SB read/write functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs

[PATCH 3/6] drm/i915: rewrite VLV IOSF SB unit specific read/write functions

2025-04-25 Thread Jani Nikula
Rewrite the VLV IOSF SB unit specific helpers in terms of the new generic read/write functions. They become even simpler than they were. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/vlv_iosf_sb.c | 73 -- 1 file changed, 20 insertions(+), 53 deletions(-) diff

[PATCH 2/6] drm/i915: add generic read/write functions for VLV IOSF SB

2025-04-25 Thread Jani Nikula
The read/write functions will be helpful for rewriting the unit specific functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/vlv_iosf_sb.c| 73 +++ drivers/gpu/drm/i915/vlv_iosf_sb.h| 6 +- .../drm/xe/compat-i915-headers/vlv_iosf_sb.h | 9 ++-

[PATCH 1/6] drm/i915: rename vlv_sideband*.[ch] to vlv_iosf_sb*.[ch]

2025-04-25 Thread Jani Nikula
Be more specific in the naming, and follow the existing function naming pattern of vlv_iosf_sb_*() in the file. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/display/i9xx_wm.c| 2 +- drivers/gpu/drm/i915/

[PATCH 0/6] drm/i915: refactor VLV IOSF SB for display usage

2025-04-25 Thread Jani Nikula
In short, add and use generic (not unit specific) read/write/get/put for i915 core, move the unit specific helpers to display, and convert all of them to use drm_display instead of drm_i915_private. This reduces the display<->i915 interface to just a handful of functions, while keeping the simple h

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Sebastian Andrzej Siewior
On 2025-04-25 20:04:43 [+0800], Junxiao Chang wrote: > --- a/drivers/gpu/drm/i915/gt/intel_gsc.c > +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c > @@ -284,7 +284,8 @@ static void gsc_irq_handler(struct intel_gt *gt, unsigned > int intf_id) > if (gt->gsc.intf[intf_id].irq < 0) > ret

[PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Junxiao Chang
MEI GSC interrupt comes from i915. It has top half and bottom half. Top half is called from i915 interrupt handler. It should be in irq disabled context. With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC top half might be in threaded IRQ context. generic_handle_irq_safe API c

Re: [PATCH v2 01/13] drm/i915/vrr: Refactor vmin/vmax stuff

2025-04-25 Thread Nautiyal, Ankit K
On 4/23/2025 12:19 PM, Nautiyal, Ankit K wrote: On 4/21/2025 9:18 PM, Mitul Golani wrote: From: Ville Syrjälä Refactor vmin/vmax functions for better computation. Signed-off-by: Ville Syrjälä Signed-off-by: Mitul Golani ---   drivers/gpu/drm/i915/display/intel_vrr.c | 41 +++-

✗ Fi.CI.BUILD: failure for drm/i915: Add drm_panic support (rev7)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915: Add drm_panic support (rev7) URL : https://patchwork.freedesktop.org/series/141935/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers LD [M] drivers/gpu/drm/i915/i915.o L

[PATCH v7 8/8] drm/i915/display: Add drm_panic support for 4-tiling with DPT

2025-04-25 Thread Jocelyn Falempe
On Alder Lake and later, it's not possible to disable tiling when DPT is enabled. So this commit implements 4-Tiling support, to still be able to draw the panic screen. Signed-off-by: Jocelyn Falempe --- .../gpu/drm/i915/display/intel_atomic_plane.c | 23 ++- 1 file changed, 22 i

[PATCH v7 7/8] drm/i915/display: Add drm_panic support for Y-tiling with DPT

2025-04-25 Thread Jocelyn Falempe
On Alder Lake and later, it's not possible to disable tiling when DPT is enabled. So this commit implements Y-Tiling support, to still be able to draw the panic screen. Signed-off-by: Jocelyn Falempe --- .../gpu/drm/i915/display/intel_atomic_plane.c | 69 ++- .../drm/i915/display

[PATCH v7 6/8] drm/i915/display: Flush the front buffer in panic handler

2025-04-25 Thread Jocelyn Falempe
On Lunar Lake, if the panic occurs when fbcon is active, the panic screen is only partially visible on the screen. Adding this intel_frontbuffer_flush() call solves the issue. It's probably not safe to do that in the panic handler, but that's still better than nothing. Signed-off-by: Jocelyn Falem

[PATCH v7 5/8] drm/i915/display: Add drm_panic support

2025-04-25 Thread Jocelyn Falempe
This adds drm_panic support for a wide range of Intel GPU. I've tested it only on 4 laptops, Haswell (with 128MB of eDRAM), Comet Lake, Alder Lake, and Lunar Lake. For hardware using DPT, it's not possible to disable tiling, as you will need to reconfigure the way the GPU is accessing the framebuff

[PATCH v7 4/8] drm/i915/gem: Add i915_gem_object_panic_map()

2025-04-25 Thread Jocelyn Falempe
Prepare the work for drm_panic support. This is used to map the current framebuffer, so the CPU can overwrite it with the panic message. Signed-off-by: Jocelyn Falempe --- v5: * Use iosys_map for intel_bo_panic_map(). v7: * Return int for i915_gem_object_panic_map() (Ville Syrjälä) driver

[PATCH v7 0/8] drm/i915: Add drm_panic support

2025-04-25 Thread Jocelyn Falempe
This is a draft of drm_panic support for i915. I've tested it on the 4 intel laptops I have at my disposal. * Haswell with 128MB of eDRAM. * Comet Lake i7-10850H * Raptor Lake i7-1370P (with DPT, and Y-tiling). * Lunar Lake Ultra 5 228V (with DPT, and 4-tiling, and using the Xe driver. I tes

[PATCH v7 1/8] drm/i915/fbdev: Add intel_fbdev_get_map()

2025-04-25 Thread Jocelyn Falempe
The vaddr of the fbdev framebuffer is private to the struct intel_fbdev, so this function is needed to access it for drm_panic. Also the struct i915_vma is different between i915 and xe, so it requires a few functions to access fbdev->vma->iomap. Signed-off-by: Jocelyn Falempe --- v2: * Add int

[PATCH v7 3/8] drm/i915/display: Add a disable_tiling() for skl planes

2025-04-25 Thread Jocelyn Falempe
drm_panic draws in linear framebuffer, so it's easier to re-use the current framebuffer, and disable tiling in the panic handler, to show the panic screen. This assumes that the alignment restriction is always smaller in linear than in tiled. It also assumes that the linear framebuffer size is alw

[PATCH v7 2/8] drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes

2025-04-25 Thread Jocelyn Falempe
drm_panic draws in linear framebuffer, so it's easier to re-use the current framebuffer, and disable tiling in the panic handler, to show the panic screen. This assumes that the alignment restriction is always smaller in linear than in tiled. It also assumes that the linear framebuffer size is alwa

Re: [PATCH v1 00/11] mm: rewrite pfnmap tracking and remove VM_PAT

2025-04-25 Thread David Hildenbrand
There will be some clash with [1], but nothing that cannot be sorted out easily by moving the functions added to kernel/fork.c to wherever the vma bits will live. Briefly tested with some basic /dev/mem test I crafted. I want to convert them to selftests, but that might or might not require a bit

[PATCH v1 01/11] x86/mm/pat: factor out setting cachemode into pgprot_set_cachemode()

2025-04-25 Thread David Hildenbrand
Let's factor it out to make the code easier to grasp. Use it also in pgprot_writecombine()/pgprot_writethrough() where clearing the old cachemode might not be required, but given that we are already doing a function call, no need to care about this micro-optimization. Signed-off-by: David Hildenb

Re: [PATCH v1 00/11] mm: rewrite pfnmap tracking and remove VM_PAT

2025-04-25 Thread Ingo Molnar
* David Hildenbrand wrote: > On top of mm-unstable. > > VM_PAT annoyed me too much and wasted too much of my time, let's clean > PAT handling up and remove VM_PAT. > > This should sort out various issues with VM_PAT we discovered recently, > and will hopefully make the whole code more stable

Re: [PATCH v3 04/20] drm/i915: Avoid open-coded use of ratelimit_state structure's ->missed field

2025-04-25 Thread Jani Nikula
On Thu, 24 Apr 2025, "Paul E. McKenney" wrote: > The i915_oa_stream_destroy() function directly accesses the > ratelimit_state structure's ->missed field, which work, but which also > makes it more difficult to change this field. Therefore, make use of > the ratelimit_state_get_miss() function in

RE: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Chang, Junxiao
On Fri, 25 Apr 2025, Jani Nikula wrote: >On Fri, 25 Apr 2025, Junxiao Chang wrote: >> MEI GSC interrupt comes from i915. It has top half and bottom half. >> >> -ret = generic_handle_irq(gt->gsc.intf[intf_id].irq); >> +/* It can be called in both irq context and in thread context */ > >Wha

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Sebastian Andrzej Siewior
On 2025-04-25 14:04:54 [+0800], Junxiao Chang wrote: > MEI GSC interrupt comes from i915. It has top half and bottom half. > Top half is called from i915 interrupt handler. It should be in > irq disabled context. > > With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC > top hal

[PATCH v1 07/11] mm: remove VM_PAT

2025-04-25 Thread David Hildenbrand
It's unused, so let's remove it. Signed-off-by: David Hildenbrand --- include/linux/mm.h | 4 +--- include/trace/events/mmflags.h | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 9b701cfbef223..a205020e2a58b 100644

[PATCH v1 10/11] drm/i915: track_pfn() -> "pfnmap tracking"

2025-04-25 Thread David Hildenbrand
track_pfn() does not exist, let's simply refer to it as "pfnmap tracking". Signed-off-by: David Hildenbrand --- drivers/gpu/drm/i915/i915_mm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c index 76e2801619f

[PATCH v1 06/11] x86/mm/pat: remove old pfnmap tracking interface

2025-04-25 Thread David Hildenbrand
We can now get rid of the old interface along with get_pat_info() and follow_phys(). Signed-off-by: David Hildenbrand --- arch/x86/mm/pat/memtype.c | 147 -- include/linux/pgtable.h | 66 - 2 files changed, 213 deletions(-) diff --git a/arc

[PATCH v1 11/11] mm/io-mapping: track_pfn() -> "pfnmap tracking"

2025-04-25 Thread David Hildenbrand
track_pfn() does not exist, let's simply refer to it as "pfnmap tracking". Signed-off-by: David Hildenbrand --- mm/io-mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/io-mapping.c b/mm/io-mapping.c index 01b3627999304..7266441ad0834 100644 --- a/mm/io-mapping.c ++

[PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

2025-04-25 Thread David Hildenbrand
Let's use our new interface. In remap_pfn_range(), we'll now decide whether we have to track (full VMA covered) or only sanitize the pgprot (partial VMA covered). Remember what we have to untrack by linking it from the VMA. When duplicating VMAs (e.g., splitting, mremap, fork), we'll handle it sim

[PATCH v1 04/11] mm/memremap: convert to pfnmap_track() + pfnmap_untrack()

2025-04-25 Thread David Hildenbrand
Let's use the new, cleaner interface. Signed-off-by: David Hildenbrand --- mm/memremap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/memremap.c b/mm/memremap.c index 2aebc1b192da9..c417c843e9b1f 100644 --- a/mm/memremap.c +++ b/mm/memremap.c @@ -130,7 +130,7 @@

[PATCH v1 09/11] x86/mm/pat: remove MEMTYPE_*_MATCH

2025-04-25 Thread David Hildenbrand
The "memramp() shrinking" scenario no longer applies, so let's remove that now-unnecessary handling. Signed-off-by: David Hildenbrand --- arch/x86/mm/pat/memtype_interval.c | 44 -- 1 file changed, 6 insertions(+), 38 deletions(-) diff --git a/arch/x86/mm/pat/memtype

[PATCH v1 08/11] x86/mm/pat: remove strict_prot parameter from reserve_pfn_range()

2025-04-25 Thread David Hildenbrand
Always set to 0, so let's remove it. Signed-off-by: David Hildenbrand --- arch/x86/mm/pat/memtype.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index 668ebf0065157..57e3ced4c28cb 100644 --- a/arch/x86/mm/p

[PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot()

2025-04-25 Thread David Hildenbrand
... by factoring it out from track_pfn_remap(). For PMDs/PUDs, actually check the full range, and trigger a fallback if we run into this "different memory types / cachemodes" scenario. Add some documentation. Will checking each page result in undesired overhead? We'll have to learn. Not checking

[PATCH v1 03/11] x86/mm/pat: introduce pfnmap_track() and pfnmap_untrack()

2025-04-25 Thread David Hildenbrand
Let's provide variants of track_pfn_remap() and untrack_pfn() that won't mess with VMAs, to replace the existing interface step-by-step. Add some documentation. Signed-off-by: David Hildenbrand --- arch/x86/mm/pat/memtype.c | 14 ++ include/linux/pgtable.h | 33 +++

[PATCH v1 00/11] mm: rewrite pfnmap tracking and remove VM_PAT

2025-04-25 Thread David Hildenbrand
On top of mm-unstable. VM_PAT annoyed me too much and wasted too much of my time, let's clean PAT handling up and remove VM_PAT. This should sort out various issues with VM_PAT we discovered recently, and will hopefully make the whole code more stable and easier to maintain. In essence: we stop

RE: [PATCH v3 1/2] drm/i915/display: Ensure enough lines between delayed VBlank and VBlank

2025-04-25 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Wednesday, April 23, 2025 3:57 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Hogander, Jouni > Subject: [PATCH v3 1/2] drm/i915/display: Ensure enough lines between > delayed VBla

RE: [PATCH v3 2/2] drm/i915/psr: Move PSR workaround to intel_psr.c

2025-04-25 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Wednesday, April 23, 2025 3:57 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Hogander, Jouni > Subject: [PATCH v3 2/2] drm/i915/psr: Move PSR workaround to intel_psr.c > > Logica

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Jani Nikula
On Fri, 25 Apr 2025, Junxiao Chang wrote: > MEI GSC interrupt comes from i915. It has top half and bottom half. > Top half is called from i915 interrupt handler. It should be in > irq disabled context. > > With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC > top half might be

Re: [PATCH v2] drm/xe: Allow building as kernel built-in

2025-04-25 Thread Jani Nikula
On Fri, 25 Apr 2025, Harry Austen wrote: > Fix Kconfig symbol dependency on KUNIT, which isn't actually required > for XE to be built-in. However, if KUNIT is enabled, it must be built-in > too. > > Also, allow DRM_XE_DISPLAY to be built-in. But only as long as DRM_I915 > isn't, since that results

✗ i915.CI.BAT: failure for drm/i915/gsc: mei interrupt top half should be in irq disabled context (rev2)

2025-04-25 Thread Patchwork
== Series Details == Series: drm/i915/gsc: mei interrupt top half should be in irq disabled context (rev2) URL : https://patchwork.freedesktop.org/series/148172/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16463 -> Patchwork_148172v2