Re: [PATCH v4 00/12] Panel Replay + Adaptive sync

2025-05-28 Thread Hogander, Jouni
On Mon, 2025-05-26 at 13:43 +0200, Maarten Lankhorst wrote: > Hey, > > Seems to be just some register definitions. > > Acked-by: Maarten Lankhorst Thank you Maarten and Ankit for checking my patches. These are now pushed to drm-intel-next. BR, Jouni Högander > > Best regards, > ~Maarten >

✓ i915.CI.BAT: success for drm/i915/pmu: Fix build error with GCOV and AutoFDO enabled

2025-05-28 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Fix build error with GCOV and AutoFDO enabled URL : https://patchwork.freedesktop.org/series/149617/ State : success == Summary == CI Bug Log - changes from CI_DRM_16610 -> Patchwork_149617v1 Summa

[PATCH] drm/i915/pmu: Fix build error with GCOV and AutoFDO enabled

2025-05-28 Thread Tzung-Bi Shih
i915_pmu.c may fail to build with GCOV and AutoFDO enabled. ../drivers/gpu/drm/i915/i915_pmu.c:116:3: error: call to '__compiletime_assert_487' declared with 'error' attribute: BUILD_BUG_ON failed: bit > BITS_PER_TYPE(typeof_member(struct i915_pmu, enable)) - 1 116 | BUILD_BUG_

✗ i915.CI.BAT: failure for drm/i915/guc: Handle race condition where wakeref count drops below 0 (rev3)

2025-05-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: Handle race condition where wakeref count drops below 0 (rev3) URL : https://patchwork.freedesktop.org/series/149081/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16610 -> Patchwork_149081v3 =

[PATCH v3] drm/i915/guc: Handle race condition where wakeref count drops below 0

2025-05-28 Thread Jesus Narvaez
There is a rare race condition when preparing for a reset where guc_lrc_desc_unpin() could be in the process of deregistering a context while a different thread is scrubbing outstanding contexts and it alters the context state and does a wakeref put. Then, if there is a failure with deregister_cont

Re: [PATCH v11 00/10] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-05-28 Thread Jakub Kicinski
On Wed, 28 May 2025 10:34:32 -0400 Jeff Layton wrote: > Changes in v10: > - drop the i915 symlink patch > - Link to v9: > https://lore.kernel.org/r/20250509-reftrack-dbgfs-v9-0-8ab888a45...@kernel.org Hm, I reported the refracker warnings at boot on v9 : ref_tracker: ref_tracker: unable to cre

Re: [PATCH v2] drm/i915/guc: Handle race condition where wakeref count drops below 0

2025-05-28 Thread Daniele Ceraolo Spurio
On 5/23/2025 4:52 PM, Jesus Narvaez wrote: There is a rare race condition when preparing for a reset where guc_lrc_desc_unpin() could be in the process of deregistering a context while a different thread is scrubbing outstanding contexts and it alters the context state and does a wakeref put.

Re: [PATCH v2 0/4] New DRM properties for output color format

2025-05-28 Thread Andri Yngvason
Hi Sean, mið., 28. maí 2025 kl. 16:24 skrifaði Sean Summers : > > Hi Andri, > > I've made this patch, but I'm unable to configure the video pipeline for YCC > 420. I'm using libdrm's modetest to set the output format / colorspace and > pass a test pattern through. Modetest can see the new "force

Fw: [PATCH v2 0/4] New DRM properties for output color format

2025-05-28 Thread Sean Summers
Whoops, wasn't subscribed to the email list. Resending. Sorry about the spam Hi Andri, I've made this patch, but I'm unable to configure the video pipeline for YCC 420. I'm using libdrm's modetest to set the output format / colorspace and pass a test pattern through. Modetest can see the new "f

Re: [PATCH v2 0/4] New DRM properties for output color format

2025-05-28 Thread Sean Summers
Hi Andri, I've made this patch, but I'm unable to configure the video pipeline for YCC 420. I'm using libdrm's modetest to set the output format / colorspace and pass a test pattern through. Modetest can see the new "force output format" property, but it's being rejected and falls back to RGB.

[PULL] drm-xe-next-fixes

2025-05-28 Thread Thomas Hellstrom
Hi Dave, Simona Two documentation fixes this week. Thanks, Thomas drm-xe-next-fixes-2025-05-28: Driver Changes: - Two documentation fixes (Rodrigo) The following changes since commit 879ede53958f7bab79a8f77e0ca91f0f77da: drm/xe: Default auto_link_downgrade status to false (2025-05-23 09:

[PULL] drm-misc-fixes

2025-05-28 Thread Thomas Zimmermann
Hi Dave, Sima, this is the weekly PR for drm-misc-fixes. Besides DRM, the bugfix for dummycon possibly affects fbcon and fbdev output as well. Best regards Thomas drm-misc-fixes-2025-05-28: Short summary of fixes pull: drm-scheduler: - signal scheduled fence when killing job dummycon: - trigge

✗ i915.CI.BAT: failure for ref_tracker: add ability to register a debugfs file for a ref_tracker_dir (rev7)

2025-05-28 Thread Patchwork
== Series Details == Series: ref_tracker: add ability to register a debugfs file for a ref_tracker_dir (rev7) URL : https://patchwork.freedesktop.org/series/148490/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16602 -> Patchwork_148490v7 =

✗ Fi.CI.SPARSE: warning for ref_tracker: add ability to register a debugfs file for a ref_tracker_dir (rev7)

2025-05-28 Thread Patchwork
== Series Details == Series: ref_tracker: add ability to register a debugfs file for a ref_tracker_dir (rev7) URL : https://patchwork.freedesktop.org/series/148490/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separ

✗ Fi.CI.CHECKPATCH: warning for ref_tracker: add ability to register a debugfs file for a ref_tracker_dir (rev7)

2025-05-28 Thread Patchwork
== Series Details == Series: ref_tracker: add ability to register a debugfs file for a ref_tracker_dir (rev7) URL : https://patchwork.freedesktop.org/series/148490/ State : warning == Summary == Error: dim checkpatch failed 35a19b0086ca i915: only initialize struct ref_tracker_dir once cfda4e

✗ Fi.CI.BUILD: failure for mtd: add driver for Intel discrete graphics (rev12)

2025-05-28 Thread Patchwork
== Series Details == Series: mtd: add driver for Intel discrete graphics (rev12) URL : https://patchwork.freedesktop.org/series/140306/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/140306/revisions/12/mbox/ not applied Applying: mtd: add driver

[PATCH v11 10/10] ref_tracker: eliminate the ref_tracker_dir name field

2025-05-28 Thread Jeff Layton
Now that we have dentries and the ability to create meaningful symlinks to them, don't keep a name string in each tracker. Switch the output format to print "class@address", and drop the name field. Also, add a kerneldoc header for ref_tracker_dir_init(). Signed-off-by: Jeff Layton --- drivers/

[PATCH v11 09/10] net: add symlinks to ref_tracker_dir for netns

2025-05-28 Thread Jeff Layton
After assigning the inode number to the namespace, use it to create a unique name for each netns refcount tracker with the ns.inum and net_cookie values in it, and register a symlink to the debugfs file for it. init_net is registered before the ref_tracker dir is created, so add a late_initcall()

[PATCH v11 07/10] ref_tracker: automatically register a file in debugfs for a ref_tracker_dir

2025-05-28 Thread Jeff Layton
Currently, there is no convenient way to see the info that the ref_tracking infrastructure collects. Attempt to create a file in debugfs when called from ref_tracker_dir_init(). The file is given the name "class@%px", as having the unmodified address is helpful for debugging. This should be safe s

[PATCH v11 08/10] ref_tracker: add a way to create a symlink to the ref_tracker_dir debugfs file

2025-05-28 Thread Jeff Layton
Add the ability for a subsystem to add a user-friendly symlink that points to a ref_tracker_dir's debugfs file. Signed-off-by: Jeff Layton --- include/linux/ref_tracker.h | 13 + lib/ref_tracker.c | 28 2 files changed, 41 insertions(+) diff --

[PATCH v11 04/10] ref_tracker: have callers pass output function to pr_ostream()

2025-05-28 Thread Jeff Layton
In a later patch, we'll be adding a 3rd mechanism for outputting ref_tracker info via seq_file. Instead of a conditional, have the caller set a pointer to an output function in struct ostream. As part of this, the log prefix must be explicitly passed in, as it's too late for the pr_fmt macro. Revi

[PATCH v11 06/10] ref_tracker: allow pr_ostream() to print directly to a seq_file

2025-05-28 Thread Jeff Layton
Allow pr_ostream to also output directly to a seq_file without an intermediate buffer. The first caller of +ref_tracker_dir_seq_print() will come in a later patch, so mark that __maybe_unused for now. That designation will be removed once it is used. Reviewed-by: Andrew Lunn Signed-off-by: Jeff L

[PATCH v11 05/10] ref_tracker: add a static classname string to each ref_tracker_dir

2025-05-28 Thread Jeff Layton
A later patch in the series will be adding debugfs files for each ref_tracker that get created in ref_tracker_dir_init(). The format will be "class@%px". The current "name" string can vary between ref_tracker_dir objects of the same type, so it's not suitable for this purpose. Add a new "class" st

[PATCH v11 01/10] i915: only initialize struct ref_tracker_dir once

2025-05-28 Thread Jeff Layton
I got some warnings from the i915 CI with the ref_tracker debugfs patches applied, that indicated that these ref_tracker_dir_init() calls were being called more than once. If references were held on these objects between the initializations, then that could lead to leaked ref tracking objects. Sin

[PATCH v11 02/10] ref_tracker: don't use %pK in pr_ostream() output

2025-05-28 Thread Jeff Layton
As Thomas Weißschuh points out [1], it is now preferable to use %p instead of hashed pointers with printk(), since raw pointers should no longer be leaked into the kernel log. Change the ref_tracker infrastructure to use %p instead of %pK in its formats. [1]: https://lore.kernel.org/netdev/202504

[PATCH v11 03/10] ref_tracker: add a top level debugfs directory for ref_tracker

2025-05-28 Thread Jeff Layton
Add a new "ref_tracker" directory in debugfs. Each individual refcount tracker can register files under there to display info about currently-held references. Reviewed-by: Andrew Lunn Signed-off-by: Jeff Layton --- lib/ref_tracker.c | 16 1 file changed, 16 insertions(+) diff

[PATCH v11 00/10] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-05-28 Thread Jeff Layton
More CI reports [1]. This time it showed what I consider to be an existing bug in the i915 driver. It can call ref_tracker_dir_init() more than once on the same dir object, which could cause reference tracking objects to leak. The first patch in the series ensures that this doesn't happen. The res

[PATCH v11 10/10] drm/xe/nvm: add support for non-posted erase

2025-05-28 Thread Alexander Usyskin
From: Reuven Abliyev Erase command is slow on discrete graphics storage and may overshot PCI completion timeout. BMG introduces the ability to have non-posted erase. Add driver support for non-posted erase with polling for erase completion. Reviewed-by: Rodrigo Vivi Acked-by: Rodrigo Vivi Sign

[PATCH v11 08/10] drm/xe/nvm: add on-die non-volatile memory device

2025-05-28 Thread Alexander Usyskin
Enable access to internal non-volatile memory on DGFX with GSC/CSC devices via a child device. The nvm child device is exposed via auxiliary bus. Reviewed-by: Rodrigo Vivi Acked-by: Rodrigo Vivi Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/

[PATCH v11 09/10] drm/xe/nvm: add support for access mode

2025-05-28 Thread Alexander Usyskin
Check NVM access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Reviewed-by: Rodrigo Vivi Acked-by: Rodrigo Vivi Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/regs/xe_gsc_regs.h | 4 +++ drivers/gpu/drm/xe/xe_heci_gsc.c | 5 +

[PATCH v11 07/10] drm/i915/nvm: add support for access mode

2025-05-28 Thread Alexander Usyskin
Check NVM access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Reviewed-by: Rodrigo Vivi Acked-by: Rodrigo Vivi Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/intel_nvm.c | 25 - 1 file changed, 24 insertio

[PATCH v11 06/10] drm/i915/nvm: add nvm device for discrete graphics

2025-05-28 Thread Alexander Usyskin
Enable access to internal non-volatile memory on DGFX devices via a child device. The nvm child device is exposed via auxiliary bus. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Acked-by: Rodrigo Vivi Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyski

[PATCH v11 03/10] mtd: intel-dg: implement access functions

2025-05-28 Thread Alexander Usyskin
Implement read(), erase() and write() functions. CC: Lucas De Marchi CC: Rodrigo Vivi Reviewed-by: Raag Jadav Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Co-developed-by: Vitaly Lubart Signed-off-by: Vitaly Lubart Signed-off-by: Alexander Usyskin --

[PATCH v11 05/10] mtd: intel-dg: align 64bit read and write

2025-05-28 Thread Alexander Usyskin
GSC NVM controller HW errors on quad access overlapping 1K border. Align 64bit read and write to avoid readq/writeq over 1K border. Acked-by: Miquel Raynal Signed-off-by: Alexander Usyskin --- drivers/mtd/devices/mtd_intel_dg.c | 35 ++ 1 file changed, 35 insertions(

[PATCH v11 04/10] mtd: intel-dg: register with mtd

2025-05-28 Thread Alexander Usyskin
Register the on-die nvm device with the mtd subsystem. Refcount nvm object on _get and _put mtd callbacks. For erase operation address and size should be 4K aligned. For write operation address and size has to be 4bytes aligned. CC: Rodrigo Vivi CC: Lucas De Marchi Acked-by: Miquel Raynal Co-de

[PATCH v11 02/10] mtd: intel-dg: implement region enumeration

2025-05-28 Thread Alexander Usyskin
In intel-dg, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/mtd/

[PATCH v11 01/10] mtd: add driver for intel graphics non-volatile memory device

2025-05-28 Thread Alexander Usyskin
Add auxiliary driver for intel discrete graphics non-volatile memory device. CC: Lucas De Marchi Reviewed-by: Raag Jadav Reviewed-by: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- MAINTAINERS

[PATCH v11 00/10] mtd: add driver for Intel discrete graphics

2025-05-28 Thread Alexander Usyskin
Add driver for access to Intel discrete graphics card internal NVM device. Expose device on auxiliary bus by i915 and Xe drivers and provide mtd driver to register this device with MTD framework. This is a rewrite of "drm/i915/spi: spi access for discrete graphics" and "spi: add driver for Intel d

✓ i915.CI.BAT: success for drm/i915/display: Fix u32 overflow in SNPS PHY HDMI PLL setup

2025-05-28 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix u32 overflow in SNPS PHY HDMI PLL setup URL : https://patchwork.freedesktop.org/series/149565/ State : success == Summary == CI Bug Log - changes from CI_DRM_16602 -> Patchwork_149565v1 Sum

RE: [PATCH] drm/i915/dp: Enable DSC on external DP display if VBT allows

2025-05-28 Thread Lee, Shawn C
On Wed, 28 May 2025, Ville Syrjälä wrote >On Tue, May 27, 2025 at 07:59:06AM +, Lee Shawn C wrote: >> A DSC setting has been available in VBT since version 251, which >> allows users to enable or disable the DSC feature based on their system >> design. >> With this in mind, DP driver shoul

Re: [PATCH] drm/i915/vrr: Set vrr.vmin to min Vtotal to re-enable LRR for PTL

2025-05-28 Thread Ville Syrjälä
On Fri, May 09, 2025 at 08:41:07AM +0530, Ankit Nautiyal wrote: > Currently in intel_vrr_compute_config, we set vrr.vmin to crtc_vtotal for > all cases to avoid having vrr.vmin changed when we switch from > fixed refresh rate timings to variable refresh rate timings. This works for > all cases, exc

Re: [PATCH] drm/i915/dp: Enable DSC on external DP display if VBT allows

2025-05-28 Thread Ville Syrjälä
On Tue, May 27, 2025 at 07:59:06AM +, Lee Shawn C wrote: > A DSC setting has been available in VBT since version 251, which allows > users to enable or disable the DSC feature based on their system design. > With this in mind, DP driver should reference this setting and avoid > enabling DSC if

[REGRESSSION] on linux-next (next-20250509)

2025-05-28 Thread Borah, Chaitanya Kumar
Hello Luke, Hope you are doing well. I am Chaitanya from the linux graphics team in Intel. This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository. Since the version next-20250509 [2], we are seeing the following regression `

Re: linux-next: build failure after merge of the drm-misc tree

2025-05-28 Thread Heiko Stübner
Hi, Am Mittwoch, 28. Mai 2025, 09:17:13 Mitteleuropäische Sommerzeit schrieb Damon Ding: > On 2025/5/28 11:42, Stephen Rothwell wrote: > > Hi all, > > > > After merging the drm-misc tree, today's linux-next build (arm > > multi_v7_defconfig) failed like this: > > > > drivers/gpu/drm/bridge/anal

Re: linux-next: build failure after merge of the drm-misc tree

2025-05-28 Thread Damon Ding
Hi Stephen, On 2025/5/28 11:42, Stephen Rothwell wrote: Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function 'analogix_dp_probe': drivers/gpu/drm/bridge/analogix/analogix_dp