Re: [PATCH] drm/i915/display: Allow async flips on planes with no framebuffer changes

2025-07-18 Thread Xaver Hugl
Am Do., 10. Juli 2025 um 22:21 Uhr schrieb Ville Syrjälä : > > On Mon, Jul 07, 2025 at 03:41:20PM +, Naveen Kumar wrote: > > Allow asynchronous page flips on planes that either lack a framebuffer or > > retain the same framebuffer, as long as no plane properties are modified. > > > > This avoid

✓ i915.CI.BAT: success for drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST (rev3)

2025-07-18 Thread Patchwork
== Series Details == Series: drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST (rev3) URL : https://patchwork.freedesktop.org/series/151085/ State : success == Summary == CI Bug Log - changes from CI_DRM_16893 -> Patchwork_151085v3 S

Re: [PATCH] drm/i915/display: Skip unavailable power wells based on pipe mask

2025-07-18 Thread Gustavo Sousa
Quoting Imre Deak (2025-07-18 14:17:09-03:00) >On Fri, Jul 18, 2025 at 01:33:26PM -0300, Gustavo Sousa wrote: >> Quoting Imre Deak (2025-07-18 12:54:11-03:00) >> >On Thu, Jul 17, 2025 at 09:02:45AM -0300, Gustavo Sousa wrote: >> >> Quoting Chaitanya Kumar Borah (2025-07-17 02:16:03-03:00) >> >> >So

✗ LGCI.VerificationFailed: failure for drm/i915: move struct_mutex from drm_device to drm_i915_private (rev3)

2025-07-18 Thread Patchwork
== Series Details == Series: drm/i915: move struct_mutex from drm_device to drm_i915_private (rev3) URL : https://patchwork.freedesktop.org/series/151828/ State : failure == Summary == Address 'luiz.me...@estudante.ufscar.br' is not on the allowlist, which prevents CI from being triggered for

Re: [PATCH] [PATCH v2] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Rodrigo Vivi
On Fri, Jul 18, 2025 at 01:34:13PM -0300, Luiz Otavio Mello wrote: Oi Luiz! :) First of all thank you so much for the patch. A few comments below: > Includes the missing file drm_device.h, which was unintentionally > omitted in v1. This version comment should be below, not in the beginning of t

✓ i915.CI.BAT: success for drm/i915/dp: Implement POST_LT_ADJ_REQ (rev3)

2025-07-18 Thread Patchwork
== Series Details == Series: drm/i915/dp: Implement POST_LT_ADJ_REQ (rev3) URL : https://patchwork.freedesktop.org/series/145348/ State : success == Summary == CI Bug Log - changes from CI_DRM_16892 -> Patchwork_145348v3 Summary ---

✓ i915.CI.BAT: success for drm/i915/dsi: Don't set/read the DSI C clock divider on GLK

2025-07-18 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Don't set/read the DSI C clock divider on GLK URL : https://patchwork.freedesktop.org/series/151803/ State : success == Summary == CI Bug Log - changes from CI_DRM_16892 -> Patchwork_151803v1 Summa

[PATCH] [PATCH v3] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Luiz Otavio Mello
Includes the missing file drm_device.h, which was unintentionally omitted in v1. i915 is the only remaining user of struct_mutex lock. Move it from drm_device to drm_i915_private so it is only used within the i915 driver. Also update intel_guc_log.c to use the new location of struct_mutex. Sign

✓ i915.CI.BAT: success for drm/ci: add new jobs, uprev IGT and mesa

2025-07-18 Thread Patchwork
== Series Details == Series: drm/ci: add new jobs, uprev IGT and mesa URL : https://patchwork.freedesktop.org/series/151801/ State : success == Summary == CI Bug Log - changes from CI_DRM_16891 -> Patchwork_151801v1 Summary --- **SUC

✓ i915.CI.BAT: success for i915_gem_execbuffer.c minor improved

2025-07-18 Thread Patchwork
== Series Details == Series: i915_gem_execbuffer.c minor improved URL : https://patchwork.freedesktop.org/series/151799/ State : success == Summary == CI Bug Log - changes from CI_DRM_16891 -> Patchwork_151799v1 Summary --- **SUCCESS

✓ i915.CI.BAT: success for iosys-map: Fix undefined behavior in iosys_map_clear()

2025-07-18 Thread Patchwork
== Series Details == Series: iosys-map: Fix undefined behavior in iosys_map_clear() URL : https://patchwork.freedesktop.org/series/151798/ State : success == Summary == CI Bug Log - changes from CI_DRM_16891 -> Patchwork_151798v1 Summary --

Re: [PATCH] [PATCH v2] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Sam Ravnborg
On Fri, Jul 18, 2025 at 01:34:13PM -0300, Luiz Otavio Mello wrote: > Includes the missing file drm_device.h, which was unintentionally > omitted in v1. > > i915 is the only remaining user of struct_mutex lock. > > Move it from drm_device to drm_i915_private so it is only used within > the i915 dr

✗ LGCI.VerificationFailed: failure for drm/i915: move struct_mutex from drm_device to drm_i915_private (rev2)

2025-07-18 Thread Patchwork
== Series Details == Series: drm/i915: move struct_mutex from drm_device to drm_i915_private (rev2) URL : https://patchwork.freedesktop.org/series/151828/ State : failure == Summary == Address 'luiz.me...@estudante.ufscar.br' is not on the allowlist, which prevents CI from being triggered for

Re: [PATCH] drm/i915/display: Skip unavailable power wells based on pipe mask

2025-07-18 Thread Imre Deak
On Fri, Jul 18, 2025 at 01:33:26PM -0300, Gustavo Sousa wrote: > Quoting Imre Deak (2025-07-18 12:54:11-03:00) > >On Thu, Jul 17, 2025 at 09:02:45AM -0300, Gustavo Sousa wrote: > >> Quoting Chaitanya Kumar Borah (2025-07-17 02:16:03-03:00) > >> >Some power wells are only relevant for certain displa

[PATCH] [PATCH v2] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Luiz Otavio Mello
Includes the missing file drm_device.h, which was unintentionally omitted in v1. i915 is the only remaining user of struct_mutex lock. Move it from drm_device to drm_i915_private so it is only used within the i915 driver. Also update intel_guc_log.c to use the new location of struct_mutex. Sign

Re: [PATCH] drm/i915/display: Skip unavailable power wells based on pipe mask

2025-07-18 Thread Gustavo Sousa
Quoting Imre Deak (2025-07-18 12:54:11-03:00) >On Thu, Jul 17, 2025 at 09:02:45AM -0300, Gustavo Sousa wrote: >> Quoting Chaitanya Kumar Borah (2025-07-17 02:16:03-03:00) >> >Some power wells are only relevant for certain display pipes. Add a check >> >to ensure we only allocate and initialize powe

Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST

2025-07-18 Thread Rodrigo Vivi
On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote: > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > > convert drm_mm selftest to KUnit) and all functions under it were > > converted to KUnit, under the

[CI] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST

2025-07-18 Thread Rodrigo Vivi
From: Ruben Wauters DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: convert drm_mm selftest to KUnit) and all functions under it were converted to KUnit, under the DRM_KUNIT_TEST option This conversion however did not occur in the Kconfig.debug file in the i915 directory.

[PATCH] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Luiz Otavio Mello
i915 is the only remaining user of struct_mutex lock. Move it from drm_device to drm_i915_private so it is only used within the i915 driver. Signed-off-by: Luiz Otavio Mello --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h| 8 2 files

Re: [PATCH] drm/i915/display: Skip unavailable power wells based on pipe mask

2025-07-18 Thread Imre Deak
On Thu, Jul 17, 2025 at 09:02:45AM -0300, Gustavo Sousa wrote: > Quoting Chaitanya Kumar Borah (2025-07-17 02:16:03-03:00) > >Some power wells are only relevant for certain display pipes. Add a check > >to ensure we only allocate and initialize power wells whose associated > >pipes are available on

Re: [PATCH] iosys-map: Fix undefined behavior in iosys_map_clear()

2025-07-18 Thread Thomas Zimmermann
Hi Am 18.07.25 um 16:47 schrieb Andi Shyti: Hi Nitin, On Fri, Jul 18, 2025 at 04:20:51PM +0530, Nitin Gote wrote: The current iosys_map_clear() implementation reads the potentially uninitialized 'is_iomem' boolean field to decide which union member to clear. This causes undefined behavior when

Re: [PATCH v3 4/4] drm/i915: Use dedicated return variable in eb_relocate_vma()

2025-07-18 Thread Andi Shyti
Hi, On Fri, Jul 18, 2025 at 01:21:53PM +0200, Chris Wilson wrote: > Quoting Sebastian Brzezinka (2025-07-18 12:28:26) > > Introduce a separate `ret` variable to hold the return value in > > `eb_relocate_vma()`, instead of overloading `remain` for both loop > > control and error reporting. > > No

Re: [PATCH v3 3/4] drm/i915: Replace empty conditional with continue in eb_relocate_vma()

2025-07-18 Thread Andi Shyti
Hi Sebastian, On Fri, Jul 18, 2025 at 10:28:19AM +, Sebastian Brzezinka wrote: > Simplifies the control flow by replacing an empty > `if (likely(offset == 0))` block with a `continue` statement. This > improves readability and avoids unnecessary nesting. > > Signed-off-by: Sebastian Brzezinka

Re: [PATCH] iosys-map: Fix undefined behavior in iosys_map_clear()

2025-07-18 Thread Andi Shyti
Hi Nitin, On Fri, Jul 18, 2025 at 04:20:51PM +0530, Nitin Gote wrote: > The current iosys_map_clear() implementation reads the potentially > uninitialized 'is_iomem' boolean field to decide which union member > to clear. This causes undefined behavior when called on uninitialized > structures, as

Re: [PATCH v3 2/4] drm/i915: Replaced hardcoded value 4095 with PAGE_SIZE - 1

2025-07-18 Thread Andi Shyti
On Fri, Jul 18, 2025 at 01:16:58PM +0200, Chris Wilson wrote: > Quoting Sebastian Brzezinka (2025-07-18 12:28:11) > > The value 4095 is intended to represent PAGE_SIZE - 1, as stated > > in the commit that introduced this change: > > commit 5f22cc0b134a ("drm/i915: Fix mismatch between misplaced >

Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST

2025-07-18 Thread Ruben Wauters
On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > convert drm_mm selftest to KUnit) and all functions under it were > converted to KUnit, under the DRM_KUNIT_TEST option > > This conversion however did not occur in the

Re: [PATCH] drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM

2025-07-18 Thread Gustavo Sousa
Quoting Hogander, Jouni (2025-07-18 10:08:52-03:00) >On Fri, 2025-07-18 at 09:58 -0300, Gustavo Sousa wrote: >> Quoting Hogander, Jouni (2025-07-18 07:46:31-03:00) >> > On Fri, 2025-07-18 at 09:05 +0300, Hogander, Jouni wrote: >> > > On Thu, 2025-07-17 at 10:31 -0300, Gustavo Sousa wrote: >> > > >

Re: [PATCH] drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM

2025-07-18 Thread Hogander, Jouni
On Fri, 2025-07-18 at 09:58 -0300, Gustavo Sousa wrote: > Quoting Hogander, Jouni (2025-07-18 07:46:31-03:00) > > On Fri, 2025-07-18 at 09:05 +0300, Hogander, Jouni wrote: > > > On Thu, 2025-07-17 at 10:31 -0300, Gustavo Sousa wrote: > > > > Quoting Jouni Högander (2025-07-17 03:32:58-03:00) > > >

Re: [PATCH] drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM

2025-07-18 Thread Gustavo Sousa
Quoting Hogander, Jouni (2025-07-18 07:46:31-03:00) >On Fri, 2025-07-18 at 09:05 +0300, Hogander, Jouni wrote: >> On Thu, 2025-07-17 at 10:31 -0300, Gustavo Sousa wrote: >> > Quoting Jouni Högander (2025-07-17 03:32:58-03:00) >> > > We are seeing "dmesg-warn/abort - *ERROR* PHY * failed after 3 >>

Re: [PATCH v1 5/7] drm/ci: uprev IGT

2025-07-18 Thread Dmitry Baryshkov
On Fri, Jul 18, 2025 at 04:23:57PM +0530, Vignesh Raman wrote: > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman > --- > drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- > .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 2 + > .../drm/ci/xf

[PATCH v2 3/4] drm/i915/dp: Implement the POST_LT_ADJ_REQ sequence

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä Implement the POST_LT_ADJ_REQ sequence, which should be used to further fine tune the link if TPS4 is not supported. The POST_LT_ADJ_REQ sequence will be performed after the normal link training has succeeded. Only the final hop between the last LTTPR and DPRX will perform th

[PATCH v2 4/4] hax: drm/i915: Disable TPS4 support to force POST_LT_ADJ_REQ usage

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä Disable TPS4 in favor of POST_LT_ADJ_REQ for testing purposes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp_link_training.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/

[PATCH v2 1/4] drm/dp: Add definitions for POST_LT_ADJ training sequence

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä Add the bit definitions needed for POST_LT_ADJ sequence. v2: DP_POST_LT_ADJ_REQ_IN_PROGRESS is bit 1 not 5 (Jani) Tested-by: Imre Deak Reviewed-by: Imre Deak Signed-off-by: Ville Syrjälä --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH v2 2/4] drm/dp: Add POST_LT_ADJ_REQ helpers

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä Add small helpers (drm_dp_post_lt_adj_req_supported() and drm_dp_post_lt_adj_req_in_progress()) to help with implementing the POST_LT_ADJ_REQ sequence. Tested-by: Imre Deak Reviewed-by: Imre Deak Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/display/drm_dp_helper.c | 8

[PATCH v2 0/4] drm/i915/dp: Implement POST_LT_ADJ_REQ

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä Implement the POST_LT_ADJ_REQ sequence, which is supposed to be used to further tune the link vswing/pre-emphasis when TPS4 is not supported. Unfortunately I don't have any displays/dongles that support this so I wasn't able to test anything. Imre has tested this with a DP te

✗ Fi.CI.BUILD: failure for drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM (rev2)

2025-07-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM (rev2) URL : https://patchwork.freedesktop.org/series/151740/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/151740/revisions/2/mbox/ not applied A

Re: [PATCH] drm/xe/display: Block hpd during suspend

2025-07-18 Thread Maarten Lankhorst
Den 2025-07-18 kl. 07:21, skrev Dibin Moolakadan Subrahmanian: > On 17-07-2025 17:24, Maarten Lankhorst wrote: >> Hey, >> >> When I looked at enabling -RT for Xe yesterday, I noticed this trace. >> >> https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151626v2/shard-bmg-6/igt@kms_cursor_crc@cursor-s

[PATCH v2] drm/i915/dsi: Don't set/read the DSI C clock divider on GLK

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä GLK doesn't use the DSI C clock at all, no need to program the divider for it. Bspec even says: "Do not program this field". However looks like some firmware versions program this and some do not. In order to avoid bogus fastset mismatches we should also filter it out during

Re: [PATCH v3 4/4] drm/i915: Use dedicated return variable in eb_relocate_vma()

2025-07-18 Thread Chris Wilson
Quoting Sebastian Brzezinka (2025-07-18 12:28:26) > Introduce a separate `ret` variable to hold the return value in > `eb_relocate_vma()`, instead of overloading `remain` for both loop > control and error reporting. No need. -Chris

Re: [PATCH] drm/xe/display: Block hpd during suspend

2025-07-18 Thread Imre Deak
On Thu, Jul 17, 2025 at 01:54:49PM +0200, Maarten Lankhorst wrote: > Hey, > > When I looked at enabling -RT for Xe yesterday, I noticed this trace. > > https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151626v2/shard-bmg-6/igt@kms_cursor_crc@cursor-susp...@pipe-d-hdmi-a-3.html#dmesg-warnings488 >

Re: [PATCH v3 2/4] drm/i915: Replaced hardcoded value 4095 with PAGE_SIZE - 1

2025-07-18 Thread Chris Wilson
Quoting Sebastian Brzezinka (2025-07-18 12:28:11) > The value 4095 is intended to represent PAGE_SIZE - 1, as stated > in the commit that introduced this change: > commit 5f22cc0b134a ("drm/i915: Fix mismatch between misplaced > vma check and vma insert") No, that is exactly

[PATCH v1 7/7] drm/ci: add mt8192

2025-07-18 Thread Vignesh Raman
Add job that executes the IGT test suite for mt8192-asurada-spherion-r0. Signed-off-by: Deborah Brouwer Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/arm64.config | 4 +++ drivers/gpu/drm/ci/test.yml | 13 +-- .../drm/ci/xfails/mediatek-mt8192-fails.tx

[PATCH v1 6/7] drm/ci: add rk3588-rock-5b

2025-07-18 Thread Vignesh Raman
Add job that executes the IGT test suite for rk3588-rock-5b. Signed-off-by: Vignesh Raman --- MAINTAINERS | 1 + drivers/gpu/drm/ci/arm64.config | 5 drivers/gpu/drm/ci/build.sh | 1 + drivers/gpu/drm/ci/gitlab-ci.yml

[PATCH v1 5/7] drm/ci: uprev IGT

2025-07-18 Thread Vignesh Raman
Uprev IGT to the latest version and update expectation files. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 2 + .../drm/ci/xfails/amdgpu-stoney-flakes.txt| 7 ++ drivers/gpu/drm/ci/xfails/i915-aml

[PATCH v1 4/7] drm/ci: uprev mesa

2025-07-18 Thread Vignesh Raman
Uprev mesa to adapt to the latest changes in Mesa CI, including support for firmware via LAVA overlays, removal of the python-artifacts job, split container and build rules, use of the alpine container for LAVA jobs, and various misc fixes. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/bui

[PATCH v1 3/7] drm/ci: i915: cml: update runner tag

2025-07-18 Thread Vignesh Raman
asus-C436FA-Flip-hatch has fewer devices available in the LAVA lab and drm-ci uses only 2 DUTs, causing tests to time out. Update drm-ci to use puff instead of hatch so the tests can run on 5 DUTs. Also increase parallel count for amly jobs to 3. Signed-off-by: Vignesh Raman --- drivers/gpu/drm

[PATCH v1 2/7] drm/ci: reduce sm8350-hdk parallel jobs from 4 to 2

2025-07-18 Thread Vignesh Raman
The sm8350-hdk jobs are short and each test takes around 2–3 minutes and the full job completes in about 10 minutes. Running 4 parallel jobs uses 4 devices at once, which is not needed. Set parallel to 2 to reduce device usage. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/test.yml | 2 +-

[PATCH v1 1/7] drm/ci: disable apq8016 and apq8096 bare-metal jobs

2025-07-18 Thread Vignesh Raman
These devices are being moved to LAVA. The jobs will be enabled and the job definitions will be updated once the move is complete. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/test.yml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ci/test.yml b/

[PATCH v1 0/7] drm/ci: add new jobs, uprev IGT and mesa

2025-07-18 Thread Vignesh Raman
This series introduces new jobs to drm-ci for testing the following devices: - rk3588-rock-5b - mt8192-asurada-spherion-r0 Other updates include: - Uprev IGT and updating test expectations accordingly. - Adapting to recent changes in Mesa CI, such as: - LAVA overlay-based firmware handling -

Re: [PATCH] drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM

2025-07-18 Thread Hogander, Jouni
On Fri, 2025-07-18 at 09:05 +0300, Hogander, Jouni wrote: > On Thu, 2025-07-17 at 10:31 -0300, Gustavo Sousa wrote: > > Quoting Jouni Högander (2025-07-17 03:32:58-03:00) > > > We are seeing "dmesg-warn/abort - *ERROR* PHY * failed after 3 > > > retries" > > > since we started configuring LFPS send

[PATCH v3 4/4] drm/i915: Use dedicated return variable in eb_relocate_vma()

2025-07-18 Thread Sebastian Brzezinka
Introduce a separate `ret` variable to hold the return value in `eb_relocate_vma()`, instead of overloading `remain` for both loop control and error reporting. Signed-off-by: Sebastian Brzezinka --- v2 -> v3: - Split commit to isolate individual changes --- drivers/gpu/drm/i915/gem/i915_

[PATCH v3 3/4] drm/i915: Replace empty conditional with continue in eb_relocate_vma()

2025-07-18 Thread Sebastian Brzezinka
Simplifies the control flow by replacing an empty `if (likely(offset == 0))` block with a `continue` statement. This improves readability and avoids unnecessary nesting. Signed-off-by: Sebastian Brzezinka --- v2 -> v3 - Split commit to isolate individual changes --- .../gpu/drm/i915/gem/

[PATCH v3 2/4] drm/i915: Replaced hardcoded value 4095 with PAGE_SIZE - 1

2025-07-18 Thread Sebastian Brzezinka
The value 4095 is intended to represent PAGE_SIZE - 1, as stated in the commit that introduced this change: commit 5f22cc0b134a ("drm/i915: Fix mismatch between misplaced vma check and vma insert") Signed-off-by: Sebastian Brzezinka --- v2 -> v3: - Reword commit mess

[PATCH v3 1/4] drm/i915: Add braces around the else block in clflush_write32()

2025-07-18 Thread Sebastian Brzezinka
According to the kernel coding style, if only one branch of a conditional statement is a single statement, braces should still be used in both branches. Reviewed-by: Andi Shyti Reviewed-by: Krzysztof Karas Signed-off-by: Sebastian Brzezinka --- v2 -> v3: - Nothing has changed --- drive

[PATCH v3 0/4] i915_gem_execbuffer.c minor improved

2025-07-18 Thread Sebastian Brzezinka
While debugging, I identified and addressed a few minor issues and style inconsistencies that could be improved. I ran some tests on these changes, and pushed them to trybot first, no regressions were found. Sebastian Brzezinka (4): drm/i915: Add braces around the else block in clflush_write32(

[PATCH] iosys-map: Fix undefined behavior in iosys_map_clear()

2025-07-18 Thread Nitin Gote
The current iosys_map_clear() implementation reads the potentially uninitialized 'is_iomem' boolean field to decide which union member to clear. This causes undefined behavior when called on uninitialized structures, as 'is_iomem' may contain garbage values like 0xFF. UBSAN detects this as: UB

Re: [PATCH v2 1/3] drm/i915: Improve readability of eb_relocate_vma

2025-07-18 Thread Sebastian Brzezinka
Hi Krzysztof On Thu Jul 17, 2025 at 2:38 PM UTC, Krzysztof Karas wrote: > Hi Sebastian, > >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c >> @@ -1529,6 +1529,7 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, >> struct eb_vma *ev) >> struct drm_i915_gem_relocation_entry __use

Re: [PATCH v2 2/3] drm/i915: Add braces around the else block in clflush_write32()

2025-07-18 Thread Andi Shyti
Hi Sebastian, On Thu, Jul 17, 2025 at 12:38:47PM +, Sebastian Brzezinka wrote: > According to the kernel coding style, if only one branch of a > conditional statement is a single statement, braces should > still be used in both branches. > > Signed-off-by: Sebastian Brzezinka Reviewed-by: A