Re: [Intel-gfx] [PATCH v2 1/2] drm: Add color management LUT validation helper (v2)

2018-12-14 Thread Alexandru-Cosmin Gheorghe
Hi, On Thu, Dec 13, 2018 at 01:55:25PM -0800, Matt Roper wrote: > Some hardware may place additional restrictions on the gamma/degamma > curves described by our LUT properties. E.g., that a gamma curve never > decreases or that the red/green/blue channels of a LUT's entries must be > equal. Let'

Re: [Intel-gfx] [RFC v3 0/8] Add Plane Color Properties

2018-07-12 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Tue, Jun 12, 2018 at 04:01:31AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of > >Alexandru-Cosmin Gheorghe > >Sent: Monday, June 11, 2018 3:47 PM >

Re: [Intel-gfx] [PATCH 1/4] drm: Add P010, P012, P016 format definitions and fourcc

2018-10-02 Thread Alexandru-Cosmin Gheorghe
Hi, How is this going on, anything holding it back from getting merged ? I'm interested in adding/using P010, [1] Thank you, Alex Gheorghe [1] https://lists.freedesktop.org/archives/dri-devel/2018-August/186963.html On Thu, Aug 30, 2018 at 03:41:11PM +0300, Juha-Pekka Heikkila wrote: > Add P010

Re: [Intel-gfx] [PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

2018-10-02 Thread Alexandru-Cosmin Gheorghe
Hi, On Tue, Oct 02, 2018 at 02:15:42PM +0300, Stanislav Lisovskiy wrote: > v5: This is YUV444 packed format same as AYUV, but without alpha, > as supported by i915. > > v6: Removed unneeded initializer for new XYUV format. > > v7: Added is_yuv field initialization according to latest > d

Re: [Intel-gfx] [PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

2018-10-03 Thread Alexandru-Cosmin Gheorghe
On Wed, Oct 03, 2018 at 06:39:00AM +, Lisovskiy, Stanislav wrote: > On Tue, 2018-10-02 at 15:28 +0000, Alexandru-Cosmin Gheorghe wrote: > > Hi, > > > > On Tue, Oct 02, 2018 at 02:15:42PM +0300, Stanislav Lisovskiy wrote: > > > v5: This is YUV444 packed format s

Re: [Intel-gfx] [PATCH 1/4] drm: Add P010, P012, P016 format definitions and fourcc

2018-10-03 Thread Alexandru-Cosmin Gheorghe
e same question on the DRM_FORMAT_XYUV thread, do we need to wait for userspace to get new fourcc merged. > > https://lists.freedesktop.org/archives/intel-gfx/2018-September/174877.html > > /Juha-Pekka > > On 02.10.2018 18:00, Alexandru-Cosmin Gheorghe wrote: > >Hi, > > > >H

Re: [Intel-gfx] [PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

2018-10-04 Thread Alexandru-Cosmin Gheorghe
On Thu, Oct 04, 2018 at 12:04:57PM +, Lisovskiy, Stanislav wrote: > On Wed, 2018-10-03 at 08:07 +0000, Alexandru-Cosmin Gheorghe wrote: > > On Wed, Oct 03, 2018 at 06:39:00AM +, Lisovskiy, Stanislav wrote: > > > On Tue, 2018-10-02 at 15:28 +, Alexandru-Cosmin Gheorghe

Re: [Intel-gfx] [PATCH v3 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

2018-10-16 Thread Alexandru-Cosmin Gheorghe
Hi Swati, On Mon, Oct 15, 2018 at 01:39:54PM +0530, swatisha...@outlook.ms-acdc.office.com wrote: > From: Vidya Srinivas > > The following pixel formats are packed format that follows 4:2:2 > chroma sampling. For memory represenation each component is > allocated 16 bits each. Thus each pixel o

Re: [Intel-gfx] [PATCH v3 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

2018-10-16 Thread Alexandru-Cosmin Gheorghe
Hi Swati, On Mon, Oct 15, 2018 at 01:39:54PM +0530, swatisha...@outlook.ms-acdc.office.com wrote: Btw, I can't reply to this address. > From: Vidya Srinivas > > > The following pixel formats are packed format that follows 4:2:2 > chroma sampling. For memory represenation each component is > a

Re: [Intel-gfx] [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

2018-10-16 Thread Alexandru-Cosmin Gheorghe
On Tue, Oct 16, 2018 at 02:21:17PM +0200, Daniel Vetter wrote: > On Mon, Oct 15, 2018 at 04:11:41PM +, Deepak Singh Rawat wrote: > > > On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote: > > > > Selftest for drm damage helper iterator functions. > > > > > > > > Cc: ville.syrj...@linux

Re: [Intel-gfx] [PATCH v5 1/2] drm: Introduce new DRM_FORMAT_XYUV

2018-08-10 Thread Alexandru-Cosmin Gheorghe
Hi Stanislav, FYI, we are trying to add same format under a slightly different name. See https://lists.freedesktop.org/archives/dri-devel/2018-July/184598.html On Fri, Aug 10, 2018 at 04:19:03PM +0300, StanLis wrote: > From: Stanislav Lisovskiy > > v5: This is YUV444 packed format same as AYUV,

Re: [Intel-gfx] [RFC v4 1/8] drm: Add Enhanced Gamma LUT precision structure

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:44PM +0530, Uma Shankar wrote: > Existing LUT precision structure is having only 16 bit > precision. This is not enough for upcoming enhanced hardwares > and advance usecases like HDR processing. Hence added a new > structure with 32 bit precision values. Also

Re: [Intel-gfx] [RFC v4 2/8] drm: Add Plane Degamma properties

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:45PM +0530, Uma Shankar wrote: > Add Plane Degamma as a blob property and plane degamma size as > a range property. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to in

Re: [Intel-gfx] [RFC v4 3/8] drm: Add Plane CTM property

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:46PM +0530, Uma Shankar wrote: > Add a blob property for plane CSC usage. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to instantiate > these properties and removed f

Re: [Intel-gfx] [RFC v4 4/8] drm: Add Plane Gamma properties

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:47PM +0530, Uma Shankar wrote: > Add plane gamma as blob property and size as a > range property. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to instantiate > these

Re: [Intel-gfx] [RFC v4 5/8] drm: Define helper function for plane color enabling

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:48PM +0530, Uma Shankar wrote: > Define helper function to enable Plane color features > to attach plane color properties to plane structure. > > v2: Rebase > > v3: Modiefied the function to use updated property names. > > v4: Rebase > > Signed-off-by: Uma

Re: [Intel-gfx] [RFC v4 7/8] drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:50PM +0530, Uma Shankar wrote: > Implement Plane Gamma feature for BDW and Gen9 platforms. > > v2: Used newly added drm_color_lut_ext structure for enhanced > precision for Gamma LUT entries. > > v3: Rebase > > Signed-off-by: Uma Shankar > --- > drivers/g

Re: [Intel-gfx] [PATCH 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

2018-08-28 Thread Alexandru-Cosmin Gheorghe
Hi Swati, On Mon, Aug 27, 2018 at 12:17:45PM +0530, Swati Sharma wrote: > From: Vidya Srinivas > > The following pixel formats are packed format that follows 4:2:2 > chroma sampling. For memory represenation each component is > allocated 16 bits each. Thus each pixel occupies a DWORD. > > Y210:

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

2018-09-14 Thread Alexandru-Cosmin Gheorghe
gt; > > > Currently for userspace we have VLC(checked with Juha-Pekka) and > > > also IGT > > > test case. > > > > > > I think those guys were from ARM and they were adding also support > > > for > > > XYUV. The only difference was th

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

2018-09-17 Thread Alexandru-Cosmin Gheorghe
Hi, On Mon, Sep 17, 2018 at 08:27:18AM +, Lisovskiy, Stanislav wrote: > On Fri, 2018-09-14 at 14:59 +0000, Alexandru-Cosmin Gheorghe wrote: > > On Fri, Sep 14, 2018 at 02:49:09PM +, Lisovskiy, Stanislav wrote: > > > On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani

Re: [Intel-gfx] [RFC v5 0/8] Add Plane Color Properties

2018-09-18 Thread Alexandru-Cosmin Gheorghe
ok. Based on community feedback on interfaces, we will implement > IGT tests to validate plane color features. This is un-tested currently. > > Userspace implementation using these properties have been done in drm > hwcomposer by "Alexandru-Cosmin Gheorghe alexandru-cosmin.gheor...

Re: [Intel-gfx] [RFC v5 2/8] drm: Add Plane Degamma properties

2018-09-18 Thread Alexandru-Cosmin Gheorghe
Hi, On Sun, Sep 16, 2018 at 01:45:25PM +0530, Uma Shankar wrote: > Add Plane Degamma as a blob property and plane degamma size as > a range property. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to instan

Re: [Intel-gfx] [RFC v3 0/8] Add Plane Color Properties

2018-06-11 Thread Alexandru-Cosmin Gheorghe
Hi Uma, Any progress on userspace for this? I was thinking on working on using this in drm_hwcomposer. Thank you, Alex Gheorghe On Fri, Mar 09, 2018 at 11:47:41PM +0530, Uma Shankar wrote: > This patch series adds properties for plane color features. It adds > properties for degamma used to line

Re: [Intel-gfx] [RFC v3 0/8] Add Plane Color Properties

2018-06-14 Thread Alexandru-Cosmin Gheorghe
On Tue, Jun 12, 2018 at 04:01:31AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of > >Alexandru-Cosmin Gheorghe > >Sent: Monday, June 11, 2018 3:47 PM > >To: Shankar