Re: [PATCH] drm/i915/gt: Disarm breadcrumbs if engines are already idle

are no more engines awake, disarm the breadcrumb and go to sleep. Fixes: 9d5612ca165a ("drm/i915/gt: Defer enabling the breadcrumb interrupt to after submission") Closes: https://gitlab.freedesktop.org/drm/intel/issues/10026 Signed-off-by: Chris Wilson Cc: Andrzej Hajda Cc: # v5.12+ Signed-o

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

On 10.04.2024 16:14, Jani Nikula wrote: Surprisingly many places depend on debugfs.h to be included via drm_print.h. Fix them. Signed-off-by: Jani Nikula --- Reviewed-by: Andrzej Hajda Regards Andrzej Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc

Re: [Intel-gfx] [PATCH v5 0/7] Introduce __xchg, non-atomic xchg

On 05.04.2024 16:47, Jani Nikula wrote: On Mon, 27 Feb 2023, Peter Zijlstra wrote: On Thu, Feb 23, 2023 at 10:24:19PM +0100, Andrzej Hajda wrote: On 22.02.2023 18:04, Peter Zijlstra wrote: On Wed, Jan 18, 2023 at 04:35:22PM +0100, Andrzej Hajda wrote: Andrzej Hajda (7): arch: rename

Re: [PATCH 3/3] drm/i915: Pin error_capture to high end of mappable

On 15.12.2023 12:09, Ville Syrjala wrote: From: Ville Syrjälä If we fail to pin error_capture to the start of ggtt (which is likely given the BIOS fb is usually there), we currently fall back to pinning it at the next available low address. This seems somewhat sub-optimal to me in case we later

Re: [PATCH 2/3] drm/i915/hdcp: Pin the hdcp gsc message high in ggtt

needlessly wasting the precious mappable range for it. Cc: Suraj Kandpal Cc: Alan Previn Cc: Uma Shankar Signed-off-by: Ville Syrjälä Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH 1/3] drm/i915/hdcp: Do intel_hdcp_component_init() much later during init

no one else has stolen them yet) is done. Cc: Suraj Kandpal Cc: Alan Previn Cc: Uma Shankar Signed-off-by: Ville Syrjälä Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/display/intel_display_driver.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) d

Re: [PATCH v2 05/15] drm/i915: Disable the "binder"

On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä Now that the GGTT PTE updates go straight to GSMBASE (bypassing GTTMMADR) there should be no more risk of system hangs? So the "binder" (ie. update the PTEs via MI_UPDATE_GTT) is no longer necessary, disable it. TODO: MI_UPDATE_GTT

Re: [PATCH v2 15/15] drm/i915: Try to relocate the BIOS fb to the start of ggtt

ust add another elseif branch here? Maybe abstracting out somehow surface registers writes? Just loose ideas. However I wouldn't be surprised if there is good reason to keep it as is. Reviewed-by: Andrzej Hajda Regards Andrzej + + return true; +} diff --git a/drivers/gpu/drm/i915/displ

Re: [PATCH v2 14/15] drm/i915: Tweak BIOS fb reuse check

Signed-off-by: Ville Syrjälä Reviewed-by: Andrzej Hajda Regards Andrzej --- .../drm/i915/display/intel_plane_initial.c| 34 +++ 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_plane_initial.c b/drivers/gpu/drm/i9

Re: [PATCH v2 04/15] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

oonas Lahtinen Signed-off-by: Ville Syrjälä With w/a id added: Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 11 ++- drivers/gpu/drm/i915/gt/intel_ggtt.c | 13 - 2 files changed, 22 insertions(+), 2 deletions(-) diff --

Re: [PATCH v2 13/15] drm/i915/fbdev: Fix smem_start for LMEMBAR stolen objects

BAR stolen objects region.start!=0. TODO: perhaps just set smem_start=0 always as our .fb_mmap() implementation no longer depends on it? Need to double check it's not needed for anything else... Cc: Paz Zcharya Signed-off-by: Ville Syrjälä Reviewed-by: Andrzej Hajda Regards Andrzej ---

Re: [PATCH] drm/i915: don't make assumptions about intel_wakeref_t type

rnel.org/r/20240102111222.2db11...@canb.auug.org.au Fixes: b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library") Cc: Andrzej Hajda Cc: Imre Deak Signed-off-by: Jani Nikula Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/display/i

Re: [PATCH v2 12/15] drm/i915: Simplify intel_initial_plane_config() calling convention

ed-by: Andrzej Hajda Regards Andrzej --- .../drm/i915/display/intel_display_driver.c | 7 +--- .../drm/i915/display/intel_plane_initial.c| 40 +++ .../drm/i915/display/intel_plane_initial.h| 4 +- 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/driver

Re: [PATCH v2 09/15] drm/i915: Fix MTL initial plane readout

On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä MTL stolen memory looks more like local memory, so use the (now fixed) lmem path when doing the initial plane readout. Cc: Paz Zcharya Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_plane_initial.c| 25 +

Re: [PATCH v2 10/15] drm/i915: s/phys_base/dma_addr/

On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä The address we read from the PTE is a dma address, not a physical address. Rename the variable to say so. Cc: Paz Zcharya Signed-off-by: Ville Syrjälä Reviewed-by: Andrzej Hajda Regards Andrzej --- .../gpu/drm/i915/display

Re: [PATCH v2 11/15] drm/i915: Split the smem and lmem plane readout apart

ttern "ggtt->gsm + offset / I915_GTT_PAGE_SIZE" is present in multiple places and depends on hw gen, but maybe it is another patch. No strong feelings. Reviewed-by: Andrzej Hajda Regards Andrzej Regards Andrzej --- .../drm/i915/display/intel_display_types.h| 2 + ..

Re: [PATCH v2 08/15] drm/i915: Fix region start during initial plane readout

On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä On MTL the stolen region starts at offset 8MiB from the start of LMEMBAR. The dma addresses are thus also offset by 8MiB. However the mm_node/etc. is zero based, and i915_pages_create_for_stolen() will add the appropriate region.star

Re: [PATCH v2 07/15] drm/i915: Fix PTE decode during initial plane readout

: Paz Zcharya Signed-off-by: Ville Syrjälä Helper can be useful (but I guess not many users atm). The change looks correct anyway. Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/display/intel_plane_initial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH v2 06/15] drm/i915: Rename the DSM/GSM registers

On 15.12.2023 11:59, Ville Syrjala wrote: From: Ville Syrjälä 0x108100 and 0x1080c0 have been around since snb. Rename the defines appropriately. Cc: Paz Zcharya Signed-off-by: Ville Syrjälä Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c

Re: â Fi.CI.BAT: failure for drm/i915: (stolen) memory region related fixes

On 13.12.2023 17:13, Andrzej Hajda wrote: On 13.12.2023 02:37, Patchwork wrote: *Patch Details* *Series:*    drm/i915: (stolen) memory region related fixes *URL:*    https://patchwork.freedesktop.org/series/127721/ <https://patchwork.freedesktop.org/series/127721/> *State:*    f

Re: â Fi.CI.BAT: failure for drm/i915: (stolen) memory region related fixes

On 13.12.2023 02:37, Patchwork wrote: *Patch Details* *Series:* drm/i915: (stolen) memory region related fixes *URL:* https://patchwork.freedesktop.org/series/127721/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/dr

Re: [PATCH 03/12] drm/i915: Remove ad-hoc lmem/stolen debugs

On 13.12.2023 01:42, Ville Syrjala wrote: From: Ville Syrjälä Now that intel_memory_regions_hw_probe() prints out each and every memory region there's no reason to have ad-hoc debugs to do similar things elsewhere. Signed-off-by: Ville Syrjälä Reviewed-by: Andrzej Hajda Regards An

Re: [PATCH 02/12] drm/i915: Print memory region info during probe

Memory region(%d): %s: %llu MiB %pR, io: n/a\n", + mem->id, mem->name, region_size, &mem->region); Doesn't printk handle properly 0-length resources? Reviewed-by: Andrzej Hajda Regards Andrzej + } + return 0; out_cleanup:

Re: [PATCH 01/12] drm/i915: Use struct resource for memory region IO as well

intel_memory_region_ops *ops); With or without this change: Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/display/intel_fbdev_fb.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_region.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 17 +--

Re: [Intel-gfx] [PATCH] drm/i915/display: do not use cursor size reduction on MTL

On 24.11.2023 08:53, Andrzej Hajda wrote: Cursor size reduction is not supported since MTL. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Gently ping. CC: maintainers Regards Andrzej diff

Re: [Intel-gfx] â Fi.CI.BAT: failure for drm/i915/display: Check GGTT to determine phys_base (rev2)

On 07.12.2023 12:26, Andrzej Hajda wrote: On 07.12.2023 11:10, Andrzej Hajda wrote: On 07.12.2023 01:18, Patchwork wrote: *Patch Details* *Series:*    drm/i915/display: Check GGTT to determine phys_base (rev2) *URL:*    https://patchwork.freedesktop.org/series/127130/ <ht

Re: [Intel-gfx] â Fi.CI.BAT: failure for drm/i915/display: Check GGTT to determine phys_base (rev2)

On 07.12.2023 11:10, Andrzej Hajda wrote: On 07.12.2023 01:18, Patchwork wrote: *Patch Details* *Series:*    drm/i915/display: Check GGTT to determine phys_base (rev2) *URL:*    https://patchwork.freedesktop.org/series/127130/ <https://patchwork.freedesktop.org/series/127130/>

Re: [Intel-gfx] â Fi.CI.BAT: failure for drm/i915/display: Check GGTT to determine phys_base (rev2)

On 07.12.2023 01:18, Patchwork wrote: *Patch Details* *Series:* drm/i915/display: Check GGTT to determine phys_base (rev2) *URL:* https://patchwork.freedesktop.org/series/127130/ *State:*failure *Details:* https://intel-gfx-ci.01

[Intel-gfx] [PATCH v2] drm/i915/selftests: wait for active idle event in i915_active_unlock_wait

*ERROR* pulsepreallocated barriers? no To prevent it let's wait explicitly for idleness. v2: wait only in live_idle tests Signed-off-by: Andrzej Hajda --- - Link to v1: https://lore.kernel.org/r/20231128-selftest_wait_for_active_idle_event-v1-1-e365cb8b2...@intel.com --- drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915/display: Check GGTT to determine phys_base

On 30.11.2023 17:16, Paz Zcharya wrote: There was an assumption that for iGPU there should be a 1:1 mapping of GGTT to physical address pointing to actual framebuffer. This assumption is not valid anymore for MTL. Fix that by checking GGTT to determine the phys address. The following algorith

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

error or not. Cc: Tvrtko Ursulin Cc: John Harrison Cc: Andi Shyti Cc: Andrzej Hajda Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5591 Signed-off-by: Nirmoy Das --- Reviewed-by: Andrzej Hajda Regards Andrzej drivers/gpu/drm/i915/gt/intel_reset.c | 8 1 file changed, 4

[Intel-gfx] [PATCH] drm/i915/selftests: wait for active idle event in i915_active_unlock_wait

*ERROR* pulsepreallocated barriers? no To prevent it let's wait explicitly for idleness. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/selftests/i915_active.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/i915_active.c b/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

On 28.11.2023 04:47, Paz Zcharya wrote: On Mon, Nov 27, 2023 at 8:20 PM Paz Zcharya wrote: On 21.11.2023 13:06, Andrzej Hajda wrote: On 18.11.2023 00:01, Paz Zcharya wrote: On Tue, Nov 14, 2023 at 10:13:59PM -0500, Rodrigo Vivi wrote: On Sun, Nov 05, 2023 at 05:27:03PM +, Paz Zcharya

[Intel-gfx] [PATCH] drm/i915/display: do not use cursor size reduction on MTL

Cursor size reduction is not supported since MTL. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

On 21.11.2023 13:06, Andrzej Hajda wrote: On 18.11.2023 00:01, Paz Zcharya wrote: On Tue, Nov 14, 2023 at 10:13:59PM -0500, Rodrigo Vivi wrote: On Sun, Nov 05, 2023 at 05:27:03PM +, Paz Zcharya wrote: Fix the value of variable `phys_base` to be the relative offset in stolen memory, and

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

On 18.11.2023 00:01, Paz Zcharya wrote: On Tue, Nov 14, 2023 at 10:13:59PM -0500, Rodrigo Vivi wrote: On Sun, Nov 05, 2023 at 05:27:03PM +, Paz Zcharya wrote: Fix the value of variable `phys_base` to be the relative offset in stolen memory, and not the absolute offset of the GSM. to me it

Re: [Intel-gfx] â Fi.CI.IGT: success for drm/i915: use ref_tracker library in i915 (rev4)

On 18.11.2023 04:21, Patchwork wrote: *Patch Details* *Series:* drm/i915: use ref_tracker library in i915 (rev4) *URL:* https://patchwork.freedesktop.org/series/125770/ *State:*success *Details:* https://intel-gfx-ci.01.org/tree/

Re: [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

On 16.11.2023 12:45, Andi Shyti wrote: Hi Andrzej, On Wed, Nov 15, 2023 at 01:10:33PM +0100, Andrzej Hajda wrote: Trace requires new-line at the end of message (in opposition to printk), otherwise trace dump becomes messy. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thx all

Re: [Intel-gfx] [PATCH v2] drm/i915: do not clean GT table on error path

On 16.11.2023 12:44, Andi Shyti wrote: Hi Andrzej, On Wed, Nov 15, 2023 at 11:54:03AM +0100, Andrzej Hajda wrote: The only task of intel_gt_release_all is to zero gt table. Calling it on error path prevents intel_gt_driver_late_release_all (called from i915_driver_late_release) to cleanup

Re: [Intel-gfx] [PATCH v3] debugobjects: stop accessing objects after releasing spinlock

On 25.10.2023 23:39, Andrzej Hajda wrote: After spinlock release object can be modified/freed by concurrent thread. Using it in such case is error prone, even for printing object state. To avoid such situation local copy of the object is created if necessary. Sample buggy scenario: 1. Thread

[Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

Trace requires new-line at the end of message (in opposition to printk), otherwise trace dump becomes messy. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b

[Intel-gfx] [PATCH v2] drm/i915: do not clean GT table on error path

: bec68cc9ea42d8 ("drm/i915: Prepare for multiple GTs") Signed-off-by: Andrzej Hajda --- - Link to v1: https://lore.kernel.org/r/20231114-dont_clean_gt_on_error_path-v1-1-37f2fa827...@intel.com --- drivers/gpu/drm/i915/gt/intel_gt.c | 11 --- drivers/gpu/drm/i915/i915_driver.c |

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: do not clean GT table on error path

On 14.11.2023 17:30, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915: do not clean GT table on error path *URL:* https://patchwork.freedesktop.org/series/126385/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/i

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

On 13.11.2023 10:37, Mika Kahola wrote: At least one TGL had regression when using u8 types for entry setup frames calculation. So, let's switch to use ints instead. This explanation is missing the most important part - why int? I guess it is because intel_psr_entry_setup_frames can return -ET

[Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path

e for multiple GTs") Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/i915_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index 80e85cadb9a262..428ace0bebaac9 100644 --- a/drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Increase guard pages when vt-d is enabled

Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Increase guard pages when vt-d is enabled On 02/11/2023 16:58, Andrzej Hajda wrote: On 02.11.2023 17:06, Radhakrishna Sripada wrote: Experiments were conducted with different multipliers to VTD_GUARD macro with multiplier of 185 we were observing

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Increase guard pages when vt-d is enabled

On 02.11.2023 17:06, Radhakrishna Sripada wrote: Experiments were conducted with different multipliers to VTD_GUARD macro with multiplier of 185 we were observing occasional pipe faults when running kms_cursor_legacy --run-subtest single-bo There could possibly be an underlying issue that is bei

Re: [Intel-gfx] â Fi.CI.BAT: failure for drm/i915: use ref_tracker library in i915 (rev2)

On 31.10.2023 23:33, Patchwork wrote: *Patch Details* *Series:* drm/i915: use ref_tracker library in i915 (rev2) *URL:* https://patchwork.freedesktop.org/series/125770/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/

Re: [Intel-gfx] [PATCH v6 0/4] Apply Wa_16018031267 / Wa_16018063123

On 26.10.2023 20:36, Andrzej Hajda wrote: Hi all, This the series from Jonathan: [PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123 taken over by me. This patchset requires IGT changes fixing handling gtt sizes not being power of 2: https://patchwork.freedesktop.org/series/125640/ Changes

Re: [Intel-gfx] â Fi.CI.IGT: failure for debugobjects: stop accessing objects after releasing spinlock (rev3)

On 27.10.2023 09:26, Patchwork wrote: *Patch Details* *Series:* debugobjects: stop accessing objects after releasing spinlock (rev3) *URL:* https://patchwork.freedesktop.org/series/124185/ *State:*failure *Details:* https://intel-gfx-

[Intel-gfx] [PATCH 1/2] drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library

Beside reusing existing code, the main advantage of ref_tracker is tracking per instance of wakeref. It allows also to catch double put. On the other side we lose information about the first acquire and the last release, but the advantages outweigh it. Signed-off-by: Andrzej Hajda Reviewed-by

[Intel-gfx] [PATCH 2/2] drm/i915: Track gt pm wakerefs

added calls in gen8_ggtt_bind_get_ce and destroyed_worker_func Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/Kconfig.debug | 14 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 14 .../drm/i915/gem/selftests

[Intel-gfx] [PATCH 0/2] drm/i915: use ref_tracker library in i915

-track_gt-v8-0-4b6517e61...@intel.com Signed-off-by: Andrzej Hajda --- Andrzej Hajda (2): drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library drm/i915: Track gt pm wakerefs drivers/gpu/drm/i915/Kconfig.debug | 18 ++ drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH] i915/perf: Fix NULL deref bugs with drm_dbg() calls

river specific drm_dbg call") Signed-off-by: Harshit Mogalapalli Reviewed-by: Andrzej Hajda Regards Andrzej --- This is found using smatch(static analysis tool), only compile tested. --- drivers/gpu/drm/i915/i915_perf.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) di

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Apply Wa_16018031267 / Wa_16018063123 (rev2)

On 27.10.2023 10:32, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Apply Wa_16018031267 / Wa_16018063123 (rev2) *URL:* https://patchwork.freedesktop.org/series/125650/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125650v2/in

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Apply Wa_16018031267 / Wa_16018063123

Hi, On 27.10.2023 07:34, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Apply Wa_16018031267 / Wa_16018063123 *URL:* https://patchwork.freedesktop.org/series/125650/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125650v1/index.

[Intel-gfx] [PATCH v6 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3

[Intel-gfx] [PATCH v6 3/4] drm/i915/gt: add selftest to exercise WABB

Test re-uses logic form indirect ctx BB selftest. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 -- 1 file changed, 47 insertions(+), 18 deletions

[Intel-gfx] [PATCH v6 2/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

Apply WABB blit for Wa_16018031267 / Wa_16018063123. v3: drop unused enum definition v4: move selftest to separate patch, use wa only on BCS0. v5: fixed selftest caller to context_wabb Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi

[Intel-gfx] [PATCH v6 1/4] drm/i915: Reserve some kernel space per vm

ned-off-by: Andrzej Hajda Reviewed-by: Jonathan Cavitt Reviewed-by: Nirmoy Das Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 43 drivers/gpu/drm/i915/gt/intel_gtt.h | 4 2 files changed, 47 insertions(+) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH v6 0/4] Apply Wa_16018031267 / Wa_16018063123

allocation v6: - decresase vm->total by reserved size Regards Andrzej Andrzej Hajda (1): drm/i915: Reserve some kernel space per vm Jonathan Cavitt (3): drm/i915: Enable NULL PTE support for vm scratch drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 drm/i915: Set copy eng

[Intel-gfx] [PATCH v3] debugobjects: stop accessing objects after releasing spinlock

ad reports error for wrong object. Signed-off-by: Andrzej Hajda --- v2: add missing switch breaks v3: abandon single-point-of-unlock approach --- lib/debugobjects.c | 196 + 1 file changed, 77 insertions(+), 119 deletions(-) diff --git a/lib/debu

Re: [Intel-gfx] [PATCH v2] drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init

~~ v2: use kasprintf(Imre) Fixes: 3eafcddf766b ("drm/i915/tc: Move TC port fields to a new intel_tc_port struct") Cc: Mika Kahola Cc: Imre Deak Cc: Jani Nikula Signed-off-by: Nirmoy Das Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/display/intel_tc.c | 9

[Intel-gfx] [PATCH v5 1/4] drm/i915: Reserve some kernel space per vm

Reserve one page in each vm for kernel space to use for things such as workarounds. v2: use real memory, do not decrease vm.total v4: reserve only one page and explain flag v5: remove allocated object on ppgtt cleanup Suggested-by: Chris Wilson Signed-off-by: Andrzej Hajda Reviewed-by

[Intel-gfx] [PATCH v5 3/4] drm/i915/gt: add selftest to exercise WABB

Test re-uses logic form indirect ctx BB selftest. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 -- 1 file changed, 47 insertions(+), 18 deletions

[Intel-gfx] [PATCH v5 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3

[Intel-gfx] [PATCH v5 2/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

Apply WABB blit for Wa_16018031267 / Wa_16018063123. v3: drop unused enum definition v4: move selftest to separate patch, use wa only on BCS0. v5: fixed selftest caller to context_wabb Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Andi

[Intel-gfx] [PATCH v5 0/4] Apply Wa_16018031267 / Wa_16018063123

: - fixed typos, - removed spare defs, - added tags v4: - removed NULL PTE patch, - separate selftest to separate patch, - use BB only on BCS0 v5: - fixed reserved memory allocation Regards Andrzej Andrzej Hajda (1): drm/i915: Reserve some kernel space per vm Jonathan Cavitt (3): drm/i915: Enable

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Apply notify_guc to all GTs

n Harrison Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Andi Shyti Cc: Andrzej Hajda Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_debugfs_params.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c b/

[Intel-gfx] [PATCH v4 3/4] drm/i915/gt: add selftest to exercise WABB

Test re-uses logic form indirect ctx BB selftest. Co-developed-by: Nirmoy Das Co-developed-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 -- 1 file changed, 47 insertions(+), 18 deletions(-) diff --git a

[Intel-gfx] [PATCH v4 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH v4 1/4] drm/i915: Reserve some kernel space per vm

Reserve one page in each vm for kernel space to use for things such as workarounds. v2: use real memory, do not decrease vm.total v4: reserve only one page and explain flag Suggested-by: Chris Wilson Signed-off-by: Andrzej Hajda Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v4 2/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

Apply WABB blit for Wa_16018031267 / Wa_16018063123. v3: drop unused enum definition v4: move selftest to separate patch, use wa only on BCS0. Co-developed-by: Nirmoy Das Co-developed-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3

[Intel-gfx] [PATCH v4 0/4] Apply Wa_16018031267 / Wa_16018063123

: - fixed typos, - removed spare defs, - added tags v4: - removed NULL PTE patch, - separate selftest to separate patch, - use BB only on BCS0 Regards Andrzej Andrzej Hajda (1): drm/i915: Reserve some kernel space per vm Jonathan Cavitt (3): drm/i915: Enable NULL PTE support for vm scratch drm

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

On 23.10.2023 11:05, Nirmoy Das wrote: On 10/23/2023 9:41 AM, Andrzej Hajda wrote: From: Jonathan Cavitt Apply WABB blit for Wa_16018031267 / Wa_16018063123. Should this be split into two patches, one that adds per_ctx wabb and another where this WA is applied on top of per_ctx BB

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

On 23.10.2023 11:55, Nirmoy Das wrote: Hi Andrzej, On 10/23/2023 9:41 AM, Andrzej Hajda wrote: From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Reviewed

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915: Enable NULL PTE support for vm scratch

On 23.10.2023 14:23, Nirmoy Das wrote: On 10/23/2023 9:41 AM, Andrzej Hajda wrote: From: Jonathan Cavitt Enable NULL PTE support for vm scratch pages. The use of NULL PTEs in vm scratch pages requires us to change how the i915 gem_contexts live selftest perform vm_isolation: instead of

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Reserve some kernel space per vm

On 23.10.2023 10:49, Nirmoy Das wrote: Hi Andrzej, On 10/23/2023 9:41 AM, Andrzej Hajda wrote: Reserve two pages in each vm for kernel space to use for things such as workarounds. v2: use real memory, do not decrease vm.total Suggested-by: Chris Wilson Signed-off-by: Andrzej Hajda Reviewed

Re: [Intel-gfx] [PATCH v3 0/4] Apply Wa_16018031267 / Wa_16018063123

On 23.10.2023 10:38, Nirmoy Das wrote: Hi Andrzej On 10/23/2023 9:41 AM, Andrzej Hajda wrote: Hi all, This the series from Jonathan: [PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123 taken over by me. Changes in this version are described in the patches, in short: v2: - use real

[Intel-gfx] [PATCH v3 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 2/4] drm/i915: Reserve some kernel space per vm

Reserve two pages in each vm for kernel space to use for things such as workarounds. v2: use real memory, do not decrease vm.total Suggested-by: Chris Wilson Signed-off-by: Andrzej Hajda Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 38

[Intel-gfx] [PATCH v3 3/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

From: Jonathan Cavitt Apply WABB blit for Wa_16018031267 / Wa_16018063123. Additionally, update the lrc selftest to exercise the new WABB changes. v3: drop unused enum definition Co-developed-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda Reviewed-by: Jonathan

[Intel-gfx] [PATCH v3 1/4] drm/i915: Enable NULL PTE support for vm scratch

t all changes to the scratch pages are voided. v2: fixed order of definitions v3: fixed typo Signed-off-by: Jonathan Cavitt Suggested-by: Chris Wilson Signed-off-by: Andrzej Hajda Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 ++ drivers/gpu/drm/i9

[Intel-gfx] [PATCH v3 0/4] Apply Wa_16018031267 / Wa_16018063123

: - fixed typos, - removed spare defs, - added tags Regards Andrzej Andrzej Hajda (1): drm/i915: Reserve some kernel space per vm Jonathan Cavitt (3): drm/i915: Enable NULL PTE support for vm scratch drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 drm/i915: Set copy engine

[Intel-gfx] [PATCH v2 3/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

From: Jonathan Cavitt Apply WABB blit for Wa_16018031267 / Wa_16018063123. Additionally, update the lrc selftest to exercise the new WABB changes. Co-developed-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3

[Intel-gfx] [PATCH v2 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +++

[Intel-gfx] [PATCH v2 1/4] drm/i915: Enable NULL PTE support for vm scratch

t all changes to the scratch pages are voided. v2: fixed order of definitions Signed-off-by: Jonathan Cavitt Suggested-by: Chris Wilson Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 ++ drivers/gpu/drm/i915/gt/gen8_ppgtt.c

[Intel-gfx] [PATCH v2 2/4] drm/i915: Reserve some kernel space per vm

Reserve two pages in each vm for kernel space to use for things such as workarounds. v2: use real memory, do not decrease vm.total Suggested-by: Chris Wilson Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 38 drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v2 0/4] Apply Wa_16018031267 / Wa_16018063123

Andrzej Andrzej Hajda (1): drm/i915: Reserve some kernel space per vm Jonathan Cavitt (3): drm/i915: Enable NULL PTE support for vm scratch drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123 .../drm/i915

Re: [Intel-gfx] [PATCH v2] debugobjects: stop accessing objects after releasing spinlock

On 13.10.2023 15:15, Thomas Gleixner wrote: On Mon, Sep 25 2023 at 15:13, Andrzej Hajda wrote: After spinlock release object can be modified/freed by concurrent thread. Using it in such case is error prone, even for printing object state. It cannot be freed. If that happens then the calling

Re: [Intel-gfx] [PATCH v12 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

On 20.09.2023 23:07, Jonathan Cavitt wrote: Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/gt

Re: [Intel-gfx] [PATCH v12 3/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

On 20.09.2023 23:07, Jonathan Cavitt wrote: Apply WABB blit for Wa_16018031267 / Wa_16018063123. Additionally, update the lrc selftest to exercise the new WABB changes. Co-developed-by: Nirmoy Das Signed-off-by: Jonathan Cavitt > --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 + driv

Re: [Intel-gfx] [PATCH v12 2/4] drm/i915: Reserve some kernel space per vm

On 20.09.2023 23:07, Jonathan Cavitt wrote: Reserve two pages in each vm for kernel space to use for things such as workarounds. Signed-off-by: Jonathan Cavitt Suggested-by: Chris Wilson --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 7 +++ drivers/gpu/drm/i915/gt/intel_gtt.h | 1 + 2 fil

Re: [Intel-gfx] [PATCH v12 1/4] drm/i915: Enable NULL PTE support for vm scratch

vice_info.h @@ -162,6 +162,7 @@ enum intel_ppgtt_type { func(has_mslice_steering); \ func(has_oa_bpc_reporting); \ func(has_oa_slice_contrib_limits); \ + func(has_null_page); \ ditto Beside this: Reviewed-by: Andrzej Hajda Btw do you want/have time to continue working on the

Re: [Intel-gfx] [PATCH v2] debugobjects: stop accessing objects after releasing spinlock

On 25.09.2023 15:13, Andrzej Hajda wrote: After spinlock release object can be modified/freed by concurrent thread. Using it in such case is error prone, even for printing object state. To avoid such situation local copy of the object is created if necessary. Signed-off-by: Andrzej Hajda

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove xehpsdv support

/gpu/drm/i915/intel_step.c | 10 --- 17 files changed, 8 insertions(+), 232 deletions(-) Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Remove incomplete PVC plumbing

| 142 -- drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 - 18 files changed, 10 insertions(+), 432 deletions(-) Nice diffstat. Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove early/pre-production Haswell code

On 06.10.2023 10:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It is not our policy to keep pre-production hardware support for this long so I guess this one was just forgotten. Signed-off-by: Tvrtko Ursulin Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v7 4/4] drm/i915/mtl: Skip MCR ops for ring fault register

ent. v4: improve the comment further(Andi) Signed-off-by: Nirmoy Das Reviewed-by: Matt Roper Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.c | 13 - drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/i915_gpu_er

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915: Introduce the intel_gt_resume_early()

On 28.09.2023 15:00, Nirmoy Das wrote: Move early resume functions of gt to a proper file. Signed-off-by: Nirmoy Das Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 6 ++ drivers/gpu/drm/i915/gt/intel_gt_pm.h | 1 + drivers/gpu/drm/i915

  1   2   3   4   5   6   7   8   9   >