Re: [Intel-gfx] [PATCH 18/23] drm/sti: Convert to CRTC VBLANK callbacks

ink that the include could also be removed. Anyway that looks for me: Acked-by: Benjamin Gaignard Thanks, Benjamin > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/sti/sti_crtc.c | 11 --- > drivers/gpu/drm/sti/sti_crtc.h | 2 -- > drivers/gpu/drm/sti/sti_drv.c

Re: [Intel-gfx] [PATCH v2 0/4] drm/rect: Bugfixes and selftests

On 11/22/19 6:56 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > My earlier fixes for drm_rect + div-by-zero fix + some > selftests that Daniel requested. > > Cc: Maarten Lankhorst > Cc: Benjamin Gaignard > Cc: Daniel Vetter Thanks to have handle this. Review

Re: [Intel-gfx] [PATCH 2/2] drm/rect: Keep the clipped dst rectangle in place

rce rectangle such >>> that it can't have negative dimensions doing the same for the >>> dst rectangle seems appropriate. Should at least result in >>> the clipped src and dst rectangles being a bit more consistent >>> with each other. >>> >>> Cc: B

Re: [Intel-gfx] [PATCH v6 16/24] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

Le ven. 26 juil. 2019 à 19:27, Andrzej Pietrasiewicz a écrit : > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Benjamin Gaignard > --- > drivers/gpu/drm/sti/sti_hdmi.c | 6 -- > 1 file changed, 4 inser

Re: [Intel-gfx] [PATCH v4 15/23] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

Le jeu. 11 juil. 2019 à 13:30, Andrzej Pietrasiewicz a écrit : > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Benjamin Gaignard > --- > drivers/gpu/drm/sti/sti_hdmi.c | 1 + > 1 file changed, 1 insertio

Re: [Intel-gfx] [PATCH v2 04/14] drm/sti: Try to fix up the tvout possible clones

t hda+hdmi cloning, but then > dvo also claims to be cloneable with hdmi, but hdmi won't recipricate. > > Benjamin tells me all encoders should be cloneable with each other, > so let's fix up the masks to indicate that. > Applied on drm-misc-next, Thanks, Benjamin >

Re: [Intel-gfx] [PATCH v2 03/14] drm/sti: Remove pointless casts

Le lun. 8 juil. 2019 à 18:21, Ville Syrjala a écrit : > > From: Ville Syrjälä > > There's no point in the cast for accessing the base class. Just > take the address of the struct instead. Applied on drm-misc-next, Thanks, Benjamin > > Cc: Benjamin Gaignard > C

Re: [Intel-gfx] [PATCH 29/59] drm/sti: Drop drm_gem_prime_export/import

Le ven. 14 juin 2019 à 22:36, Daniel Vetter a écrit : > > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Benjamin Gaignard > Cc: Vincent Abriou Thanks

Re: [Intel-gfx] [PATCH] drm/crc-debugfs: Also sprinkle irqrestore over early exits

"drm/crc-debugfs: User irqsafe spinlock in > > drm_crtc_add_crc_entry") > > Cc: Rodrigo Siqueira > > Cc: Tomeu Vizoso > > Cc: Emil Velikov > > Cc: Benjamin Gaignard > > Cc: Ville Syrjälä > > Signed-off-by: Daniel Vetter > > Reviewed-by: Emil Velikov

Re: [Intel-gfx] [PATCH] drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry

t; normal worker. Which really upsets lockdep. > > > > Cc: Rodrigo Siqueira > > Cc: Tomeu Vizoso > > Cc: Emil Velikov > > Cc: Benjamin Gaignard > > Signed-off-by: Daniel Vetter > > Reviewed-by: Ville Syrjälä Reviewed-by: Benjamin Gaignard > >

Re: [Intel-gfx] [PATCH 7/7] drm: Split out drm_probe_helper.h

Le lun. 10 déc. 2018 à 12:10, Benjamin Gaignard a écrit : > > Le lun. 10 déc. 2018 à 11:24, Thierry Reding > a écrit : > > > > On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote: > > > Having the probe helper stuff (which pretty much everyone needs) in &g

Re: [Intel-gfx] [PATCH 7/7] drm: Split out drm_probe_helper.h

Le lun. 10 déc. 2018 à 11:24, Thierry Reding a écrit : > > On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote: > > Having the probe helper stuff (which pretty much everyone needs) in > > the drm_crtc_helper.h file (which atomic drivers should never need) is > > confusing. Split them out

Re: [Intel-gfx] [PATCH v2 05/14] drm/sti: Try to fix up the tvout possible clones

ut then > dvo also claims to be cloneable with hdmi, but hdmi won't recipricate. > > Benjamin tells me all encoders should be cloneable with each other, > so let's fix up the masks to indicate that. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-o

Re: [Intel-gfx] [PATCH 05/14] drm/sti: Try to fix up the tvout possible clones

e'll leave possible_clones==0 and we'll add a global > fallback for that case to add the encoder itself to the bitmask since > that makes life easier for most drivers. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/

Re: [Intel-gfx] [PATCH 04/14] drm/sti: Remove pointless casts

2018-06-15 18:49 GMT+02:00 Ville Syrjala : > From: Ville Syrjälä > > There's no point in the cast for accessing the base class. Just > take the address of the struct instead. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Ville Syrjälä Acked-b

Re: [Intel-gfx] [PATCH 11/23] drm/sti: Stop consulting plane->fb

2018-03-22 16:23 GMT+01:00 Ville Syrjala : > From: Ville Syrjälä > > We want to get rid of plane->fb on atomic drivers. Stop looking at it. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Ville Syrjälä Ack-ed by: Benjamin Gaignard > --- > drive

Re: [Intel-gfx] [PULL] drm-misc-next

2017-10-13 16:08 GMT+02:00 Maarten Lankhorst : > Op 12-10-17 om 14:05 schreef Daniel Vetter: >> Hi Dave, >> >> drm-misc-next-2017-10-12: >> More 4.15 drm-misc stuff: >> >> Cross-subsystem Changes: >> - bridge cleanup refactor (Benjamin Gaignard) &g

Re: [Intel-gfx] [PATCH 37/38] drm/sti: Don't call drm_helper_disable_unused_functions

Acked-by: Benjamin Gaignard 2016-06-02 0:07 GMT+02:00 Daniel Vetter : > Atomic drivers are supposed to do hw/sw state reset with the > drm_mode_config_reset() call right above it. > > Cc: Benjamin Gaignard > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/sti/sti_