Re: [Intel-gfx] [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-09-04 Thread Boris Brezillon
On Sat, 2 Sep 2023 22:43:02 +0300 Dmitry Osipenko wrote: > On 8/29/23 10:29, Boris Brezillon wrote: > > On Tue, 29 Aug 2023 05:34:23 +0300 > > Dmitry Osipenko wrote: > > > >> On 8/28/23 13:12, Boris Brezillon wrote: > >>> On Sun, 27 Aug 2023 2

Re: [Intel-gfx] [PATCH v15 01/23] drm/shmem-helper: Fix UAF in error path when freeing SGT of imported GEM

2023-09-04 Thread Boris Brezillon
On Sat, 2 Sep 2023 21:15:39 +0300 Dmitry Osipenko wrote: > On 8/28/23 14:16, Boris Brezillon wrote: > > On Sun, 27 Aug 2023 20:54:27 +0300 > > Dmitry Osipenko wrote: > > > >> Freeing drm-shmem GEM right after creating it using > >> drm_gem_shmem_p

Re: [Intel-gfx] [PATCH v15 02/23] drm/shmem-helper: Use flag for tracking page count bumped by get_pages_sgt()

2023-09-04 Thread Boris Brezillon
On Sat, 2 Sep 2023 21:28:21 +0300 Dmitry Osipenko wrote: > On 8/28/23 13:55, Boris Brezillon wrote: > > On Sun, 27 Aug 2023 20:54:28 +0300 > > Dmitry Osipenko wrote: > > > >> Use separate flag for tracking page count bumped by shmem->sgt to avoid >

Re: [Intel-gfx] [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-08-29 Thread Boris Brezillon
On Tue, 29 Aug 2023 11:44:13 +0200 Boris Brezillon wrote: > On Tue, 29 Aug 2023 10:52:03 +0200 > Christian König wrote: > > > Am 29.08.23 um 09:29 schrieb Boris Brezillon: > > > On Tue, 29 Aug 2023 05:34:23 +0300 > > > Dmitry Osipenko wrote: > &g

Re: [Intel-gfx] [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-08-29 Thread Boris Brezillon
On Tue, 29 Aug 2023 10:52:03 +0200 Christian König wrote: > Am 29.08.23 um 09:29 schrieb Boris Brezillon: > > On Tue, 29 Aug 2023 05:34:23 +0300 > > Dmitry Osipenko wrote: > > > >> On 8/28/23 13:12, Boris Brezillon wrote: > >>> On Sun, 27 Aug 2023 2

Re: [Intel-gfx] [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-08-29 Thread Boris Brezillon
On Tue, 29 Aug 2023 05:34:23 +0300 Dmitry Osipenko wrote: > On 8/28/23 13:12, Boris Brezillon wrote: > > On Sun, 27 Aug 2023 20:54:43 +0300 > > Dmitry Osipenko wrote: > > > >> In a preparation of adding drm-shmem memory shrinker, move all reservation > >

Re: [Intel-gfx] [PATCH v15 12/23] drm/shmem-helper: Add and use pages_pin_count

2023-08-28 Thread Boris Brezillon
nned > in memory, but whether pages exit and are soft-pinned (and could be swapped > out). The pages_pin_count > 1 will hard-pin pages in memory. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 22

Re: [Intel-gfx] [PATCH v15 09/23] drm/shmem-helper: Remove obsoleted is_iomem test

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:35 +0300 Dmitry Osipenko wrote: > Everything that uses the mapped buffer should by agnostic to is_iomem. ^be > The only reason for the is_iomem test is that we're setting shmem->vaddr > to the returned map->vaddr. Now tha

Re: [Intel-gfx] [PATCH v15 08/23] drm/shmem-helper: Refactor locked/unlocked functions

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:34 +0300 Dmitry Osipenko wrote: > Add locked and remove unlocked postfixes from drm-shmem function names, > making names consistent with the drm/gem core code. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko Reviewed-by:

Re: [Intel-gfx] [PATCH v15 04/23] drm/gem: Add _locked postfix to functions that have unlocked counterpart

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:30 +0300 Dmitry Osipenko wrote: > Add _locked postfix to drm_gem functions that have unlocked counterpart > functions to make GEM functions naming more consistent and intuitive in > regards to the locking requirements. > > Suggested-by: Boris Brezillon

Re: [Intel-gfx] [PATCH v15 03/23] drm/gem: Change locked/unlocked postfix of drm_gem_v/unmap() function names

2023-08-28 Thread Boris Brezillon
e them consistent with the rest of the API functions. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/drm_client.c | 6 +++--- > drivers/gpu/drm/drm_gem.c| 20

Re: [Intel-gfx] [PATCH v15 01/23] drm/shmem-helper: Fix UAF in error path when freeing SGT of imported GEM

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:27 +0300 Dmitry Osipenko wrote: > Freeing drm-shmem GEM right after creating it using > drm_gem_shmem_prime_import_sg_table() frees SGT of the imported dma-buf > and then dma-buf frees this SGT second time. > > The v3d_prime_import_sg_table() is example of a error code

Re: [Intel-gfx] [PATCH v15 02/23] drm/shmem-helper: Use flag for tracking page count bumped by get_pages_sgt()

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:28 +0300 Dmitry Osipenko wrote: > Use separate flag for tracking page count bumped by shmem->sgt to avoid > imbalanced page counter during of drm_gem_shmem_free() time. It's fragile > to assume that populated shmem->pages at a freeing time means that the > count was bump

Re: [Intel-gfx] [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:43 +0300 Dmitry Osipenko wrote: > In a preparation of adding drm-shmem memory shrinker, move all reservation > locking lockdep checks to use new drm_gem_shmem_resv_assert_held() that > will resolve spurious lockdep warning about wrong locking order vs > fs_reclam code pa

Re: [Intel-gfx] [PATCH v15 16/23] drm/shmem-helper: Use kref for vmap_use_count

2023-08-28 Thread Boris Brezillon
for this field until we have a real use case. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 37 ++ > include/drm/drm_gem_shmem_helper.h | 2 +- > 2 files changed, 21 inserti

Re: [Intel-gfx] [PATCH v15 12/23] drm/shmem-helper: Add and use pages_pin_count

2023-08-28 Thread Boris Brezillon
nned > in memory, but whether pages exit and are soft-pinned (and could be swapped ^exist > out). The pages_pin_count > 1 will hard-pin pages in memory. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko > --- > drivers/gp

Re: [Intel-gfx] [PATCH v15 10/23] locking/refcount, kref: Add kref_put_ww_mutex()

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:36 +0300 Dmitry Osipenko wrote: > Introduce kref_put_ww_mutex() helper that will handle the wait-wound > mutex auto-locking on kref_put(). This helper is wanted by DRM drivers > that extensively use dma-reservation locking which in turns uses ww-mutex. > > Signed-off-by

Re: [Intel-gfx] [PATCH v13 03/10] drm/shmem-helper: Add pages_pin_count field

2023-06-26 Thread Boris Brezillon
On Mon, 26 Jun 2023 17:04:57 +0200 Boris Brezillon wrote: > Hi Dmitry, > > Sorry for chiming in only now :-/. > > On Tue, 14 Mar 2023 05:26:52 +0300 > Dmitry Osipenko wrote: > > > And new pages_pin_count field to struct drm_gem_shmem_object that will > > dete

Re: [Intel-gfx] [PATCH v13 03/10] drm/shmem-helper: Add pages_pin_count field

2023-06-26 Thread Boris Brezillon
Hi Dmitry, Sorry for chiming in only now :-/. On Tue, 14 Mar 2023 05:26:52 +0300 Dmitry Osipenko wrote: > And new pages_pin_count field to struct drm_gem_shmem_object that will > determine whether pages are evictable by memory shrinker. The pages will > be evictable only when pages_pin_count=0.

Re: [Intel-gfx] [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Boris Brezillon
On Mon, 26 Jun 2023 11:40:14 +0200 Boris Brezillon wrote: > Hi Dmitry, > > On Tue, 30 May 2023 01:39:35 +0300 > Dmitry Osipenko wrote: > > > Replace all drm-shmem locks with a GEM reservation lock. This makes locks > > consistent with dma-buf locking convention wher

Re: [Intel-gfx] [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Boris Brezillon
Hi Dmitry, On Tue, 30 May 2023 01:39:35 +0300 Dmitry Osipenko wrote: > Replace all drm-shmem locks with a GEM reservation lock. This makes locks > consistent with dma-buf locking convention where importers are responsible > for holding reservation lock for all operations performed over dma-bufs,

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 16:38:18 +0100 Daniel Vetter wrote: > > > > > > Also if you do the allocation in ->prepare_job with dma_fence and not > > > run_job, then I think can sort out fairness issues (if they do pop up) in > > > the drm/sched code instead of having to think about this in each driver.

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 11:42:57 +0100 Daniel Vetter wrote: > On Thu, Jan 12, 2023 at 11:25:53AM +0100, Boris Brezillon wrote: > > On Thu, 12 Jan 2023 11:11:03 +0100 > > Boris Brezillon wrote: > > > > > On Thu, 12 Jan 2023 10:32:18 +0100 > > > Daniel Vett

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 11:11:03 +0100 Boris Brezillon wrote: > On Thu, 12 Jan 2023 10:32:18 +0100 > Daniel Vetter wrote: > > > On Thu, Jan 12, 2023 at 10:10:53AM +0100, Boris Brezillon wrote: > > > Hi Daniel, > > > > > > On Wed, 11 Jan 2023

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 11:11:03 +0100 Boris Brezillon wrote: > On Thu, 12 Jan 2023 10:32:18 +0100 > Daniel Vetter wrote: > > > On Thu, Jan 12, 2023 at 10:10:53AM +0100, Boris Brezillon wrote: > > > Hi Daniel, > > > > > > On Wed, 11 Jan 2023

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
On Thu, 12 Jan 2023 10:32:18 +0100 Daniel Vetter wrote: > On Thu, Jan 12, 2023 at 10:10:53AM +0100, Boris Brezillon wrote: > > Hi Daniel, > > > > On Wed, 11 Jan 2023 22:47:02 +0100 > > Daniel Vetter wrote: > > > > > On Tue, 10 Jan 2

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-12 Thread Boris Brezillon
Hi Daniel, On Wed, 11 Jan 2023 22:47:02 +0100 Daniel Vetter wrote: > On Tue, 10 Jan 2023 at 09:46, Boris Brezillon > wrote: > > > > Hi Daniel, > > > > On Mon, 9 Jan 2023 21:40:21 +0100 > > Daniel Vetter wrote: > > > > > On Mon, Jan

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-10 Thread Boris Brezillon
+Frank, who's also working on the pvr uAPI. Hi, On Thu, 22 Dec 2022 14:21:07 -0800 Matthew Brost wrote: > The code has been organized such that we have all patches that touch areas > outside of drm/xe first for review, and then the actual new driver in a > separate > commit. The code which is

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Boris Brezillon
Hi Daniel, On Mon, 9 Jan 2023 21:40:21 +0100 Daniel Vetter wrote: > On Mon, Jan 09, 2023 at 06:17:48PM +0100, Boris Brezillon wrote: > > Hi Jason, > > > > On Mon, 9 Jan 2023 09:45:09 -0600 > > Jason Ekstrand wrote: > > > > > On Thu, Jan 5,

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-09 Thread Boris Brezillon
Hi Jason, On Mon, 9 Jan 2023 09:45:09 -0600 Jason Ekstrand wrote: > On Thu, Jan 5, 2023 at 1:40 PM Matthew Brost > wrote: > > > On Mon, Jan 02, 2023 at 08:30:19AM +0100, Boris Brezillon wrote: > > > On Fri, 30 Dec 2022 12:55:08 +0100 > > > Boris Brezillon

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-03 Thread Boris Brezillon
Hi, On Tue, 3 Jan 2023 13:02:15 + Tvrtko Ursulin wrote: > On 02/01/2023 07:30, Boris Brezillon wrote: > > On Fri, 30 Dec 2022 12:55:08 +0100 > > Boris Brezillon wrote: > > > >> On Fri, 30 Dec 2022 11:20:42 +0100 > >> Boris Brezillon wrote: > &g

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-03 Thread Boris Brezillon
Hi, On Mon, 02 Jan 2023 13:42:46 +0200 Jani Nikula wrote: > On Mon, 02 Jan 2023, Thomas Zimmermann wrote: > > Hi > > > > Am 22.12.22 um 23:21 schrieb Matthew Brost: > >> Hello, > >> > >> This is a submission for Xe, a new driver for Intel GPUs that supports both > >> integrated and discrete

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-01 Thread Boris Brezillon
On Fri, 30 Dec 2022 12:55:08 +0100 Boris Brezillon wrote: > On Fri, 30 Dec 2022 11:20:42 +0100 > Boris Brezillon wrote: > > > Hello Matthew, > > > > On Thu, 22 Dec 2022 14:21:11 -0800 > > Matthew Brost wrote: > > > > > In XE, the new Inte

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2022-12-30 Thread Boris Brezillon
On Fri, 30 Dec 2022 11:20:42 +0100 Boris Brezillon wrote: > Hello Matthew, > > On Thu, 22 Dec 2022 14:21:11 -0800 > Matthew Brost wrote: > > > In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 > > mapping between a drm_gpu_scheduler and drm_

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2022-12-30 Thread Boris Brezillon
Hello Matthew, On Thu, 22 Dec 2022 14:21:11 -0800 Matthew Brost wrote: > In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 > mapping between a drm_gpu_scheduler and drm_sched_entity. At first this > seems a bit odd but let us explain the reasoning below. > > 1. In XE the submi

Re: [Intel-gfx] [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes

2021-07-27 Thread Boris Brezillon
lcome, as usual. > > Cheers, Daniel > > Daniel Vetter (18): > drm/sched: Split drm_sched_job_init > drm/sched: Barriers are needed for entity->last_scheduled > drm/sched: Add dependency tracking > drm/sched: drop entity parameter from drm_sched_push_job > drm/s

Re: [Intel-gfx] [PATCH 04/15] drm/panfrost: Shrink sched_lock

2021-06-23 Thread Boris Brezillon
> in v1. > > Signed-off-by: Daniel Vetter > Cc: Lucas Stach > Cc: Rob Herring > Cc: Tomeu Vizoso > Cc: Steven Price > Cc: Alyssa Rosenzweig Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 7 +++ > 1 file changed, 3 insert

Re: [Intel-gfx] [PATCH 05/15] drm/panfrost: Use xarray and helpers for depedency tracking

2021-06-23 Thread Boris Brezillon
ing some scheduler people for this too. > > v2: Correctly handle sched_lock since Lucas pointed out it's needed. > > v3: Rebase, dma_resv_get_excl_unlocked got renamed > > v4: Don't leak job references on failure (Steven). Hehe, I had pretty much the same pat

Re: [Intel-gfx] [PATCH 06/15] drm/panfrost: Fix implicit sync

2021-06-23 Thread Boris Brezillon
> Cc: Tomeu Vizoso > Cc: Steven Price > Cc: Alyssa Rosenzweig > Cc: Sumit Semwal Reviewed-by: Boris Brezillon > Cc: "Christian König" > Cc: linux-me...@vger.kernel.org > Cc: linaro-mm-...@lists.linaro.org > --- > drivers/gpu/drm/panfrost/panfrost_j

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2020-11-02 Thread Boris Brezillon
Hi Stephen, On Mon, 2 Nov 2020 12:46:37 +1100 Stephen Rothwell wrote: > Hi all, > > After merging the imx-drm tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/gpu/drm/panfrost/panfrost_job.c: In function 'panfrost_job_close': > drivers/gpu/drm/panfro

Re: [Intel-gfx] [PATCH 0/9] shmem helper untangling

2020-05-29 Thread Boris Brezillon
similar to initialize pages_use_count to 1 when importing a dma-buf), this patchset seems to work on panfrost: Tested-by: Boris Brezillon > > Documentation/gpu/drm-kms-helpers.rst | 12 --- > Documentation/gpu/drm-mm.rst| 12 +++ > drivers/gpu/drm/drm_gem.c

Re: [Intel-gfx] [PATCH 2/2] drm/atomic-helper: reset vblank on crtc reset

2020-05-29 Thread Boris Brezillon
Reported-by: Tetsuo Handa > Reported-by: syzbot+0871b14ca2e2fb64f...@syzkaller.appspotmail.com > Cc: Tetsuo Handa > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Mihail Atanassov > Cc: Brian Starkey > Cc: Sam Ravnborg > Cc: Boris Brezillon > Cc: Nicola

Re: [Intel-gfx] [PATCH 2/8] drm/atmel: ditch fb_create wrapper

2019-11-15 Thread Boris Brezillon
On Fri, 15 Nov 2019 10:21:14 +0100 Daniel Vetter wrote: > Spotted while looking through them all. > > Signed-off-by: Daniel Vetter > Cc: Sam Ravnborg > Cc: Boris Brezillon Acked-by: Boris Brezillon > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroc

Re: [Intel-gfx] [PATCH] drm/amd: Compile fix for amdgpu_dm.c

2018-12-12 Thread Boris Brezillon
On Wed, 12 Dec 2018 13:54:48 +0100 Boris Brezillon wrote: > On Wed, 12 Dec 2018 13:44:13 +0200 > Mika Kuoppala wrote: > > > Fix compilation issue with CONFIG_DRM_AMDGPU on: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function > >

Re: [Intel-gfx] [PATCH] drm/amd: Compile fix for amdgpu_dm.c

2018-12-12 Thread Boris Brezillon
66:30: error: > passing argument 1 of ‘drm_atomic_private_obj_init’ from incompatible pointer > type > > Fixes: b962a12050a3 ("drm/atomic: integrate modeset lock with private > objects") > Cc: Rob Clark > Cc: Boris Brezillon > Cc: Daniel Vetter >

Re: [Intel-gfx] [PATCH] drm/amd: Compile fix for amdgpu_dm.c

2018-12-12 Thread Boris Brezillon
66:30: error: > passing argument 1 of ‘drm_atomic_private_obj_init’ from incompatible pointer > type > > Fixes: b962a12050a3 ("drm/atomic: integrate modeset lock with private > objects") > Cc: Rob Clark > Cc: Boris Brezillon Reviewed-by: Boris Brezillon And sorry f

Re: [Intel-gfx] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Boris Brezillon
Liviu Dudau > Cc: Brian Starkey > Cc: Mali DP Maintainers > Cc: Boris Brezillon > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroches > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: Jani Nikula > Cc: Joonas Lahtinen > C

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-26 Thread Boris Brezillon
| 4 ++-- > drivers/gpu/drm/armada/armada_drv.c| 6 +++--- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- For atmel-hlcdc: Acked-by: Boris Brezillon ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t v2 3/3] igt: Add VC4 purgeable BO tests

2017-11-21 Thread Boris Brezillon
On Tue, 21 Nov 2017 10:30:15 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > Signed-off-by: Boris Brezillon > > --- > > Changes in v2: > > - Add a rule to build vc4 purgeable tests when using Meson (suggested by > > Petri) > > - Rework th

[Intel-gfx] [PATCH i-g-t v2 3/3] igt: Add VC4 purgeable BO tests

2017-10-04 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- Changes in v2: - Add a rule to build vc4 purgeable tests when using Meson (suggested by Petri) - Rework the subtests to avoid uncertainty (suggested by Chris) - Add a subtest to make sure new BOs have their content retained by default (suggested by Chris

[Intel-gfx] [PATCH i-g-t v2 2/3] igt: Add igt_vc4_get_param() helper

2017-10-04 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- Changes in v2: - New patch --- lib/igt_vc4.c | 15 +++ lib/igt_vc4.h | 1 + 2 files changed, 16 insertions(+) diff --git a/lib/igt_vc4.c b/lib/igt_vc4.c index b75c063204ec..f98c16754c9c 100644 --- a/lib/igt_vc4.c +++ b/lib/igt_vc4.c @@ -129,6

[Intel-gfx] [PATCH i-g-t v2 0/3] igt: Add a testsuite to validate VC4 MADV ioctl

2017-10-04 Thread Boris Brezillon
quot; test (still need to figure out how to do that :-)). That's on my TODO list for a v3. Thanks, Boris Boris Brezillon (3): igt: Add a helper function to mark BOs purgeable igt: Add igt_vc4_get_param() helper igt: Add VC4 purgeable BO tests lib/igt_vc4.c| 27 +

[Intel-gfx] [PATCH i-g-t v2 1/3] igt: Add a helper function to mark BOs purgeable

2017-10-04 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- Changes in v2: - none --- lib/igt_vc4.c | 12 lib/igt_vc4.h | 1 + 2 files changed, 13 insertions(+) diff --git a/lib/igt_vc4.c b/lib/igt_vc4.c index c4682f5688f1..b75c063204ec 100644 --- a/lib/igt_vc4.c +++ b/lib/igt_vc4.c @@ -128,3 +128,15

Re: [Intel-gfx] [PATCH i-g-t 2/2] igt: Add VC4 purgeable BO tests

2017-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2017 13:50:30 +0100 Chris Wilson wrote: > Quoting Boris Brezillon (2017-09-27 13:41:41) > > Hi Chris, > > > > On Wed, 27 Sep 2017 13:07:28 +0100 > > Chris Wilson wrote: > > > > > Quoting Boris Brezillon (2017-09-27 12:51:18) > &g

Re: [Intel-gfx] [PATCH i-g-t 2/2] igt: Add VC4 purgeable BO tests

2017-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2017 14:57:05 +0300 Petri Latvala wrote: > On Wed, Sep 27, 2017 at 01:51:18PM +0200, Boris Brezillon wrote: > > Signed-off-by: Boris Brezillon > > --- > > tests/Makefile.sources | 1 + > > tes

Re: [Intel-gfx] [PATCH i-g-t 2/2] igt: Add VC4 purgeable BO tests

2017-09-27 Thread Boris Brezillon
Hi Chris, On Wed, 27 Sep 2017 13:07:28 +0100 Chris Wilson wrote: > Quoting Boris Brezillon (2017-09-27 12:51:18) > > Signed-off-by: Boris Brezillon > > --- > > tests/Makefile.sources | 1 + > > tests/vc4_purgeable_bo.c | 274 > > +

[Intel-gfx] [PATCH i-g-t 2/2] igt: Add VC4 purgeable BO tests

2017-09-27 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- tests/Makefile.sources | 1 + tests/vc4_purgeable_bo.c | 274 +++ 2 files changed, 275 insertions(+) create mode 100644 tests/vc4_purgeable_bo.c diff --git a/tests/Makefile.sources b/tests/Makefile.sources index

[Intel-gfx] [PATCH i-g-t 0/2] igt: Add a testsuite to validate VC4 MADV ioctl

2017-09-27 Thread Boris Brezillon
consider this for inclusion in IGT until the kernel and libdrm part have been accepted. Thanks, Boris Boris Brezillon (2): igt: Add a helper function to mark BOs purgeable igt: Add VC4 purgeable BO tests lib/igt_vc4.c| 12 +++ lib/igt_vc4.h| 1 + tests

[Intel-gfx] [PATCH i-g-t 1/2] igt: Add a helper function to mark BOs purgeable

2017-09-27 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- lib/igt_vc4.c | 12 lib/igt_vc4.h | 1 + 2 files changed, 13 insertions(+) diff --git a/lib/igt_vc4.c b/lib/igt_vc4.c index c4682f5688f1..b75c063204ec 100644 --- a/lib/igt_vc4.c +++ b/lib/igt_vc4.c @@ -128,3 +128,15 @@ igt_vc4_mmap_bo(int fd

Re: [Intel-gfx] [PATCH 08/16] drm/atmel-hlcdec: Use for_each_new_connector_in_state

2017-07-12 Thread Boris Brezillon
On Wed, 12 Jul 2017 10:13:36 +0200 Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the new iterator > macros. > > Signed-off-by: Maarten Lankhorst > Cc: Boris Brezillon Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/a

Re: [Intel-gfx] [PATCH 11/11] drm: remove unused and redundant callbacks

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 08:37:55 +0200 Daniel Vetter wrote: > On Thu, Jun 22, 2017 at 12:34:36AM +0800, kbuild test robot wrote: > > Hi Peter, > > > > [auto build test ERROR on drm/drm-next] > > [also build test ERROR on next-20170621] > > [cannot apply to v4.12-rc6] > > [if your patch is applied to

Re: [Intel-gfx] [PATCH 17/37] drm/atmel: Drop drm_vblank_cleanup

2017-05-24 Thread Boris Brezillon
> > Cc: Boris Brezillon > Signed-off-by: Daniel Vetter Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > b/drivers/gpu/drm/atmel-h

Re: [Intel-gfx] [PATCH 13/37] drm: better document how to send out the crtc disable event

2017-05-24 Thread Boris Brezillon
On Wed, 24 May 2017 16:51:48 +0200 Daniel Vetter wrote: > The kernel doc explained what needs to happen, but not how to most > easily accomplish that using the functions. Fix that. > > Cc: Boris Brezillon > Signed-off-by: Daniel Vetter Reviewed-by: Boris Brezillon >

Re: [Intel-gfx] [PATCH] drm/atomic: Acquire connection_mutex lock in drm_helper_probe_single_connector_modes, v4.

2017-04-10 Thread Boris Brezillon
fy the locking situation. (danvet) Maybe this is something DRM-specific, but usually we put the changelog after the '---' to avoid having it in the final commit. Same goes for the ", v4" suffix in the commit title, it should be '[PATCH vX] '. > > Signed-off-by: Ma

Re: [Intel-gfx] [PATCH] drm/atomic: Acquire connection_mutex lock in drm_helper_probe_single_connector_modes.

2017-03-29 Thread Boris Brezillon
gt; > > intel_dp.c however ignores the force flag, so still lock > > connection_mutex there if needed. > > > > Signed-off-by: Maarten Lankhorst > > Cc: Boris Brezillon > > Cc: Manasi Navare > > Hm only noticed this now, but mixing up force with the

Re: [Intel-gfx] [PATCH v2 05/15] drm/atmel-hlcdc: Use per-plane rotation property

2016-08-10 Thread Boris Brezillon
On Wed, 10 Aug 2016 16:04:37 +0200 Daniel Vetter wrote: > On Wed, Aug 10, 2016 at 01:52:45PM +0200, Boris Brezillon wrote: > > On Wed, 10 Aug 2016 14:41:52 +0300 > > Ville Syrjälä wrote: > > > > > On Wed, Aug 10, 2016 at 11:25:03AM +0200, Boris Brezillon wrote:

Re: [Intel-gfx] [PATCH v2 05/15] drm/atmel-hlcdc: Use per-plane rotation property

2016-08-10 Thread Boris Brezillon
On Wed, 10 Aug 2016 13:52:45 +0200 Boris Brezillon wrote: > On Wed, 10 Aug 2016 14:41:52 +0300 > Ville Syrjälä wrote: > > > On Wed, Aug 10, 2016 at 11:25:03AM +0200, Boris Brezillon wrote: > > > On Wed, 10 Aug 2016 12:09:41 +0300 > > > Ville Syrjälä wrote:

Re: [Intel-gfx] [PATCH v2 05/15] drm/atmel-hlcdc: Use per-plane rotation property

2016-08-10 Thread Boris Brezillon
On Wed, 10 Aug 2016 14:41:52 +0300 Ville Syrjälä wrote: > On Wed, Aug 10, 2016 at 11:25:03AM +0200, Boris Brezillon wrote: > > On Wed, 10 Aug 2016 12:09:41 +0300 > > Ville Syrjälä wrote: > > > > > On Wed, Aug 10, 2016 at 10:35:22AM +0200, Boris Brezi

Re: [Intel-gfx] [PATCH v2 05/15] drm/atmel-hlcdc: Use per-plane rotation property

2016-08-10 Thread Boris Brezillon
On Wed, 10 Aug 2016 12:09:41 +0300 Ville Syrjälä wrote: > On Wed, Aug 10, 2016 at 10:35:22AM +0200, Boris Brezillon wrote: > > Hi Ville, > > > > On Fri, 22 Jul 2016 18:47:01 +0300 > > ville.syrj...@linux.intel.com wrote: > > > > > Fr

Re: [Intel-gfx] [PATCH v2 05/15] drm/atmel-hlcdc: Use per-plane rotation property

2016-08-10 Thread Boris Brezillon
Hi Ville, On Fri, 22 Jul 2016 18:47:01 +0300 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The global mode_config.rotation_property is going away, switch over to > per-plane rotation_property. > > v2: Propagate error upwards (Boris) > > Cc: Boris Br

Re: [Intel-gfx] [PATCH 05/15] drm/atmel-hlcdc: Use per-plane rotation property

2016-07-22 Thread Boris Brezillon
Hi Ville, On Fri, 22 Jul 2016 16:43:06 +0300 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The global mode_config.rotation_property is going away, switch over to > per-plane rotation_property. > > Cc: Boris Brezillon > Signed-off-by: Ville Syrjälä >

[Intel-gfx] [PATCH v2 17/20] drm/bridge: anx78xx: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders, and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder(), and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/bridge/analogix-anx78xx.c

[Intel-gfx] [PATCH v2 19/20] drm/bridge: ps8622: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders, and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder(), and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/bridge/parade-ps8622.c |

[Intel-gfx] [PATCH v2 02/20] drm: arc: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder(), and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/arc/arcpgu_hdmi.c |

[Intel-gfx] [PATCH v2 20/20] drm/bridge: dw-hdmi: Use drm_atomic_helper_best_encoder()

2016-06-07 Thread Boris Brezillon
hen ->best_encoder() is NULL is only available when the DRM device is using the atomic helpers, and this bridge is compatible with non-atomic and atomic devices. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/bridge/dw-hdmi.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-)

[Intel-gfx] [PATCH v2 05/20] drm: fsl-dcu: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c

[Intel-gfx] [PATCH v2 08/20] drm: msm: Rely on the default ->best_encoder() behavior where appropriate

2016-06-07 Thread Boris Brezillon
For all outputs except DSI we have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/

[Intel-gfx] [PATCH v2 16/20] drm: omap: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementation and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon Reviewed-by: Laurent Pinch

[Intel-gfx] [PATCH v2 04/20] drm: exynos: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementations and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/exy

[Intel-gfx] [PATCH v2 00/20] drm/atomic: Provide default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
e applying the associated changes. Note that once patch 1 is applied, the other patches can be applied independently. Best Regards, Boris Changes since v1: - remove useless ->encoder backpointers in some implementations - documented the default behavior in the vtable doc - added R-b/A-b tags

[Intel-gfx] [PATCH v2 06/20] drm: i915: Rely on the default ->best_encoder() behavior where appropriate

2016-06-07 Thread Boris Brezillon
For all outputs except dp_mst, we have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementation and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezil

[Intel-gfx] [PATCH v2 03/20] drm: atmel-hlcdc: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_outpu

[Intel-gfx] [PATCH v2 18/20] drm/bridge: ptn3460: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders, and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder(), and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/bridge/nxp-ptn3460.c

[Intel-gfx] [PATCH v2 09/20] drm: rcar-du: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
All outputs have a 1:1 relationship between connectors and encoders, and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementations and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon Reviewed-by: Laur

[Intel-gfx] [PATCH v2 15/20] drm: virtgpu: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
The virtgpu output exposes a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementation and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/

[Intel-gfx] [PATCH v2 13/20] drm: tegra: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
All outputs have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementation and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/te

[Intel-gfx] [PATCH v2 07/20] drm: mediatek: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementation and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/mediatek/mtk_ds

[Intel-gfx] [PATCH v2 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid

2016-06-07 Thread Boris Brezillon
gly. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/drm_atomic_helper.c | 4 +++- drivers/gpu/drm/drm_fb_helper.c | 13 - include/drm/drm_modeset_helper_vtables.h | 10 -- 3 files changed, 23 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH v2 12/20] drm: sun4i: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
All outputs have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementations and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/su

[Intel-gfx] [PATCH v2 11/20] drm: sti: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
All outputs have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementations and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/

[Intel-gfx] [PATCH v2 14/20] drm: vc4: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
All outputs have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementations and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/

[Intel-gfx] [PATCH v2 10/20] drm: rockchip: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Boris Brezillon
All outputs have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementations and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon Acked-by: Mark

Re: [Intel-gfx] [PATCH 09/20] drm: rcar-du: Rely on the default ->best_encoder() behavior

2016-06-03 Thread Boris Brezillon
On Thu, 02 Jun 2016 23:57:14 +0300 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Thursday 02 Jun 2016 16:31:36 Boris Brezillon wrote: > > All outputs have a 1:1 relationship between connectors and encoders, > > and the driver is relying on

Re: [Intel-gfx] [PATCH 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid

2016-06-03 Thread Boris Brezillon
On Thu, 2 Jun 2016 23:57:02 +0200 Daniel Vetter wrote: > On Thu, Jun 2, 2016 at 11:05 PM, Laurent Pinchart > wrote: > > Hi Boris, > > > > Thank you for the patch. > > > > On Thursday 02 Jun 2016 16:31:28 Boris Brezillon wrote: > >> Adapt drm_p

Re: [Intel-gfx] [PATCH 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid

2016-06-03 Thread Boris Brezillon
On Fri, 03 Jun 2016 00:05:46 +0300 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Thursday 02 Jun 2016 16:31:28 Boris Brezillon wrote: > > Adapt drm_pick_crtcs() and update_connector_routing() to fallback to > > drm_atomic_helper_best_encod

[Intel-gfx] [PATCH 15/20] drm: virtgpu: Rely on the default ->best_encoder() behavior

2016-06-02 Thread Boris Brezillon
The virtgpu output exposes a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementation and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/

[Intel-gfx] [PATCH 05/20] drm: fsl-dcu: Rely on the default ->best_encoder() behavior

2016-06-02 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c

[Intel-gfx] [PATCH 12/20] drm: sun4i: Rely on the default ->best_encoder() behavior

2016-06-02 Thread Boris Brezillon
All outputs have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementations and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/su

[Intel-gfx] [PATCH 07/20] drm: mediatek: Rely on the default ->best_encoder() behavior

2016-06-02 Thread Boris Brezillon
We have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() implementation and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/mediatek/mtk_ds

[Intel-gfx] [PATCH 20/20] drm/bridge: dw-hdmi: Use drm_atomic_helper_best_encoder()

2016-06-02 Thread Boris Brezillon
hen ->best_encoder() is NULL is only available when the DRM device is using the atomic helpers, and this bridge is compatible with non-atomic and atomic devices. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/bridge/dw-hdmi.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-)

  1   2   3   >