Re: [Intel-gfx] [PATCH] drm/i915/huc: fix leak of debug object in huc load fence on driver unload

2022-11-16 Thread Brian Norris
which can in turn > trigger a warning if we try to register a new debug offset at the same > address on driver reload. > > To fix the issue, make sure to always run the cleanup code. > > Reported-by: Tvrtko Ursulin > Reported-by: Brian Norris > Fixes: 27536e03271d (&quo

Re: [Intel-gfx] [CI 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-11-07 Thread Brian Norris
On Mon, Nov 07, 2022 at 10:38:14AM -0800, Ceraolo Spurio, Daniele wrote: > Ok, I think I have an idea of what's happening: if HuC is not enabled, we > skip the call to fence_fini, so we leak the debug object. Can you check if > the below diff fixes the issue for you? Thanks for checking! This

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

2022-11-04 Thread Brian Norris
On Fri, Nov 04, 2022 at 02:38:03PM +, Matthew Auld wrote: > On Thu, 3 Nov 2022 at 00:14, Brian Norris wrote: > > I'm still curious about the reported failures, but maybe they require > > some particular sequence of tests? I also don't have the full > > igt-gpu-tools

Re: [Intel-gfx] [CI 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-11-04 Thread Brian Norris
Hi, On Wed, Oct 19, 2022 at 10:54:34AM +0100, Tvrtko Ursulin wrote: > Don't know if this is real or not yet, hit it while running selftests a bit. > Something to keep an eye on. > > [ 2928.370577] ODEBUG: init destroyed (active state 0) object type: > i915_sw_fence hint:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

2022-11-02 Thread Brian Norris
On Wed, Nov 02, 2022 at 12:18:37PM +, Matthew Auld wrote: > On Tue, 1 Nov 2022 at 21:58, Brian Norris wrote: > > > > On Fri, Oct 28, 2022 at 5:24 PM Patchwork > > wrote: > > > > > > Patch Details > > > Series:drm/i915: Set PROBE_PREFER_ASYNCHRO

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

2022-11-01 Thread Brian Norris
On Fri, Oct 28, 2022 at 5:24 PM Patchwork wrote: > > Patch Details > Series:drm/i915: Set PROBE_PREFER_ASYNCHRONOUS > URL:https://patchwork.freedesktop.org/series/110277/ > State:failure > Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110277v1/index.html > > CI Bug Log - changes from

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2022-10-28 Thread Brian Norris
Hi, On Thu, Aug 16, 2018 at 03:40:38PM +0800, Feng Tang wrote: > On Tue, Aug 14, 2018 at 11:39:48AM +0200, Takashi Iwai wrote: > > FYI, the upcoming 4.19 will have the completion in audio side binding, > > so this problem should be solved there. > > Really a great news! thanks for sharing For

[Intel-gfx] [PATCH] drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

2022-10-28 Thread Brian Norris
ayed i915 audio component binding") Signed-off-by: Brian Norris --- drivers/gpu/drm/i915/i915_pci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 38460a0bd7cb..1cb1f87aea86 100644 --- a/

Re: [Intel-gfx] [RFC PATCH] drm/i915: PSR regressions on Broadwell

2015-09-28 Thread Brian Norris
On Mon, Sep 28, 2015 at 10:14:04AM +0300, Jani Nikula wrote: > On Sat, 26 Sep 2015, Brian Norris <briannor...@chromium.org> wrote: > > When using PSR, I see the screen freeze after only a few frames (sometimes a > > split second; sometimes it seems like practically the first f

Re: [Intel-gfx] [1/7] drm/i915: Remove duplicated dpcd write on hsw_psr_enable_sink.

2015-09-25 Thread Brian Norris
On Thu, Aug 20, 2015 at 05:55:38PM -0700, Rodrigo Vivi wrote: > This is wrong since my commit (89251b17). The intention of that > commit was to remove this one here that is also wrong anyway, > but it was forgotten. > > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> Te

Re: [Intel-gfx] [4/7] drm/i915: PSR: Mask LPSP hw tracking back again.

2015-09-25 Thread Brian Norris
s patch fixes the unrecoverable frozen screens reported: > > Reference: https://bugs.freedesktop.org/show_bug.cgi?id=91436 > Reference: https://bugs.freedesktop.org/show_bug.cgi?id=91437 > > Cc: Ivan Mitev <ivan.mi...@gmail.com> > Signed-off-by: Rodrigo Vivi <rodrigo.v..

[Intel-gfx] [RFC PATCH] drm/i915: PSR regressions on Broadwell

2015-09-25 Thread Brian Norris
atch/57698/ Signed-off-by: Brian Norris <briannor...@chromium.org> --- drivers/gpu/drm/i915/intel_psr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 7e335a8546f6..4cd33b76b8a6 100644 --- a/driv