o
check:
drm_color_lut_check(lut, DRM_COLOR_LUT_EQUAL_CHANNELS |
DRM_COLOR_LUT_INCREASING);
Not sure if it would turn out messy with the different loop bounds.
Either way, for mali-dp it makes no difference, and probably
LUTs aren't changing all the time so:
Reviewed-by: Brian Starkey
ust be
> equal. Let's add a helper function that drivers can use to test that a
> userspace-provided LUT is valid and doesn't violate hardware
> requirements.
>
> v2:
> - Combine into a single helper that just takes a bitmask of the tests
>to apply. (Bri
rnal representation of the u64, it can
>still be confusing to look at code that uses 'rgba' terminology, but
> stores values with argb ordering. (Ville)
>
> v4:
> - Drop the bgcolor_changed flag. (Ville, Brian Starkey)
> - Clarify in kerneldoc that background
Hi Uma,
On Thu, Dec 27, 2018 at 11:22:36PM +0530, Uma Shankar wrote:
> This patch series creates a new connector property to program
> colorspace to sink devices. Modern sink devices support more
> than 1 type of colorspace like 601, 709, BT2020 etc. This helps
> to switch based on content type wh
Hi Uma,
On Thu, Dec 27, 2018 at 11:22:37PM +0530, Uma Shankar wrote:
> This patch adds a colorspace connector property, enabling
> userspace to switch to various supported colorspaces.
> This will help enable BT2020 along with other colorspaces.
>
> v2: Addressed Maarten and Ville's review commen
Hi Matt,
On Thu, Nov 15, 2018 at 02:13:45PM -0800, Matt Roper wrote:
>Some display controllers can be programmed to present non-black colors
>for pixels not covered by any plane (or pixels covered by the
>transparent regions of higher planes). Compositors that want a UI with
>a solid color backgr
Hi Uma,
On Tue, Nov 27, 2018 at 10:10:42PM +0530, Uma Shankar wrote:
> This patch adds a DP colorspace property, enabling
> userspace to switch to various supported colorspaces.
> This will help enable BT2020 along with other colorspaces.
>
> v2: Addressed Maarten and Ville's review comments. Enh
Hi,
On Tue, Nov 27, 2018 at 10:10:40PM +0530, Uma Shankar wrote:
> This patch series creates a new connector property to program
> colorspace to sink devices. Modern sink devices support more
> than 1 type of colorspace like 601, 709, BT2020 etc. This helps
> to switch based on content type which
On Wed, Nov 28, 2018 at 02:29:53PM +, Shankar, Uma wrote:
>
>
> >-Original Message-
> >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of
> >Brian Starkey
> >Sent: Wednesday, November 28, 2018 5:27 PM
> >To: Shan
Hi,
On Fri, Nov 30, 2018 at 04:34:54PM +0100, Hans Verkuil wrote:
> On 11/30/18 16:16, Ville Syrjälä wrote:
> > On Fri, Nov 30, 2018 at 03:48:00PM +0100, Hans Verkuil wrote:
> >> On 11/30/18 15:29, Ville Syrjälä wrote:
> >>> On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote:
> Hi
prevent duplication of similar logic.
This looks like a good idea to me.
I wonder if the two "has_alpha" and "is_yuv" bools should be bitfields
to reduce the footprint (not sure what the general DRM attitude to
bitfields is), but either way:
Reviewed-by: Brian Starkey
Signe
Hi,
On Wed, Aug 22, 2018 at 12:53:58PM +0300, Ville Syrjälä wrote:
On Wed, Aug 22, 2018 at 08:40:19AM +, Lankhorst, Maarten wrote:
fre 2018-08-17 klockan 19:48 +0530 skrev Uma Shankar:
> Add a blob property for plane CSC usage.
>
> v2: Rebase
>
> v3: Fixed Sean, Paul's review comments. Move
docs
to match the current implementation, and change the type from __s64
to __u64 to drive the point home.
I totally agree that this is a good idea, but...
Cc: dri-de...@lists.freedesktop.org
Cc: Mihail Atanassov
Cc: Liviu Dudau
Cc: Brian Starkey
Cc: Mali DP Maintainers
Cc: Johnson Lin
Cc
On Fri, Jul 22, 2016 at 04:43:05PM +0300, Ville Syrjälä wrote:
From: Ville Syrjälä
The global mode_config.rotation_property is going away, switch over to
per-plane rotation_property.
Cc: Liviu Dudau
Cc: Brian Starkey
Cc: Mali DP Maintainers
Signed-off-by: Ville Syrjälä
Acked-by: Brian
r case the
CFLAGS is not propagated through, this one can get build issues
regardless of the actual state of the toggle.
v2: Add -I for the include directive and correctly propagate
$(top_srcdir).
Cc: Brian Starkey
Cc: Robert Foss
Reported-by: Brian Starkey
Signed-off-by: Emil Velikov
---
T
: Brian Starkey
Reported-by: Brian Starkey
Signed-off-by: Emil Velikov
---
An alternative would be to $ git mv tools/intel_aub.h lib/stubs/drm/ and
drop the intel_aub.h reference from tools/Makefile.am.
Hm, that sounds like the approach with more consistency, but either
approach has my ack.
-Daniel
-intel case.
Cc: Brian Starkey
Reported-by: Brian Starkey
Signed-off-by: Emil Velikov
---
Works for me, I can now build with
./configure --disable-intel --disable-nouveau --disable-vc4
So:
Tested-by: Brian Starkey
Thanks!
-Brian
lib/stubs/drm/README | 6 +++---
{tools =>
Hi Gustavo,
A little late to the party here, but I was blocked by our internal
contributions process...
I didn't see these end up in my checkout yet though, so I guess they
aren't picked up yet.
On Mon, Nov 14, 2016 at 06:59:21PM +0900, Gustavo Padovan wrote:
From: Gustavo Padovan
Add suppor
Hi,
On Mon, Nov 14, 2016 at 06:59:20PM +0900, Gustavo Padovan wrote:
From: Robert Foss
Add support dor the IN_FENCE_FD property to enable setting in fences for atomic
commits.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 20
lib/igt_kms.h | 5 +
2 files changed, 25
On Tue, Nov 22, 2016 at 11:06:00AM +, Chris Wilson wrote:
On Tue, Nov 22, 2016 at 10:53:51AM +, Brian Starkey wrote:
Hi Gustavo,
A little late to the party here, but I was blocked by our internal
contributions process...
I didn't see these end up in my checkout yet though, so I
On Tue, Nov 22, 2016 at 12:10:52PM +, Chris Wilson wrote:
On Tue, Nov 22, 2016 at 11:54:57AM +, Brian Starkey wrote:
On Tue, Nov 22, 2016 at 11:06:00AM +, Chris Wilson wrote:
>On Tue, Nov 22, 2016 at 10:53:51AM +0000, Brian Starkey wrote:
>>Hi Gustavo,
>>
>>
On Tue, Nov 22, 2016 at 02:12:59PM +0100, Daniel Vetter wrote:
On Tue, Nov 22, 2016 at 12:37:47PM +, Brian Starkey wrote:
On Tue, Nov 22, 2016 at 12:10:52PM +, Chris Wilson wrote:
> On Tue, Nov 22, 2016 at 11:54:57AM +0000, Brian Starkey wrote:
> > On Tue, Nov 22, 2016 at 1
On Tue, Nov 22, 2016 at 02:56:49PM +0100, Daniel Vetter wrote:
On Tue, Nov 22, 2016 at 01:50:53PM +, Brian Starkey wrote:
On Tue, Nov 22, 2016 at 02:12:59PM +0100, Daniel Vetter wrote:
> On Tue, Nov 22, 2016 at 12:37:47PM +0000, Brian Starkey wrote:
> > On Tue, Nov 22, 2016 at 1
Hi,
On Wed, Dec 14, 2016 at 04:05:03AM -0500, Robert Foss wrote:
Add support dor the IN_FENCE_FD property to enable setting in fences for atomic
commits.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 20
lib/igt_kms.h | 5 +
2 files changed, 25 insertions(+)
diff --gi
Hi,
On Wed, Dec 14, 2016 at 04:05:04AM -0500, Robert Foss wrote:
From: Gustavo Padovan
Add support for the OUT_FENCE_PTR property to enable setting out fences for
atomic commits.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 21 -
lib/igt_k
Hi,
On Wed, Dec 14, 2016 at 04:05:05AM -0500, Robert Foss wrote:
From: Gustavo Padovan
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
tests/kms_atomic.c | 186 ++---
1 file changed, 176 insertions(+), 10 deletions(-)
diff --git a
On Wed, Dec 14, 2016 at 04:05:07AM -0500, Robert Foss wrote:
From: Gustavo Padovan
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 22 ++
tests/kms_atomic_transition.c | 32 ++--
2 files changed, 52 in
On Fri, Dec 16, 2016 at 03:21:45AM -0500, Robert Foss wrote:
On 2016-12-14 11:13 AM, Brian Starkey wrote:
Hi,
On Wed, Dec 14, 2016 at 04:05:04AM -0500, Robert Foss wrote:
From: Gustavo Padovan
Add support for the OUT_FENCE_PTR property to enable setting out
fences for
atomic commits
On Fri, Dec 16, 2016 at 03:35:36AM -0500, Robert Foss wrote:
On 2016-12-14 11:39 AM, Brian Starkey wrote:
Hi,
On Wed, Dec 14, 2016 at 04:05:05AM -0500, Robert Foss wrote:
From: Gustavo Padovan
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
tests/kms_atomic.c | 186
On Fri, Dec 16, 2016 at 03:59:00AM -0500, Robert Foss wrote:
On 2016-12-14 11:57 AM, Brian Starkey wrote:
On Wed, Dec 14, 2016 at 04:05:07AM -0500, Robert Foss wrote:
From: Gustavo Padovan
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 22
On Mon, Jan 30, 2017 at 08:58:42PM -0500, Robert Foss wrote:
Add support dor the IN_FENCE_FD property to enable setting in fences for atomic
commits.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 20
lib/igt_kms.h | 5 +
2 files changed, 25 insertions(+)
diff --git a/l
On Mon, Jan 30, 2017 at 08:58:43PM -0500, Robert Foss wrote:
From: Gustavo Padovan
Add support for the OUT_FENCE_PTR property to enable setting out fences for
atomic commits.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 26 +-
lib/igt_k
This one lgtm, just need to swap all the uint64_t out_fence_ptrs for
int32_t.
-Brian
On Mon, Jan 30, 2017 at 08:58:44PM -0500, Robert Foss wrote:
From: Gustavo Padovan
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
tests/kms_atomic.c | 187
On Mon, Jan 30, 2017 at 08:58:46PM -0500, Robert Foss wrote:
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 35 ++
tests/kms_atomic_transition.c | 148 ++
2 files changed, 169 insertions(+), 14 deletio
On Mon, Jan 30, 2017 at 08:58:47PM -0500, Robert Foss wrote:
From: Gustavo Padovan
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 3 +++
tests/kms_atomic_transition.c | 48 ++-
2 files changed, 32 insertions
On Mon, Jan 30, 2017 at 08:58:41PM -0500, Robert Foss wrote:
Added the igt_pipe_get_last_out_fence() helper function
that wraps accesses to pipe->fence_out.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 8
lib/igt_kms.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/lib/igt_kms.c
On Tue, Jan 31, 2017 at 08:25:14PM -0500, Robert Foss wrote:
Add support dor the IN_FENCE_FD property to enable setting in fences for atomic
commits.
trivial... s/dor/for/
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 25 +
lib/igt_kms.h | 5 +
2 files changed, 3
On Tue, Jan 31, 2017 at 08:25:15PM -0500, Robert Foss wrote:
From: Gustavo Padovan
Add support for the OUT_FENCE_PTR property to enable setting out fences for
atomic commits.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 23 ++-
lib/igt_kms.
On Tue, Jan 31, 2017 at 08:25:18PM -0500, Robert Foss wrote:
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 16 +
tests/kms_atomic_transition.c | 153 --
2 files changed, 164 insertions(+), 5 deletions(-)
On Tue, Jan 31, 2017 at 08:25:20PM -0500, Robert Foss wrote:
Added the igt_pipe_get_last_out_fence() helper function
that wraps accesses to pipe->fence_out.
Signed-off-by: Robert Foss
---
lib/igt_kms.c | 8
lib/igt_kms.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/lib/igt_kms.c
Hi Robert,
Some minor comments on 5, 6, 9, 10 and 11. With those addressed, the
whole series is:
Reviewed-by: Brian Starkey
Thanks!
-Brian
P.S. Immediately after hitting send I realised I should have trimmed
that blob from my reply. Sorry for bouncing that back to everyone!
On Tue, Jan 31
Hi,
Having just caught up on IRC I'm sure I'm far too late for this party,
but...
Wouldn't this whole thing be a whole lot simpler if "IN_FORMATS"
stored "pointers" to separate blobs for the format and modifier lists?
struct drm_format_modifier_blob {
#define FORMAT_BLOB_CURRENT 1
/* Ve
Hi Daniel,
On Wed, May 03, 2017 at 12:47:18PM +0100, Daniel Stone wrote:
Hi Brian,
On 3 May 2017 at 12:00, Brian Starkey wrote:
Having just caught up on IRC I'm sure I'm far too late for this party,
but...
Wouldn't this whole thing be a whole lot simpler if "IN_FORMATS&q
Hi,
On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote:
Updated blob layout (Rob, Daniel, Kristian, xerpi)
Cc: Rob Clark
Cc: Daniel Stone
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/drm_mode_config.c | 7 +++
drivers/gpu/drm/drm_plane.c | 119
On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote:
Hi Brian,
On 3 May 2017 at 13:51, Brian Starkey wrote:
On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote:
+ modifiers_size =
+ sizeof(struct drm_format_modifier) *
format_modifier_count
Hi Daniel,
On Wed, May 03, 2017 at 03:07:40PM +0100, Daniel Stone wrote:
Hi Brian,
On 3 May 2017 at 15:03, Brian Starkey wrote:
On Wed, May 03, 2017 at 02:51:18PM +0100, Daniel Stone wrote:
formats_offset is the end of the fixed-size element, which is
currently aligned to 32 bytes, and
igt_pipe_crc_new() is skipped for non-Intel devices, but the later calls
to collect_crcs_mask() will attempt to retrieve CRC values if the
pipe_crcs pointers are non-NULL.
Zero-initialise pipe_crcs to avoid accessing garbage pointers on
non-Intel devices.
Signed-off-by: Brian Starkey
---
tests
Remove a bunch of branches, functionally equivalent.
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 34 ++
1 file changed, 10 insertions(+), 24 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 4ca9145726e2..783c891aebf1 100644
--- a/lib
In the loop looking for planes on a pipe, we always want to free up
the drm_plane afterwards.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-off-by: Brian Starkey
---
Hi,
This series cleans up igt_display_init a bit.
- Fixes a memory leak.
- Fixes out-of
ent logic.
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index ef7bfd1a8108..6fbe67139d98 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1824,20 +1824,11 @@ void igt_display_i
e isn't included in n_planes anyway,
which means there's no way to ever access it/know that it's there - so
just remove it entirely.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-off-by: Brian Starkey
---
lib/igt_kms.c |6 --
1 file changed, 6 del
If there's no primary plane, pipe->plane_primary == -1, and the assert
meant to check that it's valid will access pipe->planes[-1].
Fix that to check that pipe->plane_primary has been set instead.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-of
On Sun, Feb 19, 2017 at 03:39:48PM -0500, Robert Foss wrote:
On 2017-02-17 12:54 PM, Brian Starkey wrote:
In the loop looking for planes on a pipe, we always want to free up
the drm_plane afterwards.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-off-by: Brian
On Sun, Feb 19, 2017 at 03:41:45PM -0500, Robert Foss wrote:
On 2017-02-17 12:54 PM, Brian Starkey wrote:
Remove a bunch of branches, functionally equivalent.
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 34 ++
1 file changed, 10 insertions(+), 24
In the loop looking for planes on a pipe, we always want to free up
the drm_plane afterwards.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-off-by: Brian Starkey
Reviewed-by: Robert Foss
---
lib/igt_kms.c |8 +++-
1 file changed, 3 insertions(+), 5
If there's no primary plane, pipe->plane_primary == -1, and the assert
meant to check that it's valid will access pipe->planes[-1].
Fix that to check that pipe->plane_primary has been set instead.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-of
ent logic.
Signed-off-by: Brian Starkey
Reviewed-by: Robert Foss
---
lib/igt_kms.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 60c4c260bf2d..8751c97f7a06 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1679,20 +1679
Remove a bunch of branches, functionally equivalent.
Changes since v1:
- Added back display->has_cursor_plane assignment
Signed-off-by: Brian Starkey
Reviewed-by: Robert Foss
---
lib/igt_kms.c | 33 ++---
1 file changed, 10 insertions(+), 23 deletions(-)
d
e isn't included in n_planes anyway,
which means there's no way to ever access it/know that it's there - so
just remove it entirely.
Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support
Signed-off-by: Brian Starkey
Reviewed-by: Robert Foss
---
lib/igt_kms.c |6 -
-128x128-top-edge
igt@kms_ccs@bad-rotation-90
igt@kms_busy@flip-blt-A
igt@kms_mmap_write_crc
There were no changes to any test on 11 hosts (ILK to KBL).
(3 fails on bad-rotation-90 stays just as they were)
Thanks,
Brian
On Mon, Feb 20, 2017 at 11:02:44AM +, Brian Starkey wrote:
In the loop
In trying to fix igt_display_init() for devices without cursors, I
actually made matters worse. Fix the assert.
Fixes: 545aa3398223 lib/igt_kms: Remove redundant cursor code
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
Hi Uma,
On Tue, Nov 07, 2017 at 05:36:26PM +0530, Uma Shankar wrote:
Add a blob property for plane CSC usage.
v2: Rebase
Signed-off-by: Uma Shankar
---
drivers/gpu/drm/drm_atomic.c| 10 ++
drivers/gpu/drm/drm_atomic_helper.c |3 +++
drivers/gpu/drm/drm_mode_config.c |
Hi,
On Tue, Nov 07, 2017 at 05:36:25PM +0530, Uma Shankar wrote:
Add Plane Degamma as a blob property and plane
degamma size as a range property.
v2: Rebase
Signed-off-by: Uma Shankar
---
drivers/gpu/drm/drm_atomic.c| 12
drivers/gpu/drm/drm_atomic_helper.c |6 ++
On Tue, Nov 07, 2017 at 05:49:56PM +, Brian Starkey wrote:
In one of the previous discussions[1] related to per-plane color
management, Lionel suggested that the 16-bit color lut entries weren't
enough when considering HDR.
It might be worth creating a new gamma lut format with 3
Stone
Cc: Keith Packard
Cc: tfh...@err.no
Signed-off-by: Daniel Vetter
---
Documentation/gpu/introduction.rst | 11 +++
1 file changed, 11 insertions(+)
LGTM, thanks.
Acked-by: Brian Starkey
___
Intel-gfx mailing list
Intel-gf
.
Patch 7 allows "video=" on the kernel command-line to override a
connector's default mode. I don't know if that's widely useful, but we
like to use it on our FPGA platforms.
All comments/feedback welcome,
Thanks,
Brian
Brian Starkey (7):
lib/igt_kms: Fix
fault mode.
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 5837a9f112a6..474aa005b9fa 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1575,9 +1575,6 @@ static void igt_outp
If "video=" is specified on the kernel command-line, use it to override
the default mode in kmstest_get_connector_default_mode.
If a mode override was provided on the command-line, it was probably for
good reason so we should honor it.
Signed-off-by: Brian Starkey
---
lib/igt_km
Not all elements in the crc array may be valid, so only use the valid
ones to generate the string.
Signed-off-by: Brian Starkey
---
lib/igt_debugfs.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index f5ed3dafee8a
It's not used anymore, so remove it.
Signed-off-by: Brian Starkey
---
lib/igt_debugfs.c |5 -
1 file changed, 5 deletions(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 7584be5f9cc1..f5ed3dafee8a 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -84,11
In trying to fix igt_display_init() for devices without cursors, I
actually made matters worse. Fix the assert.
Fixes: 545aa3398223 lib/igt_kms: Remove redundant cursor code
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
Separate out the CRC code for better compartmentalisation. Should ease
the addition of more/different CRC sources in the future.
Signed-off-by: Brian Starkey
---
lib/Makefile.sources |2 +
lib/igt_chamelium.h |1 +
lib/igt_crc.c | 563
igt_get_all_cairo_formats() allocates the format list on the heap, but
returns it in a const pointer. Change this so that callers can free the
array without a warning, and free the array in all callers.
Signed-off-by: Brian Starkey
---
lib/igt_fb.c |4 +++-
lib/igt_fb.h |2
On Tue, Apr 25, 2017 at 07:58:18PM +0300, Ville Syrjälä wrote:
On Tue, Apr 25, 2017 at 05:45:13PM +0100, Brian Starkey wrote:
If "video=" is specified on the kernel command-line, use it to override
the default mode in kmstest_get_connector_default_mode.
If a mode override was provi
On Tue, Apr 25, 2017 at 02:43:13PM -0300, Gabriel Krisman Bertazi wrote:
Brian Starkey writes:
igt_get_all_cairo_formats() allocates the format list on the heap, but
returns it in a const pointer. Change this so that callers can free the
array without a warning, and free the array in all
Hi Uma,
On Tue, Jan 29, 2019 at 01:30:43PM +, Shankar, Uma wrote:
>
>
> >-Original Message-
> >From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com]
> >Sent: Tuesday, January 29, 2019 5:54 PM
> >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org;
> >dri-de...@lists.freed
On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> drm_color_lut_check() doens't modify the passed in blob so
s/doens't/doesn't/
Otherwise, LGTM.
Reviewed-by:
> let's make it const.
>
> Also s/uint32_y/u32/ while at it.
>
> Cc: Matt Roper
> Signed-off
Hi,
On Tue, Jan 15, 2019 at 05:47:46PM +, Liviu Dudau wrote:
> From: Brian Starkey
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 13d3a9ceb..acb27982b 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -349,6 +349,9 @@ struct igt_pipe {
>
Hi Liviu,
On Tue, Jan 15, 2019 at 05:47:42PM +, Liviu Dudau wrote:
> From: Brian Starkey
[snip]
>
> +/**
> + * igt_output_set_writeback_fb:
> + * @output: Target output
> + * @fb: Target framebuffer
> + *
> + * This function sets the given @fb to be used as th
an, I've done the v3 and v4
> updates to them.
>
> Best regards,
> Liviu
>
> Changelog:
> - v5: Addressed comments from Brian Starkey. Old v4 changes are here:
>https://lists.freedesktop.org/archives/igt-dev/2018-November/006806.html
I just replied with two super mino
Add support in igt_kms for writeback connectors, with the ability
to attach framebuffers.
v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before
drmModeGetResources()
Signed-off-by: Brian Starkey
[rebased and updated to the latest igt style]
Signed-off-by: Liviu Dudau
Signed-off-by
_fb_mod_to_tiling to DRM_FORMAT_MOD_LINEAR
- Rename tests
- Replace int ret by unsigned int fd_id when calling igt_create_fb
Signed-off-by: Brian Starkey
[rebased and updated do_writeback_test() function to address feedback]
Signed-off-by: Liviu Dudau
[rebased and updated the patch to address fee
ole stride, just copy fb->width * cpp since
we're only going to read that
v5: use igt_memcpy_from_wc() instead of plain memcpy, as suggested by
Chris Wilson
Signed-off-by: Brian Starkey
[rebased and updated to the most recent API]
Signed-off-by: Liviu Dudau
[rebased and updated the patch
error message if sync_fence_wait fail
- Replace color_idx variable by i
- Use in_fb instead of out_fb for getting the expected CRC
- Drop unnecessary parentheses
- Replace igt_fb_mod_to_tiling to DRM_FORMAT_MOD_LINEAR
Signed-off-by: Brian Starkey
[rebased and updated the patch to address fee
Add support in igt_kms for writeback connectors, with the ability
to attach framebuffers.
v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before
drmModeGetResources()
Signed-off-by: Brian Starkey
[rebased and updated to the latest igt style]
Signed-off-by: Liviu Dudau
---
lib/igt_kms.c
Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and
WRITEBACK_FB_ID properties on writeback connectors, ensuring their
behaviour is correct.
Signed-off-by: Brian Starkey
[rebased and updated do_writeback_test() function to address feedback]
Signed-off-by: Liviu Dudau
Add a test which makes commits using the writeback connector, and
checks the output buffer hash to make sure it is/isn't written as
appropriate.
Signed-off-by: Brian Starkey
---
tests/kms_writeback.c | 124 ++
1 file changed, 124 insertions(+)
diff
advantage of word-access speedup), we can do the hash
on a cached copy, which is much faster (10x speedup on my platform).
v6: use igt_memcpy_from_wc() instead of plain memcpy, as suggested by
Chris Wilson
Signed-off-by: Brian Starkey
[rebased and updated to the most recent API]
Signed-off-by
An output can be added as a clone of any other output(s) attached to a
pipe using igt_output_clone_pipe()
v5: Drop field out_fence_requested from struct igt_pipe (Brian Starkey)
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 100 +++---
lib
Update the connector search to also optionally attempt to find a
non-writeback connector to clone to.
Add a subtest which is the same as writeback-check-output, but also
clones to the second connector.
Signed-off-by: Brian Starkey
[rebased and addressed comments by Maarten]
Signed-off-by: Liviu
Hi Uma,
On Wed, Mar 20, 2019 at 04:18:16PM +0530, Uma Shankar wrote:
> CEA 861.3 spec adds colorimetry data block for HDMI.
> Parsing the block to get the colorimetry data from
> panel.
>
While code which parses these parts (patches 2 and 3) out of EDID
could be useful - it doesn't seem to actua
Hi Uma,
On Wed, Mar 20, 2019 at 04:18:14PM +0530, Uma Shankar wrote:
> This patch adds a blob property to get HDR metadata
> information from userspace. This will be send as part
> of AVI Infoframe to panel.
>
> v2: Rebase and modified the metadata structure elements
> as per Ville's POC changes.
On Wed, Mar 20, 2019 at 04:18:19PM +0530, Uma Shankar wrote:
> Enable Dynamic Range and Mastering Infoframe for HDR
> content, which is defined in CEA 861.3 spec.
>
> The metadata will be computed based on blending
> policy in userspace compositors and passed as a connector
> property blob to driv
Hi,
On Wed, Mar 20, 2019 at 04:18:18PM +0530, Uma Shankar wrote:
> This patch implements get() and set() functions for HDR output
> metadata property.The blob data is received from userspace and
> saved in connector state, the same is returned as blob in get
> property call to userspace.
>
> v2:
Hi,
On Wed, Mar 20, 2019 at 04:18:26PM +0530, Uma Shankar wrote:
> Added the const version of infoframe for DRM metadata
> for HDR.
>
> Signed-off-by: Uma Shankar
Unless there's a strong reason not to, I think this can be squashed
into patch 6.
> ---
> drivers/video/hdmi.c | 63
> +++
Hi,
On Fri, Mar 22, 2019 at 01:06:01PM +, Shankar, Uma wrote:
>
>
> >-Original Message-
> >From: Roper, Matthew D
> >Sent: Friday, March 22, 2019 2:50 AM
> >To: Shankar, Uma
> >Cc: intel-gfx@lists.freedesktop.org; Lankhorst, Maarten
> >; Syrjala, Ville ;
> >Sharma,
> >Shashank
> >
On Fri, Mar 22, 2019 at 04:02:57PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 22, 2019 at 01:39:04PM +0000, Brian Starkey wrote:
> > Hi,
> >
> > On Fri, Mar 22, 2019 at 01:06:01PM +, Shankar, Uma wrote:
> > >
> > >
> > > >-Original Mes
97 matches
Mail list logo
