Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-11 Thread Chiou, Cooper
> I was referring to the original performance regression report which came > from LKP which was on "i7-7567U" so Kabylake. Can yo find such machine to > test on? [Chiou, Cooper] Yes, lkp-tests team has tested this patch on lkp-kbl-nuc1 (KBL i7-7567U) as the following mail thr

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-10 Thread Chiou, Cooper
> The issue is that if the regression is reproducible it means that the > broadcast > mask is no longer correct (or never was, one or the other ;) And another w/a > is going astray because it depends on the previous undefined value of the > mcr. [Chiou, Cooper] I think we might fo

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-10 Thread Chiou, Cooper
> From: Tvrtko Ursulin > Hi, > > On 08/03/2021 17:32, Chiou, Cooper wrote: > > I've tested on GLK, KBL, CFL Intel NUC devices and got the following > performance results, there is no performance regression per my testing. > >

Re: [Intel-gfx] [PATCH v5] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-09 Thread Chiou, Cooper
I've tested on GLK, KBL, CFL Intel NUC devices and got the following performance results, there is no performance regression per my testing. and CI build test has passed as well. Patch: [v5] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Test suite: phoronix-test-suite.

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-08 Thread Chiou, Cooper
I've tested on GLK, KBL, CFL Intel NUC devices and got the following performance results, there is no performance regression per my testing. Patch: [v5] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Test suite: phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultim

Re: [Intel-gfx] [PATCH v5] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-05 Thread Chiou, Cooper
Hi Rong, Please help to trigger 3D performance test on several Gen9 CI test boxes which different fusing sku with/without “patch v5”, and share the results. Thanks, Best Regards, Cooper ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-05 Thread Chiou, Cooper
Hi Rong, Please help to trigger 3D performance test on several Gen9 CI test boxes which different fusing sku with/without “patch v5”. Thanks, Best Regards, Cooper > On Mar 6, 2021, at 12:01 AM, Tvrtko Ursulin > wrote: > >  >> On 05/03/2021 15:24, Chiou, Cooper wrote: &g

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-05 Thread Chiou, Cooper
After switched to ffs from fls in "patch v5"(https://patchwork.freedesktop.org/series/81764/#rev7), now CI result is PASS no regression in wa_verify warning. @Chen, Rong Could you please run “phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultimate.1.GranParadisoIsland.frames_per_second”

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-03-04 Thread Chiou, Cooper
> <3> [198.221812] [drm:wa_verify [i915]] *ERROR* engine workaround lost > on application! (reg[b004]=0x0, relevant bits were 0x0 vs expected 0x80) <3> > [198.222751] [drm:wa_verify [i915]] *ERROR* engine workaround lost on > application! (reg[b118]=0x0, relevant bits were 0x0 vs expected 0x20)

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-01 Thread Chiou, Cooper
Hi Tvrtko, This WaProgramMgsrForCorrectSliceSpecificMmioReads info can be found on bspec WA#0575 and it's necessary for GT subslice fuse sku on PC7 exit case while running VP8 hw encode, it impacted CrOS projects since google disabled VP8 HW encode feature on Gen9 sku, so that's why we need this

Re: [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-02-17 Thread Chiou, Cooper
gards, Cooper -Original Message- From: Chiou, Cooper Sent: Thursday, September 17, 2020 2:08 AM To: intel-gfx@lists.freedesktop.org Cc: Chiou, Cooper ; Ville Syrjälä ; Vivi, Rodrigo ; Nikula, Jani ; Chris Wilson ; Tvrtko Ursulin ; Tseng, William ; Lee, Shawn C Subject: [PATCH] drm

Re: [Intel-gfx] [drm/i915] 04ff178484: phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultimate.1.GranParadisoIsland.frames_per_second -30.4% regression

2021-02-16 Thread Chiou, Cooper
:46 AM To: Chiou, Cooper Cc: Tang, Feng ; Li, Tiejun ; Chris Wilson ; Du, Frank ; Chen, Guobing ; Tseng, William ; Xie, Gengxin ; Fan, Shuhua ; Zhao, Fan ; Huang, Ying ; Kang, Shan ; Xing, Zhengjun ; Huang, Wenhuan ; Nikula, Jani ; intel-gfx@lists.freedesktop.org; l...@lists.01.org; Chen

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-02-09 Thread Chiou, Cooper
From this CI warning log, there are all known warning message in i915 driver and is not caused by my patch. Warning 1: <3> [69.081809] [drm:wa_verify [i915]] *ERROR* engine workaround lost on application! (reg[b004]=0x0, relevant bits were 0x0 vs expected 0x80) Warning 2: <3> [619.188270] i915/i

Re: [Intel-gfx] [drm/i915] 04ff178484: phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultimate.1.GranParadisoIsland.frames_per_second -30.4% regression

2021-01-21 Thread Chiou, Cooper
, Cooper +886-2-6622-1166 -Original Message- From: kernel test robot Sent: Monday, September 21, 2020 5:22 PM To: Chiou, Cooper Cc: intel-gfx@lists.freedesktop.org; Chiou, Cooper ; Tseng, William ; Nikula, Jani ; Chris Wilson ; lkp ; Ville Syrjälä ; Vivi, Rodrigo ; Tvrtko Ursulin ; Lee

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-10 Thread Chiou, Cooper
Thanks Ville, I'll backport your patch (drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes) to CrOS kernel for resolving this issue. Please abandon my patch. Best Regards, Cooper ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-10 Thread Chiou, Cooper
6622-1166 -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Tuesday, April 9, 2019 23:57 PM To: Chiou, Cooper Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; ch...@freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Chiou, Cooper
run CrOS on GLK with changed VBT to validate it. Thanks, Best Regards, Cooper On Apr 9, 2019, at 8:45 PM, Ville Syrjälä mailto:ville.syrj...@linux.intel.com>> wrote: On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote: VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x

[Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Chiou, Cooper
HDMI_MAX_DATA_RATE_297 should be 2 and HDMI_MAX_DATA_RATE_165 should be 4 TEST: Validated PASS on GLK RVP platform Cc: Jani Nikula Signed-off-by: Chiou, Cooper --- drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915