th a lock to be called from other
places from other places.
Maybe we have to make eld_notify not do anything except to call
schedule_work then? And that work in turn will ask for updated eld from
the i915 driver, and handle the result.
--
David Henningsson, Canonical Ltd.
https://launc
dec->card) != SNDRV_CTL_POWER_D0)
+ return;
+
check_presence_and_report(codec, pin_nid);
}
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 2015-11-26 16:23, Takashi Iwai wrote:
On Thu, 26 Nov 2015 16:08:06 +0100,
David Henningsson wrote:
On 2015-11-26 10:24, Takashi Iwai wrote:
On Thu, 26 Nov 2015 10:16:17 +0100,
Zhang, Xiong Y wrote:
On Thu, 26 Nov 2015 08:57:30 +0100,
Zhang, Xiong Y wrote:
BTW, I have a patchset
well is off when we try to talk to
the HDA controller. That means either the i915 shut it down while we
were holding a lock on it, or HDA tried to lock it and that didn't make
it through; in which case the HDA side should handle an error from
get_power more gracefully...?
Signed-off-by: David Henningsson
---
Now rebased against drm-intel git master.
include/drm/i915_component.h | 69
1 file changed, 51 insertions(+), 18 deletions(-)
diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h
index
On 2015-10-12 10:07, David Henningsson wrote:
To make kernel-doc happy, the i915_audio_component_audio_ops struct
cannot be nested.
Signed-off-by: David Henningsson
---
Changes since v1:
* Added a notice about when pin_eld_notify is called
* Uses new inline struct member style
To make kernel-doc happy, the i915_audio_component_audio_ops struct
cannot be nested.
Signed-off-by: David Henningsson
---
Documentation/DocBook/drm.tmpl | 1 +
include/drm/i915_component.h | 92 ++
2 files changed, 67 insertions(+), 26 deletions
On 2015-09-04 10:03, Daniel Vetter wrote:
Also please use the new inline style for struct members.
I tried that, but I couldn't get it to work. This was with Takashi's
for-next tree, do I need to apply some docbook special patches on top of
that to get the new functionality?
To make kernel-doc happy, the i915_audio_component_audio_ops struct
cannot be nested.
Signed-off-by: David Henningsson
---
Note that I didn't do the same un-nesting for i915_audio_component_ops.
This is to make it easier to merge the pending sync_audio_rate patch set.
It applies on top
On 2015-09-03 10:31, Takashi Iwai wrote:
On Thu, 03 Sep 2015 09:52:00 +0200,
David Henningsson wrote:
On 2015-08-28 19:02, David Henningsson wrote:
Hopefully last version? :-)
* Added commit text about duplicate events (patch 4/4)
* Added locks in bind/unbind on i915 side (patch 2
On 2015-08-28 19:02, David Henningsson wrote:
Hopefully last version? :-)
* Added commit text about duplicate events (patch 4/4)
* Added locks in bind/unbind on i915 side (patch 2/4)
* Fixed docbook comments in i915 struct (patch 1/4)
* Removed port_mst_streaming parameter (patch 1/4
This lets the interested codec be notified when an i915 pin/ELD
event happens.
Reviewed-by: Takashi Iwai
Signed-off-by: David Henningsson
---
include/sound/hda_i915.h | 7 +++
sound/hda/hdac_i915.c| 10 ++
2 files changed, 17 insertions(+)
diff --git a/include/sound/hda_i915
When the audio codec is enabled or disabled, notify the audio driver.
This will enable the audio driver to get the notification at all times
(even when audio is in different powersave states).
Reviewed-by: Jani Nikula
Signed-off-by: David Henningsson
---
drivers/gpu/drm/i915/i915_drv.h| 1
mp; 4 by Takashi.
Hopefully this was correct, otherwise feel free to adjust
yourself before committing.
Both Jani and Takashi seem okay with this going into 4.3.
Nobody has said which tree you prefer to take it through, so
how about Takashi merging it?
David Henningsson (4):
drm/i915: Add a
This callback will be called by the i915 driver to notify the hda
driver that its HDMI information needs to be refreshed, i e,
that audio output is now available (or unavailable) - usually as a
result of a monitor being plugged in (or unplugged).
Reviewed-by: Jani Nikula
Signed-off-by: David
we get two callbacks from the same event,
one from the unsol event and one from the i915 driver, but this is
not harmful and can be optimised away in a later patch.
Reviewed-by: Takashi Iwai
Signed-off-by: David Henningsson
---
sound/pci/hda/patch_hdmi.c | 22 +-
1 file
On 2015-08-28 15:07, Jani Nikula wrote:
On Wed, 19 Aug 2015, David Henningsson wrote:
When the audio codec is enabled or disabled, notify the audio driver.
This will enable the audio driver to get the notification at all times
(even when audio is in different powersave states).
Signed-off
On 2015-08-26 10:33, Daniel Vetter wrote:
On Wed, Aug 19, 2015 at 10:48:55AM +0200, David Henningsson wrote:
This callback will be called by the i915 driver to notify the hda
driver that its HDMI information needs to be refreshed, i e,
that audio output is now available (or unavailable
On 2015-08-20 11:28, Takashi Iwai wrote:
On Wed, 19 Aug 2015 10:48:58 +0200,
David Henningsson wrote:
Whenever there is an event from the i915 driver, wake the codec
and recheck plug/unplug + ELD status.
This fixes the issue with lost unsol events in power save mode,
the codec and
working on one Skylake machine.
David Henningsson (4):
drm/i915: Add audio pin sense / ELD callback
drm/i915: Call audio pin/ELD notify function
ALSA: hda - allow codecs to access the i915 pin/ELD callback
ALSA: hda - Wake the codec up on pin/ELD notify events
drivers/gpu/drm/i915/i915_drv.h
This lets the interested codec be notified when an i915 pin/ELD
event happens.
Signed-off-by: David Henningsson
---
include/sound/hda_i915.h | 7 +++
sound/hda/hdac_i915.c| 10 ++
2 files changed, 17 insertions(+)
diff --git a/include/sound/hda_i915.h b/include/sound/hda_i915
When the audio codec is enabled or disabled, notify the audio driver.
This will enable the audio driver to get the notification at all times
(even when audio is in different powersave states).
Signed-off-by: David Henningsson
---
drivers/gpu/drm/i915/i915_drv.h| 1 +
drivers/gpu/drm/i915
This callback will be called by the i915 driver to notify the hda
driver that its HDMI information needs to be refreshed, i e,
that audio output is now available (or unavailable) - usually as a
result of a monitor being plugged in (or unplugged).
Signed-off-by: David Henningsson
---
include/drm
Whenever there is an event from the i915 driver, wake the codec
and recheck plug/unplug + ELD status.
This fixes the issue with lost unsol events in power save mode,
the codec and controller can now sleep in D3 and still know when
the HDMI monitor has been connected.
Signed-off-by: David
hdac_bus*) so that the audio
side can easily refactor the ptr to point to the codec instead of the bus
if we would find that beneficial.
David Henningsson (4):
drm/i915: Add audio hotplug info callback
drm/i915: Call audio hotplug notify function
ALSA: hda - Dispatch incoming HDMI hotplug i915
Whenever there is an event from the i915 driver, wake the codec
and recheck plug/unplug + ELD status.
This fixes the issue with lost unsol events in power save mode,
the codec and controller can now sleep in D3 and still know when
the HDMI monitor has been connected.
Signed-off-by: David
On HDMI hotplug events, notify the audio driver. This will enable
the audio driver to get the notification at all times (even when
audio is in different powersave states).
Signed-off-by: David Henningsson
---
drivers/gpu/drm/i915/i915_drv.h|1 +
drivers/gpu/drm/i915/intel_audio.c | 23
This lets interested codec(s) be notified of HDMI hotplug
events sent from the i915 driver.
Signed-off-by: David Henningsson
---
include/sound/hdaudio.h |4
sound/hda/hdac_i915.c | 23 +++
2 files changed, 27 insertions(+)
diff --git a/include/sound/hdaudio.h b
This callback will be called by the i915 driver to notify the hda
driver that HDMI has been hotplugged.
Signed-off-by: David Henningsson
---
include/drm/i915_component.h |5 +
1 file changed, 5 insertions(+)
diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h
index
On 2015-07-23 08:17, David Henningsson wrote:
I'm about to go on vacation so it would be good to get some closure
here. If you both prefer this setup, how about I remove "struct
i915_audio_hotplug_info" for now? We will then have:
const struct i915_audio_comp
On 2015-07-22 22:31, Takashi Iwai wrote:
On Wed, 22 Jul 2015 19:52:23 +0200,
David Henningsson wrote:
On 2015-07-22 16:13, Vinod Koul wrote:
On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote:
On Wed, 22 Jul 2015 10:50:03 +0200,
David Henningsson wrote:
struct
On 2015-07-22 16:13, Vinod Koul wrote:
On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote:
On Wed, 22 Jul 2015 10:50:03 +0200,
David Henningsson wrote:
struct i915_audio_component {
struct device *dev;
+ struct hdac_bus *hdac_bus;
If we want to be more generic
On 2015-07-21 19:37, R, Durgadoss wrote:
Hi David,
-Original Message-
From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of
David Henningsson
Sent: Tuesday, July 21, 2015 1:27 PM
To: alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org;
ti...@suse.de
controller can now sleep in D3 and still know when
the HDMI monitor has been connected.
Signed-off-by: David Henningsson
---
sound/pci/hda/patch_hdmi.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
ind
at this is
correct.
David Henningsson (4):
drm/i915: Add audio hotplug info struct
drm/i915: Call audio hotplug notify function
ALSA: hda - Dispatch incoming HDMI hotplug i915 callback
ALSA: hda - Wake the codec up on hotplug notify events
drivers/gpu/drm/i915/i915_drv.h|1 +
drive
This struct will be used to transfer information from the i915
driver to the hda driver on HDMI hotplug events.
Signed-off-by: David Henningsson
---
include/drm/i915_component.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/include/drm/i915_component.h b/include/drm
On HDMI hotplug events, notify the audio driver. This will enable
the audio driver to get the information at all times (even when
audio is in different powersave states), and also without reading
it from the hardware.
Signed-off-by: David Henningsson
---
drivers/gpu/drm/i915/i915_drv.h
This lets interested codec(s) be notified of HDMI hotplug
events sent from the i915 driver.
Signed-off-by: David Henningsson
---
include/sound/hdaudio.h |4
sound/hda/hdac_i915.c | 26 ++
2 files changed, 30 insertions(+)
diff --git a/include/sound
On 2015-07-22 10:22, Takashi Iwai wrote:
On Tue, 21 Jul 2015 09:57:24 +0200,
David Henningsson wrote:
This struct will be used to transfer information from the i915
driver to the hda driver on HDMI hotplug events.
Signed-off-by: David Henningsson
Looks good to me, just a few nitpicking
On 2015-07-21 11:14, Daniel Vetter wrote:
On Tue, Jul 21, 2015 at 09:57:25AM +0200, David Henningsson wrote:
On HDMI hotplug events, notify the audio driver. This will enable
the audio driver to get the information at all times (even when
audio is in different powersave states), and also
On HDMI hotplug events, notify the audio driver. This will enable
the audio driver to get the information at all times (even when
audio is in different powersave states), and also without reading
it from the hardware.
Signed-off-by: David Henningsson
---
drivers/gpu/drm/i915/i915_drv.h
This struct will be used to transfer information from the i915
driver to the hda driver on HDMI hotplug events.
Signed-off-by: David Henningsson
---
include/drm/i915_component.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/include/drm/i915_component.h b/include/drm
This lets interested codec(s) be notified of HDMI hotplug
events sent from the i915 driver.
Signed-off-by: David Henningsson
---
include/sound/hdaudio.h |4
sound/hda/hdac_i915.c | 24
2 files changed, 28 insertions(+)
diff --git a/include/sound/hdaudio.h
patch set is based on 4.2rc2 + my recent codec wakeup patch. So far, it has
been tested (and working) on one Skylake machine.
David Henningsson (4):
drm/i915: Add audio hotplug info struct
drm/i915: Call audio hotplug notify function
ALSA: hda - Dispatch incoming HDMI hotplug i915 callback
ALSA
controller can now sleep in D3 and still know when
the HDMI monitor has been connected.
Signed-off-by: David Henningsson
---
sound/pci/hda/patch_hdmi.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hd
in power.d are executed when
battery / AC-power is changed.
Takashi, does SUSE also use pm-utils?
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/m
re no such
physical ports, the audio controller has no function.
Maybe we can, before doing anything else, ask the video driver first if
this is the case, and if so, never create the sound card at all, and
just leave things the way the video driver wants?
--
David Henningsson, C
On 06/17/2013 01:54 PM, Wang, Xingchao wrote:
-Original Message-
From: David Henningsson [mailto:david.hennings...@canonical.com]
Sent: Monday, June 17, 2013 4:24 PM
To: Wang Xingchao
Cc: ti...@suse.de; daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org;
intel-gfx
n_idx);
eld = &per_pin->sink_eld;
+ if (!eld->monitor_present || !eld->eld_valid)
+ return -EIO;
+
if (codec->vendor_id == 0x80862807)
hsw_verify_cvt_D0(spec, codec);
--
David Henningsson, Canonical Ltd.
https:/
On 05/27/2013 09:30 AM, Wang xingchao wrote:
On Thu, May 16, 2013 at 09:00:06AM +0200, David Henningsson wrote:
Hi,
I want to take this problem up again, because it's important we get
this right.
The HDA driver assumes that a codec pin widget node always refers to
the same physical o
lem in modprobe
with blacklisted modules. I've just emailed the kmod maintainer (with
Wang Xingchao in cc) and asked for clarification.
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
ct pci_dev *pci)
struct snd_card *card = pci_get_drvdata(pci);
struct azx *chip = card->private_data;
- if (pci_dev_run_wake(pci))
+ if (chip->driver_caps & AZX_DCAPS_PM_RUNTIME)
pm_runtime_get_noresume(&pci->dev);
if (card)
is.
E g, imagine that a user has a dual monitor setup and always wants audio
output from the left side monitor, and keep the right side monitor
silent. If it is not reliable which codec pin refers to which physical
output, one day suddenly the sound might come out on the right side
moni
On 05/13/2013 03:50 PM, Wang, Xingchao wrote:
-Original Message-
From: David Henningsson [mailto:david.hennings...@canonical.com]
Sent: Monday, May 13, 2013 8:13 PM
To: Wang, Xingchao
Cc: Wang Xingchao; alsa-de...@alsa-project.org; dan...@ffwll.ch;
ti...@suse.de; Lin, Mengdong; intel-gfx
On 05/13/2013 01:55 PM, Wang, Xingchao wrote:
Hi David,
-Original Message-
From: alsa-devel-boun...@alsa-project.org
[mailto:alsa-devel-boun...@alsa-project.org] On Behalf Of David Henningsson
Sent: Monday, May 13, 2013 4:29 PM
To: Wang Xingchao
Cc: alsa-de...@alsa-project.org; dan
hda_display_power(true);
+ }
err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
if (err < 0) {
@@ -3822,8 +3824,10 @@ static void azx_remove(struct pci_dev *pci)
if (card)
snd_card_free(c
introduce any i915 related code in hda_codec* files.
Still, Takashi is the boss here so he has the final say :-)
Thanks
--xingchao
-----Original Message-
From: David Henningsson [mailto:david.hennings...@canonical.com]
Sent: Thursday, May 02, 2013 10:49 PM
To: Liam Girdwood
Cc: Barnes,
On 04/30/2013 04:41 PM, Liam Girdwood wrote:
On Tue, 2013-04-30 at 12:29 +0200, David Henningsson wrote:
On 04/29/2013 05:02 PM, Jesse Barnes wrote:
On Sat, 27 Apr 2013 13:35:29 +0200
Daniel Vetter wrote:
On Sat, Apr 27, 2013 at 09:20:39AM +, Wang, Xingchao wrote:
Let me throw a basic
to i915 and codec-hdmi
drivers as necessary, e g using the set_power_state callback for the
i915 stuff.
But maybe there's something smarter to do here, as I'm not experienced
in mending kernel pieces together :-)
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
_
59 matches
Mail list logo
