Re: [Intel-gfx] [PATCH] drm/i915/gt: Avoid redundant pointer validity check

On Tue, Feb 07, 2023 at 12:12:18AM +0530, Deepak R Varma wrote: > On Mon, Feb 06, 2023 at 10:33:13AM +, Matthew Auld wrote: > > On 06/02/2023 09:45, Tvrtko Ursulin wrote: > > > > > > Hi, > > > > > > Adding Matt & Thomas as pot

Re: [Intel-gfx] [PATCH] drm/i915/gt: Avoid redundant pointer validity check

On Mon, Feb 06, 2023 at 10:33:13AM +, Matthew Auld wrote: > On 06/02/2023 09:45, Tvrtko Ursulin wrote: > > > > Hi, > > > > Adding Matt & Thomas as potential candidates to review. > > > > Regards, > > > > Tvrtko > > > > On

[Intel-gfx] [PATCH] drm/i915/gt: Avoid redundant pointer validity check

The macro definition of gen6_for_all_pdes() expands to a for loop such that it breaks when the page table is null. Hence there is no need to again test validity of the page table entry pointers in the pde list. This change is identified using itnull.cocci semantic patch. Signed-off-by: Deepak R

[Intel-gfx] [PATCH v2] drm/i915/gvt: Avoid full proxy f_ops for debugfs attributes

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma Reviewed-by: Rodrigo Vivi Acked-by: Zhenyu Wang --- Changes in v2: - Following changes as suggested by Rodrigo Vivi - Combine 2 patch series in a single patch - Base the patch on the i915/gvt to avoid

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

On Tue, Jan 17, 2023 at 02:29:37PM -0500, Rodrigo Vivi wrote: > On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote: > > On 2023.01.10 13:49:57 -0500, Rodrigo Vivi wrote: > > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > > > > Using

Re: [Intel-gfx] [PATCH] drm/i915/display: Convert i9xx_pipe_crc_auto_source to void

On Tue, Jan 17, 2023 at 02:21:59PM -0500, Rodrigo Vivi wrote: > On Sat, Jan 14, 2023 at 07:33:53PM +0530, Deepak R Varma wrote: > > Convert function i9xx_pipe_crc_auto_source() to return void instead > > of int since the current implementation always returns 0 to the caller. >

[Intel-gfx] [PATCH] drm/i915/gvt: Remove extra semicolon

Remove the extra semicolon at end. Issue identified using semicolon.cocci Coccinelle semantic patch. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt

[Intel-gfx] [PATCH] drm/i915/display: Convert i9xx_pipe_crc_auto_source to void

Convert function i9xx_pipe_crc_auto_source() to return void instead of int since the current implementation always returns 0 to the caller. Issue identified using returnvar Coccinelle semantic patch. Signed-off-by: Deepak R Varma --- Please note: The change is compile tested only. drivers/gpu

[Intel-gfx] [PATCH v3 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Changes in v3: - None Changes in v2: - Include coccicheck make command in the patch log message for clarity. Suggested by Rodrigo Vivi drivers/gpu/drm/i915/display/intel_fbc.c | 12 ++-- 1 file

[Intel-gfx] [PATCH v3 1/2] drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Changes in v3: - Fix checkpatch complaint around function parameter alignment Changes in v2: - Include coccicheck make command in the patch log message for clarity. Suggested by Rodrigo Vivi drivers/gpu

[Intel-gfx] [PATCH v3 0/2] drm/i915: Avoid full proxy f_ops debug attributes

eter alignment complaint Patch 2/2: None Changes in v2: - Individual patches clubbed in patch set - Update patch log message to include coccicheck make command Deepak R Varma (2): drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes drm/i915/fbc: Avoid full proxy f

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

On Wed, Jan 11, 2023 at 10:00:11AM -0500, Rodrigo Vivi wrote: > > > Actually, could you please address the checkpatch issues before we can > > > push? > > > Sorry about that, but just noticed now when I was going to push the other > > > ones. > > > > Hello Rodrigo, > > The checkpatch warning is

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

On Tue, Jan 10, 2023 at 01:52:05PM -0500, Rodrigo Vivi wrote: > On Tue, Jan 10, 2023 at 11:45:40PM +0530, Deepak R Varma wrote: > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > function adds the overhead of introducing a proxy file operation > &

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

On Wed, Jan 11, 2023 at 05:02:02AM -0500, Rodrigo Vivi wrote: > On Tue, Jan 10, 2023 at 01:49:57PM -0500, Rodrigo Vivi wrote: > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() &

[Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c index 03f081c3d9a4..baccbf1761b7

[Intel-gfx] [PATCH 1/2] drm/i915/gvt: Avoid full proxy f_ops for scan_nonprivbb debug attributes

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/gvt/debugfs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c index 0616b73175f3

[Intel-gfx] [PATCH 0/2] drm/i915/gvt: Avoid full proxy f_ops debug attributes

vers for the scan_nonprivbb and vgpu_status f_ops debugfs attributes respectively. Following coccicheck make command helped identify this change: make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Deepak R Varma (2): drm/i915

[Intel-gfx] [PATCH v2 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Changes in v2: - Include coccicheck make command in the patch log message for clarity. Suggested by Rodrigo Vivi drivers/gpu/drm/i915/display/intel_fbc.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[Intel-gfx] [PATCH v2 1/2] drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes

/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Changes in v2: - Include coccicheck make command in the patch log message for clarity. Suggested by Rodrigo Vivi drivers/gpu/drm/i915/display/intel_drrs.c | 8 1 file changed, 4 insertions(+), 4

[Intel-gfx] [PATCH 0/2 v2] drm/i915: Avoid full proxy f_ops debug attributes

set - Update patch log message to include coccicheck make command Deepak R Varma (2): drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes drivers/gpu/drm/i915/display/intel_drrs.c | 8 drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

On Mon, Jan 09, 2023 at 02:06:13PM -0500, Rodrigo Vivi wrote: > On Sun, Jan 08, 2023 at 01:33:41AM +0530, Deepak R Varma wrote: > > On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote: > > > > Hi Julia, thanks for helping here. > > > &g

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote: > > Hi Julia, thanks for helping here. > > > > So, my question is why this > > > > make coccicheck M=drivers/gpu/drm/i915/ MODE=context > > COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > > > didn't catch this

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

On Wed, Dec 28, 2022 at 06:18:12AM -0500, Rodrigo Vivi wrote: > On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote: > > On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > > > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wr

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wrote: > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > function adds the overhead of introducing a proxy file operation > &

[Intel-gfx] [PATCH v2 1/2] drm/i915: convert i915_active.count from atomic_t to refcount_t

atomic_add_unless Signed-off-by: Deepak R Varma --- Please note: 1. Proposed changes are compile tested only. 2. This patch 1/2 is required to be applied before patch 2/2 due to interdependency. Changes in v2: 1. Patch added to the patch series. 2. Handle build issues Reported-by: kernel

[Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

to protect the original read and write function calls for the debug attributes. There is no need for any runtime proxy file operations to be managed by the debugfs core. This Change is reported by the debugfs_simple_attr.cocci Coccinelle semantic patch. Signed-off-by: Deepak R Varma --- drivers/gpu

[Intel-gfx] [PATCH] drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes

to protect the original read and write function calls for the debug attributes. There is no need for any runtime proxy file operations to be managed by the debugfs core. This Change is reported by the debugfs_simple_attr.cocci Coccinelle semantic patch. Signed-off-by: Deepak R Varma --- drivers/gpu

[Intel-gfx] [PATCH v2 2/2] drm/i915/selftests: Convert atomic_* API calls for i915_active.count refcount_*

Handle the struct i915_active member variable count transition from atomic_t type to refcount_t type for selftest use cases. Transition the atomic_*() API calls to their equivalent refcount_*() API calls. Reported-by: kernel test robot Signed-off-by: Deepak R Varma --- Please note: 1

[Intel-gfx] [PATCH] drm/i915: convert i915_active.count from atomic_t to refcount_t

atomic_add_unless Signed-off-by: Deepak R Varma --- Please note: Proposed changes are compile tested only. drivers/gpu/drm/i915/i915_active.c | 24 +--- drivers/gpu/drm/i915/i915_active.h | 6 +++--- drivers/gpu/drm/i915/i915_active_types.h | 4 ++-- 3 files changed, 18

[Intel-gfx] [PATCH v2 0/2] convert i915_active.count from atomic_t to refcount_t

* to refcount_* transition. Deepak R Varma (2): drm/i915: convert i915_active.count from atomic_t to refcount_t drm/i915/selftests: Convert atomic_* API calls for i915_active.count refcount_* drivers/gpu/drm/i915/i915_active.c | 28 +++- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2] drm/vgem: replace idr_init() by idr_init_base()

Signed-off-by: Deepak R Varma --- Changes since v1: - Changes suggested by Daniel Vetter: 1. Correct typo in patch summary 2. cc intel-gfx to get the patch through CI bot test drivers/gpu/drm/vgem/vgem_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[Intel-gfx] [PATCH] drm/i915/perf: replace idr_init() by idr_init_base()

Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index e94976976571..2d033255b7cf 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gp

[Intel-gfx] [PATCH] drm/i915/gvt: replace idr_init() by idr_init_base()

Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/gvt/gvt.c | 2 +- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c index c7c561237883..45b492edbb19 100644 --- a/drivers/gp

[Intel-gfx] [PATCH] drm/i915/gvt: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

e reported by Coccinelle script: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Please Note: This is a Outreachy project task patch. drivers/gpu/drm/i915/gvt/debugfs.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH i-g-t 4/5] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property

Some simple test cases to use FB_DAMAGE_CLIPS plane property. Signed-off-by: Deepak Rawat --- lib/igt_kms.c | 1 + lib/igt_kms.h | 1 + tests/kms_atomic.c | 260 + 3 files changed, 262 insertions(+) diff --git a/lib/igt_kms.c b/lib

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_selftest: Integrate kernel selftest test-drm_modeset

Call kernel selftest module test-drm_modeset for testing KMS. v2: - Add test alphabetically. - Add test to meson build. v3: Rename to kms_selftest. Signed-off-by: Deepak Rawat --- tests/Makefile.sources| 1 + tests/igt_command_line.sh | 2 +- tests/kms_selftest.c | 10

[Intel-gfx] [PATCH i-g-t 3/5] lib: Don't call igt_require_fb_modifiers() when no modifier

(), remove the modifier flag iff the driver doesn't support modifiers and the modifer is 0 * Don't modify the flag in kms_addfb(). Signed-off-by: Deepak Rawat Signed-off-by: Leo Li --- lib/igt_fb.c | 7 +-- lib/ioctl_wrappers.c | 24 +++- lib/ioctl_wrappers.h | 1

[Intel-gfx] [PATCH i-g-t 1/5] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers

vmwgfx does not support GEM interface so calling gem_close on vmwgfx results in error. v2: Use drmIoctl with error when ioctl() failed. v3: Seperate ioctl wrapper. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 5 - lib/igt_kms.c | 22 ++ lib/igt_kms.h | 1 + 3

[Intel-gfx] [PATCH i-g-t 2/5] lib/igt_fb: Check for cairo surface success

For vmwgfx cairo surface creation fails due to stride mismatch, add a igt_require_f() for surface. v2: Check for surface creation failure. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 335ece69..1bb6d324

Re: [Intel-gfx] [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

> > On Tue, Oct 16, 2018 at 02:21:17PM +0200, Daniel Vetter wrote: > > On Mon, Oct 15, 2018 at 04:11:41PM +, Deepak Singh Rawat wrote: > > > > On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote: > > > > > Selftest for drm damage helper ite

Re: [Intel-gfx] [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

> > > Obviously needs some adjusting on the igt side too, since we seem to be > > > missing the igt scaffolding for tests-drm-helper.ko. > > > -Daniel > > > > Hi Daniel, > > > > Thanks for the review. I am a little confused here. Should we have single > > kernel module for drm plane helper

Re: [Intel-gfx] [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

> On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote: > > Selftest for drm damage helper iterator functions. > > > > Cc: ville.syrj...@linux.intel.com > > Cc: Daniel Vetter > > Cc: Pekka Paalanen > > Cc: Daniel Stone > > Cc

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/6] lib/igt_fb: Check for cairo surface success

> > On Wed, Oct 10, 2018 at 05:21:01PM -0700, Deepak Rawat wrote: > > For vmwgfx cairo surface creation fails due to stride mismatch, add a > > igt_require_f() for surface. > > Hmm. What kind of pixel format are you using? > > It seems to me cairo should be ha

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 4/6] lib: Don't call igt_require_fb_modifiers() when no modifier

> On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote: > > vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers() > > when modifier are not passed. > > > > Signed-off-by: Deepak Rawat > > --- > > lib/ioctl_wrappers.c | 5 -

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device

n to me. > -Daniel I saw latest email from Perti mentioning that this might be needed for loading ko. I am really not sure about that but I will test without vmwgfx as a separate driver type and see if things work. Thanks, Deepak ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 6/6] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper

> > diff --git a/tests/meson.build b/tests/meson.build > > index 697ff515..5acd7aa2 100644 > > --- a/tests/meson.build > > +++ b/tests/meson.build > > @@ -9,6 +9,7 @@ test_progs = [ > > 'debugfs_test', > > 'drm_import_export', > > 'drm_mm', > > + 'drm_plane_damage', > > For future

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device

> > On Wed, Oct 10, 2018 at 05:20:59PM -0700, Deepak Rawat wrote: > > Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests. > > > > v2: Don't remove second virtio_gpu > > > > Signed-off-by: Deepak Rawat > > --- > > lib/drmtest.c | 8

[Intel-gfx] [PATCH i-g-t 3/6] lib/igt_fb: Check for cairo surface success

For vmwgfx cairo surface creation fails due to stride mismatch, add a igt_require_f() for surface. v2: Check for surface creation failure. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 335ece69..1bb6d324

[Intel-gfx] [PATCH i-g-t 2/6] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers

vmwgfx does not support GEM interface so calling gem_close on vmwgfx results in error. v2: Use drmIoctl with error when ioctl() failed. v3: Seperate ioctl wrapper. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 5 - lib/igt_kms.c | 22 ++ lib/igt_kms.h | 1 + 3

[Intel-gfx] [PATCH i-g-t 5/6] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property

Some simple test cases to use FB_DAMAGE_CLIPS plane property. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Daniel Stone Signed-off-by: Deepak Rawat --- lib/igt_kms.c | 1 + lib/igt_kms.h | 1 + tests/kms_atomic.c | 260

[Intel-gfx] [PATCH i-g-t 4/6] lib: Don't call igt_require_fb_modifiers() when no modifier

vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers() when modifier are not passed. Signed-off-by: Deepak Rawat --- lib/ioctl_wrappers.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 0929c43f..3a11cb6e

[Intel-gfx] [PATCH i-g-t 6/6] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper

Call kernel selftest module test-drm_damage_helper from igt. v2: - Add test alphabetically. - Add test to meson build. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Daniel Stone Signed-off-by: Deepak Rawat --- tests/Makefile.sources| 1 + tests

[Intel-gfx] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device

Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests. v2: Don't remove second virtio_gpu Signed-off-by: Deepak Rawat --- lib/drmtest.c | 8 lib/drmtest.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index fee9d33a..9d013a00

[Intel-gfx] [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

Selftest for drm damage helper iterator functions. Cc: ville.syrj...@linux.intel.com Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Daniel Stone Cc: intel-gfx@lists.freedesktop.org Cc: igt-...@lists.freedesktop.org Cc: petri.latv...@intel.com Cc: ch...@chris-wilson.co.uk Signed-off-by: Deepak Rawat

[Intel-gfx] [PATCH i-g-t 2/7] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers

vmwgfx does not support GEM interface so calling gem_close on vmwgfx results in error. v2: Use drmIoctl with error when ioctl() failed. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 5 - lib/igt_kms.c | 13 + lib/igt_kms.h | 1 + 3 files changed, 18 insertions(+), 1

[Intel-gfx] [PATCH i-g-t 4/7] lib/igt_fb: Don't call gem_set_domain() for dumb buffer

gem_set_domain() is gem specific and not needed for dumb buffers. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 0485708b..74a4b501 100644 --- a/lib/igt_fb.c +++ b/lib/igt_fb.c

[Intel-gfx] [PATCH i-g-t 6/7] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property

Some simple test cases to use FB_DAMAGE_CLIPS plane property. Signed-off-by: Deepak Rawat --- lib/igt_kms.c | 1 + lib/igt_kms.h | 1 + tests/kms_atomic.c | 260 + 3 files changed, 262 insertions(+) diff --git a/lib/igt_kms.c b/lib

[Intel-gfx] [PATCH i-g-t 5/7] lib: Don't call igt_require_fb_modifiers() when no modifier

vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers() when modifier are not passed. Signed-off-by: Deepak Rawat --- lib/ioctl_wrappers.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 0929c43f..3a11cb6e

[Intel-gfx] [PATCH i-g-t 7/7] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper

Call kernel selftest module test-drm_damage_helper from igt. Signed-off-by: Deepak Rawat --- tests/Makefile.sources | 1 + tests/drm_plane_damage.c | 10 ++ 2 files changed, 11 insertions(+) create mode 100644 tests/drm_plane_damage.c diff --git a/tests/Makefile.sources b/tests

[Intel-gfx] [PATCH i-g-t 3/7] lib/igt_fb: Check for cairo surface success

For vmwgfx cairo surface creation fails due to stride mismatch, add a igt_require_f() for surface. v2: Check for surface creation failure. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 0248637c..0485708b

[Intel-gfx] [PATCH i-g-t 1/7] lib/igt_vmwgfx: Add vmwgfx device

Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests. v2: Don't remove second virtio_gpu Signed-off-by: Deepak Rawat --- lib/drmtest.c | 8 lib/drmtest.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index fee9d33a..9d013a00

Re: [Intel-gfx] [PATCH i-g-t 4/5] lib/igt_fb: Check for stride before creating cairo surface

> Quoting Deepak Rawat (2018-09-06 01:03:49) > > Cairo surface creation will fail if stride of provided buffer is not > > same as expected by cairo. This fails for vmwgfx odd length framebuffer > > as in vmwgfx stride is always width * bpp. > > > > Signed-off-b

[Intel-gfx] [PATCH i-g-t 2/5] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers

vmwgfx does not support GEM interface so calling gem_close on vmwgfx results in error. Call dumb destroy IOCTL in case have dumb buffer. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 5 - lib/igt_kms.c | 15 +++ lib/igt_kms.h | 1 + 3 files changed, 20 insertions(+), 1

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property

Some simple test cases to use FB_DAMAGE_CLIPS plane property. Signed-off-by: Deepak Rawat Cc: dri-de...@lists.freedesktop.org Cc: Daniel Vetter Cc: Lukasz Spintzyk Cc: Rob Clark Cc: Daniel Stone Cc: Noralf Trønnes Cc: Dave Airlie --- lib/igt_kms.c | 1 + lib/igt_kms.h

[Intel-gfx] [PATCH i-g-t 0/5] vmwgfx as a new driver for igt-gpu-tools

specific tests in future. Thanks, Deepak Deepak Rawat (5): lib/igt_vmwgfx: Add vmwgfx device lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers tests/kms: Don't check crtc state for vmwgfx legacy set_crtc lib/igt_fb: Check for stride before creating cairo surface tests/kms_atomic

[Intel-gfx] [PATCH i-g-t 1/5] lib/igt_vmwgfx: Add vmwgfx device

Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests. Signed-off-by: Deepak Rawat --- lib/drmtest.c | 9 - lib/drmtest.h | 3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index bfa2e0f0..563d5b8b 100644 --- a/lib

[Intel-gfx] [PATCH i-g-t 3/5] tests/kms: Don't check crtc state for vmwgfx legacy set_crtc

For a Xorg bug vmwgfx has a kernel workaround which reset the value of mode::type. This will cause crtc state not to match what is expected. Signed-off-by: Deepak Rawat --- tests/kms_atomic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/kms_atomic.c b/tests

[Intel-gfx] [PATCH i-g-t 4/5] lib/igt_fb: Check for stride before creating cairo surface

Cairo surface creation will fail if stride of provided buffer is not same as expected by cairo. This fails for vmwgfx odd length framebuffer as in vmwgfx stride is always width * bpp. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib

Re: [Intel-gfx] [PATCH 5/7] drm/vmwgfx: Stop updating plane->fb

> > On Fri, Apr 06, 2018 at 10:35:00PM +0300, Ville Syrjälä wrote: > > On Fri, Apr 06, 2018 at 07:14:51PM +, Deepak Singh Rawat wrote: > > > This makes sense once we got rid of plane->fb > > > > > > Will this go to drm-next? > > > >

Re: [Intel-gfx] [PATCH 5/7] drm/vmwgfx: Stop updating plane->fb

This makes sense once we got rid of plane->fb Will this go to drm-next? Could you please CC me so that I can do some testing myself. Thanks. Reviewed-by: Deepak Rawat <dra...@vmware.com> > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > We want to get

Re: [Intel-gfx] [PATCH 6/7] drm/vmwgfx: Stop using plane->fb in atomic_enable()

ic state but this patch looks good to me. Reviewed-by: Deepak Rawat <dra...@vmware.com> > > Cc: Thomas Hellstrom <thellst...@vmware.com> > Cc: Sinclair Yeh <s...@vmware.com> > Cc: VMware Graphics <linux-graphics-maintai...@vmware.com> > Cc: Daniel Vet

Re: [Intel-gfx] [PATCH 4/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_update_implicit_fb()

Reviewed-by: Deepak Rawat <dra...@vmware.com> > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > The only caller of vmw_kms_update_implicit_fb() is the page_flip > hook which itself gets called with the plane mutex already held. > Hence we can loo

Re: [Intel-gfx] [PATCH 2/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_atomic_check_modeset()

> > On Thu, Apr 05, 2018 at 08:15:05PM +, Deepak Singh Rawat wrote: > > > > > > > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > > > > Instead of looking at plane->fb let's look at the proper new > > > plane st

Re: [Intel-gfx] [PATCH 2/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_atomic_check_modeset()

> > From: Ville Syrjälä > > Instead of looking at plane->fb let's look at the proper new > plane state. > > Not that the code makes a ton of sense. It's only going through the > crtcs in the atomic state, so assuming not all of them are included > we're not even

[Intel-gfx] [PATCH] drm/i915: Set the Z inversion overlap field

Dual link Z-inversion overlap field is present in MIPI_CTRL register unlike the older platforms, hence setting the same in this patch. Signed-off-by: Deepak M <m.dee...@intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_dsi.c | 17 + 2

[Intel-gfx] [PATCH] drm/i915: Add ddb size field to device info structure

Adding the ddb size into the devide info will avoid platform checks while computing wm. v2: Added comment and WARN_ON if ddb size is zero.(Jani) v3: Added WARN_ON at the right place.(Jani) Suggested-by: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com> Signed-off-by: De

[Intel-gfx] [PATCH] drm/i915: Add ddb size field to device info structure

Adding the ddb size into the devide info will avoid platform checks while computing wm. v2: Added comment and WARN_ON if ddb size is zero.(Jani) Suggested-by: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- dri

[Intel-gfx] [PATCH] drm/i915: Add ddb size field to device info structure

Adding the ddb size into the devide info will avoid platform checks while computing wm. Suggested-by: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i91

Re: [Intel-gfx] drm/i915: Check GuC load status for Host to GuC action and SLPC status

On 20/08/16 10:39 AM, Sagar Arun Kamble wrote: Host to GuC actions should not be invoked when GuC isn't loaded hence add early return in i915_guc_action if GuC load status is not SUCCESS. Also, SLPC status has to be linked with GuC load status to make sure SLPC actions get invoked when GuC is

Re: [Intel-gfx] [PATCH] Revert "drm/i915/chv: Set min freq to efficient frequency on chv"

On 12/08/16 1:04 PM, Jani Nikula wrote: On Fri, 12 Aug 2016, deepa...@linux.intel.com wrote: From: Deepak S <deepa...@linux.intel.com> With latest Punit FW, vgg input voltag drop falling to minimum is fixed. So reverting the WA patch & moving to turbo freq opreation range to [

[Intel-gfx] [PATCH v3] drm/i915/chv: Set min freq to RPn on CHV.

From: Deepak S <deepa...@linux.intel.com> With latest Punit FW, vgg input voltag drop falling to minimum is fixed. So reverting the WA patch & moving to turbo freq opreation range to [RPn -> RP0] This is not a 1:1 revert of the commit 5b7c91b78b1ce6663e0f1f037f6cb4d7c9537d44.

Re: [Intel-gfx] [PATCH v2] Revert "drm/i915/chv: Set min freq to efficient frequency on chv"

On 12/08/16 11:53 AM, Chris Wilson wrote: On Fri, Aug 12, 2016 at 02:12:42PM +0800, kbuild test robot wrote: Hi Deepak, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.8-rc1 next-20160811] [if your patch is applied to the wrong git tree, please drop us a note

[Intel-gfx] [PATCH v2] Revert "drm/i915/chv: Set min freq to efficient frequency on chv"

From: Deepak S <deepa...@linux.intel.com> With latest Punit FW, vgg input voltag drop falling to minimum is fixed. So reverting the WA patch & moving to turbo freq opreation range to [RPn -> RP0] This reverts commit 5b7c91b78b1ce6663e0f1f037f6cb4d7c953

[Intel-gfx] [PATCH] Revert "drm/i915/chv: Set min freq to efficient frequency on chv"

From: Deepak S <deepa...@linux.intel.com> With latest Punit FW, vgg input voltag drop falling to minimum is fixed. So reverting the WA patch & moving to turbo freq opreation range to [RPn -> RP0] This reverts commit 5b7c91b78b1ce6663e0f1f037f6cb4d7c953

Re: [Intel-gfx] [PATCH 01/15] drm/i915: Add ctx getparam ioctl parameter to retrieve ctx unique id

1171,6 +1171,7 @@ struct drm_i915_gem_context_param { #define I915_CONTEXT_PARAM_BAN_PERIOD 0x1 #define I915_CONTEXT_PARAM_NO_ZEROMAP 0x2 #define I915_CONTEXT_PARAM_GTT_SIZE 0x3 +#define I915_CONTEXT_PARAM_HW_ID 0x4 __u64 value; }; Patch looks good to me Reviewed-by: Deepak S &

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Get the i2c bus number from the ACPI

Waiting for review comments. > -Original Message- > From: Deepak, M > Sent: Friday, March 11, 2016 3:55 PM > To: intel-gfx@lists.freedesktop.org > Cc: Deepak, M <m.dee...@intel.com>; Nikula, Jani <jani.nik...@intel.com>; > Ville Syrjälä <ville.syrj...@lin

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Parse LFP brightness control field in VBT

> -Original Message- > From: Nikula, Jani > Sent: Tuesday, March 29, 2016 8:31 PM > To: intel-gfx@lists.freedesktop.org; Deepak, M <m.dee...@intel.com> > Cc: Nikula, Jani <jani.nik...@intel.com> > Subject: [PATCH 3/5] drm/i915: Parse LFP brightness control

[Intel-gfx] [PATCH 5/5] drm/i915: CABC support for Panel PWM backlight control

here assumes that the panels use standard SW register for control. CABC is supported only when the PWM source for backlight is from the panel. Cc: Jani Nikula <jani.nik...@intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Yetunde Adebisi <yetundex.adeb...@intel.com> Sig

[Intel-gfx] [PATCH 1/5] drm: Add new DCS commands in the enum list

Adding new DCS commands which are specified in the DCS 1.3 spec related to CABC. v2: Sorted the Macro`s by value (Andrzej) Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Suggested-by: Jani Nikula <jani.nik...@intel.com> Signe

[Intel-gfx] [PATCH 4/5] drm/i915: Add DCS control for Panel PWM

unde Adebisi <yetundex.adeb...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.h| 1 - drivers/gpu/drm/i915/intel_drv.h | 2 + drivers/gpu/drm/i915/intel_d

[Intel-gfx] [PATCH 3/5] drm/i915: Parse LFP brightness control field in VBT

These fields in VBT indicates the PWM source which is used and also the controller number. Cc: Jani Nikula <jani.nik...@intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Yetunde Adebisi <yetundex.adeb...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> -

[Intel-gfx] [PATCH 2/5] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fields in VBT

Vetter <daniel.vet...@intel.com> Cc: Yetunde Adebisi <yetundex.adeb...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- drivers/gpu/drm/i915/intel_bios.c | 10 ++ drivers/gpu/drm/i915/intel_bios.h | 5 - drivers/gpu/drm/i915/intel_dsi.h | 9 + 3 file

[Intel-gfx] [PATCH 5/5] CABC support for Panel PWM backlight control

here assumes that the panels use standard SW register for control. CABC is supported only when the PWM source for backlight is from the panel. Signed-off-by: Deepak M <m.dee...@intel.com> --- drivers/gpu/drm/i915/intel_dsi.c | 19 +++ drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 4/5] drm/i915: Add DCS control for Panel PWM

unde Adebisi <yetundex.adeb...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- Should this below check be moved to intel_panel.c before calling the intel_dsi_panel_pwm_init_backlight_funcs() ?? if (dev_priv->vbt.backlight.pwm_pin == BLC_CONTROL_P

[Intel-gfx] [PATCH 2/5] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fields in VBT

Vetter <daniel.vet...@intel.com> Cc: Yetunde Adebisi <yetundex.adeb...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- DCS commands 0x53h and 0x54h controls the panel PWM operations and therfore we should send these commands to the ports mentioned in the field "dl_pan

[Intel-gfx] [PATCH 3/5] drm/i915: Parse LFP brightness control field in VBT

These fields in VBT indicates the PWM source which is used and also the controller number. Signed-off-by: Deepak M <m.dee...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_bios.c | 12 drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] [PATCH 1/5] drm: Add new DCS commands in the enum list

rj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Suggested-by: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- include/video/mipi_display.h | 8 1 file changed, 8 insertions(+) diff --git a/include/video/mipi_disp

[Intel-gfx] [PATCH 3/3] drm/i915: CABC support for backlight control

mipi_dsi_dcs_write() instead of mipi_dsi_dcs_write_buffer() (Jani) Move DCS macro`s to include/video/mipi_display.h (Jani) Cc: Jani Nikula <jani.nik...@intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Yetunde Adebisi <yetundex.adeb...@intel.com> Signed-off-by: Deepak M &

[Intel-gfx] [PATCH 1/3] drm: Add new DCS commands in the enum list

y: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- include/video/mipi_display.h | 8 1 file changed, 8 insertions(+) diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h index ddcc8ca..bb8195b 100644 --- a/include/vide

[Intel-gfx] [PATCH 2/3] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fileds in VBT

Cc: Yetunde Adebisi <yetundex.adeb...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> --- drivers/gpu/drm/i915/intel_bios.c | 10 ++ drivers/gpu/drm/i915/intel_bios.h | 5 - drivers/gpu/drm/i915/intel_dsi.h | 9 + 3 files changed, 23 insertions(+), 1

  1   2   3   4   5   6   7   >