Re: [Intel-gfx] [PATCH v3] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-03-17 Thread Eero Tamminen
Hi, On 16.3.2023 10.50, Tvrtko Ursulin wrote: [   11.674183] i915 :00:02.0: PXP init-arb-session-15 failed due to BIOS/SOC:0x101a:ERR_PLATFORM_CONFIG ... Alan - is this expected during normal operation on some parts, or it's something truly unexpected/unexplained? If the former then I

Re: [Intel-gfx] [PATCH v3] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-03-15 Thread Eero Tamminen
Hi, Tested the patch with Ubuntu 22.04 desktop + Linux 6.2-rc3 (drm-tip) kernel, on TGL-H HW. With it, this log spam has disappeared: [ 8691.608933] i915 :00:02.0: [drm] PXP firmware failed arb session init request ret=[0x101f] [

Re: [Intel-gfx] [PATCH v4] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-09-07 Thread Eero Tamminen
: https://gitlab.freedesktop.org/drm/intel/-/issues/430 Co-developed-by: Chris Wilson Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Matthew Auld Cc: Eero Tamminen Cc: Tvrtko Ursulin Cc: Rodrigo Vivi Cc: Daniel Vetter Signed-off-by: Tvrtko Ursulin Reviewed-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH] drm/i915/gt: Only disable powergating around rcs activity

2019-12-20 Thread Eero Tamminen
-u 4 -n 4800 -async 4 -hw (Chris, MediaSDK build installs sample_multi_transcode to share/mfx/samples/ directory.) - Eero On 19.12.2019 18.45, Chris Wilson wrote: References: https://gitlab.freedesktop.org/drm/intel/issues/846 Cc: Imre Deak Cc: Eero Tamminen --- drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm/i915: Enable eLLC caching of display buffers for SKL+

2019-04-16 Thread Eero Tamminen
n I had to fix the MOCS target cache to really say PTE rather than LLC+eLLC. Caveat: I've not benchmarked any real workloads. IIRC Eero did benchmark an earlier version, but that didn't have the PTE vs. LLC+eLLC MOCS fix so it wasn't actually doing the right thing most likely. Cc: Eero Tamminen Sig

Re: [Intel-gfx] [IGT 1/2] tools/intel_gpu_top: Add support for stdout logging

2019-02-12 Thread Eero Tamminen
Hi, On 11.2.2019 11.49, Tvrtko Ursulin wrote: On 08/02/2019 13:58, Eero Tamminen wrote: On 8.2.2019 14.03, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Two new output modes are added: listing of text data to standard out (-l on the command line), and dumping of JSON formatted records (-J

Re: [Intel-gfx] [IGT 1/2] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Eero Tamminen
t;: "%" }, "Video/1": { "busy": 0.00, "sema": 0.00, "wait": 0.00, "unit": "%"

Re: [Intel-gfx] [PATCH 0/9] GPU-bound energy efficiency improvements for the intel_pstate driver.

2018-04-16 Thread Eero Tamminen
Hi, On 14.04.2018 07:01, Srinivas Pandruvada wrote: Hi Francisco, [...] Are you no longer interested in improving those aspects of the non- HWP governor?  Is it that you're planning to delete it and move back to a generic cpufreq governor for non-HWP platforms in the near future? Yes that

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] intel-gpu-top: Rewrite the tool to be safe to use

2018-04-04 Thread Eero Tamminen
Hi, On 04.04.2018 15:42, Tvrtko Ursulin wrote: On 04/04/2018 13:15, Eero Tamminen wrote: I've now tested v5 with old Ubuntu kernel on KBL, and with latest drm-tip kernel on SNB, HSW, BYT, BSW and BDW GT & GT3. Generic test results * Tool works on all of them * The

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] intel-gpu-top: Rewrite the tool to be safe to use

2018-04-04 Thread Eero Tamminen
latest git versions of Mesa, libxcb, X server and few other things, and adding this to X server config: --- Section "ServerFlags" Option "Debug" "dmabuf_capable" EndSection --- On 03.04.2018 20:18, Tvrtko Ursulin wro

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] intel-gpu-top: Rewrite the tool to be safe to use

2018-04-03 Thread Eero Tamminen
Hi, On 03.04.2018 12:36, Tvrtko Ursulin wrote: On 29/03/2018 15:30, Eero Tamminen wrote: I tested this on HSW GT2, BYT, BDW GT3, SKL GT2 and KBL GT3e, with Ubuntu 16.04 and 17.10, using Ubuntu default kernels (4.4 to 4.13) and latest drm-tip build (4.16.0-rc7). General comments

Re: [Intel-gfx] [PATCH i-g-t v2] intel-gpu-top: Rewrite the tool to be safe to use

2018-03-29 Thread Eero Tamminen
asserts. (Rinat Ibragimov) * Continuously adapt to terminal size. (Rinat Ibgragimov) Signed-off-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: Petri Latvala <petri.la

Re: [Intel-gfx] [PATCH] drm/i915: Update MOCS settings for gen 9

2017-05-04 Thread Eero Tamminen
Hi, On 04.05.2017 11:53, Tvrtko Ursulin wrote: On 04/05/2017 09:35, Arkadiusz Hiler wrote: On Thu, Apr 27, 2017 at 05:23:16PM +0100, Chris Wilson wrote: But what is being counter suggested is that their is no reason for these mocs entries. If the sdk is just using mocs registers without first

Re: [Intel-gfx] [Mesa-dev] [libdrm PATCH] intel: Make unsynchronized GTT mappings work on systems with snooping.

2017-03-14 Thread Eero Tamminen
Hi, On 14.03.2017 12:48, Eero Tamminen wrote: On 11.03.2017 03:14, Kenneth Graunke wrote: On systems without LLC, drm_intel_gem_bo_map_unsynchronized() has had the surprising behavior of doing a synchronized GTT mapping. This is obviously not what the user of the API wanted. Eric left

Re: [Intel-gfx] [Mesa-dev] [libdrm PATCH] intel: Make unsynchronized GTT mappings work on systems with snooping.

2017-03-14 Thread Eero Tamminen
Hi, On 11.03.2017 03:14, Kenneth Graunke wrote: On systems without LLC, drm_intel_gem_bo_map_unsynchronized() has had the surprising behavior of doing a synchronized GTT mapping. This is obviously not what the user of the API wanted. Eric left a comment indicating a valid concern: if the CPU

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

2016-04-29 Thread Eero Tamminen
Hi, On 27.04.2016 17:53, Chris Wilson wrote: On Wed, Apr 27, 2016 at 04:25:09PM +0300, Eero Tamminen wrote: [...] Daniel, Chris, did you have some concrete example in mind where 3D driver would require CPU to snoop GPU? Not mesa, but X can do concurrent rendering to a Pixmap whilst also

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

2016-04-27 Thread Eero Tamminen
advertent CPU snooping due to incorrect MOCS config Hi, On 26.04.2016 17:30, Daniel Vetter wrote: On Tue, Apr 26, 2016 at 05:26:43PM +0300, Eero Tamminen wrote: [...] What this kernel ABI (index entry #2) has been agreed & documented to provide? I thought this entry is supposed to replace the writ

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

2016-04-26 Thread Eero Tamminen
Hi, On 26.04.2016 17:30, Daniel Vetter wrote: On Tue, Apr 26, 2016 at 05:26:43PM +0300, Eero Tamminen wrote: [...] What this kernel ABI (index entry #2) has been agreed & documented to provide? I thought this entry is supposed to replace the writeback LLC/eLLC cache MOCS setting

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

2016-04-26 Thread Eero Tamminen
Hi, On 26.04.2016 16:23, Chris Wilson wrote: On Tue, Apr 26, 2016 at 04:17:55PM +0300, Imre Deak wrote: On ti, 2016-04-26 at 13:57 +0100, Chris Wilson wrote: On Tue, Apr 26, 2016 at 03:44:22PM +0300, Imre Deak wrote: Setting a write-back cache policy in the MOCS entry definition also implies

Re: [Intel-gfx] [PATCH] drm/i915: Restore waitboost credit to the synchronous waiter

2015-12-08 Thread Eero Tamminen
Hi, On 12/07/2015 07:38 PM, Jesse Barnes wrote: [...] Still wishing we had a good way to benchmark these types of changes across a range of workloads. Eero, have you guys looked at turbo stuff at all yet? Except for this, not really: https://jira01.devtools.intel.com/browse/LCK-2271

[Intel-gfx] Fix typo in intel_lid.man

2013-09-13 Thread Eero Tamminen
Hi, Attached patch fixes typo in intel_lid.man. - Eero - Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may