L second argument
and Oops the kernel.
> - drm_object_attach_property(>base, prop,
> -info->panel_orientation);
> + drm_object_property_set_value(>base, prop,
> + info->panel_orientation);
--
Gabriel Krisman Bertazi
Hsin-Yi Wang writes:
> On Tue, Feb 15, 2022 at 9:17 AM Gabriel Krisman Bertazi
> wrote:
>>
>> Hsin-Yi Wang writes:
>>
>> > drm_dev_register() sets connector->registration_state to
>> > DRM_CONNECTOR_REGISTERED and dev->registered to true. If
>
discussion is archived at:
https://lists.freedesktop.org/archives/intel-gfx/2017-December/150646.html
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104096
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
Cc: Ben Widawsky <b...@bwidawsk.net>
---
drivers/gpu/drm/i915/int
will support it and the kernel must be
changed or if the testcase itself is bogus. My money is on the later,
but I could use a confirmation before writing down the patch.
In short, does pipe C support render compression (ccs modifier) in glk?
Thanks,
--
Gabriel Krisman Bertazi
Gabriel Krisman Bertazi <kris...@collabora.co.uk> writes:
> Hi,
>
> This is a new version of the series with the updates requested by
> reviewers. It fixes the KBL issue pointed out by Arkadiusz, adds a test
> for pitches[1] mentioned by Ville and does some other impr
Two scenarios tested:
- unaligned stride
- Stride too small
Since v4:
- Fix SIGFPE if width <= 1024 (Arkadiusz Hiler/Ville Syrjälä)
- Add test for pitches[1]=0 (Ville Syrjälä)
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_c
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
---
tests/kms_ccs.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 3d14fed91f2e..
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
---
tests/kms_ccs.c | 40 +---
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms
Commit d41c4ccbd2f9 ("tests/kms_ccs: Fix subtest enumeration")
accidently removed the update of data.pipe, causing kms_ccs to silently
only test PIPE_A.
This fixes the behavior reported by Daniel Vetter where tests would
succeed even on nonexistent pipes.
Signed-off-by: Gabriel Krism
Krisman Bertazi <kris...@collabora.co.uk>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Reviewed-by: Ben Widawsky <b...@bwidawsk.net>
---
tests/kms_ccs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 775c6999699f..7
, Daniel, Petri, thanks for the review.
Gabriel Krisman Bertazi (6):
tests/kms_ccs: Test pipes other than pipe A
lib/igt_kms: Fix off-by-one bug on skip of missing pipe
tests/kms_ccs: Prevent segfault if pipe is not supported
tests/kms_ccs: Test case where the CCS buffer was not provided
display->n_pipes is zero-indexed, so N returned in
igt_display_get_n_pipes is already not a valid pipe. This patch
prevents kms_ccs from going nuts when testing the first unexisting pipe.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
Reviewed-by: Maarten
predicate as calling init
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com>
> Cc: Imre Deak <imre.d...@intel.com>
Reviewed-by: Gabriel Kris
04:3: warning: ‘si’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> drivers/gpu/drm/i915/intel_csr.c:190:30: note: ‘si’ was declared in
>
> Give in and mark si as NULL.
>
Reviewed-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
--
Gabriel Krisman Bertazi
_
7890 205873168 1291645 13b57d after
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Matthew Auld <matthew.william.a...@gmai
Bug 103159, but let's start by
reverting to the old behavior.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103159
Fixes: ca20170afc6f ("tests/kms_plane_scaling: Add support for dynamic number
of planes")
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
Paulo Zanoni <paulo.r.zan...@intel.com> writes:
> Em Seg, 2017-10-30 às 15:54 -0200, Gabriel Krisman Bertazi escreveu:
>> knowing the assertion triggered on wait_until_enabled() is not that
>> useful without knowing what exactly caused the failure. It might be
>>
Ville Syrjälä <ville.syrj...@linux.intel.com> writes:
> On Tue, Oct 03, 2017 at 09:35:33AM -0700, Ben Widawsky wrote:
>> On 17-09-27 15:34:17, Gabriel Krisman Bertazi wrote:
>> >Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
>
the status before failing out.
Case in point:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101718
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_fbcon_fbt.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a
the status before failing out.
Case in point:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101718
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_fbcon_fbt.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a
Ben Widawsky <b...@bwidawsk.net> writes:
> On 17-09-27 15:34:18, Gabriel Krisman Bertazi wrote:
>>Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
>
> Did someone recommend this test? While we have some hardware limitations on
> current generations
Ben Widawsky <b...@bwidawsk.net> writes:
> On 17-09-27 15:34:17, Gabriel Krisman Bertazi wrote:
>>Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
>>---
>> tests/kms_ccs.c | 37 +++--
>> 1 file changed, 27 i
Ben Widawsky <b...@bwidawsk.net> writes:
> On 17-09-27 15:34:19, Gabriel Krisman Bertazi wrote:
>>Two scenarios tested:
>> - unaligned stride
>> - Stride too small
>>
>>Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
>
>
display->n_pipes is zero-indexed, so N returned in
igt_display_get_n_pipes is already not a valid pipe. This patch
prevents kms_ccs from going nuts when testing the first unxesting pipe.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
Reviewed-by: Maarten
Commit d41c4ccbd2f9 ("tests/kms_ccs: Fix subtest enumeration")
accidently removed the update of data.pipe, causing kms_ccs to silently
only test PIPE_A.
This fixes the behavior reported by Daniel Vetter where tests would
succeed even on nonexistent pipes.
Signed-off-by: Gabriel Krism
Two scenarios tested:
- unaligned stride
- Stride too small
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 2d7105
Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 775c6999699f..73025a1e019f 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -503,6 +503,9 @@ igt_main
data
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 35dfcca6be14..2d7105eb1323 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 37 +++--
1 file changed, 27 insertions(+), 10 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 73025a1e019f..35dfcca6be14 100644
--- a/tests/kms_ccs.c
Ville Syrjälä <ville.syrj...@linux.intel.com> writes:
> On Tue, Sep 05, 2017 at 08:36:54AM +0100, Daniel Stone wrote:
>> Hi Ville,
>>
>> On 4 September 2017 at 17:37, Ville Syrjälä
>> <ville.syrj...@linux.intel.com> wrote:
>> > On Thu, Aug 31, 2
Ben Widawsky <b...@bwidawsk.net> writes:
> On 17-08-31 16:52:15, Gabriel Krisman Bertazi wrote:
>>With this patch the new testcase igt@kms_ccs@pipe-X-invalid-ccs-offset
>>succeeds.
>>
>>Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
>&g
With this patch the new testcase igt@kms_ccs@pipe-X-invalid-ccs-offset
succeeds.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
drivers/gpu/drm/i915/intel_display.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drive
To represent formats 98-102, the supported formats mask must be
0x7c and not 0x3c.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
include/uapi/drm/drm_mode.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/drm/drm_
Two scenarios tested:
- unaligned stripe
- Stripe too small
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 95de69
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 06d34a80b108..95de6963226d 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms
Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 775c6999699f..73025a1e019f 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -503,6 +503,9 @@ igt_main
data
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index cc41c85c4964..06d34a80b108 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 73025a1e019f..cc41c85c4964 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms
Commit d41c4ccbd2f9 ("tests/kms_ccs: Fix subtest enumeration")
accidently removed the update of data.pipe, causing kms_ccs to silently
only test PIPE_A.
This fixes the behavior reported by Daniel Vetter where tests would
succeed even on nonexistent pipes.
Signed-off-by: Gabriel Krism
display->n_pipes is zero-indexed, so N returned in
igt_display_get_n_pipes is already not a valid pipe. This patch
prevents kms_ccs from going nuts when testing the first unxesting pipe.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
lib/igt_kms.c | 2 +-
1 file c
feedback,
Gabriel Krisman Bertazi (7):
tests/kms_ccs: Test pipes other than pipe A
lib/igt_kms: Fix off-by-one bug on skip of missing pipe
tests/kms_ccs: Prevent segfault if pipe is not supported
tests/kms_ccs: Test case where the CCS buffer was not provided
tests/kms_ccs: Test case where CCS
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index cc41c85c4964..06d34a80b108 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 06d34a80b108..95de6963226d 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms
Two scenarios tested:
- unaligned stripe
- Stripe too small
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 95de69
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 73025a1e019f..cc41c85c4964 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms
Commit d41c4ccbd2f9 ("tests/kms_ccs: Fix subtest enumeration")
accidently removed the update of data.pipe, causing kms_ccs to silently
only test PIPE_A.
This fixes the behavior reported by Daniel Vetter where tests would
succeed even on nonexistent pipes.
Signed-off-by: Gabriel Krism
a
failure because linux fails to detect the overlapping buffers in
add_fb2. I'll submit on another thread with a patch to linux fixing the
ioctl, which will make this test suceed.
Please, let me know your feedback,
Gabriel Krisman Bertazi (7):
tests/kms_ccs: Test pipes other than pipe A
lib
Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 775c6999699f..73025a1e019f 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -503,6 +503,9 @@ igt_main
data
display->n_pipes is zero-indexed, so N returned in
igt_display_get_n_pipes is already not a valid pipe. This patch
prevents kms_ccs from going nuts when testing the first unxesting pipe.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
lib/igt_kms.c | 2 +-
1 file c
Commit d41c4ccbd2f9 ("tests/kms_ccs: Fix subtest enumeration")
accidently removed the update of data.pipe, causing kms_ccs to silently
only test PIPE_A.
This fixes the behavior reported by Daniel Vetter where tests would
succeed even on nonexistent pipes.
Signed-off-by: Gabriel Krism
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 73025a1e019f..33d1369cd59b 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms
running tests for pipe C (only). I'm not sure what is the root
cause, but the crash happens when reading data from the kernel, so maybe
we got something wrong on libdrm/kernel side. I'll be debugging it
first thing in the morning. Still, I'm sure it is *not* a side effect
of my patch.
Gabriel Krisman
Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_ccs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 775c6999699f..73025a1e019f 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -503,6 +503,9 @@ igt_main
data
t alone.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
lib/igt_debugfs.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 2aa335866066..ee1f0f544824 100644
--- a/lib/igt_debugfs.c
+++ b/lib/i
Chris Wilson <ch...@chris-wilson.co.uk> writes:
> Quoting Gabriel Krisman Bertazi (2017-07-25 19:19:22)
>> power = (power & 0x1f00) >> 8;
>> units = 100 / (1 << power); /* convert to uJ */
>> power = I915_READ(MCH_SECP_NRG_S
: 0005 R15: 01eb94db
? __this_cpu_preempt_check+0x13/0x20
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101901
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
drivers/gpu/drm/i915/i915_debugfs.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
power domain workaround").
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101517
Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
drivers/gpu/drm/i915/intel_cdclk.c | 20 ++
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_pipe_crc_basic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index f49b434857e6..177211249808 100644
--- a/tests/kms_pipe_crc_b
Do a dummy crc read such that if there are no valid outputs for the
pipe, it skip the test before doing a system suspend.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_pipe_crc_basic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a
nk we could explore something
in that direction, once we address the race condition first pointed out
by Chris. He suggested on an earlier email that we leverage the
knowledge about digital ports to improve the overall detection, but I'm
not sure how to start that. I've been checking the specs and I
would maybe minimize the complexity of the
kernel-userspace interface.
>
>>
>> But that of course doesn't solve all the problems if the test
>> continues
>> to make fragile assumptions about the kernel behaviour.
>
> It's a trade-off: the more we
s Paulo
suggested in his first email.
--
Gabriel Krisman Bertazi
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
tter to check for both
> COMPRESSED and COMPRESSING as that should tell us that the
> compressor is at least trying to do something.
>
> While at it move the IVB+ register define to the right place, unify
> the naming convention of the compressed segment count masks, and
> fix up the mask for g4
n if the first one was already detected.
Since this reduces the overhead of the i915_hotplug_work_func, it may
address the following vblank misses detected by the CI:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100215
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100558
Signed-o
Gabriel Krisman Bertazi <kris...@collabora.co.uk> writes:
> If the atomic commit doesn't include any new plane, there is no need to
> choose a new CRTC for FBC, and the intel_fbc_choose_crtc() will bail out
> early. Although, if the FBC setup failed in the previous commit, i
abora.co.uk>
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
Cc: Paulo Zanoni <paulo.r.zan...@intel.com>
---
drivers/gpu/drm/i915/intel_fbc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/d
Daniel Vetter <daniel.vet...@ffwll.ch> writes:
> This reverts commit bc5ca47c0af4f949ba889e666b7da65569e36093.
>
> Gabriel put this back into generic code with
>
> commit 75f6dfe3e652e1adef8cc1b073c89f3e22103a8f
> Author: Gabriel Krisman Bertazi <kris...@collabora.co.
> failure where it failed to enable fbc in intel_fbc_can_enable() during
> the post plane update right?
yes, correct.
> On Mon, May 15, 2017 at 09:33:04PM -0300, Gabriel Krisman Bertazi wrote:
>> If the atomic commit doesn't include any new plane, there is no need t
s a result, this causes
that test to fail on Haswell.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100020
Fixes: f7e9b004b8a3 ("drm/i915/fbc: inline intel_fbc_can_choose()")
Reported-by: Dorota Czaplejewicz <dorota.czaplejew...@collabora.co.uk>
Signed-off-by: Gab
-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
drivers/gpu/drm/i915/intel_display.c | 26 ++
drivers/gpu/drm/i915/intel_dp.c | 3 +++
drivers/gpu/drm/i915/intel_drv.h | 1 +
drivers/gpu/drm/i915/intel_hdmi.c| 3 +++
4 files changed, 33 inse
Paulo Zanoni <paulo.r.zan...@intel.com> writes:
> Em Qui, 2017-04-20 às 11:11 -0300, Gabriel Krisman Bertazi escreveu:
>> After Linux commit f7e9b004b8a3 ("drm/i915/fbc: inline
>> intel_fbc_can_choose()"), no_fbc_reason will be updated to a new
>> erro
aulo)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100677
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_frontbuffer_tracking.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffe
}
> +
> + free(formats);
Hi,
Assuming I'm not missing anything, I think if you free formats here, the
static variable in igt_get_all_cairo_formats() will point to garbage and
further calls to that function will return uninitialized memory.
--
Gabriel Krisman Bertazi
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
drivers/gpu/drm/i915/intel_display.c | 26 ++
drivers/gpu/drm/i915/intel_dp.c | 3 +++
drivers/gpu/drm/i915/intel_drv.h | 1 +
drivers/gpu/drm/i915/intel_hdmi.c| 3 +++
4 files changed, 33 inse
ompression status. Instead, we can check if the cpu doesn't
support reporting and adopt the same behavior as if
--no-fbc-compression-check was used.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_frontbuffer_tracking.c | 3 ++-
1 file changed, 2 insertion
mit/?id=0eefe99fe0683ae409b665a8b18cc7eb648c6c0c
>
> Cc: Daniel Stone <dani...@collabora.com>
> Cc: Keith Packard <kei...@keithp.com>
> Cc: tfh...@err.no
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Acked-by: Gabriel Krisman Bertazi <kris...@collabora.c
triggering a test failure.
Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
---
tests/kms_frontbuffer_tracking.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index e75ea5497c4f..90a939863847 10
Jani Nikula <jani.nik...@linux.intel.com> writes:
>> +
>> +git commit --amend -s
>
> I think the intention is to just add the signoff, but this ends up
> trying to fire up the editor, which is really not good for piping.
>
You probably want --no-edit for that.
;
> + /** @driver_features: Required driver features for this entry */
> + u32 driver_features;
> + /** @data: Driver-private data, should not be device-specific. */
> void *data;
> };
>
> /**
> - * debugfs node structure. This structure represent
Daniel Vetter <daniel.vet...@ffwll.ch> writes:
> It's the default storage class for functions, entirely redundant. And
> a lot of these headers are a bit inconsistent due to organically
> grown.
>
Reviewed-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
--
with the current CONFIG_DRM_VM, for instance, which
hid some of the code for legacy drivers is the downside of requiring
recompilation of drm.ko before using a legacy driver.
Anyway, if you agree with this change, can you keep this entry until
that is done?
--
Gabriel Krisman Bertazi
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
nk not.
I gave it a try with the jobfile just to be sure on top of
drm-misc-next, and I couldn't reproduce the error anymore after applying
Chris' patch (but I could reproduce the Oops when trying only with my
patch).
Also, sorry for the noise and less
82 matches
Mail list logo
