Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v4)

2019-01-04 Thread Guang Bai
On Fri, 4 Jan 2019 12:02:34 +0800 Chris Chiu wrote: > On Thu, Jan 3, 2019 at 1:50 AM Guang Bai wrote: > > > > On Wed, 2 Jan 2019 17:29:46 +0800 > > Chris Chiu wrote: > > > > > Happy New Year. > > > Sorry for bothering you guys again, I don'

Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v4)

2019-01-02 Thread Guang Bai
our customer for integration test - So far so good. Thanks, -Guang > > Chris > > On Mon, Dec 3, 2018 at 6:38 PM Chris Chiu wrote: > > > > On Fri, Nov 30, 2018 at 1:15 AM Guang Bai > > wrote: > > > > > > On Thu, 29 Nov 2018 10:17:49 +0200 > >

Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v4)

2018-11-29 Thread Guang Bai
On Thu, 29 Nov 2018 10:17:49 +0200 Jani Nikula wrote: > On Wed, 28 Nov 2018, Guang Bai wrote: > > On some GEN9 platforms, slowly unplugging (wiggling) the HDMI cable > > makes the kernel to believe the HDMI display is still connected. > > This is because the HDMI DDC l

[Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v4)

2018-11-28 Thread Guang Bai
issue v3: Use digital port states to authorize the edid read v4: Add comments on issue histories and rationale of the fix (Chris W) Cc: Jani Nikula Cc: Chris Chiu Cc: Chris Wilson Signed-off-by: Guang Bai --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v2)

2018-11-28 Thread Guang Bai
On Tue, 13 Nov 2018 13:07:46 +0200 Jani Nikula wrote: > On Mon, 12 Nov 2018, Guang Bai wrote: > > Actually I'm still working on it right now with > > DRM_MODE_CONNECTOR_HDMIA/HDMIB, recommended by James, I'm able to > > differentiate the HDMI or DP

[Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v3)

2018-11-28 Thread Guang Bai
port live states to authorize the edid read. v2: Fix the formatting issue v3: Use digital port states to authorize the edid read Cc: Jani Nikula Cc: Chris Chiu Signed-off-by: Guang Bai --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v2)

2018-11-12 Thread Guang Bai
everything cleaned up ASAP. Thanks, Guang > > On Tue, Oct 30, 2018 at 1:24 AM Guang Bai wrote: > > > On Tue, 23 Oct 2018 17:14:34 +0800 > > Chris Chiu wrote: > > > > > On Thu, Oct 11, 2018 at 2:04 AM Guang Bai > > > wrote: > > >

Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v2)

2018-10-29 Thread Guang Bai
On Tue, 23 Oct 2018 17:14:34 +0800 Chris Chiu wrote: > On Thu, Oct 11, 2018 at 2:04 AM Guang Bai wrote: > > > On Mon, 8 Oct 2018 08:56:20 -0700 > > Guang Bai wrote: > > > > > On Mon, 8 Oct 2018 22:35:34 +0800 > > > Chris Chiu wrote: > > >

Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v2)

2018-10-10 Thread Guang Bai
On Mon, 8 Oct 2018 08:56:20 -0700 Guang Bai wrote: > On Mon, 8 Oct 2018 22:35:34 +0800 > Chris Chiu wrote: > > > Thanks! I have no problem with this patch. > > There are Fi.CI.BAT failures with the v2 (only with formatting fix > added) while the previous patch ha

Re: [Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v2)

2018-10-08 Thread Guang Bai
ang > > On Thu, Oct 4, 2018 at 2:08 AM Guang Bai wrote: > > > On some platforms, slowly unplugging (wiggling) the HDMI cable makes > > the kernel to believe the HDMI display still connected. This is > > because the HDMI DDC lines are disconnected sometimes later af

[Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v2)

2018-10-03 Thread Guang Bai
in addtion to access the DDC channels. v2: Fix the formatting issue Cc: Jani Nikula Cc: Chris Chiu Signed-off-by: Guang Bai --- drivers/gpu/drm/i915/intel_hotplug.c | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure

2018-10-02 Thread Guang Bai
in addtion to access the DDC channels. Cc: Jani Nikula Cc: Chris Chiu Signed-off-by: Guang Bai --- drivers/gpu/drm/i915/intel_hotplug.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: delay hotplug scheduling

2018-09-28 Thread Guang Bai
On Fri, 28 Sep 2018 09:26:48 +0300 Jani Nikula wrote: > On Thu, 27 Sep 2018, Guang Bai wrote: > > On Thu, 27 Sep 2018 09:45:53 +0300 > > Jani Nikula wrote: > > > >> On Wed, 26 Sep 2018, Guang Bai wrote: > >> > On Wed, 26 Sep 2

Re: [Intel-gfx] [PATCH] drm/i915: delay hotplug scheduling

2018-09-27 Thread Guang Bai
On Thu, 27 Sep 2018 09:45:53 +0300 Jani Nikula wrote: > On Wed, 26 Sep 2018, Guang Bai wrote: > > On Wed, 26 Sep 2018 16:44:16 -0700 > > Guang Bai wrote: > > > >> On Tue, 25 Sep 2018 10:18:36 +0300 > >> Jani Nikula wrote: > >> > &g

Re: [Intel-gfx] [PATCH] drm/i915: delay hotplug scheduling

2018-09-26 Thread Guang Bai
On Wed, 26 Sep 2018 16:44:16 -0700 Guang Bai wrote: > On Tue, 25 Sep 2018 10:18:36 +0300 > Jani Nikula wrote: > > > On some systems we get the hotplug irq on unplug before the DDC pins > > have been disconnected, resulting in connector status remaining > > connect

Re: [Intel-gfx] [PATCH] drm/i915: delay hotplug scheduling

2018-09-26 Thread Guang Bai
: Chris Chiu Tested-by: Chris Chiu > Cc: Chris Chiu > Cc: Guang Bai > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > drivers/gpu/drm/i915/intel_hotplug.c | 16 +++- > 2 files changed, 12 insertions(+),

[Intel-gfx] [PATCH xf86-video-intel] sna/io: Align the linear source buffer to cache line for 2d source copy

2018-09-17 Thread Guang Bai
these changes for BDW+ onward chipsets based on hardware design teams' inputs. Cc: Chris Wilson Signed-off-by: Guang Bai --- src/sna/sna_io.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/sna/sna_io.c b/src/sna/sna_io.c index d32bd58..35b90e5 100644 --- a/src/sna

[Intel-gfx] [PATCH xf86-video-intel] sna/io: Align the linear source buffer to cache line for 2d blt of SKL+

2018-09-04 Thread Guang Bai
Signed-off-by: Guang Bai --- src/sna/sna_io.c | 47 +++ 1 file changed, 35 insertions(+), 12 deletions(-) diff --git a/src/sna/sna_io.c b/src/sna/sna_io.c index d32bd58..ae82d1f 100644 --- a/src/sna/sna_io.c +++ b/src/sna/sna_io.c @@ -1064,7 +1064,7

[Intel-gfx] [PATCH xf86-video-intel] sna/io: Align the linear source buffer to cache line for 2d blt of SKL+

2018-09-04 Thread Guang Bai
On SKL+ the linear source buffer has to start from cache line boundary to meet the 2d engine source copy requirements. Apply this cache line alignment policy for SKL+ only. Signed-off-by: Guang Bai --- src/sna/sna_io.c | 47 +++ 1 file changed, 35

Re: [Intel-gfx] [PATCH xf86-video-intel] sna/io: Align the linear source buffer to cache line for 2d blt

2018-09-04 Thread Guang Bai
On Tue, 4 Sep 2018 08:01:36 +0100 Chris Wilson wrote: > Quoting Guang Bai (2018-09-04 06:37:31) > > On SKL+ the linear source buffer has to start from cache line > > boundary to meet the 2d engine source copy requirements. > > First update the requirement function. &g

[Intel-gfx] [PATCH xf86-video-intel] sna/io: Align the linear source buffer to cache line for 2d blt

2018-09-03 Thread Guang Bai
On SKL+ the linear source buffer has to start from cache line boundary to meet the 2d engine source copy requirements. Signed-off-by: Guang Bai --- src/sna/sna_io.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/sna/sna_io.c b/src/sna/sna_io.c index

Re: [Intel-gfx] [BUG] i915 HDMI connector status is connected after disconnection

2018-07-06 Thread Guang Bai
On Fri, 6 Jul 2018 13:38:06 -0700 Rodrigo Vivi wrote: > On Fri, Jul 06, 2018 at 10:41:18AM -0700, Guang Bai wrote: > > On Fri, 6 Jul 2018 14:44:58 +0800 > > Chris Chiu wrote: > > > > > On Thu, Jul 5, 2018 at 10:40 PM, Ville Syrjälä > > > wrote: >

Re: [Intel-gfx] [BUG] i915 HDMI connector status is connected after disconnection

2018-07-06 Thread Guang Bai
On Fri, 6 Jul 2018 14:44:58 +0800 Chris Chiu wrote: > On Thu, Jul 5, 2018 at 10:40 PM, Ville Syrjälä > wrote: > > On Thu, Jul 05, 2018 at 03:58:36PM +0800, Chris Chiu wrote: > >> Hi, > >> We have few ASUS laptops X705FD (The new WiskyLake), X560UD > >> (intel i5-8250U), X530UN (intel

[Intel-gfx] [PATCH] drm/i915: Fix the frame buffer fence starvation

2018-02-20 Thread Guang Bai
, the fence is only required when the frame buffer compression is enabled. Changes are made to follow graphics hardware design principles. Signed-off-by: Guang Bai <guang@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 44 +++- drivers/gpu/dr