Re: [Intel-gfx] [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-12-03 Thread Hans Verkuil
On 12/03/2018 12:23 PM, Andrzej Hajda wrote: > On 30.11.2018 15:48, Hans Verkuil wrote: >> On 11/30/18 15:29, Ville Syrjälä wrote: >>> On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote: >>>> Hi Ville, >>>> >>>> As Christoph can

Re: [Intel-gfx] [v2 1/2] drm: Add colorspace property

2018-11-05 Thread Hans Verkuil
-gfx@lists.freedesktop.org; Syrjala, Ville ; Lankhorst, Maarten ; Hans Verkuil Subject: Re: [Intel-gfx] [v2 1/2] drm: Add colorspace property On Fri, Nov 02, 2018 at 10:19:10AM +0100, Maarten Lankhorst wrote: Op 31-10-18 om 13:05 schreef Uma Shankar: This patch adds a colorspace property enabling

Re: [Intel-gfx] [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-11-30 Thread Hans Verkuil
orted non RGB >>>> color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects >>>> the value ranges within the selected color encoding. The properties >>>> are stored to drm_plane object to allow different set of supported >>>> encoding f

Re: [Intel-gfx] [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-11-30 Thread Hans Verkuil
lect the supported non RGB >>>>> color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects >>>>> the value ranges within the selected color encoding. The properties >>>>> are stored to drm_plane object to allow different set

Re: [Intel-gfx] [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-11-30 Thread Hans Verkuil
On 11/30/18 16:16, Ville Syrjälä wrote: > On Fri, Nov 30, 2018 at 03:48:00PM +0100, Hans Verkuil wrote: >> On 11/30/18 15:29, Ville Syrjälä wrote: >>> On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote: >>>> Hi Ville, >>>> >>>> As Ch

Re: [Intel-gfx] Linux 4.16 Kernel Boot Crash

2018-04-05 Thread Hans Verkuil
On 05/04/18 11:57, Mauro Carvalho Chehab wrote: > Em Wed, 4 Apr 2018 16:26:22 +0300 > Jaak Ristioja escreveu: > >> Hello, all! >> >> I experience the same issue with a Lenovo ThinkPad T440p (LENOVO >> 20AN006VMS/20AN006VMS, BIOS GLET90WW (2.44 ) 09/13/2017). I tried to >> bisect v4.15..v4.16 but

Re: [Intel-gfx] [PATCH v2 2/2] i915: content-type property for HDMI connector

2018-04-18 Thread Hans Verkuil
On 04/18/18 18:51, StanLis wrote: > From: Stanislav Lisovskiy > > Added encoding of drm content_type property from > drm_connector_state within AVI infoframe in order to properly handle > external HDMI TV content-type setting. > > Signed-off-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 1/2] drm: content-type property for HDMI connector

2018-04-18 Thread Hans Verkuil
On 04/18/18 18:51, StanLis wrote: > From: Stanislav Lisovskiy > > Added content_type property to > drm_connector_state in order to properly handle > external HDMI TV content-type setting. > > Signed-off-by: Stanislav Lisovskiy > --- > Documentation/gpu/kms-properties.csv | 1 + > drivers/gpu/

Re: [Intel-gfx] [PATCH v2 2/2] i915: content-type property for HDMI connector

2018-04-18 Thread Hans Verkuil
On 04/18/18 14:01, Lisovskiy, Stanislav wrote: > Hi, > > Please see my reply inline: > > From: dri-devel [dri-devel-boun...@lists.freedesktop.org] on behalf of Hans > Verkuil [hverk...@xs4all.nl] > Sent: Wednesday, April 18, 2018 2:

Re: [Intel-gfx] [PATCH v5 1/2] drm: content-type property for HDMI connector

2018-04-19 Thread Hans Verkuil
rm_mode_connector_set_path_property(struct drm_connector *connector, > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index 33b3a96d66d0..fb45839179dd 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -726,6 +726,11 @@ struct drm_

Re: [Intel-gfx] [PATCH v5 2/2] i915: content-type property for HDMI connector

2018-04-19 Thread Hans Verkuil
to bind those together >in same "content type" property. > > v4: > * Added it_content checking in intel_digital_connector_atomic_check. >Fixed documentation for new content type enum. > > v5: > * Moved patch revision's description to

[Intel-gfx] [PATCHv9 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Implement support for this DisplayPort feature. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu

[Intel-gfx] [PATCHv9 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This adds support for the DisplayPort CEC-Tunneling-over-AUX feature that is part of the DisplayPort 1.3 standard. Unfortunately, not all DisplayPort/USB-C to HDMI adapters with a chip that has this capability actually hook up the CEC pin, so even though a CEC device is

[Intel-gfx] [PATCHv9 2/3] drm-kms-helpers.rst: document the DP CEC helpers

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Document the Display Port CEC helper functions. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- Documentation/gpu/drm-kms-helpers.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms

[Intel-gfx] [PATCHv9 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX feature. This patch series is based on the current media master branch (https://git.linuxtv.org/media_tree.git/log/) but it applies fine on top of the current mainline tree. The v9 is identical to v8

[Intel-gfx] [PATCHv10 2/3] drm-kms-helpers.rst: document the DP CEC helpers

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Document the Display Port CEC helper functions. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- Documentation/gpu/drm-kms-helpers.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms

[Intel-gfx] [PATCHv10 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Implement support for this DisplayPort feature. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu

[Intel-gfx] [PATCHv10 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX feature. This patch series is based on top of drm-intel-next. The v10 is identical to v9, except it is rebased to drm-intel-next (v9 didn't apply cleanly) and two alignment warnings have been

[Intel-gfx] [PATCHv10 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This adds support for the DisplayPort CEC-Tunneling-over-AUX feature that is part of the DisplayPort 1.3 standard. Unfortunately, not all DisplayPort/USB-C to HDMI adapters with a chip that has this capability actually hook up the CEC pin, so even though a CEC device is

Re: [Intel-gfx] [PATCH v8 0/6] Add ChromeOS EC CEC Support

2018-07-12 Thread Hans Verkuil
On 12/07/18 14:42, Neil Armstrong wrote: > Hi Lee, > > On 12/07/2018 14:26, Lee Jones wrote: >> On Wed, 04 Jul 2018, Neil Armstrong wrote: >> >>> Hi All, >>> >>> The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support >>> through it's Embedded Controller, to enable the Linux CEC C

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2)

2018-07-14 Thread Hans Verkuil
On 11/07/18 17:24, Ville Syrjälä wrote: > On Wed, Jul 11, 2018 at 04:09:03PM +0200, Hans Verkuil wrote: >> Hi Ville, >> >> On 11/07/18 15:41, Patchwork wrote: >>> == Series Details == >>> >>> Series: drm/i915: add DisplayPort CEC-Tun

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2)

2018-07-16 Thread Hans Verkuil
On 16/07/18 15:10, Ville Syrjälä wrote: > On Sat, Jul 14, 2018 at 02:50:28PM +0200, Hans Verkuil wrote: >> On 11/07/18 17:24, Ville Syrjälä wrote: >>> On Wed, Jul 11, 2018 at 04:09:03PM +0200, Hans Verkuil wrote: >>>> Hi Ville, >>>> >>>> On 11

Re: [Intel-gfx] [PATCH 03/18] video/hdmi: Constify infoframe passed to the log functions

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > The log functions don't modify the passed in infoframe so make it const. > > Cc: Thierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks, Hans > Cc: linux-me...@vger.kernel.

Re: [Intel-gfx] [PATCH 02/18] video/hdmi: Pass buffer size to infoframe unpack functions

2018-09-21 Thread Hans Verkuil
gt; Cc: Thierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks, Hans > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville Syrjälä > --- > drivers/media/i2c/adv7511.c | 2 +- > drivers/media/i2c/adv7604.c | 2 +- > drivers/media/i2c/adv7842.c |

Re: [Intel-gfx] [PATCH 01/18] video/hdmi: Constify 'buffer' to the unpack functions

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > The unpack functions just read from the passed in buffer, > so make it const. > > Cc: Thierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks! Hans > Cc: linux-me...@vger.kernel.or

Re: [Intel-gfx] [PATCH 04/18] video/hdmi: Constify infoframe passed to the pack functions

2018-09-21 Thread Hans Verkuil
al with exynos churn > Actually export the new funcs > > Cc: Thierry Reding > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville Syrjälä > --- > drivers/video/hdmi.c | 425 > +++ > include/l

Re: [Intel-gfx] [PATCH 06/18] video/hdmi: Handle the MPEG Source infoframe

2018-09-21 Thread Hans Verkuil
plementation of this infoframe is not recommended due to unresolved issues. I don't think I've ever seen it either. It obviously doesn't hurt to have this code, but I prefer to wait until there are devices that actively set/use this infoframe. Regards, Hans > > Cc:

Re: [Intel-gfx] [PATCH 07/18] video/hdmi: Handle the NTSC VBI infoframe

2018-09-21 Thread Hans Verkuil
om the spec, and totally untested. Do we have any driver that uses this? I would prefer to wait until someone actually need this. Regards, Hans > > Cc: Thierry Reding > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville Syrjä

Re: [Intel-gfx] [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-09-21 Thread Hans Verkuil
es. Regards, Hans > > Cc: Thierry Reding > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville Syrjälä > --- > include/linux/hdmi.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/hdmi.h b/incl

Re: [Intel-gfx] [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-09-21 Thread Hans Verkuil
On 09/21/18 16:01, Ville Syrjälä wrote: > On Fri, Sep 21, 2018 at 10:41:46AM +0200, Hans Verkuil wrote: >> On 09/20/18 20:51, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> We'll be wanting to send more than just infoframes over HDMI. So add an >

Re: [Intel-gfx] [PATCH 1/2] drm: Do not call drm_dp_cec_set_edid() while registering DP connectors

2018-09-25 Thread Hans Verkuil
more than 3sec in a machine with 4 DP ports disconnected. Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks, this makes sense. Hans Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/drm_dp_cec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH v3 04/18] video/hdmi: Constify infoframe passed to the pack functions

2018-10-01 Thread Hans Verkuil
lazy and didn't want to change all the >> drivers. >> >> v2: Deal with exynos churn >> Actually export the new funcs >> v3: Fix various documentation fails (Hans) > > Hans, any more concerns about this patch? Acked-by: Hans Verkuil Regards,

Re: [Intel-gfx] [RFC PATCH 2/5] media: cec-notifier: Get notifier by device and connector name

2018-05-14 Thread Hans Verkuil
Hi Neil, Thanks for this patch series! Some comments below: On 05/15/2018 12:40 AM, Neil Armstrong wrote: > In non device-tree world, we can need to get the notifier by the driver > name directly and eventually defer probe if not yet created. > > This patch adds a variant of the get function by

Re: [Intel-gfx] [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-14 Thread Hans Verkuil
On 05/15/2018 12:40 AM, Neil Armstrong wrote: > This patchs adds the cec_notifier feature to the intel_hdmi part > of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate > between each HDMI ports. > The changes will allow the i915 HDMI code to notify EDID and HPD changes > to

Re: [Intel-gfx] [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-14 Thread Hans Verkuil
On 05/15/2018 12:40 AM, Neil Armstrong wrote: > This patchs adds the cec_notifier feature to the intel_hdmi part > of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate > between each HDMI ports. > The changes will allow the i915 HDMI code to notify EDID and HPD changes > to

Re: [Intel-gfx] [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-14 Thread Hans Verkuil
On 05/15/2018 12:40 AM, Neil Armstrong wrote: > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the > driver for such feature of the Embedded Controller. > > This driver is part of the cros-ec MFD and will be add as a sub-device when > the feature bit is exposed by the EC. >

Re: [Intel-gfx] [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Hans Verkuil
On 05/15/18 09:25, Neil Armstrong wrote: > Hi Hans, > > Thanks for the extensive review. > > On 15/05/2018 08:58, Hans Verkuil wrote: >> On 05/15/2018 12:40 AM, Neil Armstrong wrote: >>> The Chrome OS Embedded Controller can expose a CEC bus, this patch add the >

Re: [Intel-gfx] [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Hans Verkuil
On 05/15/18 10:28, Neil Armstrong wrote: > + int ret; > + > + cros_ec_cec = devm_kzalloc(&pdev->dev, sizeof(*cros_ec_cec), > +GFP_KERNEL); > + if (!cros_ec_cec) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, cros_ec_cec); >

Re: [Intel-gfx] [PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-15 Thread Hans Verkuil
On 05/15/2018 04:42 PM, Neil Armstrong wrote: > In non device-tree world, we can need to get the notifier by the driver > name directly and eventually defer probe if not yet created. > > This patch adds a variant of the get function by using the device name > instead and will not create a notifier

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Hans Verkuil
changes > to an eventual CEC adapter. > > Signed-off-by: Neil Armstrong Reviewed-by: Hans Verkuil Thanks! Hans > --- > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/i915/intel_drv.h | 2 ++ > drivers/gpu/drm/i915/intel_hdmi.c | 12

Re: [Intel-gfx] [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-15 Thread Hans Verkuil
On 05/15/2018 04:42 PM, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly inside the mkbp event > instead of

Re: [Intel-gfx] [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-15 Thread Hans Verkuil
On 05/15/2018 04:42 PM, Neil Armstrong wrote: > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong For what it is worth (not an MFD expert): Acked-by: Hans Verkuil Thanks!

Re: [Intel-gfx] [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Hans Verkuil
On 05/15/2018 04:42 PM, Neil Armstrong wrote: > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the > driver for such feature of the Embedded Controller. > > This driver is part of the cros-ec MFD and will be add as a sub-device when > the feature bit is exposed by the EC. >

Re: [Intel-gfx] [PATCH 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-16 Thread Hans Verkuil
Hi Neil, Two small comments below: On 05/15/18 14:46, Neil Armstrong wrote: > In non device-tree world, we can need to get the notifier by the driver > name directly and eventually defer probe if not yet created. > > This patch adds a variant of the get function by using the device name > instea

Re: [Intel-gfx] [PATCH 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-16 Thread Hans Verkuil
On 05/15/18 14:46, Neil Armstrong wrote: > This patchs adds the cec_notifier feature to the intel_hdmi part > of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate > between each HDMI ports. > The changes will allow the i915 HDMI code to notify EDID and HPD changes > to an ev

Re: [Intel-gfx] [PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-16 Thread Hans Verkuil
Some small comments below: On 05/15/18 14:47, Neil Armstrong wrote: > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the > driver for such feature of the Embedded Controller. > > This driver is part of the cros-ec MFD and will be add as a sub-device when > the feature bit

Re: [Intel-gfx] [PATCH v5 1/6] media: cec-notifier: Get notifier by device and connector name

2018-05-24 Thread Hans Verkuil
ed-off-by: Neil Armstrong Reviewed-by: Hans Verkuil Regards, Hans > --- > drivers/media/cec/cec-notifier.c | 11 --- > include/media/cec-notifier.h | 27 --- > 2 files changed, 32 insertions(+), 6 deletions(-) > > diff --git a/d

Re: [Intel-gfx] [PATCH v5 6/6] media: platform: Add ChromeOS EC CEC driver

2018-05-24 Thread Hans Verkuil
or name. > > Signed-off-by: Neil Armstrong > Reviewed-by: Enric Balletbo i Serra Reviewed-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/Kconfig | 11 + > drivers/media/platform/Makefile | 2 + > drivers/media/platf

Re: [Intel-gfx] [PATCH v5 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Hans Verkuil
On 24/05/18 10:54, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > > Signed-off-by: Neil Armstrong > Tested-by: Enric Balletbo i Serra > --- > include/linux/mfd/cros_ec_commands.h | 85 >

Re: [Intel-gfx] [PATCH v6 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Hans Verkuil
On 24/05/18 11:57, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > > Signed-off-by: Neil Armstrong > Tested-by: Enric Balletbo i Serra Reviewed-by: Hans Verkuil Thanks! Hans &

Re: [Intel-gfx] [PATCH v6 5/6] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-24 Thread Hans Verkuil
On 24/05/18 11:57, Neil Armstrong wrote: > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong > Reviewed-by: Enric Balletbo i Serra For whatever it is worth: Acked-by: Hans Ve

Re: [Intel-gfx] [PATCH v7 3/6] mfd: cros-ec: Increase maximum mkbp event size

2018-06-01 Thread Hans Verkuil
igned-off-by: Neil Armstrong > Tested-by: Enric Balletbo i Serra Acked-by: Hans Verkuil Regards, Hans > --- > drivers/platform/chrome/cros_ec_proto.c | 40 > + > include/linux/mfd/cros_ec.h | 2 +- > include/

Re: [Intel-gfx] [PATCH v7 0/6] Add ChromeOS EC CEC Support

2018-06-08 Thread Hans Verkuil
On 06/01/2018 10:19 AM, Neil Armstrong wrote: > Hi All, > > The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support > through it's Embedded Controller, to enable the Linux CEC Core to communicate > with it and get the CEC Physical Address from the correct HDMI Connector, the > fol

Re: [Intel-gfx] [PATCH v7 0/6] Add ChromeOS EC CEC Support

2018-06-08 Thread Hans Verkuil
On 08/06/18 10:17, Neil Armstrong wrote: > Hi Hans, > > On 08/06/2018 09:53, Hans Verkuil wrote: >> On 06/01/2018 10:19 AM, Neil Armstrong wrote: >>> Hi All, >>> >>> The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support >&

Re: [Intel-gfx] [PATCH v7 0/6] Add ChromeOS EC CEC Support

2018-06-11 Thread Hans Verkuil
On 11/06/18 10:56, Neil Armstrong wrote: > Hi Lee, > > On 11/06/2018 08:03, Lee Jones wrote: >> On Fri, 08 Jun 2018, Hans Verkuil wrote: >>> On 08/06/18 10:17, Neil Armstrong wrote: >>>> On 08/06/2018 09:53, Hans Verkuil wrote: >>>>> On 06/01

Re: [Intel-gfx] [PULL] drm/i915: Add HDCP support to i915

2018-02-14 Thread Hans Verkuil
Hi Sean, On 13/02/18 21:18, Sean Paul wrote: > > Hi Dave, > Here's the pull request for HDCP. Hopefully no surprises since it's been > baking > in drm-tip for a while now. > > topic/hdcp-2018-02-13: > Add HDCP support to i915 drm driver. > > Cheers, Sean > > > The following changes since com

Re: [Intel-gfx] [PULL] drm/i915: Add HDCP support to i915

2018-02-14 Thread Hans Verkuil
On 14/02/18 14:44, Sean Paul wrote: > On Wed, Feb 14, 2018 at 3:33 AM, Hans Verkuil wrote: >> Hi Sean, >> >> On 13/02/18 21:18, Sean Paul wrote: >>> >>> Hi Dave, >>> Here's the pull request for HDCP. Hopefully no surprises since it's been

Re: [Intel-gfx] [PATCH] dma-buf: Update docs for SYNC ioctl

2016-03-21 Thread Hans Verkuil
; Cc: David Herrmann > Cc: Sumit Semwal > Cc: Daniel Vetter > CC: linux-me...@vger.kernel.org > Cc: dri-de...@lists.freedesktop.org > Cc: linaro-mm-...@lists.linaro.org > Cc: intel-gfx@lists.freedesktop.org > Cc: de...@driverdev.osuosl.org > Cc: Hans Verkuil

Re: [Intel-gfx] Color management in DRM framework

2015-06-26 Thread Hans Verkuil
Hi Shashank, I have been working on support for colorspace handling for V4L2 (video capture), basically the flip-side of the coin that you are working on. While both the V4L2 and DRM/KMS APIs are completely different, the part that does the matrix calculations can be shared between the two. I wo

Re: [Intel-gfx] [PATCH v2 00/10] Color Manager Implementation

2015-07-13 Thread Hans Verkuil
On 06/15/2015 08:53 AM, Daniel Vetter wrote: > On Tue, Jun 09, 2015 at 01:50:48PM +0100, Damien Lespiau wrote: >> On Thu, Jun 04, 2015 at 07:12:31PM +0530, Kausal Malladi wrote: >>> From: Kausal Malladi >>> >>> This patch set adds color manager implementation in drm/i915 layer. >>> Color Manager i

Re: [Intel-gfx] [PATCH v2 00/10] Color Manager Implementation

2015-07-13 Thread Hans Verkuil
On 07/13/2015 11:18 AM, Daniel Vetter wrote: > On Mon, Jul 13, 2015 at 10:29:32AM +0200, Hans Verkuil wrote: >> On 06/15/2015 08:53 AM, Daniel Vetter wrote: >>> On Tue, Jun 09, 2015 at 01:50:48PM +0100, Damien Lespiau wrote: >>>> On Thu, Jun 04, 2015 at 07:12:31

Re: [Intel-gfx] [PATCH v2 00/10] Color Manager Implementation

2015-07-13 Thread Hans Verkuil
On 07/13/2015 11:54 AM, Daniel Vetter wrote: > On Mon, Jul 13, 2015 at 11:43:31AM +0200, Hans Verkuil wrote: >> On 07/13/2015 11:18 AM, Daniel Vetter wrote: >>> On Mon, Jul 13, 2015 at 10:29:32AM +0200, Hans Verkuil wrote: >>>> On 06/15/2015 08:53 AM, Daniel Vett

Re: [Intel-gfx] [PATCH v2 00/10] Color Manager Implementation

2015-07-14 Thread Hans Verkuil
On 07/13/15 16:07, Daniel Vetter wrote: > On Mon, Jul 13, 2015 at 12:11:08PM +0200, Hans Verkuil wrote: >> On 07/13/2015 11:54 AM, Daniel Vetter wrote: >>> On Mon, Jul 13, 2015 at 11:43:31AM +0200, Hans Verkuil wrote: >>>> On 07/13/2015 11:18 AM, Daniel Vetter wrote:

Re: [Intel-gfx] [PATCH v2 00/10] Color Manager Implementation

2015-07-14 Thread Hans Verkuil
On 07/14/15 11:11, Daniel Vetter wrote: > On Tue, Jul 14, 2015 at 10:17:09AM +0200, Hans Verkuil wrote: >> On 07/13/15 16:07, Daniel Vetter wrote: >>> On Mon, Jul 13, 2015 at 12:11:08PM +0200, Hans Verkuil wrote: >>>> On 07/13/2015 11:54 AM, Daniel Vetter wrote: >&

Re: [Intel-gfx] [PATCH v2 00/10] Color Manager Implementation

2015-07-15 Thread Hans Verkuil
On 07/14/15 12:16, Daniel Vetter wrote: I would guess that a LUT supporting 16 bit color components would need a precision of 0.20 or so (assuming the resulting values are used in further calculations). High dynamic range video will be an important driving force t

Re: [Intel-gfx] [PATCH v2 00/10] Color Manager Implementation

2015-07-15 Thread Hans Verkuil
On 07/15/15 14:35, Hans Verkuil wrote: > On 07/14/15 12:16, Daniel Vetter wrote: > > > >>>>> I would guess that a LUT supporting 16 bit color components would need a >>>>> precision >>>>> of 0.20 or so (assuming the resulting values a

[Intel-gfx] [RFC PATCH 0/7] drm/i915: add support for DisplayPort CEC-Tunneling-over-AUX

2017-05-25 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX protocol. This patch series is based on v4.12-rc2. The first four patches add support for a new CEC capability which is needed for these devices and for two helper functions. Then the DP CEC registers

[Intel-gfx] [RFC PATCH 5/7] drm/cec: Add CEC over Aux register definitions

2017-05-25 Thread Hans Verkuil
From: Clint Taylor Adding DPCD register definitions from the DP 1.3 specification for CEC over AUX support. V2: Add DP_ prefix to all defines. V3: missed prefixes from the ESI1 defines Cc: Jani Nikula Reviewed-by: Jani Nikula Signed-off-by: Clint Taylor Signed-off-by: Jani Nikula Link: ht

[Intel-gfx] [RFC PATCH 6/7] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2017-05-25 Thread Hans Verkuil
From: Hans Verkuil This adds support for the DisplayPort CEC-Tunneling-over-AUX feature that is part of the DisplayPort 1.3 standard. Unfortunately, not all DisplayPort/USB-C to HDMI adapters with a chip that has this capability actually hook up the CEC pin, so even though a CEC device is

[Intel-gfx] [RFC PATCH 1/7] cec: add CEC_CAP_NEEDS_HPD

2017-05-25 Thread Hans Verkuil
From: Hans Verkuil Add a new capability CEC_CAP_NEEDS_HPD. If this capability is set then the hardware can only use CEC if the HDMI Hotplug Detect pin is high. Such hardware cannot handle the corner case in the CEC specification where it is possible to transmit messages even if no hotplug signal

[Intel-gfx] [RFC PATCH 4/7] cec: add cec_phys_addr_invalidate() helper function

2017-05-25 Thread Hans Verkuil
From: Hans Verkuil Simplifies setting the physical address to CEC_PHYS_ADDR_INVALID. Signed-off-by: Hans Verkuil --- include/media/cec.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/media/cec.h b/include/media/cec.h index 9989cdb58bd8..6123a5eec540 100644 --- a/include

[Intel-gfx] [RFC PATCH 2/7] cec-ioc-adap-g-caps.rst: document CEC_CAP_NEEDS_HPD

2017-05-25 Thread Hans Verkuil
From: Hans Verkuil Document the new CEC_CAP_NEEDS_HPD capability. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst b/Documentation/media/uapi

[Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-25 Thread Hans Verkuil
From: Hans Verkuil Implement support for this DisplayPort feature. The cec device is created whenever it detects an adapter that has this feature. It is only removed when a new adapter is connected that does not support this. If a new adapter is connected that has different properties than the

[Intel-gfx] [RFC PATCH 3/7] cec: add cec_s_phys_addr_from_edid helper function

2017-05-25 Thread Hans Verkuil
From: Hans Verkuil This function simplifies the integration of CEC in DRM drivers. Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-adap.c | 14 ++ include/media/cec.h | 9 + 2 files changed, 23 insertions(+) diff --git a/drivers/media/cec/cec-adap.c b

Re: [Intel-gfx] [RFC PATCH 0/7] drm/i915: add support for DisplayPort CEC-Tunneling-over-AUX

2017-05-25 Thread Hans Verkuil
model. There are some more adapters that I can test next week, and I'll see if I can also test a bunch of (mini-)DP to HDMI adapters. Regards, Hans > > Thanks > > Mike > > On Thu, 25 May 2017 at 16:06 Hans Verkuil <mailto:hverk...@xs4all.nl>> wrote

Re: [Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-26 Thread Hans Verkuil
On 05/26/2017 12:13 PM, Jani Nikula wrote: > On Thu, 25 May 2017, Hans Verkuil wrote: >> @@ -4179,6 +4181,33 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp) >> return -EINVAL; >> } >> >> +static bool >> +intel_dp_check_cec_status(struct

Re: [Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-26 Thread Hans Verkuil
On 05/26/2017 09:15 AM, Daniel Vetter wrote: > On Thu, May 25, 2017 at 05:06:26PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Implement support for this DisplayPort feature. >> >> The cec device is created whenever it detects an adapter that >> ha

Re: [Intel-gfx] [RFC PATCH 6/7] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2017-05-26 Thread Hans Verkuil
On 05/26/2017 09:18 AM, Daniel Vetter wrote: > On Thu, May 25, 2017 at 05:06:25PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> This adds support for the DisplayPort CEC-Tunneling-over-AUX >> feature that is part of the DisplayPort 1.3 standard. >> >

Re: [Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-30 Thread Hans Verkuil
On 05/29/2017 09:00 PM, Daniel Vetter wrote: On Fri, May 26, 2017 at 12:20:48PM +0200, Hans Verkuil wrote: On 05/26/2017 09:15 AM, Daniel Vetter wrote: Did you look into also wiring this up for dp mst chains? Isn't this sufficient? I have no way of testing mst chains. I think I need

Re: [Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-30 Thread Hans Verkuil
On 05/30/2017 04:19 PM, Clint Taylor wrote: On 05/30/2017 12:11 AM, Jani Nikula wrote: On Tue, 30 May 2017, Hans Verkuil wrote: On 05/29/2017 09:00 PM, Daniel Vetter wrote: On Fri, May 26, 2017 at 12:20:48PM +0200, Hans Verkuil wrote: On 05/26/2017 09:15 AM, Daniel Vetter wrote: Did you

Re: [Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-30 Thread Hans Verkuil
On 05/30/2017 06:49 PM, Hans Verkuil wrote: On 05/30/2017 04:19 PM, Clint Taylor wrote: On 05/30/2017 12:11 AM, Jani Nikula wrote: On Tue, 30 May 2017, Hans Verkuil wrote: On 05/29/2017 09:00 PM, Daniel Vetter wrote: On Fri, May 26, 2017 at 12:20:48PM +0200, Hans Verkuil wrote: On 05/26

Re: [Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-30 Thread Hans Verkuil
On 05/30/2017 10:32 PM, Clint Taylor wrote: On 05/30/2017 09:54 AM, Hans Verkuil wrote: On 05/30/2017 06:49 PM, Hans Verkuil wrote: On 05/30/2017 04:19 PM, Clint Taylor wrote: On 05/30/2017 12:11 AM, Jani Nikula wrote: On Tue, 30 May 2017, Hans Verkuil wrote: On 05/29/2017 09:00 PM

Re: [Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-30 Thread Hans Verkuil
On 05/31/2017 01:25 AM, Clint Taylor wrote: On 05/30/2017 02:29 PM, Hans Verkuil wrote: On 05/30/2017 10:32 PM, Clint Taylor wrote: On 05/30/2017 09:54 AM, Hans Verkuil wrote: On 05/30/2017 06:49 PM, Hans Verkuil wrote: On 05/30/2017 04:19 PM, Clint Taylor wrote: On 05/30/2017 12:11

Re: [Intel-gfx] [RFC PATCH 6/7] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2017-05-30 Thread Hans Verkuil
On 05/31/2017 01:57 AM, Clint Taylor wrote: On 05/26/2017 12:18 AM, Daniel Vetter wrote: On Thu, May 25, 2017 at 05:06:25PM +0200, Hans Verkuil wrote: From: Hans Verkuil This adds support for the DisplayPort CEC-Tunneling-over-AUX feature that is part of the DisplayPort 1.3 standard

Re: [Intel-gfx] [PATCH 10/10] video/hdmi: Pass buffer size to infoframe unpack functions

2017-11-20 Thread Hans Verkuil
On 11/13/2017 06:04 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > To make sure the infoframe unpack functions don't end up examining > stack garbage or oopsing, let's pass in the size of the buffer. > > Cc: Thierry Reding > Cc: Hans Verkuil > Cc: linux-

Re: [Intel-gfx] [PATCH v2 0/8] drm/i915: Implement HDCP

2017-12-01 Thread Hans Verkuil
Hi Sean, On 12/01/2017 06:20 PM, Sean Paul wrote: > Ok, here's v2 of the HDCP patchset, no longer RFC since I've tackled the TODO > list I set out in the first version (Annotated below for convenience). > > The big changes to take note of in v2 is locking. To account for atomic async > + > the p

Re: [Intel-gfx] [PATCH v3 3/9] drm: Add Content Protection property

2017-12-05 Thread Hans Verkuil
On 12/05/2017 06:15 AM, Sean Paul wrote: > This patch adds a new optional connector property to allow userspace to enable > protection over the content it is displaying. This will typically be > implemented > by the driver using HDCP. > > The property is a tri-state with the following values: > -

Re: [Intel-gfx] BUG: KASAN: use-after-free in intel_hdmi_destroy+0x79/0x80

2019-02-25 Thread Hans Verkuil
Hi Jani, On 2/25/19 2:40 PM, Jani Nikula wrote: On Fri, 22 Feb 2019, Randy Dunlap wrote: This is 5.0-rc7 on an old Toshiba Portege laptop. No hdmi or other external video. Linux dragon.dunlab 5.0.0-rc7mod #3 SMP PREEMPT Wed Feb 20 00:05:17 PST 2019 x86_64 x86_64 x86_64 GNU/Linux on openSUSE

Re: [Intel-gfx] [PATCH v4] dma-buf-map: Rename to iosys-map

2022-02-08 Thread Hans Verkuil
_drv.h | 6 +- > drivers/gpu/drm/vkms/vkms_plane.c | 2 +- > drivers/gpu/drm/vkms/vkms_writeback.c | 2 +- > drivers/gpu/drm/xen/xen_drm_front_gem.c | 7 +- > drivers/gpu/drm/xen/xen_drm_front_gem.h | 6 +- For these three: > .../common/videobuf2/videobuf2-dma-contig.c | 8 +- > .../media/common/videobuf2/videobuf2-dma-sg.c | 9 +- > .../common/videobuf2/videobuf2-vmalloc.c | 11 +- Acked-by: Hans Verkuil Regards, Hans

Re: [Intel-gfx] [PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-31 Thread Hans Verkuil
On 31/08/2023 12:51, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil > Cc: linux-me...@vger.k

Re: [Intel-gfx] [PATCH 5/6] drm/i915/cec: switch to setting physical address directly

2023-08-31 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > Avoid parsing the EDID again for source physical address. Also gets rids > of a few remaining raw EDID usages. > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula Reviewed-by: Hans Verkuil Rega

Re: [Intel-gfx] [PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-31 Thread Hans Verkuil
ng is a bit specific now that > there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > v2: Fix the embarrashing build failures > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula Reviewed-by: Hans Verku

Re: [Intel-gfx] [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-31 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil > Cc: linux-me...@vger.k

Re: [Intel-gfx] [PATCH 3/6] drm/edid: parse source physical address

2023-08-31 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > CEC needs the source physical address. Parsing it is trivial with the > existing EDID CEA DB infrastructure. > > Default to CEC_PHYS_ADDR_INVALID (0x) instead of 0 to cater for > easier CEC usage. > > Cc: Hans Ve

Re: [Intel-gfx] [PATCH 0/6] drm, cec and edid updates

2023-08-31 Thread Hans Verkuil
rging via > drm-intel? That's fine, it makes sense to do that. If you need it, for this series: Acked-by: Hans Verkuil Regards, Hans > > Thanks, > Jani. > > >> >> drivers/gpu/drm/display/drm_dp_cec.c | 22 +++---

Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-31 Thread Hans Verkuil
there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/display/drm_dp_cec.c | 22 +++--- > include/drm/display

Re: [Intel-gfx] [PATCH v2 1/7] media: videobuf2: Don't assert held reservation lock for dma-buf mmapping

2023-04-12 Thread Hans Verkuil
d-by: Emil Velikov > Signed-off-by: Dmitry Osipenko Reviewed-by: Hans Verkuil Regards, Hans > --- > drivers/media/common/videobuf2/videobuf2-dma-contig.c | 3 --- > drivers/media/common/videobuf2/videobuf2-dma-sg.c | 3 --- > drivers/media/common/videobuf2/vide

Re: [Intel-gfx] [PATCH 11/15] media/videobuf2: Drop dma_buf->k(un)map support

2019-11-18 Thread Hans Verkuil
On 11/18/19 11:35 AM, Daniel Vetter wrote: > No in-tree users left. > > Signed-off-by: Daniel Vetter Acked-by: Hans Verkuil Thanks! Hans > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: linux-me...@vger.kernel.org >

Re: [Intel-gfx] Issue with cec_register_adapter calling request_module() from an async context when called from intel_dp_detect

2021-02-17 Thread Hans Verkuil
Hi Hans, On 17/02/2021 13:24, Hans de Goede wrote: > > > Hi Hans, > > Fedora has a (opt-in) system to automatically collect backtraces from software > crashing on users systems. > > This includes collecting kernel backtraces (including once triggered by > WARN macros) while looking a the top 1

Re: [Intel-gfx] Issue with cec_register_adapter calling request_module() from an async context when called from intel_dp_detect

2021-02-17 Thread Hans Verkuil
On 17/02/2021 16:11, Sean Young wrote: > Hi, > > On Wed, Feb 17, 2021 at 04:04:11PM +0100, Hans de Goede wrote: >> On 2/17/21 3:32 PM, Sean Young wrote: >>> On Wed, Feb 17, 2021 at 01:41:46PM +0100, Hans Verkuil wrote: >>>> Hi Hans, >>>&g

  1   2   >