[Intel-gfx] [RFC] drm/i915: Don't reset on preemptible workloads

2018-08-01 Thread Jakub Bartmiński
27;s execution. This new behaviour would allow the user to define intentionally large or passive workloads, that would normally be affected by the hangcheck, without having to divide them into smaller work. Suggested-by: Michał Winiarski Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Joonas Lah

[Intel-gfx] [PATCH v8 5/6] drm/i915: Add a fault injection point to WOPCM init

2018-07-27 Thread Jakub Bartmiński
Add a fault injection point in the WOPCM initialization path. v4: Move the injection inside the WOPCM init function. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko Reviewed-by: Michal Wajdeczko Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v8 4/6] drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context

2018-07-27 Thread Jakub Bartmiński
bias from intel_ring_pin. This introduces a slight functional change since we are always pinning the ring a bit higher if GuC is present even though we don't really need to. v8: Fixed patch not applying on the most recent upstream. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: M

[Intel-gfx] [PATCH v8 6/6] HAX enable GuC for CI

2018-07-27 Thread Jakub Bartmiński
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 6c4d4a21474b..323fdc258c6a 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v8 2/6] drm/i915/guc: Do not partition WOPCM if GuC is not used

2018-07-27 Thread Jakub Bartmiński
There seems to be no reason for doing extra work on WOPCM partitioning in the case GuC is not used, as the partitioning will not be used by the intel_wopcm_init_hw function anyway. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko Reviewed-by: Chris

[Intel-gfx] [PATCH v8 3/6] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-27 Thread Jakub Bartmiński
th the pin_bias in ggtt, which should be used for pinning. Fixed patch not applying or the most recent upstream. Fixes: f7dc0157e4b5 ("drm/i915/uc: Fetch GuC/HuC firmwares from guc/huc specific init") Testcase: igt/drv_selftest/mock_contexts #GuC Signed-off-by: Jakub Bartmiński Cc: Chris

[Intel-gfx] [PATCH v8 1/6] drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias

2018-07-27 Thread Jakub Bartmiński
nce we now don't use guc.base for the pin bias there's no need to validate it. It also has already been verified in WOPCM init. Bspec: 1180 Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko Reviewed-by: Michał Winiarski Reviewed-by: Michal Waj

[Intel-gfx] [PATCH v7 6/6] HAX enable GuC for CI

2018-07-27 Thread Jakub Bartmiński
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index aebe0469ddaa..3e4e128237ac 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v7 5/6] drm/i915: Add a fault injection point to WOPCM init

2018-07-27 Thread Jakub Bartmiński
Add a fault injection point in the WOPCM initialization path. v4: Move the injection inside the WOPCM init function. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_wopcm.c | 3 +++ 1 file changed, 3 insertions

[Intel-gfx] [PATCH v7 4/6] drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context

2018-07-27 Thread Jakub Bartmiński
bias from intel_ring_pin. This introduces a slight functional change since we are always pinning the ring a bit higher if GuC is present even though we don't really need to. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko Reviewed-by: Chris W

[Intel-gfx] [PATCH v7 1/6] drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias

2018-07-27 Thread Jakub Bartmiński
nce we now don't use guc.base for the pin bias there's no need to validate it. It also has already been verified in WOPCM init. Bspec: 1180 Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko Reviewed-by: Michał Winiarski Reviewed-by: Michal Waj

[Intel-gfx] [PATCH v7 2/6] drm/i915/guc: Do not partition WOPCM if GuC is not used

2018-07-27 Thread Jakub Bartmiński
There seems to be no reason for doing extra work on WOPCM partitioning in the case GuC is not used, as the partitioning will not be used by the intel_wopcm_init_hw function anyway. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko Reviewed-by: Chris

[Intel-gfx] [PATCH v7 3/6] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-27 Thread Jakub Bartmiński
pecific init") Testcase: igt/drv_selftest/mock_contexts #GuC Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem_context.c | 10 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 9 + drivers/gpu/drm/i915/i915_gem_g

[Intel-gfx] [PATCH v6 4/6] drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context

2018-07-27 Thread Jakub Bartmiński
bias from intel_ring_pin. This introduces a slight functional change since we are always pinning the ring a bit higher if GuC is present even though we don't really need to. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm

[Intel-gfx] [PATCH v6 2/6] drm/i915/guc: Do not partition WOPCM if GuC is not used.

2018-07-27 Thread Jakub Bartmiński
There seems to be no reason for doing extra work on WOPCM partitioning in the case GuC is not used, as the partitioning will not be used by the intel_wopcm_init_hw function anyway. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm

[Intel-gfx] [PATCH v6 3/6] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-27 Thread Jakub Bartmiński
;drm/i915/uc: Fetch GuC/HuC firmwares from guc/huc specific init") Testcase: igt/drv_selftest/mock_contexts #GuC Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem_context.c | 10 +- drivers/gpu/drm/

[Intel-gfx] [PATCH v6 1/6] drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias

2018-07-27 Thread Jakub Bartmiński
nce we now don't use guc.base for the pin bias there's no need to validate it. It also has already been verified in WOPCM init. Bspec: 1180 Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko Reviewed-by: Michał Winiarski Reviewed-by: Michal Waj

[Intel-gfx] [PATCH v6 5/6] drm/i915: Add a fault injection point to WOPCM init

2018-07-27 Thread Jakub Bartmiński
Add a fault injection point in the WOPCM initialization path. v4: Move the injection inside the WOPCM init function. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_wopcm.c | 3 +++ 1 file changed, 3 insertions

[Intel-gfx] [PATCH v6 6/6] HAX enable GuC for CI

2018-07-27 Thread Jakub Bartmiński
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index aebe0469ddaa..3e4e128237ac 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v5 3/5] drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context

2018-07-25 Thread Jakub Bartmiński
bias from intel_ring_pin. This introduces a slight functional change since we are always pinning a ring a bit higher if GuC is present even though we don't really need to. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm

[Intel-gfx] [PATCH v5 5/5] HAX enable GuC for CI

2018-07-25 Thread Jakub Bartmiński
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index aebe0469ddaa..3e4e128237ac 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v5 4/5] drm/i915: Add a fault injection point to WOPCM init

2018-07-25 Thread Jakub Bartmiński
v4: Move the injection inside the WOPCM init. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_wopcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v5 1/5] drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias

2018-07-25 Thread Jakub Bartmiński
nce we now don't use guc.base for the pin bias there's no need to validate it. It also has already been verified in WOPCM init. Bspec: 1180 Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko Reviewed-by: Michał Winiarski Reviewed-by: Michal Waj

[Intel-gfx] [PATCH v5 2/5] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-25 Thread Jakub Bartmiński
ic init") Testcase: igt/drv_selftest/mock_contexts #GuC Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem_context.c | 22 ++ drivers/gpu/drm/i915/i915_gem_gtt.c | 18 ++ drivers

[Intel-gfx] [PATCH v4 2/5] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-20 Thread Jakub Bartmiński
some functions use it instead of directly dereferencing i915->ggtt. Fixes: f7dc0157e4b5 ("drm/i915/uc: Fetch GuC/HuC firmwares from guc/huc specific init") Testcase: igt/drv_selftest/mock_contexts #GuC Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajde

[Intel-gfx] [PATCH v4 3/5] drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context

2018-07-20 Thread Jakub Bartmiński
bias from intel_ring_pin. This introduces a slight functional change since we are always pinning a ring a bit higher if GuC is present even though we don't really need to. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm

[Intel-gfx] [PATCH v4 5/5] HAX enable GuC for CI

2018-07-20 Thread Jakub Bartmiński
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index aebe0469ddaa..3e4e128237ac 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v4 4/5] drm/i915: Add a fault injection point to WOPCM init

2018-07-20 Thread Jakub Bartmiński
v4: Move the injection inside the WOPCM init. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_wopcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v4 1/5] drm/i915/guc: Avoid wasting memory on incorrect GuC pin bias

2018-07-20 Thread Jakub Bartmiński
It would appear that the calculated GuC pin bias was larger than it should be, as the GuC address space does NOT contain the "HW contexts RSVD" part of the WOPCM. Thus, the GuC pin bias is simply the GuC WOPCM size. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Win

[Intel-gfx] [PATCH v3 5/5] HAX enable GuC for CI

2018-07-19 Thread Jakub Bartmiński
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index aebe0469ddaa..3e4e128237ac 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v3 1/5] drm/i915/guc: Fix GuC pin bias and WOPCM initialization order

2018-07-19 Thread Jakub Bartmiński
variables in intel_wopcm_init. Fixes: f7dc0157e4b5 ("drm/i915/uc: Fetch GuC/HuC firmwares from guc/huc specific init") Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_guc.c | 21 - drive

[Intel-gfx] [PATCH v3 2/5] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-19 Thread Jakub Bartmiński
e pin bias is left at 0 and we make sure that the pin bias with GuC will not be smaller than without GuC. v3: Avoid unused i915 in intel_guc_ggtt_offset if debug is disabled. Testcase: igt/drv_selftest/mock_contexts #GuC Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: M

[Intel-gfx] [PATCH v3 4/5] drm/i915: Add a fault injection point after WOPCM init

2018-07-19 Thread Jakub Bartmiński
Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index ed2be33ec58a..dd170a293d05 100644

[Intel-gfx] [PATCH v3 3/5] drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context

2018-07-19 Thread Jakub Bartmiński
Since ggtt_offset_bias is now stored in ggtt.pin_bias, it is duplicated inside i915_gem_context, and can instead be accessed directly from ggtt. v3: Added a helper function to retrieve the ggtt.pin_bias from the vma. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc

[Intel-gfx] [PATCH v2 5/5] HAX enable GuC for CI

2018-07-18 Thread Jakub Bartmiński
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index aebe0469ddaa..3e4e128237ac 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Fix GuC pin bias and WOPCM initialization order

2018-07-18 Thread Jakub Bartmiński
variables in intel_wopcm_init. Fixes: f7dc0157e4b5 ("drm/i915/uc: Fetch GuC/HuC firmwares from guc/huc specific init") Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_guc.c | 21 - drive

[Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-18 Thread Jakub Bartmiński
e pin bias is left at 0 and we make sure that the pin bias with GuC will not be smaller than without GuC. Testcase: igt/drv_selftest/mock_contexts #GuC Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem_context.c

[Intel-gfx] [PATCH v2 3/5] drm/i915: Remove unnecessary ggtt_offset_bias from i915_gem_context

2018-07-18 Thread Jakub Bartmiński
Since ggtt_offset_bias is now stored in ggtt.pin_bias, it is duplicated inside i915_gem_context, and can instead be accessed directly from ggtt. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem_context.c | 2

[Intel-gfx] [PATCH v2 4/5] drm/i915: Add a fault injection point after WOPCM init

2018-07-18 Thread Jakub Bartmiński
Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index ed2be33ec58a..dd170a293d05 100644

[Intel-gfx] [PATCH 3/3] HAX enable guc for CI

2018-07-17 Thread Jakub Bartmiński
From: Michał Winiarski --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index aebe0469ddaa..3e4e128237ac 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/driver

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Fix GuC pin bias and WOPCM initialization order

2018-07-17 Thread Jakub Bartmiński
variables in intel_wopcm_init. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_guc.c | 21 - drivers/gpu/drm/i915/intel_wopcm.c | 19 +++ 2 files changed, 19 insertions(+), 21

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Move the pin bias value from GuC to GGTT

2018-07-17 Thread Jakub Bartmiński
order. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem.c | 8 +++--- drivers/gpu/drm/i915/i915_gem_context.c | 10 +-- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] HAX enable GuC for CI

2018-07-12 Thread Jakub Bartmiński
From: Michal Wajdeczko Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index aebe0469ddaa..3e4e128237ac 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH 1/2] drm/i915: Keep local modparams copy for mock selftests

2018-07-12 Thread Jakub Bartmiński
the issue. Signed-off-by: Jakub Bartmiński Cc: Chris Wilson Cc: Michał Winiarski --- drivers/gpu/drm/i915/i915_pci.c | 10 ++ drivers/gpu/drm/i915/selftests/i915_gem_context.c | 6 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_pci.c b