[PATCH v2 6/6] drm/i915: remove unused pipe/plane B register macros

2024-06-07 Thread Jani Nikula
None of these are used. The parametrized register macros all depend on the pipe/plane A offset macros alone. Remove the unused ones. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/gpu

[PATCH v2 5/6] drm/i915: relocate some DSPCNTR reg bit definitions

2024-06-07 Thread Jani Nikula
Some plane B/C specific bits were left next to the unused _DSPBCNTR macro. Move them next to the DSPCNTR() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 ++ drivers/gpu/drm/i915/i915_reg.h| 2 -- 2 files changed, 2 insertions(+), 2

[PATCH v2 4/6] drm/i915/gvt: do not use implict dev_priv in DSPSURF_TO_PIPE()

2024-06-07 Thread Jani Nikula
Do not rely on having dev_priv local variable, pass it to the macro. Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 3/6] drm/i915/gvt: rename range variable to stride

2024-06-07 Thread Jani Nikula
Range is a bit odd name for what really is stride. Rename. Switch to u32 while at it. Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 2/6] drm/i915/gvt: use proper i915_reg_t for calc_index() parameters

2024-06-07 Thread Jani Nikula
planes beyond C either. But all that is unrelated to the change at hand. Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[PATCH v2 1/6] drm/i915/gvt: remove the unused end parameter from calc_index()

2024-06-07 Thread Jani Nikula
All callers of calc_index() pass 0 for the end parameter. Remove it. Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git

[PATCH v2 0/6] drm/i915: gvt register macro cleanups, unused macro removals

2024-06-07 Thread Jani Nikula
v2 of https://lore.kernel.org/r/cover.1717757337.git.jani.nik...@intel.com Jani Nikula (6): drm/i915/gvt: remove the unused end parameter from calc_index() drm/i915/gvt: use proper i915_reg_t for calc_index() parameters drm/i915/gvt: rename range variable to stride drm/i915/gvt: do

Re: [PATCH 6/6] drm/i915: remove unused HSW_STEREO_3D_CTL register macros

2024-06-07 Thread Jani Nikula
On Fri, 07 Jun 2024, Ville Syrjälä wrote: > On Fri, Jun 07, 2024 at 03:21:22PM +0300, Jani Nikula wrote: >> On Fri, 07 Jun 2024, Ville Syrjälä wrote: >> > On Fri, Jun 07, 2024 at 01:51:29PM +0300, Jani Nikula wrote: >> >> Remove the unused HSW_STEREO_3D_CTL regi

Re: [PATCH 6/6] drm/i915: remove unused HSW_STEREO_3D_CTL register macros

2024-06-07 Thread Jani Nikula
On Fri, 07 Jun 2024, Ville Syrjälä wrote: > On Fri, Jun 07, 2024 at 01:51:29PM +0300, Jani Nikula wrote: >> Remove the unused HSW_STEREO_3D_CTL register macros. > > I don't enjoy having to trawl the specs to find registers. > So I prefer to keep everything that isn't actual

Re: [PATCH 5/6] drm/i915: remove unused pipe/plane B register macros

2024-06-07 Thread Jani Nikula
On Fri, 07 Jun 2024, Ville Syrjälä wrote: > On Fri, Jun 07, 2024 at 01:51:28PM +0300, Jani Nikula wrote: >> None of these are used. The parametrized register macros all depend on >> the pipe/plane A offset macros alone. Remove the unused ones. >> >> Signed-off-by: Jani

Re: [PATCH 0/2] drm/i915 & drm/xe: drop ACPI_BUTTON

2024-06-07 Thread Jani Nikula
On Fri, 07 Jun 2024, Ville Syrjälä wrote: > On Fri, Jun 07, 2024 at 11:07:05AM +0300, Jani Nikula wrote: >> Both in a series because they're related, but they should be merged via >> their own driver trees. >> >> Jani Nikula (2): >> drm/i915: do not s

[PATCH 6/6] drm/i915: remove unused HSW_STEREO_3D_CTL register macros

2024-06-07 Thread Jani Nikula
Remove the unused HSW_STEREO_3D_CTL register macros. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 2d834c32a3fa..127b113189ef 100644 --- a/drivers

[PATCH 5/6] drm/i915: remove unused pipe/plane B register macros

2024-06-07 Thread Jani Nikula
None of these are used. The parametrized register macros all depend on the pipe/plane A offset macros alone. Remove the unused ones. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 4/6] drm/i915/gvt: do not use implict dev_priv in DSPSURF_TO_PIPE()

2024-06-07 Thread Jani Nikula
Do not rely on having dev_priv local variable, pass it to the macro. Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 3/6] drm/i915/gvt: rename range variable to stride

2024-06-07 Thread Jani Nikula
Range is a bit odd name for what really is stride. Rename. Switch to u32 while at it. Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/6] drm/i915/gvt: use proper i915_reg_t for calc_index() parameters

2024-06-07 Thread Jani Nikula
planes beyond C either. But all that is unrelated to the change at hand. Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[PATCH 1/6] drm/i915/gvt: remove the unused end parameter from calc_index()

2024-06-07 Thread Jani Nikula
All callers of calc_index() pass 0 for the end parameter. Remove it. Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git

[PATCH 0/6] drm/i915: gvt register macro cleanups, unused macro removals

2024-06-07 Thread Jani Nikula
Clean up gvt a bit mainly to be able to remove direct _DSPBSURF reference, but do some drive-by cleanups on top. And then proceed to remove _DSPBSURF and other unused register macros. BR, Jani. Jani Nikula (6): drm/i915/gvt: remove the unused end parameter from calc_index() drm/i915/gvt: use

Re: [PATCH 45/65] drm/i915: pass dev_priv explicitly to _DSPBSIZE

2024-06-07 Thread Jani Nikula
On Fri, 07 Jun 2024, Jani Nikula wrote: > On Thu, 06 Jun 2024, Rodrigo Vivi wrote: >> On Tue, Jun 04, 2024 at 06:26:03PM +0300, Jani Nikula wrote: >>> Avoid the implicit dev_priv local variable use, and pass dev_priv >>> explicitly to the _DSPBSIZE register macro. &

Re: [PATCH 45/65] drm/i915: pass dev_priv explicitly to _DSPBSIZE

2024-06-07 Thread Jani Nikula
On Thu, 06 Jun 2024, Rodrigo Vivi wrote: > On Tue, Jun 04, 2024 at 06:26:03PM +0300, Jani Nikula wrote: >> Avoid the implicit dev_priv local variable use, and pass dev_priv >> explicitly to the _DSPBSIZE register macro. >> >> Signed-off-by: Jani Nikula >> --- &g

[PATCH 2/2] drm/xe: do not select ACPI_BUTTON

2024-06-07 Thread Jani Nikula
The xe driver has never needed ACPI button. Selecting the kconfig is just copy-paste from i915, which no longer needs it either. Stop selecting ACPI_BUTTON. Cc: Ville Syrjälä Closes: https://lore.kernel.org/r/zmgsjsxhhcpv4...@intel.com Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/Kconfig

[PATCH 1/2] drm/i915: do not select ACPI_BUTTON

2024-06-07 Thread Jani Nikula
We stopped using ACPI button in commit 05c72e77ccda ("drm/i915: Nuke the LVDS lid notifier"). Also stop force enabling the ACPI_BUTTON config. Cc: Ville Syrjälä Closes: https://lore.kernel.org/r/zmgsjsxhhcpv4...@intel.com Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Kconfi

[PATCH 0/2] drm/i915 & drm/xe: drop ACPI_BUTTON

2024-06-07 Thread Jani Nikula
Both in a series because they're related, but they should be merged via their own driver trees. Jani Nikula (2): drm/i915: do not select ACPI_BUTTON drm/xe: do not select ACPI_BUTTON drivers/gpu/drm/i915/Kconfig | 1 - drivers/gpu/drm/xe/Kconfig | 1 - 2 files changed, 2 deletions

Re: [PATCH 2/2] drm/i915/overlay: convert intel_overlay_print_error_state() to drm_printer

2024-06-07 Thread Jani Nikula
On Thu, 06 Jun 2024, Rodrigo Vivi wrote: > On Thu, Jun 06, 2024 at 05:07:05PM +0300, Jani Nikula wrote: >> Use the regular drm printer, so we can drop the i915_error_printf() >> usage. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gp

[PATCH 2/2] drm/i915/overlay: convert intel_overlay_print_error_state() to drm_printer

2024-06-06 Thread Jani Nikula
Use the regular drm printer, so we can drop the i915_error_printf() usage. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_overlay.c | 11 +-- drivers/gpu/drm/i915/display/intel_overlay.h | 6 +++--- drivers/gpu/drm/i915/i915_gpu_error.c| 2 +- 3 files

[PATCH 1/2] drm/i915/dmc: convert intel_dmc_print_error_state() to drm_printer

2024-06-06 Thread Jani Nikula
Use the regular drm printer, so we can drop the i915_error_printf() usage. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 15 +++ drivers/gpu/drm/i915/display/intel_dmc.h | 6 +++--- drivers/gpu/drm/i915/i915_gpu_error.c| 3 ++- 3 files changed, 12

[PATCH] drm/edid: reduce DisplayID log spamming

2024-06-06 Thread Jani Nikula
Debug printing at DisplayID validation leads to lots of log spamming as it's called at DisplayID iterators during EDID parsing. Remove it, and replace with a less noisy message at connector EDID update. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 3 --- drivers/gpu/drm

Re: [PATCH 0/7] drm/i915: bdw+ pipe interrupt stuff

2024-06-06 Thread Jani Nikula
On Wed, 05 Jun 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Clean up the bdw+ pipe interrupt bits, and enable some new fault > interrupts on tgl+ and mtl+. Some clarifications needed on patch 6, but overall Reviewed-by: Jani Nikula > > Ville Syrjälä (7): >

Re: [PATCH 6/7] drm/i915: Enable pipeDMC fault interrupts on tgl+

2024-06-06 Thread Jani Nikula
efine XELPD_PIPE_SOFT_UNDERRUNREG_BIT(22) /* adl/dg2+ */ > #define GEN11_PIPE_PLANE7_FAULT REG_BIT(22) /* icl/tgl */ > #define XELPD_PIPE_HARD_UNDERRUNREG_BIT(21) /* adl/dg2+ */ -- Jani Nikula, Intel

Re: [PATCH v13 5/9] drm/dp: Add refresh rate divider to struct representing AS SDP

2024-06-06 Thread Jani Nikula
; > + bool target_rr_divider; > enum operation_mode mode; > }; -- Jani Nikula, Intel

Re: [PATCH 4/7] drm/i915: Extend GEN9_PIPE_PLANE_FLIP_DONE() to cover all universal planes

2024-06-06 Thread Jani Nikula
ine GEN11_PIPE_PLANE5_FAULT REG_BIT(20) /* icl+ */ > #define GEN12_PIPE_VBLANK_UNMOD REG_BIT(19) /* tgl+ */ > +#define GEN11_PIPE_PLANE7_FLIP_DONE REG_BIT(18) /* icl/tgl */ > +#define GEN11_PIPE_PLANE6_FLIP_DONE REG_BIT(17) /* icl/tgl */ Need to be careful with these, as th

[PATCH v2 14/14] drm/i915: move comments about FSB straps to proper place

2024-06-06 Thread Jani Nikula
Move the comment about FSB straps to where the relevant register is read. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 11 +-- drivers/gpu/drm/i915/soc/intel_dram.c | 8 2 files changed, 9 insertions(+), 10

[PATCH v2 13/14] drm/xe/display: drop unused rawclk_freq and RUNTIME_INFO()

2024-06-06 Thread Jani Nikula
With rawclk_freq moved to display runtime info, xe has no users left for them. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 - drivers/gpu/drm/xe/xe_device_types.h | 6 -- 2 files changed, 7 deletions(-) diff --git a/drivers/gpu/drm/xe

[PATCH v2 11/14] drm/i915: move rawclk init to intel_cdclk_init()

2024-06-06 Thread Jani Nikula
The rawclk initialization is a bit out of place in intel_device_info_runtime_init(). Move it to intel_cdclk_init(), with a bit of refactoring on intel_read_rawclk(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 23 +++--- drivers/gpu/drm/i915

[PATCH v2 12/14] drm/i915: move rawclk from runtime to display runtime info

2024-06-06 Thread Jani Nikula
It's mostly about display, so move it under display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_backlight.c | 10 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/display/intel_display_device.c| 2 ++ drivers/gpu

[PATCH v2 10/14] drm/i915/cdclk: use i9xx_fsb_freq() for rawclk_freq initialization

2024-06-06 Thread Jani Nikula
Instead of duplicating the CLKCFG parsing, reuse i9xx_fsb_freq() to figure out rawclk_freq where applicable. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 46 ++ 1 file changed, 3 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v2 09/14] drm/i915: use i9xx_fsb_freq() for GT clock frequency

2024-06-06 Thread Jani Nikula
obe(), with a dependency on intel_pcode_init(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c | 3 ++- drivers/gpu/drm/i915/soc/intel_dram.c | 2 +- drivers/gpu/drm/i915/soc/intel_dram.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) d

[PATCH v2 08/14] drm/i915: extend the fsb_freq initialization to more platforms

2024-06-06 Thread Jani Nikula
, similar to i9xx_hrawclk(). v2: - Add MISSING_CASE() (Ville) - Default to the same frequency for both branches (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_dram.c | 55 --- 1 file changed, 41 insertions(+), 14 deletions(-) diff --git a/drivers/gpu

[PATCH v2 07/14] drm/i915: convert fsb_freq and mem_freq to kHz

2024-06-06 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c | 6 ++-- drivers/gpu/drm/i915/gt/intel_rps.c| 11 +++--- drivers/gpu/drm/i915/soc/intel_dram.c | 50 +- 3 files changed, 34 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v2 06/14] drm/i915/gt: remove mem freq from gt debugfs

2024-06-06 Thread Jani Nikula
It's a bit out of place, and only printed for VLV/CHV. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c index

[PATCH v2 04/14] drm/i915/dram: split out pnv DDR3 detection

2024-06-06 Thread Jani Nikula
Split out the PNV DDR3 detection to a distinct step instead of conflating it with mem freq detection. Reviewed-by: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_dram.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 05/14] drm/i915/dram: rearrange mem freq init

2024-06-06 Thread Jani Nikula
Follow the same style in mem freq init as in fsb freq init, returning the value instead of assigning in multiple places. Reviewed-by: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_dram.c | 59 --- 1 file changed, 25 insertions(+), 34 deletions

[PATCH v2 03/14] drm/i915/dram: separate fsb freq detection from mem freq

2024-06-06 Thread Jani Nikula
To simplify further changes, add separate functions for reading the fsb frequency. This ends up reading CLKCFG register twice, but it's not a big deal. Reviewed-by: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_dram.c | 106 +++--- 1 file changed

[PATCH v2 02/14] drm/i915/wm: clarify logging on not finding CxSR latency config

2024-06-06 Thread Jani Nikula
Clarify and unify the logging on not finding PNV CxSR latency config. Just let the i915->fsb_freq == 0 || i915->mem_freq == 0 case go through the table instead of checking for it separately. v2: Do not check for fsb == 0 || mem == 0 separately (Matt) Signed-off-by: Jani Nikula --- drive

[PATCH v2 01/14] drm/i915/wm: rename intel_get_cxsr_latency -> pnv_get_cxsr_latency

2024-06-06 Thread Jani Nikula
Clarify that the function is specific to PNV, making subsequent changes slightly easier to grasp. Reviewed-by: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[PATCH v2 00/14] drm/i915: mem/fsb/rawclk freq cleanups

2024-06-06 Thread Jani Nikula
v2 of https://lore.kernel.org/r/cover.1716906179.git.jani.nik...@intel.com Jani Nikula (14): drm/i915/wm: rename intel_get_cxsr_latency -> pnv_get_cxsr_latency drm/i915/wm: clarify logging on not finding CxSR latency config drm/i915/dram: separate fsb freq detection from mem freq drm/i

Re: [PATCH 2/2] drm/i915/psr: Implment WA to help reach PC10

2024-06-06 Thread Jani Nikula
and use early return. > > val |= EDP_PSR_IDLE_FRAMES(psr_compute_idle_frames(intel_dp)); > > @@ -910,7 +979,9 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp) > u32 val = EDP_PSR2_ENABLE; > u32 psr_val = 0; > > - val |= EDP_PSR2_IDLE_FRAMES(psr_compute_idle_frames(intel_dp)); > + /* WA: 16023497226*/ > + if (wa_16023497226_check(intel_dp, false)) > + val |= EDP_PSR2_IDLE_FRAMES(psr_compute_idle_frames(intel_dp)); > > if (DISPLAY_VER(dev_priv) < 14 && !IS_ALDERLAKE_P(dev_priv)) > val |= EDP_SU_TRACK_ENABLE; -- Jani Nikula, Intel

Re: [PATCH 2/2] drm/i915/bios: Define the "luminance and gamma" sub-struct of block 46

2024-06-06 Thread Jani Nikula
On Wed, 05 Jun 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Since BDB version 211 block 46 has included more luminance and > gamma related information. Define it fully. The data is semi-based > on DisplayID v2.0 apparently. > > Signed-off-by: Ville Syrjälä Rev

Re: [PATCH 1/2] drm/i915/bios: Define block 46 chromaticity coordinates properly

2024-06-06 Thread Jani Nikula
definition, where the 10bit values are split into 2bit + 8bit > chunks. Adjust our struct definition to reflect that. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 27 --- > 1 file changed, 17 ins

Re: [PATCH 07/12] drm/i915: extend the fsb_freq initialization to more platforms

2024-06-06 Thread Jani Nikula
On Wed, 05 Jun 2024, Ville Syrjälä wrote: > On Tue, May 28, 2024 at 05:24:56PM +0300, Jani Nikula wrote: >> Initialize fsb frequency for more platforms to be able to use it for GT >> clock and rawclk frequency initialization. >> >> Note: There's a discrepancy be

Re: [PATCH 06/12] drm/i915: convert fsb_freq and mem_freq to kHz

2024-06-05 Thread Jani Nikula
On Wed, 05 Jun 2024, Ville Syrjälä wrote: > On Tue, May 28, 2024 at 05:24:55PM +0300, Jani Nikula wrote: >> We'll want to use fsb frequency for deriving GT clock and rawclk >> frequencies in the future. Increase the accuracy by converting to >> kHz. Do the same for m

Re: [PATCH 3/3] drm/amdgpu: drop redundant W=1 warnings from Makefile

2024-06-05 Thread Jani Nikula
On Thu, 23 May 2024, Jani Nikula wrote: > Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default > across the subsystem"), most of the extra warnings in the driver > Makefile are redundant. Remove them. > > Note that -Wmissing-declarations and -Wmiss

Re: [PATCH 2/3] drm/xe: drop redundant W=1 warnings from Makefile

2024-06-05 Thread Jani Nikula
On Thu, 23 May 2024, Jani Nikula wrote: > Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default > across the subsystem"), most of the extra warnings in the driver > Makefile are redundant. Remove them. > > Note that -Wmissing-declarations and -Wmiss

Re: [PATCH 1/3] drm/i915: drop redundant W=1 warnings from Makefile

2024-06-05 Thread Jani Nikula
On Thu, 23 May 2024, Jani Nikula wrote: > Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default > across the subsystem"), most of the extra warnings in the driver > Makefile are redundant. Remove them. > > Note that -Wmissing-declarations and -Wmiss

Re: [PATCH] drm/i915: Reduce DDI clock gating printk level from NOTICE to DEBUG

2024-06-05 Thread Jani Nikula
On Wed, 05 Jun 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > No idea why the DDI clock gating print is done with drm_notice(). > Just use drm_dbg_kms() since no one is going to be interested in > this under normal circumstances. > > Signed-off-by: Ville Syrjälä Rev

Fixes that failed to pick to v6.10-rc2

2024-06-05 Thread Jani Nikula
v6.10, please provide the backports. BR, Jani. -- Jani Nikula, Intel

[PATCH 65/65] drm/i915: pass dev_priv explicitly to MTL_CLKGATE_DIS_TRANS

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the MTL_CLKGATE_DIS_TRANS register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_psr.c | 5 +++-- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 4 insertions(+), 3

[PATCH 64/65] drm/i915: pass dev_priv explicitly to TRANS_SET_CONTEXT_LATENCY

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_SET_CONTEXT_LATENCY register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 5

[PATCH 60/65] drm/i915: pass dev_priv explicitly to TRANS_DDI_FUNC_CTL2

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_DDI_FUNC_CTL2 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 6 -- drivers/gpu/drm/i915/display/intel_ddi.c | 9 ++--- drivers/gpu/drm

[PATCH 63/65] drm/i915: pass dev_priv explicitly to TRANS_MSA_MISC

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_MSA_MISC register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 3 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions

[PATCH 58/65] drm/i915: pass dev_priv explicitly to HSW_STEREO_3D_CTL

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the HSW_STEREO_3D_CTL register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu

[PATCH 56/65] drm/i915: pass dev_priv explicitly to PIPE_LINK_M2

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_LINK_M2 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915

[PATCH 62/65] drm/i915: pass dev_priv explicitly to TGL_DP_TP_STATUS

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TGL_DP_TP_STATUS register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 3 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions

[PATCH 61/65] drm/i915: pass dev_priv explicitly to TGL_DP_TP_CTL

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TGL_DP_TP_CTL register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 3 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions

[PATCH 57/65] drm/i915: pass dev_priv explicitly to PIPE_LINK_N2

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_LINK_N2 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_gvt_mmio_table.c

[PATCH 59/65] drm/i915: pass dev_priv explicitly to TRANS_DDI_FUNC_CTL

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the TRANS_DDI_FUNC_CTL register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c| 12 +--- drivers/gpu/drm/i915/display/intel_ddi.c | 29 --- drivers/gpu

[PATCH 55/65] drm/i915: pass dev_priv explicitly to PIPE_LINK_N1

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_LINK_N1 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/gvt/display.c | 4 ++-- drivers/gpu/drm/i915/gvt/handlers.c

[PATCH 54/65] drm/i915: pass dev_priv explicitly to PIPE_LINK_M1

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_LINK_M1 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- drivers/gpu/drm/i915/gvt/display.c | 4 ++-- drivers/gpu/drm/i915/gvt/handlers.c

[PATCH 53/65] drm/i915: pass dev_priv explicitly to PIPE_DATA_N2

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_DATA_N2 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_gvt_mmio_table.c

[PATCH 52/65] drm/i915: pass dev_priv explicitly to PIPE_DATA_M2

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_DATA_M2 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915

[PATCH 51/65] drm/i915: pass dev_priv explicitly to PIPE_DATA_N1

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_DATA_N1 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/gvt/display.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h

[PATCH 50/65] drm/i915: pass dev_priv explicitly to PIPE_DATA_M1

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_DATA_M1 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- drivers/gpu/drm/i915/display/intel_fdi.c | 6 +++--- drivers/gpu/drm/i915/gvt/display.c

[PATCH 47/65] drm/i915: pass dev_priv explicitly to _DSPBTILEOFF

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBTILEOFF register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm

[PATCH 48/65] drm/i915: pass dev_priv explicitly to _DSPBOFFSET

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBOFFSET register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm

[PATCH 49/65] drm/i915: pass dev_priv explicitly to _DSPBSURFLIVE

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBSURFLIVE register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm

[PATCH 46/65] drm/i915: pass dev_priv explicitly to _DSPBSURF

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBSURF register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/handlers.c | 2 +- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 45/65] drm/i915: pass dev_priv explicitly to _DSPBSIZE

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBSIZE register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915

[PATCH 44/65] drm/i915: pass dev_priv explicitly to _DSPBPOS

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBPOS register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915

[PATCH 43/65] drm/i915: pass dev_priv explicitly to _DSPBSTRIDE

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBSTRIDE register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm

[PATCH 42/65] drm/i915: pass dev_priv explicitly to _DSPBADDR

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBADDR register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915

[PATCH 41/65] drm/i915: pass dev_priv explicitly to _DSPBCNTR

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _DSPBCNTR register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915

[PATCH 40/65] drm/i915: pass dev_priv explicitly to _PIPEB_FLIPCOUNT_G4X

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _PIPEB_FLIPCOUNT_G4X register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers

[PATCH 39/65] drm/i915: pass dev_priv explicitly to _PIPEB_FRMCOUNT_G4X

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _PIPEB_FRMCOUNT_G4X register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers

[PATCH 38/65] drm/i915: pass dev_priv explicitly to _PIPEBSTAT

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _PIPEBSTAT register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm

[PATCH 37/65] drm/i915: pass dev_priv explicitly to _TRANSBCONF

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _TRANSBCONF register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm

[PATCH 36/65] drm/i915: pass dev_priv explicitly to _PIPEBDSL

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the _PIPEBDSL register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915

[PATCH 35/65] drm/i915: pass dev_priv explicitly to SWF3

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the SWF3 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/i915_suspend.c | 12 2 files changed, 9 insertions(+), 5 deletions(-) diff

[PATCH 34/65] drm/i915: pass dev_priv explicitly to SWF1

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the SWF1 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/i915_suspend.c | 18 -- 2 files changed, 13 insertions(+), 7 deletions

[PATCH 33/65] drm/i915: pass dev_priv explicitly to SWF0

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the SWF0 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/i915_suspend.c | 12 2 files changed, 9 insertions(+), 5 deletions(-) diff

[PATCH 32/65] drm/i915: pass dev_priv explicitly to CHV_CANVAS

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the CHV_CANVAS register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH 31/65] drm/i915: pass dev_priv explicitly to CHV_BLEND

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the CHV_BLEND register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions

[PATCH 30/65] drm/i915: pass dev_priv explicitly to PIPE_FLIPCOUNT_G4X

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_FLIPCOUNT_G4X register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- drivers/gpu/drm/i915/gvt/handlers.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h

[PATCH 29/65] drm/i915: pass dev_priv explicitly to PIPE_FRMCOUNT_G4X

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_FRMCOUNT_G4X register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vblank.c | 2 +- drivers/gpu/drm/i915/gvt/display.c | 2 +- drivers/gpu/drm/i915/i915_reg.h

[PATCH 28/65] drm/i915: pass dev_priv explicitly to DSPFW3

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPFW3 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c| 27 ++- .../drm/i915/display/intel_display_debugfs.c | 2 +- drivers/gpu/drm/i915

[PATCH 27/65] drm/i915: pass dev_priv explicitly to DSPFW2

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPFW2 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c | 13 +++-- drivers/gpu/drm/i915/i915_reg.h| 2 +- 2 files changed, 8 insertions(+), 7 deletions

[PATCH 26/65] drm/i915: pass dev_priv explicitly to DSPFW1

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPFW1 register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c | 25 + drivers/gpu/drm/i915/i915_reg.h| 2 +- 2 files changed, 14 insertions(+), 13

[PATCH 25/65] drm/i915: pass dev_priv explicitly to DSPARB

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPARB register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_wm.c | 22 -- drivers/gpu/drm/i915/i915_reg.h| 2 +- drivers/gpu/drm/i915/i915_suspend.c

[PATCH 24/65] drm/i915: pass dev_priv explicitly to ICL_PIPESTATUS

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the ICL_PIPESTATUS register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 9 ++--- drivers/gpu/drm/i915/i915_reg.h| 2 +- 2 files changed, 7

[PATCH 23/65] drm/i915: pass dev_priv explicitly to PIPE_ARB_CTL

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPE_ARB_CTL register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH 22/65] drm/i915: pass dev_priv explicitly to PIPESTAT

2024-06-04 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPESTAT register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_irq.c | 9 + drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 4 ++-- drivers/gpu/drm/i915

  1   2   3   4   5   6   7   8   9   10   >