Re: [Intel-gfx] [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h

2016-03-08 Thread Jean Delvare
parts of the kernel; the i915 graphics driver is going to need to use > this structure soon as well. Looks good in principle, a few suggestions inline below: > Cc: Mauro Carvalho Chehab > Cc: Jean Delvare > Cc: linux-e...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org

Re: [Intel-gfx] [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2)

2016-03-19 Thread Jean Delvare
*dclk_freq = -1; > return; You do not need all of these changes. memdev_dmi_entry was both the structure name and the variable name in the original code (something I usually avoid, but C allows it.) Just because you renamed the structure doesn't mean you have to rename the variable. Other than that, looks good to me. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2)

2017-07-31 Thread Jean Delvare
Hi Matt, Mauro, On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote: > > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for > > decoding DMI memory device entries. Move the structure definition to &g

Re: [Intel-gfx] [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2)

2017-08-10 Thread Jean Delvare
On mer., 2017-08-09 at 09:18 -0700, Matt Roper wrote: > On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote: > > > > Hi Matt, Mauro, > > > > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > > > > > > On Tue, 8 Mar 2016 10:32:3

Re: [Intel-gfx] [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio

2019-11-15 Thread Jean Delvare
top.org/show_bug.cgi?id=112140 > References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found") > Signed-off-by: Chris Wilson > Cc: Harry Wentland > Cc: Jean Delvare > Cc: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Don't look for CEA data blocks in CEA ext block rev < 3

2019-09-10 Thread Jean Delvare
ck they could end up misinterpreting > whatever data is in the reserved section as CEA data blocks. > > Let's have cea_db_offsets() do the revision check so that the > callers don't even have worry about it. > > Cc: Jean Delvare > Signed-off-by: Ville Syrjälä > ---

Re: [Intel-gfx] [PATCH 2/2] drm/edid: Have cea_db_offsets() zero start/end when the data block collection isn't found

2019-09-10 Thread Jean Delvare
r the caller > to blindly iterate the data blocks even if there are none. > > Cc: Jean Delvare > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid

Re: [Intel-gfx] [PATCH 2/2] drm/edid: Have cea_db_offsets() zero start/end when the data block collection isn't found

2019-09-10 Thread Jean Delvare
On Tue, 10 Sep 2019 12:48:42 +0300, Ville Syrjälä wrote: > On Tue, Sep 10, 2019 at 11:46:20AM +0200, Jean Delvare wrote: > > Hi Ville, > > > > On Mon, 2 Sep 2019 16:15:46 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Let&