Re: [PATCH v2 00/11] drm: Introduce DRM client library

On 02/10/2024 15:04, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the in-kernel client code. It is desig

Re: [PATCH 5/5] drm: Add client-lib module

On 30/09/2024 13:55, Jocelyn Falempe wrote: On 27/09/2024 16:37, Thomas Zimmermann wrote: Add drm_client_lib.ko to contain most of the client code. Move the existing client for fbdev emulation into the new module. Protect the new module behind CONFIG_DRM_CLIENT. The Kconfig rules separate the

Re: [PATCH 5/5] drm: Add client-lib module

n the KMS-helper module for now. Amdgpu has an internal DRM client, so it has to select DRM_CLIENT by itself unconditionally. Thanks, I found a typo in the Makefile (see below), other than that it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- driver

Re: [PATCH 4/5] drm: Select fbdev helpers for modules that require them

On 27/09/2024 16:37, Thomas Zimmermann wrote: Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann

Re: [PATCH 3/5] drm: Move client-device functions in to drm_client_dev.c

ut it looks good to me. Reviewed-by: Jocelyn Falempe -- Jocelyn Signed-off-by: Thomas Zimmermann --- Documentation/gpu/drm-client.rst | 3 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_client.c | 121 --- drivers/gpu/drm/drm_client_dev.c

Re: [PATCH 0/5] drm: Introduce DRM client library

On 27/09/2024 16:37, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the common client code. It's designed

Re: [PATCH v2 56/86] drm/mgag200: Run DRM default client setup

On 21/08/2024 14:59, Thomas Zimmermann wrote: Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Thanks for this whole series. Reviewed-by: Jocelyn Fa

Re: [PATCH v2 51/86] drm/ast: Run DRM default client setup

fault if no format has been given, leave it out entirely. Thanks for this whole series. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 6 -- 1 file changed, 4 insertions(

Re: linux-next: build warnings after merge of the drm-misc tree

On 16/04/2024 09:31, Stephen Rothwell wrote: Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced these warnings: drivers/gpu/drm/drm_fb_dma_helper.c:166: warning: Excess function parameter 'drm_scanout_buffer' description in 'drm_fb_dma_get_scanout_buffer'

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

On 12/01/2023 16:56, Nathan Chancellor wrote: Hi Jocelyn, On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote: This patch does also solve a kernel crash when reading /sys/class/drm/card1/gt/gt0/* on a skylake machine: https://bugzilla.redhat.com/show_bug.cgi?id=2154880

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

Hi, This patch does also solve a kernel crash when reading /sys/class/drm/card1/gt/gt0/* on a skylake machine: https://bugzilla.redhat.com/show_bug.cgi?id=2154880 Do you think it can be backported to stable releases ? Conflicts are trivial on top of v6.0 at least. Thanks, -- Jocelyn On 13