Re: [Intel-gfx] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread John Stultz
eady required anyway, so > this should be the correct flag to check for. > > References: > https://lore.kernel.org/lkml/cakmk7uhi+mg0z0humnt13qccvuturvjpcr0njrl12k-wbwz...@mail.gmail.com/ > Acked-by: Christian König > Cc: Jason Gunthorpe > Cc: Suren Baghdasaryan > Cc

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-02-16 Thread John Stultz
On Tue, Feb 16, 2021 at 7:30 PM John Stultz wrote: > > On Wed, Jan 13, 2021 at 6:06 AM Daniel Vetter wrote: > > > > We have too many people abusing the struct page they can get at but > > really shouldn't in importers. Aside from that the backing page might > > sim

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-02-16 Thread John Stultz
On Wed, Jan 13, 2021 at 6:06 AM Daniel Vetter wrote: > > We have too many people abusing the struct page they can get at but > really shouldn't in importers. Aside from that the backing page might > simply not exist (for dynamic p2p mappings) looking at it and using it > e.g. for mmap can also

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-15 Thread John Stultz
On Thu, Jan 14, 2021 at 1:03 AM Daniel Vetter wrote: > > On Wed, Jan 13, 2021 at 10:08 PM Chris Wilson > wrote: > > Quoting Daniel Vetter (2021-01-13 20:50:11) > > > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Daniel Vetter (2021-01-13 14:06:04) > > > > >

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 1:49 PM, Laurent Pinchart wrote: > On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: >> On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: >> > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: >> >> Possibly sl

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: >> Hi John, >> >> On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: >> > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 10:24 AM, Ville Syrjälä wrote: > On Wed, Aug 22, 2018 at 09:14:08PM -0700, John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> > Hey Noralf, all, >> > I've been digging for a bit on the regression that this patch ha

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 12:46 AM, Laurent Pinchart wrote: > Hi John, > > On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> > Hey Noralf, all, >> > >> > I've been digging for a

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: > On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >>> Hey Noralf, all, >>> I've been digging for a bit on the regression that this patch has >

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-22 Thread John Stultz
On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > Hey Noralf, all, > I've been digging for a bit on the regression that this patch has > tripped on the HiKey board as reported here: > https://lkml.org/lkml/2018/8/16/81 > > The first issue was that the kirin

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread John Stultz
On Tue, Aug 21, 2018 at 7:59 AM, Noralf Trønnes wrote: > Den 21.08.2018 10.44, skrev Daniel Vetter: >> On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: >>> >>> Since we don't have a drm_gem_cma_object reference in >>> drm_fb_helper_generic_p

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread John Stultz
On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: > This switches the CMA helper drivers that use its fbdev emulation over > to the generic fbdev emulation. It's the first phase of using generic > fbdev. A later phase will use DRM client callbacks for the > lastclose/hotplug/remove callbacks.

Re: [Intel-gfx] [PATCH 00/13] fbdev locking rework and deferred setup, take 2

2017-06-27 Thread John Stultz
On Tue, Jun 27, 2017 at 7:59 AM, Daniel Vetter wrote: > > Thanks to Liviu's help I realized that I fumbled the locking rework > completely. > This one here should be better, but somehow I'm having a real bad day today > and > I spent all day typing shit code, and then

Re: [Intel-gfx] [PATCH 00/12] fbdev helper locking rework and deferred setup

2017-06-21 Thread John Stultz
and the entire exynos patch), it seems to work ok. I rebooted 10 times and didn't see the initialization race where multiple fbs were created that I could regularly trigger before. Tested-by: John Stultz <john.stu...@linaro.org> thanks -john ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread John Stultz
On Thu, Dec 4, 2014 at 2:42 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Dec 03, 2014 at 11:07:08AM -0800, John Stultz wrote: On Wed, Dec 3, 2014 at 6:30 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Dec 02, 2014 at 08:54:13AM -0800, John Stultz wrote: On Tue, Dec 2, 2014 at 8:35 AM

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread John Stultz
interfaces Use ktime_get_raw_ns() and get rid of the back and forth timespec conversions. Signed-off-by: Thomas Gleixner t...@linutronix.de Acked-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: John Stultz john.stu...@linaro.org So fix this up by reinstating our

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread John Stultz
On Thu, Dec 4, 2014 at 9:50 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Thu, Dec 4, 2014 at 6:42 PM, John Stultz john.stu...@linaro.org wrote: Sigh. So you're going to make me write a separate patch that moves it over? We've written it already, Imre posted the link to the old discussion

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-04 Thread John Stultz
On Thu, Dec 4, 2014 at 10:51 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Thu, Dec 4, 2014 at 7:16 PM, John Stultz john.stu...@linaro.org wrote: On Thu, Dec 4, 2014 at 9:50 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Thu, Dec 4, 2014 at 6:42 PM, John Stultz john.stu...@linaro.org

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-03 Thread John Stultz
On Tue, Dec 2, 2014 at 8:35 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Dec 02, 2014 at 04:36:22PM +0100, Daniel Vetter wrote: +static inline unsigned long nsecs_to_jiffies_timeout(const u64 m) +{ + u64 usecs = div_u64(m + 999, 1000); + unsigned long j =

Re: [Intel-gfx] [PATCH] drm/i915: compute wait_ioctl timeout correctly

2014-12-03 Thread John Stultz
On Wed, Dec 3, 2014 at 6:30 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Dec 02, 2014 at 08:54:13AM -0800, John Stultz wrote: On Tue, Dec 2, 2014 at 8:35 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Dec 02, 2014 at 04:36:22PM +0100, Daniel Vetter wrote: +static inline