On 2024-07-11 08:18:18, Rodrigo Vivi wrote:
> Hi Dave and Sima,
>
> This is a v2 of https://lore.kernel.org/intel-xe/zo2so4t32dxqy...@intel.com/
>
> v2 - Removed Thomas' write-back caching mode patch since Lucas will propagete
> that through drm-xe-fixes towards 6.10. So we remove the amount of p
mesa/mesa/-/merge_requests/22878
> >
> > Signed-off-by: Fei Yang
> > Cc: Chris Wilson
> > Cc: Matt Roper
> > Cc: Andi Shyti
> > Reviewed-by: Andi Shyti
> > Acked-by: Jordan Justen
> > Tested-by: Jordan Justen
>
> last call for comments and revi
ed at
> https://patchwork.freedesktop.org/series/117695/
>
> Tested with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22878
>
> Signed-off-by: Fei Yang
> Cc: Chris Wilson
> Cc: Matt Roper
> Cc: Andi Shyti
> Reviewed-by: Andi Shyti
> Acked-by: Jordan Justen
ck these patches.
The good news was that I found that OpenGL testing with our iris
driver appeared to have ok results when using this interface.
But, our Vulkan Anvil driver was not stable with the current patches
in the Mesa MR. We will need to debug this further before using the
interface on Vul
can use this UAPI and we can discuss
> that on the MESA patch.
>
>
> hmmm.. so... ack anyone? [insert big hopeful smiley here]
> apologies if I am asking too often.
Assuming that:
2 = PXP feature is supported but should be ready soon (pending
initialization of non-i915 sy
...fixing some Cc email addresses I somehow mangled.
On 2023-05-10 12:40:07, Souza, Jose wrote:
> On Mon, 2023-05-08 at 17:49 +, Teres Alexis, Alan Previn wrote:
> > On Fri, 2023-05-05 at 00:39 -0700, Justen, Jordan L wrote:
> > > On 2023-05-04 22:30:07, Teres Alexis, Alan Previn wrote:
> > >
On 2023-05-10 12:40:07, Souza, Jose wrote:
> On Mon, 2023-05-08 at 17:49 +, Teres Alexis, Alan Previn wrote:
> > On Fri, 2023-05-05 at 00:39 -0700, Justen, Jordan L wrote:
> > > On 2023-05-04 22:30:07, Teres Alexis, Alan Previn wrote:
> > > > On Thu, 2023-04-27 at 16:48 -0700, Teres Alexis, Ala
On 2023-05-04 22:30:07, Teres Alexis, Alan Previn wrote:
> On Thu, 2023-04-27 at 16:48 -0700, Teres Alexis, Alan Previn wrote:
> > Because of the additional firmware, component-driver and
> > initialization depedencies required on MTL platform before a
> > PXP context can be created, UMD calling fo
On 2023-05-02 22:41:09, Joonas Lahtinen wrote:
> Hi Jordan,
>
> This approach was specifically NACKed in the PAT index thread so please
> at least mark any such series as RFC if they are intended to facilitate
> further dialog on the topic.
There was a preference expressed to not do anything from
Cc: Fei Yang
Cc: Tvrtko Ursulin
Cc: Joonas Lahtinen
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
---
drivers/gpu/drm/i915/gem/i915_gem_create.c | 30 ++
drivers/gpu/drm/i915/gem/i915_gem_create.h | 2 ++
drivers/gpu/drm/i915/i915_query.c | 36
On 2023-04-26 11:17:16, Teres Alexis, Alan Previn wrote:
> alan: Hi Jordan, Tvrtko, Daniel Vetter and Lionel,...
> how to proceed on this series (which have required Rb/Ack's) in light of
> the recent discussion on the other series here:
> https://patchwork.freedesktop.org/patch/532994/?series=115
On 2023-04-26 04:52:43, Daniel Vetter wrote:
>
> Joonas asked me to put my thoughts here:
>
> - in general the "feature discovery by trying it out" approach is most
> robust and hence preferred, but it's also not something that's required
> when there's good reasons against it
More robust in
On 2023-04-25 06:41:54, Joonas Lahtinen wrote:
> (+ Faith and Daniel as they have been involved in previous discussions)
>
> Quoting Jordan Justen (2023-04-24 20:13:00)
> > On 2023-04-24 02:08:43, Tvrtko Ursulin wrote:
> > >
> > > Being able to "li
On 2023-04-16 23:43:20, Yang, Fei wrote:
> > fei.y...@intel.com kirjoitti 17.4.2023 klo 9.24:
> >> From: Fei Yang
> >>
> >> The series includes patches needed to enable MTL.
> >> Also add new extension for GEM_CREATE uAPI to let user space set cache
> >> policy for buffer objects.
> >
> > if I'm
On 2023-04-24 02:08:43, Tvrtko Ursulin wrote:
>
> Being able to "list" supported extensions sounds like a reasonable
> principle, albeit a departure from the design direction to date.
> Which means there are probably no quick solutions. Also, AFAIU, only
> PXP context create is the problematic one
On 2023-04-20 09:11:18, Yang, Fei wrote:
> > On 20/04/2023 12:39, Andi Shyti wrote:
> >> Hi Fei,
> >>
> >>> To comply with the design that buffer objects shall have immutable
> >>> cache setting through out their life cycle, {set, get}_caching ioctl's
> >>> are no longer supported from MTL onward.
On 2023-04-05 13:26:43, Jordan Justen wrote:
> On 2023-04-05 00:45:24, Lionel Landwerlin wrote:
> > On 04/04/2023 19:04, Yang, Fei wrote:
> > >> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache
> > >> at BO creation
> > >>
>
On 2023-04-05 00:45:24, Lionel Landwerlin wrote:
> On 04/04/2023 19:04, Yang, Fei wrote:
> >> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at
> >> BO creation
> >>
> >> Just like the protected content uAPI, there is no way for userspace to tell
> >> this feature is availa
On 2022-10-14 03:58:12, Matthew Auld wrote:
> On 14/10/2022 08:20, Jordan Justen wrote:
> > Acked-by: Jordan Justen
>
> Thanks. Can I take that as ack for merging the series from Mesa POV? I
> think Lionel was going to test this, but I think keeps getting swamped
> with ot
Acked-by: Jordan Justen
On 2022-10-04 04:49:15, Matthew Auld wrote:
> On some platforms we potentially have different alignment restrictions
> depending on the memory type. We also now have different alignment
> restrictions for the same region across different kernel versions.
>
On 2022-07-14 16:08:51, Dave Airlie wrote:
> On Fri, 15 Apr 2022 at 10:15, Matt Roper wrote:
> >
> > On Tue, Apr 12, 2022 at 03:59:55PM -0700, john.c.harri...@intel.com wrote:
> > > From: John Harrison
> > >
> > > The latest GuC firmware drops the context descriptor pool in favour of
> > > passin
On 2022-06-24 14:38:50, Chery, Nanley G wrote:
> +Jordan (FYI)
>
> I think the commit message has an extra "color" next to "CC".
> With or without that dropped,
>
> Reviewed-by: Nanley Chery
Reviewed-by: Jordan Justen
Include newer integrated platforms when applying the non-recoverable
> > context and error capture restriction. (Thomas)
> >
> > Signed-off-by: Matthew Auld
> > Cc: Thomas Hellström
> > Cc: Lionel Landwerlin
> > Cc: Tvrtko Ursulin
> > Cc: Jon Bloo
On 2022-05-16 00:47:43, Lionel Landwerlin wrote:
> On 14/05/2022 00:06, Jordan Justen wrote:
>>
>> Acked-by: Jordan Justen
>>
>> I think Nanley has accounted for this on iris with:
>>
>>
>> https://gitlab.freedesktop.org/mesa/mesa/-/co
cc: Lionel Landwerlin
> > cc: Kenneth Graunke
> > cc: mesa-...@lists.freedesktop.org
> > cc: Jordan Justen
> > cc: Tony Ye
> > Reviewed-by: Matthew Auld
> > ---
> > include/uapi/drm/i915_drm.h | 16
> > 1 file changed, 16 inser
.
Series:
Reviewed-by: Jordan Justen
Tested-by: Jordan Justen
-Jordan
On 2022-04-27 21:19:22, Matt Roper wrote:
> Now that the necessary GuC-based hardware workarounds have landed, we're
> finally ready to actually enable compute engines for use by userspace.
> All of the "un
From: Rodrigo Vivi
v2:
* Jordan: Drop stepping/skew checking as suggested by John.
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Signed-off-by: Ramalingam C
Tested-by: Jordan Justen
Signed-off-by: Jordan Justen
---
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 ++
1 file
From: Rodrigo Vivi
DG2 support for hwconfig tables varies by both SKU and stepping.
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Signed-off-by: Ramalingam C
Tested-by: Jordan Justen
---
drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 ++
1 file changed, 2 insertions
: Kenneth Graunke
Cc: Michal Wajdeczko
Cc: Slawomir Milczarek
Cc: Joonas Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
Acked-by: Jon Bloomfield
---
drivers/gpu/drm/i915/i915_query.c | 23
ohn Harrison
Reviewed-by: Matthew Brost
Acked-by: Jon Bloomfield
Signed-off-by: Jordan Justen
Reviewed-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/gt/intel_gt.c| 6 +
drivers/gpu/drm/i915/gt/intel_gt_types.h | 4 +
Now with 100% less documentation. (See v7 notes.)
This is John/Rodrigo's 2 patches with some changes. There are various
changes suggested by Michal in John's "fetch" patch. The table
terminology was also changed to "blob" as requested by Joonas.
Dropped these 2 patches (which were in v1-v6):
* "
hal
* Merge in John's v2 patch, but note:
- Using drm_notice as recommended by Michal
- Reverted Michal's suggestion of using devinfo
Cc: Michal Wajdeczko
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jon Bloomfield
Signed-off-by:
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
v3:
* Add various changes suggested by Tvrtko
v5:
* Fix documenation formatting and verified with `make htmldocs` as
suggested by Daniel
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
Acked-by: Jon Bloomfield
Acked-by: Daniel
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
Acked-by: Jon Bloomfield
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed
based on John's updated "drm/i915/guc: Add fetch of hwconfig
table" v2 which stores the hwconfig blob at the GT level.
Signed-off-by: Jordan Justen
Acked-by: Jon Bloomfield
Reviewed-by: Tvrtko Ursulin
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 43 ++-
o added a few changes requested by Michal on the v5 posting.
* Tvrtko requested an example of UMD using the i915 hwconfig
interface. Mesa support for this interface can be seen in this MR:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14511
John Harrison (1):
drm/i915/guc: Add fet
John Harrison writes:
> On 2/22/2022 02:36, Jordan Justen wrote:
>> From: John Harrison
>>
>> Implement support for fetching the hardware description table from the
>> GuC. The call is made twice - once without a destination buffer to
>> query the size and
: Jordan Justen
Acked-by: Jon Bloomfield
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 44 ++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
index ad289603460c
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
v3:
* Add various changes suggested by Tvrtko
v5:
* Fix documenation formatting and verified with `make htmldocs` as
suggested by Daniel
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
Acked-by: Jon Bloomfield
Acked-by: Daniel
ichal Wajdeczko
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jon Bloomfield
Signed-off-by: Jordan Justen
---
drivers/gpu/drm/i915/Makefile | 1 +
.../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 1 +
.../gpu/drm/i915/gt/uc/abi/g
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
Acked-by: Jon Bloomfield
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed
in this version.
v5:
* Add many changes suggested by Michal in John's "drm/i915/guc: Add
fetch of hwconfig table" patch.
* Fix documenation formatting as suggested by Daniel in
"drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item"
Ramalingam C writes:
> On 2022-02-18 at 18:06:00 +, Robert Beckett wrote:
>>
>> If desired, we can make the wording clearer, maybe something like:
>>
>> "To keep things simple for userland, we mandate that any GTT mappings
>> must be aligned to 2MB. The kernel will internally pad them out t
3: fix typos and less emphasis
> v2: Fixed suggestions on formatting [Daniel]
>
> Signed-off-by: Matthew Auld
> Signed-off-by: Ramalingam C
> Signed-off-by: Robert Beckett
> Acked-by: Jordan Justen
> Reviewed-by: Ramalingam C
> Reviewed-by: Thomas Hellström
> cc: Simon Ser
From: John Harrison
Implement support for fetching the hardware description table from the
GuC. The call is made twice - once without a destination buffer to
query the size and then a second time to fill in the buffer.
Note that the table is only available on ADL-P and later platforms.
Cc: Mich
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
v3:
* Add various changes suggested by Tvrtko
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
Acked-by: Jon Bloomfield
---
include/uapi/drm/i915_drm.h | 35 +++
1 file changed, 35 insertions
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
Acked-by: Jon Bloomfield
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed
: Jordan Justen
Acked-by: Jon Bloomfield
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 44 ++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
index ce6088f112d4
Rewrite verify_hwconfig_blob() to hopefully be clearer without
relying on comments so much, and add various suggestions from
Michal.
* Michal also had some suggestions in John's "drm/i915/guc: Add fetch
of hwconfig table" patch. I held off on making any of these changes
Tvrtko Ursulin writes:
> Will GuC folks be reviewing this work?
I don't know. If you mean the i915 devs interfacing with the GuC, I know
John/Rodrigo seemed a bit resistant writing the patches to give
userspace this trivial format guarantee on the blob.
So, I hoped they would write the patches
contents,
so this verification step should not add a significant amount of init
time to i915.
v3:
* Add various changes suggested by Tvrtko
Signed-off-by: Jordan Justen
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 56 ++-
1 file changed, 53 insertions(+), 3 deletions
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
v3:
* Add various changes suggested by Tvrtko
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
---
include/uapi/drm/i915_drm.h | 32
1 file changed, 32 insertions(+)
diff --git a/include/uapi/drm
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed, 24 insertions(+)
diff
From: John Harrison
Implement support for fetching the hardware description table from the
GuC. The call is made twice - once without a destination buffer to
query the size and then a second time to fill in the buffer.
Note that the table is only available on ADL-P and later platforms.
Cc: Mich
om the feedback for
the same patch.
John Harrison (1):
drm/i915/guc: Add fetch of hwconfig table
Jordan Justen (2):
drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item
drm/i915/guc: Verify hwconfig blob matches supported format
Rodrigo Vivi (1):
drm/i915/uapi: Add query for hwcon
contents,
so this verification step should not add a significant amount of init
time to i915.
Signed-off-by: Jordan Justen
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 29 +++
1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
b
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
---
include/uapi/drm/i915_drm.h | 30 ++
1 file changed, 30 insertions(+)
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed, 24 insertions(+)
diff
From: John Harrison
Implement support for fetching the hardware description table from the
GuC. The call is made twice - once without a destination buffer to
query the size and then a second time to fill in the buffer.
Note that the table is only available on ADL-P and later platforms.
Cc: Mich
h as requested by
Tvrtko.
* Reword text added to i915_drm.h as requested by Tvrtko. (Attempting
to indicate the overall blob ends right at the last blob item.)
John Harrison (1):
drm/i915/guc: Add fetch of hwconfig table
Jordan Justen (2):
drm/i915/uapi: Add struct drm_i915_query_
Signed-off-by: Jordan Justen
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 26 +++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
index ce6088f112d4..695ef7a8f519 100644
--- a
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
---
include/uapi/drm/i915_drm.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed, 24 insertions(+)
diff
From: John Harrison
Implement support for fetching the hardware description table from the
GuC. The call is made twice - once without a destination buffer to
query the size and then a second time to fill in the buffer.
Note that the table is only available on ADL-P and later platforms.
Cc: Mich
what the uAPI
documents.
John Harrison (1):
drm/i915/guc: Add fetch of hwconfig table
Jordan Justen (2):
drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item
drm/i915/guc: Verify hwconfig blob matches supported format
Rodrigo Vivi (1):
drm/i915/uapi: Add query for hwconfig blob
d
Jordan Justen writes:
> John, Rodrigo,
>
> It is now clear to me just how dependent i915 is going to be on the
> closed source guc software, and that's just a fact of life for our
> graphics stack going forward.
>
> In that context, it seems kind of pointless for me t
John, Rodrigo,
It is now clear to me just how dependent i915 is going to be on the
closed source guc software, and that's just a fact of life for our
graphics stack going forward.
In that context, it seems kind of pointless for me to make a big deal
out of this peripheral "query item" commit mess
John Harrison writes:
> On 1/27/2022 16:48, Jordan Justen wrote:
>> john.c.harri...@intel.com writes:
>>
>>> From: Rodrigo Vivi
>>>
>>> GuC contains a consolidated table with a bunch of information about the
>>> current device.
>>>
john.c.harri...@intel.com writes:
> From: Rodrigo Vivi
>
> GuC contains a consolidated table with a bunch of information about the
> current device.
>
> Previously, this information was spread and hardcoded to all the components
> including GuC, i915 and various UMDs. The goal here is to consolid
Fixed suggestions on formatting [Daniel]
>
> Signed-off-by: Matthew Auld
> Signed-off-by: Ramalingam C
> Signed-off-by: Robert Beckett
> cc: Simon Ser
> cc: Pekka Paalanen
> Cc: Jordan Justen
> Cc: Kenneth Graunke
> Cc: mesa-...@lists.freedesktop.org
> Cc: Tony Ye
John Harrison writes:
> On 11/3/2021 14:38, Jordan Justen wrote:
>> So, i915 wants to wash it's hands completely of the format? There is
>> obviously a difference between hardware features and a blob coming from
>> closed source software. (Which i915 just happens to
John Harrison writes:
> On 11/1/2021 08:39, Jordan Justen wrote:
>> writes:
>>
>>> From: Rodrigo Vivi
>>>
>>> GuC contains a consolidated table with a bunch of information about the
>>> current device.
>>>
>>> Previo
writes:
> From: Rodrigo Vivi
>
> GuC contains a consolidated table with a bunch of information about the
> current device.
>
> Previously, this information was spread and hardcoded to all the components
> including GuC, i915 and various UMDs. The goal here is to consolidate
> the data into GuC i
On 2019-09-17 05:11:55, Radhakrishna Sripada wrote:
> return PLANE_CTL_TILED_Y |
> PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
> case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
> return PLANE_CTL_TILED_Y |
> PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE;
> @@ -9897,9 +9924,13
On 2019-03-31 03:02:21, Chris Wilson wrote:
> Quoting Jordan Justen (2019-03-31 10:57:09)
> > On 2019-03-25 03:58:59, Chris Wilson wrote:
> > > iris currently uses two distinct GEM contexts to have distinct logical
> > > HW contexts for the compute and render pi
On 2019-03-25 03:58:59, Chris Wilson wrote:
> iris currently uses two distinct GEM contexts to have distinct logical
> HW contexts for the compute and render pipelines. However, using two
> distinct GEM contexts implies that they are distinct timelines, yet as
> they are a single GL context that im
Where are these changes from (repo/commit)? It could be good to
reference in the commit message.
I suspect that the answer might mean that these patches should be
labeled RFC.
-Jordan
On 2019-03-25 03:58:58, Chris Wilson wrote:
> For use in GPU recovery and pipeline construction.
> ---
> includ
On 2019-03-31 00:32:52, Chris Wilson wrote:
> Quoting Jordan Justen (2019-03-31 04:03:44)
> > I think the change is focused mainly around setting the vm param, so
> > perhaps the subject should mention that. Maybe something like:
>
> It's not just about that, it's
any issues can be caught by making sure to add tests
for setting the new context params at context creation time.
Reviewed-by: Jordan Justen
and, I verified it fixes the segfault when setting vm at context
create time, so:
Tested-by: Jordan Justen
On 2019-03-30 03:03:49, Chris Wilson wrote:
>
On 2019-03-22 02:23:23, Chris Wilson wrote:
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
> b/drivers/gpu/drm/i915/i915_gem_context.c
> index 00dec72f6875..d0a56c8d0bb9 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> +
> +static
Series:
Tested-by: Jordan Justen
Reviewed-by: Jordan Justen
On 2017-12-06 15:11:20, Scott D Phillips wrote:
> No functionality related to aub is provided by libdrm aside from
> intel_aub.h which somewhat defines the file format. Move the
> header into this project to ease au
Despite trying, I wasn't able to confirm these values. Nevertheless, I
was able to test your series, so:
Tested-by: Jordan Justen
On 2017-12-06 15:11:22, Scott D Phillips wrote:
> The memtrace aub commands are similar to the existing ones, but
> different. Notably memtrace has c
Reviewed-by: Jordan Justen
On 2017-12-06 15:11:20, Scott D Phillips wrote:
> No functionality related to aub is provided by libdrm aside from
> intel_aub.h which somewhat defines the file format. Move the
> header into this project to ease aub-related development.
>
> Signed-
elsp_reg, descriptor & 0x);
> +
> + dword_out(CMD_MEM_TRACE_REGISTER_POLL | (5 + 1 - 1));
> + dword_out(status_reg);
> + dword_out(AUB_MEM_TRACE_REGISTER_SIZE_DWORD |
> + AUB_MEM_TRACE_REGISTER_SPACE_MMIO);
> + dword_out(0x0010);
On 2017-10-19 16:30:44, Kristian Høgsberg wrote:
> On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke
> wrote:
> > The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2
> > registers at context initialization time. Instead, they're inherited
> > from whatever happened to be runni
v2:
* Use 48-bit rather than 64-bit (Ken)
* Use 'addr_bits' rather than 'use_64bit'
Cc: Kenneth Graunke
Signed-off-by: Jordan Justen
---
tools/aubdump.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/tools/aubdump.c b/t
This just lets you specify an override like --device=bdw for
broadwell.
Signed-off-by: Jordan Justen
---
Resend with 'i-g-t' in subject line.
tools/aubdump.c| 36
tools/intel_aubdump.in | 4 +++-
2 files changed, 35 insertions(+), 5
Reviewed-by: Jordan Justen
On 2017-09-15 06:59:54, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Tell meson about the dependency on version.h. Avoids the compiler
> falling over on account of IGT_GIT_SHA1 not being there.
>
> Signed-off-by: Ville Syrjälä
> ---
&
Reviewed-by: Jordan Justen
On 2017-09-15 06:35:52, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Install the assembler and disassemebler binaries, and the accompanying
> pkg-config file. Change libbrw into a static library since we don't want
> to install that.
>
Signed-off-by: Jordan Justen
---
tools/aubdump.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/tools/aubdump.c b/tools/aubdump.c
index 788bed13..893ddf93 100644
--- a/tools/aubdump.c
+++ b/tools/aubdump.c
@@ -58,6 +58,7 @@ static int gen = 0
This just lets you specify an override like --device=bdw for
broadwell.
Signed-off-by: Jordan Justen
---
tools/aubdump.c| 36
tools/intel_aubdump.in | 4 +++-
2 files changed, 35 insertions(+), 5 deletions(-)
diff --git a/tools/aubdump.c b/tools
On 2017-09-14 12:13:08, Ville Syrjälä wrote:
> On Wed, Sep 13, 2017 at 06:10:56PM -0700, Jordan Justen wrote:
> > Signed-off-by: Jordan Justen
> > ---
> > lib/meson.build | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/meson.bui
ies : test_deps,
> + install_dir : libexecdir,
> + install : true)
I noticed indentation alignment issues, like this one, in many of the
patches. (Often when adding 'install : true')
Can you review and fix the alignment on all patches?
Series Reviewed-by: Jordan Jus
On 2017-09-14 04:46:00, Petri Latvala wrote:
> On Wed, Sep 13, 2017 at 06:10:55PM -0700, Jordan Justen wrote:
> > The meson shared_library function appears to hard code prefixing the
> > library name with 'lib'.
> >
> > Signed-off-by: Jordan Justen
&g
On 2017-09-13 18:11:00, Jordan Justen wrote:
> In some cases it is preferable to not send exec commands to the
> kernel, but to otherwise record the exec command into the AUB file.
>
> For example, when using the --device override option, it might be best
> to avoid passing
Signed-off-by: Jordan Justen
---
lib/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/meson.build b/lib/meson.build
index b78e42dc..0d379d90 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -170,6 +170,7 @@ lib_igt_build = shared_library('igt',
Signed-off-by: Jordan Justen
---
tools/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/meson.build b/tools/meson.build
index d2d4410e..91c58760 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -54,6 +54,7 @@ foreach prog : tools_progs
Signed-off-by: Jordan Justen
---
tools/meson.build | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tools/meson.build b/tools/meson.build
index 91c58760..20b63cce 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -57,4 +57,11 @@ endforeach
shared_library('intel_au
Meson detects if an input file is executable, and copies that to the
output file.
Signed-off-by: Jordan Justen
---
tools/intel_aubdump.in | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tools/intel_aubdump.in
diff --git a/tools/intel_aubdump.in b/to
In some cases it is preferable to not send exec commands to the
kernel, but to otherwise record the exec command into the AUB file.
For example, when using the --device override option, it might be best
to avoid passing the EXEC ioctls through to the kernel.
Signed-off-by: Jordan Justen
1 - 100 of 115 matches
Mail list logo
