RE: [PATCH 13/14] drm/i915/dp_mst: Ensure link parameters are up-to-date for a disabled link

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 13/14] drm/i915/dp_mst: Ensure link parameters are up-to- > date for a disabled link > > As explained in the previous patch,

RE: [PATCH 0/2] Fix null pointer error in HDCP capability check

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Monday, July 22, 2024 12:15 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Kandpal, Suraj > > Subject: [PATCH 0/2] Fix null pointer error in HDCP capabil

RE: [PATCH] drm/i915/display: Workaround for odd panning for planar yuv

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, July 24, 2024 10:32 PM > To: Nemesa Garg ; intel...@lists.freedesktop.org > Cc: Heikkila, Juha-pekka ; Shankar, Uma > ; Garg, Nemesa > Subject: RE: [PATCH] drm/i915/display: Workaround for odd pan

RE: [PATCH 09/14] drm/i915/dp_mst: Reduce the link parameters in BW order after LT failures

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Deak, Imre > Sent: Wednesday, July 24, 2024 4:57 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 09/14] drm/i915/dp_mst: Reduce the link parameters in > BW order after LT failures > > On Wed,

RE: [PATCH 14/14] drm/i915/dp_mst: Enable LT fallback between UHBR/non-UHBR link rates

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Deak, Imre > Sent: Wednesday, July 24, 2024 5:03 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 14/14] drm/i915/dp_mst: Enable LT fallback between > UHBR/non-UHBR link rates > > On Wed, Jul 2

RE: [PATCH 14/14] drm/i915/dp_mst: Enable LT fallback between UHBR/non-UHBR link rates

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 14/14] drm/i915/dp_mst: Enable LT fallback between > UHBR/non-UHBR link rates > > Enable switching between UHBR and non-UHBR

RE: [PATCH 12/14] drm/i915/dp_mst: Reprobe the MST topology after a link parameter change

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 12/14] drm/i915/dp_mst: Reprobe the MST topology after a > link parameter change > > The MST link BW reported by branch

RE: [PATCH 11/14] drm/i915/dp_mst: Queue modeset-retry after a failed payload BW allocation

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 11/14] drm/i915/dp_mst: Queue modeset-retry after a > failed payload BW allocation > > If the MST payload allocation failed,

RE: [PATCH 10/14] drm/i915/dp_mst: Configure MST after the link parameters are reset

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 10/14] drm/i915/dp_mst: Configure MST after the link > parameters are reset > > The MST topology probing depends on the

RE: [PATCH 09/14] drm/i915/dp_mst: Reduce the link parameters in BW order after LT failures

2024-07-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 09/14] drm/i915/dp_mst: Reduce the link parameters in BW > order after LT failures > > On MST links - at least for some MST

RE: [PATCH 05/14] drm/i915/dp: Initialize the link parameters during HW readout

2024-07-23 Thread Kandpal, Suraj
> -Original Message- > From: Deak, Imre > Sent: Tuesday, July 23, 2024 5:30 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 05/14] drm/i915/dp: Initialize the link parameters during > HW readout > > On Tue, Jul 23, 2024 a

RE: [PATCH 04/14] drm/i915/ddi: For an active output call the DP encoder sync_state() only for DP

2024-07-23 Thread Kandpal, Suraj
> -Original Message- > From: Deak, Imre > Sent: Tuesday, July 23, 2024 5:26 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 04/14] drm/i915/ddi: For an active output call the DP > encoder sync_state() only for DP > > On

RE: [PATCH 08/14] drm/i915/dp: Add helpers to set link training mode, BW parameters

2024-07-23 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 08/14] drm/i915/dp: Add helpers to set link training mode, BW > parameters > > Add helpers to set the link mode and BW

RE: [PATCH 07/14] drm/i915/dp: Add a separate function to reduce the link parameters

2024-07-23 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 07/14] drm/i915/dp: Add a separate function to reduce the link > parameters > > A follow-up patch will add an alternative way

RE: [PATCH 05/14] drm/i915/dp: Initialize the link parameters during HW readout

2024-07-23 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 05/14] drm/i915/dp: Initialize the link parameters during > HW readout > > Initialize the DP link parameters during HW

RE: [PATCH 04/14] drm/i915/ddi: For an active output call the DP encoder sync_state() only for DP

2024-07-23 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Monday, July 22, 2024 10:25 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 04/14] drm/i915/ddi: For an active output call the DP > encoder sync_state() only for DP > > If the DDI encoder output is

RE: [PATCH] drm/i915/dpkgc: Add VRR condition for DPKGC Enablement

2024-07-22 Thread Kandpal, Suraj
> -Original Message- > From: Golani, Mitulkumar Ajitkumar > > Sent: Thursday, July 18, 2024 9:35 PM > To: Kandpal, Suraj ; intel- > g...@lists.freedesktop.org > Cc: Manna, Animesh ; B, Jeevan > ; Naladala, Ramanaidu > > Subject: RE: [PATCH] drm/i915/dpkg

RE: [PATCH 2/3] drm/i915/dp: Require a valid atomic state for SST link training

2024-07-17 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Friday, July 12, 2024 7:27 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 2/3] drm/i915/dp: Require a valid atomic state for SST link > training > > After the previous patch link training happens

RE: [PATCH 1/3] drm/i915/dp: Retrain SST links via a modeset commit

2024-07-17 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Friday, July 12, 2024 7:27 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Ville Syrjälä > > Subject: [PATCH 1/3] drm/i915/dp: Retrain SST links via a modeset commit > > Instead of direct calls

RE: [PATCH v5] drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc clock

2024-07-09 Thread Kandpal, Suraj
> -Original Message- > From: Golani, Mitulkumar Ajitkumar > > Sent: Monday, July 8, 2024 2:03 PM > Cc: intel-gfx@lists.freedesktop.org; Kandpal, Suraj > ; Garg, Nemesa ; > Nikula, Jani > Subject: [PATCH v5] drm/i915/display: WA for Re-initialize di

RE: [PATCH v3] drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc clock

2024-07-07 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Mitul > Golani > Sent: Wednesday, June 19, 2024 4:08 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v3] drm/i915/display: WA for Re-initialize dispcnlunitt1 xosc > clock > > The dispcnlunit1_cp_xosc_clk should be de-asserted

RE: [PATCH] drm/i915/display: Consider adjusted_pixel_rate to be u64

2024-06-24 Thread Kandpal, Suraj
> -Original Message- > From: Golani, Mitulkumar Ajitkumar > > Sent: Friday, June 21, 2024 1:05 PM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Vivi, Rodrigo ; > jani.nik...@linux.intel.com; Kandpal, Suraj ; > Nautiyal, Ank

RE: drm/i915/display: Update vtotal math to address 32b build

2024-06-12 Thread Kandpal, Suraj
Thanks for patches and reviews Pushed to drm-intel-next Regards, Suraj Kandpal > -Original Message- > From: Intel-gfx-trybot On > Behalf Of Mitul Golani > Sent: Wednesday, June 12, 2024 2:07 PM > To: intel-gfx-try...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject:

RE: [PATCH v15 0/9] Implement CMRR Support

2024-06-10 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Mitul > Golani > Sent: Monday, June 10, 2024 8:18 AM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K > Subject: [PATCH v15 0/9] Implement CMRR Support > > CMRR is a display feature that uses adaptive sync framework to

RE: [PATCH 2/2] drm/i915/psr: Implment WA to help reach PC10

2024-06-09 Thread Kandpal, Suraj
> Subject: Re: [PATCH 2/2] drm/i915/psr: Implment WA to help reach PC10 > > On Thu, 06 Jun 2024, Suraj Kandpal wrote: > > To reach PC10 when PKG_C_LATENCY is configure we must do the following > > things > > 1) Enter PSR1 only when delayed_vblank < 6 lines and DC5 can be > > entered > > 2) Allow

RE: [PATCH 0/2] drm/i915: prevent some static analyzer warnings

2024-05-30 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Luca > Coelho > Sent: Tuesday, May 28, 2024 4:59 PM > To: intel-gfx@lists.freedesktop.org > Cc: Syrjala, Ville > Subject: [PATCH 0/2] drm/i915: prevent some static analyzer warnings > > Hi, > > Here's a couple of patches to prevent

RE: [PATCH] drm/i915/hdcp: Fix IS_METEORLAKE usage for HDCP line rekeying

2024-05-29 Thread Kandpal, Suraj
, Chaitanya Kumar > > Subject: Re: [PATCH] drm/i915/hdcp: Fix IS_METEORLAKE usage for HDCP line > rekeying > > I'm not terribly familiar with HDCP, but from reading the spec my > understanding is that in general we need to enable rekeying for HDCP 1.4 and > disable it for higher HDCP versions,

RE: [PATCH 0/2] Fixes in hdcp remote capability

2024-05-22 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Tuesday, May 21, 2024 1:45 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh ; Kandpal, Suraj > > Subject: [PATCH 0/2] Fixes in hdcp remote capability > > This patch series aims to avoid page

RE: [PATCH 2/2] drm/i915/hdcp: Check mst_port to determine connector type

2024-05-19 Thread Kandpal, Suraj
> -Original Message- > From: Deak, Imre > Sent: Friday, May 17, 2024 6:19 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K > Subject: Re: [PATCH 2/2] drm/i915/hdcp: Check mst_port

RE: [PATCH 1/2] drm/i915/hdcp: Move aux assignment after connector type check

2024-05-02 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Thursday, May 2, 2024 4:14 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj > Subject: Re: [PATCH 1/2] drm/i915/hdcp: Move aux assignment after &

RE: [PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-04-30 Thread Kandpal, Suraj
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Tuesday, April 30, 2024 12:05 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 > on HDMI > > Hi Suraj, >

RE: [RFC 0/3] Enable darkscreen detection

2024-04-24 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Wednesday, April 24, 2024 3:19 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Murthy, Arun R ; Kandpal, Suraj > > Subject: Re: [RFC 0/3] Enable darkscreen detection > > On Wed, 24 Apr

RE: [5/6] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-23 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Wednesday, April 24, 2024 2:51 AM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Kumar, Naveen1 > >

RE: [PATCH 2/6] drm/i915/dp: Add TCON HDR capability checks

2024-04-22 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Tuesday, April 23, 2024 10:14 AM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Shankar, > Uma ; Nautiyal, Ankit K > ; Kumar, Naveen1 ; > sebastian.w...@redhat.com > S

RE: [PATCH 2/6] drm/i915/dp: Add TCON HDR capability checks

2024-04-22 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Tuesday, April 23, 2024 8:25 AM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Shankar, > Uma ; Nautiyal, Ankit K > ; Kumar, Naveen1 ; > sebastian.w...@redhat.com > S

RE: [5/6] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-17 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Wednesday, April 17, 2024 3:54 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Nikula, Jani > ; Kumar, N

RE: [PATCH 1/2] drm/i915: Add SCLKGATE_DIS register definition

2024-04-16 Thread Kandpal, Suraj
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, April 16, 2024 6:25 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Bhadane, Dnyaneshwar > Subject: Re: [PATCH 1/2]

RE: [5/6] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-16 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Tuesday, April 16, 2024 7:10 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Nikula, Jani > ; Kumar, Naveen

RE: [PATCH] drm/i915/hdcp: Disable HDCP Line Rekeying for HDCP2.2 on HDMI

2024-04-16 Thread Kandpal, Suraj
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, April 16, 2024 2:28 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Shankar, > Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj > Subject: Re: [PATCH] drm/i915

RE: [PATCH 1/2] drm/i915: Add SCLKGATE_DIS register definition

2024-04-16 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Tuesday, April 16, 2024 1:08 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Shankar, > Uma ; Nautiyal, Ankit K > ; Bhadane, Dnyaneshwar > ; Kandpal, Suraj > > Sub

RE: [5/7] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-08 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Friday, April 5, 2024 11:50 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Syrjala, Ville > ; Kumar, Naveen

RE: [7/7] drm/i915/dp: Limit brightness level to vbt min brightness

2024-04-07 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Friday, April 5, 2024 11:26 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Nikula, Jani > ; Kumar, Naveen

RE: [7/7] drm/i915/dp: Limit brightness level to vbt min brightness

2024-04-07 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Friday, April 5, 2024 11:26 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Nikula, Jani > ; Kumar, Naveen

RE: [5/7] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-07 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Friday, April 5, 2024 11:50 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Syrjala, Ville > ; Kumar, Naveen

RE: [4/7] drm/i915/dp: Fix comments on EDP HDR DPCD registers

2024-04-05 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Friday, April 5, 2024 10:55 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Syrjala, Ville > ; Kumar, Naveen

RE: [6/7] drm/i915/dp: Write panel override luminance values

2024-04-05 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Friday, April 5, 2024 11:02 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Syrjala, Ville > ; Kumar, Naveen

RE: [3/7] drm/i915/dp: Fix Register bit naming

2024-04-05 Thread Kandpal, Suraj
> -Original Message- > From: Sebastian Wick > Sent: Friday, April 5, 2024 10:46 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > ; Shankar, Uma > ; Nautiyal, Ankit K ; > Murthy, Arun R ; Syrjala, Ville > ; Kumar, Naveen

RE: [PATCH 7/7] drm/i915/dp: Limit brightness level to 20

2024-04-04 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Thursday, April 4, 2024 2:34 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Shankar, > Uma ; Nautiyal, Ankit K > ; Murthy, Arun R ; > Syrjala, Ville ; Kumar, Naveen1 >

RE: [PATCH] drm/i915: Fix i915_display_info output when connectors are not active

2024-03-31 Thread Kandpal, Suraj
> Subject: [PATCH] drm/i915: Fix i915_display_info output when connectors are > not active > > From: Ville Syrjälä > > Currently intel_connector_info(), which prints the per-connector output for > i915_display_info, just bails out early if the connector doesn't have a > current > encoder. That

RE: [PATCH] drm/i915/display: Initalizalize capability variables

2024-03-26 Thread Kandpal, Suraj
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Wednesday, March 27, 2024 9:32 AM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/i915/display: Initalizalize capability variables > > > > > -Original

RE: [PATCH] drm/i915/dp: Fix the computation for compressed_bpp for DISPLAY < 13

2024-03-26 Thread Kandpal, Suraj
> Subject: [PATCH] drm/i915/dp: Fix the computation for compressed_bpp for > DISPLAY < 13 > > For DISPLAY < 13, compressed bpp is chosen from a list of supported > compressed bpps. Fix the condition to choose the appropriate compressed > bpp from the list. > LGTM, Reviewed-by: Suraj Kandpal >

RE: [PATCH] drm/i915/display: Initalizalize capability variables

2024-03-26 Thread Kandpal, Suraj
> Hello Suraj, > > > -Original Message- > > From: Kandpal, Suraj > > Sent: Tuesday, March 26, 2024 10:45 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Borah, Chaitanya Kumar ; Kandpal, > > Suraj > > Subject: [PATCH] drm/i915/displ

RE: [PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-06 Thread Kandpal, Suraj
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, March 6, 2024 5:57 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma ; > Nautiyal, Ankit K > Subject: Re: [PATCH] drm/i915/dp: Enable AUX based backlight for HDR > > On

RE: [PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-02-27 Thread Kandpal, Suraj
> Subject: [PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away > from header file > > Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.h so that > intel_hdcp_gsc_message can be redefined for xe as needed. > > --v2 > -Correct commit message to reflect what patch is

RE: [PATCH 5/5] drm/xe/hdcp: Add intel_hdcp_gsc_message to Makefile

2024-02-18 Thread Kandpal, Suraj
> > Hey, > > Where is xe_hdcp_gsc_message.c defined in this series? > > I would move this part there. > Hi Maarten So there is no xe_hdcp_gsc_message.c but just intel_hdcp_gsc_message.c which\ Was separated from intel_hdcp_gsc.c for the purpose of code sharing and this Patch just build the

RE: [PATCH 4/5] drm/xe/hdcp: Enable HDCP for XE

2024-02-13 Thread Kandpal, Suraj
> > interaction of HDCP as a client with the GSC CS interface. > > > > --v2 > > -add kfree at appropriate place [Daniele] -remove useless define > > [Daniele] -move host session logic to xe_gsc_submit.c [Daniele] -call > > xe_gsc_check_and_update_pending directly in an if condition [Daniele] > >

RE: [PATCH 2/5] drm/xe/hdcp: Use xe_device struct

2024-02-13 Thread Kandpal, Suraj
> > On 2/9/2024 2:14 AM, Suraj Kandpal wrote: > > Use xe_device struct instead of drm_i915_private so as to not cause > > confusion and comply with Xe standards even though xe_device gets > > translated to drm_i915_private. > > AFAIU xe_device does not get translated to drm_i915_private, it's

RE: [PATCH 2/3] drm/xe/hdcp: Enable HDCP for XE

2024-02-06 Thread Kandpal, Suraj
> Subject: Re: [PATCH 2/3] drm/xe/hdcp: Enable HDCP for XE > > > > On 2/2/2024 12:37 AM, Suraj Kandpal wrote: > > Enable HDCP for Xe by defining functions which take care of > > interaction of HDCP as a client with the GSC CS interface. > > > > Signed-off-by: Suraj Kandpal > > --- > >

RE: [PATCH 2/2] drm/i915/lnl: Program PKGC_LATENCY register

2024-02-05 Thread Kandpal, Suraj
> Subject: Re: [PATCH 2/2] drm/i915/lnl: Program PKGC_LATENCY register > > On Mon, 05 Feb 2024, Suraj Kandpal wrote: > > Program the PKGC_LATENCY register with the highest latency from level > > 1 and above LP registers else program with all 1's. > > This is used to improve package C residency

RE: [PATCH 2/7] drm/i915/hdcp: HDCP Capability for the downstream device

2024-01-26 Thread Kandpal, Suraj
= > > On 1/24/2024 6:50 PM, Nautiyal, Ankit K wrote: > > > > On 1/12/2024 1:11 PM, Suraj Kandpal wrote: > >> Currently we are only checking capability of remote device and not > >> immediate downstream device but during capability check we need are > >> concerned with only the HDCP capability of

RE: [PATCH] drm/i915: Try to preserve the current shared_dpll for fastset on type-c ports

2024-01-22 Thread Kandpal, Suraj
> Subject: [PATCH] drm/i915: Try to preserve the current shared_dpll for fastset > on type-c ports > > From: Ville Syrjälä > > Currently icl_compute_tc_phy_dplls() assumes that the active PLL will be the > TC PLL (as opposed to the TBT PLL). The actual PLL will be selected during the > modeset

Re: [Intel-gfx] [PATCH] drm/i915/display: Get bigjoiner config before dsc config during readout

2023-11-22 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Wednesday, November 22, 2023 12:16 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kandpal, Suraj ; Manna, Animesh > ; jani.nik...@linux.intel.com; Nautiyal, Ankit K > > Subject: [PATCH] drm/i915/displ

Re: [Intel-gfx] [PATCH 04/11] drm/i915/audio: Consider fractional vdsc bpp while computing tu_data

2023-11-14 Thread Kandpal, Suraj
> MTL+ supports fractional compressed bits_per_pixel, with precision of > 1/16. This compressed bpp is stored in U6.4 format. > Accommodate the precision during calculation of transfer unit data for > hblank_early calculation. > > v2: > -Fix tu_data calculation while dealing with U6.4 format.

Re: [Intel-gfx] [PATCH 03/11] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-11-14 Thread Kandpal, Suraj
> MTL+ supports fractional compressed bits_per_pixel, with precision of > 1/16. This compressed bpp is stored in U6.4 format. > Accommodate this precision while computing m_n values. > > v1: > Replace the computation of 'data_clock' with 'data_clock = > DIV_ROUND_UP(data_clock, 16).' (Sui

Re: [Intel-gfx] [PATCH 02/11] drm/i915/display: Store compressed bpp in U6.4 format

2023-11-14 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, November 10, 2023 3:40 PM > To: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Sharma, Swati2 ; Kulkarni, Vandita > ; Kandpal, Suraj ; > suijingf...@loongson.cn > Subject

Re: [Intel-gfx] [PATCH 11/11] drm/i915/dp_mst: Add support for forcing dsc fractional bpp via debugfs

2023-11-11 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, November 10, 2023 3:40 PM > To: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Sharma, Swati2 ; Kulkarni, Vandita > ; Kandpal, Suraj ; > suijingf...@loongson.cn > Subject

Re: [Intel-gfx] [PATCH 10/11] drm/i916/dp_mst: Iterate over the DSC bpps as per DSC precision support

2023-11-11 Thread Kandpal, Suraj
> Subject: [PATCH 10/11] drm/i916/dp_mst: Iterate over the DSC bpps as per > DSC precision support > > Currently we iterate over the bpp_x16 in step of 16. > Use DSC fractional bpp precision supported by the sink to compute the > appropriate steps to iterate over the bpps. > LGTM. Reviewed-by:

Re: [Intel-gfx] [PATCH 09/11] drm/i915/dp_mst: Use precision of 1/16 for computing bpp

2023-11-11 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, November 10, 2023 3:40 PM > To: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Sharma, Swati2 ; Kulkarni, Vandita > ; Kandpal, Suraj ; > suijingf...@loongson.cn > Subject

Re: [Intel-gfx] [PATCH 2/2] drm/i915: remove excess functions from plane protection check

2023-11-09 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, November 9, 2023 9:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 2/2] drm/i915: remove excess functions from plane > protection check > > Reduce the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: abstract plane protection check

2023-11-09 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, November 9, 2023 9:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 1/2] drm/i915: abstract plane protection check > > Centralize the conditions in a

Re: [Intel-gfx] [PATCH 4/4] drm/i915/dp: Ignore max_requested_bpc if its too low for DSC

2023-11-08 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Tuesday, November 7, 2023 9:48 AM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 4/4] drm/i915/dp: Ignore max_requested_bpc if its > too low for DSC > > At the moment,

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp_mst: Use helpers to get dsc min/max input bpc

2023-11-08 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Tuesday, November 7, 2023 9:48 AM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 3/4] drm/i915/dp_mst: Use helpers to get dsc > min/max input bpc > > Use helpers for

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vdsc: Remove old comment about DSC 444 support

2023-10-31 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Monday, October 16, 2023 10:51 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/2] drm/i915/vdsc: Remove old comment about > DSC 444 support > > DSC with YCbCr420 is now supported, so

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: Use helper to calculate range_bpg_offset

2023-10-31 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Monday, October 16, 2023 10:51 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: Use helper to calculate > range_bpg_offset > > We get range_bpg_offset for different

Re: [Intel-gfx] [PATCH 2/3] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Thursday, October 26, 2023 3:34 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj > Subject: Re: [PATCH 2/3] drm/i915/hdcp: Create a blanket

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Create a blanket hdcp enable function

2023-10-26 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Thursday, October 26, 2023 1:02 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj > Subject: Re: [PATCH 1/2] drm/i915/hdcp: Create a blanket

Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-09 Thread Kandpal, Suraj
> -Original Message- > From: Ville Syrjälä > Sent: Monday, October 9, 2023 6:08 PM > To: Kandpal, Suraj > Cc: Jani Nikula ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in > verify_crtc_state > > On

Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-09 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Monday, October 9, 2023 4:07 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in > verify_crtc_state > > On Mon, 09 Oct 2023, Suraj

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/hdcp: Move checks for gsc health status

2023-10-09 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Monday, October 9, 2023 3:37 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/hdcp: Move checks for gsc > health status > > On Mon, 09 Oct 2023, Suraj

Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Kandpal, Suraj
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment > > On Thu, 05 Oct 2023, Ville Syrjälä wrote: > > On Thu, Oct 05, 2023 at 12:12:58PM +0530, Suraj Kandpal wrote: > >> i2c_adapter is being assigned using intel_connector even before the > >> NULL check occurs and even

Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

2023-10-05 Thread Kandpal, Suraj
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment > > Hi Suraj, > > On Thu, Oct 05, 2023 at 12:12:58PM +0530, Suraj Kandpal wrote: > > i2c_adapter is being assigned using intel_connector even before the > > NULL check occurs and even though it shouldn't be a problem

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/hdcp: Move common message filling function to its own file

2023-09-20 Thread Kandpal, Suraj
> Subject: Re: [PATCH v3 2/2] drm/i915/hdcp: Move common message filling > function to its own file > > On Wed, 20 Sep 2023, Suraj Kandpal wrote: > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.h > > b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.h > > new file mode

Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: Move common message filling function to its own file

2023-09-20 Thread Kandpal, Suraj
> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: Move common message > filling function to its own file > > On Wed, 20 Sep 2023, Suraj Kandpal wrote: > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h > > b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h > > index

Re: [Intel-gfx] [PATCH v5] drm/i915: Added Wa_18022495364

2023-09-14 Thread Kandpal, Suraj
> Subject: [Intel-gfx] [PATCH v5] drm/i915: Added Wa_18022495364 > Commit message style should be imperative so the header becomes something Around the lines of "Add Wa_18022495364" > Set the instruction and state cache invalidate bit using INDIRECT_CTX on every > gpu context switch. > The

Re: [Intel-gfx] [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-13 Thread Kandpal, Suraj
> Subject: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp > prescision > > From: Ankit Nautiyal > > Add helper to get the DSC bits_per_pixel precision for the DP sink. > I think you forgot to add my reviewed by that I gave in the last revision  Anyways, LGTM. Reviewed-by:

Re: [Intel-gfx] [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-12 Thread Kandpal, Suraj
> Subject: [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format > > From: Ankit Nautiyal > > DSC parameter bits_per_pixel is stored in U6.4 format. > The 4 bits represent the fractional part of the bpp. > Currently we use compressed_bpp member of dsc structure to store only the >

Re: [Intel-gfx] [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-12 Thread Kandpal, Suraj
> Subject: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp > prescision > > From: Ankit Nautiyal > > Add helper to get the DSC bits_per_pixel precision for the DP sink. > LGTM. Reviewed-by: Suraj Kandpal > Signed-off-by: Ankit Nautiyal > --- >

Re: [Intel-gfx] [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-11 Thread Kandpal, Suraj
> Subject: [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when > forced from debugfs > > From: Swati Sharma > > If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff > compressed bpp is fractional. Continue if the computed compressed bpp turns > out to be a integer.

Re: [Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-11 Thread Kandpal, Suraj
> Subject: [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC > fractional > bpp > > From: Swati Sharma > > DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to > depict sink's precision. > Also, new debugfs entry is created to enforce fractional bpp. > If

Re: [Intel-gfx] [PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-11 Thread Kandpal, Suraj
> Subject: [PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step > size > > From: Ankit Nautiyal > > This patch adds support to iterate over compressed output bpp as per the > fractional step, supported by DP sink. > > v2: > -Avoid ending up with compressed bpp, same as pipe

Re: [Intel-gfx] [PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-11 Thread Kandpal, Suraj
> Subject: [PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp > > From: Vandita Kulkarni > > Consider the fractional bpp while reading the qp values. > > v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) > LGTM. Reviewed-by: Suraj Kandpal > Signed-off-by:

Re: [Intel-gfx] [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-11 Thread Kandpal, Suraj
> Subject: RE: [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 > format > > > Subject: [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 > > format > > > > From: Ankit Nautiyal > > > > DSC parameter bits_per_pixel is stored in U6.4 format. > > The 4 bits represent the

Re: [Intel-gfx] [PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-11 Thread Kandpal, Suraj
> Subject: [PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while > computing tu_data > > From: Ankit Nautiyal > > MTL+ supports fractional compressed bits_per_pixel, with precision of > 1/16. This compressed bpp is stored in U6.4 format. > Accommodate the precision during calculation

Re: [Intel-gfx] [PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-11 Thread Kandpal, Suraj
> Subject: [PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while > computing m_n values > > From: Ankit Nautiyal > > MTL+ supports fractional compressed bits_per_pixel, with precision of > 1/16. This compressed bpp is stored in U6.4 format. > Accommodate this precision while

Re: [Intel-gfx] [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-11 Thread Kandpal, Suraj
> Subject: [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format > > From: Ankit Nautiyal > > DSC parameter bits_per_pixel is stored in U6.4 format. > The 4 bits represent the fractional part of the bpp. > Currently we use compressed_bpp member of dsc structure to store only the >

Re: [Intel-gfx] [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-11 Thread Kandpal, Suraj
> Subject: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp > prescision > > From: Ankit Nautiyal > > Add helper to get the DSC bits_per_pixel precision for the DP sink. I think this should also be floated in drm-devel mailing list. Regards, Suraj Kandpal > > Signed-off-by:

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-09-08 Thread Kandpal, Suraj
> Subject: RE: [Intel-gfx] [PATCH 3/3] drm/i915/display: Configure and > initialize > HDMI audio capabilities > > Hi Suraj, > > > -Original Message- > > From: Kandpal, Suraj > > Sent: 05 September 2023 14:47 > > To: Golani, Mitulkumar Ajitkumar

Re: [Intel-gfx] [PATCH 5/8] drm/i915/dsc: drop redundant = 0 assignments

2023-09-07 Thread Kandpal, Suraj
> Subject: [PATCH 5/8] drm/i915/dsc: drop redundant = 0 assignments > > Directly assign the values instead of first assigning 0 and then |= the > values. > LGTM. Reviewed-by: Suraj Kandpal > Cc: Suraj Kandpal > Cc: Ankit Nautiyal > Signed-off-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH 8/8] drm/i915/dsc: use REG_BIT, REG_GENMASK, and friends for PPS0 and PPS1

2023-09-06 Thread Kandpal, Suraj
> Subject: [PATCH 8/8] drm/i915/dsc: use REG_BIT, REG_GENMASK, and friends > for PPS0 and PPS1 > > Use the register helper macros for PPS0 and PPS1 register contents. > LGTM. Reviewed-by: Suraj Kandpal > Cc: Suraj Kandpal > Cc: Ankit Nautiyal > Signed-off-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH 7/8] drm/i915/dsc: add the PPS number to the register content macros

2023-09-06 Thread Kandpal, Suraj
> Subject: [PATCH 7/8] drm/i915/dsc: add the PPS number to the register content > macros > > Improve clarity by specifying the PPS number in the register content macros. > It's > easier to notice if macros are being used for the wrong register. > LGTM. Reviewed-by: Suraj Kandpal > Cc: Suraj

  1   2   3   4   >