Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 05/13] lib: Add GPU power measurement

2019-02-04 Thread Katarzyna Dec
On Mon, Feb 04, 2019 at 08:36:06AM +, Chris Wilson wrote: > Read the RAPL power metrics courtesy of perf. Or your local HW > equivalent? > > Signed-off-by: Chris Wilson > --- > lib/Makefile.sources | 2 + > lib/igt_gpu_power.c | 109 +++ >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 01/13] i915/gem_mocs_settings: Allow hangs around reset tests

2019-02-04 Thread Katarzyna Dec
On Mon, Feb 04, 2019 at 08:36:02AM +, Chris Wilson wrote: > To inject a GPU hang, we should ask the kernel first if it is legal to > do so. > > Signed-off-by: Chris Wilson Reviewed-by: Katarzyna Dec Kasia :) ___ Intel-gfx mailing li

Re: [Intel-gfx] [PATCH i-g-t] igt/pm_rps: Clear previous high load on high->low transition

2018-09-04 Thread Katarzyna Dec
On Tue, Sep 04, 2018 at 01:49:56PM +0100, Chris Wilson wrote: > Make sure we do flush out the previous spinner and delay signaling > transition completion until we do. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=102250 > Signed-off-by: Chris Wilson >

Re: [Intel-gfx] [PATCH i-g-t] igt/pm_rps: Wait for the load-helper to signal receipt of command

2018-09-04 Thread Katarzyna Dec
e this will fix sporadic issues with pm_rps that still coming back. Reviewed-by: Katarzyna Dec ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] lib/sysfs: Avoid using FILE* temporary for igt_sysfs_[v]printf

2018-08-30 Thread Katarzyna Dec
but we have been interpreting errno to handle signal > restarting. As that is in doubt, reduce it to a sprintf and reuse our > common interrupt handling write() that already returns -errno. > > Signed-off-by: Chris Wilson > Cc: Katarzyna Dec &g

Re: [Intel-gfx] [PATCH] drm/i915/selftests: ring all doorbells in igt_guc_doorbells

2018-08-28 Thread Katarzyna Dec
orbell %u ring failed!\n", client->doorbell_id); > + return -EIO; > + } > + > + if (desc->wq_status != WQ_STATUS_ACTIVE) { > + pr_err("doorbell %u ring put WQ in bad state (%u)!\n", > +client->doorbell_id, desc->wq_sta

Re: [Intel-gfx] [PATCH i-g-t 4/4] igt/gem_exec_capture: Capture many, many objects

2018-07-25 Thread Katarzyna Dec
On Mon, Jul 23, 2018 at 09:07:36PM +0100, Chris Wilson wrote: > Exercise O(N^2) behaviour in reading the error state, and push it to the > extreme. > > Reported-by: Jason Ekstrand > Signed-off-by: Chris Wilson LGTM, Reviewed-by: Katar

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/4] igt/gem_tiled_fence_blits: Remove libdrm_intel dependence

2018-07-25 Thread Katarzyna Dec
On Mon, Jul 23, 2018 at 09:07:34PM +0100, Chris Wilson wrote: > Modernise the test to use igt's ioctl library as opposed to the > antiquated libdrm_intel. > > Signed-off-by: Chris Wilson LGTM, Reviewed-by: Katarzyna Dec Kasia :) ___ Intel

Re: [Intel-gfx] [PATCH i-g-t 3/4] igt/gem_exec_schedule: Trim deep runtime

2018-07-24 Thread Katarzyna Dec
On Mon, Jul 23, 2018 at 09:07:35PM +0100, Chris Wilson wrote: > Time the runtime for emitting deep dependency tree, while keeping it > full of umpteen thousand requests. > > Signed-off-by: Chris Wilson After conversation on IRC with dispelling doubts: Reviewed-by: Katarzyna

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib: Don't assert all KMS drivers support edid_override

2018-07-24 Thread Katarzyna Dec
lson Reviewed-by: Katarzyna Dec > --- > lib/igt_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/igt_kms.c b/lib/igt_kms.c > index 476a78623..c9e00c3bd 100644 > --- a/lib/igt_kms.c > +++ b/lib/igt_kms.c > @@ -913,7 +913,7 @@ void kmste

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_exec_await: Tag the final batch in the GTT

2018-06-08 Thread Katarzyna Dec
into a valid poistion within the GTT before we fill the ring with > busyspinners. > > Signed-off-by: Chris Wilson Reviewed-by: Katarzyna Dec Kasia :) ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] lib/gpgpu_fill: Adding missing configuration parameters for gpgpu_fill function

2018-03-27 Thread Katarzyna Dec
On Mon, Mar 26, 2018 at 02:28:48PM -0700, Daniele Ceraolo Spurio wrote: > + igt-dev > > On 21/03/18 07:23, Katarzyna Dec wrote: > > During debugging gpgpu_fill test on various platforms, I found out few > > things that can affect newer gens: > > this is sligh

[Intel-gfx] [PATCH i-g-t] lib/gpgpu_fill: Adding missing configuration parameters for gpgpu_fill function

2018-03-21 Thread Katarzyna Dec
results in GPU hang. Adding pipeline selection mask to gen9_gpgpu_fillfunc, which is necessary from SKL. Changes gen7_emit_interface_descriptor_load to gen8 version. Signed-off-by: Katarzyna Dec <katarzyna@intel.com> Cc: Lukasz Kalamarz <lukasz.kalam...@intel.com> Cc: Daniele Ce

Re: [Intel-gfx] [PATCH i-g-t] lib/rendercopy: Refactoring rendercopy libraries

2018-01-04 Thread Katarzyna Dec
; > Signed-off-by: Lukasz Kalamarz <lukasz.kalam...@intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > Cc: Imre Deak <imre.d...@intel.com> LGTM. More changes are going to come to this library and other similar (media and gpgpu). Reviewed-by: Katarzyna Dec

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rps: Move some test logic out of boost functiony

2017-10-17 Thread Katarzyna Dec
sagar.a.kam...@intel.com> https://lists.freedesktop.org/mailman/listinfo/intel-gfx Reviewed-by: Katarzyna Dec <katarzyna@intel.com> Cheers, Kasia ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t v2 2/4] lib/i915: Extract helpers for determining scheduler capabilities

2017-10-13 Thread Katarzyna Dec
Reviewed-by: Katarzyna Dec <katarzyna@intel.com> Cheers, Kasia ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 3/4] lib/i915: Move context related helpers to lib/i915/gem_context

2017-10-13 Thread Katarzyna Dec
Reviewed-by:Katarzyna Dec <katarzyna@intel.com>, Cheers, Kasia ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t v2 4/4] lib/i915: Extract context priority setparam to a helper

2017-10-13 Thread Katarzyna Dec
.com> > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Katarzyna Dec <katarzyna@intel.com> > Cc: Petri Latvala <petri.latv...@intel.com> Reviewed-by: Katarzyna Dec <katarzyna@intel.com>

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib: Extract helpers for determining submission method

2017-10-13 Thread Katarzyna Dec
z Hiler <arkadiusz.hi...@intel.com> > Cc: Chris Wilson <ch...@chris-wilson.co.uk> >> Cc: Katarzyna Dec <katarzyna@intel.com> Reviewed-by: Katarzyna Dec <katarzyna@intel.com> > Cc: Petri Latvala <petri.latv...@intel.com> > --- Cheers, Kasia __

Re: [Intel-gfx] [PATCH i-g-t v4] kms_rotation_crc: 90 degree flip test is not a stress test

2017-09-12 Thread Katarzyna Dec
xtended.testlist from the patch. > > v4: > > Collect a flip fb crc and check it after flip. This way we test > not only the flip succeeded but the right image is displayed. For now it looks like sprite-rotation-X-flip tests are failing by this assert. Otherwise: Reviewed-by: Kata

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-08 Thread Katarzyna Dec
On Thu, Sep 07, 2017 at 11:28:38AM -0700, Belgaumkar, Vinay wrote: > > > On 9/7/2017 5:15 AM, Katarzyna Dec wrote: > > Added comments in tricky places for better feature understanding. > > Added IGT_TEST_DESCRIPTION and short description for non-obvious > > subtests.

Re: [Intel-gfx] [PATCH i-g-t v2] kms_rotation_crc: 90 degree flip test is not a stress test

2017-09-07 Thread Katarzyna Dec
On Thu, Sep 07, 2017 at 03:20:19PM +0100, Tvrtko Ursulin wrote: > > Hi, > > On 07/09/2017 15:13, Katarzyna Dec wrote: > > On Mon, Sep 04, 2017 at 03:27:26PM +0100, Tvrtko Ursulin wrote: > > > > > > On 07/08/2017 16:53, Daniel Vetter wrote: > > &g

[Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-07 Thread Katarzyna Dec
: Vinay Belgaumkar <vinay.belgaum...@intel.com> Cc: Petri Latvala <petri.latv...@intel.com> Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Signed-off: Katarzyna Dec <katarzyna@intel.com

Re: [Intel-gfx] [PATCH i-g-t v2] tests/gem_flink_basic: Add documentation for subtests

2017-09-04 Thread Katarzyna Dec
On Fri, Sep 01, 2017 at 12:55:37PM +0100, Arkadiusz Hiler wrote: > On Thu, Aug 31, 2017 at 02:33:23PM -0700, Vinay Belgaumkar wrote: > > Added the missing IGT_TEST_DESCRIPTION and some subtest > > descriptions. Trying to establish a method to document > > Hey Vinay, > > Please add appropriate

Re: [Intel-gfx] tests/gem_flink_basic: Add documentation for subtests

2017-09-01 Thread Katarzyna Dec
> Date: Thu, 31 Aug 2017 14:33:23 -0700 > From: Vinay Belgaumkar > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH i-g-t v2] tests/gem_flink_basic: Add > documentation for subtests > Message-ID: >

[Intel-gfx] [PATCH i-g-t v8] pm_rps: Changes in waitboost scenario

2017-08-31 Thread Katarzyna Dec
ked-by: Daniel Vetter <daniel.vet...@intel.com> Signed-off-by: Katarzyna Dec <katarzyna@intel.com> --- tests/pm_rps.c | 67 -- 1 file changed, 42 insertions(+), 25 deletions(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index

[Intel-gfx] [PATCH i-g-t v7] pm_rps: Changes in waitboost scenario

2017-08-30 Thread Katarzyna Dec
t;petri.latv...@intel.com> Cc: Jani Saarinen <jani.saari...@intel.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Acked-by: Daniel Vetter <daniel.vet...@intel.com> Signed-off-by

[Intel-gfx] [PATCH i-g-t v6] pm_rps: Changes in waitboost scenario

2017-08-30 Thread Katarzyna Dec
tv...@intel.com> Cc: Jani Saarinen <jani.saari...@intel.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Acked-by: Daniel Vetter <daniel.vet...@intel.com> Signed-off-by: Katarzyna De

[Intel-gfx] [PATCH i-g-t v5] pm_rps: Changes in waitboost scenario

2017-08-29 Thread Katarzyna Dec
el.com> Cc: Jani Saarinen <jani.saari...@intel.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Signed-off-by: Katarzyna Dec <

[Intel-gfx] [PATCH i-g-t v4] pm_rps: Changes in waitboost scenario

2017-08-28 Thread Katarzyna Dec
<jani.saari...@intel.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Signed-off-by: Katarzyna Dec <katarzyna@intel.com> --- tests/pm_rps.c | 63 +++--- 1 file changed, 38 insertions(+), 25 deletions(-) diff

[Intel-gfx] [PATCH i-g-t v3] pm_rps: Changes in waitboost scenario

2017-08-22 Thread Katarzyna Dec
com> Signed-off-by: Katarzyna Dec <katarzyna@intel.com> --- tests/pm_rps.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index f0455e78..e8a051cf 100644 --- a/tests/pm_rps.c +++ b/tests/pm_rps.c @@ -50,6 +50

[Intel-gfx] [PATCH i-g-t v3] pm_rps: Changes in waitboost scenario

2017-08-21 Thread Katarzyna Dec
l.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Signed-off-by: Katarzyna Dec <katarzyna@intel.com> --- tests/pm_rps.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index f

[Intel-gfx] [PATCH i-g-t v2] pm_rps: Changes in waitboost scenario

2017-08-18 Thread Katarzyna Dec
here let's also make sure that we're running as DRM master to catch the common case, where the test is being ran along with Xorg. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Jeff Mcgee <jeff.mc...@intel.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Signed

[Intel-gfx] [PATCH i-g-t] pm_rps: Changes in waitboost scenario

2017-08-18 Thread Katarzyna Dec
to be finished. Made test DRM master to make sure that the test isn't ran along Xorg Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Jeff Mcgee <jeff.mc...@intel.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Signed-off-by: Katarzyna Dec <katarzyna@

[Intel-gfx] [PATCH i-g-t] pm_rps: Extended testcases with checking PMINTRMSK register value

2017-08-10 Thread Katarzyna Dec
become DRM master, to make sure that the test isn't ran along Xorg (which will interfere with our mesurements) Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Jeff Mcgee <jeff.mc...@intel.com> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Signed-off-by: Katarz