luding
linux/kernel.h. This prepares for dropping drmP.h from files including
drm_hdcp.h."
Reviewed-by: Laurent Pinchart
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
> Signed-off-by: Jani Nikula
> ---
> include/drm/drm_hdcp.h | 2 ++
> 1 file changed, 2
to make drm_file.h self-contained."
Reviewed-by: Laurent Pinchart
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
> Signed-off-by: Jani Nikula
> ---
> include/drm/drm_file.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/drm
avoid including drm_device.h by un-inlining (Daniel)
It would be nice to explain why you de-inline the function (I assume because
it's a bit too large).
Reviewed-by: Laurent Pinchart
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Cc: Laurent Pinchart
> Signed-off-by: Jani Nikula
> ---
Hi Andrzej,
On Wednesday, 5 December 2018 10:46:40 EET Andrzej Hajda wrote:
> On 05.12.2018 07:32, Laurent Pinchart wrote:
> > On Tuesday, 4 December 2018 21:13:20 EET Ville Syrjälä wrote:
> >> On Tue, Dec 04, 2018 at 08:46:53AM +0100, Andrzej Hajda wrote:
> >>> On 0
Hi Ville,
On Tuesday, 4 December 2018 21:13:20 EET Ville Syrjälä wrote:
> On Tue, Dec 04, 2018 at 08:46:53AM +0100, Andrzej Hajda wrote:
> > On 03.12.2018 22:38, Ville Syrjälä wrote:
> >> On Thu, Nov 29, 2018 at 10:08:07AM +0100, Andrzej Hajda wrote:
> >>> On 21.1
: "David (ChunMing) Zhou"
> Cc: Archit Taneja
> Cc: Andrzej Hajda
> Cc: Laurent Pinchart
> Cc: Inki Dae
> Cc: Joonyoung Shim
> Cc: Seung-Woo Kim
> Cc: Kyungmin Park
> Cc: Russell King
> Cc: CK Hu
> Cc: Philipp Zabel
> Cc: Rob Clark
> Cc: Ben Ske
Hi Daniel,
On Wednesday, 3 October 2018 12:08:38 EEST Daniel Vetter wrote:
> On Tue, Oct 02, 2018 at 04:53:12PM +0300, Laurent Pinchart wrote:
> > On Tuesday, 2 October 2018 16:35:10 EEST Daniel Vetter wrote:
> > > It's the default. The exported version was kinda a transit
on
> the default) let's unexport it.
>
> Signed-off-by: Daniel Vetter
> Cc: Gustavo Padovan
> Cc: Maarten Lankhorst
> Cc: Sean Paul
> Cc: David Airlie
> Cc: VMware Graphics
> Cc: Sinclair Yeh
> Cc: Thomas Hellstrom
> Cc: Archit Taneja
> Cc: Neil A
Hi John,
On Friday, 24 August 2018 00:12:46 EEST John Stultz wrote:
> On Thu, Aug 23, 2018 at 1:49 PM, Laurent Pinchart wrote:
> > On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote:
> >> On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote:
> >>> On T
Hi John,
On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote:
> On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote:
> > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote:
> >> On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote:
> >>&
, the 1920x2160 res fbdev should still be ok, as only
> 1920x1080 is actually displayed at one time.
>
> So it seems like we might need to multiply the max_height by the
> overalloc factor when we are checking it in
> drm_internal_framebuffer_create?
>
> Does that approach sou
-crtc
> - init sources-list only for gen3
> Changes Since V2:
> - Adopt to driver style
> - Address other review comments from Laurent Pinchart
I'm pretty sure this has changed since v4 as well.
> Signed-off-by: Mahesh Kumar
> Cc: dri-de...@lists.freedesktop.org
> Cc: L
-crtc
> - init sources-list only for gen3
>
> Signed-off-by: Mahesh Kumar
> Cc: Laurent Pinchart
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 96 ++-
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 3 ++
> 2 files changed, 98 insertions(+), 1 de
r optimize the code
>
> Signed-off-by: Mahesh Kumar
> Cc: dri-de...@lists.freedesktop.org
> Cc: Laurent Pinchart
> Reviewed-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 71 +--
> 1 file changed, 51 insertions(+), 20
Hi Mahesh,
Thank you for the patch.
On Thursday, 12 July 2018 11:36:35 EEST Mahesh Kumar wrote:
> This patch implements get_crc_sources callback, which returns list of
> all the crc sources supported by driver in current platform.
>
> Signed-off-by: Mahesh Kumar
> Cc: L
y allocation.
> Now set_crc_source takes only two variable inputs, values_cnt we
> already gets as part of verify_crc_source.
>
> Changes since V1:
> - refactor code to use single spin lock
>
> Signed-off-by: Mahesh Kumar
> Cc: dri-de...@lists.freedesktop.org
> Cc: L
-by: Mahesh Kumar
> Cc: dri-de...@lists.freedesktop.org
> Cc: Laurent Pinchart
> Reviewed-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 66 ---
> 1 file changed, 53 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu
-core
> Changes Since V2:
> - update commit message
> - update callback documentation
> - print one source name per line
>
> Signed-off-by: Mahesh Kumar
> Cc: dri-de...@lists.freedesktop.org
> Cc: Laurent Pinchart
> Reviewed-by: Maarten Lankhorst
> ---
> drivers
+
> drivers/gpu/drm/rcar-du/rcar_du_kms.h | 1 +
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 26 -
> include/drm/drm_crtc.h | 40 ++-
> 14 files changed, 396 insertions(+), 74 deletions(-)
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
g string for source.
>
> Changes since V1:
> - do not yet verify_crc_source during open.
>
> Signed-off-by: Mahesh Kumar
> Cc: dri-de...@lists.freedesktop.org
> Cc: Laurent Pinchart
> Reviewed-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/drm_debugfs_crc.c | 8 +
Hi Mahesh,
On Tuesday, 10 July 2018 15:59:11 EEST Kumar, Mahesh wrote:
> On 7/10/2018 5:07 PM, Laurent Pinchart wrote:
> > On Monday, 2 July 2018 14:07:24 EEST Mahesh Kumar wrote:
> >> This patch implements "verify_crc_source" callback function for
> >> rcar
Hi Mahesh,
On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote:
> On 7/10/2018 4:56 PM, Laurent Pinchart wrote:
> > On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote:
> >> This patch adds a new callback function "verify_crc_source" which will
> &g
Hi Mahesh,
On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote:
> On 7/10/2018 4:52 PM, Laurent Pinchart wrote:
> > Hi Mahesh,
> > On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote:
> >> This patch introduce a callback function "get_crc_sources" whi
s not support CRC
> + * generation or no prework is required before reading the crc
> + *
> + * RETURNS:
> + *
> + * 0 on success or a negative error code on failure.
> + */
> + int (*pre_crc_read)(struct drm_crtc *crtc);
>
> /**
>
ter read call, it can use
> poll/read blocking read() call.
>
> Suggested-by: Ville Syrjälä
> Signed-off-by: Mahesh Kumar
> Cc: dri-de...@lists.freedesktop.org
> Cc: Tomeu Vizoso
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_debugfs_crc.c | 16 ---
gt;f_inode->i_private;
> struct drm_crtc_crc *crc = &crtc->crc;
> - size_t values_cnt;
>
> - crtc->funcs->set_crc_source(crtc, NULL, &values_cnt);
> + crtc->funcs->set_crc_source(crtc, NULL);
>
> spin_lock_irq(&crc->lock);
> crtc_crc_cleanup(crc);
> @@ -370,7 +362,7 @@ int drm_debugfs_crtc_crc_add(struct drm_crtc *crtc)
> {
> struct dentry *crc_ent, *ent;
>
> - if (!crtc->funcs->set_crc_source)
> + if (!crtc->funcs->set_crc_source || !crtc->funcs->verify_crc_source)
> return 0;
>
> crc_ent = debugfs_create_dir("crc", crtc->debugfs_entry);
[snip]
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
@@ static const struct drm_crtc_funcs crtc_funcs_gen3 = {
> .enable_vblank = rcar_du_crtc_enable_vblank,
> .disable_vblank = rcar_du_crtc_disable_vblank,
> .set_crc_source = rcar_du_crtc_set_crc_source,
> + .verify_crc_source = rcar_du_crtc_verify_crc_source,
> };
>
> /*
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
* verifies the source of CRC checksums of frames before setting the
> + * source for CRC and during crc open.
> + *
> + * This callback is optional if the driver does not support any CRC
> + * generation functionality.
> +
upport exporting of
> + * possible CRC sources list. CRC-core does the verification of sources.
> + *
> + * RETURNS:
> + *
> + * a constant character pointer to the list of all the available CRC
> + * sources
> + */
> + const char *const *(*get_crc_sources)(struct drm_crtc *crtc,
> + size_t *count);
>
> /**
>* @atomic_print_state:
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Dave,
On Thursday, 17 May 2018 08:05:03 EEST Dave Airlie wrote:
> On 17 May 2018 at 14:42, Dave Airlie wrote:
> > On 16 May 2018 at 01:37, Laurent Pinchart wrote:
> >> On Tuesday, 15 May 2018 17:24:52 EEST kbuild test robot wrote:
> >>> tree: git://anongit.f
rm-misc-next but not merged in
the drm tree yet.
Dave, how would you like to handle this ? I can rebase my drm/du/next branch
on top of your tree once you merge drm-misc-next and send a new pull request,
but I'd like to avoid missing the v4.18 merge window. Another option would be
to handle th
olerate absence of 8-bit format
>
> lib/igt_gt.c | 24 ++--
> lib/igt_pm.c | 2 +-
> tests/kms_addfb_basic.c | 33 ++---
> tests/kms_panel_fitting.c | 1 +
> tests/kms_plane_lowres.c | 1 +
| 6 +++---
> > drivers/gpu/drm/tve200/tve200_drv.c| 4 ++--
> > drivers/gpu/drm/udl/udl_drv.c | 2 +-
> > drivers/gpu/drm/vc4/vc4_drv.c | 4 ++--
> > drivers/gpu/drm/vgem/vgem_drv.c|
#x27;s just replace
> all current use cases of drm_dev_unref() with drm_dev_put and remove
> the function itself.
>
> Coccinelle was used for mass-patching.
>
> Signed-off-by: Vaishali Thakkar
I love seeing deprecated functions go.
Reviewed-by: Laurent Pinchart
> ---
&g
Hi Daniel,
On Wednesday, 21 March 2018 10:34:33 EET Daniel Vetter wrote:
> On Tue, Mar 20, 2018 at 01:24:09PM +0200, Laurent Pinchart wrote:
> > Hi Ulrich,
> >
> > Thank you for the patch.
> >
> > On Thursday, 15 March 2018 16:45:38 EET Ulrich Hecht wrote:
&
;s good news ! (Not that I'm happy that we have bugs, but catching them
shows that igt is useful for us). I hope this will help convincing management
that we should keep contributing to igt going forward.
Ulrich, for the record, I agree with all of Daniel's and Ville's comments
poste
Hi Ulrich,
Thank you for the patch.
On Thursday, 15 March 2018 16:45:37 EET Ulrich Hecht wrote:
> Add is_i915_device() requirement to tests using Intel-specific APIs.
>
> Signed-off-by: Ulrich Hecht
Reviewed-by: Laurent Pinchart
> ---
> tests/kms_addfb_basic.c | 3 +++
>
? Can't we replace the Intel generation check with a different
feature check ?
> for_each_pipe_with_valid_output(display, pipe, output) {
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Noralf,
Thank you for the patch.
On Thursday, 4 January 2018 00:21:04 EET Noralf Trønnes wrote:
> Remove a couple of trailing spaces.
>
> Signed-off-by: Noralf Trønnes
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_ioctl.c | 4 ++--
> 1 file changed,
ffers.h
> @@ -0,0 +1,10 @@
You should add an SPDX header to specify the file license.
> +#ifndef _DRM_DUMB_BUFFERS_H_
> +#define _DRM_DUMB_BUFFERS_H_
> +
> +struct drm_device;
> +struct drm_file;
> +
> +int drm_mode_create_dumb_ioctl(struct drm_device *
Hi Daniel,
On Tuesday, 19 December 2017 16:00:36 EET Daniel Vetter wrote:
> On Tue, Dec 19, 2017 at 03:33:57PM +0200, Laurent Pinchart wrote:
> > On Tuesday, 19 December 2017 12:03:55 EET Daniel Vetter wrote:
> > > On Mon, Dec 18, 2017 at 06:13:46PM +0200, Laurent Pinchart
Hi Daniel,
On Tuesday, 19 December 2017 12:03:55 EET Daniel Vetter wrote:
> On Mon, Dec 18, 2017 at 06:13:46PM +0200, Laurent Pinchart wrote:
> > On Thursday, 14 December 2017 22:30:53 EET Daniel Vetter wrote:
> >> DK put some nice docs into the commit introducing driver priva
> Cc: Dhinakaran Pandiyan
> Cc: Maarten Lankhorst
> Cc: Ville Syrjälä
> Cc: Laurent Pinchart
> Cc: Rob Clark
> Cc: Alex Deucher
> Cc: Ben Skeggs
> Signed-off-by: Daniel Vetter
> ---
> Documentation/gpu/drm-kms.rst | 6 ++
> d
hat great).
> >
> > Cc: Harry Wentland
> > Cc: Dhinakaran Pandiyan
> > Cc: Maarten Lankhorst
> > Cc: Ville Syrjälä
> > Cc: Laurent Pinchart
> > Cc: Rob Clark
> > Cc: Alex Deucher
> > Cc: Ben Skeggs
> > Signed-off-by: Daniel Vetter
ushed to drm-misc-next. Thanks for the reviews.
And I now realize my review comments aren't very useful (apart possibly the
one about adding a comment to the drm_plane_helper_check_update() function,
feel free to submit a patch for that if you think it's useful) as the series
has been merged already :-/ I should really start reading mails in the reverse
chronological order.
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
: VMware Graphics
> Cc: Sinclair Yeh
> Cc: Thomas Hellstrom
> Signed-off-by: Ville Syrjälä
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 17 +++--
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/
hich have been checked by the core already.
>
> Cc: VMware Graphics
> Cc: Sinclair Yeh
> Cc: Thomas Hellstrom
> Signed-off-by: Ville Syrjälä
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 --
> 1 file changed, 6 deletions(-)
>
&g
> drm_atomic_helper.c.
>
> Cc: Daniel Vetter
> Suggested-by: Daniel Vetter
> Signed-off-by: Ville Syrjälä
I would move this patch before 4/5 to make it easier to revert 4/5 (for the
reason explaining as a reply to that patch).
Reviewed-by: Laurent Pinchart
> ---
> driver
hange should be reverted
when the function is dropped, otherwise we'll carry the CRTC state argument
for a long time without realizing it's not needed anymore.
Apart from that,
Reviewed-by: Laurent Pinchart
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/arm/hdlcd
the hardware. That's why I
use it in rcar-du.
Are drivers allowed to adjust the hdisplay and vdisplay values though ? I
thought unsupported values there had to be rejected with an error at atomic
check time, not adjusted.
> I guess I just volunteered myself to do this. Just needs plenty
buffer with multiple entries that
> have consecutive sg_dma_addresses, effectively making it contiguous.
> Allow for that scenario by testing the entries in the sg_table for
> contiguous coverage.
>
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Liviu Dudau
> ---
>
> Laure
Hi Noralf,
On Wednesday, 13 September 2017 18:19:22 EEST Noralf Trønnes wrote:
> Den 13.09.2017 07.09, skrev Laurent Pinchart:
> > On Monday, 11 September 2017 17:31:54 EEST Noralf Trønnes wrote:
> >> Hi,
> >>
> >> I want to start out by saying that this patc
| 2 +
> include/drm/drm_fb_helper.h | 9 +
> include/drm/drm_file.h | 2 +
> include/drm/drm_framebuffer.h | 4 +
> 11 files changed, 305 insertions(+), 237 deletions(-)
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wednesday, 30 August 2017 17:17:36 EEST Daniel Vetter wrote:
> On Wed, Aug 30, 2017 at 05:10:43PM +0300, Laurent Pinchart wrote:
> > Hi Maarten,
> >
> > Thank you for the patch.
> >
> > On Wednesday, 30 August 2017 15:17:51 EEST Maarten Lankhorst wrote:
&g
- Only create a single disable commit. (danvet)
> - Fix leak in intel_legacy_cursor_update.
>
> Signed-off-by: Maarten Lankhorst
> Testcase: kms_atomic_transition.plane-use-after-nonblocking-unbind*
> Cc: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_atomic.c | 4 +
> driver
through the
> + * various phases. This is never cleared, except when we destroy the
> + * state, so that subsequent commits can synchronize with previous ones.
> + */
> + struct drm_crtc_commit *commit;
> +
> struct drm_atom
t; drm_property_blob_put(state->mode_blob);
> drm_property_blob_put(state->degamma_lut);
> drm_property_blob_put(state->ctm);
> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> index 8a5808eb5628..e76d9f95c191 100644
> --- a/include/drm/d
On Monday 14 Aug 2017 09:25:47 Daniel Vetter wrote:
> On Sat, Aug 12, 2017 at 12:20 AM, Laurent Pinchart
>
> wrote:
> > On Tuesday 25 Jul 2017 10:01:16 Daniel Vetter wrote:
> >> diff --git a/drivers/gpu/drm/drm_mode_object.c
> >> b/drivers/gpu/drm/drm
continue;
>
> if (*arg_count_props > count) {
> - ret = drm_object_property_get_value(obj, prop, &val);
> + ret = __drm_object_property_get_value(obj, prop,
&val);
> if (ret)
>
,
Reviewed-by: Laurent Pinchart
> Signed-off-by: Daniel Vetter
> Cc: Liviu Dudau
> Cc: Brian Starkey
> Cc: Mali DP Maintainers
> Cc: Boris Brezillon
> Cc: Daniel Vetter
> Cc: Jani Nikula
> Cc: Sean Paul
> Cc: David Airlie
> Cc: Inki Dae
> Cc: Joonyou
Hi Joe,
On Tuesday 01 Aug 2017 10:24:25 Joe Kniss wrote:
> On Tue, Aug 1, 2017 at 5:09 AM, Laurent Pinchart wrote:
> > On Monday 31 Jul 2017 11:29:13 Joe Kniss wrote:
> >> New getfb2 functionality uses drm_mode_fb_cmd2 struct to be symmetric
> >> with addfb2.
> >
> index b2c52843bc70..c81c75335cca 100644
> --- a/include/uapi/drm/drm.h
> +++ b/include/uapi/drm/drm.h
> @@ -814,6 +814,8 @@ extern "C" {
> #define DRM_IOCTL_MODE_CREATEPROPBLOBDRM_IOWR(0xBD, struct
> drm_mode_create_blob)
> #define DRM_IOCTL_MODE_DESTROYPROPB
gt; v2: don't forget zorder and get_property!
> >>
> >> Cc: Tomi Valkeinen >> Cc: Laurent Pinchart
> >> Signed-off-by: Daniel Vetter
> >> ---
> >>
> >> drivers/gpu/drm/omapdrm/omap_crtc.c | 64 ++-
>
Hi Maarten,
On Wednesday 26 Jul 2017 14:53:33 Laurent Pinchart wrote:
> On Wednesday 19 Jul 2017 16:39:16 Maarten Lankhorst wrote:
> > for_each_obj_in_state is about to be removed, so use the correct new
> > iterator macros.
> >
> > Also look at new_plane_state i
n use. They should be the same except when reallocating,
> (in which case this code is skipped) and we should really stop looking
> at obj->state whenever possible.
>
> Changes since v1:
> - Actually compile correctly.
>
> Signed-off-by: Maarten Lankhorst
&
s/gpu/drm/rcar-du/rcar_du_lvdscon.c | 1 -
For the above,
Reviewed-by: Laurent Pinchart
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
sil-sii8620 doesn't have a connector around when
> >> + * we need one, so we have to be prepared for a NULL connector.
> >> + */
> >> + bool has_hdmi_infoframe = connector ?
> >> + &connector->display_info.has_hdmi_infoframe : NULL;
> >
ultimately from drm_dev_release(), calls drm_vblank_cleanup(). The
commit message could be a bit more explicit. Apart from that,
Acked-by: Laurent Pinchart
> Cc: Laurent Pinchart
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 +---
> 1 file chang
mmon error code for failed to
> look up an object throughout drm, so let's use it in the cma helpers,
> too.
Regardless of which is best, it's true that ENOENT is used through the DRM
code, so
Reviewed-by: Laurent Pinchart
Someone should however mention that this changes the
Chris pointed out on irc that the grammar went a bit wrong here. I'll fix
> this to
>
> "As a freedesktop.org project, dri-devel, and the DRM community, follows
> the Contributor Covenant, ..."
s/follows/follow/ ?
Apart from that and the other small style and typo changes
er side of how to
> make hw work correctly where it's possible is imo already sufficiently
> documented.
>
> v2: Review from Laurent.
>
> Cc: Laurent Pinchart
> Signed-off-by: Daniel Vetter
Reviewed-by: Laurent Pinchart
> ---
> include/drm/drm_crtc.h | 6 ++
&
Hi Maarten,
Thank you for the resend.
For the whole series,
Tested-by: Laurent Pinchart
On Wednesday 01 Mar 2017 10:21:26 Maarten Lankhorst wrote:
> There are new iterator macros that annotate whether the new or old
> state should be used. This is better than using a state that depe
e->crtc);
I believe more *_state -> *_(new|old)_state renames could be useful, but that
can be addressed as a subsequent patch, so
Reviewed-by: Laurent Pinchart
> crtc_state->connector_mask &=
> ~(1 << drm_connector_index(conn_stat
p. For clarity, also rename the
> variables from $obj_state to (old,new)_$obj_state as well.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_blend.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
&
> The calls to drm_atomic_get_existing_$obj_state should no longer be
> used, and converted over to these new calls.
>
> Changes since v1:
> - Expand commit message.
> - Deprecate get_existing_*_state functions in the documentation.
>
> Signed-off-by: Maarten Lankh
e dropped.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 7 ---
> drivers/gpu/drm/drm_plane_helper.c | 2 +-
> include/drm/drm_atomic_helper.h | 26 --
> 3 files changed,
const struct drm_plane_helper_funcs *funcs;
> + struct drm_plane_state *plane_state;
> +
> + /*
> + * This might be called before swapping when commit is
aborted,
> + * in which case we have to free the new state.
s/free/cleanup/
Apart from that,
Reviewed-by: La
Hi Daniel,
On Tuesday 14 Feb 2017 21:03:07 Daniel Vetter wrote:
> On Tue, Jan 17, 2017 at 01:55:50AM +0200, Laurent Pinchart wrote:
> > On Monday 16 Jan 2017 10:37:40 Maarten Lankhorst wrote:
> >
> > Could we please get a description ? Apart from that,
>
> Typed som
rm_atomic.c | 39 ++--
> drivers/gpu/drm/drm_atomic_helper.c | 377 ++--
> drivers/gpu/drm/drm_blend.c | 23 +--
> drivers/gpu/drm/i915/intel_display.c | 13 +-
> include/drm/drm_atomic.h | 180 -
> include/drm/drm_atomi
ommitting the state.
>
> Changes since v1:
> - Remove nonblock parameter for commit_duplicated_state.
> Changes since v2:
> - Use commit_duplicated_state for i915 load detection.
> - Add WARN_ON(old_state != obj->state) before swapping.
>
> Signed-off-by: Maarten La
Hi Daniel,
On Monday 23 Jan 2017 09:48:54 Daniel Vetter wrote:
> On Thu, Jan 19, 2017 at 12:56:29AM +0200, Laurent Pinchart wrote:
> > On Tuesday 17 Jan 2017 08:41:03 Maarten Lankhorst wrote:
> >> Op 17-01-17 om 00:11 schreef Laurent Pinchart:
> >>> On Monda
rm_dev_init() to note that driver->release()
> allows for arbitrary embedding.
>
> Signed-off-by: Chris Wilson
> Cc: Laurent Pinchart
> Cc: Daniel Vetter
> ---
> drivers/gpu/drm/drm_drv.c | 65 ++--
> include/drm/drm_drv.h
tch
that shows usage of the release callback in a driver ?
> Signed-off-by: Chris Wilson
> Cc: Laurent Pinchart
> Cc: Daniel Vetter
> ---
> drivers/gpu/drm/drm_drv.c | 56 ++--
> include/drm/drm_drv.h | 11 ++
> 2 files c
Hi Chris,
On Thursday 19 Jan 2017 11:20:37 Chris Wilson wrote:
> On Wed, Dec 14, 2016 at 12:04:38AM +0200, Laurent Pinchart wrote:
> > On Thursday 08 Dec 2016 08:18:40 Chris Wilson wrote:
> >> Some state is coupled into the device lifetime outside of the
> >> load/un
Hi Maarten,
On Tuesday 17 Jan 2017 08:41:03 Maarten Lankhorst wrote:
> Op 17-01-17 om 00:11 schreef Laurent Pinchart:
> > On Monday 16 Jan 2017 10:37:38 Maarten Lankhorst wrote:
> >> Add for_each_(old)(new)_(plane,connector,crtc)_in_state iterators to
> >> replace th
Hi Maarten,
On Wednesday 18 Jan 2017 15:49:56 Maarten Lankhorst wrote:
> Op 17-01-17 om 02:01 schreef Laurent Pinchart:
> > On Monday 16 Jan 2017 10:37:41 Maarten Lankhorst wrote:
> >> Signed-off-by: Maarten Lankhorst
> >> ---
> >>
> >&g
; include/drm/drm_atomic.h | 180 -
> include/drm/drm_atomic_helper.h | 2 +
> 6 files changed, 438 insertions(+), 196 deletions(-)
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
; if (!old_crtc_state->active ||
> !drm_atomic_crtc_needs_modeset(old_conn_state->crtc-
>state))
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Maarten,
Thank you for the patch.
On Monday 16 Jan 2017 10:37:44 Maarten Lankhorst wrote:
Could we please get a commit message ?
Apart from that,
Reviewed-by: Laurent Pinchart
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/drm_blend.c | 22 +++---
he new state before this patch ?
> const struct drm_plane_helper_funcs *plane_funcs;
>
> plane_funcs = plane->helper_private;
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
te for the given connector,
> + * or NULL if the connector is not part of the global atomic state.
> + */
> +static inline struct drm_connector_state *
> +drm_atomic_get_new_connector_state(struct drm_atomic_state *state,
> +struct drm_connector *c
ne_state, *new_plane_state;
> int i;
>
> - for_each_plane_in_state(old_state, plane, plane_state, i) {
> + for_each_oldnew_plane_in_state(old_state, plane, plane_state,
> new_plane_state, i) {
> const struct drm_plane_helper_funcs *funcs;
>
ivers/gpu/drm/drm_atomic_helper.c | 377 ++--
> drivers/gpu/drm/drm_blend.c | 23 +--
> drivers/gpu/drm/i915/intel_display.c | 13 +-
> include/drm/drm_atomic.h | 180 -
> include/drm/drm_atomic_helper.h |
Hi Maarten,
Thank you for the patch.
On Monday 16 Jan 2017 10:37:40 Maarten Lankhorst wrote:
Could we please get a description ? Apart from that,
Reviewed-by: Laurent Pinchart
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/drm_atomic.c | 16
> 1 fil
ed-off-by: Maarten Lankhorst
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_atomic.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 1c1cbf436717..18cdf2c956c6 100644
((plane) = (__state)->planes[__i].ptr, \
> + (old_plane_state) = (__state)->planes[__i].old_state, 1); \
> + (__i)++) \
> + for_each_if (plane)
> +
> +#define for_each_new_plane_in_state(__state, plane, new_plane_state, __i) \
> + for ((__i) = 0; \
> + (__i) < (__state)->dev->mode_config.num_total_plane && \
> + ((plane) = (__state)->planes[__i].ptr, \
> + (new_plane_state) = (__state)->planes[__i].new_state, 1); \
> + (__i)++) \
> + for_each_if (plane)
> +
> /**
> * drm_atomic_crtc_needs_modeset - compute combined modeset need
> * @state: &drm_crtc_state for the CRTC
> diff --git a/include/drm/drm_atomic_helper.h
> b/include/drm/drm_atomic_helper.h index 9afcd3810785..2c4549e98c16 100644
> --- a/include/drm/drm_atomic_helper.h
> +++ b/include/drm/drm_atomic_helper.h
> @@ -105,6 +105,8 @@ int __drm_atomic_helper_set_config(struct drm_mode_set
> *set, int drm_atomic_helper_disable_all(struct drm_device *dev,
> struct drm_modeset_acquire_ctx *ctx);
> struct drm_atomic_state *drm_atomic_helper_suspend(struct drm_device *dev);
> +int drm_atomic_helper_commit_duplicated_state(struct drm_atomic_state
> *state,
> + struct drm_modeset_acquire_ctx
> *ctx);
> int drm_atomic_helper_resume(struct drm_device *dev,
>struct drm_atomic_state *state);
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
t;planes[__i].old_state, 1); \
> + (__i)++) \
> + for_each_if (plane)
> +
> +#define for_each_new_plane_in_state(__state, plane, new_plane_state, __i) \
> + for ((__i) = 0;
tables (where the
> per-member kerneldoc tends to be long).
>
> Also some minor drive-by polish where it makes sense, I read a lot
> of docs ...
>
> Cc: Laurent Pinchart
> Cc: Jani Nikula
> Cc: Chris Wilson
> Signed-off-by: Daniel Vetter
>
7;s a KMS feature, only
> used by the fbdev deferred_io support to implement flushing/upload.
>
> Cc: Noralf Trønnes
> Cc: Laurent Pinchart
> Signed-off-by: Daniel Vetter
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 58 ++
| 1 +
> drivers/gpu/drm/drm_drv.c | 26 ++
> drivers/gpu/drm/drmfs.c| 566 ++
> drivers/gpu/drm/i915/i915_guc_submission.c | 33 +-
> include/drm/drm_drv.h | 3 +
> include/drm/drmfs.h| 77
101 - 200 of 285 matches
Mail list logo
