ct drm_mode_fb_cmd2
*mode_cmd);
>
> /**
> + * @get_format_info:
> + *
> + * Allows a driver to return custom format information for special
> + * fb layouts (eg. ones with auxiliary compresssion control planes).
> + *
> + * RETURNS:
&
Hi Jani,
On Thursday 10 Nov 2016 12:30:09 Jani Nikula wrote:
> On Thu, 10 Nov 2016, Laurent Pinchart wrote:
> > On Wednesday 09 Nov 2016 16:59:31 Eric Engestrom wrote:
> >> On Wednesday, 2016-11-09 14:13:40 +0100, Daniel Vetter wrote:
> >>> On Wed, Nov 9, 2016 at
he various trees and branches get merged?
> I googled a bit and found this doc [4] by Jani, but it doesn't mention
> drm-misc for instance, so I'm not sure how up-to-date and
> non-intel-specific it is.
>
> Looking at this page, something just occurr
Hi Daniel,
On Tuesday 18 Oct 2016 09:36:23 Daniel Vetter wrote:
> On Tue, Oct 18, 2016 at 01:38:05AM +0300, Laurent Pinchart wrote:
> > On Friday 22 Jul 2016 16:43:13 ville.syrj...@linux.intel.com wrote:
> >> From: Ville Syrjälä <ville.syrj...@linux.intel.com>
> >>
ition in the connected _framebuffer.
>*/
> @@ -2960,8 +2955,6 @@ extern int drm_mode_plane_set_obj_prop(struct
> drm_plane *plane, struct drm_property *property,
> uint64_t value);
>
> -extern struct drm_property *drm_mode_create_rotation_pr
an
> move drm_connector_register_all() to drm_dev_register() and not suffer
> from any backwards compatibility issues with drivers not following the
> more rigorous init ordering.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vet
top of mediatek.
>
> Cc: Philipp Zabel <p.za...@pengutronix.de>
> Cc: Maxime Ripard <maxime.rip...@free-electrons.com>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Emil Velikov <emil.l.veli...@gmail.com>
> Signed-off-by: Daniel Vetter <
Hi Daniel,
On Friday 03 Jun 2016 11:45:56 Daniel Vetter wrote:
> On Fri, Jun 3, 2016 at 11:40 AM, Laurent Pinchart wrote:
> > On Friday 03 Jun 2016 08:55:36 Daniel Vetter wrote:
> >> On Fri, Jun 03, 2016 at 01:54:44AM +0300, Laurent Pinchart wrote:
> >>> On Mond
Hi Daniel,
On Friday 03 Jun 2016 08:55:36 Daniel Vetter wrote:
> On Fri, Jun 03, 2016 at 01:54:44AM +0300, Laurent Pinchart wrote:
> > On Monday 30 May 2016 16:54:10 Daniel Vetter wrote:
> >> On Mon, May 30, 2016 at 11:58:27AM +0200, Maarten Lankhorst wrote:
> >>>
Hi Daniel,
On Monday 30 May 2016 16:54:10 Daniel Vetter wrote:
> On Mon, May 30, 2016 at 11:58:27AM +0200, Maarten Lankhorst wrote:
> > Op 30-05-16 om 11:18 schreef Laurent Pinchart:
> >> Hi Daniel,
> >>
> >> Thank you for the patch.
> >>
>
Hi Daniel,
Thank you for the patch.
On Thursday 02 Jun 2016 00:06:27 Daniel Vetter wrote:
> We want to hide drm_atomic_state internals better.
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Ac
Hi Daniel,
Thank you for the patch.
On Thursday 02 Jun 2016 00:06:29 Daniel Vetter wrote:
> We want to hide drm_atomic_stat internals a bit better.
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Tomi Valkeinen <tomi.valkei...@ti.com>
> S
->best_encoder() is
> + * NULL we fallback to the default drm_atomic_helper_best_encoder()
> + * helper.
> + */
> + if (fb_helper->dev->mode_config.funcs->atomic_commit &&
> + !connector_funcs->best_encoder)
> + encoder = drm
is assigned but not used anymore, you can
remove it.
With that fixed,
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> -}
> -
> static const struct drm_connector_funcs omap_connector_funcs = {
> .dpms = drm_atomic_helper_connector_dpms,
> .re
emove
rcon->encoder = renc;
from rcar_du_vga_connector_init(), it's not needed anymore. The same code in
rcar_du_hdmi_connector_init() has to stay for now though, as it's used to
locate the slave encoder in the HDMI support code. That should change when the
driver will be converted to
->planes[i])
> - continue;
> -
> - plane = to_rcar_plane(state->planes[i]);
> - plane_state = to_rcar_plane_state(state->plane_states[i]);
> + plane = to_rcar_plane(drm_plane);
> + plane_state = to_rca
.com>
> Cc: Liviu Dudau <liviu.du...@arm.com>
> Cc: Russell King <rmk+ker...@arm.linux.org.uk>
> Cc: Thierry Reding <thierry.red...@gmail.com>
> Cc: Eric Anholt <e...@anholt.net>
> Cc: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
&
Hi Daniel,
Thank you for the patch.
s/crtc/connector/ in the subject (I've just realized that the same comment
applies to patch 2/3, with s/connector/plane/ as well).
Apart from that,
Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
On Friday 06 May 2016 10:32:30 Daniel
thierry.red...@gmail.com>
> Cc: Eric Anholt <e...@anholt.net>
> Cc: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> Cc: Inki Dae <inki@samsung.com>
> Cc: Tomi Valkeinen <tomi.valkei...@ti.com>
> Cc: Mark Yao <mark@rock-chi
b/drivers/gpu/drm/drm_crtc.c
> index 1e7692a10c83..cde9b5af7553 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -897,7 +897,7 @@ int drm_connector_init(struct drm_device *dev,
> struct ida *connector_ida =
> _connector_enum_list[connector_type].ida;
>
Hi Maarten,
Thank you for the patch.
On Tuesday 26 Apr 2016 16:11:40 Maarten Lankhorst wrote:
> The async name is deprecated and should be changed to nonblocking.
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Maarten Lankhorst <maarten.lank
even
> easier to
> + * debug. This can be done by setting the drm_kms_helper.fbdev_emulation=0
> + * kernel cmdline option.
> + *
> * RETURNS:
> * Zero if everything went ok, nonzero otherwise.
> */
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
gt; drm_vblank_put.
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Acked-by: Daniel Stone <dani...@collabora.com>
> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Reviewed-by: Laurent
Deucher <alexander.deuc...@amd.com>
> Cc: Rob Clark <robdcl...@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
> drivers/gpu/drm/drm_atomic.c | 44 ---
ing of the kerneldoc and split out vblank cleanup (Laurent).
>
> Cc: Alex Deucher <alexander.deuc...@amd.com>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Acked-by: Daniel Stone <dan
homas Hellstrom <thellst...@vmware.com>
> Cc: Inki Dae <inki@samsung.com>
> Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
> drivers/gpu/drm/drm_fops.c | 42 ++
Hi Daniel,
On Monday 11 January 2016 14:51:46 Daniel Stone wrote:
> On 10 January 2016 at 23:48, Laurent Pinchart wrote:
> > On Saturday 09 January 2016 14:28:46 Daniel Vetter wrote:
> >> @@ -353,18 +354,16 @@ static void drm_events_release(struct drm_fi
v3: Remove unused flags (Tomi).
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Tomi Valkeinen <tomi.valkei...@ti.com>
> Acked-by: Daniel Stone <dani...@collabora.com>
> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>
> Sign
to me at the moment :-) After closing the "[PATCH] drm: Clean
up pending events in the core" discussion (and assuming the conclusion is that
is works),
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.
Hi Daniel,
Thank you for the patch.
On Sunday 10 January 2016 23:26:06 Daniel Vetter wrote:
> Again since the drm core takes care of event unlinking/disarming this
> is now just needless code.
>
> v2: Fixup misplaced hunk.
>
> Cc: Laurent Pinchart <laurent.pinch...@ideas
@@ struct drm_ioctl_desc {
> struct drm_pending_event {
> struct drm_event *event;
> struct list_head link;
> + struct list_head pending_link;
> struct drm_file *file_priv;
> pid_t pid; /* pid of requester, no guarantee it's valid by the time
> we deliver the event, for tracing only */
> @@ -346,6 +347,7 @@ struct drm_file {
> struct list_head blobs;
>
> wait_queue_head_t event_wait;
> + struct list_head pending_event_list;
> struct list_head event_list;
> int event_space;
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Daniel,
Thank you for the patch.
On Friday 08 January 2016 21:36:47 Daniel Vetter wrote:
> Again since the core takes care of this we can remove them. While at
> it also remove the postclose hook, it's empty.
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
&g
gt;
> > v2: Spelling fixes from Pierre, Laurent and Jani.
>
> Nah, you ignored my comment about "these documentations use American
> English". :/
Isn't documentation uncountable when meaning information recorded in a
document ?
--
Regards,
Laurent Pinchart
_
On Wednesday 09 December 2015 16:17:47 Jani Nikula wrote:
> On Wed, 09 Dec 2015, Laurent Pinchart <laurent.pinch...@ideasonboard.com>
wrote:
> > On Wednesday 09 December 2015 13:21:09 Jani Nikula wrote:
> >> On Wed, 09 Dec 2015, Daniel Vetter <daniel.vet...@ffwll.ch&
: Either in the comment for the lock explaining what it
> > + protects, or data fields need a note about which lock protects
> > them, or
> > + both.
> > +
> > +
> > + Functions which have a non-void return value should
> > have a
> > +
more ;-)
>
> v2: Reword the deprecation note for ->load a bit, using Laurent's
> suggestion as an example (but making the wording a bit stronger even).
> Fix spelling in commit message.
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: David Herrmann <dh.h
sting drivers. Using that callback is depracated
s/depracated/deprecated/
> and
> + * when using drm_dev_alloc() and drm_dev_regiter() directly actually
s/regiter/register/
> unsafe:
> + * Becuase of backwards compatibility needs ->load() is only called _after_
> the
s/Becuase/Because/
> + * device instance is already registered.
> + *
This could be stated more clearly. I'd write
NOTE: To ensure backward compatibility with existing drivers that still rely
on the deprecated .load() method this function calls the .load() method after
registering the device nodes, creating race conditions. Usage of the .load()
(and .unload()) methods is deprecated, drivers should perform device
initialization before calling drm_dev_register().
> * RETURNS:
> * 0 on success, negative error code on failure.
> */
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
er a plane gets a new CRTC assigned while
> still in active use out of this patch.
>
> v4: Rebase over exynos changes.
>
> Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
> Cc: Thierry Reding <tred...@nvidia.com>
> Cc: Laurent Pinchart <
() and for the commit callback with
+ * drm_atomic_helper_commit(). But the individual stages and callbacks are
expose
While at it, could you fix the typo here with s/expose/exposed/ ?
Apart from that,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
* to allow drivers to mix and match and e.g
that ...
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reported-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Signed-off-by: Daniel Vetter daniel.vet...@intel.com
This gets rid of the warning at driver load time with the rcar-du-drm driver.
Tested-by: Laurent Pinchart
);
\
+ connector-head != ((dev)-mode_config.connector_list);
\
+ connector = list_next_entry(connector, head))
#define drm_for_each_encoder(encoder, dev) \
list_for_each_entry(encoder, (dev)-mode_config.encoder_list, head)
--
Regards,
Laurent
Dae inki@samsung.com
Cc: Matt Roper matthew.d.ro...@intel.com
Signed-off-by: Daniel Vetter daniel.vet...@intel.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Tested-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
(with the ongoing omapdrm atomic update conversion work
these callbacks useless for drivers support runtime PM, so make them
optional. Again motivated by discussions with Laurent.
Cc: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Signed-off-by: Daniel Vetter daniel.vet...@intel.com
I think we should go one step further and remove
to something more descriptive and update the kerneldoc
a bit. Motivated in a discussion with Laurent about how to restore
plane state for dpms for drivers with runtime pm.
Cc: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Signed-off-by: Daniel Vetter daniel.vet...@intel.com
Acked
Hi Daniel,
On Sunday 22 February 2015 19:53:23 Laurent Pinchart wrote:
On Sunday 22 February 2015 12:24:20 Daniel Vetter wrote:
With runtime PM the hw might still be off while doing the -mode_set
callbacks - runtime PM get/put should only happen in the
enable/disable hooks to properly
of
that is required.
v2: Clarify the code flow slightly as suggested by Ville.
Cc: Ville Syrjälä ville.syrj...@linux.intel.com
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Imre Deak imre.d...@intel.com
Reviewed-by: Imre Deak imre.d...@intel.com
Signed-off-by: Daniel Vetter daniel.vet
correct ? I think I like this solution better,
and it could be conditioned by a driver flag if we don't want to audit all
drivers for possible breakages.
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Signed-off-by: Daniel Vetter daniel.vet...@intel.com
---
drivers/gpu/drm/drm_irq.c
, yay!
Noticed while trying to answer questions Laurent had about how the new
atomic helpers work.
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Signed-off-by: Daniel Vetter daniel.vet...@intel.com
---
drivers/gpu/drm/i915/i915_irq.c | 52 --
1
On Monday 04 August 2014 09:30:04 Daniel Vetter wrote:
On Fri, Aug 01, 2014 at 02:58:21PM +0200, Laurent Pinchart wrote:
On Thursday 31 July 2014 15:16:21 Randy Dunlap wrote:
On 05/12/14 11:04, Randy Dunlap wrote:
On 05/12/2014 08:54 AM, Daniel Vetter wrote:
On Mon, May 12, 2014 at 08:23
preferred.
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Daniel,
Thank you for the patch.
On Thursday 15 May 2014 15:00:08 Daniel Vetter wrote:
Leftover from the old days of ums and should be used any longer. Since
commit 29935554b384b1b3a7377d6f0b03b21d18a61683
Author: Laurent Pinchart laurent.pinch...@ideasonboard.com
Date: Wed May 30 00
.
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Sagar,
On Wednesday 12 March 2014 16:46:05 Sagar Arun Kamble wrote:
On Mon, 2014-03-10 at 15:36 +0100, Laurent Pinchart wrote:
On Monday 10 March 2014 06:21:49 Daniel Vetter wrote:
On Wed, Mar 5, 2014 at 11:56 AM, sagar.a.kam...@intel.com wrote:
+table border=1 cellpadding=0
...@ffwll.ch
Cc: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Cc: David Herrmann dh.herrm...@gmail.com
Cc: Alex Deucher alexander.deuc...@amd.com
Cc: Ville Syrjälä ville.syrj...@linux.intel.com
Cc: Sagar Kamble sagar.a.kam...@intel.com
Cc: Purushothaman, Vijay A vijay.a.purushotha
Airlie airl...@redhat.com
Cc: Daniel Vetter daniel.vet...@ffwll.ch
Cc: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Cc: David Herrmann dh.herrm...@gmail.com
Cc: Alex Deucher alexander.deuc...@amd.com
Cc: Ville Syrjälä ville.syrj...@linux.intel.com
Cc: Sagar Kamble sagar.a.kam
Hi Sagar,
Thank you for the patch.
On Saturday 08 March 2014 13:51:19 sagar.a.kam...@intel.com wrote:
From: Sagar Kamble sagar.a.kam...@intel.com
Cc: Rob Landley r...@landley.net
Cc: Dave Airlie airl...@redhat.com
Cc: Daniel Vetter daniel.vet...@ffwll.ch
Cc: Laurent Pinchart
for kms drivers which don't use GEM
for backing storage, but it does decently simplify matters for gem
drivers.
Cc: Inki Dae inki@samsung.com
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Intel Graphics Development intel-gfx@lists.freedesktop.org
Cc: Ben Skeggs skeg
,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hello,
On Wednesday 08 May 2013 15:52:10 Laurent Pinchart wrote:
On Wednesday 08 May 2013 16:40:54 ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
There's a bunch of unused members inside drm_plane, bloating the size of
the structure needlessly
.
+ *
+ * Used when the plane's current framebuffer is destroyed,
+ * and when restoring fbdev mode.
+ */
void drm_plane_force_disable(struct drm_plane *plane)
{
int ret;
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx
drm_plane *plane);
extern void drm_encoder_cleanup(struct drm_encoder *encoder);
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
this new function in the struct drm_fb_helper_funcs
kerneldoc block ?
};
struct drm_fb_helper_connector {
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
-by: Ville Syrjälä ville.syrj...@linux.intel.com
Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/drm_crtc.c | 2 +-
include/drm/drm_crtc.h | 11 ---
2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b
() that can take care
of such details.
Initially just plug in drm_fb_helper_restore_fbdev_mode for all
drivers.
v2: Add kernel-doc for the new hook
Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers
if rectangle @dst is still visible after being clipped,
+ * %false otherwise
+ */
Otherwise,
Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http
) 0;
+}
+
+bool drm_rect_intersect(struct drm_rect *r, const struct drm_rect *clip);
+bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst,
+ const struct drm_rect *clip,
+ int hscale, int vscale);
+
+#endif
--
Regards,
Laurent
Hi Ville,
On Thursday 04 April 2013 22:52:37 Ville Syrjälä wrote:
On Thu, Apr 04, 2013 at 06:38:15PM +0200, Laurent Pinchart wrote:
On Wednesday 27 March 2013 17:46:22 ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
struct drm_rect represents
looked at
those kerneldoc headers that actually resulted in a complaint from
the kerneldoc parser tool.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
After fixing the small mistake below,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
Documentation/DocBook
is quiescent
+ * @address: i2c target address for the currently ongoing transfer
+ * @aux_ch: driver callback to transfer a single byte of the i2c payload
+ */
struct i2c_algo_dp_aux_data {
bool running;
u16 address;
--
Regards,
Laurent Pinchart
);
+extern void drm_helper_move_panel_connectors_to_head(struct drm_device *);
+
extern int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb,
struct drm_mode_fb_cmd2 *mode_cmd);
--
Regards,
Laurent Pinchart
(-)
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
|4 +-
kernel/time/timekeeping.c |2 +-
13 files changed, 113 insertions(+), 61 deletions(-)
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman
201 - 272 of 272 matches
Mail list logo
