Re: [Intel-gfx] [PATCH 2/3] drm/scheduler: Fix elapsed_ns kernel-doc error

2023-02-03 Thread Lucas Stach
Am Freitag, dem 03.02.2023 um 17:02 +0700 schrieb Bagas Sanjaya: > Stephen Rothwell reported htmldocs warnings: > > include/drm/gpu_scheduler.h:232: warning: Incorrect use of kernel-doc format: > * @elapsed_ns > include/drm/gpu_scheduler.h:238: warning: Function parameter or member > 'e

Re: [Intel-gfx] [PATCH 3/7] drm/etnaviv: Don't break exclusive fence ordering

2021-07-07 Thread Lucas Stach
Am Mittwoch, dem 07.07.2021 um 13:37 +0200 schrieb Daniel Vetter: > On Wed, Jul 7, 2021 at 10:54 AM Lucas Stach wrote: > > > > Hi Daniel, > > > > I'm feeling like I miss a ton of context here, so some maybe dumb > > questions/remarks below. > > &g

Re: [Intel-gfx] [PATCH 3/7] drm/etnaviv: Don't break exclusive fence ordering

2021-07-07 Thread Lucas Stach
ption is the fence import ioctl from Jason: > > https://lore.kernel.org/dri-devel/20210610210925.642582-7-ja...@jlekstrand.net/ Sorry, but why is the fence import ioctl a alternative to the fix proposed in this patch? > > Signed-off-by: Daniel Vetter > Cc: Lucas Stach

Re: [Intel-gfx] [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default

2021-05-21 Thread Lucas Stach
Am Freitag, dem 21.05.2021 um 11:09 +0200 schrieb Daniel Vetter: > No need to set it explicitly. > > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach For dcss and imx-drm: Acked-by: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengu

Re: [Intel-gfx] [PATCH 02/11] drm/panfrost: Remove sched_lock

2021-05-21 Thread Lucas Stach
Am Freitag, dem 21.05.2021 um 11:09 +0200 schrieb Daniel Vetter: > Scheduler takes care of its own locking, dont worry. For everything else > there's reservation locking on each bo. > > So seems to be entirely redundnant and just a bit in the way. I haven't read all the surrounding code, but this

Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Lucas Stach
Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > > Since > > > > > > commit 890880ddfdbe25608317086

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Lucas Stach
M_FORMAT_MOD_LINEAR, so maybe that's where some of the confusion about needing to specify the modifier list comes from. > Now that this is all done consistently across all drivers, document > the rules and enforce it in the drm core. This clarification looks good to me. Reviewed-by:

Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Lucas Stach
parate drivers. Maybe we should move imx-drm into its own ipuv3 directory one day to make this more clear. Change is still correct, though. Reviewed-by: Lucas Stach > Signed-off-by: Daniel Vetter > Cc: Philipp Zabel > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-15 Thread Lucas Stach
Am Samstag, dem 13.02.2021 um 18:40 +0100 schrieb Pavel Machek: > Hi! > > > Userspace has discovered the functionality offered by SYS_kcmp and has > > started to depend upon it. In particular, Mesa uses SYS_kcmp for > > os_same_file_description() in order to identify when two fd (e.g. device > > o

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Lucas Stach
Drewry > Cc: Andrew Morton > Cc: Dave Airlie > Cc: Daniel Vetter > Cc: Lucas Stach > --- >  init/Kconfig | 11 +++ >  kernel/Makefile | 2 +- >  tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- >

Re: [Intel-gfx] [PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp

2021-02-05 Thread Lucas Stach
Am Freitag, dem 05.02.2021 um 16:59 +0100 schrieb Daniel Vetter: > On Fri, Feb 05, 2021 at 04:58:32PM +0100, Daniel Vetter wrote: > > On Fri, Feb 05, 2021 at 01:03:07PM +, Chris Wilson wrote: > > > gallium (iris) depends on os_same_file_description() to disambiguate > > > screens and so avoid i

Re: [Intel-gfx] [PATCH v3 03/22] drm/etnaviv: Introduce GEM object functions

2020-09-23 Thread Lucas Stach
which is non-trivial to convert. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Daniel Vetter Acked-by: Lucas Stach > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 - > drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 - > drivers/gpu/drm/etnaviv/etnaviv_gem.c |

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Lucas Stach
On Fr, 2020-02-28 at 10:47 +0100, Daniel Vetter wrote: > On Fri, Feb 28, 2020 at 10:29 AM Erik Faye-Lund > wrote: > > On Fri, 2020-02-28 at 13:37 +1000, Dave Airlie wrote: > > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter > > > wrote: > > > > Hi all, > > > > > > > > You might have read the short

Re: [Intel-gfx] [PATCH 3/9] drm/etnaviv: use drm_debug_enabled() to check for debug categories

2019-09-13 Thread Lucas Stach
On Fr, 2019-09-13 at 14:51 +0300, Jani Nikula wrote: > Allow better abstraction of the drm_debug global variable in the > future. No functional changes. > > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc: etna...@lists.freedesktop.org > Signed-off-by

Re: [Intel-gfx] [PATCH 13/59] drm/etnaviv: Drop drm_gem_prime_export/import

2019-06-25 Thread Lucas Stach
Am Freitag, den 14.06.2019, 22:35 +0200 schrieb Daniel Vetter: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Lucas Stach > Cc: Russell King > C

Re: [Intel-gfx] [PATCH 42/59] drm/etnaviv: Drop resv argument from etnaviv_gem_new_impl

2019-06-25 Thread Lucas Stach
Am Freitag, den 14.06.2019, 22:35 +0200 schrieb Daniel Vetter: > Only user was the prime import, and drm_prime.c takes care of that > now. > > > Signed-off-by: Daniel Vetter > > Cc: Lucas Stach > > Cc: Russell King > > Cc: Christian Gmeiner > Cc: etna..

Re: [Intel-gfx] [PATCH 08/17] drm/etnaviv: Remove unecessary dma_fence_ops

2018-05-03 Thread Lucas Stach
Am Freitag, den 27.04.2018, 08:17 +0200 schrieb Daniel Vetter: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > > Signed-off-by: Daniel Vetter > > Cc: Lucas Stach > > Cc: Russell King > >

Re: [Intel-gfx] [PATCH 3/3] drm/etnaviv: add thermal dependency

2017-08-08 Thread Lucas Stach
Hi Arnd, Am Mittwoch, den 26.07.2017, 15:53 +0200 schrieb Arnd Bergmann: > When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is > built-in, we get a link error: > > drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_bind': > etnaviv_gpu.c:(.text.etnaviv_gpu_bind+0x34):

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH] dma-fence: Don't BUG_ON when not absolutely needed

2017-07-20 Thread Lucas Stach
Am Donnerstag, den 20.07.2017, 14:51 +0200 schrieb Daniel Vetter: > It makes debugging a massive pain. It is also considered very bad style to BUG the kernel on anything other than filesystem eating catastrophic failures. Reviewed-by: Lucas Stach > Signed-off-by: Daniel Vetter >

Re: [Intel-gfx] [PATCH 18/24] drm/etnaviv: switch to postclose

2017-03-09 Thread Lucas Stach
Am Mittwoch, den 08.03.2017, 19:15 +0100 schrieb Daniel Vetter: > On Wed, Mar 08, 2017 at 05:09:45PM +0100, Lucas Stach wrote: > > Am Mittwoch, den 08.03.2017, 15:12 +0100 schrieb Daniel Vetter: > > > I didn't spot anything that would require ordering here (well not >

Re: [Intel-gfx] [PATCH 18/24] drm/etnaviv: switch to postclose

2017-03-08 Thread Lucas Stach
Am Mittwoch, den 08.03.2017, 15:12 +0100 schrieb Daniel Vetter: > I didn't spot anything that would require ordering here (well not > anywhere else either), and I'm trying to unify at least modern > drivers > on one close hook. > > Cc: Lucas Stach > Cc: Russel

Re: [Intel-gfx] [PATCH v5] drm: Improve drm_mm search (and fix topdown allocation) with rbtrees

2017-02-03 Thread Lucas Stach
önig" > Cc: David Airlie > Cc: Russell King > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Sean Paul > Cc: Lucas Stach > Cc: Christian Gmeiner > Cc: Rob Clark > Cc: Thierry Reding > Cc: Stephen Warren > Cc: Alexandre Courbot > Cc: Eric Anholt > Cc: S

Re: [Intel-gfx] [PATCH v4 1/2] drm: Improve drm_mm search (and fix topdown allocation) with rbtrees

2017-02-02 Thread Lucas Stach
önig" > Cc: David Airlie > Cc: Russell King > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Sean Paul > Cc: Lucas Stach > Cc: Christian Gmeiner > Cc: Rob Clark > Cc: Thierry Reding > Cc: Stephen Warren > Cc: Alexandre Courbot > Cc: Eric Anholt >

Re: [Intel-gfx] [PATCH 02/11] drm/etnaviv: Remove manual call to reservation_object_test_signaled_rcu before wait

2016-10-10 Thread Lucas Stach
ntially blocking wait. > >> > >> Signed-off-by: Chris Wilson > >> Cc: Lucas Stach > >> Cc: Russell King > >> Cc: Christian Gmeiner > > > > Reviewed-by: Daniel Vetter > > > Could you please let me know if this is in your tree already,

Re: [Intel-gfx] [PATCH 16/35] drm/etnaviv: Use lockless gem BO free callback

2016-04-27 Thread Lucas Stach
Am Dienstag, den 26.04.2016, 19:29 +0200 schrieb Daniel Vetter: > No dev->struct_mutex anywhere to be seen. > > Cc: Christian Gmeiner > Cc: Russell King > Cc: Lucas Stach > Signed-off-by: Daniel Vetter Acked-by: Lucas Stach > --- > drivers/gpu/drm/etnaviv/etn

Re: [Intel-gfx] [PATCH 09/35] drm/gem: support BO freeing without dev->struct_mutex

2016-04-27 Thread Lucas Stach
igned-off-by: Daniel Vetter Two mostly cosmetic comments below, otherwise looks good: Reviewed-by: Lucas Stach > --- > drivers/gpu/drm/drm_gem.c | 64 > ++- > include/drm/drmP.h| 12 - > include/drm/drm_gem.h | 45 +