Re: [Intel-gfx] [PATCH v2] kernel-doc: rename the kernel-doc directive 'functions' to 'identifiers'

Am 29.10.19 um 01:31 schrieb Changbin Du: But is it, really? I agree with Jon about the distinction between None and '' being confusing. Here python is different from C. Both empty string and None are False in python. Note such condition is common in python. The one is a empty string

Re: [Intel-gfx] [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c

> Am 12.12.2017 um 16:23 schrieb Daniel Vetter : > >>> Thanks for your patch, but similar fix is already merged here [1] >>> >>> Michal >>> >>> [1] >>> https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7 >> >> >> Thanks for pointing out.

Re: [Intel-gfx] [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c

> Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko <michal.wajdec...@intel.com>: > > On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser <markus.hei...@darmarit.de> > wrote: > >> With commit d9e2e0143c the 'GuC-specific firmware loader' doc >> section was

[Intel-gfx] [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c

to intel_guc_fw.c Signed-off-by: Markus Heiser <markus.hei...@darmarit.de> --- Documentation/gpu/i915.rst | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 2e7ee03..e94d3ac 100644 --- a/Documentation/gpu/i9

Re: [Intel-gfx] [PATCH 06/11] dma-buf: Introduce fence_get_rcu_safe()

Am 23.09.2016 um 14:59 schrieb Daniel Vetter : >> >> /** >> - * fence_put - decreases refcount of the fence >> - * @fence: [in]fence to reduce refcount of >> + * fence_get_rcu_safe - acquire a reference to an RCU tracked fence >> + * @fence: [in]pointer to fence to

Re: [Intel-gfx] [PATCH 01/20] drm/doc: Fix more kerneldoc/sphinx warnings

Am 11.08.2016 um 10:23 schrieb Jani Nikula : > On Thu, 11 Aug 2016, Jani Nikula wrote: >> On Tue, 09 Aug 2016, Daniel Vetter wrote: >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c >>>

Re: [Intel-gfx] [PATCH 1/2] doc/sphinx: Enable keep_warnings

Am 20.07.2016 um 13:27 schrieb Daniel Vetter <daniel.vet...@ffwll.ch>: > On Wed, Jul 20, 2016 at 12:55 PM, Markus Heiser > <markus.hei...@darmarit.de> wrote: >> Hi Daniel, hi Mauro, >> >> Am 19.07.2016 um 17:32 schrieb Daniel Vetter <daniel.vet...@ffwll.ch

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Fix more kerneldoc/sphinx warnings

tovers I could only track down using keep_warnings = >>> True. For some of them we might want to update our style guide on how >>> to reference structures and constants, not sure ... >>> >>> Cc: Markus Heiser <markus.hei...@darmarit.de> >>> Cc: Jonat

Re: [Intel-gfx] [PATCH 1/2] doc/sphinx: Enable keep_warnings

Hi Daniel, hi Mauro, Am 19.07.2016 um 17:32 schrieb Daniel Vetter <daniel.vet...@ffwll.ch>: > On Tue, Jul 19, 2016 at 5:25 PM, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: >> On Tue, Jul 19, 2016 at 4:59 PM, Markus Heiser >> <markus.hei...@darmarit.de> wrote

Re: [Intel-gfx] [PATCH 1/2] doc/sphinx: Enable keep_warnings

f you touch one of the source, e.g. the drivers/gpu/drm/drm_crtc.c or the rst-file where the drm_crtc.c is referred by a kernel-doc directive .. these dependence sometimes confuse me .. when I missed log messages, I clean the cache e.g. by target cleandocs. -- Markus -- > > Cc: Markus