Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: Add smem fallback allocation for dpt

On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: > > Add fallback smem allocation for dpt if stolen memory > allocation failed. > > Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't leak lmem mapping in vma_evict

On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: > > Don't leak lmem mapping in vma_evict, move __i915_vma_iounmap outside > i915_vma_is_map_and_fenceable > > Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Update i915 uapi documentation

On 10/06/2022 08:07, Niranjana Vishwanathapura wrote: Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld This one looks to be standalone. If no objections should we go

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

On 10/06/2022 11:16, Tvrtko Ursulin wrote: On 09/06/2022 19:53, Niranjana Vishwanathapura wrote: On Thu, Jun 09, 2022 at 09:36:48AM +0100, Matthew Auld wrote: On 08/06/2022 22:32, Niranjana Vishwanathapura wrote: On Wed, Jun 08, 2022 at 10:12:05AM +0100, Matthew Auld wrote: On 08/06/2022 08

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

On 08/06/2022 22:32, Niranjana Vishwanathapura wrote: On Wed, Jun 08, 2022 at 10:12:05AM +0100, Matthew Auld wrote: On 08/06/2022 08:17, Tvrtko Ursulin wrote: On 07/06/2022 20:37, Niranjana Vishwanathapura wrote: On Tue, Jun 07, 2022 at 11:27:14AM +0100, Tvrtko Ursulin wrote: On 17/05/2022

Re: [Intel-gfx] [RFC v3 2/3] drm/i915: Update i915 uapi documentation

/** @ctx_id: Id of the created context (output) */ > + __u32 ctx_id; > + > + /** > +* @flags: Supported flags are, are: > +* > +* I915_CONTEXT_CREATE_FLAGS_USE_EXTENSIONS: > +* > +* Extensions may be appended to this structur

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

On 08/06/2022 08:17, Tvrtko Ursulin wrote: On 07/06/2022 20:37, Niranjana Vishwanathapura wrote: On Tue, Jun 07, 2022 at 11:27:14AM +0100, Tvrtko Ursulin wrote: On 17/05/2022 19:32, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Ensure proper kernel-doc formatting

Re: [Intel-gfx] [RFC PATCH v2 0/1] Replace shmem memory region and object backend

On Fri, 27 May 2022 at 16:37, Adrian Larumbe wrote: > > On 18.05.2022 16:00, Matthew Auld wrote: > > On Tue, 17 May 2022 at 21:45, Adrian Larumbe > > wrote: > > > > > > This patch is a second attempt at eliminating the old shmem memory region > > &g

Re: [Intel-gfx] [PATCH 03/10] drm/i915/uapi: expose the avail tracking

On 26/05/2022 09:33, Tvrtko Ursulin wrote: On 26/05/2022 09:10, Matthew Auld wrote: On 26/05/2022 08:58, Tvrtko Ursulin wrote: On 25/05/2022 19:43, Matthew Auld wrote: Vulkan would like to have a rough measure of how much device memory can in theory be allocated. Also add

Re: [Intel-gfx] [PATCH v6] drm/i915: Individualize fences before adding to dma_resv obj

On 27/05/2022 11:24, Das, Nirmoy wrote: On 5/27/2022 11:55 AM, Matthew Auld wrote: On 27/05/2022 10:46, Das, Nirmoy wrote: On 5/26/2022 11:27 AM, Matthew Auld wrote: On 25/05/2022 10:59, Nirmoy Das wrote: _i915_vma_move_to_active() can receive > 1 fences for multiple batch buff

Re: [Intel-gfx] [PATCH v6] drm/i915: Individualize fences before adding to dma_resv obj

On 27/05/2022 10:46, Das, Nirmoy wrote: On 5/26/2022 11:27 AM, Matthew Auld wrote: On 25/05/2022 10:59, Nirmoy Das wrote: _i915_vma_move_to_active() can receive > 1 fences for multiple batch buffers submission. Because dma_resv_add_fence() can only accept one fence at a time, cha

Re: [Intel-gfx] [PATCH v6] drm/i915: Individualize fences before adding to dma_resv obj

ces. v2: make sure to reserve enough fence slots before adding. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5614 Signed-off-by: Nirmoy Das Reviewed-by: Matthew Auld Do we need Fixes: ? --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 3 +- drivers/gpu/drm/i915/i915_vm

Re: [Intel-gfx] [PATCH 03/10] drm/i915/uapi: expose the avail tracking

On 26/05/2022 08:58, Tvrtko Ursulin wrote: On 25/05/2022 19:43, Matthew Auld wrote: Vulkan would like to have a rough measure of how much device memory can in theory be allocated. Also add unallocated_cpu_visible_size to track the visible portion, in case the device is using small BAR. I

[Intel-gfx] [PATCH 10/10] HAX: force small BAR on dg2

Just for CI. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c index 6c6f8cbd7321..119e53f5d9b1 100644 --- a/drivers/gpu

[Intel-gfx] [PATCH 09/10] drm/i915: turn on small BAR support

With the uAPI in place we should now have enough in place to ensure a working system on small BAR configurations. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem

[Intel-gfx] [PATCH 08/10] drm/i915/uapi: disable capturing objects on recoverable contexts

A non-recoverable context must be used if the user wants proper error capture on discrete platforms. In the future the kernel may want to blit the contents of some objects when later doing the capture stage. Testcase: igt@gem_exec_capture@capture-recoverable-discrete Signed-off-by: Matthew Auld

[Intel-gfx] [PATCH 07/10] drm/i915/error: skip non-mappable pages

Skip capturing any lmem pages that can't be copied using the CPU. This in now only best effort on platforms that have small BAR. Testcase: igt@gem-exec-capture@capture-invisible Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfiel

[Intel-gfx] [PATCH 06/10] drm/i915/uapi: add NEEDS_CPU_ACCESS hint

x27;t make space. Testcase: igt@gem-create@create-ext-cpu-access-sanity-check Testcase: igt@gem-create@create-ext-cpu-access-big Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abod

[Intel-gfx] [PATCH 05/10] drm/i915/uapi: apply ALLOC_GPU_ONLY by default

eate@create-ext-cpu-access-big Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_g

[Intel-gfx] [PATCH 04/10] drm/i915: remove intel_memory_region avail

No longer used. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin --- drivers/gpu/drm/i915/intel_memory_region.c | 4 +--- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 03/10] drm/i915/uapi: expose the avail tracking

-sanity-check Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin --- drivers/gpu/drm/i915/i915_query.c | 10 +- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 02/10] drm/i915/uapi: add probed_cpu_visible_size

just case of plumbing that through to the region query. Testcase: igt@i915_query@query-regions-sanity-check Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abod

[Intel-gfx] [PATCH 01/10] drm/doc: add rfc section for small BAR uapi

over. (Tvrtko) Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin Cc: mesa-...@lists.freedesktop.org Acked-by: Tvrtko Ursulin Acked-by: Akeem G Abodu

[Intel-gfx] [PATCH 00/10] small BAR uapi bits

Test-with: 20220525183702.490989-1-matthew.a...@intel.com -- 2.34.3

[Intel-gfx] [PATCH i-g-t 3/9] tests/i915/gem_create: exercise NEEDS_CPU_ACCESS

Add some basic tests for this new flag. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- tests/i915/gem_create.c | 309 +++- 1 file changed, 308 insertions(+), 1 deletion(-) diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c index f8ae7804

[Intel-gfx] [PATCH i-g-t 4/9] lib/i915: add gem_create_with_cpu_access_in_memory_regions

r. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- lib/i915/intel_memory_region.c | 10 +--- lib/i915/intel_memory_region.h | 46 +++--- tests/i915/gem_eio.c | 1 + tests/i915/gem_lmem_swapping.c | 2 +- tests/i915/i915_pm_rpm.c | 6 ++--

[Intel-gfx] [PATCH i-g-t 6/9] tests/i915/query: sanity check the unallocated tracking

Signed-off-by: Matthew Auld Cc: Thomas Hellström --- tests/i915/i915_query.c | 273 +++- 1 file changed, 272 insertions(+), 1 deletion(-) diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c index 6b036241..77cbd93e 100644 --- a/tests/i915

[Intel-gfx] [PATCH i-g-t 5/9] tests/i915/query: sanity check the probed_cpu_visible_size

Add some basic sanity checks for this, like checking if this falls within the probed_size. On older kernels the value reported here should be zero. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- tests/i915/i915_query.c | 19 --- 1 file changed, 16 insertions(+), 3

[Intel-gfx] [PATCH i-g-t 2/9] lib/i915: wire up optional flags for gem_create_ext

For now limit to direct callers. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- lib/i915/gem_create.c | 9 ++--- lib/i915/gem_create.h | 5 +++-- lib/i915/intel_memory_region.c | 2 +- tests/i915/gem_create.c| 24 tests/i915

[Intel-gfx] [PATCH i-g-t 0/9] small BAR uapi bits

-- 2.34.3

[Intel-gfx] [PATCH i-g-t 1/9] lib/i915_drm_local: Add I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS

For now dump into i915_drm_local.h. Once the uapi on the kernel side is merged, and is part of drm-next, we can sync the kernel headers and remove this. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- lib/i915/i915_drm_local.h | 21 + 1 file changed, 21 insertions

[Intel-gfx] [PATCH i-g-t 9/9] lib/i915: request CPU_ACCESS for fb objects

e the mappable portion, if possible. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- lib/ioctl_wrappers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 09eb3ce7..7713e78b 100644 --- a/lib/ioctl_wrappers.c +++

[Intel-gfx] [PATCH i-g-t 8/9] tests/i915/capture: handle uapi changes

skipped, for now at least. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- tests/i915/gem_exec_capture.c | 143 -- 1 file changed, 135 insertions(+), 8 deletions(-) diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c index 60f8df04

[Intel-gfx] [PATCH i-g-t 7/9] lib/i915/intel_memory_region: plumb through the cpu_size

Will be useful later. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- lib/i915/intel_memory_region.c | 2 ++ lib/i915/intel_memory_region.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/i915/intel_memory_region.c b/lib/i915/intel_memory_region.c index da81650d..2dd4c156 100644

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Add smem fallback allocation for dpt

On Fri, 20 May 2022 at 12:23, Juha-Pekka Heikkilä wrote: > > > > Matthew Auld kirjoitti 11.5.2022 klo 13.41: > > On Fri, 6 May 2022 at 14:11, Juha-Pekka Heikkila > > wrote: > >> > >> Add fallback smem allocation for dpt if stolen memory allocation f

Re: [Intel-gfx] (no subject)

On Thu, 19 May 2022 at 10:55, Christian König wrote: > > Just sending that out once more to intel-gfx to let the CI systems take > a look. If all went well it should normally appear at [1][2], if CI was able to pick up the series. Since it's not currently there, I assume it's temporarily stuck i

Re: [Intel-gfx] [RFC PATCH v2 0/1] Replace shmem memory region and object backend

On Tue, 17 May 2022 at 21:45, Adrian Larumbe wrote: > > This patch is a second attempt at eliminating the old shmem memory region > and GEM object backend, in favour of a TTM-based one that is able to manage > objects placed on both system and local memory. > > Questions addressed since previous r

[Intel-gfx] [PATCH v4] drm/doc: add rfc section for small BAR uapi

over. (Tvrtko) Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jon Bloomfield Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin Cc: mesa-...@lists.freedesktop.org --- Documentation/gpu/rfc/i915_small_b

Re: [Intel-gfx] [PATCH v3] drm/doc: add rfc section for small BAR uapi

On 17/05/2022 09:29, Tvrtko Ursulin wrote: On 16/05/2022 19:11, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem & Thomas)    - Rework error capture interactions, including no longer nee

[Intel-gfx] [PATCH v3] drm/doc: add rfc section for small BAR uapi

size. (Lionel) v3: - Drop the vma query for now. - Add unallocated_cpu_visible_size as part of the region query. - Improve the docs some more, including documenting the expected behaviour on older kernels, since this came up in some offline discussion. Signed-off-by: Matthew Auld Cc: Th

Re: [Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap

On 11/05/2022 19:38, Maarten Lankhorst wrote: Op 11-05-2022 om 20:23 schreef Matthew Auld: On 11/05/2022 12:52, Maarten Lankhorst wrote: Instead of its own path, use the common path when it doesn't result in evicting any vma. This fixes the case where we don't wait for binding

Re: [Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap

waiting for the bind doesn't seem to help? Fixes: b5cfe6f7a6e1 ("drm/i915: Remove short-term pins from execbuf, v6.") Cc: Matthew Auld Reported-by: Mateusz Jończyk Tested-by: Hans de Goede Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

Re: [Intel-gfx] [PATCH 3/3] drm/i915: error out on platform with small-bar and CCS

Spurious new line here. For the series, Reviewed-by: Matthew Auld + } + if (GEM_WARN_ON(lmem_size < flat_ccs_base)) return ERR_PTR(-EIO);

Re: [Intel-gfx] [RFC PATCH] drm/i915: don't treat small BAR as an error with CSS

On Wed, 11 May 2022 at 13:34, Das, Nirmoy wrote: > > > On 5/11/2022 1:31 PM, Matthew Auld wrote: > > On Wed, 11 May 2022 at 11:25, Nirmoy Das wrote: > >> Determine lmem_size using ADDR_RANGE register so that module > >> load on platfrom with small bar with cs

Re: [Intel-gfx] [RFC PATCH] drm/i915: don't treat small BAR as an error with CSS

On Wed, 11 May 2022 at 11:25, Nirmoy Das wrote: > > Determine lmem_size using ADDR_RANGE register so that module > load on platfrom with small bar with css works. > > Signed-off-by: Nirmoy Das > --- > I once reserved a dg2 machine with small bar and module load failed on > it. I can't find that

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix i915_vma_pin_iomap()

n; > > - io_mapping_unmap(vma->iomap); > + if (page_unmask_bits(vma->iomap)) > + __i915_gem_object_release_map(vma->obj); > + else > + io_mapping_unmap(vma->iomap); > vma->iomap = NULL; I don't suppose you want to type a patch that also moves the __i915_vma_iounmap() in vma_evict out from under the is_map_and_fenceable check, since we are currently leaking that lmem mapping, and now also that pin_map? I could have sworn that internal fixed that somewhere... With that "leak" fixed, Reviewed-by: Matthew Auld > } > > -- > 2.25.1 >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Add smem fallback allocation for dpt

ALLOC_CONTIGUOUS); > - else > + dpt_obj = i915_gem_object_create_lmem(i915, size, > I915_BO_ALLOC_CONTIGUOUS); > + if (IS_ERR(dpt_obj) && i915_ggtt_has_aperture(to_gt(i915)->ggtt)) > dpt_obj = i915_gem_object_create_stolen(i915, size); >

Re: [Intel-gfx] [PATCH 01/16] drm/i915: Drop has_llc from device info

On Mon, 9 May 2022 at 15:05, Souza, Jose wrote: > > On Mon, 2022-05-09 at 12:09 +0100, Matthew Auld wrote: > > On Sat, 7 May 2022 at 14:29, José Roberto de Souza > > wrote: > > > > > > This feature is supported in graphics version 6 and newer in all > &g

Re: [Intel-gfx] [PATCH 01/16] drm/i915: Drop has_llc from device info

On Sat, 7 May 2022 at 14:29, José Roberto de Souza wrote: > > This feature is supported in graphics version 6 and newer in all > integrated GPUs not including VLC and CHV, so we can drop this flag > for a not so complicated macro check. s/VLC/VLV/ ? There are also some gen9/10 platforms that onl

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Enable THP on Icelake and beyond

is run both in fullscreen and 1/2 screen window). """ Since the only regression is MemBW GPU blend, against many more gains, it sounds it is time to enable THP on Gen11+. Signed-off-by: Tvrtko Ursulin References: https://gitlab.freedesktop.org/drm/intel/-/issues/430 Cc: Joonas Lahti

[Intel-gfx] [PATCH i-g-t 1/2] tests/i915/gem_caching: handle discrete

Test should still be valid, even if we can't explicitly control the PTE caching bits, like on discrete, where the caching should already be enabled by default for system memory objects. References: https://gitlab.freedesktop.org/drm/intel/-/issues/4873 Signed-off-by: Matthew Auld Cc: Nirmo

[Intel-gfx] [PATCH i-g-t 2/2] tests/i915/gem_workarounds: handle discrete

On discrete the object should already be using I915_CACHING_CACHED, by default, for system memory objects, although we can no longer explicitly control the PTE caching bits. References: https://gitlab.freedesktop.org/drm/intel/-/issues/4873 Signed-off-by: Matthew Auld Cc: Nirmoy Das --- tests

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

On 28/04/2022 12:11, Tvrtko Ursulin wrote: On 28/04/2022 11:25, Matthew Auld wrote: On 28/04/2022 09:55, Tvrtko Ursulin wrote: On 27/04/2022 18:36, Matthew Auld wrote: On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

On 03/05/2022 11:39, Lionel Landwerlin wrote: On 03/05/2022 13:22, Matthew Auld wrote: On 02/05/2022 09:53, Lionel Landwerlin wrote: On 02/05/2022 10:54, Lionel Landwerlin wrote: On 20/04/2022 20:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

On 02/05/2022 09:53, Lionel Landwerlin wrote: On 02/05/2022 10:54, Lionel Landwerlin wrote: On 20/04/2022 20:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem & Thomas)    - Rework error cap

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

; Bloomfield, Jon ; Daniel Vetter ; Justen, Jordan L ; Kenneth Graunke ; Abodunrin, Akeem G ; mesa-...@lists.freedesktop.org Subject: Re: [PATCH v2] drm/doc: add rfc section for small BAR uapi On 20/04/2022 20:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

On 02/05/2022 08:54, Lionel Landwerlin wrote: On 20/04/2022 20:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem & Thomas)    - Rework error capture interactions, including no longer nee

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

ce > batch. This allows us to protect the kernel's ring without changing the > uABI. > > Suggested-by: Zbigniew Kempczynski > Signed-off-by: Chris Wilson > Cc: Zbigniew Kempczynski > Cc: Thomas Hellstrom > Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 2/3] drm/i915/selftests: Skip poisoning SET_PREDICATE_RESULT on dg2

; Cc: Joonas Lahtinen > Suggested-by: CQ Tang > Signed-off-by: Chris Wilson > Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 1/3] drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing

> mismatch between LRC register layout generated during init and HW > default register offsets. > > Signed-off-by: Akeem G Abodunrin > cc: Prathap Kumar Valsan > Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Replace shmem memory region and object backend with TTM

On Thu, 28 Apr 2022 at 09:39, Adrian Larumbe wrote: > > Remove shmem region and object backend code as they are now unnecessary. > In the case of objects placed in SMEM and backed by kernel shmem files, the > file pointer has to be retrieved from the ttm_tt structure, so change this > as well. Thi

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

On 28/04/2022 09:55, Tvrtko Ursulin wrote: On 27/04/2022 18:36, Matthew Auld wrote: On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

o_copy). +*/ + GEM_BUG_ON(!it->sg); It will crash and burn anyway, with the below NULL deref. Not sure if BUG_ON() is really much better, but I guess with the additional comment, Reviewed-by: Matthew Auld it->dma = sg_dma_address(it->sg);

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: optimize the ccs_sz calculation per chunk

dst_sz; bool ccs_is_src; int err; @@ -770,7 +762,7 @@ intel_context_migrate_copy(struct intel_context *ce, } do { - int len; + int len, ccs_sz; This could be moved into the reduced scope below. Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem & Thomas)    - Rework error capture interactions, including no longer nee

Re: [Intel-gfx] [PATCH v2 4/4] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

cc: Matthew Auld cc: Thomas Hellstrom --- include/uapi/drm/i915_drm.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index 35ca528803fd..ad191ed6547c 100644 --- a/include/uapi/drm/i915_drm.h +++ b/include/uapi/drm

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/gt: Document the eviction of the Flat-CCS objects

On 25/04/2022 17:24, Ramalingam C wrote: Capture the eviction details for Flat-CCS capable, lmem objects. v2: Fix the Flat-ccs capbility of lmem obj with smem residency possibility [Thomas] Signed-off-by: Ramalingam C cc: Thomas Hellstrom cc: Matthew Auld --- drivers/gpu/drm/i915/gt

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

-Lionel On 27/04/2022 09:35, Lionel Landwerlin wrote: Hi Matt, The proposal looks good to me. Looking forward to try it on drm-tip. -Lionel On 20/04/2022 20:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other smal

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

mappable by address? You made a comment stating this is racy, wouldn't querying on the GEM object prevent this? Thanks, -Lionel On 27/04/2022 09:35, Lionel Landwerlin wrote: Hi Matt, The proposal looks good to me. Looking forward to try it on drm-tip. -Lionel On 20/04/2022 20:13, M

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/4] drm/i915: consider min_page_size when migrating

On 21/04/2022 02:30, Patchwork wrote: *Patch Details* *Series:* series starting with [CI,1/4] drm/i915: consider min_page_size when migrating *URL:* https://patchwork.freedesktop.org/series/102879/ *State:*failure *Details:* https://i

[Intel-gfx] [CI 3/4] drm/i915/selftests: fixup min_alignment usage

Trying to cast the region id into the region type doesn't work too well, since the i915_vm_min_alignment() won't give us the correct value for the stolen-lmem case. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das Cc: Ramalingam C --- drivers/gpu/drm/i915

[Intel-gfx] [CI 4/4] drm/i915/selftests: tweak the misaligned_case

The compact-pt layout restrictions should only apply to the ppGTT. Also make this play nice on platforms that only have the 64K GTT restriction, and not the compact-pt thing. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das Cc: Ramalingam C --- drivers/gpu/drm/i915/selftests

[Intel-gfx] [CI 2/4] drm/i915/buddy: sanity check the size

-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c b/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c index 8e4e3f72c1ef

[Intel-gfx] [CI 1/4] drm/i915: consider min_page_size when migrating

9] DR3: DR6: fffe0ff0 DR7: 0400 [ 2857.497692] Call Trace: [ 2857.497694] [ 2857.497697] intel_context_migrate_copy+0x1e5/0x4f0 [i915] Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

size. (Lionel) Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin Cc: mesa-...@lists.freedesktop.org --- Documentation/gpu/rfc/i915_small_bar.h |

[Intel-gfx] [PATCH v2] drm/ttm: fixup ttm_bo_add_move_fence

moving") Cc: Christian König Cc: Daniel Vetter Signed-off-by: Matthew Auld Reviewed-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/tt

[Intel-gfx] [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

l Vetter Signed-off-by: Matthew Auld --- drivers/gpu/drm/ttm/ttm_bo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 015a94f766de..b15b77e10383 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c

Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

On 11/04/2022 13:39, Christian König wrote: Am 11.04.22 um 10:56 schrieb Matthew Auld: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent changes in this

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] tests/drm_buddy: Add drm buddy test cases

On Mon, 11 Apr 2022 at 19:51, Arunpravin Paneer Selvam wrote: > > Add a set of drm buddy test cases to validate the > drm/drm_buddy.c memory allocator. > > v2: sorted in alphabetical order > > Signed-off-by: Arunpravin Paneer Selvam > Reviewed-by: Matthew Auld Tests

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

On 11/04/2022 13:42, Christian König wrote: Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their

Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

On 11/04/2022 10:56, Thomas Hellström wrote: Hi, Matthew On 4/11/22 10:56, Matthew Auld wrote: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

min_order = 8, triggers the BUG_ON(order < min_order). v2: add more commit description v3: remove WARN_ON() Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH] tests/drm_buddy: Add drm buddy test cases

10 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -10,6 +10,7 @@ test_progs = [ 'device_reset', 'drm_import_export', 'drm_mm', + 'drm_buddy', Nit: Should be kept sorted. No need to resend though. Reviewed-by: Matthew Au

[Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

x3e/0x2b0 <4>[5.467704] intel_alloc_initial_plane_obj.isra.6+0x1a9/0x390 [i915] <4>[5.467833] intel_crtc_initial_plane_config+0x83/0x340 [i915] In the ttm_bo_move_sync_cleanup() case it seems we only really care about calling ttm_bo_wait_free_node(), so let's ins

Re: [Intel-gfx] [PATCH v2] drm/i915: fix i915_gem_object_wait_moving_fence

On 08/04/2022 10:48, Matthew Auld wrote: On 08/04/2022 09:59, Christian König wrote: Am 08.04.22 um 10:42 schrieb Matthew Auld: All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that

Re: [Intel-gfx] [PATCH 20/20] drm/i915/gsc: allocate extended operational memory in LMEM

On Thu, 7 Apr 2022 at 14:00, Alexander Usyskin wrote: > > From: Tomas Winkler > > GSC requires more operational memory than available on chip. > Reserve 4M of LMEM for GSC operation. The memory is provided to the > GSC as struct resource to the auxiliary data of the child device. > > Signed-off-b

Re: [Intel-gfx] [PATCH v2] drm/i915: fix i915_gem_object_wait_moving_fence

On 08/04/2022 09:59, Christian König wrote: Am 08.04.22 um 10:42 schrieb Matthew Auld: All of CI is just failing with the following, which prevents loading of the module: i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that this comes from the pin_map() for the

[Intel-gfx] [PATCH v2] drm/i915: fix i915_gem_object_wait_moving_fence

calls into dma_resv_wait_timeout() which can return the remaining timeout, leading to the caller thinking this is an error. v2(Lucas): handle ret == 0 Fixes: 1d7f5e6c5240 ("drm/i915: drop bo->moving dependency") Signed-off-by: Matthew Auld Cc: Christian König Cc: Lucas De March

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix broken build

On 07/04/2022 17:49, Christian König wrote: Am 07.04.22 um 18:45 schrieb Matthew Auld: I guess this was missed in the conversion or something. Fixes: 7bc80a5462c3 ("dma-buf: add enum dma_resv_usage v4") Signed-off-by: Matthew Auld Cc: Christian König Cc: Daniel Vetter My bes

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix i915_gem_object_wait_moving_fence

On 08/04/2022 06:00, Lucas De Marchi wrote: On Thu, Apr 07, 2022 at 05:45:32PM +0100, Matthew Auld wrote: All of CI is just failing with the following, which prevents loading of the module:    i915 :03:00.0: [drm] *ERROR* Scratch setup failed Best guess is that this comes from the pin_map

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix broken build

On 07/04/2022 17:49, Christian König wrote: Am 07.04.22 um 18:45 schrieb Matthew Auld: I guess this was missed in the conversion or something. Fixes: 7bc80a5462c3 ("dma-buf: add enum dma_resv_usage v4") Signed-off-by: Matthew Auld Cc: Christian König Cc: Daniel Vetter My bes

[Intel-gfx] [PATCH 2/2] drm/i915: fix i915_gem_object_wait_moving_fence

calls into dma_resv_wait_timeout() which can return the remaining timeout, leading to the caller thinking this is an error. Fixes: 1d7f5e6c5240 ("drm/i915: drop bo->moving dependency") Signed-off-by: Matthew Auld Cc: Christian König Cc: Daniel Vetter --- drivers/gpu

[Intel-gfx] [PATCH 1/2] drm/i915: fix broken build

I guess this was missed in the conversion or something. Fixes: 7bc80a5462c3 ("dma-buf: add enum dma_resv_usage v4") Signed-off-by: Matthew Auld Cc: Christian König Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_deps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Intel-gfx] [PATCH 1/2] drm/i915: consider min_page_size when migrating

9] DR3: DR6: fffe0ff0 DR7: 0400 [ 2857.497692] Call Trace: [ 2857.497694] [ 2857.497697] intel_context_migrate_copy+0x1e5/0x4f0 [i915] Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 2/2] drm/i915/buddy: sanity check the size

-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das --- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c b/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c index 8e4e3f72c1ef..a5109548abc0 100644 --- a

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: tweak the misaligned_case

The compact-pt layout restrictions should only apply to the ppGTT. Also make this play nice on platforms that only have the 64K GTT restriction, and not the compact-pt thing. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 12

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: fixup min_alignment usage

Trying to cast the region id into the region type doesn't work too well, since the i915_vm_min_alignment() won't give us the correct value for the stolen-lmem case. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2

[Intel-gfx] [PATCH] drm/i915: consider min_page_size when migrating

9] DR3: DR6: fffe0ff0 DR7: 0400 [ 2857.497692] Call Trace: [ 2857.497694] [ 2857.497697] intel_context_migrate_copy+0x1e5/0x4f0 [i915] Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_object.c

[Intel-gfx] [PATCH] drm/i915/selftests: handle more rounding

Ensure we account for potential rounding up of lmem objects. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5485 Signed-off-by: Matthew Auld Cc: Nirmoy Das --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

Re: [Intel-gfx] [PATCH 14/16] drm/i915: drop bo->moving dependency

On Wed, 6 Apr 2022 at 08:52, Christian König wrote: > > That should now be handled by the common dma_resv framework. > > Signed-off-by: Christian König > Reviewed-by: Daniel Vetter > Cc: intel-gfx@lists.freedesktop.org > --- > drivers/gpu/drm/i915/gem/i915_gem_object.c| 41 -

<    1   2   3   4   5   6   7   8   9   10   >