Re: [Intel-gfx] mm/huge_memory: do not clobber swp_entry_t during THP split

2022-10-26 Thread Mel Gorman
ng would trigger an excessive number of new bugs but it served its intended purpose -- catch fallout from clobbering page->private causing subtle bugs later that are hard to debug. -- Mel Gorman SUSE Labs

Re: [Intel-gfx] mm/huge_memory: do not clobber swp_entry_t during THP split

2022-10-25 Thread Mel Gorman
at 09:50:14AM +0100, Tvrtko Ursulin wrote: > > On 24/10/2022 15:23, Mel Gorman wrote: > > On Mon, Oct 24, 2022 at 02:04:50PM +0100, Tvrtko Ursulin wrote: > > > > > > Hi Mel, mm experts, > > > > > > With 6.1-rc2 we started hitting the WARN_ON added in 71e

Re: [Intel-gfx] mm/huge_memory: do not clobber swp_entry_t during THP split

2022-10-24 Thread Mel Gorman
, which makes no pass down the tails). Fixes: 71e2d666ef85 ("mm/huge_memory: do not clobber swp_entry_t during THP split") Signed-off-by: Hugh Dickins Cc: Mel Gorman Cc: Matthew Wilcox (Oracle) Cc: --- mm/huge_memory.c | 2 +- mm/page_alloc.c | 1 + 2 files changed, 2 insertion

Re: [Intel-gfx] [PATCH 00/31] Move LRU page reclaim from zones to nodes v8

2016-07-19 Thread Mel Gorman
list. If lowmem reclaim persisted for long periods of time, the same highmem pages get continually scanned. The idea would be that lowmem keeps those pages on a separate list until a reclaim for highmem pages arrives that splices the highmem pages back onto the LRU. That would reduce the s

Re: [Intel-gfx] Kswapd 100% CPU since 3.8 on Sandybridge

2014-10-06 Thread Mel Gorman
x220 Intel Sandy Bridge graphics Ubuntu 14.04 with edgers PPA for Mesa 3.16.3 kernel Since around the 3.8 kernel time frame, I've been able to reproduce this behavior. I'm pretty sure it was a kernel change. I mentioned this to Mel Gorman at LinuxCon NA, and he wanted me to run a particular

Re: [Intel-gfx] [PATCH v4 17/31] drivers: convert shrinkers to new count/scan API

2013-05-02 Thread Mel Gorman
On Wed, May 01, 2013 at 05:26:38PM +0200, Daniel Vetter wrote: On Tue, Apr 30, 2013 at 11:53 PM, Mel Gorman mgor...@suse.de wrote: On Sat, Apr 27, 2013 at 03:19:13AM +0400, Glauber Costa wrote: diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 6be940e

Re: [Intel-gfx] [PATCH v4 17/31] drivers: convert shrinkers to new count/scan API

2013-05-02 Thread Mel Gorman
On Tue, Apr 30, 2013 at 03:00:50PM -0700, Kent Overstreet wrote: On Tue, Apr 30, 2013 at 10:53:55PM +0100, Mel Gorman wrote: On Sat, Apr 27, 2013 at 03:19:13AM +0400, Glauber Costa wrote: diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index 03e44c1..8b9c1a6 100644

Re: [Intel-gfx] [PATCH v4 17/31] drivers: convert shrinkers to new count/scan API

2013-05-01 Thread Mel Gorman
+ LRU_ACTIVE_FILE); @@ -1212,7 +1218,8 @@ skip_evict: } static struct shrinker zcache_shrinker = { - .shrink = shrink_zcache_memory, + .scan_objects = scan_zcache_memory, + .count_objects = count_zcache_memory, .seeks = DEFAULT_SEEKS, }; -- Mel Gorman SUSE Labs