[Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support

2023-09-29 Thread Mitul Golani
This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchw

[Intel-gfx] [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-26 Thread Mitul Golani
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by: S

[Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-26 Thread Mitul Golani
ue if output_bpp is computed as integer. With this approach, we will be able to validate DSC with fractional bpp. v2: Add drm_modeset_unlock to new line(Suraj) Signed-off-by: Swati Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- .../drm/i915/di

[Intel-gfx] [PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-26 Thread Mitul Golani
From: Ankit Nautiyal This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-26 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fixed tu_data calculation while dealing with U6.4 f

[Intel-gfx] [PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-26 Thread Mitul Golani
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_qp_tables.c

[Intel-gfx] [PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-26 Thread Mitul Golani
(data_clock, 16).' (Sui Jingfeng). Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display.c | 6 +- drivers/gpu/drm/i915/display/intel_display.h | 2 +- drivers/gpu/drm/i915/display/intel_dp.c | 5 +++--

[Intel-gfx] [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-26 Thread Mitul Golani
file for 6.4 fixed point helper(Jani, Nikula) -Add comment for magic values(Suraj) v4: Fix checkpatch warnings caused by renaming(Suraj) Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/icl_dsi.c| 11 +++--- drivers

[Intel-gfx] [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp precision

2023-09-26 Thread Mitul Golani
From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Acked-by: Maxime Ripard --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display/drm_dp_helper.h | 1 +

[Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support

2023-09-26 Thread Mitul Golani
This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchw

[Intel-gfx] [PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-12 Thread Mitul Golani
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by: S

[Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-12 Thread Mitul Golani
ue if output_bpp is computed as integer. With this approach, we will be able to validate DSC with fractional bpp. v2: Add drm_modeset_unlock to new line(Suraj) Signed-off-by: Swati Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- .../drm/i915/di

[Intel-gfx] [PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fixed tu_data calculation while dealing with U6.4 f

[Intel-gfx] [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 28 insertions(+) diff --git a/dri

[Intel-gfx] [PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-12 Thread Mitul Golani
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_qp_tables.c

[Intel-gfx] [PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate this precision while computing m_n values. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel

[Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support

2023-09-12 Thread Mitul Golani
his patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchwo

[Intel-gfx] [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-12 Thread Mitul Golani
file for 6.4 fixed point helper(Jani, Nikula) -Add comment for magic values(Suraj) v4: -Fix checkpatch caused due to renaming(Suraj) Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/icl_dsi.c| 11 +++--- drivers/gpu

[Intel-gfx] [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-12 Thread Mitul Golani
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by: S

[Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-12 Thread Mitul Golani
ue if output_bpp is computed as integer. With this approach, we will be able to validate DSC with fractional bpp. v2: Add drm_modeset_unlock to new line(Suraj) Signed-off-by: Swati Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- .../drm/i915/di

[Intel-gfx] [PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-12 Thread Mitul Golani
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_qp_tables.c

[Intel-gfx] [PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fixed tu_data calculation while dealing with U6.4 f

[Intel-gfx] [PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate this precision while computing m_n values. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel

[Intel-gfx] [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 28 insertions(+) diff --git a/dri

[Intel-gfx] [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-12 Thread Mitul Golani
file for 6.4 fixed point helper(Jani, Nikula) -Add comment for magic values(Suraj) Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/icl_dsi.c| 11 +++--- drivers/gpu/drm/i915/display/intel_audio.c| 3 +- drivers

[Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support

2023-09-12 Thread Mitul Golani
This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchw

[Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support

2023-09-10 Thread Mitul Golani
This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchw

[Intel-gfx] [PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-10 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fixed tu_data calculation while dealing with U6.4 f

[Intel-gfx] [PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-10 Thread Mitul Golani
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_qp_tables.c| 3 --- drivers/gpu/drm/i

[Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-10 Thread Mitul Golani
From: Swati Sharma DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to depict sink's precision. Also, new debugfs entry is created to enforce fractional bpp. If Force_DSC_Fractional_BPP_en is set then while iterating over output bpp with fractional step size we will continue if

[Intel-gfx] [PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-10 Thread Mitul Golani
From: Ankit Nautiyal This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 37 ++

[Intel-gfx] [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-10 Thread Mitul Golani
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by: S

[Intel-gfx] [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-10 Thread Mitul Golani
From: Ankit Nautiyal DSC parameter bits_per_pixel is stored in U6.4 format. The 4 bits represent the fractional part of the bpp. Currently we use compressed_bpp member of dsc structure to store only the integral part of the bits_per_pixel. To store the full bits_per_pixel along with the fractiona

[Intel-gfx] [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-10 Thread Mitul Golani
From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 28 insertions(+) diff --git a/dri

[Intel-gfx] [PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-10 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate this precision while computing m_n values. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 6 +- drive

[Intel-gfx] [PATCH 3/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-08-21 Thread Mitul Golani
tions separately, removed code duplication and merged functions.[Nikula, Jani] - Remove magic value for SAD Channel mask. [Nikula, Jani] - Corrected rate values based on HDMI Spec [Nikula, Jani] - Update drm function to extract SAD from ELD [Nikula, Jani] Signed-off-by: Mitul Golani --- drivers/gp

[Intel-gfx] [PATCH 1/3] drm/i915: Add has_audio to separate audio parameter in crtc_state

2023-08-21 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c

[Intel-gfx] [PATCH 2/3] drm: Add Wrapper Functions for ELD SAD Extraction

2023-08-21 Thread Mitul Golani
functions provide flexibility to the codebase, allowing users to access SAD information while adhering to const correctness when needed and modifying the pointer when required. Signed-off-by: Mitul Golani --- include/drm/drm_edid.h | 15 ++- 1 file changed, 10 insertions(+), 5

[Intel-gfx] [PATCH 0/3] Get optimal audio frequency and channels

2023-08-21 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Signed-off-by: Mitul Golani Mitul Golani (3): drm/i915: Add has_audio to separate audio parameter in crtc_state drm: Add Wrapper Functions for ELD SAD Extraction drm

[Intel-gfx] [PATCH 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-08-17 Thread Mitul Golani
before that. --v9: - Handling the case when, sink supported channel is less than max supported. In that case, rate needs to be calibrate in accordance with available bandwidth. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c | 107 - 1 file changed

[Intel-gfx] [PATCH 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-08-17 Thread Mitul Golani
num_of_channel and aud_rate separately. - Declare index value outside of for loop. - Move Bandwidth calculation to intel_Audio.c as it is common for both DP and HDMI. Also use static. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c| 38 +++ .../drm

[Intel-gfx] [PATCH 1/3] drm/i915: Add has_audio to separate audio parameter in crtc_state

2023-08-17 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c

[Intel-gfx] [PATCH 0/3] Get optimal audio frequency and channels

2023-08-17 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Signed-off-by: Mitul Golani Mitul Golani (3): drm/i915: Add has_audio to separate audio parameter in crtc_state drm/i915/display: Configure and initialize HDMI

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-28 Thread Mitul Golani
before that. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c | 73 +- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 79377e33a59b..9f4fc3f9b224

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-28 Thread Mitul Golani
num_of_channel and aud_rate separately. - Declare index value outside of for loop. - Move Bandwidth calculation to intel_Audio.c as it is common for both DP and HDMI. Also use static. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c| 38 +++ .../drm

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-28 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Signed-off-by: Mitul Golani Mitul Golani (3): drm/i915: Add has_audio to separate audio parameter in crtc_state drm/i915/display: Configure and initialize HDMI

[Intel-gfx] [RFC 1/3] drm/i915: Add has_audio to separate audio parameter in crtc_state

2023-06-28 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-28 Thread Mitul Golani
num_of_channel and aud_rate separately. - Declare index value outside of for loop. - Move Bandwidth calculation to intel_Audio.c as it is common for both DP and HDMI. Also use static. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c| 38 +++ .../drm

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-28 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Mitul Golani (3): drm/i915: Add has_audio to separate audio parameter in crtc_state drm/i915/display: Configure and initialize HDMI audio capabilities drm/i915/display

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-28 Thread Mitul Golani
before that. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c | 73 +- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 79377e33a59b

[Intel-gfx] [RFC 1/3] drm/i915: Add has_audio to separate audio parameter in crtc_state

2023-06-28 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c

[Intel-gfx] [PATCH 0/1] HDMI 2.0/DP1p62Gbps skew violation when there is skew between DL PCLK

2023-06-27 Thread Mitul Golani
o Display Version 13 Wa_15010727533 Signed-off-by: Mitul Golani Mitul Golani (1): drm/i915/display: HDMI2.0/DP1p62Gbps skew violation when there is skew between DL PCLK drivers/gpu/drm/i915/display/intel_ddi.c | 13 + drivers/gpu/drm/i915/i915_reg.h | 6 ++ 2 files ch

[Intel-gfx] [PATCH 1/1] drm/i915/display: HDMI2.0/DP1p62Gbps skew violation when there is skew between DL PCLK

2023-06-27 Thread Mitul Golani
o Display Version 13 Wa_15010727533 Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 13 + drivers/gpu/drm/i915/i915_reg.h | 6 ++ 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/displ

[Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-26 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c | 6 +++--- drivers

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-26 Thread Mitul Golani
intel_audio_compute_eld in this commit as it is defined here --v2: - Handle case when max frequency is less than 32k. - remove drm prefix. - name change for parse_sad to eld_to_sad. --v3: - Use signed int wherever required. - add debug trace when channel is limited. Signed-off-by: Mitul Golani

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-26 Thread Mitul Golani
. - Use int instead of unsigned int for max_channel and max_frequecy - Update commit message and header --v2: - Use signed instead of unsigned variables. - Avoid using magic numbers and give them proper name. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.h| 3

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-26 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Mitul Golani (3): drm/i915/hdmi: Optimize source audio parameter handling drm/i915/display: Configure and initialize HDMI audio capabilities drm/i915/display: Add wrapp

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-26 Thread Mitul Golani
intel_audio_compute_eld in this commit as it is defined here --v2: - Handle case when max frequency is less than 32k. - remove drm prefix. - name change for parse_sad to eld_to_sad. --v3: - Use signed int wherever required. - add debug trace when channel is limited. Signed-off-by: Mitul Golani

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-26 Thread Mitul Golani
. - Use int instead of unsigned int for max_channel and max_frequecy - Update commit message and header --v2: - Use signed instead of unsigned variables. - Avoid using magic numbers and give them proper name. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.h| 3

[Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-26 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c | 6 +++--- drivers

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-26 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Mitul Golani (3): drm/i915/hdmi: Optimize source audio parameter handling drm/i915/display: Configure and initialize HDMI audio capabilities drm/i915/display: Add wrapp

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-15 Thread Mitul Golani
. - Use int instead of unsigned int for max_channel and max_frequecy - Update commit message and header Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_types.h| 6 drivers/gpu/drm/i915/display/intel_hdmi.c | 35 +++ drivers/gpu/drm/i915/display

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-15 Thread Mitul Golani
intel_audio_compute_eld in this commit as it is defined here Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c | 66 ++ drivers/gpu/drm/i915/display/intel_audio.h | 1 + drivers/gpu/drm/i915/display/intel_hdmi.c | 2 + 3 files changed, 69 insertions

[Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-15 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c | 6 +++--- drivers

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-15 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Mitul Golani (3): drm/i915/hdmi: Optimize source audio parameter handling drm/i915/display: Configure and initialize HDMI audio capabilities drm/i915/display: Add wrapp

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-14 Thread Mitul Golani
intel_audio_compute_eld in this commit as it is defined here --v2: - Handle case when max frequency is less than 32k. - remove drm prefix. - name change for parse_sad to eld_to_sad. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c | 69 ++ drivers/gpu

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-14 Thread Mitul Golani
. - Use int instead of unsigned int for max_channel and max_frequecy - Update commit message and header Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_types.h| 6 drivers/gpu/drm/i915/display/intel_hdmi.c | 35 +++ drivers/gpu/drm/i915/display

[Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-14 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c | 6 +++--- drivers

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-14 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Signed-off-by: Mitul Golani Mitul Golani (3): drm/i915/hdmi: Optimize source audio parameter handling drm/i915/display: Configure and initialize HDMI audio capabilities

[Intel-gfx] [RFC 2/3] drm/i915/display: Configure and initialize HDMI audio capabilities

2023-06-09 Thread Mitul Golani
. - Use int instead of unsigned int for max_channel and max_frequecy - Update commit message and header Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_types.h| 6 drivers/gpu/drm/i915/display/intel_hdmi.c | 35 +++ drivers/gpu/drm/i915/display

[Intel-gfx] [RFC 3/3] drm/i915/display: Add wrapper to Compute SAD

2023-06-09 Thread Mitul Golani
intel_audio_compute_eld in this commit as it is defined here Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c | 66 ++ drivers/gpu/drm/i915/display/intel_audio.h | 1 + drivers/gpu/drm/i915/display/intel_hdmi.c | 2 + 3 files changed, 69 insertions

[Intel-gfx] [RFC 1/3] drm/i915/hdmi: Optimize source audio parameter handling

2023-06-09 Thread Mitul Golani
commit where it is being used - update commit message and header Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display/intel_audio.c | 6 +++--- drivers

[Intel-gfx] [RFC 0/3] Get optimal audio frequency and channels

2023-06-09 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Mitul Golani (3): drm/i915/hdmi: Optimize source audio parameter handling drm/i915/display: Configure and initialize HDMI audio capabilities drm/i915/display: Add wrapp

[Intel-gfx] [RFC 4/4] drm/i915/display: Initialize and compute HDMI Audio source cap

2023-06-09 Thread Mitul Golani
into SADs, we can determine which audio formats are supported. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_hdmi.c | 37 +++ drivers/gpu/drm/i915/display/intel_hdmi.h | 1 + 2 files changed, 38 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [RFC 2/4] drm/i915/display: Update access of has_audio param

2023-06-09 Thread Mitul Golani
Update access of has_audio param from crtc_state pointer as it is wrapped under audio_config. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/g4x_dp.c| 4 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 16 drivers/gpu/drm/i915/display

[Intel-gfx] [RFC 3/4] drm/i915/display: Add wrapper to Compute SAD

2023-06-09 Thread Mitul Golani
: Mitul Golani --- drivers/gpu/drm/i915/display/intel_audio.c | 66 ++ drivers/gpu/drm/i915/display/intel_audio.h | 1 + 2 files changed, 67 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index b4a0dae65cbf

[Intel-gfx] [RFC 1/4] drm/i915/hdmi: Add audio config related params in crtc_state

2023-06-09 Thread Mitul Golani
Add source audio-related config params in crtc_state. These params can be supported frequency, supported channel, and audio support, which can be further computed based on source capabilities. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display_types.h | 12

[Intel-gfx] [RFC 0/4] Get optimal audio frequency and channels

2023-06-09 Thread Mitul Golani
maximum supported rate and channel by the audio source. - Computing the SADs based on the audio source's capabilities. Mitul Golani (4): drm/i915/hdmi: Add audio config related params in crtc_state drm/i915/display: Update access of has_audio param drm/i915/display: Add wrapper to Comput

[Intel-gfx] [PATCH] drm/i915/display: Enable VDIP Enable VSC whenever GMP DIP enabled

2022-12-11 Thread Mitul Golani
GMP VDIP gets dropped when enabled without VSC DIP being enabled. Enable VSC DIP whenever GMP DIP is enabled WA:14015402699 Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 5 - drivers/gpu/drm/i915/display/intel_lspcon.c | 2 ++ 2 files changed, 6 insertions

[Intel-gfx] [PATCH] drm/i915/display: Enable VDIP Enable VSC whenever GMP DIP enabled

2022-12-11 Thread Mitul Golani
GMP VDIP gets dropped when enabled without VSC DIP being enabled. Enable VSC DIP whenever GMP DIP is enabled WA:14015402699 Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_lspcon.c | 2 ++ 2 files changed, 4 insertions

[Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-30 Thread Mitul Golani
. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/i915_driver.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index 1332c70370a6..be0d51c04cc5 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-29 Thread Mitul Golani
. It will check the suspend state and if driver is not resumed before taking wakeref then resume before it. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/i915_driver.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_driver.c b

[Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-23 Thread Mitul Golani
. It will check the suspend state and if driver is not resumed before taking wakeref then resume before it. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/i915_driver.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-23 Thread Mitul Golani
. It will check the suspend state and if driver is not resumed before taking wakeref then resume before it. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/i915_driver.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-12 Thread Mitul Golani
unregistered, this wakeref is released with enable_rpm_wakeref_asserts and balancing wakeref_count acquired by driver. This patch will fix the warning callstack by adding check if device is already suspended and rpm ownership transfer is going on. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915

<    1   2   3   4