Re: ✗ Fi.CI.BAT: failure for series starting with [V2,1/2] drm/i915/drrs: Refactor CPU transcoder DRRS check (rev2)

2024-02-28 Thread Modem, Bhanuprakash
Hello Bug filing team, Below failures are False positive, please help to re-report. - Bhanu On 28-02-2024 01:58 pm, Patchwork wrote: *Patch Details* *Series:* series starting with [V2,1/2] drm/i915/drrs: Refactor CPU transcoder DRRS check (rev2) *URL:* https://patchwork.freedesktop.org/series

Re: [PATCH] drm/i915/display/debugfs: New entry "DRRS capable" to i915_drrs_status

2024-02-26 Thread Modem, Bhanuprakash
intel-gfx@lists.freedesktop.org Cc: Modem, Bhanuprakash Subject: [PATCH] drm/i915/display/debugfs: New entry "DRRS capable" to i915_drrs_status If the connected panel supports both DRRS & PSR, driver gives preference to PSR ("DRRS enabled: no"). Even though the hardware suppor

Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2023-11-16 Thread Modem, Bhanuprakash
On Thu-16-11-2023 04:07 pm, Stanislav Lisovskiy wrote: For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs. Do we have any IGT to validate this? - Bhanu v2: - Apparently

Re: [Intel-gfx] [PATCH 1/1] drm/i915/debugfs: New debugfs for display clock frequencies

2023-04-12 Thread Modem, Bhanuprakash
Hi Jani, Thanks for the review, I have floated a new rev [*] by addressing your comments. [*]: https://patchwork.freedesktop.org/series/116372/ - Bhanu On Wed-12-04-2023 02:52 pm, Jani Nikula wrote: On Wed, 12 Apr 2023, Bhanuprakash Modem wrote: Instead of mixing display & non-display stu

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/debugfs: add crtc i915_pipe debugfs file

2023-03-20 Thread Modem, Bhanuprakash
On Mon-20-03-2023 06:14 pm, Jani Nikula wrote: The pipe may differ from crtc index if pipes are fused off. For testing purposes, IGT needs to know the pipe. There's already a I915_GET_PIPE_FROM_CRTC_ID IOCTL for this. However, the upcoming Xe driver won't have that IOCTL, and going forward, w

Re: [Intel-gfx] [RFC V3 0/2] Attach and Set vrr_enabled property

2022-06-01 Thread Modem, Bhanuprakash
On Tue-31-05-2022 07:26 pm, Daniel Vetter wrote: On Tue, May 17, 2022 at 12:56:34PM +0530, Bhanuprakash Modem wrote: This series will add a support to set the vrr_enabled property for crtc based on the platform support and the request from userspace. And userspace can also query to get the statu

Re: [Intel-gfx] [RFC V3 1/2] drm/vrr: Attach vrr_enabled property to the drm crtc

2022-06-01 Thread Modem, Bhanuprakash
On Tue-31-05-2022 10:42 pm, Navare, Manasi wrote: On Tue, May 17, 2022 at 12:56:35PM +0530, Bhanuprakash Modem wrote: Modern display hardware is capable of supporting variable refresh rates. This patch introduces helpers to attach and set "vrr_enabled" property on the crtc to allow userspace to

Re: [Intel-gfx] [RFC V3 2/2] drm/i915/vrr: Set drm crtc vrr_enabled property

2022-06-01 Thread Modem, Bhanuprakash
On Tue-31-05-2022 10:44 pm, Navare, Manasi wrote: On Tue, May 17, 2022 at 12:56:36PM +0530, Bhanuprakash Modem wrote: This function sets the vrr_enabled property for crtc based on the platform support and the request from userspace. V2: Check for platform support before updating the prop. V3: D

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-17 Thread Modem, Bhanuprakash
On Mon-16-05-2022 02:09 pm, Jani Nikula wrote: On Mon, 02 May 2022, Harry Wentland wrote: Both the kernel and IGT series look good to me. I recommend you merge the entire kernel set as one into drm-next. We can pull it into amd-staging-drm-next so as not to break our CI once the IGT patches la

Re: [Intel-gfx] [V2 0/3] Expose max and current bpc via debugfs

2022-05-10 Thread Modem, Bhanuprakash
Hi Jani, Can you please help to push this series to drm-next? CI result: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102502v7/index.html? I'll merge IGT changes [1] first, so that we won't break the CI. [1]: https://patchwork.freedesktop.org/series/102387/ - Bhanu On Mon-11-04-2022 0

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Modem, Bhanuprakash
On Mon-02-05-2022 07:08 pm, Harry Wentland wrote: On 2022-05-02 09:28, Modem, Bhanuprakash wrote: On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: -Original Message- From: Intel-gfx On Behalf Of Bhanuprakash Modem Sent: Monday, April 11, 2022 3:21 PM To: intel-gfx

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Modem, Bhanuprakash
On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: -Original Message- From: Intel-gfx On Behalf Of Bhanuprakash Modem Sent: Monday, April 11, 2022 3:21 PM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; amd- g...@lists.freedesktop.org; jani.nik...@linux.intel.com;

Re: [Intel-gfx] [RFC v2 1/2] drm/vrr: Attach vrr_enabled property to the drm crtc

2022-04-28 Thread Modem, Bhanuprakash
On Wed-27-04-2022 03:31 am, Navare, Manasi wrote: On Mon, Apr 25, 2022 at 12:16:11PM +0530, Bhanuprakash Modem wrote: Modern display hardware is capable of supporting variable refresh rates. This patch introduces helpers to attach and set "vrr_enabled" property on the crtc to allow userspace to

Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Modem, Bhanuprakash
On Tue-12-04-2022 08:37 am, Murthy, Arun R wrote: +static int output_bpc_show(struct seq_file *m, void *data) { Would it be better to have this function name as drm_output_bpc_show() As we are using DEFINE_SHOW_ATTRIBUTE() to define file_operations, this function name must be _show(). Otherw

Re: [Intel-gfx] [PATCH 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-08 Thread Modem, Bhanuprakash
On Fri-08-04-2022 08:32 pm, Harry Wentland wrote: On 2022-04-08 02:53, Bhanuprakash Modem wrote: It's useful to know the connector's max supported bpc for IGT testing. Expose it via a debugfs file on the connector "output_bpc". Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc Cc: Jani Ni

Re: [Intel-gfx] [PATCH 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-08 Thread Modem, Bhanuprakash
On Fri-08-04-2022 08:33 pm, Harry Wentland wrote: On 2022-04-08 02:53, Bhanuprakash Modem wrote: As drm_connector already have the display_info, instead of creating "output_bpc" debugfs in vendor specific driver, move the logic to the drm layer. This patch will also move "Current" bpc to the

Re: [Intel-gfx] [PATCH] drm/i915/display/debugfs: Add connector debugfs for "output_bpc"

2022-04-08 Thread Modem, Bhanuprakash
On Mon-04-04-2022 09:11 pm, Daniel Vetter wrote: On Mon, Apr 04, 2022 at 01:46:23PM +0300, Jani Nikula wrote: On Mon, 04 Apr 2022, "Modem, Bhanuprakash" wrote: On Fri-01-04-2022 06:10 pm, Jani Nikula wrote: On Tue, 29 Mar 2022, Bhanuprakash Modem wrote: This new debugfs will

Re: [Intel-gfx] [PATCH] drm/i915/display/debugfs: Add connector debugfs for "output_bpc"

2022-04-04 Thread Modem, Bhanuprakash
On Mon-04-04-2022 04:16 pm, Jani Nikula wrote: On Mon, 04 Apr 2022, "Modem, Bhanuprakash" wrote: On Fri-01-04-2022 06:10 pm, Jani Nikula wrote: On Tue, 29 Mar 2022, Bhanuprakash Modem wrote: This new debugfs will expose the connector's max supported bpc and the bpc current

Re: [Intel-gfx] [PATCH] drm/i915/display/debugfs: Add connector debugfs for "output_bpc"

2022-04-04 Thread Modem, Bhanuprakash
On Fri-01-04-2022 06:10 pm, Jani Nikula wrote: On Tue, 29 Mar 2022, Bhanuprakash Modem wrote: This new debugfs will expose the connector's max supported bpc and the bpc currently using. It is very useful for verifying whether we enter the correct output color depth from IGT. Example: cat /sys/

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

2021-06-21 Thread Modem, Bhanuprakash
> From: Ville Syrjälä > Sent: Wednesday, May 26, 2021 8:08 PM > To: Jani Nikula > Cc: Modem, Bhanuprakash ; intel- > g...@lists.freedesktop.org; Varide, Nischal ; > Shankar, Uma ; Gupta, Anshuman > > Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dit

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

2021-06-10 Thread Modem, Bhanuprakash
> From: Intel-gfx On Behalf Of Vidya > Srinivas > Sent: Tuesday, June 1, 2021 7:38 PM > To: intel-gfx@lists.freedesktop.org; igt-...@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't > set primary fb color in coverage-vs-premult-vs-constant > > Pa

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC

2021-06-08 Thread Modem, Bhanuprakash
> From: Intel-gfx On Behalf Of Vidya > Srinivas > Sent: Friday, May 28, 2021 9:57 AM > To: intel-gfx@lists.freedesktop.org; igt-...@lists.freedesktop.org > Cc: markyac...@chromium.org; Lin, Charlton > Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank > before collecting C

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_color: Disable gamma in degamma tests

2021-06-07 Thread Modem, Bhanuprakash
> From: Srinivas, Vidya > Sent: Monday, June 7, 2021 9:18 AM > To: intel-gfx@lists.freedesktop.org; igt-...@lists.freedesktop.org > Cc: markyac...@chromium.org; Almahallawy, Khaled > ; Lin, Charlton ; > Latvala, Petri ; Modem, Bhanuprakash > ; Shankar, Uma ; > Srinivas, Vi

Re: [Intel-gfx] [PATCH] tests/kms_color: Disable gamma in degamma tests

2021-06-06 Thread Modem, Bhanuprakash
> From: Srinivas, Vidya > Sent: Friday, June 4, 2021 6:41 PM > To: intel-gfx@lists.freedesktop.org; igt-...@lists.freedesktop.org > Cc: markyac...@chromium.org; Almahallawy, Khaled > ; Lin, Charlton ; > Latvala, Petri ; Modem, Bhanuprakash > ; Shankar, Uma ; > Srinivas,

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-06-04 Thread Modem, Bhanuprakash
> From: Intel-gfx On Behalf Of Nischal > Varide > Sent: Wednesday, June 2, 2021 11:48 AM > To: intel-gfx@lists.freedesktop.org; Varide, Nischal > ; Shankar, Uma ; Gupta, > Anshuman ; Nikula, Jani > Subject: [Intel-gfx] [PATCH v2 1/1] drm/i915/xelpd: Enabling dithering after > the CC1 > > If the

Re: [Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Modem, Bhanuprakash
> From: Jani Nikula > Sent: Wednesday, May 26, 2021 7:34 PM > To: Modem, Bhanuprakash ; intel- > g...@lists.freedesktop.org; Varide, Nischal ; > Shankar, Uma ; Gupta, Anshuman > > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after > the CC1

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

2021-05-26 Thread Modem, Bhanuprakash
> From: Jani Nikula > Sent: Wednesday, May 26, 2021 7:57 PM > To: Modem, Bhanuprakash ; intel- > g...@lists.freedesktop.org; Varide, Nischal ; > Shankar, Uma ; Gupta, Anshuman > > Cc: Ville Syrjälä > Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dit

Re: [Intel-gfx] [v8 3/3] drm/debug: Expose connector VRR monitor range via debugfs

2020-06-21 Thread Modem, Bhanuprakash
> -Original Message- > From: Navare, Manasi D > Sent: Saturday, June 20, 2020 12:13 AM > To: Modem, Bhanuprakash > Cc: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: Re: [v8 3/3] drm/debug: Expose connector VRR monitor range via >

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915/dp: Expose connector VRR info via debugfs

2020-05-13 Thread Modem, Bhanuprakash
[Why] It's useful to know the min and max vrr range for IGT testing. [How] Expose the min and max vfreq for the connector via a debugfs file on the connector, "vrr_range". Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range v5: * Rename to vrr_range to match AMD debugfs v4: * Rebase v3: *

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915/dp: Expose connector VRR info via debugfs

2020-05-13 Thread Modem, Bhanuprakash
-Original Message- From: Navare, Manasi D Sent: Wednesday, May 13, 2020 11:05 AM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Modem, Bhanuprakash ; Navare, Manasi D ; Jani Nikula ; Ville Syrjälä Subject: [PATCH v5 3/3] drm/i915/dp: Expose connector VRR info