[Intel-gfx] [PATCH] drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock

2022-11-22 Thread Nischal Varide
Making sure that the mode-clock is not greater than the max_dot_clock freq.This patch will prevent attempts from userspace to modeset with mode->clock greater than max_dot_clock freq. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_dp.c | 10 ++ drivers/gpu/

[Intel-gfx] [PATCH] drm/i915/display: mode clock check related to max dotclk frequency

2022-11-08 Thread Nischal Varide
A check on mode->clock to see if is greater than i915->max_dotclk_freq or greater than 2 * (i915_max_dotclk_freq) in case of big-joiner and return an -EINVAL in both the cases Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_dp.c | 4 1 file changed, 4 inse

[Intel-gfx] [RFC v1 0/1] Enabling Smooth Sync Feature.

2022-08-26 Thread Nischal Varide
a programmable number of scanlines. Nischal Varide (1): INTEL_DII: drm/i915/display: Enabling Smooth Sync Feature. drivers/gpu/drm/i915/display/intel_display.c | 66 ++- .../drm/i915/display/intel_display_types.h| 3 + .../drm/i915/display/skl_universal_plane.c| 31

[Intel-gfx] [PATCH] drm/i915/xelpd: Enabling dithering after the CC1

2021-06-11 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_color.c | 7

[Intel-gfx] [PATCH v3 1/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-06-09 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_color.c | 7

[Intel-gfx] [PATCH v3 0/1] Enabling dithering after the CC1

2021-06-09 Thread Nischal Varide
13 then we can not enable dithering at all.So this v3 version of the patch has added an extra check to fix it. Nischal Varide (1): drm/i915/xelpd: Enabling dithering after the CC1 drivers/gpu/drm/i915/display/intel_color.c | 7 +++ drivers/gpu/drm/i915/display/intel_display.c |

[Intel-gfx] [PATCH v3 1/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-06-09 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_color.c | 7

[Intel-gfx] [PATCH v3 0/1] Enabling dithering after the CC1

2021-06-09 Thread Nischal Varide
13 then we can not enable dithering at all.So this v3 version of the patch has added an extra check to fix it. Nischal Varide (1): drm/i915/xelpd: Enabling dithering after the CC1 drivers/gpu/drm/i915/display/intel_color.c | 7 +++ drivers/gpu/drm/i915/display/intel_display.c |

[Intel-gfx] [PATCH v2 1/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-06-02 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_color.c | 7

[Intel-gfx] [PATCH v2 0/1] Enabling dithering after the CC1

2021-06-02 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. This is Version 2 of the patch, after addresing few review comments. Nischal Varide (1

[Intel-gfx] [PATCH v1 1/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_color.c | 15

[Intel-gfx] [PATCH v1 0/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Nischal Varide (1): drm/i915/xelpd: Enabling dithering after the CC1 drivers/gpu

[Intel-gfx] [PATCH v1 1/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_color.c | 15

[Intel-gfx] [PATCH v1 0/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Nischal Varide (1): drm/i915/xelpd: Enabling dithering after the CC1 drivers/gpu

[Intel-gfx] [RFC v2 1/1] drm/i915/display: New Property Creation for HDMI

2021-05-07 Thread Nischal Varide
Jani) v1: Create new property for vendor and product id of HDMI. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_atomic.c | 14 + .../gpu/drm/i915/display/intel_connector.c| 20 +++ .../gpu/drm/i915/display/intel_connector.h

[Intel-gfx] [RFC v2 0/1] drm/i915/display: New Property Creation for HDMI

2021-05-07 Thread Nischal Varide
lds of the Infoframe structure in the userspace instead of hardcoding in the kernel, and this will help display manufacturers preload picture configurations for the devices. The changes has been Tested by an IGT testcase which got floated. https://patchwork.freedesktop.org/series/89852/. Nischal

[Intel-gfx] [RFC 1/1] drm/i915/display: Expose HDMI properties to userspace

2021-05-06 Thread Nischal Varide
lds of the Infoframe structure in the userspace, instead of hardcoding in the kernel. The changes has been Tested by an IGT testcase , which will be floated in few hours Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_atomic.c | 14 + .../gpu/drm/i915/dis

[Intel-gfx] [RFC 0/1] drm/i915/display: Expose HDMI properties to userspace

2021-05-06 Thread Nischal Varide
lds of the Infoframe structure in the userspace, instead of hardcoding in the kernel. The changes has been Tested by an IGT testcase , which will be floated in few hours Nischal Varide (1): drm/i915/display: Expose HDMI properties to userspace drivers/gpu/drm/i915/display/intel_atomic.c | 14 +

[Intel-gfx] [PATCH 5/5] Fixing a Possible Null Pointer Dereference.

2020-08-24 Thread Nischal Varide
Fixing a Possible Null Pointer Dereference in intel_crt.c. Introduced a Null Check for dev_priv pointer before dereferencing. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_crt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 1/5] Fixing Possible Null Pointer Dereference

2020-08-24 Thread Nischal Varide
There is a possble Null Pointer dereference in intel_atomic.c and this patch fixes the same by introducting a check to old_state, new_state old_conn_state and new_conn_state variables. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_atomic.c | 5 + 1 file changed, 5

[Intel-gfx] [PATCH 4/5] Fixing Possible Null Pointer Dereference.

2020-08-24 Thread Nischal Varide
A possible Null Pointer dereference of new_state,old_state, new_crtc_state pointers from intel_tv.c is handled in this patch. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_tv.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 2/5] Fixing Possible Null Pointer Dereference.

2020-08-24 Thread Nischal Varide
A Possible Null Pointer Dereference of a Pointer obj is handled in intel_displa.c .This patch introduced a check on pointer obj before dereferencing Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_display.c | 22 +++- 1 file changed, 12 insertions(+), 10

[Intel-gfx] [PATCH 3/5] Fixing a Possible Null Pointer Dereference.

2020-08-24 Thread Nischal Varide
This Patch addresses a Possible Null Pointer Dereference of variables new_stae, new_conn_state and old_state, old_conn_state in intel_sdvo.c Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_sdvo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null

2020-08-19 Thread Nischal Varide
This patch fixes Critical Klockwork errors and in this case a Possible Null Pointer Dereferencing is addressed with a Check before Dereferencing Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_sdvo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 5/5] Critical-KlockWorks-Fix-intel_crt.c-Possible-Null

2020-08-19 Thread Nischal Varide
This Patch fixes the Critical KlockWork Errors and here a Possible Null Pointer Dereferencing is addressed with a Null Pointer check before Dereferencing Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_crt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null

2020-08-19 Thread Nischal Varide
This patch fixes the Critical Klock work Error and in this case a Possible Null Pointer Dereference has been addressed with a Null check before dereferencing Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_tv.c | 17 ++--- 1 file changed, 10 insertions(+), 7

[Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref

2020-08-19 Thread Nischal Varide
This Patch fixes the Critical KlockWork Error and here a possible NuLL Pointer dereferencing is addressed. A check has been added before dereferencing. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_display.c | 22 +++- 1 file changed, 12 insertions(+), 10

[Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull

2020-08-19 Thread Nischal Varide
This Patch fixes the Klocwork errors and the Current fix is avoiding Possible Null Pointer Dereference Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_atomic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 8/8] Critical KlockWork Error - Fixes - intel_combo_phy.c Uninitialized Variable-1

2020-08-14 Thread Nischal Varide
--- drivers/gpu/drm/i915/display/intel_combo_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c index eccaa79cb4a9..6e721b8ed611 100644 ---

[Intel-gfx] [PATCH 2/8] Critical KlockWork Error - Fixes - intel_atomic.c - Possible NullPointerDereference1

2020-08-14 Thread Nischal Varide
--- drivers/gpu/drm/i915/display/intel_atomic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c index 630f49b7aa01..49ca65b207df 100644 --- a/drivers/gpu/drm/i915/display/intel_atomic.c +++

[Intel-gfx] [PATCH 6/8] Critical KlockWork Error - Fixes - intel_tv.c - Possible NullPointerDereference1

2020-08-14 Thread Nischal Varide
--- drivers/gpu/drm/i915/display/intel_tv.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c index 777032d9697b..862ea94ffdae 100644 --- a/drivers/gpu/drm/i915/display/intel_tv.c

[Intel-gfx] [PATCH 1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

2020-08-14 Thread Nischal Varide
--- drivers/gpu/drm/i915/display/intel_cdclk.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index 9d6cacbdb691..1cd0ab5b36d2 100644 ---

[Intel-gfx] [PATCH 7/8] Critical KlockWork Error - Fixes - intel_display_power.c - Possible NullPointerDereference2

2020-08-14 Thread Nischal Varide
--- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c index 7946c6af4b1e..9530f6e0b10c 100644 ---

[Intel-gfx] [PATCH 4/8] Critical KlockWork Error - Fixes - intel_display.c - Possible NullPointerDereference1

2020-08-14 Thread Nischal Varide
--- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 2ddabf92adde..30d189094e97 100644 ---

[Intel-gfx] [PATCH 5/8] Critical KlockWork Error - Fixes - intel_sdvo.c - Possible NullPointerDereference1

2020-08-14 Thread Nischal Varide
--- drivers/gpu/drm/i915/display/intel_sdvo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index 2da4388e1540..279b2be958bb 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++

[Intel-gfx] [PATCH 3/8] Critical KlockWork Error - Fixes - intel_fbdev.c - Possible NullPointerDereference1

2020-08-14 Thread Nischal Varide
--- drivers/gpu/drm/i915/display/intel_fbdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index bd39eb6a21b8..ec4f82559fc1 100644 ---