On Mon, Jul 30, 2012 at 10:30:57AM -0700, Eric Anholt wrote:
> I'm perfectly fine with the VUE containing slots for both when the app
> has gone out of its way to ask for deprecated two-sided color
> rendering.
Are you also ok with recompiler the shaders when that enable is
switched?
OG.
_
On Tue, Jul 17, 2012 at 07:37:43AM -0700, Paul Berry wrote:
> If possible, I would still like to think of a way to address this situation
> that (a) doesn't require modifying both fragment shader back-ends and the
> SF program, and (b) helps all Mesa drivers, not just Intel Gen4-5.
> Especially bec
On Thu, Jul 26, 2012 at 10:18:01AM -0700, Eric Anholt wrote:
> Olivier Galibert writes:
>
> > In some cases the fragment shader view of the vue registers was out of
> > sync with the builder. This fixes it.
>
> s/builder/SF outputs/ ?
>
> I'd love to see
On Thu, Jul 26, 2012 at 10:22:26AM -0700, Eric Anholt wrote:
> I don't like seeing this data that should be referenced out of the
> program cache key being communicated through brw->.
What would you like it being communicated through?
OG.
___
Intel-gf
On Fri, Jul 20, 2012 at 10:01:03AM -0700, Eric Anholt wrote:
> > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
> > b/src/mesa/drivers/dri/i965/brw_fs.cpp
> > index 3f98137..3b62952 100644
> > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> > @@ -972,
This patch ensures that integers will pass through unscathed. Doing
(useless) computations on them is risky, especially when their bit
patterns correspond to values like inf or nan.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_clip_util.c | 48
At this point all interpolation tests with fixed clipping work.
Signed-off-by: Olivier Galibert
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/brw_clip.c |9 ++
src/mesa/drivers/dri/i965/brw_clip.h |1 +
src/mesa/drivers/dri/i965/brw_clip_util.c | 147
At that point, all interpolation piglit tests involving fixed clipping
work as long as there's no noperspective.
Signed-off-by: Olivier Galibert
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/brw_clip.c | 13 --
src/mesa/drivers/dri/i965/brw_clip.h |
would require putting
brw_wm_prog before brw_clip_prog and brw_sf_prog. This may be a good
thing, but it could have unexpected consequences, so it's better be
done independently in any case.
Signed-off-by: Olivier Galibert
Reviewed-by: Paul Berry
---
src/mesa/drivers/dri/i965/brw_f
The program keys are updated accordingly, but the values are not used
yet.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_clip.c| 90 ++-
src/mesa/drivers/dri/i965/brw_clip.h|1 +
src/mesa/drivers/dri/i965/brw_context.h | 11
most of the generated piglit tests useless to test the
backface selection, but it's simple and it works.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_fs.cpp |9 +
src/mesa/drivers/dri/i965/brw_wm_pass2.c |9 +
2 files changed, 18 insertions(+)
Previous code only selected two side in pure fixed-function setups.
This version also activates it when needed with shaders programs.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_sf.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers
This patch is mostly designed to make followup patches simpler, but
it's a simplification by itself.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_sf_emit.c | 93 +--
1 file changed, 52 insertions(+), 41 deletions(-)
diff --git a/src
In some cases the fragment shader view of the vue registers was out of
sync with the builder. This fixes it.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_fs.cpp |9 -
src/mesa/drivers/dri/i965/brw_wm_pass2.c | 10 +-
2 files changed, 17 insertions
Hi,
This is the second verion of the clipping/interpolation patches.
Main differences:
- I tried to take all of Paul's remarks into account
- I exploded the first patch in 4 independant ones
- I've added a patch to ensure that integers pass through unscathed
Patch 4/9 is (slightly) controversi
On Mon, Jul 16, 2012 at 08:43:17PM -0700, Paul Berry wrote:
> Also, I'm not convinced that #3 is necessary. Is there something in the
> spec that dictates this behaviour? My reading of the spec is that if the
> vertex shader writes to gl_BackColor but not glFrontColor, then the
> contents of gl_C
On Mon, Jul 16, 2012 at 08:43:17PM -0700, Paul Berry wrote:
> Can you split this into three separate patches? That will make it easier
> to troubleshoot in case we find bugs with these patches in the future.
I'm going to try.
> Also, I'm not convinced that #3 is necessary. Is there something i
On Fri, Jul 13, 2012 at 02:45:10PM -0700, Kenneth Graunke wrote:
> Sorry...been really busy, and most of us haven't actually spent much if
> any time in the clipper shaders. I'll try and review it within a week.
Ok cool, lack of time is something I completely understand :-)
> Despite the lack o
On Sat, Jun 30, 2012 at 08:50:10PM +0200, Olivier Galibert wrote:
> This is the first part of the fixes I've done to make my gm45 work
> correctly w.r.t clipping and interpolation. There's a fair chance
> they work for everything gen 4/5, but I have no way to be sure.
So, n
On Thu, Jul 05, 2012 at 10:10:10AM +0100, Chris Wilson wrote:
> + if (INTEL_INFO(dev)->gen >= 4 && (x|y) & ~4095) {
> + DRM_ERROR("CRTC offset too larget (%d, %d)\n", x, y);
larget?
OG.
___
Intel-gfx mailing list
Intel-gfx@lists.freede
At this point all interpolation tests with fixed clipping work.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_clip.c |9 ++
src/mesa/drivers/dri/i965/brw_clip.h |1 +
src/mesa/drivers/dri/i965/brw_clip_util.c | 133 ++---
3 files
you. The code instead picks whatever slot
was written to by the vertex shader. That makes most of the generated
piglit tests useless to test the backface selection though.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 18 +-
src/mesa/drivers/dri/i965
would require putting
brw_wm_prog before brw_clip_prog and brw_sf_prog. This may be a good
thing, but it could have unexpected consequences, so it's better be
done independently in any case.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_fs.cpp |2 +-
src/mesa/dr
At that point, all interpolation piglit tests involving fixed clipping
work as long as there's no noperspective.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_clip.c | 10 -
src/mesa/drivers/dri/i965/brw_clip.h |6 +--
src/mesa/drivers/dri
Hi,
This is the first part of the fixes I've done to make my gm45 work
correctly w.r.t clipping and interpolation. There's a fair chance
they work for everything gen 4/5, but I have no way to be sure.
[PATCH 1/5] intel gen4-5: fix GL_VERTEX_PROGRAM_TWO_SIDE.
[PATCH 2/5] intel gen4-5: Compute t
The program keys are updated accordingly, but the values are not used
yet.
Signed-off-by: Olivier Galibert
---
src/mesa/drivers/dri/i965/brw_clip.c| 82 ++-
src/mesa/drivers/dri/i965/brw_clip.h|1 +
src/mesa/drivers/dri/i965/brw_context.h | 59
Hi guys,
I'm playing with my gm45, and trying to understand the inter-shader
register allocation and referencing aspects. From what I see, the vs
and clipper follow the brw_vue_map to know where data is. The
fragment shader, though, does its own input register allocation in the
urb_setup array
On Tue, Mar 15, 2011 at 01:32:40PM +, Matthew Garrett wrote:
> Opregion is one mechanism to provide VBT - it doesn't define it.
Then let me repeat that I haven't seen anything in the VBT tables of
the gma500-using netbook I have that didn't seem to be parsed
correctly by the current gpu/drm/i9
On Tue, Mar 15, 2011 at 01:52:26AM +, Matthew Garrett wrote:
> Now that we've got multiple consumers it's probably not helpful to move
> the (potentially chip-specific) VBT handling to general code. We've got
> zero documentation on how GMA500 handles VBT, and not a great deal more
> for i91
29 matches
Mail list logo
