Re: [PATCH 5/8] drm/imx/ipuv3: do not return negative values from .get_modes()

On Fr, 2024-03-08 at 18:03 +0200, Jani Nikula wrote: > The .get_modes() hooks aren't supposed to return negative error > codes. Return 0 for no modes, whatever the reason. > > Cc: Philipp Zabel > Cc: sta...@vger.kernel.org > Signed-off-by: Jani Nikula Acked-by: Philipp Zabel regards Philipp

Re: [PATCH 4/6] drm/imx: prefer snprintf over sprintf

Hi Jani, On Mi, 2024-01-10 at 19:39 +0200, Jani Nikula wrote: > This will trade the W=1 warning -Wformat-overflow to > -Wformat-truncation. This lets us enable -Wformat-overflow subsystem > wide. > > Cc: Philipp Zabel > Signed-off-by: Jani Nikula Reviewed-by: Philipp Zabel regards Philipp

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915: Move abs_diff() to math.h

On Mo, 2023-07-24 at 11:25 +0300, Andy Shevchenko wrote: > abs_diff() belongs to math.h. Move it there. > This will allow others to use it. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Jiri Slaby # tty/serial Reviewed-by: Philipp Zabel # gpu/ipu-v3 regards Philipp

Re: [Intel-gfx] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

gpu_top does not do. > > Signed-off-by: Tvrtko Ursulin > Cc: Rob Clark > Cc: Christian König > Acked-by: Christian König Tested-by: Philipp Zabel on etnaviv with [1]. [1] https://lore.kernel.org/dri-devel/20220916151205.165687-3-l.st...@pengutronix.de/ regards Philipp

Re: [Intel-gfx] [PATCH 09/22] drm/imx: Use drm_mode_duplicate()

t; identifier newmode; > @@ > - newmode = drm_mode_create(dev); > + newmode = drm_mode_duplicate(dev, oldmode); >   ... > - drm_mode_copy(newmode, oldmode); > > Cc: Philipp Zabel > Signed-off-by: Ville Syrjälä Reviewed-by: Philipp Zabel regards Philipp

Re: [Intel-gfx] [PATCH v3 11/27] drm/imx: Don't set struct drm_device.irq_enabled

> - * drivers can well take care of their interrupts > - */ > - drm->irq_enabled = true; > - > /* >* set max width and height as default value(4096x4096). >* this value would be used to check framebuffer size limitation Acked-by: P

Re: [Intel-gfx] [PATCH 08/15] drm/: drm_gem_plane_helper_prepare_fb is now the default

pu_plane_helper_funcs = { > - .prepare_fb = drm_gem_plane_helper_prepare_fb, > .atomic_check = ipu_plane_atomic_check, > .atomic_disable = ipu_plane_atomic_disable, > .atomic_update = ipu_plane_atomic_update, Acked-by: Philipp Zabel regards Philipp _

Re: [Intel-gfx] [PATCH 3/8] drm/imx: Use __drm_atomic_helper_crtc_reset

eans vblank state isn't ill-defined and fail-y at driver load > > > before the first modeset on each crtc. > > > > > > Signed-off-by: Daniel Vetter > > > Cc: Philipp Zabel > > > Cc: Shawn Guo > > > Cc: Sascha Hauer > > > Cc: Pengu

Re: [Intel-gfx] [PATCH 07/13] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

On Wed, 2019-07-31 at 18:58 +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Reviewed-by: Philipp Zabel regards Philipp > ---

Re: [Intel-gfx] [PATCH v6 11/24] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

On Fri, 2019-07-26 at 19:23 +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Philipp Zabel regards Philipp > --- > drivers/gpu/drm/imx/imx-tve.c | 6 -- > 1 file changed,

Re: [Intel-gfx] [PATCH v6 10/24] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

On Fri, 2019-07-26 at 19:23 +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Philipp Zabel Thanks! regards Philipp > --- > drivers/gpu/drm/imx/imx-ldb.c | 7 --- >

Re: [Intel-gfx] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

t; } > > - state->base.crtc = crtc; > + __drm_atomic_helper_crtc_reset(crtc, >base); > } > > static struct drm_crtc_state *mtk_drm_crtc_duplicate_state(struct drm_crtc > *crtc) For the imx-drm and mediatek drivers, Acked-by: Philipp Zabel regards Philipp ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 06/10] drm/imx: Use drm_plane_mask()

On Tue, 2018-06-26 at 22:47 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_plane_mask() where appropriate. > > Cc: Philipp Zabel > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts

behaviour doesn't > change when I start clear out the entire dynamic state with memset(). [...] > drivers/gpu/drm/imx/imx-ldb.c | 4 +- > drivers/gpu/drm/imx/parallel-display.c | 2 +- For imx-drm, Acked-by: Philipp Zabel <p.za...@pengutronix.de>

Re: [Intel-gfx] [PATCH 07/15] drm/mediatek: Use drm_mode_get_hv_timing() to populate plane clip rectangle

no functional changes though, Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 06/15] drm/imx: Use drm_mode_get_hv_timing() to populate plane clip rectangle

ode. The latter is the correct choice since that's the > mode the user provided and it matches the plane crtc coordinates > the user also provided. I am not aware of any adjustments that change hdisplay/vdisplay anyway, Acked-by: Philipp Zabel <p

Re: [Intel-gfx] [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

t; drivers/gpu/drm/imx/parallel-display.c | 1 - > drivers/gpu/drm/mediatek/mtk_dsi.c | 1 - > drivers/gpu/drm/mediatek/mtk_hdmi.c| 1 - Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp __

Re: [Intel-gfx] [PATCH 13/16] drm/mediatek: Convert to new iterator macros

On Wed, 2017-07-12 at 10:13 +0200, Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the new atomic > iterator macros. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: CK Hu <ck...@mediatek.com>

Re: [Intel-gfx] [PATCH v2 06/12] drm/mediatek: Handle drm_atomic_helper_swap_state failure

ux.intel.com> > Cc: CK Hu <ck...@mediatek.com> > Cc: Philipp Zabel <p.za...@pengutronix.de> > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-media...@lists.infradead.org > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7 ++- > 1 file changed, 6 insertio

Re: [Intel-gfx] [PATCH 12/16] drm/imx: Use atomic iterator macros

On Wed, 2017-07-12 at 10:13 +0200, Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the new atomic > iterator macros. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: Philipp Zabel <p.za...@pengutronix.de> &

Re: [Intel-gfx] [PATCH 23/37] drm/imx: Drop drm_vblank_cleanup

;vblank). > Cc: Philipp Zabel <p.za...@pengutronix.de> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > > --- > drivers/gpu/drm/imx/imx-drm-core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx

Re: [Intel-gfx] [PATCH 10/16] drm: Don't call drm_dev_set_unique from platform drivers

drm_dev_alloc() > > we're using a reasonable default which should work for everyone. Only > mtk, rcar-du and sun4i are affected, and as kms-only drivers without > any rendering support no one should ever care about the unique name > > v2: Rebase on top of mediatek. > >

Re: [Intel-gfx] [PATCH 19/35] drm/imx: Use lockless gem BO free callback

Am Mittwoch, den 04.05.2016, 12:28 +0200 schrieb Daniel Vetter: > On Wed, Apr 27, 2016 at 02:01:35PM +0200, Philipp Zabel wrote: > > Am Mittwoch, den 27.04.2016, 13:21 +0200 schrieb Daniel Vetter: > > > On Wed, Apr 27, 2016 at 12:29:34PM +0200, Philipp Zabel wrote: > &

Re: [Intel-gfx] [PATCH 19/35] drm/imx: Use lockless gem BO free callback

Am Mittwoch, den 27.04.2016, 13:21 +0200 schrieb Daniel Vetter: > On Wed, Apr 27, 2016 at 12:29:34PM +0200, Philipp Zabel wrote: > > Am Dienstag, den 26.04.2016, 19:29 +0200 schrieb Daniel Vetter: > > > No dev->struct_mutex anywhere to be seen. > > > > > > C

Re: [Intel-gfx] [PATCH 19/35] drm/imx: Use lockless gem BO free callback

Am Dienstag, den 26.04.2016, 19:29 +0200 schrieb Daniel Vetter: > No dev->struct_mutex anywhere to be seen. > > Cc: Sascha Hauer <s.ha...@pengutronix.de> > Cc: Philipp Zabel <p.za...@pengutronix.de> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>

Re: [Intel-gfx] [PATCH 08/10] drm/imx: Don't set a gamma table size

Hi Daniel, Am Mittwoch, den 30.03.2016, 11:51 +0200 schrieb Daniel Vetter: > imx doesn't have any functions for setting the gamma table, so this is > completely defunct. > > Not nice to lie to userspace, so let's stop! Thank you for the patch. Now the ret variable and the err_register label are

Re: [Intel-gfx] [PATCH 14/22] drm/imx: Unconfuse preclose logic

s confused code without ill side-effects. > > Someone else needs to audit the locking for ->newfb and > ->page_flip_event and fix it up. Common approach is to reuse > dev->event_lock for this. > > Cc: Sascha Hauer <s.ha...@pengutronix.de> > Cc: Philip